Re: [dpdk-dev] [PATCH] ci: exit setup on any error

2019-08-08 Thread Michael Santana Francisco
On Thu, Aug 8, 2019 at 8:22 AM David Marchand wrote: > > -e is preferrable so that we can catch errors in the middle of this > script. > An example is this Travis job [1] that should have errored at the meson > install step rather than go to the build step. > > Adding debug mode as it can help pos

Re: [dpdk-dev] [PATCH v7] doc: add meson ut info in prog guide

2019-08-07 Thread Michael Santana Francisco
On 8/7/19 9:56 AM, Agalya Babu RadhaKrishnan wrote: From: Hari Kumar Vemula Add a programmer's guide section for meson ut Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- v7: Updated v6 patch comments v6: Updated comments v5: Modified v4: Typos corrected v3: Modified v2: Remov

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-07 Thread Michael Santana Francisco
On Mon, Aug 5, 2019 at 2:27 AM David Marchand wrote: > > On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon wrote: > > > > 02/08/2019 23:25, Aaron Conole: > > > This series turns the fast unit tests on for a limited set of > > > builds under the travis build system. An example run is available > >

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-05 Thread Michael Santana Francisco
On Mon, Aug 5, 2019 at 8:52 AM David Marchand wrote: > > On Mon, Aug 5, 2019 at 8:26 AM David Marchand > wrote: > > > > On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon wrote: > > > > > > 02/08/2019 23:25, Aaron Conole: > > > > This series turns the fast unit tests on for a limited set of > > >

Re: [dpdk-dev] [PATCH] test/eal: fix incorrect array sizes

2019-08-02 Thread Michael Santana Francisco
On Thu, Aug 1, 2019 at 3:25 AM David Marchand wrote: > > On Wed, Jul 31, 2019 at 9:57 PM Michael Santana Francisco > wrote: > > > > On Wed, Jul 31, 2019 at 2:56 PM David Marchand > > wrote: > > > > > > Following removal of -c and -n options, the

Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci

2019-08-02 Thread Michael Santana Francisco
On Fri, Aug 2, 2019 at 9:34 AM Aaron Conole wrote: > > Michael Santana Francisco writes: > > > On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote: > >> > >> When building under Travis (or another linux CI service), enable running > >> the > >&g

Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci

2019-07-31 Thread Michael Santana Francisco
On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote: > > When building under Travis (or another linux CI service), enable running the > fast-tests for selected builds. Only the shared builds are enabled at this > point, since they are the ones passing. Builds that are statically linked > still s

Re: [dpdk-dev] [PATCH] test/eal: fix incorrect array sizes

2019-07-31 Thread Michael Santana Francisco
On Wed, Jul 31, 2019 at 2:56 PM David Marchand wrote: > > Following removal of -c and -n options, the array should have been > shrunk to avoid launch_proc to access unitialised strings. > > Fixes: b4dbacdb1ad7 ("test/eal: set core mask/list config only in dedicated > test") > Fixes: 501fa9a40298

Re: [dpdk-dev] [PATCH v3] eal: sort experimental symbols per release

2019-07-29 Thread Michael Santana Francisco
On Sat, Jul 27, 2019 at 3:21 AM David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand > Acked-by: Ferruh Yigit > --- > Changelog since v2: > - fixed alphabetical order per release > >

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 10:06 AM, David Marchand wrote: Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- Changelog since v1: - rte_service symbols who got promoted to stable got reintroduced in experimental when reba

Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 3:09 AM, David Marchand wrote: Hello Michael, On Thu, Jul 25, 2019 at 11:31 PM Michael Santana wrote: This patch reduces the memory footprint of tables for the unit test. Lower memory footprint means the test now passes when trying to allocate the tables. This is mainly for tests i

Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

2019-07-09 Thread Michael Santana Francisco
On Mon, Jul 8, 2019 at 4:18 PM Aaron Conole wrote: > > Thomas Monjalon writes: > > > Hi please find some comments below: > > > > 06/06/2019 13:59, Hari Kumar Vemula: > >> +++ b/doc/guides/prog_guide/meson_ut.rst > >> @@ -0,0 +1,151 @@ > >> +.. SPDX-License-Identifier: BSD-3-Clause > >> + > > > >

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-07-09 Thread Michael Santana Francisco
On 7/1/19 2:07 PM, Michael Santana Francisco wrote: On Mon, Jul 1, 2019 at 6:04 PM Aaron Conole wrote: - rwlock_autotest and hash_readwrite_lf_autotest are taking a little more than 10s, Occasionally the distributor test times out as well. I've moved them as part of a separate

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-07-01 Thread Michael Santana Francisco
> > > > On Mon, Jul 1, 2019 at 6:04 PM Aaron Conole wrote: >> >> >> - rwlock_autotest and hash_readwrite_lf_autotest are taking a little more >> >> than 10s, >> >> Occasionally the distributor test times out as well. I've moved them as >> part of a separate patch, that I'll post along with a bi

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-06 Thread Michael Santana Francisco
On 6/6/19 10:57 AM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: dev On Behalf Of Michael Santana Francisco Sent: Thursday, June 6, 2019 4:09 AM To: Honnappa Nagarahalli ; Aaron Conole ; tho...@monjalon.net Cc: Ruifeng Wang (Arm Technology China) ; Gavin Hu (Arm Technology

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread Michael Santana Francisco
On 6/6/19 10:50 AM, jer...@marvell.com wrote: From: Jerin Jacob Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C language. ../lib/librte_acl/acl_run_

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-05 Thread Michael Santana Francisco
On 6/5/19 5:36 PM, Honnappa Nagarahalli wrote: Thomas Monjalon writes: 05/06/2019 21:40, Aaron Conole: Thomas Monjalon writes: The compilation of the master branch is failing for aarch64: https://travis-ci.com/DPDK/dpdk The log is so much verbose that I am not able to understand wh

Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI

2019-06-04 Thread Michael Santana Francisco
On 6/4/19 4:59 AM, David Marchand wrote: This is a joint effort to make the unit tests ready for CI. The first 8 patches are fixes that I had accumulated. Then the second part of the series focuses on skipping tests when some requirements are not fulfilled so that we can start them in a restraine

Re: [dpdk-dev] [PATCH 2/2] meson: make build configurable

2019-05-29 Thread Michael Santana Francisco
On 5/29/19 12:39 PM, Ilya Maximets wrote: The first thing many developers do before start building DPDK is disabling all the not needed divers and libraries. This happens just because more than a half of DPDK dirvers and libraries are not needed for the particular reason. For example, you don't n

Re: [dpdk-dev] [PATCH] Fix off-by-one errors in snprintf in various files

2019-05-28 Thread Michael Santana Francisco
On 5/10/19 11:28 AM, Burakov, Anatoly wrote: On 10-May-19 3:53 PM, Michael Santana wrote: snprintf guarantees to always correctly place a null terminator in the buffer string. So manually placing a null terminator in a buffer right after a call to snprintf is redundant code. Additionally, the

Re: [dpdk-dev] Hugepages not being deleted

2019-04-29 Thread Michael Santana Francisco
ping Hello, I am currently working on a patch to fix the eal_flags_autotest test as it currently fails on many platforms. I have made some progress, however I stumbled upon a possible issue with EAL and hugepages. Looking at the code and some documentation it appears to me that hupepages are

[dpdk-dev] Hugepages not being deleted

2019-04-23 Thread Michael Santana Francisco
Hello, I am currently working on a patch to fix the eal_flags_autotest test as it currently fails on many platforms. I have made some progress, however I stumbled upon a possible issue with EAL and hugepages. Looking at the code and some documentation it appears to me that hupepages are suppos

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-21 Thread Michael Santana Francisco
On 3/20/19 5:11 PM, Luca Boccassi wrote: On Wed, 2019-03-20 at 15:28 -0400, Michael Santana Francisco wrote: +matrix: + include: + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1 +compiler: gcc +addons: + apt: +packages: + -

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-20 Thread Michael Santana Francisco
Thank you for taking at look at this On 3/20/19 12:01 PM, Thomas Monjalon wrote: Hi, 04/03/2019 17:12, Michael Santana: .ci/linux-build.sh | 21 + .ci/linux-setup.sh | 3 ++ .travis.yml | 73 + Pl

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-14 Thread Michael Santana Francisco
On 3/4/19 1:14 PM, Luca Boccassi wrote: On Mon, 2019-03-04 at 11:12 -0500, Michael Santana wrote: GitHub is a service used by developers to store repositories. GitHub provides service integrations that allow 3rd party services to access developer repositories and perform actions. One of these

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file.

2019-03-04 Thread Michael Santana Francisco
On 3/1/19 4:08 PM, Thomas Monjalon wrote: 01/03/2019 21:24, Michael Santana Francisco: On 3/1/19 12:51 PM, Thomas Monjalon wrote: 01/03/2019 18:43, Thomas Monjalon: 01/03/2019 18:08, Michael Santana: +# Enable codespell by default. This can be overwritten from a config file. +# You can also

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file.

2019-03-01 Thread Michael Santana Francisco
On 3/1/19 12:51 PM, Thomas Monjalon wrote: 01/03/2019 18:43, Thomas Monjalon: 01/03/2019 18:08, Michael Santana: +# Enable codespell by default. This can be overwritten from a config file. +# You can also enable codespell by setting DPDK_CHECKPATCH_CODESPELL to a valid path +# to a dictionary.

Re: [dpdk-dev] [PATCH v2 1/2] Enable codespell by default. Can be disabled from config file.

2019-02-28 Thread Michael Santana Francisco
On 2/28/19 6:21 AM, Thomas Monjalon wrote: 14/02/2019 20:35, Michael Santana: Enable codespell by default. codespell is a feature by checkpatch.pl that checks for common spelling mistakes in patches. What is the difference between codespell and spelling.txt included with checkpatch? Is it just

Re: [dpdk-dev] [PATCH v5 0/2] Introduce travis support

2019-02-14 Thread Michael Santana Francisco
On 2/7/19 5:01 PM, Michael Santana wrote: ping This series introduces the ability for any github mirrors of the DPDK project, including developer mirrors, to kick off builds under the travis CI infrastructure. For now, this just means compilation - no other kinds of automated run exists yet. In

Re: [dpdk-dev] [PATCH] Introduce travis builds for github repositories

2019-01-24 Thread Michael Santana Francisco
That's a good suggestion. I will look into it. ~Michael Santana On Thu, Jan 24, 2019 at 2:27 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > GitHub is a service used by developers to store repositories. GitHub > > provides service integrations that allow 3rd party service