Re: [dpdk-dev] [EXTERNAL] [PATCH v3 7/7] eal/windows: do not expose POSIX symbols

2021-03-04 Thread Khoa To
gned-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 6/7] drivers: remove POSIX dependencies

2021-03-04 Thread Khoa To
> Replace POSIX strncasecmp() with EAL rte_strncasecmp(). > Replace POSIX strtok_r() with EAL rte_strtok(). > Replace POSIX strdup() with EAL rte_strdup(). > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 4/7] eal: add asprintf() internal wrapper

2021-03-04 Thread Khoa To
> POSIX asprintf() is unavailable on Windows. > Add eal_asprintf() wrapper for EAL internal use. > On Windows it's a function, on Unix it's a macro for asprintf(). > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 5/7] lib: remove POSIX dependencies

2021-03-04 Thread Khoa To
> Replace POSIX strtok_r() with EAL rte_strtok(). > Replace POSIX strdup() with EAL rte_strdup(). > Locally rename Windows _close() to standard close(). > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 3/7] eal: add sleep API

2021-03-04 Thread Khoa To
> POSIX sleep(3) is missing from Windows. > Add generic rte_thread_sleep() to suspend current OS thread. > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 1/7] eal: add wrappers for POSIX string functions

2021-03-04 Thread Khoa To
mentation is trivial. > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 2/7] eal: add macro for maximum path length

2021-03-04 Thread Khoa To
> Path length limit is PATH_MAX on Unix and _MAX_PATH on Windows. > Add RTE_PATH_MAX macro for use in OS-independent code. Keep > PATH_MAX > in "common" multiprocess code, because it's really Unix-specific. > > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v3 0/7] eal/windows: do not expose POSIX symbols

2021-03-04 Thread Khoa To
reventing issues rather then solving direct ones. > > v3: > * Fix indentation in 3/7 (Tal Shnaiderman). > * Fix build failures in 6/7 and 7/7 (Tal Shnaiderman). > v2: > * Fix compilation issues in 3/7 and 6/7 (self). > Acked-by: Khoa To

Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-03-03 Thread Khoa To
On Wed, 3 Mar 2021, Ranjit Menon wrote: On 2/28/2021 10:52 PM, Khoa To wrote: EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch

[dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-28 Thread Khoa To
during PCI bus scan. Signed-off-by: Khoa To --- v4: * Fix coding style warning with unaligned comments v3: * Move the check inside pci_scan_one * Small change to pci_scan_one to malloc only after checks succeeded v2: * Truncate commit description lines to 75 charaters or less drivers/bus/pci

[dpdk-dev] [PATCH v3] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-28 Thread Khoa To
during PCI bus scan. Signed-off-by: Khoa To --- v3: * Move the check inside pci_scan_one * Small change to pci_scan_one to malloc only after checks succeeded v2: * Truncate commit description lines to 75 charaters or less drivers/bus/pci/windows/pci.c | 23 --- 1 file changed

[dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-18 Thread Khoa To
during PCI bus scan. Signed-off-by: Khoa To --- v2: * Truncate commit description lines to 75 charaters or less drivers/bus/pci/windows/pci.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c index f66258452..0bba05eb4 100644

[dpdk-dev] [PATCH] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-17 Thread Khoa To
From: Khoa To EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides this missing functionality, so that apps can specify which NetUIO

Re: [dpdk-dev] [EXTERNAL] [PATCH v3] mlx5: split multi-threaded flows per OS

2021-01-11 Thread Khoa To
| 10 ++ > drivers/net/mlx5/windows/mlx5_flow_os.c | 178 > > 6 files changed, 240 insertions(+), 24 deletions(-) Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [PATCH v2] windows: minor build fixes

2020-11-06 Thread Khoa To
dled between 0.47.1 and 0.54.0. Only make the change > for >= 0.54.0, leaving the behaviour unchanged for earlier > versions. > > Signed-off-by: Nick Connolly > Tested-by: Ranjit Menon > Acked-by: Ranjit Menon > --- > v2: > * split out config/meson.build change > Acked-by: Khoa To

Re: [dpdk-dev] [EXTERNAL] [RFC] pthread on Windows

2020-11-03 Thread Khoa To
+Dmitry, Harini Hi Nick, > -Original Message- > From: Nick Connolly > Sent: Monday, November 2, 2020 3:17 AM > To: Khoa To ; dev@dpdk.org > Subject: Re: [EXTERNAL] [dpdk-dev] [RFC] pthread on Windows > > Hi Khoa, > > On 29/10/2020 21:19, Khoa To wrote:

Re: [dpdk-dev] [EXTERNAL] [RFC] pthread on Windows

2020-10-29 Thread Khoa To
Hi Nick, > -Original Message- > From: dev On Behalf Of Nick Connolly > Sent: Monday, October 19, 2020 2:59 AM > To: dev@dpdk.org > Subject: [EXTERNAL] [dpdk-dev] [RFC] pthread on Windows > > > The proposed changes are: > > 1. An EAL implementation of pthread with a new rte_pthread API

Re: [dpdk-dev] [EXTERNAL] [PATCH v2 7/7] examples/cmdline: build on Windows

2020-09-26 Thread Khoa To
> -Original Message- > From: Dmitry Kozlyuk > > diff --git a/examples/meson.build b/examples/meson.build index > eb13e8210..2b8ebce3b 100644 > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -79,9 +79,9 @@ foreach example: examples > > ext_deps = [execinfo] > i

Re: [dpdk-dev] [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW

2020-09-25 Thread Khoa To
> -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, September 24, 2020 4:17 PM > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; sta...@dpdk.org; Khoa To > ; Tal Shnaiderman ; Narcisa Ana > Maria Vasile ; Dmitry Malloy > (MESHCHANINOV) ; Pallavi Kadam > &

Re: [dpdk-dev] [EXTERNAL] [PATCH 2/2] eal/windows: implement alarm API

2020-09-24 Thread Khoa To
> -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, September 24, 2020 2:39 PM > To: Khoa To > Cc: dev@dpdk.org; Narcisa Ana Maria Vasile > ; Dmitry Malloy (MESHCHANINOV) > ; Pallavi Kadam > Subject: Re: [EXTERNAL] [dpdk-dev] [PATCH 2/2] eal/window

Re: [dpdk-dev] [EXTERNAL] [PATCH 2/2] eal/windows: implement alarm API

2020-09-21 Thread Khoa To
Hi Dmitry, Since all alarm callbacks are scheduled on the interrupt thread, looks like this implementation of rte_eal_alarm_set() would create a head-of-line blocking issue, as the callbacks are serialized one after the other. Is that correct? If so, while this does not violate the API contract