Re: [PATCH 2/2] test/power_intel_uncore: skip test if init fails

2025-05-21 Thread Kevin Laatz
tates. Signed-off-by: Bruce Richardson --- app/test/test_power_intel_uncore.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver

2025-05-21 Thread Kevin Laatz
s/power/intel_uncore/intel_uncore.c | 35 --- 1 file changed, 18 insertions(+), 17 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH] doc/dmadevs: clarify naming constraints for idxd devices

2025-02-18 Thread Kevin Laatz
: Kevin Laatz

Re: [PATCH] dma/idxd: add device ids for new HW versions

2025-02-11 Thread Kevin Laatz
/dpdk-devbind.py | 7 ++- 2 files changed, 10 insertions(+), 1 deletion(-) Acked-by: Kevin Laatz

[PATCH] test/dma: fix api testuite teardown

2024-03-11 Thread Kevin Laatz
ned-off-by: Kevin Laatz --- app/test/test_dmadev_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c index a130e74b51..d40c05cfbf 100644 --- a/app/test/test_dmadev_api.c +++ b/app/test/test_dmadev_api.c @@ -82,6 +82,7 @@ testsuite_tea

Re: [PATCH v3 3/7] dma/idxd: replace rte atomics with GCC builtin atomics

2023-05-25 Thread Kevin Laatz
, 6 insertions(+), 5 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 5/6] test/dmadev: create separate function for single copy test

2023-02-14 Thread Kevin Laatz
/test_dmadev.c | 120 ++--- 1 file changed, 64 insertions(+), 56 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 2/6] dma/ioat: fix incorrectly set indexes after restart

2023-02-14 Thread Kevin Laatz
start and stop") Cc: conor.wa...@intel.com Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 7 +++ 1 file changed, 7 insertions(+) Acked-by: Kevin Laatz

Re: [PATCH v2 1/6] dma/ioat: fix device stop if no copies done

2023-02-14 Thread Kevin Laatz
Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 6/6] test/dmadev: add tests for stopping and restarting dev

2023-02-14 Thread Kevin Laatz
. Take account of both possibilities in the test case. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 46 ++ 1 file changed, 46 insertions(+) Acked-by: Kevin Laatz

Re: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart

2023-02-14 Thread Kevin Laatz
ions(+), 2 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH v2 4/6] test/dmadev: check result for device stop

2023-02-14 Thread Kevin Laatz
On 16/01/2023 17:37, Bruce Richardson wrote: The DMA device stop API can return an error value so check that return value when running dmadev unit tests. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Acked-by: Kevin

Re: [PATCH v2] bus: fix leak for devices without driver

2023-02-10 Thread Kevin Laatz
nsertions(+), 3 deletions(-) Acked-by: Kevin Laatz

Re: [PATCH] bus: fix leak for devices without driver

2023-02-08 Thread Kevin Laatz
Hi Volodymyr, On 07/01/2023 15:12, Volodymyr Fialko wrote: For devices not assigned to any driver, we leak a pci device object since it is never freed from the PCI bus device list, reported by ASAN. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by: Volodymyr Fialko ---

Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Kevin Laatz
{ "lcore_ids": [ 4, 5 ], "total_cycles": [ 23846845590, 23900558914 ], "busy_cycles": [ 21043446682, 21448837316 ] } } Cc: Kevin Laatz Cc: Morten Brørup Signed-off-by: Robin Jarry

Re: [PATCH v6 4/5] testpmd: report lcore usage

2023-01-19 Thread Kevin Laatz
++ app/test-pmd/rxonly.c | 5 +++-- app/test-pmd/shared_rxq_fwd.c | 5 +++-- app/test-pmd/testpmd.c| 39 ++- app/test-pmd/testpmd.h| 14 + app/test-pmd/txonly.c | 7 --- 13 files changed, 81 insertions(+), 27 deletions(-) Reviewed-by: Kevin Laatz

Re: [PATCH v6 3/5] testpmd: add dump_lcores command

2023-01-19 Thread Kevin Laatz
-by: Kevin Laatz

Re: [PATCH v6 2/5] eal: allow applications to report their cpu usage

2023-01-19 Thread Kevin Laatz
35 lib/eal/version.map | 1 + 3 files changed, 78 insertions(+), 3 deletions(-) Reviewed-by: Kevin Laatz

Re: [PATCH v6 1/5] eal: add lcore info in telemetry

2023-01-19 Thread Kevin Laatz
ket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-by: Robin Jarry Acked-by: Morten Brørup --- Notes: v5 -> v6: No change lib/eal/common/eal_common_lcore.c | 96 +++ 1 file changed, 96 insertions(+) Reviewed-by: Kevin Laatz

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 14:45, Robin Jarry wrote: Kevin Laatz, Jan 18, 2023 at 10:42: Hi Robin, Thanks for taking the time to work on this. It is a good implementation for debug use-cases. I have 2 suggestions which would improve the usability of the data: 1. Could we make the lcore_id paramater on

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 10:21, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 18 January 2023 10.42 To: Robin Jarry; dev@dpdk.org Cc: Tyler Retzlaff; Morten Brørup Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry On 16/12/2022 10:21, Robin Jarry wrote

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 16/12/2022 10:21, Robin Jarry wrote: Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cp

[PATCH v2] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
uot;) Signed-off-by: Kevin Laatz --- v2: remove redundant NULL checks --- drivers/bus/pci/pci_common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7f598667fe..71cd3f59ad 100644 --- a/drivers/bus/pci/pci_common

[PATCH] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
uot;) Signed-off-by: Kevin Laatz --- drivers/bus/pci/pci_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7f598667fe..330a41ed12 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-05 Thread Kevin Laatz
On 14/09/2022 10:29, Kevin Laatz wrote: Currently, there is no way to measure lcore polling busyness in a passive way, without any modifications to the application. This patchset adds a new EAL API that will be able to passively track core polling busyness. As part of the set, new telemetry

Re: [PATCH v9] eal: add bus cleanup to eal cleanup

2022-10-05 Thread Kevin Laatz
Hi Thomas, All, On 05/10/2022 10:41, Thomas Monjalon wrote: 05/10/2022 09:45, David Marchand: On Tue, Oct 4, 2022 at 6:47 PM Kevin Laatz wrote: This patch proposes adding bus cleanup to the eal_cleanup() to make EAL's init/exit more symmetrical, ensuring all bus devices are clean

[PATCH v9] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
r bus maintainers to add the relevant cleanup for their buses since they have the domain expertise. Signed-off-by: Kevin Laatz Acked-by: Morten Brørup Reviewed-by: Bruce Richardson --- v9: * move bus cleanup before trace save and uninitialize v8: * rebase v7: * free rte_pci_device structs d

Re: [PATCH v8] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
On 04/10/2022 16:28, David Marchand wrote: On Tue, Oct 4, 2022 at 3:08 PM Kevin Laatz wrote: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up

[PATCH v8] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
r bus maintainers to add the relevant cleanup for their buses since they have the domain expertise. Signed-off-by: Kevin Laatz Acked-by: Morten Brørup Reviewed-by: Bruce Richardson --- v8: * rebase v7: * free rte_pci_device structs during cleanup * free rte_vdev_device structs during cleanu

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-10-03 Thread Kevin Laatz
Hi David, On 03/10/2022 13:35, David Marchand wrote: Hello Bruce, Kevin, On Mon, Jun 13, 2022 at 5:59 PM Bruce Richardson wrote: For info, Li has sent a patch for the bus cleanup which is not updating the bus code: https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-3-l...@nvidi

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-29 Thread Kevin Laatz
On 26/09/2022 10:37, Konstantin Ananyev wrote: Hi Kevin, Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. The poll busyness is calc

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-22 Thread Kevin Laatz
On 19/09/2022 11:19, Konstantin Ananyev wrote: Hi everyone, From: Anatoly Burakov Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness.

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-09-16 Thread Kevin Laatz
On 16/09/2022 13:35, Kevin Laatz wrote: On 14/09/2022 15:33, Stephen Hemminger wrote: On Wed, 14 Sep 2022 10:29:25 +0100 Kevin Laatz wrote: Currently, there is no way to measure lcore polling busyness in a passive way, without any modifications to the application. This patchset adds a new

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-09-16 Thread Kevin Laatz
On 14/09/2022 15:33, Stephen Hemminger wrote: On Wed, 14 Sep 2022 10:29:25 +0100 Kevin Laatz wrote: Currently, there is no way to measure lcore polling busyness in a passive way, without any modifications to the application. This patchset adds a new EAL API that will be able to passively

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-16 Thread Kevin Laatz
On 14/09/2022 15:30, Stephen Hemminger wrote: On Wed, 14 Sep 2022 10:29:26 +0100 Kevin Laatz wrote: +struct lcore_poll_telemetry { + int poll_busyness; + /**< Calculated poll busyness (gets set/returned by the API) */ + int raw_poll_busyness; + /**< Calculate

[PATCH v7 4/4] doc: add howto guide for lcore poll busyness

2022-09-14 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- v6: * Add mention of perf autotest in note mentioning perf impact. v4: * Include note on perf impact when the feature is enabled

[PATCH v7 3/4] app/test: add unit tests for lcore poll busyness

2022-09-14 Thread Kevin Laatz
Add API unit tests and perf unit tests for the newly added lcore poll busyness feature. Signed-off-by: Kevin Laatz --- app/test/meson.build | 4 + app/test/test_lcore_poll_busyness_api.c | 134 +++ app/test/test_lcore_poll_busyness_perf.c | 72

[PATCH v7 2/4] eal: add cpuset lcore telemetry entries

2022-09-14 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- .../common/eal_common_lcore_poll_telemetry.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_poll_telemetry.c b/lib/eal/common/e

[PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-14 Thread Kevin Laatz
to the howto guides to explain the usage of the new telemetry endpoints and API. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signed-off-by: David Hunt Signed-off-by: Anatoly Burakov --- v7: * Rename funcs, vars, files to include "poll" where missing. v5: * Fix Win

[PATCH v7 0/4] Add lcore poll busyness telemetry

2022-09-14 Thread Kevin Laatz
uset lcore telemetry entries Kevin Laatz (2): app/test: add unit tests for lcore poll busyness doc: add howto guide for lcore poll busyness app/test/meson.build | 4 + app/test/test_lcore_poll_busyness_api.c | 134 +++ app/test/test_lcore_poll_busyn

[PATCH v6 4/4] doc: add howto guide for lcore poll busyness

2022-09-13 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- v6: * Add mention of perf autotest in note mentioning perf impact. v4: * Include note on perf impact when the feature is enabled

[PATCH v6 3/4] app/test: add unit tests for lcore poll busyness

2022-09-13 Thread Kevin Laatz
Add API unit tests and perf unit tests for the newly added lcore poll busyness feature. Signed-off-by: Kevin Laatz --- app/test/meson.build | 4 + app/test/test_lcore_poll_busyness_api.c | 134 +++ app/test/test_lcore_poll_busyness_perf.c | 72

[PATCH v6 2/4] eal: add cpuset lcore telemetry entries

2022-09-13 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_co

[PATCH v6 1/4] eal: add lcore poll busyness telemetry

2022-09-13 Thread Kevin Laatz
to the howto guides to explain the usage of the new telemetry endpoints and API. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signed-off-by: David Hunt Signed-off-by: Anatoly Burakov --- v5: * Fix Windows build * Make lcore_telemetry_free() an internal interface * Minor cleanu

[PATCH v6 0/4] Add lcore poll busyness telemetry

2022-09-13 Thread Kevin Laatz
polling busyness vs general busyness * Fix segfault when calling telemetry timestamp from an unregistered non-EAL thread. * Minor cleanup Anatoly Burakov (2): eal: add lcore poll busyness telemetry eal: add cpuset lcore telemetry entries Kevin Laatz (2): app/test: add unit tests for

Re: [PATCH v5 1/3] eal: add lcore poll busyness telemetry

2022-09-06 Thread Kevin Laatz
On 03/09/2022 14:33, Jerin Jacob wrote: On Fri, Sep 2, 2022 at 9:26 PM Kevin Laatz wrote: From: Anatoly Burakov Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to

[PATCH v5 3/3] doc: add howto guide for lcore poll busyness

2022-09-02 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- v4: * Include note on perf impact when the feature is enabled * Add doc to toctree * Updates to incorporate changes made earlier in

[PATCH v5 2/3] eal: add cpuset lcore telemetry entries

2022-09-02 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_co

[PATCH v5 1/3] eal: add lcore poll busyness telemetry

2022-09-02 Thread Kevin Laatz
to the howto guides to explain the usage of the new telemetry endpoints and API. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signed-off-by: David Hunt Signed-off-by: Anatoly Burakov --- v5: * Fix Windows build * Make lcore_telemetry_free() an internal interface * Minor cleanu

[PATCH v5 0/3] Add lcore poll busyness telemetry

2022-09-02 Thread Kevin Laatz
* Fix segfault when calling telemetry timestamp from an unregistered non-EAL thread. * Minor cleanup Anatoly Burakov (2): eal: add lcore poll busyness telemetry eal: add cpuset lcore telemetry entries Kevin Laatz (1): doc: add howto guide for lcore poll busyness config/meson.build

[PATCH v4 3/3] doc: add howto guide for lcore poll busyness

2022-09-01 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- v4: * Include note on perf impact when the feature is enabled * Add doc to toctree * Updates to incorporate changes made earlier in

[PATCH v4 2/3] eal: add cpuset lcore telemetry entries

2022-09-01 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_co

[PATCH v4 1/3] eal: add lcore poll busyness telemetry

2022-09-01 Thread Kevin Laatz
to the howto guides to explain the usage of the new telemetry endpoints and API. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signed-off-by: David Hunt Signed-off-by: Anatoly Burakov --- v4: * Fix doc build * Rename timestamp macro to RTE_LCORE_TELEMETRY_TIMESTAMP * Make e

[PATCH v4 0/3] Add lcore poll busyness telemetry

2022-09-01 Thread Kevin Laatz
cleanup Anatoly Burakov (2): eal: add lcore poll busyness telemetry eal: add cpuset lcore telemetry entries Kevin Laatz (1): doc: add howto guide for lcore poll busyness config/meson.build | 1 + config/rte_config.h | 1 + doc/guides/howto

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-30 Thread Kevin Laatz
On 26/08/2022 23:06, Mattias Rönnblom wrote: On 2022-08-25 17:28, Kevin Laatz wrote: From: Anatoly Burakov To avoid performance impact from having lcore telemetry support, a global variable is exported by EAL, and a call to timestamping function is wrapped into a macro, so that whenever

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-29 Thread Kevin Laatz
On 29/08/2022 14:44, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Monday, 29 August 2022 15.37 On 29/08/2022 13:49, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Monday, 29 August 2022 14.37 The patches currently include runtime

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-29 Thread Kevin Laatz
On 29/08/2022 13:49, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Monday, 29 August 2022 14.37 The patches currently include runtime options to enable/disable the feature via API and via telemetry endpoints. We have run performance tests and have failed to

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-29 Thread Kevin Laatz
On 26/08/2022 23:06, Mattias Rönnblom wrote: On 2022-08-25 17:28, Kevin Laatz wrote: From: Anatoly Burakov Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-29 Thread Kevin Laatz
On 29/08/2022 11:53, Thomas Monjalon wrote: 29/08/2022 12:41, Bruce Richardson: On Fri, Aug 26, 2022 at 05:46:48PM +0200, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Friday, 26 August 2022 17.27 On 26/08/2022 09:29, Morten Brørup wrote: From: Jerin Jacob

Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-26 Thread Kevin Laatz
On 26/08/2022 09:29, Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Friday, 26 August 2022 10.16 On Fri, Aug 26, 2022 at 1:37 PM Bruce Richardson wrote: On Fri, Aug 26, 2022 at 12:35:16PM +0530, Jerin Jacob wrote: On Thu, Aug 25, 2022 at 8:56 PM Kevin Laatz

[PATCH v3 3/3] doc: add howto guide for lcore poll busyness

2022-08-25 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- v3: update naming to poll busyness --- doc/guides/howto/lcore_busyness.rst | 79 + 1 file changed, 79

[PATCH v3 2/3] eal: add cpuset lcore telemetry entries

2022-08-25 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_co

[PATCH v3 1/3] eal: add lcore poll busyness telemetry

2022-08-25 Thread Kevin Laatz
dded to the howto guides to explain the usage of the new telemetry endpoints and API. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signed-off-by: David Hunt Signed-off-by: Anatoly Burakov --- v3: * Fix missed renaming to poll busyness * Fix clang compilation * Fix arm compilati

[PATCH v3 0/3] Add lcore poll busyness telemetry

2022-08-25 Thread Kevin Laatz
non-EAL thread. * Minor cleanup Anatoly Burakov (2): eal: add lcore poll busyness telemetry eal: add cpuset lcore telemetry entries Kevin Laatz (1): doc: add howto guide for lcore poll busyness config/meson.build | 1 + config/rte_config.h

Re: [PATCH v2 0/3] Add lcore poll busyness telemetry

2022-08-25 Thread Kevin Laatz
On 25/08/2022 08:47, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 24 August 2022 18.25 Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patchset adds a new EAL API that will be

[PATCH v2 2/3] eal: add cpuset lcore telemetry entries

2022-08-24 Thread Kevin Laatz
From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_co

[PATCH v2 1/3] eal: add lcore poll busyness telemetry

2022-08-24 Thread Kevin Laatz
t is also possible to disable it at compile time by commenting out RTE_LCORE_BUSYNESS from build config. This patch also adds a telemetry endpoint to report lcore busyness, as well as telemetry endpoints to enable/disable lcore telemetry. Signed-off-by: Kevin Laatz Signed-off-by: Conor Walsh Signe

[PATCH v2 0/3] Add lcore poll busyness telemetry

2022-08-24 Thread Kevin Laatz
Burakov (2): eal: add lcore poll busyness telemetry eal: add cpuset lcore telemetry entries Kevin Laatz (1): doc: add howto guide for lcore poll busyness config/meson.build | 1 + config/rte_config.h | 1 + doc/guides/howto

[PATCH v2 3/3] doc: add howto guide for lcore poll busyness

2022-08-24 Thread Kevin Laatz
Add a new section to the howto guides for using the new lcore poll busyness telemetry endpoints and describe general usage. Signed-off-by: Kevin Laatz --- doc/guides/howto/lcore_busyness.rst | 79 + 1 file changed, 79 insertions(+) create mode 100644 doc/guides

Re: [PATCH v2] examples/dma: support DMA dequeue when no packet received

2022-07-26 Thread Kevin Laatz
Signed-off-by: Chengwen Feng --- examples/dma/dmafwd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Acked-by: Kevin Laatz

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-12 Thread Kevin Laatz
: Kevin Laatz

[PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove

2022-07-04 Thread Kevin Laatz
laring 'info' on the stack and passing its address to 'rte_dma_info_get'. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/idxd_pci.c | 8 1

[PATCH v3 2/3] dma/idxd: fix memory leak due to free on incorrect pointer

2022-07-04 Thread Kevin Laatz
0a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_pc

[PATCH v3 1/3] dma/idxd: fix memory leak in pci close

2022-07-04 Thread Kevin Laatz
.org Cc: bruce.richard...@intel.com Reported-by: Xingguang He Signed-off-by: Kevin Laatz -- v3: move ref_count increment to pci probe --- drivers/dma/idxd/idxd_internal.h | 2 ++ drivers/dma/idxd/idxd_pci.c | 35 +--- 2 files changed, 30 insertions(+), 7 deletion

[PATCH v3 0/3] Fix IDXD PCI device close

2022-07-04 Thread Kevin Laatz
ULL pointer dereference in pci remove Kevin Laatz (3): dma/idxd: fix memory leak in pci close dma/idxd: fix memory leak due to free on incorrect pointer dma/idxd: fix null pointer dereference during pci remove drivers/dma/idxd/idxd_internal.h | 2 ++ drivers

Re: [PATCH] doc: announce marking bus object as internal

2022-07-04 Thread Kevin Laatz
RFC series of the intended changes is available at: https://patches.dpdk.org/project/dpdk/list/?series=23811&state=%2A&archive=both --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) Acked-by: Kevin Laatz

Re: [PATCH v2 1/3] dma/idxd: fix memory leak in pci close

2022-07-04 Thread Kevin Laatz
On 04/07/2022 14:19, Bruce Richardson wrote: On Sun, Jul 03, 2022 at 01:22:41PM +0100, Kevin Laatz wrote: ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev' struct. This is fixed by free'ing the struct when the last queue on the PCI devic

[PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove

2022-07-03 Thread Kevin Laatz
aring 'info' as a variable and passing its address to 'rte_dma_info_get'. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_pci.c | 8 1 file changed, 4 insertions(+)

[PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer

2022-07-03 Thread Kevin Laatz
ak by calling free on the correct pointer. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH v2 1/3] dma/idxd: fix memory leak in pci close

2022-07-03 Thread Kevin Laatz
.org Cc: bruce.richard...@intel.com Reported-by: Xingguang He Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_common.c | 2 ++ drivers/dma/idxd/idxd_internal.h | 2 ++ drivers/dma/idxd/idxd_pci.c | 34 +--- 3 files changed, 31 insertions(+), 7 deletion

[PATCH v2 0/3] Fix IDXD PCI device close

2022-07-03 Thread Kevin Laatz
nsure the cleanup is completed correctly. Depends-on: patch-112376 ("eal: add device removal in rte cleanup") --- v2: * remove changes to applications (no longer needed with EAL changes) * add fix for NULL pointer dereference in pci remove Kevin Laatz (3): dma/idxd: fix memory leak in pc

Re: [PATCH] dma/idxd: fix return value for pci device commands

2022-06-08 Thread Kevin Laatz
negated before being returned by the function, meaning error codes cannot be checked against the HW specification. This patch fixes the return values of the function by removing the negation. Signed-off-by: Kevin Laatz Acked-by: Conor Walsh Fixes: 9449330a8458 ("dma/idxd: create d

Re: [PATCH v6] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Kevin Laatz
On 02/06/2022 03:06, lihuisong (C) wrote: Hi Kevin, 在 2022/6/2 1:02, Kevin Laatz 写道: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up

[PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Kevin Laatz
r bus maintainers to add the relevant cleanup for their buses since they have the domain expertise. Signed-off-by: Kevin Laatz Acked-by: Morten Brørup Reviewed-by: Bruce Richardson --- v7: * free rte_pci_device structs during cleanup * free rte_vdev_device structs during cleanup v6: * fix units i

[PATCH v6 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-06-02 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin

[PATCH v6 4/4] examples/l3fwd_power: add cli for configurable options

2022-06-02 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz Acked-by: Anatoly Burakov --- v3: move

[PATCH v6 2/4] lib/power: add get and set API for pause duration

2022-06-02 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hunt --- v6: fix unit of pause duration in doc v5: add doc entry for new API v

[PATCH v6 1/4] lib/power: add get and set API for emptypoll max

2022-06-02 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Tested-by: David Hunt --- v5: add doc entry for new API --- doc/guides/prog_guide/power_man.rst | 6 ++ lib/power

[PATCH v6 0/4] Add APIs for configurable power options

2022-06-02 Thread Kevin Laatz
er * order version.map additions alphabetically Kevin Laatz (4): lib/power: add get and set API for emptypoll max lib/power: add get and set API for pause duration lib/power: add get and set API for scaling freq min and max with pstate mode examples/l3fwd_power: add cli for configurable opt

Re: [PATCH v5 2/4] lib/power: add get and set API for pause duration

2022-06-02 Thread Kevin Laatz
On 02/06/2022 15:01, Burakov, Anatoly wrote: On 31-May-22 10:59 AM, Kevin Laatz wrote: Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested

Re: [PATCH 0/5] Fix IDXD PCI device close

2022-06-01 Thread Kevin Laatz
On 31/05/2022 17:37, Kevin Laatz wrote: On 31/05/2022 17:17, Thomas Monjalon wrote: Kevin Laatz (5):    dma/idxd: fix memory leak in pci close    dma/idxd: fix memory leak due to free on incorrect pointer    app/test: close dma devices during cleanup    app/testpmd: stop and close dmadevs at

[PATCH v6] eal: add bus cleanup to eal cleanup

2022-06-01 Thread Kevin Laatz
r bus maintainers to add the relevant cleanup for their buses since they have the domain expertise. Signed-off-by: Kevin Laatz Acked-by: Morten Brørup --- v6: * add bus_cleanup to eal_cleanup for FreeBSD * add bus_cleanup to eal_cleanup for Windows * remove bus cleanup function to remove rte_ p

Re: [PATCH 0/5] Fix IDXD PCI device close

2022-05-31 Thread Kevin Laatz
On 31/05/2022 17:17, Thomas Monjalon wrote: Kevin Laatz (5): dma/idxd: fix memory leak in pci close dma/idxd: fix memory leak due to free on incorrect pointer app/test: close dma devices during cleanup app/testpmd: stop and close dmadevs at exit examples/dma: fix missing dma close

[PATCH v5 4/4] examples/l3fwd_power: add cli for configurable options

2022-05-31 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz Acked-by: Anatoly Burakov --- v3: move

[PATCH v5 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-05-31 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin

[PATCH v5 2/4] lib/power: add get and set API for pause duration

2022-05-31 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hunt --- v5: add doc entry for new API v3: changed printf to RTE_LOG ---

[PATCH v5 1/4] lib/power: add get and set API for emptypoll max

2022-05-31 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Tested-by: David Hunt --- v5: add doc entry for new API --- doc/guides/prog_guide/power_man.rst | 6 ++ lib/power

[PATCH v5 0/4] Add APIs for configurable power options

2022-05-31 Thread Kevin Laatz
APIs v4: * fix return value when scaling_freq_max is not set * fix mismatching comments v3: * move setters from arg parse function to init * consider 0 as 'not set' for scaling_freq_max * other minor fixes v2: * add doc update for l3fwd-power * order version.map additions alphabetica

Re: [PATCH 2/4] app/test: support test last-idx when no DMA completed

2022-05-30 Thread Kevin Laatz
Tested with IOAT and IDXD, both pass unit tests. Tested-by: Kevin Laatz On 27/05/2022 04:40, Chengwen Feng wrote: If no DMA request is completed, the ring_idx of the last completed operation need returned by last_idx parameter. This patch adds testcase for it. Signed-off-by: Chengwen Feng

Re: [PATCH v5] eal: add bus cleanup to eal cleanup

2022-05-26 Thread Kevin Laatz
On 25/05/2022 12:12, Bruce Richardson wrote: On Wed, May 25, 2022 at 11:39:53AM +0100, Kevin Laatz wrote: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not

  1   2   3   4   5   6   7   8   >