Cc: Zaiyu Wang
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, December 5, 2024 6:19 AM
> To: dev@dpdk.org
> Cc: jiawe...@trustnetic.com
> Subject: Re: [RFC 2/5] net/ngbe: fix query handling in xstats_get
>
> On Tue, 8 Oct 2024 08:59:56 -0700
> Stephen Hemminger wrote
> > > Hello everyone,
> > > I recently added a txgbe port and enabled vlan offload.
> > > However, when I checked the dpdk logs, I noticed the following error:
> > > "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set():
> > > Please stop port first."
> >
> > You should stop the device first,
> -Original Message-
> From: Wangyunjian(wangyunjian,TongTu)
> Sent: Monday, December 9, 2024 8:30 PM
> To: dev@dpdk.org; jiawe...@trustnetic.com; jianw...@trustnetic.com
> Cc: liwei (DT) ; xiawei (H)
> Subject: txgbe: vlan offload setting errors
>
> Hello everyone,
> I recently added a
On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote:
> On 11/15/2024 8:33 AM, Jiawen Wu wrote:
> > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
> > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
> > is set to 0xd by
ault' is 0 -> 1 triggers
the interrupt. However, the interrupt is not cleared. And GPIO interrupt
mask is enabled and disabled to trigger the MISC interrupt repeatedly.
Since this 'tx_fault' interrupt does not make much sense, simply clear it
to fix the issue.
Signed-off-by:
When interrupt is legacy or MSI mode, shared interrupt may cause the
interrupt cannot be re-enabled. So fix to read the shared interrupt.
Fixes: b9246b8fa280 ("net/ngbe: support link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 13 ++
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_rxtx.c | 33
: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 49 ++
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver
evice")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
index 353d17acc8..238533f2b8 100644
--- a/drivers/net/ngbe/ngbe_ethdev.c
++
onfigure MAC Rx when link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_regs.h | 2 ++
drivers/net/ngbe/ngbe_ethdev.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_regs.h
b/drivers/net/ngbe/base/ngbe_reg
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path. Althrough the hardware
does not support TDM desc check.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 13 +
drivers/net/ngbe/ngbe_rxtx.c | 2 ++
drivers/net/ngbe/ngbe_rxtx.h | 1 +
3 files changed, 16 insertions(+)
diff --git a/drivers/net/ngbe
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 13 +
drivers/net/txgbe/txgbe_rxtx.c | 6 ++
drivers/net/txgbe/txgbe_rxtx.h | 1 +
3 files changed, 20 insertions(+)
diff --git a/drivers/net
of packet
type.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 6 ++
drivers/net/txgbe/txgbe_ethdev.c| 64 ++
drivers/net/txgbe/txgbe_ethdev.h| 3 +
drivers/net/txgbe/txgbe_rxtx.c | 100
drivers/net/txgbe/tx
Drv_load bit will be reset to default 0 after hardware LAN reset,
reconfigure it to inform firmware that driver is loaded. And set it to 0
when device is closed.
Fixes: b1f596677d8e ("net/txgbe: support device start")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers
ned-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_mng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/txgbe/base/txgbe_mng.c
b/drivers/net/txgbe/base/txgbe_mng.c
index 20db982891..7dc8f21183 100644
--- a/drivers/net/txgbe/base/txgbe_mng.c
+++ b/drivers/net/txgbe/base/txgbe_mng.
The hardware does not support outer UDP checksum for tunnel packets.
It's wrong to claim this Tx offload capability, so fix it.
Bugzilla ID: 1529
Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE")
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: sta...@dpdk.org
There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the
interrupt from being handled correctly.
Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 2
Fix some bugs in txgbe/ngbe, and optimize the Tx flow.
v2 -> v3:
- Reset Tx desc error statistics in .stats_reset().
- Add comment for Tx desc error count.
v1 -> v2:
- Fix build errors on ARM platform.
Jiawen Wu (13):
net/txgbe: fix swfw mbox failure
net/txgbe: fix VF-PF mbox int
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, November 1, 2024 10:46 AM
> To: Jiawen Wu ; dev@dpdk.org
> Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics
>
> On 11/1/2024 2:06 AM, Jiawen Wu wrote:
>
> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
> > if (!txq->resetting)
> > continue;
> >
> > + txq->desc_error++;
> >
>
> Why error value is increased in this function, which resets the Tx queue?
> Is the intention to reset the error va
On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote:
> On 10/28/2024 2:31 AM, Jiawen Wu wrote:
> > Add checking of the Tx packet length to avoid TDM fatal error as far as
> > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
> > and drop it directly in
There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the
interrupt from being handled correctly.
Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 2
ned-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_mng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/txgbe/base/txgbe_mng.c
b/drivers/net/txgbe/base/txgbe_mng.c
index 20db982891..7dc8f21183 100644
--- a/drivers/net/txgbe/base/txgbe_mng.c
+++ b/drivers/net/txgbe/base/txgbe_mng.
: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 49 ++
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver
When interrupt is legacy or MSI mode, shared interrupt may cause the
interrupt cannot be re-enabled. So fix to read the shared interrupt.
Fixes: b9246b8fa280 ("net/ngbe: support link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 13 ++
of packet
type.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 6 ++
drivers/net/txgbe/txgbe_ethdev.c| 64 ++
drivers/net/txgbe/txgbe_ethdev.h| 3 +
drivers/net/txgbe/txgbe_rxtx.c | 100
drivers/net/txgbe/tx
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_rxtx.c | 33
onfigure MAC Rx when link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_regs.h | 2 ++
drivers/net/ngbe/ngbe_ethdev.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_regs.h
b/drivers/net/ngbe/base/ngbe_reg
evice")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
index d9d2daf656..ba46dcf2a5 100644
--- a/drivers/net/ngbe/ngbe_ethdev.c
++
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 6 ++
drivers/net/txgbe/txgbe_rxtx.c | 3 +++
drivers/net/txgbe/txgbe_rxtx.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/drivers/net/txgbe
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 6 ++
drivers/net/ngbe/ngbe_rxtx.c | 2 ++
drivers/net/ngbe/ngbe_rxtx.h | 1 +
3 files changed, 9 insertions(+)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path. Althrough the hardware
does not support TDM desc check.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe
The hardware does not support outer UDP checksum for tunnel packets.
It's wrong to claim this Tx offload capability, so fix it.
Bugzilla ID: 1529
Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE")
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: sta...@dpdk.org
Fix some bugs in txgbe/ngbe, and optimize the Tx flow.
v1 -> v2:
- Fix build errors on ARM platform.
Jiawen Wu (13):
net/txgbe: fix swfw mbox failure
net/txgbe: fix VF-PF mbox interrupt
net/txgbe: remove outer UDP checksum capability
net/txgbe: fix driver load bit to inform firmw
Drv_load bit will be reset to default 0 after hardware LAN reset,
reconfigure it to inform firmware that driver is loaded. And set it to 0
when device is closed.
Fixes: b1f596677d8e ("net/txgbe: support device start")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers
: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 49 ++
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver
When interrupt is legacy or MSI mode, shared interrupt may cause the
interrupt cannot be re-enabled. So fix to read the shared interrupt.
Fixes: b9246b8fa280 ("net/ngbe: support link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 13 ++
onfigure MAC Rx when link update")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_regs.h | 2 ++
drivers/net/ngbe/ngbe_ethdev.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_regs.h
b/drivers/net/ngbe/base/ngbe_reg
evice")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
index d9d2daf656..ba46dcf2a5 100644
--- a/drivers/net/ngbe/ngbe_ethdev.c
++
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 6 ++
drivers/net/ngbe/ngbe_rxtx.c | 2 ++
drivers/net/ngbe/ngbe_rxtx.h | 1 +
3 files changed, 9 insertions(+)
diff --git a/drivers/net/ngbe/ngbe_ethdev.c b
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path. Althrough the hardware
does not support TDM desc check.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe
Count the number of packets not sent due to Tx descriptor error.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 6 ++
drivers/net/txgbe/txgbe_rxtx.c | 3 +++
drivers/net/txgbe/txgbe_rxtx.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/drivers/net/txgbe
of packet
type.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 6 ++
drivers/net/txgbe/txgbe_ethdev.c| 64 ++
drivers/net/txgbe/txgbe_ethdev.h| 3 +
drivers/net/txgbe/txgbe_rxtx.c | 100
drivers/net/txgbe/tx
Add checking of the Tx packet length to avoid TDM fatal error as far as
possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
and drop it directly in featured Tx code path.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_rxtx.c | 33
Drv_load bit will be reset to default 0 after hardware LAN reset,
reconfigure it to inform firmware that driver is loaded. And set it to 0
when device is closed.
Fixes: b1f596677d8e ("net/txgbe: support device start")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers
The hardware does not support outer UDP checksum for tunnel packets.
It's wrong to claim this Tx offload capability, so fix it.
Bugzilla ID: 1529
Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE")
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: sta...@dpdk.org
There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the
interrupt from being handled correctly.
Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 2
ned-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_mng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/txgbe/base/txgbe_mng.c
b/drivers/net/txgbe/base/txgbe_mng.c
index 20db982891..7dc8f21183 100644
--- a/drivers/net/txgbe/base/txgbe_mng.c
+++ b/drivers/net/txgbe/base/txgbe_mng.
Fix some bugs in txgbe/ngbe, and optimize the Tx flow.
Jiawen Wu (13):
net/txgbe: fix swfw mbox failure
net/txgbe: fix VF-PF mbox interrupt
net/txgbe: remove outer UDP checksum capability
net/txgbe: fix driver load bit to inform firmware
net/txgbe: enable Tx descriptor error interrupt
or (i = 0; i < limit; i++) {
> + for (i = 0; i < count; i++) {
> uint32_t offset = 0;
>
> if (txgbe_get_offset_by_id(i, &offset)) {
> --
> 2.45.2
>
>
Thanks!
Reviewed-by: Jiawen Wu
On Mon, Sep 9, 2024 2:51 PM, David Marchand wrote:
> On Mon, Sep 9, 2024 at 8:18 AM Jiawen Wu wrote:
> >
> > On Sat, Sep 7, 2024 10:54 PM, David Marchand wrote:
> > > BP_LOG() is only used in the base driver.
> > >
> > > Signed-off-by: David Marchan
On Sat, Sep 7, 2024 10:54 PM, David Marchand wrote:
> BP_LOG() is only used in the base driver.
>
> Signed-off-by: David Marchand
> ---
> drivers/net/txgbe/base/txgbe_osdep.h | 8
> drivers/net/txgbe/txgbe_logs.h | 7 ---
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> Hello Jianwen,
>
> In reference to https://bugs.dpdk.org/show_bug.cgi?id=1531#c3 reported
> by Yopper, is there is a fix needed for dpdk main branch or LTS branches ?
Sure. But adding a 10 us delay seems like a rude way to fix it. Actually, 1 us
delay is also effective. So I'll take a moment to
On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote:
> On 7/16/2024 9:16 AM, Jiawen Wu wrote:
> > --- a/drivers/net/ngbe/base/ngbe_hw.h
> > +++ b/drivers/net/ngbe/base/ngbe_hw.h
> > @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval);
> > void ngbe_m
In the new firmware versions, LLDP is enabled by default to implement
new features in other drivers. But it is useless in DPDK. So disable
it in device initialization to prevent it from affecting hardware
default behavior.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_eeprom.h | 3
bi);
../drivers/net/ngbe/base/ngbe_mng.c:385:36: note: while referencing
'buffer'
385 | struct ngbe_hic_write_lldp buffer;
So remove the redundant code 'resp->cmd == 0x30' to fix this issue.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_eeprom.h | 4 ++
igit wrote:
> >>>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver.
> >>>>>>>
> >>>>>>> Jiawen Wu (19):
> >>>>>>> net/txgbe: fix to parse tunnel packets
> >>>>>
Hi,
> -Original Message-
> From: Jiawen Wu
> Sent: Tuesday, June 25, 2024 9:51 AM
> To: dev@dpdk.org
> Subject: RE: [PATCH 00/19] Wangxun fixes and supports
>
> Hi,
>
> > -Original Message-
> > From: Jiawen Wu
> > Sent: Tuesday,
Hi,
> -Original Message-
> From: Jiawen Wu
> Sent: Tuesday, June 18, 2024 3:12 PM
> To: dev@dpdk.org
> Cc: Jiawen Wu
> Subject: [PATCH 00/19] Wangxun fixes and supports
>
> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver.
>
> Jiawen
ned-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 2 ++
drivers/net/txgbe/txgbe_ethdev.c| 8 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/txgbe/base/txgbe_regs.h
b/drivers/net/txgbe/base/txgbe_regs.h
index 86896d11dc..a2984f1106 100644
---
In the new firmware versions, LLDP is enabled by default to implement
new features in other drivers. But it is useless in DPDK. So disable
it in device initialization to prevent it from affecting hardware
default behavior.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_eeprom.h | 4
Fix some memory leaks caused by not release resource in time.
Fixes: 43b7e5ea60ac ("net/ngbe: support Rx queue setup/release")
Fixes: a58e7c312c6b ("net/ngbe: support Tx queue setup/release")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_rxtx.c |
Implement Rx queue interrupt enable/disable functions.
Signed-off-by: Jiawen Wu
---
doc/guides/nics/features/ngbe.ini | 1 +
doc/guides/nics/ngbe.rst | 1 +
drivers/net/ngbe/ngbe_ethdev.c| 33 ++-
3 files changed, 34 insertions(+), 1 deletion(-)
diff
In the new firmware versions, LLDP is enabled by default to implement
new features in other drivers. But it is useless in DPDK. So disable
it in device initialization to prevent it from affecting hardware
default behavior.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_eeprom.h | 3
Fix Rx interrupt enable failure.
Fixes: a5682d28f134 ("net/txgbe: support Rx interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c| 18 +-
drivers/net/txgbe/txgbe_ethdev_vf.c | 2 +-
2 files changed, 10 insertions(+), 10
ot;)
Fixes: 3a123ba60a71 ("net/txgbe: support VF start and stop")
Fixes: 039b769f7c01 ("net/txgbe: support VF MAC address")
Fixes: 226bf98eda87 ("net/txgbe: add Rx and Tx queues setup and release")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
dri
The valid range of MTU is 68 to 9414. Set min_mtu and max_mtu in dev_info.
Fixes: 07baabb6a51a ("net/ngbe: support MTU set")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 4 +++-
drivers/net/ngbe/ngbe_ethdev.h | 1 +
2 files changed, 4 insert
The valid range of MTU is 68 to 9414. Set min_mtu and max_mtu in dev_info.
Fixes: 3926214fd80d ("net/txgbe: support MTU set")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 12 +---
drivers/net/txgbe/txgbe_ethdev.h | 2 +-
2 files
Support WOL and NCSI capability for devices. And there is one OEM
NCSI NIC which can not be identified from sub-system ID, it needs
to check NCSI pin status in firmware.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_hw.c | 30 ++--
drivers/net/ngbe/base
This bug occurs in OpenvSwitch. After adding a port bound to vfio-pci
to ovs, detach it from ovs and then unbind it from vfio-pci(that is
hotplug) will cause operating system to get stuck.
Fixes: 6ee7e574cd48 ("net/ngbe: support probe and remove")
Cc: sta...@dpdk.org
Signed-off-by:
This bug occurs in OpenvSwitch. After adding a port bound to vfio-pci
to ovs, detach it from ovs and then unbind it from vfio-pci(that is
hotplug) will cause operating system to get stuck.
Fixes: 7dc117068a7c ("net/txgbe: support probe and remove")
Cc: sta...@dpdk.org
Signed-off-by:
The internal PHY will be set to default power down after LAN reset,
but the external PHY will not. To keep the PHY behavior consistent,
set PHY power down uniformly here.
Fixes: 708ebe7d0399 ("net/ngbe: fix external PHY power down")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
d
- restorting the proper mode (none or allmulti) when we disable
promiscuous mode
Fixes: 29072d593fe4 ("net/txgbe: support VF promiscuous and allmulticast")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev_vf.c | 12 +++-
1 file changed, 11 insert
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_phy_yt.c | 4
drivers/net/ngbe/base/ngbe_phy_yt.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_phy_yt.c
b/drivers/net/ngbe/base/ngbe_phy_yt.c
index ea313cd9a5..a374b015fd 1006
: 220b0e49bc47 ("net/txgbe: support VLAN")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 49 +---
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgb
a72b4d9dc0 ("net/txgbe: support ntuple filter add and delete")
Fixes: 983a4ef2265b ("net/txgbe: support syn filter add and delete")
Fixes: 08d61139be0a ("net/txgbe: support flow director filter add and delete")
Fixes: 9fdfed08a5e3 ("net/txgbe: restore RSS filter&qu
ueue after disabling PCIe bus
master to ensure that there are no packets left to cause Tx hang.
Fixes: b1f596677d8e ("net/txgbe: support device start")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/meson.build | 2 +-
drivers/net/txgbe/bas
fload")
Fixes: e5ece1f467aa ("net/txgbe: fix VXLAN-GPE packet checksum")
Fixes: 0e32d6edd479 ("net/txgbe: fix packet type to parse from offload flags")
Fixes: 5bbaf75ed6df ("net/txgbe: fix GRE tunnel packet checksum")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
On Tuesday, June 18, 2024 2:49 PM, dmarc...@redhat.com wrote:
> On Mon, Jun 17, 2024 at 11:54 AM Jiawen Wu wrote:
> >
> > Support WOL and NCSI capability for devices. And there is one OEM
> > NCSI NIC which can not be identified from sub-system ID, it needs
> >
The internal PHY will be set to default power down after LAN reset,
but the external PHY will not. To keep the PHY behavior consistent,
set PHY power down uniformly here.
Fixes: 708ebe7d0399 ("net/ngbe: fix external PHY power down")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
d
Support WOL and NCSI capability for devices. And there is one OEM
NCSI NIC which can not be identified from sub-system ID, it needs
to check NCSI pin status in firmware.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_hw.c | 30 ++--
drivers/net/ngbe/base
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_phy_yt.c | 4
drivers/net/ngbe/base/ngbe_phy_yt.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_phy_yt.c
b/drivers/net/ngbe/base/ngbe_phy_yt.c
index ea313cd9a5..a374b015fd 1006
- restorting the proper mode (none or allmulti) when we disable
promiscuous mode
Fixes: 29072d593fe4 ("net/txgbe: support VF promiscuous and allmulticast")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev_vf.c | 12 +++-
1 file changed, 11 insert
ned-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_regs.h | 2 ++
drivers/net/txgbe/txgbe_ethdev.c| 8 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/txgbe/base/txgbe_regs.h
b/drivers/net/txgbe/base/txgbe_regs.h
index 86896d11dc..a2984f1106 100644
---
: 220b0e49bc47 ("net/txgbe: support VLAN")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_ethdev.c | 49 +---
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgb
ueue after disabling PCIe bus
master to ensure that there are no packets left to cause Tx hang.
Fixes: b1f596677d8e ("net/txgbe: support device start")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/meson.build | 2 +-
drivers/net/txgbe/bas
a72b4d9dc0 ("net/txgbe: support ntuple filter add and delete")
Fixes: 983a4ef2265b ("net/txgbe: support syn filter add and delete")
Fixes: 08d61139be0a ("net/txgbe: support flow director filter add and delete")
Fixes: 9fdfed08a5e3 ("net/txgbe: restore RSS filter&qu
fload")
Fixes: e5ece1f467aa ("net/txgbe: fix VXLAN-GPE packet checksum")
Fixes: 0e32d6edd479 ("net/txgbe: fix packet type to parse from offload flags")
Fixes: 5bbaf75ed6df ("net/txgbe: fix GRE tunnel packet checksum")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
x86/arm architecture.
The performance test results on Phytium D2000(ARM64) show that,
throughput for 128-byte packets increased from 76.797% to 94.375%.
Signed-off-by: Jiawen Wu
---
doc/guides/rel_notes/release_24_07.rst
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
x86/arm architecture.
The performance test results on Phytium D2000(ARM64) show that,
throughput for 64-byte packets increased from 64.844% to 73.984%.
Signed-off-by: Jiawen Wu
---
doc/guides/rel_notes/release_24_07.rst
Add SSE/NEON vector instructions for TXGBE and NGBE driver to process
packets.
v3:
- Update release note.
- Use spaces instead of tab in meson.build.
v2:
- Add performance test results.
- Cleanup codes and rebase.
- Remove GCC "-Wcast-qual".
Jiawen Wu (2):
net/txgbe: add vectorized
On Friday, April 19, 2024 8:12 AM, ferruh.yi...@amd.com wrote:
> On 4/9/2024 7:31 AM, Jiawen Wu wrote:
> > Add SSE/NEON vector instructions for TXGBE and NGBE driver to process
> > packets.
> >
> > v2:
> > - Add performance test results.
> > - Cleanup cod
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
x86/arm architecture.
The performance test results on Phytium D2000(ARM64) show that,
throughput for 64-byte packets increased from 64.844% to 73.984%.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/meson.build
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
x86/arm architecture.
The performance test results on Phytium D2000(ARM64) show that,
throughput for 128-byte packets increased from 76.797% to 94.375%.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/meson.build
Add SSE/NEON vector instructions for TXGBE and NGBE driver to process
packets.
v2:
- Add performance test results.
- Cleanup codes and rebase.
- Remove GCC "-Wcast-qual".
Jiawen Wu (2):
net/txgbe: add vectorized functions for Rx/Tx
net/ngbe: add vectorized functions for Rx/Tx
d
> >>> @@ -2198,8 +2220,15 @@ txgbe_set_tx_function(struct rte_eth_dev *dev,
> >>> struct txgbe_tx_queue *txq)
> >>> #endif
> >>> txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST) {
> >>> PMD_INIT_LOG(DEBUG, "Using simple tx code path");
> >>> - dev->tx_pkt_bur
On Wed, Feb 7, 2024 11:13 AM, ferruh.yi...@amd.com wrote:
> On 2/1/2024 3:00 AM, Jiawen Wu wrote:
> > To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
> > x86/arm architecture.
> >
>
> Do you have any performance improvement number with vector
>
Hi,
> -Original Message-
> From: Jiawen Wu
> Sent: Thursday, February 1, 2024 11:00 AM
> To: dev@dpdk.org
> Cc: Jiawen Wu
> Subject: [PATCH 0/2] Wangxun support vector Rx/Tx
>
> Add SSE/NEON vector instructions for TXGBE and NGBE driver to process
> packets.
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on
x86/arm architecture.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/meson.build| 6 +
drivers/net/ngbe/ngbe_ethdev.c | 6 +
drivers/net/ngbe/ngbe_ethdev.h | 1 +
drivers/net/ngbe/ngbe_rxtx.c
1 - 100 of 919 matches
Mail list logo
