Re: [dpdk-dev] [PATCH v3 3/4] cryptodev: rework dependency on vdev header

2017-10-10 Thread Jan Blunck
On Tue, Oct 10, 2017 at 10:47 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message----- >> From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck >> Sent: Friday, October 6, 2017 9:40 AM >> To: dev@dpdk.org >> Cc: Doherty, Declan ;

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-06 Thread Jan Blunck
On Fri, Oct 6, 2017 at 3:37 PM, Thomas Monjalon wrote: > 06/10/2017 15:12, Shreyansh Jain: >> On Friday 06 October 2017 04:51 AM, Thomas Monjalon wrote: >> > 19/09/2017 20:51, Jan Blunck: >> >> On Mon, Sep 18, 2017 at 1:36 PM, Hemant Agrawal >> >&g

[dpdk-dev] [PATCH v3 1/4] cryptodev: remove obsolete include

2017-10-06 Thread Jan Blunck
Signed-off-by: Jan Blunck Acked-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 7ec9c4bc4..ad97ff940 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h

[dpdk-dev] [PATCH v3 2/4] cryptodev: move initialization

2017-10-06 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_cryptodev/rte_cryptodev.c | 3 +++ lib/librte_cryptodev/rte_cryptodev_pmd.c | 6 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 327d7e846

[dpdk-dev] [PATCH v3 4/4] cryptodev: move parameter parsing to its own header

2017-10-06 Thread Jan Blunck
This moves the parameter parsing functions out of the rte_cryptodev_vdev.h header to not require the rte_vdev.h header at build time of the library. Signed-off-by: Jan Blunck --- lib/librte_cryptodev/Makefile| 1 + lib/librte_cryptodev/rte_cryptodev_pmd.c | 2

[dpdk-dev] [PATCH v3 3/4] cryptodev: rework dependency on vdev header

2017-10-06 Thread Jan Blunck
The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. By moving the helper to the header we don't require rte_vdev.h at build-time of the librte_cryptodev library. This is a preparation to move the vdev bus into a standalone library. Signed-off-by: Jan Blunck ---

[dpdk-dev] [PATCH v3 0/4] cryptodev vdev changes for 17.11-rc1

2017-10-06 Thread Jan Blunck
since v2: - fix bisect compile errors - workaround check-git-log.sh stupidity Jan Blunck (4): cryptodev: remove obsolete include cryptodev: move initialization cryptodev: rework dependency on vdev header cryptodev: move parameter parsing to its own header lib/librte_cryptodev/Makefile

Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h

2017-10-05 Thread Jan Blunck
On Mon, Sep 4, 2017 at 4:32 PM, De Lara Guarch, Pablo wrote: > Hi Jan, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, >> Pablo >> Sent: Saturday, July 15, 2017 12:05 PM >> To: Jan Blunck ; dev@dpdk.org &g

Re: [dpdk-dev] [PATCH v2 09/12] ethdev: support attach vdev in secondary process

2017-10-05 Thread Jan Blunck
On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan wrote: > When vdev driver requests an ethdev entry in secondary process, > we will identify the correct entry in rte_eth_dev_data array > and return the correct entry in the rte_eth_devices arrays. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_e

Re: [dpdk-dev] [PATCH v2 03/12] cryptodev: avoid dependency on rte_vdev.h

2017-10-05 Thread Jan Blunck
On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan wrote: > The helper API, rte_cryptodev_vdev_pmd_init(), has a parameter of > struct rte_vdev_device *, which needs to include rte_vdev.h. > > We will move vdev into drivers/bus, so we need to avoid such > dependency. And also, we cannot break the ABI.

Re: [dpdk-dev] [PATCH v2 08/12] bus/vdev: scan and probe vdev in secondary processes

2017-10-05 Thread Jan Blunck
On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan wrote: > Base on primary/secondary communication channel, we add vdev action > to scan virtual devices in secondary processes. > This doesn't need to be in vdev. You application could just hotplug the drivers with exactly the same parameters as the pr

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-10-05 Thread Jan Blunck
On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan wrote: > Previouly, there is only one way for primary/secondary to exchange > messages, that is, primary process writes info into some predefind > file, and secondary process reads info out. That cannot address > the requirements: > a. Secondary want

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-09-19 Thread Jan Blunck
On Mon, Sep 18, 2017 at 1:36 PM, Hemant Agrawal wrote: > Tested-by: Hemant Agrawal > > > On 8/12/2017 3:52 PM, Shreyansh Jain wrote: >> >> Bus scan is responsible for finding devices over *all* buses. >> Some of these buses might not be able to scan but that should >> not prevent other buses to b

Re: [dpdk-dev] [PATCH v5 0/2] add uevent monitor for hot plug

2017-09-19 Thread Jan Blunck
On Wed, Sep 20, 2017 at 6:12 AM, Jeff Guo wrote: > So far, about hot plug in dpdk, we already have hot plug add/remove > api and fail-safe driver to offload the fail-safe work from the app > user. But there are still lack of a general event api, since the interrupt > event, which hot plug related

[dpdk-dev] Minutes of techboard meeting 2017-08-09

2017-08-27 Thread Jan Blunck
Member attendees: - Bruce Richardson - Hemant Agrawal - Jan Blunck - Jerin Jacob - Konstantin Ananyev - Stephen Hemminger - Yuanhan Liu - How we want the developers to use the github.com/dpdk? Do we want to get pull requests also from github? We only want to maintain it as a mirror for dpdk

Re: [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-07-27 Thread Jan Blunck
On Wed, Jul 19, 2017 at 9:31 AM, De Lara Guarch, Pablo wrote: > > > > > -Original Message----- > > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > > Sent: Wednesday, July 12, 2017 8:59 PM > > To: dev@dpdk.org > > Cc:

[dpdk-dev] [PATCH v2 15/15] devargs: remove bus field

2017-07-14 Thread Jan Blunck
This removes the enum rte_bus field ``bus`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 3 +-- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 3 files changed, 1 insertion(+), 5

[dpdk-dev] [PATCH v2 13/15] devargs: pass busname argument when parsing

2017-07-14 Thread Jan Blunck
Let the rte_eal_devargs_parse() function explicitly take a "busname" argument that is validated. Now that the busname is known and validated at parse time the validity of the device name is checked for all device types when they get probed. Signed-off-by: Jan Blunck --- lib/librte_

[dpdk-dev] [PATCH v2 14/15] devargs: remove type field

2017-07-14 Thread Jan Blunck
This removes the enum rte_devtype field ``type`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b

[dpdk-dev] [PATCH v2 12/15] vdev: use busname

2017-07-14 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index ff6a3b571..d04015582 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v2 10/15] devargs: use busname

2017-07-14 Thread Jan Blunck
This makes the devargs code itself require the rte_devargs type field for properly functioning. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common

[dpdk-dev] [PATCH v2 11/15] pci: use busname

2017-07-14 Thread Jan Blunck
Signed-off-by: Jan Blunck --- drivers/net/virtio/virtio_pci.c| 3 +-- lib/librte_eal/common/eal_common_pci.c | 9 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index e6eda75b6..dfc6edac2 100644

[dpdk-dev] [PATCH v2 09/15] devargs: add busname string field

2017-07-14 Thread Jan Blunck
This adds the busname as a string to struct rte_devargs. This is a generic replacement for enum rte_devtype without tightly coupling rte_devargs to the rte_bus structure. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 9 + lib/librte_eal/common/include

[dpdk-dev] [PATCH v2 08/15] devargs: use existing functions in rte_eal_devargs_parse()

2017-07-14 Thread Jan Blunck
This fixes the newly introduces rte_eal_devargs_parse() to make use of: - snprintf() instead of open coding a while() loop - rte_eal_parse_devargs_str() instead of duplicating parsing code - RTE_LOG() instead of direct output to stderr Signed-off-by: Jan Blunck --- lib/librte_eal/common

[dpdk-dev] [PATCH v2 07/15] devargs: use bus configuration interface to set scanning mode

2017-07-14 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 92c77c30e..205fabb95 100644

[dpdk-dev] [PATCH v2 06/15] bus: add configuration interface for buses

2017-07-14 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 16 lib/librte_eal/common/include/rte_bus.h | 9 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 4 files changed, 27

[dpdk-dev] [PATCH v2 05/15] pci: use scan_mode configuration

2017-07-14 Thread Jan Blunck
When scanning/probing devices the bus doesn't need to look at the devargs->type field: if the bus is in blacklist probing mode and there is no devargs found for the device it is white-listed. Therefore it is enough to let the bus check for the scan_mode. Signed-off-by: Jan Blunck

[dpdk-dev] [PATCH v2 04/15] devargs: deprecate enum rte_devtype based functions

2017-07-14 Thread Jan Blunck
The enum rte_devtype will need to get extended every time we add a bus. Mark all related functions as deprecated for 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst| 7 +++ lib/librte_eal/common/include/rte_devargs.h | 3 +++ 2 files changed, 10 insertions

[dpdk-dev] [PATCH v2 03/15] devargs: extend unittest

2017-07-14 Thread Jan Blunck
This is extending the existing unittest to also cover corner cases of rte_eal_devargs_parse(). Signed-off-by: Jan Blunck --- test/test/test_devargs.c | 20 1 file changed, 20 insertions(+) diff --git a/test/test/test_devargs.c b/test/test/test_devargs.c index 02fec8b1f

[dpdk-dev] [PATCH v2 02/15] devargs: fix unittest

2017-07-14 Thread Jan Blunck
Since the scan-mode of the bus is now based on the bus configuration it isn't possible to have blacklisted and whitelisted devices existing for the same bus. This fixes the unittest to reflect that. Signed-off-by: Jan Blunck --- test/test/test_devargs.c | 8 +--- 1 file chang

[dpdk-dev] [PATCH v2 00/15] devargs fixes

2017-07-14 Thread Jan Blunck
explain why changes are done Jan Blunck (15): Revert "devargs: make device types generic" devargs: fix unittest devargs: extend unittest devargs: deprecate enum rte_devtype based functions pci: use scan_mode configuration bus: add configuration interface for buses devarg

[dpdk-dev] [PATCH v2 01/15] Revert "devargs: make device types generic"

2017-07-14 Thread Jan Blunck
This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1. --- lib/librte_eal/common/eal_common_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_options.c | 6 ++--- lib/librte_eal/common/eal_common_pci.c | 4 ++-- lib/librte_eal/common/eal_common_vdev.c | 1 + li

Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

2017-07-13 Thread Jan Blunck
On Wed, Jul 12, 2017 at 1:20 PM, Gaëtan Rivet wrote: > On Wed, Jul 12, 2017 at 04:20:48AM -0400, Jan Blunck wrote: >> On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: >> > Some buses will operate either in whitelist or blacklist mode. >> > This mode is c

Re: [dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

2017-07-13 Thread Jan Blunck
On Thu, Jul 13, 2017 at 1:59 PM, Gaëtan Rivet wrote: > On Tue, Jul 11, 2017 at 07:25:03PM -0400, Jan Blunck wrote: >> When scanning/probing devices the bus should use its configuration instead >> of looking at the devargs->type field. >> > > With this patch, how

Re: [dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-13 Thread Jan Blunck
mmitlog does not describe the problem being > solved. > > I think there should be a discussion about the future format of device > declarations. One version has been integrated in RC1 but it will be reworked > anyway. I'd like to hear more opinions. > > On Tue, Jul 11,

[dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-12 Thread Jan Blunck
This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst | 5 + lib/librte_cryptodev

[dpdk-dev] [PATCH v2 4/4] cryptodev: move parameter parsing to its own header

2017-07-12 Thread Jan Blunck
This moves the parameter parsing functions out of the rte_cryptodev_vdev.h header to not require the rte_vdev.h header at build time of the library. Signed-off-by: Jan Blunck --- lib/librte_cryptodev/Makefile| 1 + lib/librte_cryptodev/rte_cryptodev_pmd.c | 2

[dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h

2017-07-12 Thread Jan Blunck
The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. By moving the helper to the header we don't require rte_vdev.h at build-time of the librte_cryptodev library. This is a preparation to move the vdev bus into a standalone library. Signed-off-by: Jan Blunck ---

[dpdk-dev] [PATCH v2 1/4] cryptodev: remove obsolete include

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck Acked-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 1d975e5f9..2048d6e29 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h

[dpdk-dev] [PATCH v2 2/4] cryptodev: move initialization

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_cryptodev/rte_cryptodev.c | 3 +++ lib/librte_cryptodev/rte_cryptodev_pmd.c | 6 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 8ee5d47a9

[dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-07-12 Thread Jan Blunck
This series is a preparation to move the vdev bus out of librte_eal. For that the newly added cryptodev vdev functions need to change signature to not require the rte_vdev.h header. Changes since v1: - move params parsing into new header - make rte_cryptodev_vdev_pmd_init() static inline Jan

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Jan Blunck
On Wed, Jul 12, 2017 at 4:50 AM, Thomas Monjalon wrote: > 12/07/2017 10:09, Jan Blunck: >> On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: >> > 12/07/2017 01:24, Jan Blunck: >> >> The changes to enum rte_devtype that got merged into 17.08-rc1 are >>

Re: [dpdk-dev] [PATCH v3 4/8] eal: fix hotplug add / remove

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > The hotplug API requires a few properties that were not previously > explicitly enforced: > > - Idempotency, two consecutive scans should result in the same state. > - Upon returning, internal devices are now allocated and available >

Re: [dpdk-dev] [PATCH v3 2/8] devargs: introduce removal function

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > Hotplug support introduces the possibility of removing devices from the > system. Allocated resources must be freed. > > Extend the rte_devargs API to allow freeing allocated resources. > > This API is experimental and bound to change. It is c

Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > Some buses will operate either in whitelist or blacklist mode. > This mode is currently passed down by the rte_eal_devargs_add function > with the devtype argument. > > When inserting devices using the hotplug API, the implicit assumption is >

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Jan Blunck
On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: > 12/07/2017 01:24, Jan Blunck: >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking >> API without prior notice. This series is reworking the rte_devargs changes >> in a way hopefully complian

[dpdk-dev] [PATCH 1/2] cryptodev: remove obsolete include

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_cryptodev/rte_cryptodev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index ca7cbdd8d..989db0f36 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib

[dpdk-dev] [PATCH 0/2] cryptodev vdev changes for -rc2

2017-07-12 Thread Jan Blunck
This series is a preparation to move the vdev bus out of librte_eal. For that the newly added cryptodev vdev functions need to change signature to not require the rte_vdev.h header. Jan Blunck (2): cryptodev: remove obsolete include cryptodev: rework cryptodev PMD init to not require

[dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h

2017-07-12 Thread Jan Blunck
This reworks the library code so that it doesn't require to include rte_vdev.h. This is a preparation to move the vdev bus into a standalone library. Signed-off-by: Jan Blunck --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 ++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c

[dpdk-dev] [PATCH 13/13] devargs: remove bus field

2017-07-11 Thread Jan Blunck
This removes the enum rte_bus field ``bus`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib

[dpdk-dev] [PATCH 12/13] devargs: remove type field

2017-07-11 Thread Jan Blunck
This removes the enum rte_devtype field ``type`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b

[dpdk-dev] [PATCH 08/13] devargs: use busname

2017-07-11 Thread Jan Blunck
This makes the devargs code itself require the rte_devargs type field for properly functioning. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/lib/librte_eal/common

[dpdk-dev] [PATCH 11/13] vdev: use busname

2017-07-11 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index ff6a3b571..d04015582 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-11 Thread Jan Blunck
Let the rte_eal_devargs_parse() function parse the "bus=" argument. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 131 ++--- test/test/test_devargs.c | 19 + 2 files changed, 102 insertions(+), 48 deletion

[dpdk-dev] [PATCH 10/13] pci: use busname

2017-07-11 Thread Jan Blunck
Signed-off-by: Jan Blunck --- drivers/net/virtio/virtio_pci.c| 3 +-- lib/librte_eal/common/eal_common_pci.c | 9 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index e6eda75b6..a81322969 100644

[dpdk-dev] [PATCH 07/13] devargs: add busname string field

2017-07-11 Thread Jan Blunck
devices anyway but didn't guarantee that this device exists. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 89 + lib/librte_eal/common/include/rte_devargs.h | 9 ++- test/test/test_devargs.c| 12 3 files change

[dpdk-dev] [PATCH 06/13] devargs: use bus configuration interface to set scanning mode

2017-07-11 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 92c77c30e..691538095 100644

[dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

2017-07-11 Thread Jan Blunck
When scanning/probing devices the bus should use its configuration instead of looking at the devargs->type field. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pc

[dpdk-dev] [PATCH 05/13] bus: add configuration interface for buses

2017-07-11 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 16 lib/librte_eal/common/include/rte_bus.h | 9 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 4 files changed, 27

[dpdk-dev] [PATCH 02/13] devargs: fix unittest

2017-07-11 Thread Jan Blunck
Since the scan-mode of the bus is now based on the bus configuration it isn't possible to have blacklisted and whitelisted devices existing for the same bus. This fixes the unittest to reflect that. Signed-off-by: Jan Blunck --- test/test/test_devargs.c | 8 +--- 1 file chang

[dpdk-dev] [PATCH 03/13] devargs: deprecate enum rte_devtype based functions

2017-07-11 Thread Jan Blunck
The enum rte_devtype will need to get extended every time we add a bus. Mark all related functions as deprecated for 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst| 7 +++ lib/librte_eal/common/include/rte_devargs.h | 3 +++ 2 files changed, 10 insertions

[dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-11 Thread Jan Blunck
The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking API without prior notice. This series is reworking the rte_devargs changes in a way hopefully compliant to the new failover PMD and still keeping API compatible with earlier releases. Jan Blunck (13): Revert "de

[dpdk-dev] [PATCH 01/13] Revert "devargs: make device types generic"

2017-07-11 Thread Jan Blunck
This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1. --- lib/librte_eal/common/eal_common_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_options.c | 6 ++--- lib/librte_eal/common/eal_common_pci.c | 4 ++-- lib/librte_eal/common/eal_common_vdev.c | 1 + li

[dpdk-dev] [PATCH v2 3/3] vdev: allocate empty str args

2017-07-11 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 5abdba091..e00dda9aa 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/lib

[dpdk-dev] [PATCH v2 1/3] vdev: get name from embedded device

2017-07-11 Thread Jan Blunck
Instead of getting the name from the devargs lets take it from the rte_device. Signed-off-by: Jan Blunck --- lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_vdev.h b/lib/librte_eal/common/include

[dpdk-dev] [PATCH v2 2/3] vdev: directly use rte_bus reference

2017-07-11 Thread Jan Blunck
It isn't necessary to use rte_bus_find_by_name() to find a reference to our own bus. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librt

[dpdk-dev] [PATCH v2 0/3] vdev patches for -rc2

2017-07-11 Thread Jan Blunck
Three trivial vdev patches for -rc2. Please review and apply. Changes since v0: - Fix review comments by Gaetan Jan Blunck (3): vdev: get name from embedded device vdev: directly use rte_bus reference vdev: allocate empty str args lib/librte_eal/common/eal_common_vdev.c | 11

Re: [dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference

2017-07-11 Thread Jan Blunck
On Tue, Jul 11, 2017 at 3:09 PM, Gaëtan Rivet wrote: > Hi Jan, > > On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote: >> It isn't necessary to use rte_bus_find_by_name() to find a reference to >> our own bus. >> >> Signed-off-by: Jan Bl

[dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference

2017-07-11 Thread Jan Blunck
It isn't necessary to use rte_bus_find_by_name() to find a reference to our own bus. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librt

[dpdk-dev] [PATCH 1/2] vdev: get name from embedded device

2017-07-11 Thread Jan Blunck
Instead of getting the name from the devargs lets take it from the rte_device. Signed-off-by: Jan Blunck --- lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_vdev.h b/lib/librte_eal/common/include

[dpdk-dev] [PATCH 0/2] vdev patches for -rc2

2017-07-11 Thread Jan Blunck
Two trivial vdev patches for -rc2. Please review and apply. Jan Blunck (2): vdev: get name from embedded device vdev: directly use rte_bus reference lib/librte_eal/common/eal_common_vdev.c | 9 + lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 2 files changed, 7 insertions(+), 6

Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing

2017-07-09 Thread Jan Blunck
On Sun, Jul 9, 2017 at 6:17 AM, Thomas Monjalon wrote: > 09/07/2017 10:37, Jan Blunck: >> On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon wrote: >> > 07/07/2017 02:04, Gaetan Rivet: >> >> In this patchset, the representation of devices in rte_devargs is made >

Re: [dpdk-dev] [PATCH v7 03/11] net/failsafe: add fail-safe PMD

2017-07-09 Thread Jan Blunck
On Sat, Jul 8, 2017 at 9:47 PM, Gaetan Rivet wrote: > Introduce the fail-safe poll mode driver initialization and enable its > build infrastructure. > > This PMD allows for applications to benefit from true hot-plugging > support without having to implement it. > > It intercepts and manages Ethern

Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing

2017-07-09 Thread Jan Blunck
On Sun, Jul 9, 2017 at 6:46 AM, Jan Blunck wrote: > On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon wrote: >> 09/07/2017 11:28, Jan Blunck: >>> This is going to get cleaned up in future releases so lets not expose >>> this API unnecessarily. >>> >>>

Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing

2017-07-09 Thread Jan Blunck
On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon wrote: > 09/07/2017 11:28, Jan Blunck: >> This is going to get cleaned up in future releases so lets not expose >> this API unnecessarily. >> >> Signed-off-by: Jan Blunck >> --- >> --- a/lib/librte_eal/linuxa

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix build

2017-07-09 Thread Jan Blunck
On Sun, Jul 9, 2017 at 6:38 AM, Thomas Monjalon wrote: > 09/07/2017 11:44, Jan Blunck: >> Fixes 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") >> >> drivers/crypto/scheduler/scheduler_multicore.c: In function 'scheduler_stop': >>

Re: [dpdk-dev] [PATCH 0/9] fix hotplug API

2017-07-09 Thread Jan Blunck
On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > Sending those fixes as separate patches as they stand on their own. > This series improves usability of the hotplug API and fixes a few issues > with existing implementations. > Interesting that you send this series as fixes. From what I can t

[dpdk-dev] [PATCH] crypto/scheduler: fix build

2017-07-09 Thread Jan Blunck
or C11 mode for (uint16_t i = 0; i < sched_ctx->nb_wc; i++) ^ compilation terminated due to -Wfatal-errors. mk/internal/rte.compile-pre.mk:138: recipe for target 'scheduler_multicore.o' failed make[4]: *** [scheduler_multicore.o] Error 1 make[4]: *** Waiting for unfinished job

[dpdk-dev] [PATCH 0/2] devargs changes / deprecation notice

2017-07-09 Thread Jan Blunck
Since rte_devargs API will change again for 17.11 I'll add a deprecation notice now to be able to get the change into the next release. Jan Blunck (2): eal: internalize devargs parsing eal: deprecate 17.08 devargs API/ABI doc/guides/rel_notes/deprecation.rst| 9 -

[dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing

2017-07-09 Thread Jan Blunck
This is going to get cleaned up in future releases so lets not expose this API unnecessarily. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst| 2 +- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 - lib/librte_eal/common/eal_common_devargs.c | 2

[dpdk-dev] [PATCH 2/2] eal: deprecate 17.08 devargs API/ABI

2017-07-09 Thread Jan Blunck
Add deprecation notice necessary to do devargs refactoring for 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 33e8b93db

Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing

2017-07-09 Thread Jan Blunck
On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon wrote: > 07/07/2017 02:04, Gaetan Rivet: >> In this patchset, the representation of devices in rte_devargs is made >> generic >> to remove some dependencies of the EAL on specific buses implementations. >> Following the device types being characteri

Re: [dpdk-dev] [PATCH] eal: remove vdev probe by dev args

2017-07-09 Thread Jan Blunck
On Fri, Jun 16, 2017 at 10:20 AM, Thomas Monjalon wrote: > Please Jan, could you comment? > My intention was to provide a way that devices can have arbitrary names. Ferruh correctly pointed out that this is undocumented and hidden functionality. Lets apply this and I can rework this if it becomes

Re: [dpdk-dev] [PATCH v2] eal: don't advertise a physical address when no hugepages

2017-07-03 Thread Jan Blunck
won't complain in that > case. > > Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user") > > CC: sta...@dpdk.org > Signed-off-by: Olivier Matz Reviewed-by: Jan Blunck > --- > > v1 -> v2: > - initialize memory segme

Re: [dpdk-dev] [PATCH 1/8] eal: expose rte_eal_using_phys_addrs

2017-07-03 Thread Jan Blunck
On Mon, Jul 3, 2017 at 10:25 AM, Olivier Matz wrote: > Hi, > > On Fri, 30 Jun 2017 21:05:47 +0200, Jan Blunck wrote: >> On Thu, Jun 1, 2017 at 12:14 PM, Gaetan Rivet wrote: >> > This function was previously private to the EAL layer. >> > Other subsystems

Re: [dpdk-dev] [PATCH 1/8] eal: expose rte_eal_using_phys_addrs

2017-06-30 Thread Jan Blunck
On Thu, Jun 1, 2017 at 12:14 PM, Gaetan Rivet wrote: > This function was previously private to the EAL layer. > Other subsystems requires it, such as the PCI bus. > > This function is only exposed for linuxapps. > > In order not to force other components to include stdbool, which is > incompatible

Re: [dpdk-dev] [PATCH v8 09/14] bus: introduce device plug/unplug functionality

2017-06-30 Thread Jan Blunck
On Fri, Jun 30, 2017 at 8:38 PM, Gaëtan Rivet wrote: > On Fri, Jun 30, 2017 at 08:19:38PM +0200, Jan Blunck wrote: >> This allows the buses to plug and probe specific devices. This is meant to >> be a building block for hotplug support. >> >> Signed-off-by: Jan Blunck

[dpdk-dev] [PATCH v8 13/14] ethdev: Use embedded rte_device to detach driver

2017-06-30 Thread Jan Blunck
This is changing the API of rte_eal_dev_detach(). Signed-off-by: Jan Blunck --- app/test-pmd/testpmd.c | 2 +- lib/librte_eal/common/eal_common_dev.c | 32 +++- lib/librte_eal/common/include/rte_dev.h | 7 +++ lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH v8 07/14] bus: require buses to implement find_device operation

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index 5d06f5d..b8a9e30 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib

[dpdk-dev] [PATCH v8 14/14] dev: use new hotplug API in attach

2017-06-30 Thread Jan Blunck
Using the new hotplug API allows attach to be backwards compatible while decoupling it from the concrete bus implementations. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_dev.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a

[dpdk-dev] [PATCH v8 12/14] eal: add hotplug add/remove functions

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 8 +++ lib/librte_eal/common/eal_common_dev.c | 88 + lib/librte_eal/common/include/rte_dev.h | 34 ++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 +++ 4

[dpdk-dev] [PATCH v8 11/14] pci: implement hotplug bus operation

2017-06-30 Thread Jan Blunck
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index e449758..5ee100e 100644 --- a/

[dpdk-dev] [PATCH v8 10/14] vdev: implement unplug bus operation

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 9bb7427..baf3c5b 100644 --- a/lib/librte_eal/common/eal_common_vdev.c

[dpdk-dev] [PATCH v8 09/14] bus: introduce device plug/unplug functionality

2017-06-30 Thread Jan Blunck
This allows the buses to plug and probe specific devices. This is meant to be a building block for hotplug support. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 32 2 files changed, 34

[dpdk-dev] [PATCH v8 08/14] bus: add rte_bus_find_by_name

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 14 ++ lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 4 files changed, 21

[dpdk-dev] [PATCH v8 06/14] bus: add helper to find which bus holds a device

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 23 +++ lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v8 05/14] bus/fslmc: implement find_device bus operation

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- drivers/bus/fslmc/fslmc_bus.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index b24642d..1e3bbee 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc

[dpdk-dev] [PATCH v8 04/14] pci: implement find_device bus operation

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_pci.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 479c62d..e449758 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v8 03/14] vdev: implement find_device bus operation

2017-06-30 Thread Jan Blunck
Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index b4db2be..9bb7427 100644 --- a/lib

[dpdk-dev] [PATCH v8 00/14] bus attach/detach API and hotplug rework

2017-06-30 Thread Jan Blunck
symbols Gaetan Rivet (1): pci: implement hotplug bus operation Jan Blunck (13): bus: add bus iterator to find a bus bus: add find_device bus operation vdev: implement find_device bus operation pci: implement find_device bus operation bus/fslmc: implement find_device bus operation bus:

  1   2   3   4   5   >