RE: [PATCH v3 3/6] net/intel: add TxPP Support for E830

2025-06-10 Thread Hore, Soumyadeep
-Original Message- From: Richardson, Bruce Sent: 09 June 2025 20:09 To: Hore, Soumyadeep Cc: dev@dpdk.org; Singh, Aman Deep ; Subbarao, Manoj Kumar Subject: Re: [PATCH v3 3/6] net/intel: add TxPP Support for E830 On Sun, Jun 08, 2025 at 11:32:20AM +, Soumyadeep Hore wrote

RE: [PATCH v3 2/6] net/intel: add read clock feature in ICE

2025-06-10 Thread Hore, Soumyadeep
The similar implementation is done in igc driver. Currently we don't read time from device. We read the system time and send it out based on the burst calculations. The mechanism is same in kernel drivers too. On Sun, Jun 08, 2025 at 11:32:19AM +, Soumyadeep Hore wrote: > Adding eth_ice_read

RE: [PATCH v3 3/6] net/intel: add TxPP Support for E830

2025-06-10 Thread Hore, Soumyadeep
On Sun, Jun 08, 2025 at 11:32:20AM +, Soumyadeep Hore wrote: > Add support for Tx Time based queues. This is used to schedule packets > based on Tx timestamp. > > Signed-off-by: Soumyadeep Hore Some initial review comments inline below. /Bruce > --- > drivers/net/intel/common/tx.h

RE: [PATCH v2 2/2] net/intel: add Tx time queue

2025-02-18 Thread Hore, Soumyadeep
On Wed, Feb 12, 2025 at 09:47:11PM +, Soumyadeep Hore wrote: > Enabling Tx timestamp queue for supporting Tx time based scheduling of > packets. > Can you provide more details of this feature and how it can be used, how it is enabled/disabled etc. See also comments inline below. /Bruce >

RE: [PATCH v1] common/iavf: update README documentation

2024-09-17 Thread Hore, Soumyadeep
Hi Bruce, The below wording looks fine. We can proceed with it. On Tue, Sep 17, 2024 at 11:45:02AM +, Soumyadeep Hore wrote: > Updating README documentation to have the latest version for IAVF Base > driver. > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/iavf/README | 8 +++

RE: [PATCH v1] net/ice: fix incorrect reading of PHY timestamp

2024-09-03 Thread Hore, Soumyadeep
Hi Bruce, Let's keep it separate for better tracking of the bug fix. On Fri, Aug 23, 2024 at 11:01:33AM +, Soumyadeep Hore wrote: > In E830 adapters, PHY timestamp for Tx packets should be read once the > ready status of PHY timestamp registers is 1. > > Fixes: 881169950d80 ("net/ice/base:

RE: [PATCH v1 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-22 Thread Hore, Soumyadeep
Hi Bruce, they should not be merged, they are solving different issues. On Thu, Aug 22, 2024 at 09:56:08AM +, Soumyadeep Hore wrote: > Correct the logic for determining the maximum PFA offset to include > the extra last word. Additionally, make the driver robust against > overflows by using

RE: [PATCH v5 16/21] drivers: add flex array support and fix issues

2024-07-01 Thread Hore, Soumyadeep
> With the internal Linux upstream feedback that is received on IDPF > driver and also some references available online, it is discouraged to > use 1-sized array fields in the structures, especially in the new > Linux drivers that are going to be upstreamed. Instead, it is > recommended to use

RE: [PATCH v5 15/21] common/idpf: add wmb before tail

2024-07-01 Thread Hore, Soumyadeep
> Introduced through customer's feedback in their attempt to address > some bugs this introduces a memory barrier before posting ctlq tail. > This makes sure memory writes have a chance to take place before HW > starts messing with the descriptors. > > Signed-off-by: Soumyadeep Hore > --- >Fr