[PATCH] mlx5: fix race at mlx5_dev_close

2024-04-10 Thread hepeng
From: "hepeng.0320" mlx5_dev_close currently will set priv->sh->port[priv->dev_port - 1].nl_ih_port_id to RTE_MAX_ETHPORTS to avoid mlx5_dev_interrupt_nl_cb to use the port's dev_private, because later the rte_eth_dev_close will free the dev_private and set the pointer

Re: [dpdk-dev] Missing an increment on vq->log_cache_nb_elem ?

2018-06-15 Thread HePeng
gt; >>> return; >>> } >>> >>> vq->log_cache[i].offset = offset; >>> vq->log_cache[i].val = (1UL << bit_nr); >>> } >>> >>> Did it just miss an increment on vq->log_cache_nb_elem ? >>

[dpdk-dev] Missing an increment on vq->log_cache_nb_elem ?

2018-06-14 Thread HePeng
Hi, In the latest dpdk master branch, in the function *vhost_log_cache_page*: static __rte_always_inline void vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, uint64_t page) { uint32_t bit_nr = page % (sizeof(unsigned long) << 3);

[dpdk-dev] missing vq->log_cache_nb_elem ++ ?

2018-06-13 Thread HePeng
Hi, In the latest dpdk master branch, in the function *vhost_log_cache_page*: static __rte_always_inline void vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, uint64_t page) { uint32_t bit_nr = page % (sizeof(unsigned long) << 3);

[dpdk-dev] Is there an interrupt mode PMD for virtio

2015-12-29 Thread HePeng
Hi, I am asking if there is an interrupt mode PMD for virtio driver. I check with l3fwd-power code, it is based on VFIO driver. However, it seems that current virtio driver does not support VFIO. Thanks. HePeng

[dpdk-dev] Is there an interrupt mode PMD for virtio

2015-12-29 Thread HePeng
Hi, I am asking if there is an interrupt mode PMD for virtio driver. I check with l3fwd-power code, it is based on VFIO driver. However, it seems that current virtio driver does not support VFIO. Thanks. HePeng

[dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs

2015-08-03 Thread HePeng
Hi, wenzhuo, Have to check that because I really had the panic when compile my code with dpdk 2.0.0. Also I checked the code in the dpdk git repo. It does not check the reference count, it just only calculate the begin positions of mbufs that really needs to be recycled.

[dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs

2015-08-03 Thread HePeng
huo ??? > > Hi Peng, > >> -Original Message- >> From: HePeng [mailto:xnhp0320 at icloud.com <mailto:xnhp0320 at icloud.com>] >> Sent: Monday, August 3, 2015 3:09 PM >> To: Lu, Wenzhuo >> Cc: dev at dpdk.org <mailto:dev at dpdk.org> >>

[dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs

2015-08-03 Thread HePeng
27;s refcnt check in rte_mbuf_sanity_check. I'm not sure what sanity > check you want to add. > Thanks. > >> -----Original Message- >> From: HePeng [mailto:xnhp0320 at icloud.com] >> Sent: Monday, August 3, 2015 10:54 AM >> To: Lu, Wenzhuo >> Subject: Re:

[dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs

2015-08-01 Thread hepeng
In *ixgbe_tx_free_bufs*, after recycling some tx entries, one should set their mbuf pointers to NULL. The first path is not correct, the txep->mbuf should be set to NULL no matter if it is recycled into mempool Signed-off-by: hepeng --- drivers/net/ixgbe/ixgbe_rxtx_vec.c | 13 -

[dpdk-dev] [PATCH] ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs

2015-08-01 Thread hepeng
In *ixgbe_tx_free_bufs*, after recycling some tx entries, one should set their mbuf pointers to NULL. Signed-off-by: hepeng --- drivers/net/ixgbe/ixgbe_rxtx_vec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe