("devargs: parse global device syntax")
Signed-off-by: Gaetan Rivet
---
lib/eal/common/eal_common_devargs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/eal/common/eal_common_devargs.c
b/lib/eal/common/eal_common_devargs.c
index 8c7650cf6c..184fe676aa 100644
--- a/lib/
The original triple negative was hard to read and the attempt
to improve the formulation was commendable, unfortunately the new
comment is the inverse of correct.
Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
Cc: step...@networkplumber.org
Signed-off-by: Ga
uses snprintf without a real need for it. Both can be
avoided, which improves the parsing performance.
The function is also simpler and shorter.
Signed-off-by: Gaetan Rivet
---
drivers/bus/dpaa/dpaa_bus.c | 68 +++--
1 file changed, 28 insertions(+), 40 deletions
uses snprintf without a real need for it. Both can be
avoided, which improves the parsing performance.
The function is also simpler and shorter.
Signed-off-by: Gaetan Rivet
---
drivers/bus/dpaa/dpaa_bus.c | 69 +++--
1 file changed, 27 insertions(+), 42 deletions
From: Ivan Ilchenko
rte_eth_dev_stop() return value was changed from void to int,
so this patch modify usage of this function across net/failsafe
according to new return type.
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
Hello Andrew,
Thanks for doing this. I had some com
state repeatedly.
Consider all devices when doing a removal round, but limit burst control
and stats saving to active devices.
Fixes: 598fb8aec6f6 ("net/failsafe: support device removal")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
drivers/net/failsafe/failsafe_et
ed.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/rte_pci.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
index d1ab6b414..e4ecdc32f 100644
--- a/lib/
] != ':'` afterward
will return -EINVAL.
Enforcing consistency between parsers by reading the code is not helped
by this property being implicit. Add a comment to explain.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/rte_pci.c | 4
1 file changed, 4 insertions(+)
diff -
Add a clarifying comment and fix the PCI addr parser behavior for
some edge-case.
Gaetan Rivet (2):
pci: fix allowing underflow when parsing PCI id
pci: explain how empty strings are rejected in DBDF
lib/librte_pci/rte_pci.c | 16
1 file changed, 16 insertions
:
* Long sentences that would be better cut short.
* Comma abuse.
* 'May' used where 'can' seems more fitting.
I'm not a native speaker though, so grain of salt applies.
Fixes: fdf7471cccb8 ("doc: introduce major ABI versions")
Cc: Ray Kinsella
cc: Neil
When modifying the rte_devargs implementation, a deprecation notice was
done for v18.11, regarding internal rte_devargs structure and exposed
functions.
Most of the changes were part of v18.11, but the notice was not removed.
Signed-off-by: Gaetan Rivet
---
doc/guides/rel_notes/deprecation.rst
Minor error, unless was used instead of unlike.
Cc: sta...@dpdk.org
Fixes: a3b85476c51e ("kvargs: add generic string matching callback")
Signed-off-by: Gaetan Rivet
---
lib/librte_kvargs/rte_kvargs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/lib
pointer properly in do_eth_dev_ring_create().
Cc: sta...@dpdk.org
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Signed-off-by: Gaetan Rivet
---
drivers/net/ring/rte_eth_ring.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
ix fd leak")
Signed-off-by: Gaetan Rivet
Cc: wangyunj...@huawei.com
Cc: Ali Alnubani
---
drivers/net/failsafe/failsafe.c | 1 +
drivers/net/failsafe/failsafe_private.h | 8
2 files changed, 9 insertions(+)
diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/
nd
write the pointer properly in do_eth_dev_ring_create().
Cc: sta...@dpdk.org
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Cc: ferruh.yi...@intel.com
Cc: tho...@monjalon.net
Signed-off-by: Gaetan Rivet
---
drivers/net/ring/rte_eth_ring.c | 36 ++---
Some issues seen on next-net.
Gaetan Rivet (3):
net/failsafe: avoid crash on malformed eth_dev
net/ring: fix eth_dev device pointer on allocation
net/failsafe: fix default service proxy state
drivers/net/failsafe/failsafe.c | 1 +
drivers/net/failsafe/failsafe_ether.c | 5
. Instead, warn the user of the error repeatedly.
The failsafe PMD can warn of the issue and continue. It will repeatedly
attempt to initialize the failed port and complain about it, which
should result in the same developer focus but with less crashing.
Signed-off-by: Gaetan Rivet
---
drivers/net
PMDs that could be simplified with it.
Cc: Chas Williams
Cc: Liron Himi
Cc: Andrew Rybchenko
Cc: Thomas Monjalon
Signed-off-by: Gaetan Rivet
---
Simplifies a recurring usage pattern.
This patch was integrated on top of a small bonding fixes patchset:
https://mails.dpdk.org/archives/dev
ned-off-by: Gaetan Rivet
---
drivers/net/bonding/rte_eth_bond_args.c | 58 +++--
1 file changed, 25 insertions(+), 33 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c
b/drivers/net/bonding/rte_eth_bond_args.c
index 35616fb8b..8c5f90dc6 100644
--- a/drivers/n
: new link bonding library")
Cc: sta...@dpdk.org
Cc: Chas Williams
Signed-off-by: Gaetan Rivet
---
drivers/net/bonding/rte_eth_bond_args.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c
b/drivers/net/bonding/rte_eth_bond_ar
rly at the time: the comment about lacking the proper
rte_bus_pci impl was already not correct anymore when the check on the kdrv
was removed. The necessary functions were already available I think.
Gaetan Rivet (2):
bonding: fix port id validity check on parsing
bonding: fix PCI address com
Supporting more than 2 sub-device is a remnant from earlier fail-safe
design, that was never actually published.
Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
doc/guides/nics/fail_safe.rst | 2 +-
1 file changed, 1 inser
The fail-safe documentation is subpar. It can be improved (1), and an
error is present from the beginning (2).
Gaetan Rivet (2):
doc/failsafe: improve fail-safe documentation
doc/failsafe: fix incorrect statement regarding number of sub-device
doc/guides/nics/fail_safe.rst | 109
Reading the fail-safe doc with a few years added, a few phrasing
choices are ambiguous or confusing.
Signed-off-by: Gaetan Rivet
---
doc/guides/nics/fail_safe.rst | 107 +-
1 file changed, 66 insertions(+), 41 deletions(-)
diff --git a/doc/guides/nics
ff-by: Somnath Kotur
---
v1->v2: Incorporated suggestions from Gaetan Rivet
drivers/bus/pci/linux/pci.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 740a2cd..71b0a30 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/driv
[...]
(gdb) p dev2
$5 = (struct rte_pci_device *) 0x54de5e0
(gdb) p /x *dev2
$6 = {next = {tqe_next = 0x5307460, tqe_prev = 0x5539f80}, device =
{next = {tqe_next = 0x0, tqe_prev = 0x0}, name = 0x54e4f00, driver =
0x3a6b7f0,
bus = 0x3a59a00, numa_node = 0x0, devargs = 0x0}, addr = {domain =
On 10/02/2020 15:34, Gaetan Rivet wrote:
Hi Somnath,
Reformating the mails, to keep with the inner-posting (mixing top-posting and
inner-posting
makes it hard to follow). See the end of the mail.
[...]
Any updates on this ?
My thoughts on this are just as I'd suspected / sugg
Hi Somnath,
Reformating the mails, to keep with the inner-posting (mixing top-posting and
inner-posting
makes it hard to follow). See the end of the mail.
On Wed, Feb 5, 2020 at 2:47 PM Gaetan Rivet wrote:
On 05/02/2020 09:52, Somnath Kotur wrote:
Hello Gaetan,
On Tue, Feb 4, 2020 at 3
On 05/02/2020 09:52, Somnath Kotur wrote:
Hello Gaetan,
On Tue, Feb 4, 2020 at 3:19 PM Gaetan Rivet wrote:
On 04/02/2020 10:15, Somnath Kotur wrote:
As per the comments in this code section, "since there is a matching device,
it is now its responsibility to manage the devargs we&#x
On 04/02/2020 16:06, Thomas Monjalon wrote:
04/02/2020 13:43, Gaetan Rivet:
On 04/02/2020 12:07, Thomas Monjalon wrote:
04/02/2020 11:03, Gaetan Rivet:
On 03/02/2020 23:21, Thomas Monjalon wrote:
03/02/2020 06:16, Pavan Nikhilesh Bhagavatula:
@David Marchand @tho...@monjalon.net
Ping?
Are
On 04/02/2020 12:07, Thomas Monjalon wrote:
04/02/2020 11:03, Gaetan Rivet:
On 03/02/2020 23:21, Thomas Monjalon wrote:
03/02/2020 06:16, Pavan Nikhilesh Bhagavatula:
@David Marchand @tho...@monjalon.net
Ping?
Are there any more changes required for this patch? It's been in queue
On 03/02/2020 23:21, Thomas Monjalon wrote:
03/02/2020 06:16, Pavan Nikhilesh Bhagavatula:
@David Marchand @tho...@monjalon.net
Ping?
Are there any more changes required for this patch? It's been in queue since
last October.
Sorry we have not decided whether it is a good idea or not.
All c
On 04/02/2020 10:15, Somnath Kotur wrote:
As per the comments in this code section, "since there is a matching device,
it is now its responsibility to manage the devargs we've just inserted."
But the matching device ptr's devargs is still uninitialized or not pointing
to the newest dev_args that
On 02/02/2020 12:21, Jerin Jacob wrote:
On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger
wrote:
On Fri, 31 Jan 2020 22:31:57 +0530
wrote:
+
+#define set_err(err, where, fmt, ...) do { \
+ graph_err(fmt, ##__VA_ARGS__);
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
Acked-by : Vamsi Attunuru
Tested-by: Vamsi Attunuru
Reviewed-by: Jerin
nyway in the meantime, not
sure whether there is anything to change.
Thanks for the rebase, I will follow-up if there are remarks blocking
the integration.
-Original Message-
From: dev On Behalf Of Gaetan Rivet
Sent: Friday, October 25, 2019 9:17 PM
To: dev@dpdk.org
Cc: Gaetan Rivet ;
My email address has changed, gaetan.ri...@6wind.com is no longer valid.
Signed-off-by: Gaetan Rivet
---
Sorry, I did not take the time to change it while I controlled it.
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
---
I haven't heard many opinions on the matter, please shout if yo
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
---
I haven't heard many opinions on the matter, please shout if yo
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
---
I haven't heard many opinions on the matter, please shout if yo
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
---
I haven't heard many opinions on the matter, please shout if yo
--vdev),
will be probed using the hotplug API, in the order they are declared.
This has the effect of offering a way for users to control probe order
of their devices, for drivers requiring it.
Signed-off-by: Gaetan Rivet
---
I haven't heard many opinions on the matter, please shout if yo
Make rte_option_register return a negative value when
an error occur.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_option.h | 6 +-
lib/librte_eal/common/rte_option.c | 8 +---
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal
Not only check against other registered options, but also common EAL
options. This will mitigate user confusion.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/rte_option.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/lib/librte_eal/common/rte_option.c
b/lib
INFO is not correct when logging an error.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/rte_option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_option.c
b/lib/librte_eal/common/rte_option.c
index ae8a0e2ca..b2c93b220 100644
--- a/lib
Use doxygen to describe the main structure and describe a little more
why it exists.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_option.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_option.h
b/lib
option->opt_* is redundant.
The field should also be constant.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_option.h | 2 +-
lib/librte_eal/common/rte_option.c | 8
lib/librte_telemetry/rte_telemetry.c | 2 +-
3 files changed, 6 insertions(+)
Add a usage string field in rte_option, allowing to display
help to the user and describe which options are currently available.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_options.c | 1 +
lib/librte_eal/common/eal_private.h| 7 +++
lib/librte_eal/common
Current options name can be passed with arbitrary format.
Force the use of "--" prefix and thus POSIX long options format.
This restricts the ability to introduce surprising options and will help
future additional checks.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/rte_opti
This is rather weird. Someone should have caught that during review.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/rte_option.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/rte_option.c
b/lib/librte_eal/common/rte_option.c
index
?)
- fix doc, improve API a little...
Gaetan Rivet (8):
option: use bare option string as name
option: do not use static iterator
option: add usage string
option: rename name field
option: check against common option on register
option: fix log level of error in register
option: improve
-by: Gaetan Rivet
---
I completely agree that we should change the coding style and force
all if()s to have brackets.
In the meantime, this patch might help alleviate the issue.
mk/toolchain/gcc/rte.vars.mk | 4
1 file changed, 4 insertions(+)
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk
Missing brackets around the if means that the loop will end at its first
iteration.
Cc: sta...@dpdk.org
Fixes: 2395332798d0 ("eal: add option register infrastructure")
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/rte_option.c | 3 ++-
1 file changed, 2 insertions(+),
rte_devargs_parsef will leak memory each time it is called.
The device string must be freed.
Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
CC: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 6 +-
1 file changed, 5
The interactive command
show port sfp_eeprom
will dump the content of the SFP EEPROM for the selected port.
Dumping SFP eeprom of all ports at once is not supported.
Signed-off-by: Gaetan Rivet
---
app/test-pmd/cmdline.c | 9 +++--
app/test-pmd/config.c | 32
rte_log() is available in the context of this compilation unit,
do not deter from using it.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c
b/lib/librte_eal/common
Add the --dev parameter to the EAL.
This new parameter takes a generic device declaration as argument.
It uses the new devargs parsing API.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 4 +++
lib/librte_eal/common/eal_common_options.c | 36
Introduce the facility to process future PCI parameters.
Once the matching between PCI devices and devargs has been done, it is
possible to process each devargs. New parameters would have the PCI
device handle to work with when parsing the device (bus specific)
parameters.
Signed-off-by: Gaetan
Process the eth parameters of a devargs.
For each parameters that have a setter implemented,
the relevant field in rte_eth_dev field is written.
Currently only "name" is implemented.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/ethdev_private.h | 5 +++
lib/librte_ethdev/rte_c
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Process each devargs privately prior to attempting a bus scan.
Prepare them if they are using the new devargs format.
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev.c | 10
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Instead of introducing a new bus API, process those devargs privately
for the moment. Prepare them for matching during scan against the
bus devices.
Signed-off-by: Gaetan Rivet
---
drivers
/class=eth,name=net_ring0
These devices may not be otherwise useful, some buses will spawn devices
to keep track of their assets without having a driver to use them.
Signed-off-by: Gaetan Rivet
Acked-by: Bernard Iremonger
---
app/test-pmd/cmdline.c | 54
Implement the operators of an rte_class for the
ethdev abstraction layer.
Register the layer as such.
Signed-off-by: Gaetan Rivet
Acked-by: Andrew Rybchenko
---
lib/librte_ethdev/Makefile| 3 +-
lib/librte_ethdev/meson.build | 1 +
lib/librte_ethdev/rte_class_eth.c | 79
The eth device class can now parse a field name,
matching the eth_dev name with one passed as
"class=eth,name=xx"
Signed-off-by: Gaetan Rivet
Acked-by: Andrew Rybchenko
---
lib/librte_ethdev/rte_class_eth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/lib
This iterator can be customized with a comparison function that will
trigger a stopping condition.
It can be leveraged to write several different iterators that have
similar but non-identical purposes.
It is private to librte_ethdev.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/Makefile
The vdev bus parses a field "driver", matching
a vdev driver name with one passed as follows:
"bus=vdev,driver="
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev_params.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --gi
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 3 +-
drivers/bus/vdev/meson.build| 5 +++-
drivers/bus/vdev/vdev.c | 10 ---
drivers/bus/vdev/vdev_params.c | 51 +
drivers/bus/vdev/vdev_private.h | 26 +
5
The PCI bus can now parse a matching field "id" as follows:
"bus=pci,id=:00:00.0"
or
"bus=pci,id=00:00.0"
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_params.c | 29 +++--
1 file changed, 27 insertions(+)
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/Makefile | 3 +-
drivers/bus/pci/meson.build | 6 +++-
drivers/bus/pci/pci_common.c | 3 +-
drivers/bus/pci/pci_params.c | 53
drivers/bus/pci/private.h| 25 +
5 files changed, 86
ly two PMDs, for now.
The new devargs format is also made available through the new --dev parameter.
Next work is to generalize use of new API for eth_dev creation,
compatibility layer for -w, -b and --vdev with --dev, and devargs unit test.
--
v2: fixed Andrew's and Stephen's remarks,
The interactive command
show port eeprom
will dump the content of the EEPROM for the selected port.
Dumping eeprom of all ports at once is not supported.
Signed-off-by: Gaetan Rivet
---
app/test-pmd/cmdline.c | 9 +++--
app/test-pmd/config.c | 32
app
Add support for passive device reset on IGB ports.
Signed-off-by: Gaetan Rivet
---
drivers/net/e1000/igb_ethdev.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 64dfe6836..4dbf46b28 100644
input.
The function strscpy has been discussed for some time already and
has been made available in the linux kernel[1].
Propose this new function as a safe alternative.
[1]: http://git.kernel.org/linus/30c44659f4a3
Signed-off-by: Gaetan Rivet
Acked-by: Juhamatti Kuusisaari
---
v2: use
Signed-off-by: Gaetan Rivet
---
I agree with the original email, here is a proposed implementation.
I have added the function as part of 18.11 API proper, because this API
is definitely not meant to change.
This is not meant to be enforced on existing code, or even on new code.
But I think it is
Add the --dev parameter to the EAL.
This new parameter takes a generic device declaration as argument.
It uses the new devargs parsing API.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 4 +++
lib/librte_eal/common/eal_common_options.c | 36
Introduce the facility to process future PCI parameters.
Once the matching between PCI devices and devargs has been done, it is
possible to process each devargs. New parameters would have the PCI
device handle to work with when parsing the device (bus specific)
parameters.
Signed-off-by: Gaetan
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Process each devargs privately prior to attempting a bus scan.
Prepare them if they are using the new devargs format.
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev.c | 10
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Instead of introducing a new bus API, process those devargs privately
for the moment. Prepare them for matching during scan against the
bus devices.
Signed-off-by: Gaetan Rivet
---
drivers
Process the class-specific arguments in a devargs.
This processing takes the form of setting the proper eth_dev fields when
relevant.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/eth_private.h | 5 +++
lib/librte_ethdev/rte_class_eth.c | 62 +++
lib
The eth device class can now parse a field name,
matching the eth_dev name with one passed as
"class=eth,name=xx"
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/rte_class_eth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/librte_ethdev/rte_class_et
/class=eth,name=net_ring0
These devices may not be otherwise useful, some buses will spawn devices
to keep track of their assets without having a driver to use them.
Signed-off-by: Gaetan Rivet
Acked-by: Bernard Iremonger
---
app/test-pmd/cmdline.c | 54
The vdev bus parses a field "driver", matching
a vdev driver name with one passed as follows:
"bus=vdev,driver="
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev_params.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --gi
This iterator can be customized with a comparison function that will
trigger a stopping condition.
It can be leveraged to write several different iterators that have
similar but non-identical purposes.
It is private to librte_ethdev.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/Makefile
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/Makefile| 3 +-
lib/librte_ethdev/meson.build | 1 +
lib/librte_ethdev/rte_class_eth.c | 79 +++
3 files changed, 82 insertions(+), 1 deletion(-)
create mode 100644 lib/librte_ethdev/rte_class_eth.c
The PCI bus can now parse a matching field "id" as follows:
"bus=pci,id=:00:00.0"
or
"bus=pci,id=00:00.0"
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_params.c | 29 +++--
1 file changed, 27 insertions(+)
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 3 +-
drivers/bus/vdev/meson.build| 5 +++-
drivers/bus/vdev/vdev.c | 10 ---
drivers/bus/vdev/vdev_params.c | 51 +
drivers/bus/vdev/vdev_private.h | 26 +
5
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/Makefile | 3 +-
drivers/bus/pci/meson.build | 6 +++-
drivers/bus/pci/pci_common.c | 3 +-
drivers/bus/pci/pci_params.c | 53
drivers/bus/pci/private.h| 25 +
5 files changed, 86
ly two PMDs, for now.
The new devargs format is also made available through the new --dev parameter.
Next work is to generalize use of new API for eth_dev creation,
compatibility layer for -w, -b and --vdev with --dev, and devargs unit test.
Gaetan Rivet (13):
bus/pci: implement device iteration
Add the --dev parameter to the EAL.
This new parameter takes a generic device declaration as argument.
It uses the new devargs parsing API.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 4 +++
lib/librte_eal/common/eal_common_options.c | 36
Process the class-specific arguments in a devargs.
This processing takes the form of setting the proper eth_dev fields when
relevant.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/eth_private.h | 5 +++
lib/librte_ethdev/rte_class_eth.c | 62 +++
lib
The eth device class can now parse a field name,
matching the eth_dev name with one passed as
"class=eth,name=xx"
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/rte_class_eth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/librte_ethdev/rte_class_et
/class=eth,name=net_ring0
These devices may not be otherwise useful, some buses will spawn devices
to keep track of their assets without having a driver to use them.
Signed-off-by: Gaetan Rivet
Acked-by: Bernard Iremonger
---
app/test-pmd/cmdline.c | 54
Introduce the facility to process future PCI parameters.
Once the matching between PCI devices and devargs has been done, it is
possible to process each devargs. New parameters would have the PCI
device handle to work with when parsing the device (bus specific)
parameters.
Signed-off-by: Gaetan
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Process each devargs privately prior to attempting a bus scan.
Prepare them if they are using the new devargs format.
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev.c | 10
The new devargs format does not recognize a particular device name.
Each bus uses its specific format.
Instead of introducing a new bus API, process those devargs privately
for the moment. Prepare them for matching during scan against the
bus devices.
Signed-off-by: Gaetan Rivet
---
drivers
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/Makefile| 3 +-
lib/librte_ethdev/meson.build | 1 +
lib/librte_ethdev/rte_class_eth.c | 79 +++
3 files changed, 82 insertions(+), 1 deletion(-)
create mode 100644 lib/librte_ethdev/rte_class_eth.c
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 3 +-
drivers/bus/vdev/meson.build| 5 +++-
drivers/bus/vdev/vdev.c | 10 ---
drivers/bus/vdev/vdev_params.c | 51 +
drivers/bus/vdev/vdev_private.h | 26 +
5
The PCI bus can now parse a matching field "id" as follows:
"bus=pci,id=:00:00.0"
or
"bus=pci,id=00:00.0"
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_params.c | 29 +++--
1 file changed, 27 insertions(+)
This iterator can be customized with a comparison function that will
trigger a stopping condition.
It can be leveraged to write several different iterators that have
similar but non-identical purposes.
It is private to librte_ethdev.
Signed-off-by: Gaetan Rivet
---
lib/librte_ethdev/Makefile
The vdev bus parses a field "driver", matching
a vdev driver name with one passed as follows:
"bus=vdev,driver="
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev_params.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --gi
1 - 100 of 1245 matches
Mail list logo
