Thanks Kevin for bringing this up.
See below.
On Mon, Nov 15, 2021 at 1:06 PM Kevin Traynor wrote:
> On 15/11/2021 14:58, Thomas Monjalon wrote:
> > For the last 5 years, DPDK was doing 4 releases per year,
> > in February, May, August and November (the LTS one):
> > .02 .05 .08 .11
t; +vhost_dequeue_offload_legacy(struct virtio_net_hdr *hdr, struct rte_mbuf *m)
> {
> uint16_t l4_proto = 0;
> void *l4_hdr = NULL;
> struct rte_tcp_hdr *tcp_hdr = NULL;
>
> - if (hdr->flags == 0 && hdr->gso_type == VIRTIO_NET_HDR_GSO_NONE)
&g
PKT_RX_LRO | PKT_RX_L4_CKSUM_NONE;
My understanding of the virtio 1.1 spec is that GSO can be
used independently of CSUM. There is nothing preventing to
send a fully checksummed TSO packet.
Anyways, that's unusual and not the goal of this patch.
Acked-by: Flavio Leitner
fbl
> +
y: Maxime Coquelin
> ---
Acked-by: Flavio Leitner
On Fri, Apr 09, 2021 at 03:30:18PM +0200, Olivier Matz wrote:
> On Thu, Apr 08, 2021 at 09:58:35AM -0300, Flavio Leitner wrote:
> > On Thu, Apr 08, 2021 at 02:05:21PM +0200, Olivier Matz wrote:
> > > On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote:
> > > &
not done in this patch for now so TSO activation is forcibly
> refused.
>
> Fixes: 859b480d5afd ("vhost: add guest offload setting")
There is change that before ECN was ignored and now it is invalid.
I think that's the right way to go, but not sure if virtio blocks
the negotiation of that feature.
Reviewed-by: Flavio Leitner
fbl
igned-off-by: David Marchand
> ---
Reviewed-by: Flavio Leitner
On Thu, Apr 08, 2021 at 02:05:21PM +0200, Olivier Matz wrote:
> On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote:
> > On Thu, Apr 08, 2021 at 09:41:59AM +0200, Olivier Matz wrote:
> > > On Wed, Apr 07, 2021 at 05:15:39PM -0300, Flavio Leitner wrote:
> > > &
On Thu, Apr 08, 2021 at 09:41:59AM +0200, Olivier Matz wrote:
> On Wed, Apr 07, 2021 at 05:15:39PM -0300, Flavio Leitner wrote:
> > On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> > > Tx offload flags are of the application responsibility.
> > > Leave t
On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> Tx offload flags are of the application responsibility.
> Leave the mbuf alone and check for TSO where needed.
>
> Signed-off-by: David Marchand
> ---
The patch looks good, but maybe a better approach would be
to change the docume
> Signed-off-by: David Marchand
> ---
Reviewed-by: Flavio Leitner
ime Coquelin
> * fixed mbuf alloc errors for packed virtqueues - Maxime Coquelin
> * fixed mbuf copy errors - Flavio Leitner
>
> Signed-off-by: Sivaprasad Tummala
> ---
> lib/librte_vhost/virtio_net.c | 50 ++-
> 1 file changed, 37 insertions(
On Wed, Apr 29, 2020 at 10:43:01AM +0200, Maxime Coquelin wrote:
> Hi Sivaprasad,
>
> On 4/28/20 11:52 AM, Sivaprasad Tummala wrote:
> > vhost buffer allocation is successful for packets that fit
> > into a linear buffer. If it fails, vhost library is expected
> > to drop the current buffer descri
On Tue, 29 Oct 2019 10:02:57 +0100
David Marchand wrote:
> On Tue, Oct 15, 2019 at 9:00 PM Flavio Leitner
> wrote:
> > diff --git a/lib/librte_vhost/virtio_net.c
> > b/lib/librte_vhost/virtio_net.c index 5b85b832d..da69ab1db 100644
> > --- a/lib/librte_vhost/vi
On Thu, 24 Oct 2019 16:32:43 +0200
Maxime Coquelin wrote:
> Hi Flavio,
>
> On 10/24/19 4:28 PM, Flavio Leitner wrote:
> > Currently the IPv4 header checksum is calculated including its
> > current value, which can be a valid checksum or just garbage.
> > In any cas
ae ("vhost: fix IP checksum")
Cc: sta...@dpdk.org
Signed-off-by: Flavio Leitner
---
lib/librte_vhost/virtio_net.c | 1 +
1 file changed, 1 insertion(+)
v2:
CC stable
Added 'Fixes:' line.
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index eae78
checksum algorithm is:
The checksum field is the 16 bit one's complement of the one's
complement sum of all 16 bit words in the header. For purposes of
computing the checksum, the value of the checksum field is zero.
Thus force the csum field to always be zero.
Signed-off-by: Flav
s removed while introducing extbuf
> support for large buffers. But it was useful for catching
> mempool issues and needs to be returned back.
>
> Cc: Flavio Leitner
>
> Fixes: 5005bcda7123 ("vhost: add support for large buffers")
> Signed-off-by: Ilya Maximets
On Wed, 16 Oct 2019 16:08:54 +0200
Ilya Maximets wrote:
> On 16.10.2019 16:02, Flavio Leitner wrote:
> > On Wed, 16 Oct 2019 15:46:15 +0200
> > Maxime Coquelin wrote:
> >
> >> On 10/16/19 3:32 PM, Ilya Maximets wrote:
> >>>
On Wed, 16 Oct 2019 15:46:15 +0200
Maxime Coquelin wrote:
> On 10/16/19 3:32 PM, Ilya Maximets wrote:
> > On 16.10.2019 13:13, Maxime Coquelin wrote:
> >>
> >>
> >> On 10/15/19 8:59 PM, Flavio Leitner wrote:
> >>> The rte_vhost_dequeue_burst s
during registration if
attaching an external buffer to pktmbuf is supported and if
only linear buffer are supported.
Signed-off-by: Flavio Leitner
---
doc/guides/prog_guide/vhost_lib.rst | 35 +
lib/librte_vhost/rte_vhost.h| 4 +
lib/librte_vhost/socket.c | 22 ++
lib
On Tue, 15 Oct 2019 19:41:52 +0200
Ilya Maximets wrote:
> Hi.
> Not a full review. Few comments inline.
>
> Best regards, Ilya Maximets.
Thanks for reviewing Ilya, see below.
[...]
> > @@ -870,6 +878,8 @@ rte_vhost_driver_register(const char *path,
> > uint64_t flags) goto out_free;
> > }
during registration if
attaching an external buffer to pktmbuf is supported and if
only linear buffer are supported.
Signed-off-by: Flavio Leitner
---
doc/guides/prog_guide/vhost_lib.rst | 35 +
lib/librte_vhost/rte_vhost.h| 4 +
lib/librte_vhost/socket.c | 22 ++
lib
during registration if
attaching an external buffer to pktmbuf is supported and if
only linear buffer are supported.
Signed-off-by: Flavio Leitner
---
doc/guides/prog_guide/vhost_lib.rst | 35 +
lib/librte_vhost/rte_vhost.h| 4 ++
lib/librte_vhost/socket.c | 22
of the title should be dropped.
>
> On Fri, Oct 04, 2019 at 05:10:08PM -0300, Flavio Leitner wrote:
> > The rte_vhost_dequeue_burst supports two ways of dequeuing data.
> > If the data fits into a buffer, then all data is copied and a
> > single linear buffer is returned. Otherwis
pktmbuf is supported and if
only linear buffer are supported.
Signed-off-by: Flavio Leitner
---
doc/guides/prog_guide/vhost_lib.rst | 35 ++
lib/librte_vhost/rte_vhost.h| 4 ++
lib/librte_vhost/socket.c | 10 +++
lib/librte_vhost/vhost.c| 22 ++
lib
On Thu, 3 Oct 2019 18:57:32 +0200
Ilya Maximets wrote:
> On 02.10.2019 20:15, Flavio Leitner wrote:
> > On Wed, 2 Oct 2019 17:50:41 +
> > Shahaf Shuler wrote:
> >
> >> Wednesday, October 2, 2019 3:59 PM, Flavio Leitner:
> >>> Obrembski Mic
On Wed, 2 Oct 2019 17:50:41 +
Shahaf Shuler wrote:
> Wednesday, October 2, 2019 3:59 PM, Flavio Leitner:
> > Obrembski MichalX ; Stokes Ian
> >
> > Subject: Re: [dpdk-dev] [PATCH] vhost: add support to large linear
> > mbufs
> >
> >
> > Hi
; Hello Shahaf,
> >
> > On Wed, Oct 2, 2019 at 6:46 AM Shahaf Shuler
> > wrote:
> > >
> > > Wednesday, October 2, 2019 1:20 AM, Flavio Leitner:
> > > > Subject: [dpdk-dev] [PATCH] vhost: add support to large linear
> > > > mbufs
>
On Tue, 1 Oct 2019 19:19:35 -0300
Flavio Leitner wrote:
> The rte_vhost_dequeue_burst supports two ways of dequeuing data. If
> the data fits into a buffer, then all data is copied and a single
> linear buffer is returned. Otherwise it allocates additional mbufs
> and chains them
containing larger mbufs. If that
is not provided (NULL), the behavior remains as before the change.
Otherwise, the data size is checked and the corresponding mempool
is used to return linear mbufs.
Signed-off-by: Flavio Leitner
---
drivers/net/vhost/rte_eth_vhost.c | 4 +--
examples
On Wed, Apr 18, 2018 at 11:17:47AM -0700, Stephen Hemminger wrote:
> On Wed, 18 Apr 2018 11:11:01 -0300
> Flavio Leitner wrote:
>
> > On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote:
> > > My vote is to work with udev and not try to replace it.
> >
On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote:
> My vote is to work with udev and not try to replace it.
>
> Driverctl works well. Just not for bifurcated driver
I second that. We also have other system configs to care about like
kernel parameters and hugepage configuration w
On Tue, 03 Oct 2017 17:17:53 +0200
Thomas Monjalon wrote:
> 03/10/2017 16:29, Mokhtar, Amr:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > 25/08/2017 15:46, Amr Mokhtar:
> > > > +int
> > > > +rte_bbdev_configure(uint8_t dev_id, uint16_t num_queues,
> > > > + const
On Mon, Sep 26, 2016 at 11:43:37AM -0400, Aaron Conole wrote:
> My only concern is whether this change would be considered ABI
> breaking. I wouldn't think so, since it doesn't seem as though an
> application would want to call this explicitly (and is spelled out as
> such), but I can't be sure th
An application might be linked to DPDK but not really use it,
so move the cpu flag check to the EAL initialization instead.
Signed-off-by: Flavio Leitner
---
lib/librte_eal/bsdapp/eal/eal.c | 3 +++
lib/librte_eal/common/eal_common_cpuflags.c | 6 --
lib/librte_eal/linuxapp/eal
On Tue, Apr 05, 2016 at 01:47:33PM +0800, Yuanhan Liu wrote:
> On Fri, Feb 19, 2016 at 03:06:50PM +0800, Yuanhan Liu wrote:
> > On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote:
> > > Array of buf_vector's is just an array for temporary storing information
> > > about available descrip
On Tue, Nov 17, 2015 at 10:23:38AM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 16, 2015 at 02:20:57PM -0800, Flavio Leitner wrote:
> > On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote:
> > > On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote:
>
On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote:
> > On Sat, Oct 24, 2015 at 08:47:10PM +0300, Michael S. Tsirkin wrote:
> > > On Sat, Oct 24, 2015 at 12:34:08AM -0200, Flavio Leitner wrote:
>
On Wed, Oct 28, 2015 at 12:47:40PM +0900, Tetsuya Mukawa wrote:
> The patch fixes wrong handling of virtqueue array index when
> GET_VRING_BASE message comes.
>
> Signed-off-by: Tetsuya Mukawa
> ---
vhost-user segfaults without this patch with MQ enabled.
LGTM
Acked-by: Flavio Leitner
On Sat, Oct 24, 2015 at 08:47:10PM +0300, Michael S. Tsirkin wrote:
> On Sat, Oct 24, 2015 at 12:34:08AM -0200, Flavio Leitner wrote:
> > On Thu, Oct 22, 2015 at 02:32:31PM +0300, Michael S. Tsirkin wrote:
> > > On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote:
>
On Thu, Oct 22, 2015 at 02:32:31PM +0300, Michael S. Tsirkin wrote:
> On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote:
> > On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote:
> > > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote:
> > > > > Please note that fo
packet tx/rx
> testing.
>
>
>
> Test with OVS
> =
>
> Marcel also created a simple yet quite clear test guide with OVS at:
>
>http://wiki.qemu.org/Features/vhost-user-ovs-dpdk
>
> BTW, Marcel, would you please complete the page on mq testing?
>
>
> ---
I reviewed the patch and tested with success using Open vSwitch.
The Open vSwitch patch is posted here:
http://openvswitch.org/pipermail/dev/2015-October/061413.html
Acked-by: Flavio Leitner
Thanks,
fbl
On Thu, Sep 10, 2015 at 02:43:59PM +0200, Thomas Monjalon wrote:
> 2015-09-09 12:56, O'Driscoll, Tim:
> > Vhost Multi-Queue Support: The vhost-user library will be updated to
> > provide multi-queue support in the host similar to the RSS model so that
> > guest driver may allocate multiple rx/tx
On Fri, Aug 14, 2015 at 04:04:40PM +, Gray, Mark D wrote:
> Hi Daniele,
>
> Thanks for starting this conversation. It is a good list :) I have
> crossed-posted this
> to dpdk.org as I feel that some of the points could be interesting to that
> community
> as they are related to how DPDK is u
On Fri, Aug 14, 2015 at 02:29:51AM +, Ouyang, Changchun wrote:
> > -Original Message-
> > From: Flavio Leitner [mailto:fbl at sysclose.org]
> > Sent: Thursday, August 13, 2015 8:52 PM
> > To: Ouyang, Changchun
> > Cc: dev at dpdk.org
> > Subject: R
On Wed, Aug 12, 2015 at 04:02:37PM +0800, Ouyang Changchun wrote:
> Each virtio device could have multiple queues, say 2 or 4, at most 8.
> Enabling this feature allows virtio device/port on guest has the ability to
> use different vCPU to receive/transmit packets from/to each queue.
>
> In multip
On Tue, Aug 11, 2015 at 01:10:10PM +, Mcnamara, John wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Weglicki, MichalX
> > Sent: Tuesday, August 11, 2015 11:40 AM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] DPDK2.1 (rc3 & rc4) major performa
On Mon, Jun 15, 2015 at 03:56:39PM +0800, Ouyang Changchun wrote:
> Each virtio device could have multiple queues, say 2 or 4, at most 8.
> Enabling this feature allows virtio device/port on guest has the ability to
> use different vCPU to receive/transmit packets from/to each queue.
>
> In multip
On Mon, Jun 15, 2015 at 03:56:39PM +0800, Ouyang Changchun wrote:
> Each virtio device could have multiple queues, say 2 or 4, at most 8.
> Enabling this feature allows virtio device/port on guest has the ability to
> use different vCPU to receive/transmit packets from/to each queue.
>
> In multip
On Wed, 29 Apr 2015 13:56:58 +0200
Thomas Monjalon wrote:
> 2015-04-29 13:38 GMT+02:00 Panu Matilainen :
> > On 04/29/2015 02:29 PM, Huawei Xie wrote:
> >>
> >> vhost enabled vSwitch could have their own thread-safe vring
> >> enqueue policy.
> >> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for v
e build issue here.
Reported-by: Flavio Leitner
Tested-by: Flavio Leitner
Thanks Neil!
fbl
On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote:
> Hi Flavio,
>
> 2014-07-01 15:19, Flavio Leitner:
> > The SET_ETHTOOL_OPS has been removed from upstream, so it
> > breaks the dpdk build with recent kernels.
> >
> > Signed-off-by: Flav
The SET_ETHTOOL_OPS has been removed from upstream, so it
breaks the dpdk build with recent kernels.
Signed-off-by: Flavio Leitner
---
lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 4 ++--
lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h | 1 -
lib/librte_eal/linuxapp/kni
54 matches
Mail list logo
