RE: [EXT] [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Devendra Singh Rawat
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, December 13, 2023 10:06 PM >To: dev@dpdk.org >Cc: Stephen Hemminger ; Devendra Singh >Rawat ; Alok Prasad >Subject: [EXT] [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with >rte_

RE: [EXT] [PATCH v5 19/19] drivers: remove use of term sanity check

2023-11-29 Thread Devendra Singh Rawat
eswara Rao Kottidi ; Andrew Rybchenko >; Bruce Richardson >; Kevin Laatz ; Chas >Williams ; Min Hu (Connor) ; Liron >Himi ; Chaoyong He ; >Devendra Singh Rawat ; Alok Prasad > >Subject: [EXT] [PATCH v5 19/19] drivers: r

RE: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check

2023-08-02 Thread Devendra Singh Rawat
; Bruce Richardson ; Kevin Laatz ; Chas Williams ; Min Hu (Connor) ; Liron Himi ; Chaoyong He ; Niklas Söderlund ; Devendra Singh Rawat ; Alok Prasad Subject: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check External Email

[PATCH] net/qede: fix RSS indirection table initialization

2023-05-25 Thread Devendra Singh Rawat
ned-off-by: Devendra Singh Rawat Signed-off-by: Alok Prasad --- drivers/net/qede/qede_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index a4923670d6..22cd470646 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/driver

[PATCH] net/qede: fix RSS indirection table initialization

2023-05-25 Thread Devendra Singh Rawat
RSS indirection table was not updated for VF ports during RSS hash update, this resulted in device start failure. This fix updates RSS indirection table during RSS hash update. Fixes: 7ab35bf6b97b (net/qede: fix RSS) Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Alok

[PATCH] net/qede: fix RSS indirection table initialization

2023-05-24 Thread Devendra Singh Rawat
RSS indirection table was not updated for VF ports during RSS hash update, this resulted in device start failure. This fix updates RSS indirection table during RSS hash update. Fixes: 7ab35bf6b97b (net/qede: fix RSS) Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Alok

RE: [EXT] [PATCH 20/20] Remove use of term sanity check

2023-05-18 Thread Devendra Singh Rawat
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, May 17, 2023 9:46 PM >To: dev@dpdk.org >Cc: Stephen Hemminger ; Hemant Agrawal >; Sachin Saxena ; Bruce >Richardson ; Kevin Laatz >; Chas Williams ; Min Hu (Connor) >; Liron Himi ; Devendra

RE: [EXT] [RFC] lib: set/get max memzone segments

2023-04-19 Thread Devendra Singh Rawat
>diff --git a/drivers/net/qede/base/bcm_osal.c >b/drivers/net/qede/base/bcm_osal.c >index 2c59397..f195f2c 100644 >--- a/drivers/net/qede/base/bcm_osal.c >+++ b/drivers/net/qede/base/bcm_osal.c >@@ -47,10 +47,26 @@ void osal_poll_mode_dpc(osal_int_ptr_t >hwfn_cookie) } > > /* Array of memzone poi

Re: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths

2023-03-09 Thread Devendra Singh Rawat
at is your opinion? > Both the maintainers for bnx2x PMD have left Marvell, We are in process of finalizing new maintainers for this PMD. Meanwhile I have reviewed the patch and I am Acking it. Acked-by: Devendra Singh Rawat

[PATCH] MAINTAINERS: update maintainers list for qede

2023-03-09 Thread Devendra Singh Rawat
Add new maintainer and remove old one from list for qede PMD. Signed-off-by: Devendra Singh Rawat --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 878204c93b..bdd5c311bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -936,8

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

2022-07-26 Thread Devendra Singh Rawat
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 19/20] remove repeated word &#x

RE: [EXT] [PATCH] net/qede: fix build with GCC 13

2022-06-20 Thread Devendra Singh Rawat
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 16, 2022 10:32 PM > To: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org > Subject: [EXT] [PATCH] net/qede: fix build with GC

RE: [EXT] Re: [PATCH 1/3] net/qede: fix Tx callback completion routine

2022-03-10 Thread Devendra Singh Rawat
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 10, 2022 2:26 PM > To: Devendra Singh Rawat ; Jerin Jacob > > Cc: dpdk-dev ; Jerin Jacob Kollanukkaran > ; Ferruh Yigit ; Rasesh Mody > ; Alok Prasad ; dpdk stable > > Subject: [EXT] Re

[PATCH 3/3] net/qede: fix max Rx pktlen calculation

2022-03-04 Thread Devendra Singh Rawat
size of CRC is not added to max_rx_pktlen, due to this bigger sized packets(size 1480, 1490 1500) are being dropped. This fix adds RTE_ETHER_CRC_LEN to max_rx_pktlen. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Sig

[PATCH 2/3] net/qede: fix Rx callback

2022-03-04 Thread Devendra Singh Rawat
: fix performance bottleneck in Rx path") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 68 1 file changed, 31 insertions(+), 37 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c

[PATCH 1/3] net/qede: fix Tx callback completion routine

2022-03-04 Thread Devendra Singh Rawat
bulk") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 79 +++- 1 file changed, 33 insertions(+), 46 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxt

RE: [EXT] [PATCH v2 63/83] net/qede: remove unnecessary NULL checks

2022-01-24 Thread Devendra Singh Rawat
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 11:17 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 63/83] net/qede: remove unnecessary NULL check

RE: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug code

2022-01-09 Thread Devendra Singh Rawat
> -Original Message- > From: Jerin Jacob > Sent: Monday, January 10, 2022 12:50 PM > To: Anatoly Burakov > Cc: dpdk-dev ; Rasesh Mody ; > Devendra Singh Rawat ; Igor Russkikh > ; dpdk stable > Subject: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant c

Re: [dpdk-dev] [EXT] [PATCH v3 1/5] net/qede: fix minsize build

2021-08-08 Thread Devendra Singh Rawat
-Original Message- From: Thomas Monjalon Sent: Sunday, August 8, 2021 6:22 PM To: dev@dpdk.org Cc: bruce.richard...@intel.com; david.march...@redhat.com; Rasesh Mody ; Devendra Singh Rawat Subject: [EXT] [PATCH v3 1/5] net/qede: fix minsize build External Email

Re: [dpdk-dev] [PATCH 2/2] maint changes for marvell qlogic drivers

2021-07-29 Thread Devendra Singh Rawat
>-Original Message- >From: Igor Russkikh >Sent: Tuesday, July 27, 2021 1:33 PM >To: dev@dpdk.org >Cc: Rasesh Mody ; Devendra Singh Rawat >; Ferruh Yigit ; >jerinjac...@gmail.com; Igor Russkikh >Subject: [PATCH 2/2] maint changes for marvell qlogic drivers >

Re: [dpdk-dev] [PATCH] fix Marvell maintainer email for atlantic

2021-06-01 Thread Devendra Singh Rawat
ACK for Marvell QLogic qede PMD. Thanks, Devendra > -Original Message- > From: Igor Russkikh > Sent: Tuesday, May 25, 2021 3:27 PM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Jerin Jacob Kollanukkaran > ; Rasesh Mody ; Devendra Singh > Rawat ; Ariel Elior ; Igor

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-21 Thread Devendra Singh Rawat
> -Original Message- > From: Igor Russkikh > Sent: Friday, March 19, 2021 3:17 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh > Subject: [PATCH v2 0/2] qede: 2020-02 minor fixes > > Two small fixes after customer feedback.

Re: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables

2021-03-21 Thread Devendra Singh Rawat
Sure Igor, I will do that. Thanks, Devendra > -Original Message- > From: Igor Russkikh > Sent: Friday, March 19, 2021 3:18 PM > To: Devendra Singh Rawat ; dev@dpdk.org > Cc: Rasesh Mody ; sta...@dpdk.org > Subject: RE: [PATCH 2/2] qede: make driver accept bigger rss ta

Re: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables

2021-03-11 Thread Devendra Singh Rawat
> -Original Message- > From: Igor Russkikh > Sent: Sunday, February 21, 2021 4:47 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh ; > sta...@dpdk.org > Subject: [PATCH 2/2] qede: make driver accept bigger rss tables > > W

Re: [dpdk-dev] [PATCH 1/2] qede: reduce trace verbosity level

2021-03-11 Thread Devendra Singh Rawat
> -Original Message- > From: Igor Russkikh > Sent: Sunday, February 21, 2021 4:47 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh ; > sta...@dpdk.org > Subject: [PATCH 1/2] qede: reduce trace verbosity level > > On some ha

Re: [dpdk-dev] [PATCH] fix maintainers for qede driver

2021-03-11 Thread Devendra Singh Rawat
> -Original Message- > From: Igor Russkikh > Sent: Wednesday, March 10, 2021 1:47 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Jerin Jacob ; Igor > Russkikh > Subject: [PATCH] fix maintainers for qede driver > > Removing Shahed, addi

Re: [dpdk-dev] [PATCH v2] net/qede: change driver's default load parameter

2021-01-06 Thread Devendra Singh Rawat
> -Original Message- > From: Devendra Singh Rawat > Sent: Wednesday, January 6, 2021 6:50 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > ferruh.yi...@intel.com > Cc: GR-Everest-DPDK-Dev ; Igor > Russkikh ; Rasesh Mody ; > Manish Chopra ; Devendra Singh R

[dpdk-dev] [PATCH v2] net/qede: change driver's default load parameter

2021-01-06 Thread Devendra Singh Rawat
should be allowed to load, otherwise MFW should fail the load request. Fixes: c5e1108920 ("alter driver's force load behavior") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- doc/guides/nics/qede.rst |

Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9

2020-12-30 Thread Devendra Singh Rawat
Adding more people to comment/investigate here. Devendra, could it be that we don't consider subsequent calls of promisc_enabled + allmulti_enable ? Devendra >> yes, I agree that as long as promiscuous mode is enabled for a port, all traffic should be accepted even if allmulticast is enabled l

[dpdk-dev] [PATCH] net/qede: change driver's default load parameter

2020-12-03 Thread Devendra Singh Rawat
should be allowed to load, otherwise MFW should fail the load request. Fixes: c5e1108920 ("alter driver's force load behavior") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_main.c

[dpdk-dev] rte APIs for allocating IOVA contiguous memory

2020-09-18 Thread Devendra Singh Rawat
Apart from using rte_memzone_reserve_* APIs, is there any other way to allocate IOVA contiguous memory block in DPDK ? If I am correct there is no 'rte' API to allocate an anonymous IOVA contiguous memory block from a heap, right ? My PMD needs to allocate many IOVA contiguous memory blocks o

[dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro

2020-07-27 Thread Devendra Singh Rawat
The macro defined for milliseconds sleep was not putting the thread to sleep and was simply calling a delay routine. This fix redefines the macro to call the correct rte sleep API. Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat

[dpdk-dev] [PATCH] net/qede: fix multicast pkts drop in promisc mode

2020-06-18 Thread Devendra Singh Rawat
VF-VF traffic with unmatched dest address") Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Igor Russkikh Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/driver