[dpdk-dev] [PATCH] common/mlx5: fix output buffer size calculation

2021-02-18 Thread Dekel Peled
Previous patch included a glue function call, with wrong size calculation for an output buffer. This patch fixes the issue, using the correct size calculation. Fixes: bb7ef9a96281 ("common/mlx5: add register access DevX routine") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked

[dpdk-dev] [PATCH] app/testpmd: fix support for shared age action query

2021-02-04 Thread Dekel Peled
Shared age action query was implemented as part of flow query, but was not implemented as part of shared action query. This patch adds the required implementation. Fixes: 2f622174bf86 ("app/testpmd: support query of age action") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked

[dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue pointer

2021-02-03 Thread Dekel Peled
indicate error. Fixes: e1592b6c4dea ("net/mlx5: make Rx queue thread safe") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/driver

[dpdk-dev] [PATCH] net/mlx5: fix check of shared RSS capability

2021-02-03 Thread Dekel Peled
ion. This patch adds check of driver capability, and fails the validation for shared RSS action in case it is insufficient. Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and cleanup

2021-02-01 Thread Dekel Peled
prove code readability, this patch renames all to "shared_rss". Fixes: d7cfcddded61 ("net/mlx5: translate shared action for RSS action") Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by:

[dpdk-dev] [PATCH] net/mlx5: update flow meter capability flags names

2021-01-31 Thread Dekel Peled
Existing names of the flags denoting flow meter capability are unclear and may be misleading. This patch updates the names to align with the updated documentation. Comments were edited, describing the names clearly. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix flow split combined with age action

2021-01-17 Thread Dekel Peled
ned-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow_dv.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 860ef9aa01..11adc138f8 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/driver

[dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counter

2021-01-17 Thread Dekel Peled
. Need to create just one counter per flow, and use it for all sub-flows. This patch adds the required check to make sure a counter is created just once per flow, and used by all sub-flows. Fixes: fa2d01c87d2b ("net/mlx5: support flow aging") Cc: sta...@dpdk.org Signed-off-by: D

[dpdk-dev] [PATCH v2] net/mlx5: fix flow check hairpin split

2021-01-10 Thread Dekel Peled
flows were wrongly handled. This patch adds the required check for return value is NULL. Fixes: 509f8470de55 ("net/mlx5: do not split hairpin flow in explicit mode") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- v2: update conditions according to coding

[dpdk-dev] [PATCH] net/mlx5: fix flow check hairpin split

2021-01-03 Thread Dekel Peled
flows were wrongly handled. This patch adds the required check for return value is NULL. Fixes: 509f8470de55 ("net/mlx5: do not split hairpin flow in explicit mode") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 fi

[dpdk-dev] [PATCH] net/mlx5: fix shared age action validation

2020-11-24 Thread Dekel Peled
required check to ensure proper validation. Fixes: f9bc5274a6f9 ("net/mlx5: allow age modes combination") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation

2020-11-18 Thread Dekel Peled
declaration to the start of the function, outside of the check loop. Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types") Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Jack Min --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[dpdk-dev] [PATCH 2/3] net/mlx5: fix input register for ASO object

2020-11-18 Thread Dekel Peled
function mlx5dv_dr_action_create_flow_hit(). Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 36 +++--- drivers/net/mlx5/mlx5_flow.c | 1 + driver

[dpdk-dev] [PATCH 0/3] ASO age action fixes

2020-11-18 Thread Dekel Peled
The age action using ASO was recently introduced in MLX5 PMD. This series includes fixes for this feature, repairing issues found and updating it to the released rdma-core API. Dekel Peled (3): net/mlx5: fix unfreed memory on ASO age close net/mlx5: fix input register for ASO object common

[dpdk-dev] [PATCH 3/3] common/mlx5: move to formal ASO action API

2020-11-18 Thread Dekel Peled
Existing code uses the previous API offered by rdma-core in order to create ASO Flow Hit action. A general API is now formally released, to create ASO action of any type. This patch moves the MLX5 PMD code to use the formal API. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers

[dpdk-dev] [PATCH 1/3] net/mlx5: fix unfreed memory on ASO age close

2020-11-18 Thread Dekel Peled
Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index ede5fd44ab..627e511b12 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -41

Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation

2020-11-17 Thread Dekel Peled
PSB. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 17, 2020 12:30 PM > To: Dekel Peled ; Xiaoyu Min > ; Jasvinder Singh ; > Cristian Dumitrescu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size >

Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation

2020-11-16 Thread Dekel Peled
age- > From: Ferruh Yigit > Sent: Monday, November 16, 2020 6:27 PM > To: Xiaoyu Min ; Jasvinder Singh > ; Cristian Dumitrescu > > Cc: dev@dpdk.org; Dekel Peled > Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size > calculation > > On 11/

Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

2020-11-09 Thread Dekel Peled
ay, November 9, 2020 12:05 PM > To: Xiaoyu Min ; Ori Kam ; > Wenzhuo Lu ; Beilei Xing ; > Bernard Iremonger ; Matan Azrad > ; Dekel Peled ; Ajit Khaparde > > Cc: dev@dpdk.org; Jack Min ; Andrew Rybchenko > ; NBU-Contact-Thomas Monjalon > ; Hyong Youb Kim ; John > Dal

[dpdk-dev] [PATCH] net/mlx5: fix use of local array for global error

2020-11-04 Thread Dekel Peled
engine. Fixes: cb6a02dcea9d ("net/mlx5: support item type error message in flow Verbs") Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_verbs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_

[dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing

2020-11-03 Thread Dekel Peled
by 2. Fixes: 18c88cf29c29 ("net/mlx5: support flow hit action for aging") Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 21 +-- drivers/net/mlx5/mlx5.h | 3 ++- drivers/net/mlx5/mlx5_flow_age.c | 36 ++--

[dpdk-dev] [PATCH] net/mlx5: fix IPv6 next proto validation

2020-10-20 Thread Dekel Peled
updates the validation, to make sure next proto is not 0 before validating it. Fixes: 55e4c1d1ba73 ("net/mlx5: enforce limitation on IPv6 next proto") Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[dpdk-dev] [PATCH v6] net/mlx5: support query of AGE action

2020-10-19 Thread Dekel Peled
: Remove redundant blank line in RN. v5: Fix pointer type compilation issue. v6: Access time count atomically. --- Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/rel_notes/release_20_11.rst | 8 drivers/net/mlx5/mlx5.h| 21 - drivers/net/mlx5

[dpdk-dev] [PATCH v5] net/mlx5: support query of AGE action

2020-10-18 Thread Dekel Peled
: Remove redundant blank line in RN. v5: Fix pointer type compilation issue. --- Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/rel_notes/release_20_11.rst | 8 drivers/net/mlx5/mlx5.h| 20 drivers/net/mlx5/mlx5_flow.c | 21

[dpdk-dev] [PATCH v4] net/mlx5: support query of AGE action

2020-10-16 Thread Dekel Peled
: Remove redundant blank line in RN. --- Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/rel_notes/release_20_11.rst | 8 drivers/net/mlx5/mlx5.h| 20 drivers/net/mlx5/mlx5_flow.c | 21 ++--- drivers/net/mlx5/mlx5_flow_dv.c| 84

[dpdk-dev] [PATCH v3] net/mlx5: support query of AGE action

2020-10-16 Thread Dekel Peled
Recent patch [1] adds to ethdev the API for query of age action. This patch implements in MLX5 PMD the query of age action using this API. [1] https://mails.dpdk.org/archives/dev/2020-October/184864.html Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/rel_notes/release_20_11

[dpdk-dev] [PATCH v5 1/2] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-15 Thread Dekel Peled
/177536.html Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/prog_guide/rte_flow.rst | 13 ++--- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_20_11.rst | 7 +++ lib/librte_ethdev/rte_flow.h | 17 + 4 files

[dpdk-dev] [PATCH v5 2/2] app/testpmd: support VLAN attributes in ETH and VLAN items

2020-10-15 Thread Dekel Peled
rte_flow update introduced has_vlan field for ETH header item, and field has_more_vlan for VLAN header item. The new fields are used to clearly indicate packet tagging chrasteristics. This patch updates testpmd CLI to support the new fields. Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by

[dpdk-dev] [PATCH v5 0/2] support VLAN attributes in ETH and VLAN items

2020-10-15 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-August/177536.html --- v2: fix checkpatch comment. v3: updates description in comments and documentation. v4: add testpmd patch with application support. v5: update comments and documentation for clarity. --- Dekel Peled (2): ethdev: add VLAN attributes to ETH and VLAN

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-15 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 15, 2020 1:35 PM > To: Dekel Peled ; Ori Kam ; > wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com; m...@ashroe.eu; nhor...@tuxdriver.com; > NBU-Co

[dpdk-dev] [PATCH v2 5/5] net/mlx5: enforce limitation on IPv6 next proto

2020-10-15 Thread Dekel Peled
Due to PRM requirement, the IPv6 header item 'proto' field, indicating the next header protocol, should not be set as extension header. This patch adds the relevant validation, and documents the limitation. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rs

[dpdk-dev] [PATCH v2 4/5] net/mlx5: support match on IPv6 fragment ext. item

2020-10-15 Thread Dekel Peled
rte_flow update, following RFC [1], added to ethdev the rte_flow item ipv6_frag_ext. This patch adds to MLX5 PMD the option to match on this item type. [1] http://mails.dpdk.org/archives/dev/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH v2 3/5] net/mlx5: support match on IPv6 fragment packets

2020-10-15 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv6 fragmented and non-fragmented packets, using the new field has_frag_ext, added to rte_flow following RFC [1]. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides

[dpdk-dev] [PATCH v2 2/5] net/mlx5: support match on IPv4 fragment packets

2020-10-15 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv4 fragmented and non-fragmented packets, using the IPv4 header fragment_offset field. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/rel_notes/release_20_11.rst | 5 ++ drivers/net/mlx5/mlx5_flow.c | 48

[dpdk-dev] [PATCH v2 0/5] net/mlx5: support match on L3 fragmented packets

2020-10-15 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-October/186177.html --- v2: rebase on top of latest commits. --- Dekel Peled (5): net/mlx5: remove handling of ICMP fragmented packets net/mlx5: support match on IPv4 fragment packets net/mlx5: support match on IPv6 fragment packets net/mlx5: support match on IPv6

[dpdk-dev] [PATCH v2 1/5] net/mlx5: remove handling of ICMP fragmented packets

2020-10-15 Thread Dekel Peled
t;net/mlx5: fix matching for ICMP fragments") Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 361c32d..3fa51c3 100644 --

[dpdk-dev] [PATCH v2] net/mlx5: add debug print of LRO minimal size

2020-10-15 Thread Dekel Peled
Add debug printout showing HCA capability lro_min_mss_size - the minimal size of TCP segment required for coalescing. MLX5 PMD documentation is updated to note this condition. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 3 +++ drivers/common/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix use of atomic cmpset for age state

2020-10-15 Thread Dekel Peled
. This patch updates the calls to rte_atomic16_cmpset(), to check that the return value is 0 or non-zero. [1] https://doc.dpdk.org/api/rte__atomic_8h.html Fixes: fa2d01c87d2b ("net/mlx5: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH v4 1/2] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-14 Thread Dekel Peled
/177536.html Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 14 -- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_20_11.rst | 7 +++ lib/librte_ethdev/rte_flow.h | 18 +++--- 4 files changed, 34 insertions

[dpdk-dev] [PATCH v4 2/2] app/testpmd: support VLAN attributes in ETH and VLAN items

2020-10-14 Thread Dekel Peled
rte_flow update introduced has_vlan field for ETH header item, and field has_more_vlan for VLAN header item. The new fields are used to clearly indicate packet tagging chrasteristics. This patch updates testpmd CLI to support the new fields. Signed-off-by: Dekel Peled --- app/test-pmd

[dpdk-dev] [PATCH v4 0/2] support VLAN attributes in ETH and VLAN items

2020-10-14 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-August/177536.html --- v2: fix checkpatch comment. v3: updates description in comments and documentation. v4: add testpmd patch with application support. --- Dekel Peled (2): ethdev: add VLAN attributes to ETH and VLAN items app/testpmd: support VLAN attributes in ETH

[dpdk-dev] [PATCH v7 2/5] ethdev: add IPv6 fragment extension header item

2020-10-14 Thread Dekel Peled
/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Thomas Monjalon --- doc/guides/prog_guide/rte_flow.rst | 12 lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 20 lib/librte_ip_frag/rte_ip_frag.h | 26

[dpdk-dev] [PATCH v7 4/5] app/testpmd: support IPv6 fragments

2020-10-14 Thread Dekel Peled
-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 5c224d6..9be1f64 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -144,6

[dpdk-dev] [PATCH v7 0/5] support match on L3 fragmented packets

2020-10-14 Thread Dekel Peled
on to clarify use of IPv6 extension header flags. v5: update following rebase on recent ICMP changes. v6: - move MLX5 PMD patches to separate series. - rename IPv6 extension flags for clarity (e.g. frag_ext_exist renamed to has_frag_ext). v7: remove the announcement from deprecation file.

[dpdk-dev] [PATCH v7 3/5] app/testpmd: support IPv4 fragments

2020-10-14 Thread Dekel Peled
spec 1 fragment_offset last 0x3fff fragment_offset mask 0x3fff ... (Use the full available range 1 to 0x3fff to include all possible values.) To match on any IPv4 packets, fragmented and non-fragmented, the fragment_offset field should not be specified for match. Signed-off-by: Dekel Peled Acked-by

[dpdk-dev] [PATCH v7 5/5] app/testpmd: support IPv6 fragment extension item

2020-10-14 Thread Dekel Peled
-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9be1f64..c4796c3 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v7 1/5] ethdev: add extensions attributes to IPv6 item

2020-10-14 Thread Dekel Peled
need to use has_frag_ext 1. To match on any IPv6 packets, the has_frag_ext field should not be specified for match. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon --- doc/guides/pr

[dpdk-dev] [PATCH 5/5] net/mlx5: enforce limitation on IPv6 next proto

2020-10-13 Thread Dekel Peled
Due to PRM requirement, the IPv6 header item 'proto' field, indicating the next header protocol, should not be set as extension header. This patch adds the relevant validation, and documents the limitation. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rs

[dpdk-dev] [PATCH 2/5] net/mlx5: support match on IPv4 fragment packets

2020-10-13 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv4 fragmented and non-fragmented packets, using the IPv4 header fragment_offset field. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/rel_notes/release_20_11.rst | 5 ++ drivers/net/mlx5/mlx5_flow.c | 48

[dpdk-dev] [PATCH 4/5] net/mlx5: support match on IPv6 fragment ext. item

2020-10-13 Thread Dekel Peled
rte_flow update, following RFC [1], added to ethdev the rte_flow item ipv6_frag_ext. This patch adds to MLX5 PMD the option to match on this item type. [1] http://mails.dpdk.org/archives/dev/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH 3/5] net/mlx5: support match on IPv6 fragment packets

2020-10-13 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv6 fragmented and non-fragmented packets, using the new field has_frag_ext, added to rte_flow following RFC [1]. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides

[dpdk-dev] [PATCH 0/5] net/mlx5: support match on L3 fragmented packets

2020-10-13 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-October/186177.html Dekel Peled (5): net/mlx5: remove handling of ICMP fragmented packets net/mlx5: support match on IPv4 fragment packets net/mlx5: support match on IPv6 fragment packets net/mlx5: support match on IPv6 fragment ext. item net/mlx5: enforce limitation

[dpdk-dev] [PATCH 1/5] net/mlx5: remove handling of ICMP fragmented packets

2020-10-13 Thread Dekel Peled
t;net/mlx5: fix matching for ICMP fragments") Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 2bbfcea..c0fb311 100644 --

[dpdk-dev] [PATCH v6 3/5] app/testpmd: support IPv4 fragments

2020-10-13 Thread Dekel Peled
spec 1 fragment_offset last 0x3fff fragment_offset mask 0x3fff ... (Use the full available range 1 to 0x3fff to include all possible values.) To match on any IPv4 packets, fragmented and non-fragmented, the fragment_offset field should not be specified for match. Signed-off-by: Dekel Peled Acked-by

[dpdk-dev] [PATCH v6 5/5] app/testpmd: support IPv6 fragment extension item

2020-10-13 Thread Dekel Peled
-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index d311b85..75d2b56 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v6 2/5] ethdev: add IPv6 fragment extension header item

2020-10-13 Thread Dekel Peled
/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 12 lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 20 lib/librte_ip_frag/rte_ip_frag.h | 26

[dpdk-dev] [PATCH v6 4/5] app/testpmd: support IPv6 fragments

2020-10-13 Thread Dekel Peled
-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index cfbf57b..d311b85 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -142,6

[dpdk-dev] [PATCH v6 1/5] ethdev: add extensions attributes to IPv6 item

2020-10-13 Thread Dekel Peled
need to use has_frag_ext 1. To match on any IPv6 packets, the has_frag_ext field should not be specified for match. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Ajit Khaparde --- doc/guides/prog_guide/rte_flow.rst

[dpdk-dev] [PATCH v6 0/5] support match on L3 fragmented packets

2020-10-13 Thread Dekel Peled
on to clarify use of IPv6 extension header flags. v5: update following rebase on recent ICMP changes. v6: - move MLX5 PMD patches to separate series. - rename IPv6 extension flags for clarity (e.g. frag_ext_exist renamed to has_frag_ext). --- *** BLURB HERE *** Dekel Peled (5): ethdev: add e

Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-13 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:42 PM > To: Ori Kam ; Dekel Peled > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; > konstantin.anan...@intel.com; olivier.m...@6wind.com; > wenzhuo...@intel.com;

Re: [dpdk-dev] [PATCH v5 02/11] ethdev: add IPv6 fragment extension header item

2020-10-13 Thread Dekel Peled
Yes, thanks. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:50 PM > To: Dekel Peled > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; konstantin.anan...@intel.com; > olivier.m...@6wind.com; wenzhuo...@intel.com;

[dpdk-dev] [PATCH v5 09/11] net/mlx5: support match on IPv6 fragment ext. item

2020-10-12 Thread Dekel Peled
rte_flow update, following RFC [1], added to ethdev the rte_flow item ipv6_frag_ext. This patch adds to MLX5 PMD the option to match on this item type. [1] http://mails.dpdk.org/archives/dev/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH v5 11/11] net/mlx5: enforce limitation on IPv6 next proto

2020-10-12 Thread Dekel Peled
Due to PRM requirement, the IPv6 header item 'proto' field, indicating the next header protocol, should not be set as extension header. This patch adds the relevant validation, and documents the limitation. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rs

[dpdk-dev] [PATCH v5 10/11] doc: update release notes for MLX5 L3 frag support

2020-10-12 Thread Dekel Peled
This patch updates 20.11 release notes with the changes included in patches of this series: 1) MLX5 support of matching on IPv4/IPv6 fragmented/non-fragmented packets. 2) ABI change in ethdev struct rte_flow_item_ipv6. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/rel_notes

[dpdk-dev] [PATCH v5 02/11] ethdev: add IPv6 fragment extension header item

2020-10-12 Thread Dekel Peled
/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 16 ++-- lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 20 lib/librte_ip_frag/rte_ip_frag.h | 26

[dpdk-dev] [PATCH v5 07/11] net/mlx5: support match on IPv4 fragment packets

2020-10-12 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv4 fragmented and non-fragmented packets, using the IPv4 header fragment_offset field. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 48 drivers/net/mlx5/mlx5_flow.h | 10

[dpdk-dev] [PATCH v5 08/11] net/mlx5: support match on IPv6 fragment packets

2020-10-12 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv6 fragmented and non-fragmented packets, using the new field frag_ext_exist, added to rte_flow following RFC [1]. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers

[dpdk-dev] [PATCH v5 04/11] app/testpmd: support IPv6 fragments

2020-10-12 Thread Dekel Peled
Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a9bf29f..b078095 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v5 03/11] app/testpmd: support IPv4 fragments

2020-10-12 Thread Dekel Peled
spec 1 fragment_offset last 0x3fff fragment_offset mask 0x3fff ... (Use the full available range 1 to 0x3fff to include all possible values.) To match on any IPv4 packets, fragmented and non-fragmented, the fragment_offset field should not be specified for match. Signed-off-by: Dekel Peled Acked-by

[dpdk-dev] [PATCH v5 05/11] app/testpmd: support IPv6 fragment extension item

2020-10-12 Thread Dekel Peled
-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index b078095..1f800eb 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v5 00/11] support match on L3 fragmented packets

2020-10-12 Thread Dekel Peled
date patch 'ethdev: add IPv6 fragment extension header item' to avoid ABI breakage. v4: update rte_flow documentation to clarify use of IPv6 extension header flags. v5: update following rebase on recent ICMP changes. --- Dekel Peled (11): ethdev: add extensions attributes to IPv6 ite

[dpdk-dev] [PATCH v5 06/11] net/mlx5: remove handling of ICMP fragmented packets

2020-10-12 Thread Dekel Peled
t;net/mlx5: fix matching for ICMP fragments") Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 2bbfcea..c0fb311 100644 --

[dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-12 Thread Dekel Peled
, need to use frag_ext_exist 1. To match on any IPv6 packets, the frag_ext_exist field should not be specified for match. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 22 +++---

[dpdk-dev] [PATCH] net/mlx5: add debug print of LRO minimal size

2020-10-08 Thread Dekel Peled
Add debug printout showing HCA capability lro_min_mss_size - the minimal size of TCP segment required for coalescing. MLX5 PMD documentation is updated to note this condition. Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst | 4 +++- drivers/common/mlx5/mlx5_devx_cmds.c | 2

Re: [dpdk-dev] [PATCH v4 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ajit Khaparde > Sent: Thursday, October 8, 2020 6:14 AM > To: Dekel Peled > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Ananyev, Konstantin > ; Olivier Matz ; > Wenzhuo Lu

[dpdk-dev] [PATCH v3] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-07 Thread Dekel Peled
/177536.html --- v2: fix checkpatch comment. v3: updates description in comments and documentation. --- Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 14 -- doc/guides/rel_notes/release_20_11.rst | 7 +++ lib/librte_ethdev/rte_flow.h | 18

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-07 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ori Kam > Sent: Wednesday, October 7, 2020 3:14 PM > To: Maxime Leroy ; Dekel Peled > ; NBU-Contact-Thomas Monjalon > > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; dev@dpdk.org > Subject: RE: [PATCH] ethdev: ad

[dpdk-dev] [PATCH v2] net/mlx5: support query of AGE action

2020-10-07 Thread Dekel Peled
Recent patch [1] adds to ethdev the API for query of age action. This patch implements in MLX5 PMD the query of age action using this API. [1] https://mails.dpdk.org/archives/dev/2020-October/184864.html Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5.h | 7 + drivers/net

[dpdk-dev] [PATCH v4 2/2] app/testpmd: support query of AGE action

2020-10-07 Thread Dekel Peled
Following ethdev update in the previous patch of this series, this patch adds CLI support to query information related to AGE action. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- app/test-pmd/config.c | 12 1 file changed, 12 insertions(+) diff --git a/app/test-pmd

[dpdk-dev] [PATCH v4 0/2] support query of AGE action

2020-10-07 Thread Dekel Peled
additional field for clarity. --- Dekel Peled (2): ethdev: support query of AGE action app/testpmd: support query of AGE action app/test-pmd/config.c | 12 doc/guides/prog_guide/rte_flow.rst | 17 + doc/guides/rel_notes/release_20_11.rst | 3

[dpdk-dev] [PATCH v4 1/2] ethdev: support query of AGE action

2020-10-07 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-September/180061.html Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/prog_guide/rte_flow.rst | 17 + doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_ethdev/rte_flow.h | 15 +++ 3 files changed, 35

[dpdk-dev] [PATCH v3 2/2] app/testpmd: support query of AGE action

2020-10-07 Thread Dekel Peled
Following ethdev update [1], this patch adds CLI support to query information related to AGE action. [1] https://mails.dpdk.org/archives/dev/2020-September/183699.html Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- app/test-pmd/config.c | 12 1 file changed, 12 insertions

[dpdk-dev] [PATCH v3 1/2] ethdev: support query of AGE action

2020-10-07 Thread Dekel Peled
://mails.dpdk.org/archives/dev/2020-September/180061.html Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/prog_guide/rte_flow.rst | 17 + doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_ethdev/rte_flow.h | 14 ++ 3 files changed, 34

[dpdk-dev] [PATCH v3 0/2] support query of AGE action

2020-10-07 Thread Dekel Peled
This series includes change in ethdev to support a new query response format, and change in testpmd CLI using it. --- v2: enclose 2 separate patches in series. (no change in patch contents). v3: rename struct rte_flow_query_age field for clarity. --- Dekel Peled (2): ethdev: support query

[dpdk-dev] [PATCH v4 11/11] net/mlx5: enforce limitation on IPv6 next proto

2020-10-07 Thread Dekel Peled
Due to PRM requirement, the IPv6 header item 'proto' field, indicating the next header protocol, should not be set as extension header. This patch adds the relevant validation, and documents the limitation. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/nics/mlx5.rs

[dpdk-dev] [PATCH v4 10/11] doc: update release notes for MLX5 L3 frag support

2020-10-07 Thread Dekel Peled
This patch updates 20.11 release notes with the changes included in patches of this series: 1) MLX5 support of matching on IPv4/IPv6 fragmented/non-fragmented packets. 2) ABI change in ethdev struct rte_flow_item_ipv6. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/rel_notes

[dpdk-dev] [PATCH v4 08/11] net/mlx5: support match on IPv6 fragment packets

2020-10-07 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv6 fragmented and non-fragmented packets, using the new field frag_ext_exist, added to rte_flow following RFC [1]. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled --- drivers/net/mlx5

[dpdk-dev] [PATCH v4 09/11] net/mlx5: support match on IPv6 fragment ext. item

2020-10-07 Thread Dekel Peled
rte_flow update, following RFC [1], added to ethdev the rte_flow item ipv6_frag_ext. This patch adds to MLX5 PMD the option to match on this item type. [1] http://mails.dpdk.org/archives/dev/2020-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH v4 05/11] app/testpmd: support IPv6 fragment extension item

2020-10-07 Thread Dekel Peled
-March/160255.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index b078095..1f800eb 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v4 06/11] net/mlx5: remove handling of ICMP fragmented packets

2020-10-07 Thread Dekel Peled
t;net/mlx5: fix matching for ICMP fragments") Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 79fdf34..0a0a5a4 100644 --

[dpdk-dev] [PATCH v4 07/11] net/mlx5: support match on IPv4 fragment packets

2020-10-07 Thread Dekel Peled
This patch adds to MLX5 PMD the support of matching on IPv4 fragmented and non-fragmented packets, using the IPv4 header fragment_offset field. Signed-off-by: Dekel Peled Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 48 drivers/net/mlx5/mlx5_flow.h | 10

[dpdk-dev] [PATCH v4 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-07 Thread Dekel Peled
, need to use frag_ext_exist 1. To match on any IPv6 packets, the frag_ext_exist field should not be specified for match. [1] https://mails.dpdk.org/archives/dev/2020-August/177257.html Signed-off-by: Dekel Peled Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 22 +++---

[dpdk-dev] [PATCH v4 04/11] app/testpmd: support IPv6 fragments

2020-10-07 Thread Dekel Peled
Signed-off-by: Dekel Peled Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a9bf29f..b078095 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v4 03/11] app/testpmd: support IPv4 fragments

2020-10-07 Thread Dekel Peled
spec 1 fragment_offset last 0x3fff fragment_offset mask 0x3fff ... (Use the full available range 1 to 0x3fff to include all possible values.) To match on any IPv4 packets, fragmented and non-fragmented, the fragment_offset field should not be specified for match. Signed-off-by: Dekel Peled Acked-by

[dpdk-dev] [PATCH v4 02/11] ethdev: add IPv6 fragment extension header item

2020-10-07 Thread Dekel Peled
/2020-March/160255.html Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 16 ++-- lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 20 lib/librte_ip_frag/rte_ip_frag.h | 26 ++ lib

[dpdk-dev] [PATCH v4 00/11] support match on L3 fragmented packets

2020-10-07 Thread Dekel Peled
date patch 'ethdev: add IPv6 fragment extension header item' to avoid ABI breakage. v4: update rte_flow documentation to clarify use of IPv6 extension header flags. --- Dekel Peled (11): ethdev: add extensions attributes to IPv6 item ethdev: add IPv6 fragment extension header item app/t

Re: [dpdk-dev] [PATCH v3 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-07 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ajit Khaparde > Sent: Wednesday, October 7, 2020 2:44 AM > To: Dekel Peled > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Ananyev, Konstantin > ; Olivier Matz ; > Wenzhuo Lu

[dpdk-dev] [PATCH] net/mlx5: support query of AGE action

2020-10-06 Thread Dekel Peled
Recent patch [1] adds to ethdev the API for query of age action. This patch implements in MLX5 PMD the query of age action using this API. [1] https://mails.dpdk.org/archives/dev/2020-October/184319.html Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5.h | 7 + drivers/net

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: support query of AGE action

2020-10-05 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 1:02 PM > To: Dekel Peled ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > arybche...@solarflare.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.c

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-05 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Maxime Leroy > Sent: Friday, October 2, 2020 3:39 PM > To: Dekel Peled > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > arybche...@solarflare.com; dev@dpdk.org; Dekel Peled > > Subject: R

  1   2   3   4   5   6   7   >