[PATCH 2/2] maintainers: update for crypto performance

2024-05-07 Thread Ciara Power
Replacing myself as Crypto Perf App maintainer with Brian Dooley. Signed-off-by: Ciara Power --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7726e9e7a9..4e4197e178 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1825,7 +1825,7

[PATCH 1/2] maintainers: update for telemetry

2024-05-07 Thread Ciara Power
Replacing myself as Telemetry maintainer with Bruce Richardson. Signed-off-by: Ciara Power --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7abb3aee49..7726e9e7a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1739,7 +1739,7

[PATCH] crypto: fix crypto callbacks macro

2024-04-15 Thread Ciara Power
ned-off-by: Ciara Power --- lib/cryptodev/rte_cryptodev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index 00ba6a234a..357d4bcf9c 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_c

[PATCH] common/qat: fix undefined macro

2024-03-05 Thread Ciara Power
When using RTE_ENABLE_ASSERT and debug mode, an undefined macro error appeared for ICP_QAT_FW_SYM_COMM_ADDR_SGL. This was not being defined, but is now added to the header file. Bugzilla ID: 1395 Fixes: e9271821e489 ("common/qat: support GEN LCE device") Signed-off-by: Ciara Powe

[PATCH v8 3/3] test/cryptodev: add tests for GCM with 64 byte AAD

2024-02-29 Thread Ciara Power
: Nishikant Nayak Signed-off-by: Ciara Power Acked-by: Arkadiusz Kusztal --- v7: - Added second developer to signed-off for v7 fixes. - Utilised 100 char line limit. - Moved NULL capability check earlier in test function. v2: - Removed unused code. - Added one new unit test, AAD

[PATCH v8 2/3] crypto/qat: update headers for GEN LCE support

2024-02-29 Thread Ciara Power
From: Nishikant Nayak This patch handles the changes required for updating the common header fields specific to GEN LCE, Also added/updated of the response processing APIs based on GEN LCE requirement. Signed-off-by: Nishikant Nayak Signed-off-by: Ciara Power Acked-by: Arkadiusz Kusztal

[PATCH v8 1/3] common/qat: add support for GEN LCE device

2024-02-29 Thread Ciara Power
: Ciara Power Acked-by: Arkadiusz Kusztal --- v7: - Squashed patch 1 + 2 together. - Updated commit message. - Added new signed off to cover changes made by second developer in v7. - Fixed copyright year for new files. - Utilised 100 char line limit. v6: - Removed

[PATCH v8 0/3] add QAT GEN LCE device

2024-02-29 Thread Ciara Power
This patchset adds a new QAT LCE device. The device currently only supports symmetric crypto, and only the AES-GCM algorithm. v8: Rebased on latest next-crypto-for-main. v7: - Squashed patch 1 and 2. - Fixed formatting to leverage 100 char line limit. - Removed unnecessary whitespace and ind

[PATCH v7 3/3] test/cryptodev: add tests for GCM with 64 byte AAD

2024-02-29 Thread Ciara Power
: Nishikant Nayak Signed-off-by: Ciara Power Acked-by: Arkadiusz Kusztal --- v7: - Added second developer to signed-off for v7 fixes. - Utilised 100 char line limit. - Moved NULL capability check earlier in test function. v2: - Removed unused code. - Added one new unit test, AAD

[PATCH v7 2/3] crypto/qat: update headers for GEN LCE support

2024-02-29 Thread Ciara Power
From: Nishikant Nayak This patch handles the changes required for updating the common header fields specific to GEN LCE, Also added/updated of the response processing APIs based on GEN LCE requirement. Signed-off-by: Nishikant Nayak Signed-off-by: Ciara Power Acked-by: Arkadiusz Kusztal

[PATCH v7 1/3] common/qat: add support for GEN LCE device

2024-02-29 Thread Ciara Power
: Ciara Power Acked-by: Arkadiusz Kusztal --- v7: - Squashed patch 1 + 2 together. - Updated commit message. - Added new signed off to cover changes made by second developer in v7. - Fixed copyright year for new files. - Utilised 100 char line limit. v6: - Removed

[PATCH v7 0/3] add QAT GEN LCE device

2024-02-29 Thread Ciara Power
This patchset adds a new QAT LCE device. The device currently only supports symmetric crypto, and only the AES-GCM algorithm. v7: - Squashed patch 1 and 2. - Fixed formatting to leverage 100 char line limit. - Removed unnecessary whitespace and indent changes. - Fixed copyright year typo o

[PATCH v3 4/4] common/qat: add gen5 device

2024-02-26 Thread Ciara Power
. Symmetric, asymmetric and compression services are enabled. Signed-off-by: Ciara Power Acked-by: Kai Ji --- v3: - Fixed copyright tag in new files to 2024. - Removed v2 changes in notes of commit, this patch was new in v2. --- doc/guides/cryptodevs/qat.rst| 4 + doc/guides

[PATCH v3 3/4] common/qat: add new gen3 CMAC macros

2024-02-26 Thread Ciara Power
The new QAT GEN3 device uses new macros for CMAC values, rather than using XCBC_MAC ones. The wireless slice handles CMAC in the new gen3 device, and no key precomputes are required by SW. Signed-off-by: Ciara Power Acked-by: Kai Ji --- drivers/common/qat/qat_adf/icp_qat_hw.h | 4

[PATCH v3 2/4] common/qat: add zuc256 wireless slice for gen3

2024-02-26 Thread Ciara Power
capability for the device. The device supports 24 bytes iv for ZUC 256, with iv[20] being ignored in register. For 25 byte iv, compress this into 23 bytes. Signed-off-by: Ciara Power Acked-by: Kai Ji --- v2: - Fixed setting extended protocol flag bit position. - Added slice map check for ZUC256

[PATCH v3 1/4] common/qat: add new gen3 device

2024-02-26 Thread Ciara Power
, asymmetric and compression services are enabled. Signed-off-by: Ciara Power Acked-by: Kai Ji --- v2: Added documentation updates. --- doc/guides/compressdevs/qat_comp.rst | 1 + doc/guides/cryptodevs/qat.rst| 2 ++ doc/guides/rel_notes/release_24_03.rst | 4

[PATCH v3 0/4] add new QAT gen3 and gen5

2024-02-26 Thread Ciara Power
. - Added check for ZUC-256 wireless slice in slice map. Ciara Power (4): common/qat: add new gen3 device common/qat: add zuc256 wireless slice for gen3 common/qat: add new gen3 CMAC macros common/qat: add gen5 device doc/guides/compressdevs/qat_comp.rst | 1 + doc/guides

[PATCH v2 4/4] common/qat: add gen5 device

2024-02-23 Thread Ciara Power
. Symmetric, asymmetric and compression services are enabled. Signed-off-by: Ciara Power --- v2: - Fixed setting extended protocol flag bit position. - Added slice map check for ZUC256 wireless slice. - Fixed IV modification for ZUC256 in raw datapath. - Added increment size for ZUC256

[PATCH v2 3/4] common/qat: add new gen3 CMAC macros

2024-02-23 Thread Ciara Power
The new QAT GEN3 device uses new macros for CMAC values, rather than using XCBC_MAC ones. The wireless slice handles CMAC in the new gen3 device, and no key precomputes are required by SW. Signed-off-by: Ciara Power --- drivers/common/qat/qat_adf/icp_qat_hw.h | 4 +++- drivers/crypto/qat

[PATCH v2 2/4] common/qat: add zuc256 wireless slice for gen3

2024-02-23 Thread Ciara Power
capability for the device. The device supports 24 bytes iv for ZUC 256, with iv[20] being ignored in register. For 25 byte iv, compress this into 23 bytes. Signed-off-by: Ciara Power --- v2: - Fixed setting extended protocol flag bit position. - Added slice map check for ZUC256 wireless slice

[PATCH v2 1/4] common/qat: add new gen3 device

2024-02-23 Thread Ciara Power
, asymmetric and compression services are enabled. Signed-off-by: Ciara Power --- v2: Added documentation updates. --- doc/guides/compressdevs/qat_comp.rst | 1 + doc/guides/cryptodevs/qat.rst| 2 ++ doc/guides/rel_notes/release_24_03.rst | 4 drivers/common

[PATCH v2 0/4] add new QAT gen3 and gen5

2024-02-23 Thread Ciara Power
. Ciara Power (4): common/qat: add new gen3 device common/qat: add zuc256 wireless slice for gen3 common/qat: add new gen3 CMAC macros common/qat: add gen5 device doc/guides/compressdevs/qat_comp.rst | 1 + doc/guides/cryptodevs/qat.rst| 6 + doc/guides

[PATCH 4/4] crypto/qat: disable asym and compression for new gen3 device

2023-12-19 Thread Ciara Power
Currently only symmetric crypto has been added for the new gen3 device, adding a check to disable asym and comp PMDs for this device. Signed-off-by: Ciara Power --- drivers/compress/qat/qat_comp_pmd.c | 3 ++- drivers/crypto/qat/qat_asym.c | 3 ++- 2 files changed, 4 insertions(+), 2

[PATCH 3/4] crypto/qat: add new gen3 CMAC macros

2023-12-19 Thread Ciara Power
The new QAT GEN3 device uses new macros for CMAC values, rather than using XCBC_MAC ones. The wireless slice handles CMAC in the new gen3 device, and no key precomputes are required by SW. Signed-off-by: Ciara Power --- drivers/common/qat/qat_adf/icp_qat_hw.h | 4 +++- drivers/crypto/qat

[PATCH 2/4] crypto/qat: add zuc256 wireless slice for gen3

2023-12-19 Thread Ciara Power
capability for the device. The device supports 24 bytes iv for ZUC 256, with iv[20] being ignored in register. For 25 byte iv, compress this into 23 bytes. Signed-off-by: Ciara Power --- drivers/common/qat/qat_adf/icp_qat_fw.h | 3 +- drivers/common/qat/qat_adf/icp_qat_fw_la.h | 24

[PATCH 0/4] add new QAT gen3 device

2023-12-19 Thread Ciara Power
moved to wireless slice (SNOW3G, ZUC, AES-CMAC). This patchset covers Symmetric crypto, so a check has been added for Asymmetric and Compression PMDs to skip for this gen3 device only. Documentation will be updated in a subsequent version of the patchset. Ciara Power (4): crypto/qat: add new

[PATCH 1/4] crypto/qat: add new gen3 device

2023-12-19 Thread Ciara Power
-by: Ciara Power --- drivers/common/qat/qat_device.c | 13 + drivers/common/qat/qat_device.h | 2 ++ drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 11 +++ 3 files changed, 26 insertions(+) diff --git a/drivers/common/qat/qat_device.c b/drivers/common

[PATCH v2] crypto/ipsec_mb: fix getting process ID per job

2023-11-23 Thread Ciara Power
: 9593d83e5d88 ("crypto/ipsec_mb: fix aesni_mb multi-process session ID") Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aes

[PATCH] crypto/ipsec_mb: fix getting process ID per job

2023-11-23 Thread Ciara Power
: 9593d83e5d88 ("crypto/ipsec_mb: fix aesni_mb multi-process session ID") Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aes

[PATCH v2] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Ciara Power
the legacy capabilities list is moved to the top of the loop, so it is detected when the last legacy element is SM and no SM slice exists. Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms") Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- v2: updating sender email --- driv

[PATCH v3] crypto/openssl: fix asym memory leaks

2023-11-13 Thread Ciara Power
("crypto/openssl: add DH and DSA asym operations") Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Fixes: ad149f93093e ("crypto/openssl: fix memory leaks in asym ops") Cc: kai...@intel.com Cc: gmuthukri...@marvell.com Cc: sunila.s...@caviumnetw

[PATCH v2] crypto/openssl: fix asym memory leaks

2023-11-13 Thread Ciara Power
("crypto/openssl: add DH and DSA asym operations") Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Fixes: ad149f93093e ("crypto/openssl: fix memory leaks in asym ops") Cc: kai...@intel.com Cc: gmuthukri...@marvell.com Cc: sunila.s...@caviumnetw

[PATCH] crypto/openssl: fix asym memory leaks

2023-11-03 Thread Ciara Power
11f ("crypto/openssl: support asymmetric SM2") Fixes: ac42813a0a7c ("crypto/openssl: add DH and DSA asym operations") Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Cc: kai...@intel.com Cc: gmuthukri...@marvell.com Cc: sunila.s...@caviumnetworks.c

[PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ciara Power
code so it does not depend on openssl at all. Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations") Cc: brian.doo...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 2 ++ drivers/crypto/qat

[PATCH v1] cryptodev: clarify usage of the block ciphers

2023-10-06 Thread Ciara Power
From: Arkadiusz Kusztal Some of the API comments incorrectly limited the usage of symmetric crypto fields to block ciphers. Signed-off-by: Arkadiusz Kusztal Signed-off-by: Ciara Power --- lib/cryptodev/rte_crypto_sym.h | 19 +-- 1 file changed, 5 insertions(+), 14 deletions

[PATCH] crypto/qat: fix raw API null algorithm digest

2023-09-07 Thread Ciara Power
expected, and the digest is placed to the side, as it won't be used anyway. This fix was previously added for the main QAT code path, but it also needs to be included for the raw API code path. Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Cc: sta...@dpdk.org Signed-off-

[PATCH v2] common/qat: enable QAT 2.0c devices

2023-08-21 Thread Ciara Power
This commit enables QAT 2.0c devices in the Intel QuickAssist Technology PMD. These are 4th Generation QAT, 402xx devices. Signed-off-by: Ciara Power --- v2: - Fixed kernel module. - Modified commit to align naming of new QAT device. --- doc/guides/cryptodevs/qat.rst | 4 doc

[PATCH] common/qat: enable gen4 c devices

2023-08-11 Thread Ciara Power
This commit enables QAT 2.0c devices in the Intel QuickAssist Technology PMD. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/qat.rst | 4 doc/guides/rel_notes/release_23_11.rst | 3 +++ drivers/common/qat/qat_device.c| 4 3 files changed, 11 insertions(+) diff

[PATCH v2] app/crypto-perf: fix socket ID default value

2023-07-06 Thread Ciara Power
check range of socket id") Cc: bruce.richard...@intel.com Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power Acked-by: Kai Ji --- v2: check if socket ID equals SOCKET_ID_ANY --- app/test-crypto-perf/main.c | 15 +-- 1 file changed, 9 insertions(+), 6 deleti

[PATCH] doc: support IPsec Multi-buffer lib v1.4

2023-07-05 Thread Ciara Power
Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPsec Multi-buffer library supported. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/aesni_gcm.rst | 6 +++--- doc/guides/cryptodevs

[PATCH] crypto/qat: fix legacy sm4 ecb capability

2023-07-05 Thread Ciara Power
Following the deprecation of insecure algorithms in QAT, SM4-ECB should be included as legacy, to be disabled by default. Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms") Signed-off-by: Ciara Power --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++--- 1 file

[PATCH v2] cryptodev: fix device socket ID type

2023-07-05 Thread Ciara Power
type to int fixes the issue, as it now takes the correct -1 value. Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power Acked-by: Morten Brørup Acked-by: Kai Ji --- v2: Added cc for stab

[PATCH] app/crypto-perf: fix socket ID default value

2023-07-05 Thread Ciara Power
rg Signed-off-by: Ciara Power --- app/test-crypto-perf/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index af5bd0d23b..b74e7ba118 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -651,6 +651,

[PATCH v2] crypto/ipsec_mb: fix jobs array used for burst

2023-07-05 Thread Ciara Power
ec_mb: use burst API in AESNI") Cc: marcel.d.co...@intel.com Signed-off-by: Ciara Power Acked-by: Kai Ji --- v2: fixed typo in commit --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c

[PATCH] crypto/ipsec_mb: fix jobs array used for burst

2023-07-05 Thread Ciara Power
ec_mb: use burst API in AESNI") Cc: marcel.d.co...@intel.com Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index

[PATCH] drivers/ipsec_mb: fix aesni_mb set session ID

2023-06-30 Thread Ciara Power
template session to the job again. Fixes: 0fb4834e00af ("crypto/ipsec_mb: set and use session ID") Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 8 +++- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 ++ 2 files

[PATCH] cryptodev: fix device socket ID type

2023-06-29 Thread Ciara Power
type to int fixes the issue, as it now takes the correct -1 value. Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default") Cc: olivier.m...@6wind.com Signed-off-by: Ciara Power --- lib/cryptodev/cryptodev_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2] crypto/qat: fix NULL algorithm digest placement

2023-06-23 Thread Ciara Power
expected, and the digest is placed to the side, as it won't be used anyway. Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Signed-off-by: Ciara Power --- v2: added fixes line as this was a bug --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 2 +- drivers

[PATCH] crypto/qat: modify NULL algorithm digest placement

2023-06-21 Thread Ciara Power
expected, and the digest is placed to the side, as it won't be used anyway. Signed-off-by: Ciara Power --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 2 +- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 18 ++ drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 4 ++-- dr

[PATCH] crypto/openssl: fix SM2 for older openssl version

2023-06-15 Thread Ciara Power
c SM2") Cc: gmuthukri...@marvell.com Signed-off-by: Ciara Power --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index fe38e4ebd8..9497da41ef 10

[PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ciara Power
framework") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- v2: fixed indents --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/

[PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ciara Power
framework") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec

[PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2023-05-16 Thread Ciara Power
illed again. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 - drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni

[PATCH v2 7/8] crypto/ipsec_mb: do not free linear_sgl always

2023-05-16 Thread Ciara Power
From: Pablo de Lara linear_sgl buffer only needs to be freed if it was allocated previously. Signed-off-by: Pablo de Lara --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto

[PATCH v2 6/8] crypto/ipsec_mb: optimize for GCM case

2023-05-16 Thread Ciara Power
From: Pablo de Lara Use a separate code path when dealing with AES-GCM. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 88 +++--- 1 file changed, 79 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ipsec_mb

[PATCH v2 5/8] crypto/ipsec_mb: store template job

2023-05-16 Thread Ciara Power
-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 403 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 20 +- 2 files changed, 159 insertions(+), 264 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c

[PATCH v2 4/8] crypto/ipsec_mb: remove unneeded fields in crypto session

2023-05-16 Thread Ciara Power
From: Pablo de Lara Cipher direction, cipher mode and hash algorithm are duplicated in crypto session. Signed-off-by: Pablo de Lara --- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypt

[PATCH v2 3/8] crypto/ipsec_mb: use new SGL API

2023-05-16 Thread Ciara Power
: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 187 +++- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 7 + 2 files changed, 153 insertions(+), 41 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index

[PATCH v2 2/8] crypto/ipsec_mb: use burst API in aesni_mb

2023-05-16 Thread Ciara Power
From: Marcel Cornu Use new ipsec_mb burst API in dequeue burst function, when ipsec_mb version is v1.3 or newer. Signed-off-by: Marcel Cornu Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- v2: moved some functions inside ifdef as they are only used when IPSec_MB version is

[PATCH v2 1/8] crypto/ipsec_mb: use GMAC dedicated algorithms

2023-05-16 Thread Ciara Power
From: Pablo de Lara AES-GMAC can be done with auth-only enums IMB_AES_GMAC_128/192/256, which allows another cipher algorithm to be used, instead of being part of AES-GCM. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 104

[PATCH v2 0/8] add AESNI_MB optimisations

2023-05-16 Thread Ciara Power
This patchset adds some optimisations for AESNI_MB PMD, many based on features that are available in intel-ipsec-mb v1.3 and future release v1.4. v2: moved some functions inside ifdef as they are only used when IPSec_MB version is 1.2 or lower. Marcel Cornu (1): crypto/ipsec_mb: use burst A

[PATCH] crypto/openssl: fix memory free issue

2023-05-11 Thread Ciara Power
enssl: update DSA routine with 3.0 EVP API") Cc: kai...@intel.com Cc: sta...@dpdk.org Signed-off-by: Saoirse O'Donovan Signed-off-by: Ciara Power --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ope

[PATCH 8/8] crypto/ipsec_mb: set and use session ID

2023-04-21 Thread Ciara Power
illed again. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 - drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni

[PATCH 7/8] crypto/ipsec_mb: do not free linear_sgl always

2023-04-21 Thread Ciara Power
From: Pablo de Lara linear_sgl buffer only needs to be freed if it was allocated previously. Signed-off-by: Pablo de Lara --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto

[PATCH 6/8] crypto/ipsec_mb: optimize for GCM case

2023-04-21 Thread Ciara Power
From: Pablo de Lara Use a separate code path when dealing with AES-GCM. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 88 +++--- 1 file changed, 79 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ipsec_mb

[PATCH 5/8] crypto/ipsec_mb: store template job

2023-04-21 Thread Ciara Power
-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 403 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 20 +- 2 files changed, 159 insertions(+), 264 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c

[PATCH 4/8] crypto/ipsec_mb: remove unneeded fields in crypto session

2023-04-21 Thread Ciara Power
From: Pablo de Lara Cipher direction, cipher mode and hash algorithm are duplicated in crypto session. Signed-off-by: Pablo de Lara --- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypt

[PATCH 3/8] crypto/ipsec_mb: use new SGL API

2023-04-21 Thread Ciara Power
: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 187 +++- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 7 + 2 files changed, 153 insertions(+), 41 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index

[PATCH 1/8] crypto/ipsec_mb: use GMAC dedicated algorithms

2023-04-21 Thread Ciara Power
From: Pablo de Lara AES-GMAC can be done with auth-only enums IMB_AES_GMAC_128/192/256, which allows another cipher algorithm to be used, instead of being part of AES-GCM. Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 104

[PATCH 2/8] crypto/ipsec_mb: use burst API in aesni_mb

2023-04-21 Thread Ciara Power
From: Marcel Cornu Use new ipsec_mb burst API in dequeue burst function, when ipsec_mb version is v1.3 or newer. Signed-off-by: Marcel Cornu Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 133 - 1 file changed

[PATCH 0/8] add AESNI_MB optimisations

2023-04-21 Thread Ciara Power
This patchset adds some optimisations for AESNI_MB PMD, many based on features that are available in intel-ipsec-mb v1.3 and future release v1.4. Marcel Cornu (1): crypto/ipsec_mb: use burst API in aesni_mb Pablo de Lara (7): crypto/ipsec_mb: use GMAC dedicated algorithms crypto/ipsec_mb: u

[PATCH] crypto/scheduler: fix last element for valid args

2023-04-14 Thread Ciara Power
vdev driver") Cc: fanzhang@gmail.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- drivers/crypto/scheduler/scheduler_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index

[PATCH] crypto/qat: fix stack buffer overflow in SGL loop

2023-04-14 Thread Ciara Power
e i value, which represents the number of cvecs available. If i is 0, then no need to increment as the current cvec is the last one. Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Cc: kai...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- drivers/c

[PATCH] app/compress-perf: fix remaining data for ops

2023-03-10 Thread Ciara Power
From: Arkadiusz Kusztal Individual variables are needed for tracking the remaining data for compression and decompression. Fixes: 83cc3b90ad7a ("app/compress-perf: fix testing single operation") Cc: michae...@nvidia.com Signed-off-by: Arkadiusz Kusztal Signed-off-by: Ciara Power

[PATCH] app/crypto-perf: fix test file memory leak

2023-03-10 Thread Ciara Power
successful run. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test-crypto-perf/cperf_options_parsing.c | 1 + app/test-crypto-perf/cperf_test_vector_parsing.c | 1 + 2 files changed, 2

[PATCH 3/3] app/test: add more cryptodev tests to meson suite

2023-03-07 Thread Ciara Power
The meson driver-tests suite did not include some ipsec_mb SW Crypto PMD tests, and QAT tests. These are now added to avoid them being missed if the user runs tests only using the meson suite infrastructure. Signed-off-by: Ciara Power --- app/test/meson.build | 5 + 1 file changed, 5

[PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL

2023-03-07 Thread Ciara Power
encryption SGL tests for CPU crypto on AESNI_MB only, as AESNI_GCM CPU crypto supports inplace SGL. Fixes: f9dfb59edbcc ("crypto/ipsec_mb: support remaining SGL") Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletion

[PATCH 2/3] test/crypto: skip asym test if driver or device missing

2023-03-07 Thread Ciara Power
d-off-by: Ciara Power --- app/test/test_cryptodev_asym.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 5b16dcab56..9236817650 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app

[PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ciara Power
The meson driver-tests suite was missing some QAT and SW PMD crypto tests, which are now added. Some issues were highlighted after adding to the driver-tests suite, which are also addressed in this patchset. Ciara Power (3): test/crypto: fix skip condition for CPU crypto SGL test/crypto

[PATCH v2 5/5] test/crypto: add chained ZUC256 testcases

2023-03-03 Thread Ciara Power
Testcases are added for ZUC256 cipher-auth, auth-cipher, and auth-cipher-verify. 4 byte, 8 byte, and 16 byte tags are tested for each chained type. Signed-off-by: Ciara Power Acked-by: Brian Dooley --- v2: changed from bit to byte length representation --- app/test/test_cryptodev.c

[PATCH v2 4/5] test/crypto: fix capability check for ZUC cipher auth

2023-03-03 Thread Ciara Power
("test/crypto: check cipher parameters") Fixes: f93fce6de4aa ("test/crypto: check auth parameters") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power Acked-by: Brian Dooley --- app/test/test_cryptodev.c | 27 --- 1 file ch

[PATCH v2 3/5] test/crypto: fix auth op parameter for ZUC256 tests

2023-03-03 Thread Ciara Power
The incorrect value was being passed to the ZUC authentication test function, indicating the opposite of the intended GENERATE/VERIFY op. This is fixed to use the auth op enum rather than a value. Fixes: 83397b9f0739 ("test/crypto: add further ZUC test cases") Signed-off-by: Ciara Po

[PATCH v2 2/5] test/crypto: fix ZUC digest length in comparison

2023-03-03 Thread Ciara Power
length. Fixes: 83397b9f0739 ("test/crypto: add further ZUC test cases") Fixes: fa5bf9345d4e ("test/crypto: add ZUC cases with 256-bit keys") Cc: vvelum...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power Acked-by: Brian Dooley --- app/test/test_cryptodev.c | 6 ++

[PATCH v2 1/5] test/crypto: improve readability of ZUC256 tests

2023-03-03 Thread Ciara Power
length as this can vary with ZUC256. Signed-off-by: Ciara Power Acked-by: Brian Dooley --- app/test/test_cryptodev.c | 125 +++--- 1 file changed, 62 insertions(+), 63 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index aa831d79a2

[PATCH v2 0/5] test/crypto: add ZUC256 chained tests

2023-03-03 Thread Ciara Power
were highlighted when these new tests were added. v2: changed bit lengths to byte length representation. Ciara Power (5): test/crypto: improve readability of ZUC256 tests test/crypto: fix ZUC digest length in comparison test/crypto: fix auth op parameter for ZUC256 tests test/crypto

[PATCH 5/5] test/crypto: add chained ZUC256 testcases

2023-03-01 Thread Ciara Power
Testcases are added for ZUC256 cipher-auth, auth-cipher, and auth-cipher-verify. 4 byte, 8 byte, and 16 byte tags are tested for each chained type. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 110 app/test/test_cryptodev_zuc_test_vectors.h | 714

[PATCH 4/5] test/crypto: fix capability check for ZUC cipher auth

2023-03-01 Thread Ciara Power
("test/crypto: check cipher parameters") Fixes: f93fce6de4aa ("test/crypto: check auth parameters") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 27 --- 1 file changed, 16 insertions(+), 1

[PATCH 3/5] test/crypto: fix auth op parameter for ZUC256 tests

2023-03-01 Thread Ciara Power
The incorrect value was being passed to the ZUC authentication test function, indicating the opposite of the intended GENERATE/VERIFY op. This is fixed to use the auth op enum rather than a value. Fixes: 83397b9f0739 ("test/crypto: add further ZUC test cases") Signed-off-by: C

[PATCH 2/5] test/crypto: fix ZUC digest length in comparison

2023-03-01 Thread Ciara Power
length. Fixes: 83397b9f0739 ("test/crypto: add further ZUC test cases") Fixes: fa5bf9345d4e ("test/crypto: add ZUC cases with 256-bit keys") Cc: vvelum...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 6 +++--- 1 file changed

[PATCH 0/5] test/crypto: add ZUC256 chained tests

2023-03-01 Thread Ciara Power
were highlighted when these new tests were added. Ciara Power (5): test/crypto: improve readability of ZUC256 tests test/crypto: fix ZUC digest length in comparison test/crypto: fix auth op parameter for ZUC256 tests test/crypto: fix capability check for ZUC cipher auth test/crypto

[PATCH 1/5] test/crypto: improve readability of ZUC256 tests

2023-03-01 Thread Ciara Power
length as this can vary with ZUC256. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 125 +++--- 1 file changed, 62 insertions(+), 63 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index aa831d79a2..ca7f10557c 100644 --- a

[PATCH] crypto/qat: fix SM3 auth mode

2023-03-01 Thread Ciara Power
ned-off-by: Ciara Power --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 3 +++ drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 3 +++ drivers/crypto/qat/qat_sym_session.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c

[PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length

2023-01-31 Thread Ciara Power
("crypto/ipsec_mb: support all tag sizes for ZUC-EIA3-256") Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 2 +- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] test/crypto: fix and improve ZUC cipher and auth tests

2023-01-06 Thread Ciara Power
a new variable, this can then be used directly. The cipher SGL function does not need to buffers allocated for ciphertext and plaintext, one can be used for both. Fixes: be8e5d957366 ("test/crypto: add further ZUC testcases") Signed-off-by: Ciara Power --- app/test/test_crypto

[PATCH v2] test/crypto: add further ZUC testcases

2022-12-21 Thread Ciara Power
Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. Signed-off-by: Ciara Power --- v2: fixed variable initialisation. --- app/test/test_cryptodev.c | 446

[PATCH] crypto/qat: fix stream cipher direction

2022-12-21 Thread Ciara Power
Signed-off-by: Ciara Power --- drivers/crypto/qat/qat_sym_session.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 0ebc66f89e..c91acc1e9b 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++

[PATCH] test/crypto: add further ZUC testcases

2022-12-21 Thread Ciara Power
Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 444 +++--- 1 file

[PATCH] crypto/qat: enable asymmetric crypto on gen3 device

2022-12-14 Thread Ciara Power
This commit enables asymmetric crypto in generation three devices. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/qat.rst| 3 ++- doc/guides/rel_notes/release_23_03.rst | 3 +++ drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 12 3 files changed, 13

[PATCH] crypto/qat: add SHA3 plain hash support

2022-12-14 Thread Ciara Power
Add support for plain SHA3-224, SHA3-256, SHA3-384, and SHA3-512 hash support in QAT GEN3. Add support for SHA3-256 in GEN2. Signed-off-by: Ciara Power --- Tested using testcases from patch not yet merged. https://patchwork.dpdk.org/project/dpdk/patch/20221109152809.2026484-1-vfia

[PATCH 2/2] test/crypto-perf: replace slave with worker

2022-11-14 Thread Ciara Power
Update the use of outdated language "slaves" with "workers". Signed-off-by: Ciara Power --- app/test-crypto-perf/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 22f6b2b3ba..af5bd0d

  1   2   3   4   5   6   7   8   9   >