From: Kusztal, ArkadiuszX
Sent: 25 July 2019 19:57
To: Shally Verma ; Anoob Joseph ; Ayuj
Verma ; akhil.go...@nxp.com
Cc: Sunila Sahu ; Kanaka Durga Kotamarthy
; dev@dpdk.org ; Trahe, Fiona
Subject: RE: [PATCH v1 0/2] declare crypto asym xform immutable
Improve logic:
* to get list of valid devices based on driver id so that to
eliminate unnecessary if check for driver id match in device loop
* loop till 1st device supporting asymmetric feature is found unlike
previous logic which breaks on 1st device
Ayuj Verma (1):
test/crypto
Kotamarthy
Signed-off-by: Ayuj Verma
---
app/test/test_cryptodev_asym.c | 43 +-
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 95e7d34..e8177e7 100644
--- a/app/test
Marked asym xform as constant.
Signed-off-by: Ayuj Verma
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index a307c91
+Fiona.
From: Ayuj Verma
Sent: 24 July 2019 14:21:55
To: akhil.go...@nxp.com
Cc: arkadiuszx.kusz...@intel.com ; Shally Verma
; Sunila Sahu ; Kanaka Durga Kotamarthy
; Anoob Joseph ; dev@dpdk.org
; Ayuj Verma
Subject: [PATCH v1 0/2] declare crypto asym xform
ption.
* Updated openssl PMD with above changes.
Ayuj Verma (2):
lib/crypto: declare crypto asym xform immutable
crypto/openssl: mark asym xform constant
doc/guides/prog_guide/cryptodev_lib.rst | 10 ++
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 8
lib/librte_cryp
Update asym xform usage in cryptodev documentation.
Change lib spec to mark xform as const read only
pointer which cannot be manipulated once initiallized
on session.
Signed-off-by: Ayuj Verma
---
doc/guides/prog_guide/cryptodev_lib.rst | 10 ++
lib/librte_cryptodev/rte_cryptodev.c
Hi Akhil, Arek, Fiona,
Since this require changes in other Asym PMD( qat) apart from openssl (we plan
to send changes for this),
so should we need to send any announcement on ABI breakage here before
proposing patch v1?
Thanks and regards
Ayuj Verma
From
orporate this in Patch v1.
Thanks and regards
Ayuj Verma
____
From: Ayuj Verma
Sent: 18 July 2019 15:26
To: Kusztal, ArkadiuszX; Trahe, Fiona; akhil.go...@nxp.com
Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev@dpdk.org
Subject: Re: [RFC] lib/crypto: mar
Hi Arek, Fiona
Please see in-line.
Thanks and regards
Ayuj Verma
From: Kusztal, ArkadiuszX
Sent: 17 July 2019 19:40
To: Trahe, Fiona; Ayuj Verma; akhil.go...@nxp.com
Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev@dpdk.org
Subject: RE: [RFC] lib
Hi Arek,
Please see inline.
Thanks and regards
Ayuj Verma
From: Kusztal, ArkadiuszX
Sent: 17 July 2019 19:40
To: Ayuj Verma; akhil.go...@nxp.com
Cc: Trahe, Fiona; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy;
dev@dpdk.org
Subject: RE: [RFC] mark asym
Update asym xform usage in cryptodev documentation.
Xform are immutable, non-reuseable entity till
life time of session. This allow some PMD to optimize
session setup time.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
doc/guides/prog_guide/cryptodev_lib.rst | 6 ++
lib
till lifetime
of session. This will help PMDs to reduce session setup time.
Ayuj Verma (1):
lib/crypto: mark asym session-buffer non-reuseable
doc/guides/prog_guide/cryptodev_lib.rst | 6 ++
lib/librte_cryptodev/rte_cryptodev_pmd.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion
Added RSA sign/verify and enc/dec tests for RSA
key type CRT(quintuple) and associated test vectors.
Signed-off-by: Kanaka Durga Kotamarthy
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 97 ++
app/test
Move common code of enqueue/dequeue into separate functions.
Signed-off-by: Kanaka Durga Kotamarthy
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 413 -
1 file changed, 199 insertions(+), 214 deletions
ff_disable set
Ayuj Verma (2):
test/crypto: move rsa enqueue/dequeue into separate functions
test/crypto: add tests for RSA key type CRT
app/test/test_cryptodev_asym.c | 460 +
app/test/test_cryptodev_rsa_test_vectors.h | 93 ++
2 files changed, 363
Changes in v4:
- add reason for change as part of commit message log
Changes in v3:
- retain '-1' for app error.
- add NULL check for rte_cryptodev_asym_capability_get()
- Typo correction
Changes in v2:
- Replace TEST_SKIPPED/-1 with -ENOTSUP
Ayu
- Return -ENOTSUP for unsupported tests
- add NULL check for rte_cryptodev_asym_capability_get()
- Typo correction
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 45 ++
1 file changed, 32 insertions(+), 13 deletions
Hi Akhil,
Sorry for delay.
I have sent v4 for this.
Thanks for the heads up.
Regards
Ayuj Verma
From: Akhil Goyal
Sent: 09 May 2019 14:23:25
To: Ayuj Verma
Cc: dev@dpdk.org; arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally
Verma; Sunila Sahu
- Return -ENOTSUP for unsupported tests
- add NULL check for rte_cryptodev_asym_capability_get()
- Typo correction
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 45 ++
1 file changed, 32 insertions(+), 13
Changes in v3:
- retain '-1' for app error.
- add NULL check for rte_cryptodev_asym_capability_get()
- Typo correction
Changes in v2:
- Replace TEST_SKIPPED/-1 with -ENOTSUP
Ayuj Verma (1):
app/test: replace TEST_SKIPPED with -ENOTSUP
app/test/test_crypto
include rte_crypto_sym.h in asym header file.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
index 5e43620
include rte_crypto_sym.h in asym header file.
Changes in v2:
- Change commit summary from “fix alphabetical ordering of headers”
to better reflect intent of change. Previous patch set version
http://mails.dpdk.org/archives/dev/2019-April/130010.html .
- revert change in rte_crypto.h
Ayuj
Hi Fiona,
Sorry for delay in response.
Please see inline.
Thanks and regards
Ayuj Verma
From: Trahe, Fiona
Sent: 12 April 2019 20:47
To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX
Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind
Hi Fiona,
Please see inline.
Thanks and regards
Ayuj Verma
From: Trahe, Fiona
Sent: 09 April 2019 20:47
To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX; De Lara Guarch, Pablo
Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai
include rte_crypto_sym.h in rte_crypto_asym.h in place
of including it in rte_crypto.h.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_crypto.h | 1 -
lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff
rte_crypto_sym.h is included prior to rte_crypto_asym.h
in rte_crypto.h, which breaks alphabetical order.
include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
Ayuj Verma (1):
lib/crypto: fix alphabetical ordering of headers
lib/librte_cryptodev/rte_crypto.h | 1 -
lib
Hi Bruce,
Have you gone through patch-set
v1<http://mails.dpdk.org/archives/dev/2019-April/128407.html>
What's your opinion on them.
Thanks and regards
Ayuj Verma
From: Bruce Richardson
Sent: 09 April 2019 20:25:32
To: Ayuj Verma
Cc: akhil.go
Changes in v2:
- Replace TEST_SKIPPED/-1 with -ENOTSUP
Ayuj Verma (1):
app/test: replace TEST_SKIPPED with -ENOTSUP
app/test/test_cryptodev_asym.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
--
1.8.3.1
Return -ENOTSUP for unsupported tests
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index d2efce9..feed3a8
Hi Akhil,
Thanks.
Regards
Ayuj Verma
From: Akhil Goyal
Sent: 03 April 2019 14:17:11
To: Ayuj Verma
Cc: arkadiuszx.kusz...@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga
Kotamarthy; Arvind Desai; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/4
+ Fiona and Pablo
Hi Akhil, Arek, Fiona and Pablo
Did you get a chance to look into this.
Thanks and regards
Ayuj Verma
From: Ayuj Verma
Sent: 01 April 2019 13:01:56
To: akhil.go...@nxp.com
Cc: arkadiuszx.kusz...@intel.com; Shally Verma; Sunila Sahu
Hi Akhil,
Did you get chance to look into this.
Thanks and regards
Ayuj Verma
From: Ayuj Verma
Sent: 01 April 2019 13:01:56
To: akhil.go...@nxp.com
Cc: arkadiuszx.kusz...@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga
Kotamarthy; Arvind Desai; dev
Add skipped counter to count for number of skipped testcases.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test.c b/app/test/test.c
index d646f51..1e0113b 100644
--- a/app/test/test.c
+++ b/app/test
different purpose, thus add a new counter
skipped in test app to count number of skipped test.
Ayuj Verma (1):
app/test: add check for test skipped
app/test/test.c | 2 ++
1 file changed, 2 insertions(+)
--
1.8.3.1
Hi Akhil,
Thanks.
Please add relevant information in the description in future.
Sure will keep this in mind.
Thanks and regards
Ayuj Verma
From: Akhil Goyal
Sent: 29 March 2019 20:47:33
To: Ayuj Verma
Cc: arkadiuszx.kusz...@intel.com; Shally Verma; Sunila
Add ff description in overview.rst and update
feature support in Openssl PMD feature list
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
doc/guides/cryptodevs/features/openssl.ini | 2 ++
doc/guides/cryptodevs/overview.rst | 6 ++
2 files changed, 8 insertions(+)
diff
type.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_cryptodev.c | 4
lib/librte_cryptodev/rte_cryptodev.h | 4
2 files changed, 8 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.c
b/lib/librte_cryptodev/rte_cryptodev.c
index 871d7dd
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index a779e8f..539eda1 100644
--- a/app/test
openssl PMD support RSA private key operation
using both qt and exp key type.
Set rsa key type feature flag
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto
quintuple,
in place of making them part of xform capabilities.
Ayuj Verma (4):
lib/cryptodev: add rsa priv key feature flag
crypto/openssl: set rsa private op feature flag
app/test: check for key type ff in asym unit test
doc: add rsa key type to feature list
app/test
Hi Akhil, Arek,
Sure, I'll rebase the patch and will send v3 along with doc changes.
Thanks and regards
Ayuj Verma
-Original Message-
From: Akhil Goyal
Sent: Sunday, March 17, 2019 11:17 PM
To: Ayuj Verma
Cc: arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally Verma
; S
Hi Akhil, Fiona, Arek,
Gentle reminder.
Did you get a chance to look into these.
Thanks and regards
Ayuj Verma
From: dev on behalf of Ayuj Verma
Sent: 05 March 2019 14:41:18
To: akhil.go...@nxp.com
Cc: arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com
Hi Akhil,
Did you get a chance to look into these.
Thanks and regards
Ayuj Verma
From: Ayuj Verma
Sent: 27 February 2019 19:03:31
To: akhil.go...@nxp.com
Cc: arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally Verma; Sunila
Sahu; Kanaka Durga
Check for RSA private key type feature flag in
private key operations
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
test/test/test_cryptodev_asym.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/test/test/test_cryptodev_asym.c b/test/test
RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT which would mean support
to perform a private key op using CRT keys (quintuple) or
exponent or both.
App should query PMD feature flag to check if specific
key type is supported and call operation with relevant key type.
Ayuj Verma (3):
lib/cryptodev: add rsa priv key
openssl PMD support RSA private key operation
using both qt and exp key type.
Set both feature flag in PMD capability
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
type.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_cryptodev.c | 4
lib/librte_cryptodev/rte_cryptodev.h | 4
2 files changed, 8 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.c
b/lib/librte_cryptodev/rte_cryptodev.c
index
Hi Pablo,Fiona
Did you get a chance to look into these.
Thanks and regards
Ayuj Verma
From: Ayuj Verma
Sent: 06 February 2019 16:46:17
To: pablo.de.lara.gua...@intel.com
Cc: fiona.tr...@intel.com; dev@dpdk.org; Shally Verma; Sunila Sahu; Kanaka
Durga
, thus call operation with relevant key type.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_crypto_asym.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
index 5e185b2dd
SIGN/DECRYPT_CRT variant,
current SIGN and DECRYPT operation default to using quintuple RSA keys.
Ayuj Verma (3):
lib/cryptodev: add crt sign and decrypt ops
crypto/openssl: update op-type mask with crt ops
test/crypto: check for rsa capa for op-type
drivers/crypto/openssl
Add a rsa xform capability check in test functions,
to check for supported sign and decrypt op_types
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
test/test/test_cryptodev_asym.c | 47 +
1 file changed, 47 insertions(+)
diff --git a/test/test
add new asym op_types RTE_CRYPTO_ASYM_OP_SIGN_CRT and
RTE_CRYPTO_ASYM_OP_DECRYPT_CRT in capability structure
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers
53 matches
Mail list logo
