RE: [EXTERNAL] [PATCH v2] eventdev: make flag types consistent with API

2025-06-26 Thread Jerin Jacob
> -Original Message- > From: Mattias Rönnblom > Sent: Thursday, June 26, 2025 7:49 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Mattias Rönnblom ; Mattias > Rönnblom > Subject: [EXTERNAL] [PATCH v2] eventdev: make flag types consistent with API > > Make RTE_EVENT_DEV_CAP_* flags' type con

Re: [PATCH v3 2/2] dts: add flow validation

2025-06-26 Thread Patrick Robb
Applied to next-dts, thanks. On Thu, Jun 26, 2025 at 3:56 PM Dean Marx wrote: > Add a method for validating flow rules to the testpmd shell class. > Implement test case skipping for flow rules that do not pass > validation. > > Signed-off-by: Dean Marx > Reviewed-by: Patrick Robb > --- > dts/

Re: [PATCH v3 1/2] dts: add rte flow test suite

2025-06-26 Thread Patrick Robb
Applied to next-dts, thanks. On Thu, Jun 26, 2025 at 3:56 PM Dean Marx wrote: > Add an RTE Flow API testing suite, which covers some basic > synchronous Flow API rules that should be supported across PMDs. > This suite will be added to over time, as the Flow API is too large > to cover all in on

Re: Re: [PATCH v5 3/3] riscv: override machine_args only when default

2025-06-26 Thread 孙越池
Okay, they have been updated in v6. > -原始邮件- > 发件人: "Stanisław Kardach" > 发送时间: 2025-06-27 10:31:15 (星期五) > 收件人: u...@foxmail.com > 抄送: dev@dpdk.org, "Sun Yuechi" , "Bruce Richardson" > 主题: Re: [PATCH v5 3/3] riscv: override machine_args only when default > > On Wed, Jun 11, 2025 at 5

[PATCH v6 1/3] config/riscv: detect V extension

2025-06-26 Thread uk7b
From: Sun Yuechi This patch is derived from "config/riscv: detect presence of Zbc extension with modifications". The RISC-V C api defines architecture extension test macros These let us detect whether the V extension is supported on the compiler and -march we're building with. The C api also def

[PATCH v6 3/3] riscv: override machine_args only when default

2025-06-26 Thread uk7b
From: Sun Yuechi Support using -Dcpu_instruction_set=rv64gcv to enable V extension. Signed-off-by: Sun Yuechi --- config/riscv/meson.build | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/config/riscv/meson.build b/config/riscv/meson.build index e3694cf2e6..

[PATCH v6 2/3] lib/lpm: R-V V rte_lpm_lookupx4

2025-06-26 Thread uk7b
From: Sun Yuechi The initialization of vtbl_entry is not fully vectorized here because doing so would require __riscv_vluxei32_v_u32m1, which is slower than the scalar approach in this small-scale scenario. - Test: app/test/lpm_perf_autotest - Platform: Banana Pi(BPI-F3) - SoC: Spacemit X60 (8 c

[PATCH v6 0/3] Add RISC-V V extension detection and LPM optimization

2025-06-26 Thread uk7b
From: Sun Yuechi This patch series adds support for the RISC-V Vector (V) extension and provides an optimized implementation of `rte_lpm_lookupx4` using RVV. The initialization of vtbl_entry is not fully vectorized here because doing so would require __riscv_vluxei32_v_u32m1, which is slower tha

Re: [PATCH v5 3/3] riscv: override machine_args only when default

2025-06-26 Thread Stanisław Kardach
On Wed, Jun 11, 2025 at 5:23 PM wrote: > > From: Sun Yuechi > > Support using -Dcpu_instruction_set=rv64gcv to enable V extension. > > Signed-off-by: Sun Yuechi > --- > config/riscv/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/config/riscv/meson.build b/config/riscv/me

RE: [PATCH v3 1/2] latencystats: fix receive sample MP issues

2025-06-26 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen > -Original Message- > From: Stephen Hemminger > Sent: Thursday, June 26, 2025 8:31 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; David Marchand ; > sta...@dpdk.org > Subject: Re: [PATCH v3 1/2] latencystats: fix receive

[PATCH v3 03/16] net/nbl: add PHY layer definitions and implementation

2025-06-26 Thread dimon.zhao
add PHY layer related definitions and product ops Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 54 -- drivers/net/nbl/nbl_core.h| 30 +- drivers/net/nbl/nbl_ethdev.c

[PATCH v3 16/16] net/nbl: nbl device support set MTU and promisc

2025-06-26 Thread dimon.zhao
Implement NBL device set MTU and promisc functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.h| 2 + drivers/net/nbl/nbl_dev/nbl_dev.c | 60 +++ drivers/net/nbl/nbl_dev/nbl_dev.h | 4 +- drivers/net/nbl/nbl_dispatch.c

[PATCH v3 15/16] net/nbl: add nbl device xstats and stats

2025-06-26 Thread dimon.zhao
Implement NBL device xstats and stats functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 148 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 2 + drivers/net/nbl/nbl_dispatch.c| 111 + .../nbl/nbl_hw/nbl_hw_le

[PATCH v3 14/16] net/nbl: add nbl device Tx and Rx burst

2025-06-26 Thread dimon.zhao
Implement NBL device Tx and Rx burst Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 108 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 5 + drivers/net/nbl/nbl_dispatch.c| 62 drivers/net/nbl/nbl_ethdev.c | 7 + d

[PATCH v3 13/16] net/nbl: add nbl device start and stop ops

2025-06-26 Thread dimon.zhao
Implement NBL device start and stop functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 173 +- drivers/net/nbl/nbl_dispatch.c| 121 +++- drivers/net/nbl/nbl_ethdev.c | 5 + drivers/net/nbl/nbl_hw/nbl_

[PATCH v3 11/16] net/nbl: add nbl ethdev configuration

2025-06-26 Thread dimon.zhao
NBL device add ethdev configuration Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 33 +-- drivers/net/nbl/nbl_include/nbl_include.h | 3 ++- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/net/nbl/nbl_dev/nbl_dev.c b/drive

[PATCH v3 12/16] net/nbl: add nbl device rxtx queue setup and release ops

2025-06-26 Thread dimon.zhao
Implement NBL device Rx and Tx queue setup & release functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 81 + .../nbl/nbl_hw/nbl_hw_leonis/nbl_res_leonis.c | 2 + drivers/net/nbl/nbl_hw/nbl_resource.h | 99 ++ drivers/net/nbl/nbl_hw/nbl_tx

[PATCH v3 10/16] net/nbl: add nbl coexistence mode for nbl

2025-06-26 Thread dimon.zhao
NBL device support coexistence mode Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_common/nbl_userdev.c | 729 +- drivers/net/nbl/nbl_common/nbl_userdev.h | 11 + drivers/net/nbl/nbl_core.c| 3 +- drivers/net/nbl/nbl_core.h|

[PATCH v3 09/16] net/nbl: add UIO and VFIO mode for nbl

2025-06-26 Thread dimon.zhao
NBL device support UIO/VFIO Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_common/nbl_userdev.c | 24 +++ drivers/net/nbl/nbl_common/nbl_userdev.h | 10 .../nbl_hw_leonis/nbl_phy_leonis_snic.c | 7

[PATCH v3 08/16] net/nbl: add complete device init and uninit functionality

2025-06-26 Thread dimon.zhao
NBL device is a concept of low level device which used to manage hw resource and to interact with fw Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.c| 8 +- drivers/net/nbl/nbl_core.h| 7 + drivers/net/nbl/nbl_dev/nbl_dev.c | 248 ++

[PATCH v3 07/16] net/nbl: add Dev layer definitions and implementation

2025-06-26 Thread dimon.zhao
add Dev layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 14 +- drivers/net/nbl/nbl_core.h| 16 ++ drivers/net/nbl/nbl_dev/nbl_dev.c | 200 ++ drive

[PATCH v3 06/16] net/nbl: add Dispatch layer definitions and implementation

2025-06-26 Thread dimon.zhao
add Dispatch layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_core.c| 7 + drivers/net/nbl/nbl_core.h| 4 + drivers/net/nbl/nbl_dispatch.c| 466 ++

[PATCH v3 04/16] net/nbl: add Channel layer definitions and implementation

2025-06-26 Thread dimon.zhao
add Channel layer related definitions and nbl_thread for mbx interact Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_common/nbl_common.c | 47 ++ drivers/net/nbl/nbl_common/nbl_common.h | 10 + drivers/net/nbl/nbl_common/nbl

[PATCH v3 05/16] net/nbl: add Resource layer definitions and implementation

2025-06-26 Thread dimon.zhao
add Resource layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_core.c| 11 +- drivers/net/nbl/nbl_core.h| 4 + .../nbl/nbl_hw/nbl_hw_leonis/nbl_res_leonis.c | 137 +

[PATCH v3 01/16] net/nbl: add doc and minimum nbl build framework

2025-06-26 Thread dimon.zhao
add minimum PMD code, doc and build infrastructure for nbl driver. Signed-off-by: dimon.zhao --- .mailmap | 4 +++ MAINTAINERS | 9 +++ doc/guides/nics/features/nbl.ini | 9 +++ doc/guides/nics/index.rst| 1 + doc/guides/nics/nbl.r

[PATCH v3 02/16] net/nbl: add simple probe/remove and log module

2025-06-26 Thread dimon.zhao
Our driver architecture is relatively complex because the code is highly reusable and designed to support multiple features. For example, our driver can support open-source UIO/VFIO drivers while also coexisting with kernel drivers. Additionally, the codebase supports multiple chip variants, each w

[PATCH v3 00/16] NBL PMD for Nebulamatrix NICs

2025-06-26 Thread dimon.zhao
Features: - - MTU update - promisc mode set - xstats - Basic stats  Support NICs: - - S1205CQ-A00CHT - S1105AS-A00CHT - S1055AS-A00CHT - S1052AS-A00CHT - S1051AS-A00CHT - S1045XS-A00CHT - S1205CQ-A00CSP - S1055AS-A00CSP - S1052AS-A00CSP Dimon Zhao (16): net/nbl: add doc and

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-06-26 Thread Yogev Chaimovich
OK. I wished there was a DPDK function to verify if transceiver is plugged in or not, without log errors. Such as rte_eth_dev_is_module_exist() So, 1'st I would have checked if it's plugged in. Then I would have used rte_eth_dev_get_module_info(). The workaround is setting the module's log leve

Re: [RFC 13/18] net/hinic3: add dev ops

2025-06-26 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:59 +0800 Feifei Wang wrote: > +static int > +hinic3_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t > fw_size) > +{ > + struct hinic3_nic_dev *nic_dev = HINIC3_ETH_DEV_TO_PRIVATE_NIC_DEV(dev); > + char mgmt_ver[MGMT_VERSION_MAX_LEN] = {0}; > +

Re: [RFC 14/18] net/hinic3: add Rx/Tx functions

2025-06-26 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:00 +0800 Feifei Wang wrote: > From: Feifei Wang > > This patch add package sending and receiving function codes. > > Signed-off-by: Feifei Wang > Signed-off-by: Yi Chen > Reviewed-by: Xin Wang > --- This code has lots of places where __rte_unused is added, but the

Re: [RFC 13/18] net/hinic3: add dev ops

2025-06-26 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:59 +0800 Feifei Wang wrote: > +static int > +hinic3_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t > fw_size) > +{ > + struct hinic3_nic_dev *nic_dev = HINIC3_ETH_DEV_TO_PRIVATE_NIC_DEV(dev); > + char mgmt_ver[MGMT_VERSION_MAX_LEN] = {0}; > +

Re: [RFC 14/18] net/hinic3: add Rx/Tx functions

2025-06-26 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:06:00 +0800 Feifei Wang wrote: > From: Feifei Wang > > This patch add package sending and receiving function codes. > > Signed-off-by: Feifei Wang > Signed-off-by: Yi Chen > Reviewed-by: Xin Wang > --- If your driver doesn't implement these call backs, then leave the

[PATCH v2] net/gve: support gve driver on FreeBSD

2025-06-26 Thread Jasper Tran O'Leary
This commit adds small changes so that the gve driver can build when FreeBSD is the host operating system. Signed-off-by: Jasper Tran O'Leary Acked-by: Joshua Washington --- .mailmap | 1 + doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/base/gve_osdep.h | 2 --

Re: [PATCH] net/gve: support gve driver on FreeBSD

2025-06-26 Thread Jasper Tran O'Leary
Thank you all for the feedback; I've made these changes and will resubmit. On Thu, Jun 26, 2025 at 7:10 AM Stephen Hemminger wrote: > > On Wed, 25 Jun 2025 18:27:51 + > "Jasper Tran O'Leary" wrote: > > > This commit adds small changes so that the gve driver can build when > > FreeBSD is the

Re: [V2 17/18] net/hinic3: add FDIR flow control module

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 10:28:13 +0800 Feifei Wang wrote: > diff --git a/drivers/net/hinic3/hinic3_fdir.c > b/drivers/net/hinic3/hinic3_fdir.c > new file mode 100644 > index 00..32fc5472bd > --- /dev/null > +++ b/drivers/net/hinic3/hinic3_fdir.c > @@ -0,0 +1,1394 @@ Suggestion: Don't call t

[PATCH v3 2/2] dts: add flow validation

2025-06-26 Thread Dean Marx
Add a method for validating flow rules to the testpmd shell class. Implement test case skipping for flow rules that do not pass validation. Signed-off-by: Dean Marx Reviewed-by: Patrick Robb --- dts/framework/remote_session/testpmd_shell.py | 15 + dts/framework/test_run.py

[PATCH v3 1/2] dts: add rte flow test suite

2025-06-26 Thread Dean Marx
Add an RTE Flow API testing suite, which covers some basic synchronous Flow API rules that should be supported across PMDs. This suite will be added to over time, as the Flow API is too large to cover all in one suite, and sending one monolithic series would be impossible. Signed-off-by: Dean Marx

[DPDK/ethdev Bug 1732] E830 Tx packet pacing support causing seg fault on E810

2025-06-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1732 Bug ID: 1732 Summary: E830 Tx packet pacing support causing seg fault on E810 Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED

Re: [PATCH] raw/cnxk_gpio: fix out of bound access

2025-06-26 Thread Jerin Jacob
On Wed, Jun 25, 2025 at 4:52 PM Tomasz Duszynski wrote: > > In rare circumstances such as when underlying gpio device is being > removed while userspace access is still ongoing flags returned from > ioctl() may be invalid. > > Coverity issue: 469060 > Coverity issue: 469061 > Coverity issue: 46906

[PATCH v2] app/testpmd: cross NUMA support

2025-06-26 Thread Maayan Kashani
Cross NUMA support means that if the current NUMA is out of memory, use another available NUMA memory. This patch is meant to support cross NUMA in testpmd, when disabling gro, gro fix for cross NUMA will come later. Replace pdump, metrics and dev shared data memory allocations to any socket inst

Re: [PATCH v1] app/eventdev: fix number of releases sent during cleanup

2025-06-26 Thread Jerin Jacob
On Tue, Jun 24, 2025 at 11:57 AM Pavan Nikhilesh Bhagavatula wrote: > > >During cleanup, only send releases for events app was > >not able to enqueue. Current code is sending releases for > >entire dequeue burst. > > > >Fixes: f0b68c0b2af7 ("app/eventdev: clean up worker state before exit") > >Cc:

Re: DPDK libs as one big shared object

2025-06-26 Thread Bruce Richardson
On Thu, Jun 26, 2025 at 05:16:10PM +0200, Thomas Monjalon wrote: > 26/06/2025 14:53, Stephen Hemminger: > > On Wed, 18 Jun 2025 12:01:45 +0200 > > Thomas Monjalon wrote: > > > > > 18/06/2025 09:39, Morten Brørup: > > > > > Why are we still building one .so file per DPDK library, instead of > > >

Re: [PATCH v2 0/4] net/mlx5: support non template SAMPLE flow action

2025-06-26 Thread Thomas Monjalon
26/06/2025 09:59, Gregory Etelson: > Support SAMPLE flow action in the non-template API. > > Bing Zhao (1): > net/mlx5: fix the table flags of mirror action > > Gregory Etelson (3): > net/mlx5: add a stand alone function for mirror creation > net/mlx5: add functions for non template sample

Re: [V2 17/18] net/hinic3: add FDIR flow control module

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 10:28:13 +0800 Feifei Wang wrote: > From: Yi Chen > > Added support for rte_flow, including ethertype, IPv4, > IPv6, and tunnel VXLAN. In addition, user can add or delete filters. > > Signed-off-by: Yi Chen > Reviewed-by: Xin Wang > Reviewed-by: Feifei Wang > --- You ad

Re: [V2 01/18] add some basic files about hinic3 driver

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 10:27:57 +0800 Feifei Wang wrote: > From: Yi Chen > > This patch adds some basic files to describe the hinic3 driver. > > Signed-off-by: Feifei Wang > Signed-off-by: Yi Chen > Reviewed-by: Xin Wang The Subject here should include net/hinic3 $ ./devtools/check-git-log.

Re: [V2 00/18] add hinic3 pmd driver

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 10:27:56 +0800 Feifei Wang wrote: > From: Yi Chen > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (2): > net/hinic3: add dev ops > net/hinic3: add Rx/Tx functio

Re: [V2 01/18] add some basic files about hinic3 driver

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 10:27:57 +0800 Feifei Wang wrote: > diff --git a/doc/guides/nics/hinic3.rst b/doc/guides/nics/hinic3.rst > new file mode 100644 > index 00..6ab13113b8 > --- /dev/null > +++ b/doc/guides/nics/hinic3.rst > @@ -0,0 +1,51 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +

RE: [PATCH] net/null: Add fast mbuf release TX offload

2025-06-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 26 June 2025 16.06 > > On Tue, 24 Jun 2025 18:14:16 + > Morten Brørup wrote: > > > Added fast mbuf release, re-using the existing mbuf pool pointer > > in the queue structure. > > > > Signed-off-by: Morten Brørup

[PATCH v2 2/4] dts: remove unnecessary testpmd verification

2025-06-26 Thread Dean Marx
Remove unnecessary verification step in the start method of TestPmdShell which checks the link status. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 7 --- 1 file changed, 7 deletions(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framewo

[PATCH v2 4/4] dts: add physical function capability check

2025-06-26 Thread Dean Marx
Add a physical function NIC capability that checks if the test run is using PFs. Add PF capability requirement to all suites/cases that do not run without error on virtual functions. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 22 +++ dts/tests/Te

[PATCH v2 3/4] dts: modify existing suites to work with VFs

2025-06-26 Thread Dean Marx
Modify existing test suites to use broadcast destination MAC addresses when possible, rather than a default MAC address assigned by DTS during execution. VFs do not consistently receive and forward packets unless the MAC address is broadcast or matches the VF address, even with promiscuous mode en

[PATCH v2 1/4] dts: add virtual functions to framework

2025-06-26 Thread Dean Marx
Add virtual functions to DTS framework, along with a field for specifying VF test runs in the config file. Signed-off-by: Patrick Robb Signed-off-by: Dean Marx --- dts/framework/config/test_run.py | 2 + dts/framework/test_run.py| 7 +++ dts/framework/testbed_m

RE: Function to fail at build time?

2025-06-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 26 June 2025 16.32 > > On Thu, 26 Jun 2025 01:55:02 +0200 > Morten Brørup wrote: > > > I was wondering if this was somehow possible: > > > > #define RTE_VERIFY(exp) do { \ > > + if (__rte_constant(exp)) \ > > +

Re: [PATCH v2 2/3] net/mlx5: add new devarg for Tx queue consecutive memory

2025-06-26 Thread Thomas Monjalon
26/06/2025 16:29, Stephen Hemminger: > On Thu, 26 Jun 2025 13:18:18 + > Bing Zhao wrote: > > > Hi Stephen, > > > > Thanks for your review and comments. I will add the description about the > > new devarg in our mlx5.rst file to have a detailed description. > > Indeed, after some review and

Re: DPDK libs as one big shared object

2025-06-26 Thread Thomas Monjalon
26/06/2025 14:53, Stephen Hemminger: > On Wed, 18 Jun 2025 12:01:45 +0200 > Thomas Monjalon wrote: > > > 18/06/2025 09:39, Morten Brørup: > > > > Why are we still building one .so file per DPDK library, instead of just > > > > building one big dpdk.so for all DPDK libraries? > > > > I think it's

Re: [PATCH] ethdev: sync ethtool link modes with Linux 6.15

2025-06-26 Thread Thomas Monjalon
26/06/2025 16:26, Stephen Hemminger: > On Wed, 25 Jun 2025 15:42:02 +0200 > Thomas Monjalon wrote: > > > diff --git a/lib/ethdev/ethdev_linux_ethtool.c > > b/lib/ethdev/ethdev_linux_ethtool.c > > index ec42d3054a..f508cdba6c 100644 > > --- a/lib/ethdev/ethdev_linux_ethtool.c > > +++ b/lib/ethdev

Re: [PATCH v2 2/3] net/mlx5: add new devarg for Tx queue consecutive memory

2025-06-26 Thread Stephen Hemminger
On Thu, 26 Jun 2025 13:18:18 + Bing Zhao wrote: > Hi Stephen, > > Thanks for your review and comments. I will add the description about the new > devarg in our mlx5.rst file to have a detailed description. > Indeed, after some review and internal call discussion with our datapath > experts

Re: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API

2025-06-26 Thread Mattias Rönnblom
On 2025-06-26 16:12, Jerin Jacob wrote: -Original Message- From: Mattias Rönnblom Sent: Thursday, June 26, 2025 7:23 PM To: Jerin Jacob Cc: dev@dpdk.org; Mattias Rönnblom ; Mattias Rönnblom Subject: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API Make RTE_EVENT_DEV_CA

[PATCH v2] eventdev: make flag types consistent with API

2025-06-26 Thread Mattias Rönnblom
Make RTE_EVENT_DEV_CAP_* flags' type consistent with the rte_event_dev_info.event_dev_cap's type. Make RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT consistent with rte_event_dev_config.event_dev_cfg. Make RTE_EVENT_QUEUE_CFG_* consistent with rte_event_queue_conf.event_queue_cfg. Make RTE_EVENT_PORT_CF

Re: [PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Khadem Ullah
Thank you very much for the review and Ack. I’ll make sure to include version change notes under a notes section in future patch versions, as per the contribution guide. Also noted about maintainers, I had added them in v1 but missed them in v2. I’ll make sure to always use `get-maintainer.sh` go

Re: [PATCH] ethdev: sync ethtool link modes with Linux 6.15

2025-06-26 Thread Stephen Hemminger
On Wed, 25 Jun 2025 15:42:02 +0200 Thomas Monjalon wrote: > diff --git a/lib/ethdev/ethdev_linux_ethtool.c > b/lib/ethdev/ethdev_linux_ethtool.c > index ec42d3054a..f508cdba6c 100644 > --- a/lib/ethdev/ethdev_linux_ethtool.c > +++ b/lib/ethdev/ethdev_linux_ethtool.c > @@ -17,8 +17,9 @@ > * >

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-26 Thread Stephen Hemminger
On Mon, 9 Jun 2025 15:19:37 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH v7 1/2] node: add global node mbuf dynfield

2025-06-26 Thread Nitin Saxena
Hi Stephen, On Thu, Jun 26, 2025 at 7:29 PM Stephen Hemminger wrote: > > On Thu, 19 Jun 2025 21:14:49 +0530 > Nitin Saxena wrote: > > > +#ifndef RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE > > +/** Size of persistent mbuf fields */ > > +#define RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE (0) > > +#e

RE: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API

2025-06-26 Thread Jerin Jacob
> -Original Message- > From: Mattias Rönnblom > Sent: Thursday, June 26, 2025 7:23 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Mattias Rönnblom ; Mattias > Rönnblom > Subject: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API > > Make RTE_EVENT_DEV_CAP_* flags' type consiste

[PATCH] eventdev: make flag types consistent with API

2025-06-26 Thread Mattias Rönnblom
Make RTE_EVENT_DEV_CAP_* flags' type consistent with the rte_event_dev_info.event_dev_cap's type. Make RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT consistent with rte_event_dev_config.event_dev_cfg. Make RTE_EVENT_QUEUE_CFG_* consistent with rte_event_queue_conf.event_queue_cfg. Make RTE_EVENT_PORT_CF

Re: [PATCH] net/null: Add fast mbuf release TX offload

2025-06-26 Thread Stephen Hemminger
On Tue, 24 Jun 2025 18:14:16 + Morten Brørup wrote: > Added fast mbuf release, re-using the existing mbuf pool pointer > in the queue structure. > > Signed-off-by: Morten Brørup Makes sense. > --- > drivers/net/null/rte_eth_null.c | 30 +++--- > 1 file changed, 27

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

2025-06-26 Thread Bruce Richardson
On Thu, Jun 26, 2025 at 07:00:11AM -0700, Stephen Hemminger wrote: > On Mon, 23 Jun 2025 17:12:43 +0100 > Bruce Richardson wrote: > > > On Mon, Jun 23, 2025 at 06:01:00PM +0200, David Marchand wrote: > > > On Tue, May 27, 2025 at 5:29 PM Bruce Richardson > > > wrote: > > > > > > > > As the num

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

2025-06-26 Thread Stephen Hemminger
On Mon, 23 Jun 2025 17:12:43 +0100 Bruce Richardson wrote: > On Mon, Jun 23, 2025 at 06:01:00PM +0200, David Marchand wrote: > > On Tue, May 27, 2025 at 5:29 PM Bruce Richardson > > wrote: > > > > > > As the number of cores/cpus on platforms has increased over the years, > > > the use of corem

Re: [PATCH v7 1/2] node: add global node mbuf dynfield

2025-06-26 Thread Stephen Hemminger
On Thu, 19 Jun 2025 21:14:49 +0530 Nitin Saxena wrote: > +#ifndef RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE > +/** Size of persistent mbuf fields */ > +#define RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE (0) > +#endif /* RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE */ > + > +#ifndef RTE_NODE_MBUF_OVERLOADAB

[PATCH iproute2] bond: fix stack smash in xstats

2025-06-26 Thread Stephen Hemminger
Building with stack smashing detection finds an off by one in the bond xstats attribute parsing. $ ip link xstats type bond dev bond0 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". bond0 LACPDU Rx 0

Re: [PATCH 2/2] doc: use core lists rather than masks in guides

2025-06-26 Thread Burakov, Anatoly
On 6/24/2025 3:34 PM, Bruce Richardson wrote: For the guides for applications and examples, use the "-l" flag rather than the "-c" flag to pass in core lists rather than core masks. While for the trivial examples given, core masks work fine and may be easier; in real-world cases, with potentially

Re: [PATCH 1/2] doc/eal: add doc entry for service core list flag

2025-06-26 Thread Burakov, Anatoly
On 6/24/2025 3:34 PM, Bruce Richardson wrote: In the list of EAL arguments, only the "-s" flag for service cores was documented. Add an entry for the "-S" one too, which takes a core list instead of a core mask. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/eal_args.include.rst | 5

Re: [PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Dariusz Sosnowski
Thank you very much for changes and detailed descriptions. It helped a lot during review. Acked-by: Dariusz Sosnowski On Thu, Jun 26, 2025 at 09:07:02AM -0400, Khadem Ullah wrote: > v2: > - Added missing check for AGE + CT conflict in flow_dv_query(). > - Removed unnecessary null check from fl

[PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Khadem Ullah
v2: - Added missing check for AGE + CT conflict in flow_dv_query(). - Removed unnecessary null check from flow_aso_age_get_by_idx(). - Added Fixes tag for LTS tracking. - Ensured .mailmap and Signed-off-by addresses match. This patch fixes a segmentation fault that occurs when querying the AGE

RE: [PATCH v2 2/3] net/mlx5: add new devarg for Tx queue consecutive memory

2025-06-26 Thread Bing Zhao
Hi Stephen, Thanks for your review and comments. I will add the description about the new devarg in our mlx5.rst file to have a detailed description. Indeed, after some review and internal call discussion with our datapath experts. We would like to change the devarg a little bit but not only 0 /

Re: [PATCH] common/mlx5: fix extraction of auxiliary network device name

2025-06-26 Thread Thomas Monjalon
15/06/2025 09:41, Gregory Etelson: > The PMD reads auxiliary network device name from the Linux SYSFS. > > The current implementation closed directory context before it copied > a file name from that directory into internal buffer. > > The patch closes SYSFS directory after file name was copied.

Re: [PATCH v2 2/2] net/mlx5: enhance log file path

2025-06-26 Thread Dariusz Sosnowski
Hi Yang, This patch breaks compilation on Windows: https://lab.dpdk.org/results/dashboard/testruns/logs/1600918/ The problem is that mlx5_rxtx.c is used on both Linux and Windows. Would you be able to fix the patch? I suggest to do the following: - Declare a function mlx5_os_debug_dump_file_ope

[PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Khadem Ullah
v2: - Added missing check for AGE + CT conflict in flow_dv_query(). - Removed unnecessary null check from flow_aso_age_get_by_idx(). - Added Fixes tag for LTS tracking. - Ensured .mailmap and Signed-off-by addresses match. This patch fixes a segmentation fault that occurs when querying the AGE

Re: [PATCH] net/af_xdp: add rx/tx queue support for af_xdp

2025-06-26 Thread Stephen Hemminger
On Wed, 18 Jun 2025 17:41:03 + Shivaji Kant wrote: > Driver like GVE do support rx/tx queue configuration > rather than combined queue. Enable AF_XDP vdev to use > rx/tx queue configuration instead of combined queue > configuration if available. The first sentence is awkward to read. Is the

Re: DPDK libs as one big shared object

2025-06-26 Thread Stephen Hemminger
On Wed, 18 Jun 2025 12:01:45 +0200 Thomas Monjalon wrote: > 18/06/2025 09:39, Morten Brørup: > > > Why are we still building one .so file per DPDK library, instead of just > > > building one big dpdk.so for all DPDK libraries? > > > I think it's legacy from when DPDK libraries were versioned indi

Re: [PATCH] net/mlx5: fix access to auxiliary flow data

2025-06-26 Thread Thomas Monjalon
25/06/2025 11:43, Gregory Etelson: > The MLX5 PMD keeps non-essential flow data in an auxiliary structure > to reduce flow L1 cache usage. > > The auxiliary data location differs in HWS and non-template flows. > > The PMD tried to fetch HWS flow table from a non-template flow object > and accesse

Re: [PATCH v2 1/2] net/mlx5: enhance socket file path

2025-06-26 Thread Dariusz Sosnowski
On Fri, Mar 21, 2025 at 09:27:49PM +0800, Yang Ming wrote: > The directory /var/tmp may not be writable in a container's > read-only mode. To address this issue, use the DPDK runtime > directory as an alternative when /var/tmp is not writable. > > Cc: bi...@nvidia.com > Cc: dsosnow...@nvidia.com >

Re: [PATCH v1] net/mlx5: use reg to match eswitch manager

2025-06-26 Thread Thomas Monjalon
19/06/2025 09:17, Rongwei Liu: > Rdma-core exposes E-Switch Manager vport metadata > for matching in flow rules. > Use that metadata when available. > > Signed-off-by: Rongwei Liu > Acked-by: Dariusz Sosnowski Applied, thanks.

Re: [PATCH] net/mlx5: fix segfault in counter pool destroy

2025-06-26 Thread Thomas Monjalon
25/06/2025 11:32, Maayan Kashani: > When there is not enough memory, counter pool creation fails. > As a result, the pool is being destroyed. > Since not all pointers were initialized during creation, > Need to check for null pointer in destruction. > > Fixes: 13ea6bdcc7ee ("net/mlx5: support coun

Re: [PATCH] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Dariusz Sosnowski
Hi, +Cc mlx5 maintainers Thank you for the contribution. Please see the comments inline. On Tue, Jun 24, 2025 at 01:10:15AM -0400, Khadem Ullah wrote: > This patch fixes a segmentation fault that occurs when querying the > age action of an indirect flow rule using connection tracking. > > Steps

Re: [PATCH v2] net/mlx5: support NUMA node fallback

2025-06-26 Thread Thomas Monjalon
25/06/2025 17:00, Maayan Kashani: > Cross NUMA support means that when there is no > memory on the local NUMA, use other available > NUMA memory for port initialization and start. > > If mlx5 malloc with specified socket failed, > malloc function would return an error. > To support cross NUMA, > N

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-06-26 Thread Dariusz Sosnowski
Hi Yogev, On Mon, Jun 09, 2025 at 01:11:27PM +, Yogev Chaimovich wrote: > Hi, > Actually looks like we're going with another workaround, so I might not be > needing my original patch. Could you tell us what kind of workaround you applied? Also, I'm not sure if this warning should be suppres

RE: [PATCH v2 02/10] test/telemetry: fix test calling all commands

2025-06-26 Thread Marat Khalili
> -Original Message- > From: David Marchand > Sent: Thursday 26 June 2025 09:33 > > The problem lies in the use of subshell and pipes and that a failure > is not propagated. > Adding a test only the the telemetry script would not catch other > errors (like for example, if the jq command s

[DPDK/other Bug 1731] FIB insertion error(-28) after remove all rules

2025-06-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1731 Bug ID: 1731 Summary: FIB insertion error(-28) after remove all rules Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [PATCH v2 05/10] cmdline: fix port list parsing

2025-06-26 Thread Marat Khalili
Acked-by: Marat Khalili

RE: release candidate 25.07-rc1

2025-06-26 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 12, 2025 9:57 AM > To: annou...@dpdk.org > Subject: release candidate 25.07-rc1 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v25.07-rc1 > > There are 542 new patches in

[PATCH] crypto/virtio: fix virtio desc flags virtq info

2025-06-26 Thread Rajesh Mudimadugula
This patch corrects virtio descriptor flags and updates virtqueue metadata. Fixes: 796429e72a6d ("crypto/virtio: add packed ring support") Signed-off-by: Rajesh Mudimadugula --- drivers/crypto/virtio/virtio_rxtx.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v2 02/10] test/telemetry: fix test calling all commands

2025-06-26 Thread David Marchand
On Tue, Jun 24, 2025 at 6:00 PM Marat Khalili wrote: > > Reviewed-by: Marat Khalili > > Just an idea, in case you have another iteration: could we maybe add a small > check that $telemetry_script actually exists and executable to avoid similar > situations in the future? Can be as simple as: >

[PATCH v3 15/15] doc: update for txgbe

2025-06-26 Thread Zaiyu Wang
Add new types of Wangxun NICs(Amber-Lite NIC models) into txgbe supported NICs list. Signed-off-by: Zaiyu Wang --- doc/guides/nics/txgbe.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/txgbe.rst b/doc/guides/nics/txgbe.rst index 93fb592759..e7b657f

[PATCH v3 14/15] net/txgbe: add other hardware-related changes

2025-06-26 Thread Zaiyu Wang
Add other hardware-related changes for Amber-Lite NICs, such as PF queue rate limit, enable/disable tx laser. Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_hw.c| 113 +-- drivers/net/txgbe/base/txgbe_osdep.h | 2 + drivers/net/txgbe/base/txgbe_phy.c |

[PATCH v3 13/15] net/txgbe: disable unstable features

2025-06-26 Thread Zaiyu Wang
Temporarily disabled unstable features on Amber-Lite NICs (e.g., flow control). These incomplete features will be gradually completed in future driver updates. Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_hw.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/t

[PATCH v3 12/15] net/txgbe: add GPIO configuration

2025-06-26 Thread Zaiyu Wang
Add GPIO configuration for Amber-Lite NICs to match design differences from 10G NICs: The Amber-Lite NIC requires additional setup steps compared to 10G NICs to ensure proper functionality of features SFP module detection. Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_regs.h | 2 +

[PATCH v3 11/15] net/txgbe: add FEC support for Amber-Lite 25G NICs

2025-06-26 Thread Zaiyu Wang
Amber-Lite 25G NICs support four FEC modes (off, baser, rs, auto). The driver implements standard interfaces (fec_get_capability, fec_get, fec_set) to allow manual configuration. The default FEC mode is set to 'auto'. Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_aml.c | 27 ++

[PATCH v3 10/15] net/txgbe: add RX desc merge mode for Amber-Lite NICs

2025-06-26 Thread Zaiyu Wang
Add RX desc merge mode for Amber-Lite NICs. When enabled, the hardware batch-processes RX packets, significantly enhancing performance. This feature is enabled by default in the driver and can be configured via the rx_desc_merge parameter in devargs. Signed-off-by: Zaiyu Wang --- drivers/net/txg

[PATCH v3 09/15] net/txgbe: add TX head Write-Back mode for Amber-Lite NICs

2025-06-26 Thread Zaiyu Wang
Add TX head Write-Back mode for Amber-Lite NICs. When enabled, the hardware no longer individually rewrites descriptors but intermittently notifies the driver of processed descriptor indices. This feature significantly improves performance and is enabled by default in the driver. Users can configur

  1   2   >