[PATCH v4 3/3] app/testpmd: fix obtain inner info of tunnel packet

2025-05-22 Thread Dengdui Huang
l2_len for tunneling packets should contain Outer_L4_len. Additionally, the current offset used for the inner Ethernet header is incorrect. This patch fixes these issues. Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- app/te

[PATCH v4 1/3] net: fix GTP packet parsing

2025-05-22 Thread Dengdui Huang
After parsing the GTP packet header, the next protocol type should be converted from RTE_GTP_TYPE_IPV4/IPV6 to RTE_ETHER_TYPE_IPV4/IPV6. Otherwise, the next protocol cannot be parsed. Bugzilla ID: 1672 Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing") Cc: sta...@dpdk.org Signed-off-by:

[PATCH v4 2/3] net: fix parse the tunnel length of tunnel packet with UDP

2025-05-22 Thread Dengdui Huang
Currently, the tunnel length info is not available when get the tunnel packet type with UDP port. This patch adds the parsing of the tunnel length info. Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- lib/net/rte_net.c | 4 1

Re: [PATCH v2 1/2] net: fix offset calculation for GENEVE packet

2025-05-22 Thread huangdengdui
Acked-by: Dengdui Huang On 2025/5/21 13:11, sk...@marvell.com wrote: > From: Sunil Kumar Kori > > While parsing packet headers, offset must be added to get next > header but for geneve header parsing offset is overwritten. > Also inner_l2_len is not set in case of geneve packets. > > Fixes: 64

[PATCH] rcu: add deprecation notice about limit on defer queue element size

2025-05-22 Thread Andre Muezerie
The functions rte_rcu_qsbr_dq_create and rte_rcu_qsbr_dq_reclaim establish no limit on the size of each element in the defer queue. With DPDK 25.11 a hard limit will be set (``RTE_QSBR_ESIZE_MAX``). This will allow fixed C arrays to be used in the functions' implementations, avoiding VLAs and use o

RE: [PATCH v1 3/4] ring: fix potential sync issue between head and tail values

2025-05-22 Thread Wathsala Wathawana Vithanage
Hi Konstanin, In rte_ring the store-release on tail update guarantees that CAS won't get reordered with the store-released of the tail update. So, the sequence of events would look like this (combined view of head and tail update) Releaxed-load(new_head, N)

[DPDK/core Bug 1711] Warnings from unaligned access on 32 bit build

2025-05-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1711 Bug ID: 1711 Summary: Warnings from unaligned access on 32 bit build Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor

Re: [RFC v2 6/6] dts: add performance test functions to test suite api

2025-05-22 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [RFC v2 5/6] dts: add trex traffic generator to dts framework

2025-05-22 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-22 Thread Stephen Hemminger
On Thu, 22 May 2025 08:15:14 +0530 farooq basha wrote: > Thanks Stephen for addressing my queries , and it is helpful. > > One more follow up question on the same , Can DPDK HQOS be customized > based on Use case ? > > For example: Hqos config for one of the use cases , *One Port , O

[PATCH v2] fix eal/linux: unregister alarm callback before free

2025-05-22 Thread Rui Ferreira
This was flagged by Address sanitizer as a use after free. The intr_handle ptr is shared between the main thread and the interrupt thread. The interrupt thread can dereference the ptr after free (from the alarm callback). free is called when the main thread cleans up. The interrupt thread never te

Re: [RFC v2 4/6] dts: add extended timeout option to interactive shells.

2025-05-22 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [RFC v2 3/6] dts: add asynchronous support to ssh sessions.

2025-05-22 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v2 1/7] net/ena/base: avoid recalculating desc per entry

2025-05-22 Thread Shai Brandes
desc_per_entry is precomputed in ena_com_config_llq_info() using desc_stride_ctrl and desc_list_entry_size, which remain unchanged after device negotiation. Reuse the existing value instead of recalculating it in the fast path. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by:

Re: eal patches with other licenses

2025-05-22 Thread Andre Muezerie
On Thu, May 22, 2025 at 10:29:46AM +0200, Morten Brørup wrote: > Andre, > > Please try asking the respective original authors of getline() and asprintf() > if they are willing to license these functions to the DPDK project under the > BSD-3-Clause license. Or perhaps generally offer dual-license

[PATCH v3 1/7] net/ena/base: avoid recalculating desc per entry

2025-05-22 Thread Shai Brandes
desc_per_entry is precomputed in ena_com_config_llq_info() using desc_stride_ctrl and desc_list_entry_size, which remain unchanged after device negotiation. Reuse the existing value instead of recalculating it in the fast path. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by:

Re: Addressing git.dpdk.org downtime

2025-05-22 Thread Ali Alnubani
On 5/22/25 11:36 AM, Ali Alnubani wrote: Hello everyone, We’re aware that https://git.dpdk.org has been experiencing availability issues lately, largely due to abusive bots and crawlers overloading the servers and ignoring traditional controls like robots.txt. To address this, we're preparing

[PATCH v3 2/7] net/ena/base: coding style changes

2025-05-22 Thread Shai Brandes
Reordered variable declarations to follow the reverse Christmas tree style. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/base/ena_com.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_c

[PATCH v3 6/7] net/ena: fix aenq timeout with low poll interval

2025-05-22 Thread Shai Brandes
The driver can work in polling-based functionality of the admin queue, eliminating the need for interrupts in the control-path. This mode is mandatory when using the uio_pci_generic driver, which lacks interrupt support. The control_path_poll_interval devarg is being set within the range [1..1000]

[PATCH v2 2/7] net/ena/base: coding style changes

2025-05-22 Thread Shai Brandes
Reordered variable declarations to follow the reverse Christmas tree style. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/base/ena_com.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_c

[PATCH v3 4/7] net/ena: support fragment bypass mode

2025-05-22 Thread Shai Brandes
Introduce devarg `enable_frag_bypass` to toggle the fragment bypass mode for egress packets. When enabled, this feature bypasses the PPS limit enforced by EC2 for fragmented egress packets on every ENI. Note that enabling this might negatively impact network performance. By default, this feature

[PATCH v3 7/7] net/ena: upgrade driver version to 2.13.0

2025-05-22 Thread Shai Brandes
Upgraded the driver version to 2.13.0. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 182e0

[PATCH v3 5/7] net/ena: fix unhandled interrupt config failure

2025-05-22 Thread Shai Brandes
Fixed the device initialization routine to correctly handle failure during the registration or enabling of interrupts when operating in control path interrupt mode. Fixes: ca1dfa85f0d3 ("net/ena: add control path pure polling mode") Cc: sta...@dpdk.org Signed-off-by: Shai Brandes Reviewed-by: Ami

[PATCH v3 3/7] net/ena: separate doorbell logic for Rx and Tx

2025-05-22 Thread Shai Brandes
The function ena_com_write_sq_doorbell() currently checks for LLQ mode using is_llq_max_tx_burst_exists() which is relevant only for TX queues. Since RX queues do not operate in LLQ mode, this check is unnecessary for the RX path. This patch separates the doorbell write logic into two distinct han

[PATCH v3 0/7] net/ena: release 2.13.0

2025-05-22 Thread Shai Brandes
This patchset includes an upgrade of the ENA HAL, introduces a new feature, and addresses three bug fixes. Thank you in advance to the net maintainers and community members for your time and effort reviewing the code. Best regards, Shai Brandes AWS Elastic Network Adapter team --- v2: Removed pa

[PATCH v2 4/7] net/ena: support fragment bypass mode

2025-05-22 Thread Shai Brandes
Introduce devarg `enable_frag_bypass` to toggle the fragment bypass mode for egress packets. When enabled, this feature bypasses the PPS limit enforced by EC2 for fragmented egress packets on every ENI. Note that enabling this might negatively impact network performance. By default, this feature

[PATCH v2 7/7] net/ena: upgrade driver version to 2.13.0

2025-05-22 Thread Shai Brandes
Upgraded the driver version to 2.13.0. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 182e0

[PATCH v2 6/7] net/ena: fix aenq timeout with low poll interval

2025-05-22 Thread Shai Brandes
The driver can work in polling-based functionality of the admin queue, eliminating the need for interrupts in the control-path. This mode is mandatory when using the uio_pci_generic driver, which lacks interrupt support. The control_path_poll_interval devarg is being set within the range [1..1000]

[PATCH v2 5/7] net/ena: fix unhandled interrupt config failure

2025-05-22 Thread Shai Brandes
Fixed the device initialization routine to correctly handle failure during the registration or enabling of interrupts when operating in control path interrupt mode. Fixes: ca1dfa85f0d3 ("net/ena: add control path pure polling mode") Cc: sta...@dpdk.org Signed-off-by: Shai Brandes Reviewed-by: Ami

[PATCH v2 4/7] net/ena: support fragment bypass mode

2025-05-22 Thread Shai Brandes
Introduce devarg `enable_frag_bypass` to toggle the fragment bypass mode for egress packets. When enabled, this feature bypasses the PPS limit enforced by EC2 for fragmented egress packets on every ENI. Note that enabling this might negatively impact network performance. By default, this feature

[PATCH v2 3/7] net/ena: separate doorbell logic for Rx and Tx

2025-05-22 Thread Shai Brandes
The function ena_com_write_sq_doorbell() currently checks for LLQ mode using is_llq_max_tx_burst_exists() which is relevant only for TX queues. Since RX queues do not operate in LLQ mode, this check is unnecessary for the RX path. This patch separates the doorbell write logic into two distinct han

[PATCH v2 0/7] net/ena: release 2.13.0

2025-05-22 Thread Shai Brandes
This patchset includes an upgrade of the ENA HAL, introduces a new feature, and addresses three bug fixes. Thank you in advance to the net maintainers and community members for your time and effort reviewing the code. Best regards, Shai Brandes AWS Elastic Network Adapter team --- v2: Removed pa

Re: Addressing git.dpdk.org downtime

2025-05-22 Thread David Marchand
On Thu, May 22, 2025 at 11:06 AM Bruce Richardson wrote: > > On Thu, May 22, 2025 at 08:36:28AM +, Ali Alnubani wrote: > > Hello everyone, > > > > We’re aware that https://git.dpdk.org has been experiencing availability > > issues lately, largely due to abusive bots and crawlers overloading th

Re: [PATCH 1/2] ci: bump tested distributions in GHA

2025-05-22 Thread David Marchand
Hello Luca, Xueming, On Wed, Jan 31, 2024 at 6:44 PM David Marchand wrote: > > Fedora 37 has reached end of life in December 2023. > Ubuntu 20.04 is getting quite old. > > Switch to more recent versions. > > With this move, some packages provided by those distributions are now > recent enough to

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-22 Thread Akhil Goyal
> Hi, Akhil > > On Wed, 21 May 2025 at 20:39, Akhil Goyal wrote: > > > > > Realize async mode to replace sync mode for better performance > > > > > > Zhangfei Gao (2): > > > compress/uadk: use async mode to replace sync mode > > > crypto/uadk: use async mode to replace sync mode > > > > > >

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-22 Thread farooq basha
Thanks Stephen for addressing my queries , and it is helpful. One more follow up question on the same , Can DPDK HQOS be customized based on Use case ? For example: Hqos config for one of the use cases , *One Port , One Subport , 16 Pipes & Each Pipe with only one TC*.

Re: [RFC PATCH 3/7] argparse: make argparse EAL-args compatible

2025-05-22 Thread Bruce Richardson
On Tue, May 20, 2025 at 05:40:20PM +0100, Bruce Richardson wrote: > The argparse library was missing two key features which made it > unsuitable for use by EAL or any program wanting similar behaviour. > > 1. It didn't stop parsing arguments when it hit a "--" character > 2. It never returned the

[dpdk-dev] [PATCH ] common/cnxk: fix E-tag pattern parsing

2025-05-22 Thread psatheesh
From: Satheesh Paul E-tag pattern parsing was using wrong length leading to a segfault. Fixing this by using the correct length of the pattern item. Fixes: c34ea71b878d ("common/cnxk: add NPC parsing API") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- driver

RE: [EXTERNAL] [dpdk-dev] [PATCH ] net/cnxk: support ESP based RSS hashing

2025-05-22 Thread Jerin Jacob
> -Original Message- > From: psathe...@marvell.com > Sent: Wednesday, April 2, 2025 1:55 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Harman Kalra > Cc: dev@dpdk.org; Satheesh Paul Antonysamy > Subject: [EXTERNAL]

Re: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-22 Thread Zhangfei Gao
Hi, Akhil On Wed, 21 May 2025 at 20:39, Akhil Goyal wrote: > > > Realize async mode to replace sync mode for better performance > > > > Zhangfei Gao (2): > > compress/uadk: use async mode to replace sync mode > > crypto/uadk: use async mode to replace sync mode > > > > drivers/compress/uadk/

Re: [PATCH] net/ice: fix support for 3 scheduler levels

2025-05-22 Thread Bruce Richardson
On Wed, May 21, 2025 at 11:52:21AM +0100, Loftus, Ciara wrote: > > > > When using only 3 scheduler levels, the VSI node needs to be a node > > further down the scheduler hierarchy, rather than one up it as with all > > other possible level settings (5-9). Take account of this possibility in > > th

Re: [PATCH v4] event/dlb2: consolidate AVX512 and SSE changes

2025-05-22 Thread Bruce Richardson
On Tue, Apr 08, 2025 at 08:00:48AM -0500, Tirthendu Sarkar wrote: > Streamline code for AVX512 and SSE by consolidating the common code and > adding runtime check for selecting appropriate path based on CPU > capability. > > Signed-off-by: Tirthendu Sarkar > > --- > v4: > - Modify some AVX512 i

[PATCH v6 2/9] crypto/zsda: add device operations

2025-05-22 Thread Hanxiao Li
Add crypto device operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 82 +-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_crypto_pmd.c index

[PATCH v6 8/9] crypto/zsda: add capabilities

2025-05-22 Thread Hanxiao Li
Add crypto capabilities scope for zsda device. Signed-off-by: Hanxiao Li --- doc/guides/cryptodevs/features/zsda.ini | 51 doc/guides/cryptodevs/zsda.rst| 26 doc/guides/rel_notes/release_25_07.rst| 8 ++ .../crypto/zsda/zsda_crypto_capabilities.h

[PATCH v6 4/9] crypto/zsda: add queue pair configuration

2025-05-22 Thread Hanxiao Li
Add crypto queue pair configuration operations for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_c

[PATCH v6 6/9] crypto/zsda: add enqueue datapath

2025-05-22 Thread Hanxiao Li
Add crypto enqueue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_crypto.c | 256 ++ drivers/crypto/zsda/zsda_crypto.h | 45 + drivers/crypto/zsda/zsda_crypto_pmd.

[PATCH v6 5/9] crypto/zsda: add session configuration

2025-05-22 Thread Hanxiao Li
Add crypto session configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_crypto_pmd.c | 45 +- drivers/crypto/zsda/zsda_crypto_session.c | 498 ++ drivers/crypto/zsda/zsda_crypto_session.

[PATCH v6 9/9] app/test: add zsda cryptodev test

2025-05-22 Thread Hanxiao Li
Add crypto test for zsda device and driver. Signed-off-by: Hanxiao Li --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + doc/guides/cryptodevs/zsda.rst | 6 ++ 3 files changed, 14 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

[PATCH v6 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-22 Thread Hanxiao Li
v6: - Modify the code according to the advise v5: - Modify the code according to the advise v4: - change some "sym" to "crypto". v3: - Modify the code according to the advise v2: - Modify the errors about cryptodevs/zsda.rst. - Modify the errors about author. v1: - Add zsda cryptodev driver.

[PATCH v6 3/9] crypto/zsda: add statistics

2025-05-22 Thread Hanxiao Li
Add crypto statistics operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_crypto_pmd.c inde

[PATCH v6 1/9] crypto/zsda: add skeleton

2025-05-22 Thread Hanxiao Li
Add crypto driver skeleton for zsda devices. Signed-off-by: Hanxiao Li --- MAINTAINERS | 6 ++ doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryptodevs/zsda.rst| 26 ++ drivers/common/zsda/meson.build | 12 ++- drivers/common/zsda/zsda_

[PATCH v6 7/9] crypto/zsda: add dequeue datapath

2025-05-22 Thread Hanxiao Li
Add crypto dequeue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto.c | 16 drivers/crypto/zsda/zsda_crypto.h | 2 ++ drivers/crypto/zsda/zsda_crypto_pmd.c | 12 ++-- 3 files changed, 28 insertions(+), 2 delet

Re: Addressing git.dpdk.org downtime

2025-05-22 Thread Bruce Richardson
On Thu, May 22, 2025 at 08:36:28AM +, Ali Alnubani wrote: > Hello everyone, > > We’re aware that https://git.dpdk.org has been experiencing availability > issues lately, largely due to abusive bots and crawlers overloading the > servers and ignoring traditional controls like robots.txt. > >

Re: [PATCH] net/mlx5: align PF and VF/SF MAC addresses handling

2025-05-22 Thread Raslan Darawsheh
Hi, On 16/05/2025 10:10 AM, Gavin Li wrote: In the mlx5_dev_spawn function, the Virtual Function (VF) synchronizes MAC addresses from the kernel using netlink. It queries the netdev-configured MACs and populates the list in the PMD device data, including multicast MAC addresses. These addresses

Addressing git.dpdk.org downtime

2025-05-22 Thread Ali Alnubani
Hello everyone, We’re aware that https://git.dpdk.org has been experiencing availability issues lately, largely due to abusive bots and crawlers overloading the servers and ignoring traditional controls like robots.txt. To address this, we're preparing to deploy Anubis, a traffic-challenging to

eal patches with other licenses

2025-05-22 Thread Morten Brørup
Andre, Please try asking the respective original authors of getline() and asprintf() if they are willing to license these functions to the DPDK project under the BSD-3-Clause license. Or perhaps generally offer dual-license with BSD-3-Clause as an alternative to their original license. -Morten

RE: [EXTERNAL] Re: [v5,1/9] crypto/zsda: add skeleton

2025-05-22 Thread Akhil Goyal
> Hi akhil: > > There is a critical warning, maybe can called error, that the patches can't be > applied. > > Because I formatted some files in patch "[v1] compress/zsda: code formatting", > whose link is > https://patches.dpdk.org/project/dpdk/patch/20250522062351.2266776-1- > li.hanx...@zte.com

Re: [v5,1/9] crypto/zsda: add skeleton

2025-05-22 Thread Hanxiao Li
Hi akhil: There is a critical warning, maybe can called error, that the patches can't be applied. Because I formatted some files in patch "[v1] compress/zsda: code formatting", whose link is https://patches.dpdk.org/project/dpdk/patch/20250522062351.2266776-1-li.hanx...@zte.com.cn/ The crypto

[PATCH v3] ethdev: fix the bug where the flag variables are assigned

2025-05-22 Thread Sunyang Wu
Set the values of the promiscuous and all_multicast variables according to the return value. Fixes: af75078fece3 ("first public release") Fixes: de5ccf0775ae ("ethdev: do nothing if all-multicast mode is applied again") Cc: sta...@dpdk.org Signed-off-by: Morten Brørup Signed-off-by: Sunyang Wu