回复: [PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-07 Thread Sunyang Wu
Thank you for your reply. Personally, I think that when disabling promiscuous/all-multicast mode, the corresponding flag should be set based on the return value. This is because, at the driver implementation level, the driver may check the flag to determine whether the corresponding disable ope

Re: [PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-07 Thread Stephen Hemminger
Why bother? This is not critical path. Original code looked fine On Thu, May 8, 2025, 11:34 Sunyang Wu wrote: > Set the values of the promiscuous and all_multicast variables > according to the return value. > > Signed-off-by: Sunyang Wu > --- > lib/ethdev/rte_ethdev.c | 9 +++-- > 1 file c

[PATCH] eal: warn if no lcore is available

2025-05-07 Thread David Marchand
On systems with more cpu than RTE_MAX_LCORE, starting DPDK with cores >= RTE_MAX_LCORE ends up with an ambiguous error log. Example with RTE_MAX_LCORE=8: $ taskset -c 8 ./build/app/dpdk-testpmd EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Invalid 'command line' arguments. EAL: Erro

[PATCH] build: fix disabling developer mode

2025-05-07 Thread David Marchand
A recent change broke disabling developer mode: $ meson setup plop -Ddeveloper_mode=disabled ... drivers/meson.build:150:14: ERROR: Unknown variable "fs". Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers") Signed-off-by: David Marchand --- meson.build | 3 ++- 1 file ch

[PATCH] app/test-flow-perf: support testing the flow tables query rate

2025-05-07 Thread Sunyang Wu
Support testing the flow tables query rate. Signed-off-by: Sunyang Wu --- :: [Latency | query] All Cores :: Port 0 :: Total query rate -> 951.138132 K Rules/Sec :: [Latency | query] All Cores :: Port 0 :: The time for query 1 rules is 0.010514 seconds :: [Throughput | query] All Cores :: Por

[PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-07 Thread Sunyang Wu
Set the values of the promiscuous and all_multicast variables according to the return value. Signed-off-by: Sunyang Wu --- lib/ethdev/rte_ethdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index d4197322a0..b1f5

Re: [PATCH] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-05-07 Thread huangdengdui
Tested-by: Dengdui Huang The issue addressed by this patch is the same as the one fixed by the patch [1] pushed by Haijie. However, this patch is better, and I have already tested it on the Kunpeng platform. Please make the changes based on Konstantin's review comments and push the next versio

Re: [PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-07 Thread Jake Freeland
On Wed May 7, 2025 at 3:52 AM CDT, Stephen Hemminger wrote: > Please don't split message a across multiple lines. > Open and access are not the same in all security checks, so not a great > idea. What do you mean by this? In this case, access() is just verifying that we can read and write to the h

Re: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 12:35 PM, Konstantin Ananyev wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Th

RE: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Konstantin Ananyev
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 7, 2025 12:07 PM > To: Konstantin Ananyev ; dev@dpdk.org > Subject: Re: [PATCH v4 1/2] cmdline: add floating point support > > On 5/7/2025 12:35 PM, Konstantin Ananyev wrote: > > > > > >> Add support for parsing floati

[PATCH v5 2/3] cmdline: add floating point support

2025-05-07 Thread Anatoly Burakov
Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. Use C library for parsing. Signed-off-by: Anatoly Burakov --- Notes: v4 -> v5: - Reworked to use standard C library functions as much as possible, keeping near-100% c

Re: [PATCH v3 1/1] buildtools: avoid break due to failure to cleanup temporary directory

2025-05-07 Thread Dmitry Kozlyuk
Acked-by: Dmitry Kozlyuk

[PATCH v5 3/3] app/testpmd: add sleep command

2025-05-07 Thread Anatoly Burakov
Test-pmd already has a way to run a list of commands from file, but there is no way to pause execution for a specified amount of time between two commands. This may be necessary for simple automation, particularly for waiting on some asynchronous operation such as link status update. Add a simple

Re: [PATCH v2 2/2] crypto/ipsec_mb: fix QP release in secondary

2025-05-07 Thread Ji, Kai
Hi Yangming, PID check is implemented here: https://github.com/DPDK/dpdk/blob/75f179ebe347b6098cf3af26d3d3b7168fe3fe24/drivers/crypto/ipsec_mb/ipsec_mb_ops.c#L376 Can you share the steps to re-produce the error ? Regards Kai From: Yang Ming Sent: Thursday, Apri

[PATCH v5 1/3] cmdline: use C standard library as number parser

2025-05-07 Thread Anatoly Burakov
Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into account a few quirks: - We do not consider "negative" numbers to be valid for anything other than base-10 numbers, whereas C standard library d

[PATCH v3 1/1] buildtools: avoid break due to failure to cleanup temporary directory

2025-05-07 Thread Andre Muezerie
When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). This issue was not seen on operating systems other than Windows. This patch eliminates the use of tempfile.TemporaryDirectory, which was triggering

[PATCH v3 0/1] avoid break due to failure to cleanup temporary directory

2025-05-07 Thread Andre Muezerie
When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). This issue was not seen on operating systems other than Windows. This patch eliminates the use of tempfile.TemporaryDirectory, which was triggering

Re: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 2:24 PM, Konstantin Ananyev wrote: -Original Message- From: Burakov, Anatoly Sent: Wednesday, May 7, 2025 12:07 PM To: Konstantin Ananyev ; dev@dpdk.org Subject: Re: [PATCH v4 1/2] cmdline: add floating point support On 5/7/2025 12:35 PM, Konstantin Ananyev wrote: Add

Re: [dpdk-dev v1] app/test-crypto-perf: remove decrypt test case from perf

2025-05-07 Thread Radu Nicolau
On 02-May-25 11:12 AM, Kai Ji wrote: Remove all decrypt test cases in aesni-mb throughput perf as the decrypt throughput testing only support OOP by dpdk-test-crypto-perf Signed-off-by: Kai Ji --- Acked-by: Radu Nicolau

RE: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Konstantin Ananyev
> Add support for parsing floating point numbers in cmdline library, as well > as unit tests for the new functionality. The parser supports single and > double precision floats, and will understand decimal fractions as well as > scientific notation. There are standard functions for that: strtod

Re: [PATCH] crypto/qat: disable ZUC 256 on selected devices

2025-05-07 Thread Ji, Kai
Acked-by: Kai Ji From: Nicolau, Radu Sent: 23 April 2025 11:50 To: Ji, Kai Cc: dev@dpdk.org ; Nicolau, Radu Subject: [PATCH] crypto/qat: disable ZUC 256 on selected devices Disable ZUC 256 cipher on selected devices. Signed-off-by: Radu Nicolau --- drivers/

[PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Anatoly Burakov
Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Signed-off-by: Anatoly Burakov --- Notes: v3 -> v4

[PATCH v4 2/2] app/testpmd: add sleep command

2025-05-07 Thread Anatoly Burakov
Test-pmd already has a way to run a list of commands from file, but there is no way to pause execution for a specified amount of time between two commands. This may be necessary for simple automation, particularly for waiting on some asynchronous operation such as link status update. Add a simple

Re: [PATCH v3 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 11:50 AM, Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Signed-of

[PATCH v3 2/2] app/testpmd: add sleep command

2025-05-07 Thread Anatoly Burakov
Test-pmd already has a way to run a list of commands from file, but there is no way to pause execution for a specified amount of time between two commands. This may be necessary for simple automation, particularly for waiting on some asynchronous operation such as link status update. Add a simple

[PATCH v3 1/2] cmdline: add floating point support

2025-05-07 Thread Anatoly Burakov
Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Signed-off-by: Anatoly Burakov --- app/test/test_cmdli

Re: [PATCH v2 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/6/2025 3:38 PM, Bruce Richardson wrote: On Tue, May 06, 2025 at 02:08:18PM +0100, Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will under

Re: [PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-07 Thread Stephen Hemminger
Please don't split message a across multiple lines. Open and access are not the same in all security checks, so not a great idea. Some analyzer tools may flag as time of check, time of use issue. On Wed, May 7, 2025, 02:50 Jake Freeland wrote: > Currently, hugepage mountpoints will be used irres

RE: [PATCH] net/intel: fix igb tx queue offloads capability

2025-05-07 Thread Deng, KaiwenX
> -Original Message- > From: Richardson, Bruce > Sent: Monday, April 28, 2025 11:21 PM > To: Deng, KaiwenX > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > Yaroslav Brustinov > Subject: Re: [PATCH] net/intel: fix igb tx queue offloads capability > > On Mon, Apr 14, 2025 at 04:53: