Re: |FAILURE| pw153190 [PATCH V3] Add new tracepoint function for type time_t

On 5/5/25 21:56, David Marchand wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, On Wed, Apr 30, 2025 at 7:21 AM Changqing Li wrote: I'm new to this project, and

Tech Board Meeting Minutes - 2025-Apr-30

TB Members Attending - Aaron Conole Bruce Richardson Honnappa Nagarahalli (chair) Jerin Jacob Kevin Traynor Konstantin Ananyev Maxime Coquelin Morten Brørup Stephen Hemminger NOTE: The technical board meetings are on every second Wednesday at 3pm UTC. Meetings are public, and

Re: [PATCH v2 1/1] buildtools: avoid break due to failure to cleanup temporary directory

On 07.05.2025 01:14, Andre Muezerie wrote: When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was only seen on

[PATCH v2 1/1] buildtools: avoid break due to failure to cleanup temporary directory

When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was only seen on Windows. Adding a 1 second sleep before clean

[PATCH v2 0/1] avoid break due to failure to cleanup temporary directory

When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was only seen on Windows. The proposed fix adds a mitigation

Re: [PATCH 1/1] buildtools: avoid break due to failure to cleanup temporary directory

On Tue, May 06, 2025 at 01:47:03AM +0300, Dmitry Kozlyuk wrote: > Hi Andre, > > On 05.05.2025 22:46, Andre Muezerie wrote: > >When compiling drivers on Windows, instances have been seen where a > >temporary directory fails to get cleaned up due to > >ERROR_SHARING_VIOLATION (32). > > > >Code inspe

Re: Polling for patchseries in DPDK - the /series/ and /events/ endpoints

Thanks for the clarification regarding the datetimes. Yes let's clear up any remaining questions offline at Prague. :)

[PATCH] net/ice: Localize dynamic mbuf timestamp data

The ice_timestamp_dynfield_offset and ice_timestamp_dynflag global variables are used to access the dynamic mbuf timestamp field when timestamp offloading is enabled. Move these into the ice_rx_queue structure, located in shared rte_eth_dev_data, so they can be accessed by secondary processes. Si

[PATCH 3/3] eal/linux: Check hugepage access permissions

Currently, hugepage mountpoints will be used irrespective of permissions, leading to potential EACCES errors during memory allocation. Fix this by not using a mountpoint if we do not have read/write permissions on it. Signed-off-by: Jake Freeland --- lib/eal/linux/eal_hugepage_info.c | 6 ++

[PATCH 2/3] eal/freebsd: Do not index out of bounds in memseg list

It is possible for rte_fbarray_find_next_n_free() to misreport that there are n contiguous open spots. If we need two contiguous entries for a hole, make sure that we're not indexing out-of-bounds in the fbarray. The `arr->len - arr->count < n` condition in fbarray_find_n() is meant to safeguard a

[PATCH 0/3] EAL memory fixes

Hi there, This patchset contains a number of EAL-specific memory fixes that I've made over the last year. Two pertain to FreeBSD, one pertains to Linux. Let me know if you have any feedback. Thanks. Jake Freeland (3): eal/freebsd: Do not use prev_ms_idx for hole detection eal/freebsd: Do not

[PATCH 1/3] eal/freebsd: Do not use prev_ms_idx for hole detection

Use rte_fbarray_is_used() to check if the previous fbarray entry is already empty. Using prev_ms_idx to do this is flawed in cases where we loop through multiple memseg lists. Each memseg list has its own count and length, so using a prev_ms_idx from one memseg list to check for used entries in an

[PATCH] kernel/freebsd: Allow contigmem allocation in NUMA domains

Allow the user to specify a list of comma separated NUMA domains in `hw.contigmem.domains` to allocate memory from. All contigmem will be allocated in an interleaved fashion across the specified domains using the DOMAINSET_POLICY_INTERLEAVE policy from domainset(9). If `hw.contigmem.domains` is un

[PATCH 4/4] bus/pci/bsd: Fix device existence check

Use open(2) instead of access(2) to check for the existence of the target device. This avoids a possible race condition where the the device file is removed after a successful call to access(2) but before open(2). This also fixes any potential bugs associated with passing open(2)-style flags into

[PATCH 3/4] bus/pci/bsd: Eliminate potential overflow

When calling rte_pci_write_config(), use memcpy(3) to copy @len bytes of @buf into local memory instead of casting it to a uint32_t pointer and dereferencing it. This prevents us from reading data outside of @buf in the case that @buf has a length less than 32 bits. Signed-off-by: Jake Freeland -

[PATCH 2/4] bus/pci/bsd: Map resources at EAL baseaddr

Provide the EAL base address as a hint to mmap(2), so device resources are not mapped where malloc(3) et al. make allocations. This makes mapping conflicts less likely for secondary processes that make memory allocations before initializing EAL. Signed-off-by: Jake Freeland --- drivers/bus/pci/

[PATCH 1/4] bus/pci: Use force-noreplace flag when mapping PCI resources

When mapping PCI resources in secondary processes, use the RTE_MAP_FORCE_ADDRESS_NOREPLACE flag to indicate that the mapping must be made at the provided address. Without this flag, the kernel might return a different address for the mapping, even if the requested region was available. Signed-off

[PATCH 0/4] BSD PCI Fixes

Hi there, The following patchset includes a number of fixes I've made over the past year relating to the PCI driver. Most of these changes target the FreeBSD platform. Let me know if you have any feedback. Thanks. Jake Freeland (4): bus/pci: Use force-noreplace flag when mapping PCI resources

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

> From: Owen Hilyard > Sent: Saturday, May 03, 2025 6:13 PM > To: Van Haaren, Harry; Etelson, Gregory; Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq > > From: Van Haaren, Harry > Sent: Friday, May 2, 2025 9:58 AM > To: Etelson, Gre

Re: Polling for patchseries in DPDK - the /series/ and /events/ endpoints

Patrick Robb writes: > There was some discussion at last week's CI meeting about usage of the > Patchwork > /events/ endpoint for polling for patches, and issues with that process. Here > is a relevant > blurb, explaining some issues Aaron has run into using the dpdk-ci repo > "poll-pw.sh" she

Re: [PATCH v2 1/2] cmdline: add floating point support

On Tue, May 06, 2025 at 02:08:18PM +0100, Anatoly Burakov wrote: > Add support for parsing floating point numbers in cmdline library, as well > as unit tests for the new functionality. The parser supports single and > double precision floats, and will understand decimal fractions as well as > scien

[PATCH] net/mlx5: fix error notification for large patterns

HWS has limited resources to translate flow pattern. When pattern translation does not fit STE, HWS translation fails with E2BIG error. The patch verifies that the E2BIG error value is kept during flow error notification. Fixes: e38776c36c8a ("net/mlx5: introduce HWS for non-template flow API") S

[PATCH] net/mlx5: fix transceiver warning when not exist

In case no transceiver exist when trying to get the transceiver's info There should not be an error message from the library. The caller may print an appropriate error message using the relevant rte_errno if required. Bugzilla ID: 1690 Signed-off-by: yogev --- drivers/net/mlx5/linux/mlx5_ethde

[PATCH v2 3/3] dts: add packet capture test suite

From: Thomas Wilks Add a test suite that tests the packet capture framework through the use of dpdk-dumpcap. Signed-off-by: Thomas Wilks Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../dts/tests.TestSuite_packet_capture.rst| 8 + dts/tests/TestSuite_packet_capture.py

[PATCH v2 2/3] dts: add facility to change file permissions

Add an abstraction to handle file permissions for the remote. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/testbed_model/os_session.py| 34 dts/framework/testbed_model/posix_session.py | 11 ++- 2 files changed, 44 insertions(+), 1 del

[PATCH v2 1/3] dts: import lldp package in scapy

From: Thomas Wilks Add import for lldp scapy package to enable lldp packet creation and handling. Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek Reviewed-by: Dean Marx --- dts/framework/testbed_model/traffic_generator/scapy.py | 1 + 1 file changed, 1 insertion(+) diff --git a/dts

[PATCH v2 0/3] dts: add packet capture test suite

Hi there, sending in a v2 for the packet capture test suite. v2: - added a new command to change file permissions on remote - changed test suite to use dpdk-dumpcap instead of dpdk-pdump Best regards, Luca Luca Vizzarro (1): dts: add facility to change file permissions Thomas Wilks (2): dt

[PATCH v1 13/13] net/intel: add common Tx mbuf recycle

Currently, there are duplicate implementations of Tx mbuf recycle in some drivers, specifically ixgbe and i40e. Move them into a common header. Signed-off-by: Anatoly Burakov --- drivers/net/intel/common/recycle_mbufs.h | 98 +++ drivers/net/intel/common/tx.h

[PATCH v1 12/13] net/intel: add common Rx mbuf recycle

Currently, there are duplicate implementations of Rx mbuf recycle in some drivers, specifically ixgbe and i40e. Move them into a common header. While we're at it, also support no-IOVA-in-mbuf case. Signed-off-by: Anatoly Burakov --- drivers/net/intel/common/recycle_mbufs.h | 67 +++

[PATCH v1 10/13] net/ixgbe: use common Rx rearm code

The ixgbe driver has implementations of vectorized mbuf rearm code that is identical to the ones in the common code, so just use those. Signed-off-by: Anatoly Burakov --- drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +- drivers/net/intel/ixgbe/ixgbe_rxtx_vec_neon.c | 66 +--- d

[PATCH v1 11/13] net/intel: support wider x86 vectors for Rx rearm

Currently, for 32-byte descriptor format, only SSE instruction set is supported. Add implementation for AVX2 and AVX512 instruction sets. This implementation similarly constant-propagates everything at compile time and thus should not affect performance of existing code paths. To improve code reada

[PATCH v1 09/13] net/iavf: use common Rx rearm code

The iavf driver has implementations of vectorized mbuf rearm code that is identical to the ones in the common code, so just use those. Signed-off-by: Anatoly Burakov --- drivers/net/intel/iavf/iavf_rxtx.h| 4 +- drivers/net/intel/iavf/iavf_rxtx_vec_avx2.c | 3 +- drivers/net/in

[PATCH v1 08/13] net/i40e: use common Rx rearm code

The i40e driver has an implementation of vectorized mbuf rearm code that is identical to the one in the common code, so just use that. In addition, the i40e has an implementation of Rx queue rearm for Neon instruction set, so create a common header for Neon implementations too, and use that in i40

[PATCH v1 07/13] net/intel: generalize vectorized Rx rearm

There is certain amount of duplication between various drivers when it comes to Rx ring rearm. This patch takes implementation from ice driver as a base because it has support for no IOVA in mbuf as well as all vector implementations, and moves them to a common file. The driver Rx rearm code used

[PATCH v1 06/13] net/iavf: use the common Rx queue structure

Make the iavf driver use the new common Rx queue structure. Because the iavf driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_IAVF_16BYTE_RX_DESC define), the common queue structure has to take that into account, so the ring queue structure will have both, whil

[PATCH v1 05/13] net/ice: use the common Rx queue structure

Make the ice driver use the new common Rx queue structure. Because the ice driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_ICE_16BYTE_RX_DESC define), the common queue structure has to take that into account, so the ring queue structure will have both, while t

[PATCH v1 04/13] net/i40e: use the common Rx queue structure

Make the i40e driver use the new common Rx queue structure. Because the i40e driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_I40E_16BYTE_RX_DESC define), the common queue structure has to take that into account, so the ring queue structure will have both, whil

[PATCH v1 03/13] net/ixgbe: create common Rx queue structure

In preparation for deduplication effort, generalize the Rx queue structure. Most of the fields are simply moved to common/rx.h, clarifying the comments where necessary. There are some instances where the field is renamed when moving, to make it more consistent with the rest of the codebase. Speci

[PATCH v1 02/13] net/iavf: make IPsec stats dynamically allocated

Currently, the stats structure is directly embedded in the queue structure. We're about to move iavf driver to a common Rx queue structure, so we can't have driver-specific structures that aren't pointers, inside the common queue structure. To prepare, we replace direct embedding into the queue str

[PATCH v1 01/13] net/ixgbe: remove unused field in Rx queue struct

The `rdh` (read head) field in the `ixgbe_rx_queue` struct is not used anywhere in the codebase, and can be removed. Signed-off-by: Anatoly Burakov --- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 9 ++--- drivers/net/intel/ixgbe/ixgbe_rxtx.h | 1 - 2 files changed, 2 insertions(+), 8 deletions(-)

[PATCH] dts: improve port handling

Improve the way ports are handled by taking a lazy approach. Provide an interface to select the drivers by using the "dpdk" and "kernel" keywords. Centralise the handling of ports in Topology. Bind only driver to ports as needed, avoiding redundant bindings. Improve resilience by not relying on the

Re: [PATCH 00/10] centralise base code handling for drivers

On Mon, Apr 28, 2025 at 6:44 PM Bruce Richardson wrote: > > On Thu, Apr 10, 2025 at 08:37:20AM -0700, Stephen Hemminger wrote: > > On Mon, 31 Mar 2025 17:09:49 +0100 > > Bruce Richardson wrote: > > > > > Many DPDK drivers use the same pattern for base code handling, having > > > a meson.build fil

Re: [PATCH 00/10] centralise base code handling for drivers

On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson wrote: > > Many DPDK drivers use the same pattern for base code handling, having > a meson.build file in the base code directory which optionally defines > some custom cflags for the base code build, then builds the code as a > static library and ex

[PATCH v2 2/2] app/testpmd: add sleep command

Test-pmd already has a way to run a list of commands from file, but there is no way to pause execution for a specified amount of time between two commands. This may be necessary for simple automation, particularly for waiting on some asynchronous operation such as link status update. Add a simple

[PATCH v2 1/2] cmdline: add floating point support

Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Signed-off-by: Anatoly Burakov --- app/test/test_cmdli

[PATCH v2] test/crypto: increment dequeue timeout

Increment dequeue timeout to allow implementations taking longer cycles. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - no changes. only for CI. --- app/test/test_cryptodev_asym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/

Re: [PATCH v1 1/1] app/testpmd: add sleep command

On 5/2/2025 5:42 PM, Stephen Hemminger wrote: On Fri, 2 May 2025 13:27:29 +0100 Anatoly Burakov wrote: @@ -13701,6 +13735,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { &cmd_help_brief, &cmd_help_long, &cmd_quit, + &cmd_sleep, &cmd_load_from_file,

Re: [PATCH] net/ixgbe: fix port mask default value in flow director

On Fri, Apr 18, 2025 at 10:42:22AM +, Xu, HailinX wrote: > > -Original Message- > > From: Yuan Wang > > Sent: Friday, April 18, 2025 3:43 PM > > To: Burakov, Anatoly ; Medvedkin, Vladimir > > ; dev@dpdk.org > > Cc: Wang, YuanX ; sta...@dpdk.org > > Subject: [PATCH] net/ixgbe: fix port

[PATCH] net/ice: fix support for 3 scheduler levels

When using only 3 scheduler levels, the VSI node needs to be a node further down the scheduler hierarchy, rather than one up it as with all other possible level settings (5-9). Take account of this possibility in the code. Fixes: 4ace7701eb44 ("net/ice: provide parameter to limit scheduler layers"