Community CI Meeting Minutes - March 20, 2025

2025-03-27 Thread Patrick Robb
# March 20, 2025 Attendees 1. Patrick Robb 2. Paul Szczepanek 3. Luca Vizzarro 4. Cody Cheng 5. Aaron Conole 6. Matthew McGovern 7. Dean Marx # Minutes =

Re: [PATCH] event/eth_tx: prefetch mbuf headers

2025-03-27 Thread Mattias Rönnblom
On 2025-03-28 06:43, Mattias Rönnblom wrote: Prefetch mbuf headers, resulting in ~10% throughput improvement when the Ethernet RX and TX Adapters are hosted on the same core (likely ~2x in case a dedicated TX core is used). Signed-off-by: Mattias Rönnblom Tested-by: Peter Nilsson What should

[PATCH v17 17/29] net/rnp: add Rx scatter segment version

2025-03-27 Thread Wenbo Cao
add support scatter multi segment received. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 2 + drivers/net/rnp/rnp_ethdev.c | 2 + drivers/net/rnp/rnp_rxtx.c | 130 ++- drivers/net/rnp/rnp_rxtx.

[PATCH] event/eth_tx: prefetch mbuf headers

2025-03-27 Thread Mattias Rönnblom
Prefetch mbuf headers, resulting in ~10% throughput improvement when the Ethernet RX and TX Adapters are hosted on the same core (likely ~2x in case a dedicated TX core is used). Signed-off-by: Mattias Rönnblom Tested-by: Peter Nilsson --- lib/eventdev/rte_event_eth_tx_adapter.c | 20 ++

[PATCH v17 22/29] net/rnp: add supported packet types

2025-03-27 Thread Wenbo Cao
add support parse hw packet types result. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 2 ++ drivers/net/rnp/base/rnp_bdq_if.h | 4 +++ drivers/net/rnp/rnp_ethdev.c | 31 + drivers/net/rnp/rnp_rxtx.c

[PATCH v17 12/29] net/rnp: add support link update operations

2025-03-27 Thread Wenbo Cao
This patch add support poll/irq link get mode. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 2 + doc/guides/nics/rnp.rst | 3 + drivers/net/rnp/base/rnp_fw_cmd.c | 45 drivers/net/rnp/base/rnp_fw_cmd.h | 55 + drivers/net/rnp/base/rnp_hw.h | 3 +

[PATCH v17 13/29] net/rnp: add support link setup operations

2025-03-27 Thread Wenbo Cao
add set link_down/link_up implement Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 2 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/base/rnp_fw_cmd.c | 22 +++ drivers/net/rnp/base/rnp_fw_cmd.h | 6 ++ drivers/net/rnp/base/rnp_mbx_fw.c | 33 +++

[PATCH v17 10/29] net/rnp: add support device start stop operations

2025-03-27 Thread Wenbo Cao
add basic support for device to start/stop function. Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 2 + drivers/net/rnp/base/rnp_common.c | 22 +++ drivers/net/rnp/base/rnp_common.h | 1 + drivers/net/rnp/base/rnp_dma_regs.h | 10 + drivers/net/rnp/base/rnp_eth_reg

[PATCH v17 20/29] net/rnp: add support xstats operation

2025-03-27 Thread Wenbo Cao
add support mac eth rx tx hw xstats. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 3 + drivers/net/rnp/base/rnp_eth_regs.h | 4 + drivers/net/rnp/base/rnp_mac_regs.h | 80 ++ drivers/net/rnp/rnp.h | 44

[PATCH v17 29/29] net/rnp: add multicast MAC filter operation

2025-03-27 Thread Wenbo Cao
add mac filter for single/multiple port. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_crc32.c| 18 - drivers/net/rnp/base/rnp_crc32.h| 1 + drivers/net/rnp/base/rnp_eth_regs.h | 3

[PATCH v17 16/29] net/rnp: add MTU set operation

2025-03-27 Thread Wenbo Cao
add mtu update limit for multiple port mode. multiple mode just used the max-mtu of ports to limit receive. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 3 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/rnp.h

[PATCH v17 07/29] net/rnp: add support MAC promisc mode

2025-03-27 Thread Wenbo Cao
add support two method of MAC unicast promisc mulcast promisc broadcast promisc mode Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 11 +++ drivers/net/rnp/base/rnp_common.c | 5 ++ drivers/net/rnp/base/rnp_eth_regs.h | 15 ++

[PATCH v17 28/29] net/rnp: support Rx/Tx burst mode info

2025-03-27 Thread Wenbo Cao
add platform method for get rx/tx burst function select by upload func name. Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 2 ++ drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 58 drivers/net/rnp/rnp_rxtx.h | 6 4

[PATCH v17 27/29] net/rnp: add queue info operation

2025-03-27 Thread Wenbo Cao
add support get queue configure info for user debug Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 2 ++ drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 42 drivers/net/rnp/rnp_rxtx.h | 4 4 files changed, 50 inserti

[PATCH v17 25/29] net/rnp: support VLAN offloads

2025-03-27 Thread Wenbo Cao
add support rx vlan strip,filter,tx vlan/qinq insert. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 4 + drivers/net/rnp/base/rnp_bdq_if.h | 2 +- drivers/net/rnp/base/rnp_eth_regs.h | 5 + drivers/net/rnp/base/rnp_hw.h

[PATCH v17 26/29] net/rnp: add support VLAN filters operations

2025-03-27 Thread Wenbo Cao
add support to update vid for vlan filter. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 3 +- drivers/net/rnp/base/meson.build| 1 + drivers/net/rnp/base/rnp_bitrev.h | 64 drivers/net/rnp/base/rnp_crc

[PATCH v17 21/29] net/rnp: add unicast MAC filter operation

2025-03-27 Thread Wenbo Cao
add mac filter for single/multiple port. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 6 ++ drivers/net/rnp/base/rnp_eth_regs.h | 4 ++ drivers/net/rnp/base/rnp_hw.h | 3 + drivers/net/rnp/base/rnp_mac.c | 91 +++

[PATCH v17 18/29] net/rnp: add Tx multiple segment version

2025-03-27 Thread Wenbo Cao
add support multiple segs mbuf send. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 + drivers/net/rnp/rnp_rxtx.c | 126 ++- drivers/net/rnp/rnp_rxtx.h | 3 +- 3 files changed, 128 insertions(+), 3 deletions(-) diff --git a/drivers/net/rnp/

[PATCH v17 14/29] net/rnp: add Rx burst simple support

2025-03-27 Thread Wenbo Cao
add only support simple recv pkts. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 7 ++ drivers/net/rnp/rnp_rxtx.c | 130 +++ drivers/net/rnp/rnp_rxtx.h | 5 ++ 3 files changed, 142 insertions(+) diff --git a/drivers/net/rnp/rnp_ethdev.c b/dr

[PATCH v17 09/29] net/rnp: add queue stop and start operations

2025-03-27 Thread Wenbo Cao
support rx/tx queue stop/start,for rx queue stop need to reset a queue,must stop all rx queue during reset this queue. Signed-off-by: Wenbo Cao Reviewed-by: Stephen Hemminger --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 4 + drivers/net/rnp/base/rnp_commo

[PATCH v17 05/29] net/rnp: add device init and uninit

2025-03-27 Thread Wenbo Cao
add firmware communic method and basic device init, uninit and close resource function. Signed-off-by: Wenbo Cao Reviewed-by: Ferruh Yigit --- doc/guides/nics/rnp.rst | 10 + drivers/net/rnp/base/meson.build| 4 + drivers/net/rnp/base/rnp_common.c | 73 ++ drivers/net/

[PATCH v17 08/29] net/rnp: add queue setup and release operations

2025-03-27 Thread Wenbo Cao
support tx/rx queue setup and release add hw bd queue reset,sw queue reset. Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 3 + drivers/net/rnp/base/meson.build| 1 + drivers/net/rnp/base/rnp_bdq_if.c | 398 +++ drivers/net/rnp/base/rnp_bdq_if.h

[PATCH v17 06/29] net/rnp: add get device information operation

2025-03-27 Thread Wenbo Cao
add get device hardware capability function Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_fw_cmd.c | 20 ++ drivers/net/rnp/base/rnp_fw_cmd.h | 80 + drivers/net/rnp/base/rnp_m

[PATCH v17 03/29] net/rnp: add log

2025-03-27 Thread Wenbo Cao
add log function for trace or debug Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_logs.h | 36 2 files changed, 38 insertions(+) create mode 100644 drivers/net/rnp/rnp_logs.h diff --git a/drivers/net/rnp/rnp_ethdev

[PATCH v17 02/29] net/rnp: add ethdev probe and remove

2025-03-27 Thread Wenbo Cao
Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao Reviewed-by: Stephen Hemminger --- doc/guides/nics/rnp.rst | 10 ++ drivers/net/rnp/rnp.h| 16 + drivers/net/rnp/rnp_ethdev.c | 66 3 files changed, 92 insertions(+) c

[PATCH v17 00/29] [v17]drivers/net Add Support mucse N10 Pmd Driver

2025-03-27 Thread Wenbo Cao
For This patchset just to support the basic chip init work and user can just found the eth_dev, but can't control more. For Now just support 2*10g nic,the chip can support 2*10g,4*10g,4*1g,8*1g,8*10g. The Feature rx side can support rx-cksum-offload,rss,vlan-filter flow_clow,uncast_filter,mcast_fil

[PATCH v6 06/14] net/zxdh: add eram tables ops

2025-03-27 Thread Bingbin Chen
Implement the eram tables read and write operations by dtb channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 545 - drivers/net/zxdh/zxdh_np.h | 15 + 2 files changed, 558 insertions(+), 2 deletions(-) diff --git a/drivers/net/zxdh/zxdh_n

RE: [PATCH] mempool: micro optimizations

2025-03-27 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 27 March 2025 18.16 > > On Wed, Feb 26, 2025 at 03:59:22PM +, Morten Brørup wrote: > > The comparisons lcore_id < RTE_MAX_LCORE and lcore_id != LCORE_ID_ANY > are > > equivalent, but the latter compiles to fewer byt

Re: [PATCH v5 0/8] Symbol versioning and export rework

2025-03-27 Thread David Marchand
On Thu, Mar 27, 2025 at 2:37 PM David Marchand wrote: > > So far, each DPDK library (or driver) exposing symbols in an ABI had to > maintain a version.map and use some macros for symbol versioning, > specially crafted with the GNU linker in mind. > > This series proposes to rework the whole princi

Re: [PATCH v5 5/8] build: mark exported symbols

2025-03-27 Thread David Marchand
On Thu, Mar 27, 2025 at 2:50 PM David Marchand wrote: > > Annotate symbols with newly introduced export macros. > > For code not compiled via drivers/meson.build (think base drivers code), > the exported symbols are added in some new .c listed in the sources so they > get caught by drivers/meson.b

Re: [PATCH v6 00/14] net/zxdh: add network processor ops

2025-03-27 Thread Stephen Hemminger
On Fri, 21 Mar 2025 15:31:46 +0800 Bingbin Chen wrote: > v6: > - Use byte stream to process bar channel return messages > and modify some issues to ensure proper functionality. > > v5: > - the VF read/write table function is fixed. > > v4: > - change some tables to const. > - use %u

Re: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Bruce Richardson
On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote: > Caught in OBS for Fedora Rawhide on aarch64: > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > [ 198s] from ../lib/acl/acl_run_neon.c:5: > [ 198s] In function ‘alloc_completion’, > [ 198s] inl

Re: [PATCH v16 00/28] [v16]drivers/net Add Support mucse N10 Pmd Driver

2025-03-27 Thread Stephen Hemminger
On Wed, 26 Feb 2025 15:41:47 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH] mempool: micro optimizations

2025-03-27 Thread Bruce Richardson
On Wed, Feb 26, 2025 at 03:59:22PM +, Morten Brørup wrote: > The comparisons lcore_id < RTE_MAX_LCORE and lcore_id != LCORE_ID_ANY are > equivalent, but the latter compiles to fewer bytes of code space. > Similarly for lcore_id >= RTE_MAX_LCORE and lcore_id == LCORE_ID_ANY. > > The rte_mempool

Re: [PATCH] event/dlb2: consolidate AVX512 and SSE changes

2025-03-27 Thread Bruce Richardson
On Thu, Mar 27, 2025 at 04:53:27AM -0500, tirthendu.sarkar wrote: > Streamline code for AVX512 and SSE by removing separate files for them > and adding runtime checks for selecting appropriate paths based on CPU > capability. Also, update meson build file. > > Signed-off-by: Tirthendu Sarkar > --

[PATCH] doc/contributing: remove obsolete advice in coding std

2025-03-27 Thread Bruce Richardson
Remove obsolete, and generally not followed, advice in the coding standards doc, around local variables. Signed-off-by: Bruce Richardson --- doc/guides/contributing/coding_style.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/cont

Re: [PATCH v4] rust: support raw DPDK API

2025-03-27 Thread Bruce Richardson
On Sat, Mar 22, 2025 at 12:59:11PM +0200, Gregory Etelson wrote: > The patch converts include files with DPDK API to RUST and binds new > RUST API files into raw module under dpdk crate. > > The RUST files and DPDK libraries build from C sources > allow creation of DPDK application in RUST. > > R

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-27 Thread Pavan Nikhilesh Bhagavatula
> Hi Gregory, > > > Arm meson.build unconditionally relays on the `extra_features` > > member of SoC configuration. > > > > SoC dictionary is populated for Arm CPUs with generic instruction set > > only. > > For Arm CPUs with native CPU instruction set the SoC dictionary is > > empty. > > > > meso

Re: DPDK for rust

2025-03-27 Thread Bruce Richardson
On Thu, Mar 27, 2025 at 11:00:40AM +0200, Etelson, Gregory wrote: > Hello Morten, > > Thank you for raising these questions ! > > > > > Do we want the DPDK project itself to support rust? > > Or should parts of this be a DPDK hosted project, like grout? > > Rust packages management is different

[PATCH v5 2/4] net/intel: use common Tx queue structure

2025-03-27 Thread Shaiq Wani
Merge in additional fields used by the idpf driver and then convert it over to using the common Tx queue structure Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 20 +++ drivers/net/intel/cpfl/cpfl_ethdev.c | 3 +- drivers/net/intel/cpfl/cpfl_ethdev.h

Re: Driver: bnxt_en

2025-03-27 Thread Ajit Khaparde
On Thu, Mar 27, 2025 at 6:49 AM Eldho Paul Mathew wrote: > > Hi All, > > What is the importance of the 'ice' driver? > > Right now I am using 18.05.1. Does it have 'ice' driver support? > > We bought a new card: BCM57508 NetXtreme-E 10Gb/25Gb/40Gb/50Gb/100Gb/200Gb > Ethernet > > To support this c

[PATCH v5 3/8] buildtools: display version when listing symbols

2025-03-27 Thread David Marchand
Display the version when a symbol was introduced. This is needed for scripting the conversion from static to dynamically generated version maps. It is also useful when listing experimental symbols. Signed-off-by: David Marchand --- buildtools/map-list-symbol.sh | 2 +- 1 file changed, 1 insertio

[PATCH v5 1/8] lib: remove incorrect exported symbols

2025-03-27 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. eal_log_journal has no implementation and can be removed. Signed-off-by: David Marchand --- lib/eventdev/version.map | 12 lib/graph/ver

[PATCH v5 4/4] net/idpf: use common Tx free fn in idpf

2025-03-27 Thread Shaiq Wani
Switch the idpf driver to use the common Tx free function for AVX2 and AVX512 Signed-off-by: Shaiq Wani --- .../net/intel/idpf/idpf_common_rxtx_avx2.c| 68 + .../net/intel/idpf/idpf_common_rxtx_avx512.c | 237 +- 2 files changed, 22 insertions(+), 283 deletions(-) diff

[PATCH v5 3/4] net/intel: use common Tx entry structure

2025-03-27 Thread Shaiq Wani
Used the common Tx entry structure and common Tx mbuf ring replenish fn in place of idpf-specific structure and function. The vector driver code paths (AVX2, AVX512) use the smaller SW ring structure. Signed-off-by: Shaiq Wani --- drivers/net/intel/idpf/idpf_common_rxtx.c | 26 --

[PATCH v5 1/4] net/intel: align Tx queue struct field names

2025-03-27 Thread Shaiq Wani
Align the Tx queue struct field names in idpf and cpfl driver with the common Tx queue struct. Signed-off-by: Shaiq Wani --- drivers/net/intel/cpfl/cpfl_rxtx.c| 40 - drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h | 4 +- drivers/net/intel/idpf/idpf_common_rxtx.c | 72 +++

[PATCH v5 0/4] net/intel: using common functions in idpf driver

2025-03-27 Thread Shaiq Wani
reworked the drivers to use the common functions and structures from drivers/net/intel/common. Shaiq Wani (4): net/intel: align Tx queue struct field names net/intel: use common Tx queue structure net/intel: use common Tx entry structure net/idpf: use common Tx free fn in idpf drivers/ne

[PATCH v2 3/3] net/ixgbe: support MDD on VF Tx path

2025-03-27 Thread Anatoly Burakov
According to datasheet for 82599 and similar NICs, the Tx path must set CC (Check Context) bit in the descriptor in cases when Tx switching is enabled in the PF. In case of using VF functions, the fact that it is a VF function implies that Tx switching is enabled, and thus the CC bit must always be

[PATCH v2 2/3] net/ixgbe: fix VF registers for E610

2025-03-27 Thread Anatoly Burakov
When adding E610 support, some case statements for VF definitions were missing, resulting in picking incorrect registers to write to in certain cases. Fix it by adding necessary case statements for E610 VF. Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device") Cc: sta...@dpdk.org Signed-off-

[PATCH v2 1/3] net/ixgbe: use check for VF function

2025-03-27 Thread Anatoly Burakov
In a couple of places, we are using explicit mac type comparisons to trigger a VF-specific path, but we already have a function that does the same thing, so use it. Signed-off-by: Anatoly Burakov --- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 17 + 1 file changed, 5 insertions(+), 12

[PATCH v3 3/9] net/ixgbe/base: correct definition of macro

2025-03-27 Thread Bruce Richardson
The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value in place - similar to the le32_to_cpus() macro in kernel. Fixing the definition allows us to remove some warning flags, and removes the need for the uintptr_t typecasts. Fixes: aa4fc14d2cee ("ixgbe: update base driver") Cc: st

[PATCH v3 9/9] net/intel: simplify base code builds

2025-03-27 Thread Bruce Richardson
Now that base-code warning flags have been removed from a number of drivers, we can simplify their build configuration by just including the base code files in the regular list of driver files passed back. There is no need to use pre-compiled objects. Signed-off-by: Bruce Richardson --- drivers/

[PATCH v3 8/9] net/ice/base: reduce warnings for unused variables

2025-03-27 Thread Bruce Richardson
Improve base code macros to reduce the number of issues with unused variables in the code. Issues still remain with unused-but-set variables, but completely unused variable warnings are eliminated. Signed-off-by: Bruce Richardson --- drivers/net/intel/ice/base/ice_osdep.h | 6 +++--- drivers/ne

[PATCH v3 7/9] net/i40e/base: fix compiler warnings

2025-03-27 Thread Bruce Richardson
Add a single-line fix to the base code, and then the remaining two compiler warning disable flags can be removed from the driver base code build file. Fixes: 8db9e2a1b232 ("i40e: base driver") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/intel/i40e/base/i40e_diag.c | 2 +

[PATCH v3 6/9] net/i40e/base: fix unused value warnings

2025-03-27 Thread Bruce Richardson
Fix warnings about unused values - parameters, variables, etc., and remove the warning disable flags for them. Although modifying the base-code files is not ideal, the changes required are minor, and only affect two files from the imported base code. Fixes: 8db9e2a1b232 ("i40e: base driver") Cc: s

[PATCH v3 5/9] net/ixgbe/base: fix lock checker errors

2025-03-27 Thread Bruce Richardson
When building on FreeBSD, errors are reported in the base code by the lock checker (-Wthread-safety). For example: ../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex' is still held at the end of function [-Werror,-Wthread-safety-analysis] 42 | } | ^ These erro

[PATCH v3 1/9] net/fm10k/base: fix compilation warnings

2025-03-27 Thread Bruce Richardson
The fixes required to re-enable warnings in the fm10k base code are trivial, so let's make the changes and get a clean compile without any warning disable flags. * provide definitions for the UNREFERENCED_PARAMETER macros * fix the spelling of the work "fallthrough" in comments * provide a definit

[PATCH v3 4/9] net/ixgbe/base: fix compilation warnings

2025-03-27 Thread Bruce Richardson
We can remove almost all of the "unused parameter" and "unused variable" warnings by just improving the macro definitions in the osdep.h header. Remaining two instances can be fixed by just one-line additions to the code, so add those to give us a clean build with the warnings enabled. Fixes: af75

[PATCH v3 0/9] net/intel: clean up base code build

2025-03-27 Thread Bruce Richardson
Simplify the build of the various intel base code directories, by clearing compiler warnings so the files can be compiled directly along with the regular driver files. v3: add fix for lock checker issues on FreeBSD v2: added missing patch for fm10k Bruce Richardson (9): net/fm10k/base: fix comp

[PATCH v3 2/9] net/iavf/base: remove unused meson.build file

2025-03-27 Thread Bruce Richardson
The meson.build file in the base folder was never used, as the base files were just included in the main sources list for iavf. Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net") Signed-off-by: Bruce Richardson --- drivers/net/intel/iavf/base/meson.build | 10 -- 1 fil

[PATCH v1 2/3] net/ixgbe: fix VF registers for E610

2025-03-27 Thread Anatoly Burakov
When adding E610 support, some case statements for VF definitions were missing, resulting in picking incorrect registers to write to in certain cases. Fix it by adding necessary case statements for E610 VF. Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device") Cc: sta...@dpdk.org Signed-off-

[PATCH v1 3/3] net/ixgbe: support MDD on VF Tx path

2025-03-27 Thread Anatoly Burakov
According to datasheet for 82599 and similar NICs, the Tx path must set CC (Check Context) bit in the descriptor in cases when Tx switching is enabled in the PF. In case of using VF functions, the fact that it is a VF function implies that Tx switching is enabled, and thus the CC bit must always be

[PATCH v1 1/3] net/ixgbe: use check for VF function

2025-03-27 Thread Anatoly Burakov
In a couple of places, we are using explicit mac type comparisons to trigger a VF-specific path, but we already have a function that does the same thing, so use it. Signed-off-by: Anatoly Burakov --- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 17 + 1 file changed, 5 insertions(+), 12

[PATCH v5 2/8] drivers: remove incorrect exported symbols

2025-03-27 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. rte_dpaa2_dev_type is an enum token. roc_se_ctx_swap has no implementation (leftover from a previous rework) and can be removed. Signed-off-by: David M

Re: Driver: bnxt_en

2025-03-27 Thread Eldho Paul Mathew
Hi All, What is the importance of the 'ice' driver? Right now I am using 18.05.1. Does it have 'ice' driver support? We bought a new card: BCM57508 NetXtreme-E 10Gb/25Gb/40Gb/50Gb/100Gb/200Gb Ethernet To support this card using the 'ice' driver, is the DPDK 18.05.1 version sufficient, or is the

RE: Dpdk-pdump not capturing packet for vmxnet3 device

2025-03-27 Thread Rajesh Goel (rajegoel)
Thanks Stephen. I checked this module is not present in 20.11 dpdk version, but its in 23.11 But can you suggest if I need to port this back to 20.11, any necessary steps I can follow or any dependencies with the new version etc, Thanks Rajesh -Original Message- From: Stephen Hemminger

[PATCH v5 8/8] eal: rework function versioning macros

2025-03-27 Thread David Marchand
For versioning symbols: - MSVC uses pragmas on the symbol, - GNU linker uses special asm directives, To accommodate both GNU linker and MSVC linker, introduce new macros for exporting and versioning symbols that will surround the whole function. This has the advantage of hiding all the ugly detai

[PATCH v5 6/8] build: use dynamically generated version maps

2025-03-27 Thread David Marchand
Switch to dynamically generated version maps. As the map files get generated, tooling around checking, converting, updating etc.. static version maps can be removed. Signed-off-by: David Marchand --- .github/workflows/build.yml | 1 - MAINTAINERS

[PATCH v5 4/8] build: generate symbol maps

2025-03-27 Thread David Marchand
Rather than maintain a file in parallel of the code, symbols to be exported can be marked with a token RTE_EXPORT_*SYMBOL. >From those marks, the build framework generates map files only for symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack becomes unnecessary). The build fra

[PATCH v5 0/8] Symbol versioning and export rework

2025-03-27 Thread David Marchand
So far, each DPDK library (or driver) exposing symbols in an ABI had to maintain a version.map and use some macros for symbol versioning, specially crafted with the GNU linker in mind. This series proposes to rework the whole principle, and instead rely on marking the symbol exports in the source

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Konstantin Ananyev
> On Thu, Mar 27, 2025 at 12:10:12PM +, Konstantin Ananyev wrote: > > > > > > > > > > > > > > > -Original Message- > > > > > > From: David Marchand > > > > > > Sent: Thursday, March 27, 2025 10:37 AM > > > > > > To: Bruce Richardson > > > > > > Cc: dev@dpdk.org; bl...@debian.org; st

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 27 March 2025 13.10 > > > > > > > > > > From: David Marchand > > > > > Sent: Thursday, March 27, 2025 10:37 AM > > > > > > > > > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson > > > > > wrote: > > > > > > > >

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Konstantin Ananyev
> > > > > > > -Original Message- > > > > From: David Marchand > > > > Sent: Thursday, March 27, 2025 10:37 AM > > > > To: Bruce Richardson > > > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin > > Ananyev ; David Christensen > > > > ; Wathsala Vithanage > > > > > > Su

Re: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Bruce Richardson
On Thu, Mar 27, 2025 at 12:10:12PM +, Konstantin Ananyev wrote: > > > > > > > > > > > -Original Message- > > > > > From: David Marchand > > > > > Sent: Thursday, March 27, 2025 10:37 AM > > > > > To: Bruce Richardson > > > > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Kon

[DPDK/examples Bug 1684] Colt Python holster

2025-03-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1684 Bug ID: 1684 Summary: Colt Python holster Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

Re: [External] Re: [PATCH v2] eal/linux: improve ASLR check

2025-03-27 Thread Yang Ming
On 2025/3/13 23:37, Stephen Hemminger wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Thu, 13 Mar 2025 14:19:03 +0800 Yang Ming wrote: This change ensures that the current pro

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 27 March 2025 11.51 > > On Thu, Mar 27, 2025 at 10:39:09AM +, Konstantin Ananyev wrote: > > > > > > > -Original Message- > > > From: David Marchand > > > Sent: Thursday, March 27, 2025 10:37 AM > > > To: Br

[PATCH] devtools: exclude atomic checks for common cnxk

2025-03-27 Thread pbhagavatula
From: Pavan Nikhilesh Since driver/common/cnxk has common code that is used across multiple platforms, allow use of GCC builtin atomic functions. Signed-off-by: Pavan Nikhilesh --- Rest of drivers i.e., drivers/*/cnxk have been migrated to use stdatomics in: https://patchwork.dpdk.org/projec

[PATCH] cnxk: use stdatomic API

2025-03-27 Thread pbhagavatula
From: Pavan Nikhilesh Replace GCC inbuilt atomic functions with rte_atomic_xxx API. Signed-off-by: Pavan Nikhilesh --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 36 ++- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 20 +-- drivers/net/cnxk/cn10k_tx.h | 42

Re: DPDK compilers and RHEL 7 support

2025-03-27 Thread Kevin Traynor
On 27/03/2025 07:55, Morten Brørup wrote: > + Red Hat tech board members > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, 26 March 2025 20.21 >> >> On Wed, 26 Mar 2025 19:06:58 +0100 >> Morten Brørup wrote: >> From: Bruce Richardson [mailto:bruce.richard..

[PATCH v4 1/4] net/intel: align Tx queue struct field names

2025-03-27 Thread Shaiq Wani
Align the Tx queue struct field names in idpf and cpfl driver with the common Tx queue struct. Signed-off-by: Shaiq Wani --- drivers/net/intel/cpfl/cpfl_rxtx.c| 40 - drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h | 4 +- drivers/net/intel/idpf/idpf_common_rxtx.c | 72 +++

RE: [PATCH v2 1/2] eal: fix uncheck worker ID

2025-03-27 Thread Morten Brørup
> From: Dengdui Huang [mailto:huangdeng...@huawei.com] > Sent: Thursday, 27 March 2025 10.01 > > The worker_id may come from user input. > So it is necessary to verify it. > > Fixes: a95d70547c57 ("eal: factorize lcore main loop") > Cc: sta...@dpdk.org > > Signed-off-by: Dengdui Huang > --- >

Re: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Bruce Richardson
On Thu, Mar 27, 2025 at 10:39:09AM +, Konstantin Ananyev wrote: > > > > -Original Message- > > From: David Marchand > > Sent: Thursday, March 27, 2025 10:37 AM > > To: Bruce Richardson > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin Ananyev > > ; David Christens

[PATCH v4 4/4] net/idpf: use common Tx free fn in idpf

2025-03-27 Thread Shaiq Wani
Switch the idpf driver to use the common Tx free function for AVX2 and AVX512. Signed-off-by: Shaiq Wani --- .../net/intel/idpf/idpf_common_rxtx_avx2.c| 10 +- .../net/intel/idpf/idpf_common_rxtx_avx512.c | 237 +- 2 files changed, 22 insertions(+), 225 deletions(-) diff -

[PATCH v4 2/4] net/intel: use common Tx queue structure

2025-03-27 Thread Shaiq Wani
Merge in additional fields used by the idpf driver and then convert it over to using the common Tx queue structure. Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 20 +++ drivers/net/intel/cpfl/cpfl_ethdev.c | 3 +- drivers/net/intel/cpfl/cpfl_ethdev.

[PATCH v4 0/4] net/intel: using common functions in idpf driver

2025-03-27 Thread Shaiq Wani
reworked the drivers to use the common functions and structures from drivers/net/intel/common. Shaiq Wani (4): net/intel: align Tx queue struct field names net/intel: use common Tx queue structure net/intel: use common Tx entry structure net/idpf: use common Tx free fn in idpf drivers/ne

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Konstantin Ananyev
> -Original Message- > From: David Marchand > Sent: Thursday, March 27, 2025 10:37 AM > To: Bruce Richardson > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin Ananyev > ; David Christensen > ; Wathsala Vithanage > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarc

Re: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread David Marchand
On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson wrote: > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote: > > Caught in OBS for Fedora Rawhide on aarch64: > > > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > > [ 198s] from ../lib/acl/acl_run_neo

RE: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Konstantin Ananyev
> > Caught in OBS for Fedora Rawhide on aarch64: > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > [ 198s] from ../lib/acl/acl_run_neon.c:5: > [ 198s] In function ‘alloc_completion’, > [ 198s] inlined from ‘acl_start_next_trie’ at > ../lib/acl/acl_r

[PATCH v2 0/2] fix the problem of dma-perf infinite loop

2025-03-27 Thread Dengdui Huang
After CPU isolation is configured, an infinite loop occurs when dma-perf is executed using the default config file. This patchset fix it. Dengdui Huang (2): eal: fix uncheck worker ID app/dma-perf: fix infinite loop app/test-dma-perf/main.c | 8 +++- lib/eal/common/eal_common_

Re: [External] Re: [PATCH] eal: prevent socket closure before MP sync

2025-03-27 Thread Yang Ming
On 2025/3/17 21:56, Stephen Hemminger wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Fri, 14 Mar 2025 18:36:38 +0800 Yang Ming wrote: The secordary process should not close s

[PATCH 2/2] app/dma-perf: fix infinite loop

2025-03-27 Thread Dengdui Huang
When a core that is not used by the rte is specified in the config for testing, the problem of infinite loop occurs. This patch fix it by adding a check for lcore_id. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- app/te

[PATCH v4] raw/cnxk_gpio: switch to character based GPIO interface

2025-03-27 Thread Tomasz Duszynski
The direct passthrough interrupt mechanism, which allowed bypassing the kernel, was obscure and is no longer supported. So this driver won't work with latest SDK kernels. Additionally, the sysfs GPIO control interface has been deprecated by Linux kernel itself. That said, this change updates the P

[PATCH v2 2/2] app/dma-perf: fix infinite loop

2025-03-27 Thread Dengdui Huang
When a core that is not used by the rte is specified in the config for testing, the problem of infinite loop occurs. This patch fix it by adding a check for lcore_id. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- app/te

Re: DPDK for rust

2025-03-27 Thread Etelson, Gregory
Hello Morten, Thank you for raising these questions ! Do we want the DPDK project itself to support rust? Or should parts of this be a DPDK hosted project, like grout? Rust packages management is different. Also DPDK Rust code will eventually provide a different API. At this stage, DPDK host

[PATCH 1/2] eal: fix uncheck worker ID

2025-03-27 Thread Dengdui Huang
The worker_id may come from user input. So it is necessary to verify it. Fixes: a95d70547c57 ("eal: factorize lcore main loop") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- lib/eal/common/eal_common_launch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_commo

[PATCH] app/dma-perf: fix infinite loop

2025-03-27 Thread Dengdui Huang
When a core that is not used by the rte is specified in the config for testing, the problem of infinite loop occurs. This patch fix it by adding a check for lcore_id. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- app/te

Re: [PATCH] acl: fix build with GCC 15 on aarch64

2025-03-27 Thread Bruce Richardson
On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote: > Caught in OBS for Fedora Rawhide on aarch64: > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > [ 198s] from ../lib/acl/acl_run_neon.c:5: > [ 198s] In function ‘alloc_completion’, > [ 198s] inl

DPDK for rust

2025-03-27 Thread Morten Brørup
> From: Gregory Etelson [mailto:getel...@nvidia.com] > Sent: Thursday, 6 March 2025 14.37 > Subject: [PATCH] rust: support DPDK API > > The patch converts include files with DPDK API to RUST and binds new > RUST API files info dpdklib package. > > The RUST dpdklib files and DPDK libraries build f

Re: [External] Re: [PATCH v2] eal/linux: improve ASLR check

2025-03-27 Thread David Marchand
Hello, On Thu, Mar 27, 2025 at 9:02 AM Yang Ming wrote: > On 2025/3/13 23:37, Stephen Hemminger wrote: > > On Thu, 13 Mar 2025 14:19:03 +0800 > > Yang Ming wrote: > > > >> This change ensures that the current process is checked for > >> being run with 'setarch' before verifying the value of > >>

  1   2   >