RE: [EXTERNAL] Re: [Patch v2] doc: announce bus/vmbus API changes

2025-03-17 Thread Long Li
> -Original Message- > From: David Marchand > Sent: Monday, March 17, 2025 2:47 AM > To: lon...@linuxonhyperv.com > Cc: Stephen Hemminger ; Wei Hu > ; Thomas Monjalon ; > dev@dpdk.org; Long Li > Subject: [EXTERNAL] Re: [Patch v2] doc: announce bus/vmbus API changes > > On Sat, Mar 15,

[Patch v3] doc: announce bus/vmbus API changes

2025-03-17 Thread longli
From: Long Li All vmbus APIs are used internally by DPDK core and net/netvsc PMD. It's not feasible or practical to use those APIs by the application. Those APIs will become internal in DPDK 25.11. Signed-off-by: Long Li --- Change in v2: add details on what APIs will be changed v3: remove the

Re: [PATCH v7 2/4] lib: fix comparison between devices

2025-03-17 Thread Stephen Hemminger
On Thu, 6 Mar 2025 16:26:50 + Shani Peretz wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, 20 February 2025 20:33 > > To: Shani Peretz > > Cc: dev@dpdk.org; Tyler Retzlaff ; Parav > > Pandit > > ; Xueming Li ; Nipun Gupta > > ; Nikhil Agarwal ; Hemant

[PATCH v4 00/14] net/zxdh: add network processor ops

2025-03-17 Thread Bingbin Chen
v4: - change some tables to const. - use %u instead of %d. - delete cast of ret_zmalloc() return. - resolve code functionality issues. V3: - resolve code style. - resolve spin lock build issue. - rebase code baseline. - modify parameters of the plcr function. V2: - resolve code

RE: [External] Re: [PATCH 2/2] net/mlx5: improve log file path

2025-03-17 Thread Bing Zhao
Hi Ming & Stephen, > -Original Message- > From: Yang Ming > Sent: Wednesday, March 12, 2025 10:33 AM > To: Stephen Hemminger ; Bing Zhao > > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad ; dev@dpdk.org > Subject: Re: [External] Re: [PATCH 2/2] net/mlx

[RFC v4 7/8] build: use dynamically generated version maps

2025-03-17 Thread David Marchand
Switch to always dynamically generate version maps. As the map files get generated, tooling around checking, converting, updating etc.. static version maps can be removed. Signed-off-by: David Marchand --- .github/workflows/build.yml | 1 - MAINTAINERS

[RFC v4 3/8] eal: rework function versioning macros

2025-03-17 Thread David Marchand
For versioning symbols: - MSVC uses pragmas on the symbol, - GNU linker uses special asm directives, To accommodate both GNU linker and MSVC linker, introduce new macros for exporting and versioning symbols that will surround the whole function. This has the advantage of hiding all the ugly detai

[RFC v4 5/8] build: generate symbol maps

2025-03-17 Thread David Marchand
Rather than maintain a file in parallel of the code, symbols to be exported can be marked with a token RTE_EXPORT_*SYMBOL. >From those marks, the build framework generates map files only for symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack becomes unnecessary). The build fra

[RFC v4 1/8] lib: remove incorrect exported symbols

2025-03-17 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. eal_log_journal has no implementation and can be removed. Signed-off-by: David Marchand --- lib/eventdev/version.map | 12 lib/graph/ver

[RFC v4 4/8] buildtools: display version when listing symbols

2025-03-17 Thread David Marchand
Display the version when a symbol was introduced. This is needed for scripting the conversion from static to dynamically generated version maps. It is also useful when listing experimental symbols. Signed-off-by: David Marchand --- buildtools/map-list-symbol.sh | 2 +- 1 file changed, 1 insertio

[RFC v4 2/8] drivers: remove incorrect exported symbols

2025-03-17 Thread David Marchand
Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. rte_dpaa2_dev_type is an enum token. roc_se_ctx_swap has no implementation (leftover from a previous rework) and can be removed. Signed-off-by: David M

[RFC v4 0/8] Symbol versioning and export rework

2025-03-17 Thread David Marchand
So far, each DPDK library (or driver) exposing symbols in an ABI had to maintain a version.map and use some macros for symbol versioning, specially crafted with the GNU linker in mind. This series proposes to rework the whole principle, and instead rely on marking the symbol exports in the source

[PATCH v4 07/14] net/zxdh: get flow tables resources

2025-03-17 Thread Bingbin Chen
Implement the flow tables resources get operation by agent channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_ethdev.c | 13 + drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_np.c | 492 + drivers/net/zxdh/zxdh_np.h | 282 +++

[PATCH v4 11/14] net/zxdh: get hash table entry result

2025-03-17 Thread Bingbin Chen
Implement hash tables get operation by dtb channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 482 - drivers/net/zxdh/zxdh_np.h | 7 + 2 files changed, 488 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net

[PATCH v4 04/14] net/zxdh: modify dtb queue ops

2025-03-17 Thread Bingbin Chen
Modify the implementation of the dtb queue request and release interfaces, and add the implementation of queue initialization. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 491 + drivers/net/zxdh/zxdh_np.h | 97 2 files changed, 482 i

[PATCH v4 06/14] net/zxdh: add eram tables ops

2025-03-17 Thread Bingbin Chen
Implement the eram tables read and write operations by dtb channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 545 - drivers/net/zxdh/zxdh_np.h | 15 + 2 files changed, 558 insertions(+), 2 deletions(-) diff --git a/drivers/net/zxdh/zxdh_n

[PATCH v4 03/14] net/zxdh: add agent channel

2025-03-17 Thread Bingbin Chen
Add agent channel to access (np)network processor registers that are not mapped by PCIE. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 315 - drivers/net/zxdh/zxdh_np.h | 53 +++ 2 files changed, 367 insertions(+), 1 deletion(-) diff --git

[PATCH v4 02/14] net/zxdh: support compatibility check

2025-03-17 Thread Bingbin Chen
Add compatibility check between (np)network processor software and firmware. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 93 ++ drivers/net/zxdh/zxdh_np.h | 12 + 2 files changed, 105 insertions(+) diff --git a/drivers/net/zxdh/zxdh_np.c

Re: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2025-03-17 Thread Edwin Brossette
Hello, Thank you for your answer. The short patch I joined with my first mail was just a rough example to report what I tested. I believe you know the driver's code better than I do, so I wouldn't be opposed to see you fix this issue. Thank you in advance. Regards, Edwin Brossette. On Wed, Mar 5

[PATCH] test: fix race in per lcore test

2025-03-17 Thread David Marchand
In some CI, this unit test can fail, as the main thread may get rescheduled while lcores execute the callback waiting 100ms. Bugzilla ID: 1668 Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_per_lcore.c | 17 +++-- 1 f

Re: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-17 Thread Jan Viktorin
Hello Vipin and others, please, will there be any progress or update on this series? I successfully tested those changes on our Intel and AMD machines and would like to use it in production soon. The API is a little bit unintuitive, at least for me, but I successfully integrated into our softwar

RE: [PATCH 2/2] net/mlx5: fix GENEVE parser cleanup

2025-03-17 Thread Matan Azrad
> From: Michael Baum > > The GENEVE parser is shared across ports on the same physical device. It is > created once for the first port and increments a reference counter for each > additional port. The parser is created using the InfiniBand > (IBV) context (CTX) of the first port, and cleanup s

RE: [PATCH 1/2] common/mlx5: add device duplication function

2025-03-17 Thread Matan Azrad
> From: Michael Baum > > Add function for creating additional CTX for same device base on existing CTX. > > Signed-off-by: Michael Baum Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 52 > > drivers/common/mlx5/mlx5_common.h|

RE: [EXTERNAL] [PATCH] app/crypto-perf: fix aad offset alignment

2025-03-17 Thread Akhil Goyal
Hi, > AAD offset in AES-GCM crypto test was calculated by adding > 16-byte alignment after the IV, which is only needed in AES-CCM. Agreed that CCM has a requirement for 16B alignment. But for GCM, does it break any protocol? Can we not align to byte boundary for performance? This is a performanc

Re: [PATCH v2 0/4] remove driver-specific logic for AVX builds

2025-03-17 Thread David Marchand
On Fri, Mar 14, 2025 at 6:44 PM Bruce Richardson wrote: > > A number of drivers had special optimized AVX2 and AVX512 code paths > for performance reasons, and these tended to have copy-pasted logic > to build those files. Centralise that logic in the main > drivers/meson.build file to avoid dupli

Re: [PATCH v2 4/4] drivers/net: remove AVX2 build-time define

2025-03-17 Thread David Marchand
On Fri, Mar 14, 2025 at 6:44 PM Bruce Richardson wrote: > > Since all supported compilers can generate AVX2 code, we will always > enable the build of the AVX2 files on x86. This means that > CC_AVX2_SUPPORT is always true on x86, so it can be removed and a > regular "#ifdef RTE_ARCH_x86" used in

Re: [Patch v2] doc: announce bus/vmbus API changes

2025-03-17 Thread David Marchand
On Sat, Mar 15, 2025 at 1:35 AM wrote: > > From: Long Li > > All vmbus APIs are used internally by DPDK core and net/netvsc PMD. > It's not feasible or practical to use those APIs by the application. > Those APIs will be moved from "DPDK" to "Internal" in DPDK 25.11. > > Signed-off-by: Long Li >

Re: [PATCH 2/2] bus/fslmc: fix use after free

2025-03-17 Thread Markus Elfring
> The cleanup loop would deference the dpio_dev after freeing. … dereference? Regards, Markus

RE: [PATCH] test/crypto: skip test when virtio PMD not loaded

2025-03-17 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: skip test when virtio PMD not loaded > > Skip asymmetric test when virtio PMD is not loaded. > > Fixes: 7e2e9d5f3227 ("test/crypto: add asymmetric cases for virtio") > Fixes: a8f3d4f5b547 ("test/crypto: add cases for virtio-user") > > Signed-off-by: Gowrishankar M

RE: [EXTERNAL] [PATCH v2] common/qat: fix incorrect size in the parser

2025-03-17 Thread Akhil Goyal
> The function `strlen` returns the size of the string without a terminating > null-character, therefore a request to allocate memory space for a parsed > argument is too small by 1. > > Fixes: 99ab2806687b ("common/qat: isolate parser arguments configuration") > Cc: sta...@dpdk.org > > Signed-of

[DPDK/ethdev Bug 1677] E810 VLAN Stripping Offload broken with multiple RX queues

2025-03-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1677 Bug ID: 1677 Summary: E810 VLAN Stripping Offload broken with multiple RX queues Product: DPDK Version: 24.11 Hardware: x86 OS: Linux Status: UNCONFIRME