Re: [PATCH v2 3/5] eal: update versioning macros

2025-03-07 Thread David Marchand
On Wed, Feb 19, 2025 at 2:40 AM Andre Muezerie wrote: > > When compiling with MSVC the error below shows up due to function > versioning: > > ../lib/net/rte_net_crc.c(418): error C2061: syntax error: > identifier '__attribute__' > > MSVC allows alias function names to be exported, but the mech

Re: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-07 Thread Andre Muezerie
On Fri, Mar 07, 2025 at 09:01:28AM +, Bruce Richardson wrote: > On Thu, Mar 06, 2025 at 12:03:28PM -0800, Andre Muezerie wrote: > > Compiling with MSVC logs the warnings below, which result in > > build error: > > > > ../app/test/test_hash_readwrite.c(73): warning C4476: 'printf' : > > unk

[PATCH v1 4/5] net/ntnic: check result of malloc

2025-03-07 Thread Serhii Iliushyk
Check return value from the malloc code Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 10 ++ drivers/net/ntnic/nthw/nthw_rac.c | 5 - 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/ntnic/dbsconfig/ntnic_db

[PATCH v1 5/5] net/ntnic: add nthw prefix function names

2025-03-07 Thread Serhii Iliushyk
Add nthw prefix to functions with abstract names to avoid exposing global symbols Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 +- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 6 +- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 32 +-- drivers/ne

[PATCH v1 3/5] net/ntnic: replace assert with RTE assert

2025-03-07 Thread Serhii Iliushyk
Use RTE_ASSERT instead of direct calling asserts Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 14 ++- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 6 +- drivers/net/ntnic/include/flow_api.h | 2 +- .../link_mgmt/link_100g/nt4ga_link_100g.c

[PATCH v1 0/5] bugfixes and cleanup

2025-03-07 Thread Serhii Iliushyk
This patchset contains bugfixes and cleanup for the ntnic PMD * add SPDX tag * rename clock registers file * replace assert with RTE assert * check result of malloc * add 'nthw' prefix function names Serhii Iliushyk (5): net/ntnic: add SPDX tag net/ntnic: rename clock registers file

[PATCH v1 1/5] net/ntnic: add SPDX tag

2025-03-07 Thread Serhii Iliushyk
Add missed SPDX tag Signed-off-by: Serhii Iliushyk --- .../include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h| 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h b/drivers/net/ntnic/nthw/core/include/

[PATCH v1 2/5] net/ntnic: rename clock registers file

2025-03-07 Thread Serhii Iliushyk
Rename this files to align the file naming Signed-off-by: Serhii Iliushyk --- ...egisters.h => nt400d13_u62_si5332_gm2_revd_1_v5_registers.h} | 0 ...0_v5-Registers.h => nt200a02_u23_si5340_adr0_v5_registers.h} | 0 .../ntnic/nthw/core/nt200a0x/clock_profiles/nthw_fpga_clk9563.c | 2 +- drivers/

Re: MPLS Push action

2025-03-07 Thread Kishore Padmanabha
Hi Thomas, Any update on this. Thanks, Kishore On Tue, Mar 4, 2025 at 12:48 PM Kishore Padmanabha < kishore.padmana...@broadcom.com> wrote: > Hi Thomas, > > On Mon, Mar 3, 2025 at 2:25 PM Thomas Monjalon > wrote: > >> Hi, >> >> This is the related code: >> >> /** >> * RTE_FLOW_ACTION_TYPE_OF

Re: [PATCH] rust: support DPDK API

2025-03-07 Thread Etelson, Gregory
On Fri, 7 Mar 2025, Bruce Richardson wrote: External email: Use caution opening links or attachments On Fri, Mar 07, 2025 at 03:54:33PM +, Van Haaren, Harry wrote: From: Gregory Etelson Sent: Thursday, March 6, 2025 1:37 PM To: dev@dpdk.org Cc: getel...@nvidia.com ; tho...@monjalon.n

Re: [PATCH] rust: support DPDK API

2025-03-07 Thread Etelson, Gregory
On Fri, 7 Mar 2025, Van Haaren, Harry wrote: External email: Use caution opening links or attachments From: Gregory Etelson Sent: Thursday, March 6, 2025 1:37 PM To: dev@dpdk.org Cc: getel...@nvidia.com ; tho...@monjalon.net ; mkash...@nvidia.com ; Richardson, Bruce Subject: [PATCH] ru

[DPDK/testpmd Bug 1627] Not all variants of supported NIC types have been used in testing

2025-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1627 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC

RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF

2025-03-07 Thread Long Li
> -Original Message- > From: Wei Hu > Sent: Tuesday, February 18, 2025 10:12 PM > To: lon...@linuxonhyperv.com; Stephen Hemminger > > Cc: dev@dpdk.org; Long Li ; sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF > > > > > -Original Message-

Re: [PATCH] rust: support DPDK API

2025-03-07 Thread Etelson, Gregory
Hello Harry, From: Gregory Etelson Sent: Thursday, March 6, 2025 1:37 PM To: dev@dpdk.org Cc: getel...@nvidia.com ; tho...@monjalon.net ; mkash...@nvidia.com ; Richardson, Bruce Subject: [PATCH] rust: support DPDK API Cool, I like this subject, great! The patch converts include files w

[DPDK/ethdev Bug 1621] In packets provided by the PMD, some flags are missing

2025-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1621 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added Resolution|--- |WONTFIX Status|

Re: [PATCH] rust: support DPDK API

2025-03-07 Thread Bruce Richardson
On Fri, Mar 07, 2025 at 03:54:33PM +, Van Haaren, Harry wrote: > > From: Gregory Etelson > > Sent: Thursday, March 6, 2025 1:37 PM > > To: dev@dpdk.org > > Cc: getel...@nvidia.com ; tho...@monjalon.net > > ; mkash...@nvidia.com ; > > Richardson, Bruce > > Subject: [PATCH] rust: support DPD

[PATCH] net/intel: remove unused reassembly functions

2025-03-07 Thread Bruce Richardson
When creating a common pkt reassembly function for common driver Rx re-use, not all original copies of the function were removed. Fix this omission. Fixes: 82fbc4a4479c ("net/intel: create common packet reassembly") Signed-off-by: Bruce Richardson --- drivers/net/intel/i40e/i40e_rxtx_vec_common

Re: [PATCH] rust: support DPDK API

2025-03-07 Thread Van Haaren, Harry
> From: Gregory Etelson > Sent: Thursday, March 6, 2025 1:37 PM > To: dev@dpdk.org > Cc: getel...@nvidia.com ; tho...@monjalon.net > ; mkash...@nvidia.com ; Richardson, > Bruce > Subject: [PATCH] rust: support DPDK API More in-depth review in this reply.. > The patch converts include files w

Re: [PATCH v3 0/2] enable build of lib/stack when using MSVC

2025-03-07 Thread David Marchand
On Tue, Feb 4, 2025 at 2:58 AM Andre Muezerie wrote: > > MSVC does not support inline assembly, which is used by the > implementation of rte_atomic128_cmp_exchange and is needed > by the C11 flavor of lib/stack. > > A special implementation of rte_atomic128_cmp_exchange > compatible with MSVC is a

[DPDK/vhost/virtio Bug 1671] [dpdk-25.03] loopback_virtio_user_server_mode: failed to launch dpdk-pdump

2025-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1671 Bug ID: 1671 Summary: [dpdk-25.03] loopback_virtio_user_server_mode: failed to launch dpdk-pdump Product: DPDK Version: 25.03 Hardware: All OS: All Stat

Re: [PATCH v1 20/32] net/ntnic: add clock init

2025-03-07 Thread Serhii Iliushyk
On 05.03.2025, 19:03, "David Marchand" wrote: On Thu, Feb 20, 2025 at 11:06 PM Serhii Iliushyk wrote: > diff --git > a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h > > b/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h > ne

Re: [PATCH] ethdev: fix get_reg_info

2025-03-07 Thread fengchengwen
On 2025/2/18 19:58, Thierry Herbelot wrote: > 'width' and 'offset' are input parameters when dumping the register > info of an Ethernet device. They should be copied in the new request > before calling the device callback function. > > Fixes: 083db2ed9e9 ('ethdev: add report of register names and

Re: [PATCH] ethdev: fix get_reg_info

2025-03-07 Thread fengchengwen
On 2025/2/20 2:45, Stephen Hemminger wrote: > On Tue, 18 Feb 2025 12:58:28 +0100 > Thierry Herbelot wrote: > >> 'width' and 'offset' are input parameters when dumping the register >> info of an Ethernet device. They should be copied in the new request >> before calling the device callback functio

[PATCH v2] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-07 Thread Dariusz Sosnowski
From: Alex Vesker When creating a root modify/reformat action it is created for a single specific table type, current code ignored this and used the first ft_type found in if, else. Also added missing translation for non-root FDB action root dest. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action o

Re: [PATCH] hash_readwrite_autotest: fix printf parameters

2025-03-07 Thread Bruce Richardson
On Thu, Mar 06, 2025 at 12:03:28PM -0800, Andre Muezerie wrote: > Compiling with MSVC logs the warnings below, which result in > build error: > > ../app/test/test_hash_readwrite.c(73): warning C4476: 'printf' : > unknown type field character ''' in format specifier > ../app/test/test_hash_read

Re: [PATCH v2 2/2] drivers/net: remove use of non-standard array range initialization

2025-03-07 Thread Howard Wang
Acked-by: Howard Wang