Re: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-04 Thread Mattias Rönnblom
On 2025-03-04 11:08, Morten Brørup wrote: From: Varghese, Vipin [mailto:vipin.vargh...@amd.com] Sent: Monday, 3 March 2025 10.06 [Public] Hi Morten, snipped From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Thursday, 13 February 2025 09.34 13/02/2025 04:09, Varghese, Vipin: [AMD O

[v6 4/6] crypto/virtio: add vDPA backend

2025-03-04 Thread Gowrishankar Muthukrishnan
Add vDPA backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_logs.h

[v6 3/6] crypto/virtio: add packed ring support

2025-03-04 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers/cryp

[v6 6/6] test/crypto: add tests for virtio user PMD

2025-03-04 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a/app

[v6 5/6] test/crypto: add asymmetric tests for virtio PMD

2025-03-04 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 28 1 file changed, 28 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 9b5f3c545e..ac47be724f 100644

[v6 2/6] crypto/virtio: refactor queue operations

2025-03-04 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virtio_crypto_algs.h | 2 +- drivers/crypto/virtio/virtio_c

[v6 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-03-04 Thread Gowrishankar Muthukrishnan
This patch series enhances virtio crypto PMD to: * support RSA * support packed virtio ring * support vDPA backend v6: - patches rebased. Gowrishankar Muthukrishnan (6): crypto/virtio: add asymmetric RSA support crypto/virtio: refactor queue operations crypto/virtio: add packed ring sup

[v6 1/6] crypto/virtio: add asymmetric RSA support

2025-03-04 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/virtio.ini | 4 + doc/guides/rel_notes/release_25_03.rst| 4 + .../virtio/virtio_crypto_capabilities.h |

RE: [EXTERNAL] [PATCH v4 4/5] trace: support expression for blob length

2025-03-04 Thread Sunil Kumar Kori
> Support any expression as a blob length by using an intermediate variable in > the trace point emitter itself. > This also avoids any side effect on the passed variable. > > On the "register" side, prefix the length variable in the trace metadata with > the name of the emitted argument. > > Wit

RE: [EXTERNAL] [PATCH v4 5/5] trace: fix undefined behavior in register

2025-03-04 Thread Sunil Kumar Kori
> Registering a tracepoint handler was resulting so far in undefined behavior at > runtime. > > The RTE_TRACE_POINT_REGISTER() macro was casting the tracepoint handler > (which expects arguments) to a void (*)(void). > At runtime, calling this handler while registering resulted in reading the > cu

RE: [EXTERNAL] [PATCH v4 3/5] trace: support dereferencing pointers

2025-03-04 Thread Sunil Kumar Kori
> Rather than use an intermediate variable, add new helpers that handle > dereferencing pointers. > Update dmadev traces accordingly (and adjust the emitter type). > > Signed-off-by: David Marchand > --- > Changes since v3: > - started from scratch with different approach, added new helpers > t

Re: [PATCH 2/2] net/mlx5: improve log file path

2025-03-04 Thread Yang Ming
On 2025/3/4 14:23, Bing Zhao wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. Hi Ming, -Original Message- From: Yang Ming Sent: Friday, December 13, 2024 5:25 PM To: Dariu

[RFC] doc: Document frequency and volume limits on patches.

2025-03-04 Thread Aaron Conole
The DPDK project has two constrained resources - reviewers and public CI infrastructure. These are shared among the entire project, and there are true costs associated with using these resources. Thus, there are two motivations behind this change: - Encourage developers to spend more time ensur

[DPDK/cryptodev Bug 1669] Cannot use ESN with GMAC authentication

2025-03-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1669 Bug ID: 1669 Summary: Cannot use ESN with GMAC authentication Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] net/mana: avoid the use of variable length array

2025-03-04 Thread longli
From: Long Li The pathname can be defined as name[MAX_PATH]. This makes the driver compilable using MSVC. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index c37c4e

[DPDK/core Bug 1668] EAL: rte_eal_mp_remote_launch is able to launch an lcore which is running

2025-03-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1668 Bug ID: 1668 Summary: EAL: rte_eal_mp_remote_launch is able to launch an lcore which is running Product: DPDK Version: 25.03 Hardware: x86 OS: Linux Sta

Re: [PATCH v3 00/16] net/zxdh: updated net zxdh driver

2025-03-04 Thread Thomas Monjalon
25/02/2025 17:12, Stephen Hemminger: > On Tue, 25 Feb 2025 18:42:52 +0800 > Junlong Wang wrote: > > Junlong Wang (16): > > net/zxdh: optimize np dtb channel initialization > > net/zxdh: optimize queue res alloc/free process > > net/zxdh: optimize link update process > > net/zxdh: update Rx

DPDK Summit CFP extended - last days

2025-03-04 Thread Thomas Monjalon
The next DPDK Summit will happen on May 8-9 in Prague, Czech Republic. The events team decided to extend the CFP period by one week to give you a little more chance to propose interesting talks. This is the very last week to submit on this page: https://events.linuxfoundation.org/dpdk-sum

Re: [PATCH] ci: point at GitHub mirror.

2025-03-04 Thread Patrick Robb
I see a spurious dpdk-test fail for this, on per_lcore_autotest, it remotely launches an lcore which is running though it should not be able to. I threw the relevant blurbs below - I will bring this to Bugzilla since obviously your patch is unrelated. We can do a retest if you want - otherwise I t

[PATCH v2 1/2] lib/hash: initialize __m128i data type in a portable way

2025-03-04 Thread Andre Muezerie
The mechanism used to initialize an __m128i data type in rte_thash.h is non-portable and MSVC does not like it. It clearly is not doing what is desired: ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': truncation from 'unsigned __int64' to 'char' ..\lib\hash\rte_thash.h(38): warning

[PATCH v2 2/2] app/test: add test_init_m128i using compiler intrinsic

2025-03-04 Thread Andre Muezerie
This test initializes an __m128i data type using the old non-portable way used until now and the more portable way using compiler intrinsics. The test ensures the resulting values after initialization match. Signed-off-by: Andre Muezerie --- app/test/test_thash.c | 34 +++

Re: [PATCH v2 0/3] bbdev: trace point and logging

2025-03-04 Thread Maxime Coquelin
On 1/23/25 11:55 PM, Nicolas Chautru wrote: v2: fix build error. Hi, Based on previous discussion improving logging for bbdev and PMD using notably trace points and internal logging extension. The trace point impacting real time are not built by default. This is added at bbdev level and also

Re: [PATCH v1 0/2] bbdev: doc and vector clean up

2025-03-04 Thread Maxime Coquelin
On 2/28/25 5:50 PM, Nicolas Chautru wrote: Minor changes to clean up the documentation for bbdev programming guide and updating vectors to avoid false alarms when using different windowing configuration assumption by users. Nicolas Chautru (2): doc: update bbdev documentation test/bbdev

[PATCH v4 5/5] trace: fix undefined behavior in register

2025-03-04 Thread David Marchand
Registering a tracepoint handler was resulting so far in undefined behavior at runtime. The RTE_TRACE_POINT_REGISTER() macro was casting the tracepoint handler (which expects arguments) to a void (*)(void). At runtime, calling this handler while registering resulted in reading the current stack wi

Re: [PATCH v4 6/7] dts: add per-test-suite configuration

2025-03-04 Thread Dean Marx
I like this implementation a lot, it's concise and easy to use. Reviewed-by: Dean Marx

Re: [PATCH v4 4/7] dts: update autodoc sorting order

2025-03-04 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v4 7/7] dts: improve configuration errors

2025-03-04 Thread Dean Marx
Looks great, thanks Luca! Reviewed-by: Dean Marx

Re: [PATCH v4 5/7] dts: run only one test run per execution

2025-03-04 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v4 3/7] dts: fix smoke tests docstring

2025-03-04 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v4 2/7] dts: amend test suites docstring

2025-03-04 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v4 1/7] dts: add tests package to API docs

2025-03-04 Thread Dean Marx
Reviewed-by: Dean Marx

[DPDK/core Bug 1667] Can't configure DPDK poller in busy loop to fix drops

2025-03-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1667 fgiord...@riverbed.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[PATCH] doc: update virtio prog guide with new feature list

2025-03-04 Thread Kommula Shiva Shankar
This patch adds newly added virtio hash report feature to prog guide. Signed-off-by: Kommula Shiva Shankar --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index c22ce56a02..0615abfaaf 100644 --- a/doc/g

Re: MPLS Push action

2025-03-04 Thread Kishore Padmanabha
Hi Thomas, On Mon, Mar 3, 2025 at 2:25 PM Thomas Monjalon wrote: > Hi, > > This is the related code: > > /** > * RTE_FLOW_ACTION_TYPE_OF_PUSH_MPLS > * > * Implements OFPAT_PUSH_MPLS ("push a new MPLS tag") as defined by the > * OpenFlow Switch Specification. > */ > struct rte_flow_action_of

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-03-04 Thread Patrick Robb
Thanks Ariel, If you submitted another version that supersedes it, I think you need to mark this superseded: https://patchwork.dpdk.org/project/dpdk/patch/20250223214123.447579-2-ariel.otilib...@6wind.com/ Best, Patrick

[PATCH v4] lib/fib: remove warning about implicit 64-bit conversion

2025-03-04 Thread Andre Muezerie
MSVC issues the warning below: ../lib/fib/trie.c(341): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The fix is to cast (1) explicitly to uintptr_t since it is used in pointer arithmetic. Signed-off-by: Andre Muezerie --- lib/fib/trie.

Re: [PATCH v3] lib/fib: remove warning about implicit 64-bit conversion

2025-03-04 Thread Andre Muezerie
On Tue, Mar 04, 2025 at 10:47:28AM +, Bruce Richardson wrote: > On Mon, Mar 03, 2025 at 02:54:52PM -0800, Andre Muezerie wrote: > > MSVC issues the warning below: > > > > ../lib/fib/trie.c(341): warning C4334: '<<': > > result of 32-bit shift implicitly converted to 64 bits > > (was 64-bit shi

Re: [PATCH v3] lib/fib: remove warning about implicit 64-bit conversion

2025-03-04 Thread Andre Muezerie
On Mon, Mar 03, 2025 at 10:49:52PM -0800, Stephen Hemminger wrote: > Better to cast the constant (1) to avoid warning, > . > That is what other code does like RTE_BIT macros Alright, I made that change in v4. > > On Mon, Mar 3, 2025, 23:55 Andre Muezerie > wrote: > > > MSVC issues the warning

[PATCH v4 0/5] Trace point framework enhancement for dmadev

2025-03-04 Thread David Marchand
dmadev trace points have been working around trace point framework limitations. One of this workaround blocks enabling dmadev on MSVC. Traces files were not checked in CI, so this series also adds a new check. -- David Marchand Changes since v3: - dropped changes to CTF metadata, - added new he

Re: [PATCH v1 2/2] test/bbdev: update to fft test vectors

2025-03-04 Thread Maxime Coquelin
On 2/28/25 5:50 PM, Nicolas Chautru wrote: Some FFT operations vectors could create false alarms depending on implementation and dependency SW versions. Updated one vector and removing one previous vector. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_vectors/fft_9.data | 870

Re: [PATCH v1 1/2] doc: update bbdev documentation

2025-03-04 Thread Maxime Coquelin
On 2/28/25 5:50 PM, Nicolas Chautru wrote: Correcting the scope of supported bbdev operations. Signed-off-by: Nicolas Chautru --- doc/guides/prog_guide/bbdev.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbd

[PATCH v4 4/5] trace: support expression for blob length

2025-03-04 Thread David Marchand
Support any expression as a blob length by using an intermediate variable in the trace point emitter itself. This also avoids any side effect on the passed variable. On the "register" side, prefix the length variable in the trace metadata with the name of the emitted argument. With this, we can u

[PATCH v4 3/5] trace: support dereferencing pointers

2025-03-04 Thread David Marchand
Rather than use an intermediate variable, add new helpers that handle dereferencing pointers. Update dmadev traces accordingly (and adjust the emitter type). Signed-off-by: David Marchand --- Changes since v3: - started from scratch with different approach, added new helpers to avoid touching c

[PATCH v4 2/5] dmadev: avoid copies in tracepoints

2025-03-04 Thread David Marchand
No need to copy values in intermediate variables. Use the right trace point emitters. Update the pcie struct to avoid aliasing warning. Signed-off-by: David Marchand --- Changes since v3: - added anonymous union around pcie struct (which triggered an abidiff warning that needs waiving) and kept

[PATCH v4 1/5] ci: check traces validity

2025-03-04 Thread David Marchand
We currently do not validate if generated traces can be parsed by a tracing tool. Add some check. Signed-off-by: David Marchand --- Changes since v2: - added this check, as v2 was breaking CTF metadata content, --- .ci/linux-build.sh | 10 ++ .github/workflows/build.yml | 2 +-

[PATCH] ci: point at GitHub mirror.

2025-03-04 Thread David Marchand
We face some random failures accessing dpdk.org git when running GHA. Point at GitHub hosted mirror. Cc: sta...@dpdk.org Signed-off-by: David Marchand --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workfl

Re: [PATCH v2 2/3] baseband/acc: add trace point

2025-03-04 Thread Maxime Coquelin
On 1/23/25 11:55 PM, Nicolas Chautru wrote: Improvement of logging to notably use trace point for driver specific error logging and tracepoint. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.c | 8 drivers/baseband/acc/acc_common.h | 55

Re: [PATCH v2 3/3] baseband/acc: add internal logging

2025-03-04 Thread Maxime Coquelin
Hi Nicolas, On 2/28/25 6:28 PM, Chautru, Nicolas wrote: Hi Maxime, I believe that for 25.03 we can just apply the first 2 commits of the serie. For the last commit, it will take more time to try your suggestion out, we can do this in subsequent release. Does that sound okay with you? Yes, t

DPDK Release Status Meeting 2025-03-04

2025-03-04 Thread Mcnamara, John
Release status meeting minutes 2025-03-04 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Broadcom * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed working dates

Re: [v9 0/6] vhost: add RSA support

2025-03-04 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: This patch series supports asymmetric RSA in vhost crypto library. It also includes changes to improve vhost crypto library: * support newer QEMU versions. * fix broken vhost_crypto example application. * stabilize crypto fastpath ope

Re: [PATCH 1/1] vhost: fix missing descriptor chains length checks

2025-03-04 Thread Maxime Coquelin
On 12/23/24 4:29 AM, Yunjian Wang wrote: The descriptor chains length must be greater than the Virtio-net header size. Otherwise, such descriptor chains sizes implies no packet data. Fixes: fe8477ebbd94 ("vhost: support async packed ring dequeue") Cc: sta...@dpdk.org Signed-off-by: Yunjian W

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-04 Thread Maxime Coquelin
On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob ; Nithin Kumar Dabilpuram ; Srujana Challa Subje

Re: [PATCH 1/1] vhost: fix missing descriptor chains length checks

2025-03-04 Thread Maxime Coquelin
On 12/23/24 4:29 AM, Yunjian Wang wrote: The descriptor chains length must be greater than the Virtio-net header size. Otherwise, such descriptor chains sizes implies no packet data. Fixes: fe8477ebbd94 ("vhost: support async packed ring dequeue") Cc: sta...@dpdk.org Signed-off-by: Yunjian W

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-04 Thread Maxime Coquelin
On 3/3/25 11:25 AM, Maxime Coquelin wrote: On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob ; N

[DPDK/core Bug 1667] Can't configure DPDK poller in busy loop to fix drops

2025-03-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1667 Bug ID: 1667 Summary: Can't configure DPDK poller in busy loop to fix drops Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: norma

Re: [PATCH v2] member: use common top-level variable for easier maintenance

2025-03-04 Thread Bruce Richardson
On Mon, Mar 03, 2025 at 12:47:54PM -0800, Andre Muezerie wrote: > Updated meson.build to use common variable cc_avx512_flags for > msvc and avoiding code duplication for other compilers. > > Signed-off-by: Andre Muezerie > --- Acked-by: Bruce Richardson

Re: [PATCH v3] lib/fib: remove warning about implicit 64-bit conversion

2025-03-04 Thread Bruce Richardson
On Mon, Mar 03, 2025 at 02:54:52PM -0800, Andre Muezerie wrote: > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The fix is to cast the result explicitly to uintptr_t since

Re: [PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

2025-03-04 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 02:57:57PM -0800, Andre Muezerie wrote: > The mechanism used to initialize an __m128i data type in rte_thash.h is > non-portable and MSVC does not like it. It clearly is not doing what > is desired: > > ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': > trunc

RE: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-04 Thread Morten Brørup
> From: Varghese, Vipin [mailto:vipin.vargh...@amd.com] > Sent: Monday, 3 March 2025 10.06 > > [Public] > > Hi Morten, > > snipped > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, 13 February 2025 09.34 > > > > > > 13/02/2025 04:09, Varghese, Vipin: > > > > [