RE: [v4 0/5] vhost: add RSA support

2025-02-23 Thread Akhil Goyal
Hi Maxime, Can you pick these patches in vhost tree first so that virtio/crypto patches can be merged in crypto tree? Regards, Akhil > Subject: [v4 0/5] vhost: add RSA support > > This patch series supports asymmetric RSA in vhost crypto library. > It also includes changes to improve vhost cryp

RE: [v4 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-02-23 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, February 22, 2025 2:47 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Akhil Goyal ; > Gowrishankar Muthukrishnan > Subject: [v4 0/6] crypto/virtio: enhancements for RSA and vDPA > > This patch series enhances virtio cr

RE: [v4 4/5] vhost: support asymmetric RSA crypto ops

2025-02-23 Thread Akhil Goyal
> Subject: [v4 4/5] vhost: support asymmetric RSA crypto ops > > Support asymmetric RSA crypto operations in vhost-user. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal You may want to update documentation and release notes also.

RE: [v4 1/5] vhost: skip crypto op fetch before vring init

2025-02-23 Thread Akhil Goyal
> Subject: [v4 1/5] vhost: skip crypto op fetch before vring init > > Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), > worker thread should not try to fetch crypto op, which would lead to > memory fault. > > Fixes: 939066d96563 ("vhost/crypto: add public function implement

RE: [v4 5/5] examples/vhost_crypto: support asymmetric crypto

2025-02-23 Thread Akhil Goyal
> Subject: [v4 5/5] examples/vhost_crypto: support asymmetric crypto > > Support asymmetric crypto operations. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Update documentation for newly added parameter. Apart from that. Acked-by: Akhil Goyal

RE: [PATCH 34/34] common/cnxk: move interrupt handling to platform-specific

2025-02-23 Thread Jerin Jacob
> -Original Message- > From: Nithin Dabilpuram > Sent: Friday, January 31, 2025 1:35 PM > To: Jerin Jacob ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Harman Kalra > > Cc: dev@dpdk.org > Subject: [PATCH 34/34] common/cnxk

RE: [v4 3/5] examples/vhost_crypto: fix user callbacks

2025-02-23 Thread Akhil Goyal
> Subject: [v4 3/5] examples/vhost_crypto: fix user callbacks > > In order to handle new vhost user connection, use new_connection > and destroy_connection callbacks. > > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar M

RE: [v4 2/5] vhost: update vhost_user crypto session parameters

2025-02-23 Thread Akhil Goyal
> Subject: [v4 2/5] vhost: update vhost_user crypto session parameters > > As per requirements on vhost_user spec, session id should be > located at the end of session parameter. > > Update VhostUserCryptoSessionParam structure to support newer QEMU. Do we need to update QEMU version in documenta

Re: [PATCH v2 00/16] net/zxdh: updated net zxdh driver

2025-02-23 Thread Junlong Wang
Hi maintainer, Do these warnings need to be resolved? The usage of this code is also supported by the standard C language, and other drivers also have this usage; At the same time, why does the compilation still have [- Wvla] warning when adding cflags += no_wvla_cflag in zxdh

Re: [PATCH v2 00/16] net/zxdh: updated net zxdh driver

2025-02-23 Thread Junlong Wang
Hi maintainer, Do these warnings need to be resolved? The usage of this code is also supported by the standard C language, and other drivers also have this usage; At the same time, why does the compilation still have [- Wvla] warning when adding cflags += no_wvla_cflag in zxdh

Re: [PATCH 00/12] net/xsc: Resolve issues from PVS and Coverity Scan

2025-02-23 Thread Renyong Wan
Hello Stephen, Thank you for your review.  I appreciate the detailed analysis and the suggestions for improvements. Please find my feedback bellow. On 2025/2/23 1:30, Stephen Hemminger wrote: > On Sat, 22 Feb 2025 11:57:59 +0800 > "Renyong Wan" wrote: > >> This patch series resolves several iss

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-23 Thread Dmitry Kozlyuk
2025-02-23 22:41 (UTC+0100), Ariel Otilibili: > diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c > index 16485b27cb46..d2cbcea42885 100644 > --- a/lib/pcapng/rte_pcapng.c > +++ b/lib/pcapng/rte_pcapng.c > @@ -716,6 +716,9 @@ rte_pcapng_fdopen(int fd, > void > rte_pcapng_close(rte_pc

[PATCH v10 1/2] net/af_xdp: Fix use after free in af_xdp_tx_zc

2025-02-23 Thread Ariel Otilibili
tx_bytes is computed after both legs are tested. This might produce a use after memory free. The computation is now moved into each leg. Bugzilla ID: 1440 Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Signed-off-by: Ariel Otilibili Acked-by: Stephen Hemminger --- .mailmap

[PATCH v10 0/2] Fix use after free, and refactor af_xdp_tx_zc

2025-02-23 Thread Ariel Otilibili
Hello, The series addresses Bugzilla ID 1440 in two steps; 1. Fix use after free. 2. Refactor af_xdp_tx_zc(). Thank you, --- v10 * no change v9 (https://inbox.dpdk.org/dev/20250207104552.1663519-1-ariel.otilib...@6wind.com/) * desc->len takes its value from mbuf (Maryam Tahhan) v8 (https://i

[PATCH v10 2/2] net/af_xdp: Refactor af_xdp_tx_zc

2025-02-23 Thread Ariel Otilibili
Both legs of the loop share the same logic: the common parts are about reserving and filling both address and length into the description. This is moved into reserve_and_fill(). Bugzilla ID: 1440 Suggested-by: Maryam Tahhan Signed-off-by: Ariel Otilibili Acked-by: Maryam Tahhan --- drivers/ne

[PATCH v2 0/1] warn if NULL is passed to rte_pcapng_close

2025-02-23 Thread Ariel Otilibili
Hello, This patch addresses a warning found by static analysis; courtesy of Stephen Hemminger. Thank you, --- v2 * rather change documentation than work around the bug (Stephen Hemminger) * changed cover letter and commit message v1 (https://inbox.dpdk.org/dev/20250216160833.3216001-1-ariel.ot

[PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-23 Thread Ariel Otilibili
rte_pcapng_close() might dereference a null pointer; as example, PVS-Studio gives its usage in test_pcapng.c: indeed, that call to rte_pcapng_close() might receive a null pointer. In that case, rte_errno is set to EINVAL. The API is updated accordingly. Link: https://pvs-studio.com/en/docs/warnin

Re: [PATCH] net/mlx5: fix flow null ops seg fault

2025-02-23 Thread Raslan Darawsheh
Hi, From: Kevin Traynor Sent: Friday, February 14, 2025 12:05 PM To: dev@dpdk.org Cc: Dariusz Sosnowski; Maayan Kashani; Raslan Darawsheh; Ori Kam; Kevin Traynor; sta...@dpdk.org Subject: [PATCH] net/mlx5: fix flow null ops seg fault flow null driver ops may get selected and try to call .list_c

Re: [PATCH] net/mlx5: fix leak in HWS flow counter action

2025-02-23 Thread Raslan Darawsheh
Hi, From: David Marchand Sent: Monday, January 27, 2025 12:53 PM To: dev@dpdk.org Cc: sta...@dpdk.org; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Jack Min Subject: [PATCH] net/mlx5: fix leak in HWS flow counter action This was caught by our internal covsc

[RFC 0/1] replace inline assembly prefetch with cc builtins

2025-02-23 Thread Mattias Rönnblom
This is an unorthodox RFC in that I think it probably shouldn't be accepted. I thought I'd try replacing the x86 inline assembly for DPDK software prefetch with GCC __builtin_prefetch(). Being essentially a black box for the compiler, inline assembly hinders certain optimizations. The hope was be

[RFC 1/1] eal/x86: replace inline assembly prefetch with cc builtins

2025-02-23 Thread Mattias Rönnblom
Implement the 32- and 64-bit x86 rte_prefetch() functions and rte_prefetch_non_temporal() using compiler builtins, rather than inline assembly. This change frees the compiler to do certain optimizations that otherwise wouldn't be possible. Signed-off-by: Mattias Rönnblom --- lib/eal/x86/include

Re: [PATCH v2] net/mlx5/hws: fix fragmented ptype match

2025-02-23 Thread Raslan Darawsheh
Hi, From: Alexander Kozyrev Sent: Thursday, December 19, 2024 6:05 PM To: dev@dpdk.org Cc: sta...@dpdk.org; Raslan Darawsheh; Slava Ovsiienko; Dariusz Sosnowski; Bing Zhao; Suanming Mou; Michael Baum Subject: [PATCH v2] net/mlx5/hws: fix fragmented ptype match Fragmented PTYPE matching requires