On 06-02-2025 05:38, Shani Peretz wrote:
DPDK supports multiple formats for specifying buses,
(such as ":08:00.0" and "08:00.0" for PCI).
This flexibility can lead to inconsistencies when using one
format while running testpmd, then attempts to use the other
format in a later command, resul
> -Original Message-
> From: psathe...@marvell.com
> Sent: Wednesday, February 5, 2025 11:13 AM
> To: Nithin Kumar Dabilpuram ; Kiran Kumar
> Kokkilagadda ; Sunil Kumar Kori
> ; Satha Koteswara Rao Kottidi
> ; Harman Kalra
> Cc: dev@dpdk.org; Satheesh Paul Antonysamy
> Subject: [EXTER
In the function __rte_graph_mcore_dispatch_sched_node_enqueue,
use a slower loop to search for the graph, modify the search logic
to record the result of the first search, and use this record for
subsequent searches to improve search speed.
Signed-off-by: Huichao Cai
---
devtools/libabigail.abig
On Sat 1 Feb 2025, 10:03 Ariel Otilibili, wrote:
> Both legs of the loop share the same logic: the common parts are about
> reserving and filling both address and length into the description.
>
> This is moved into reserve_and_fill().
>
> Bugzilla ID: 1440
> Suggested-by: Maryam Tahhan
> Signed-
On Wed, Feb 05, 2025 at 05:35:26PM +0100, David Marchand wrote:
> Hello André,
>
> On Tue, Feb 4, 2025 at 9:57 PM Andre Muezerie
> wrote:
> > @@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun
> > assign_fun, flip_fun flip_fun, size
> > rand_bitset(bitset, size);
> >
> >
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c6297
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
buildtools/chkincs/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index ed65105599..49dbc55
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
examples/fips_validation/meson.build | 2 ++
examples/ip_fragmentation/meson.build | 1 +
examples/ipsec-secgw/meson.build | 3 +++
examples/l2fwd-crypto/meson.build
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
lib/acl/meson.build| 2 ++
lib/bpf/meson.build| 2 ++
lib/dispatcher/meson.build | 2 ++
lib/eventdev/meson.build | 2 ++
lib/ipsec/meson.build |
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
app/pdump/meson.build| 2 ++
app/proc-info/meson.build| 2 ++
app/test-acl/meson.build | 2 ++
app/test-bbdev/meson.build | 2 ++
app/
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
Acked-by: Chengwen Feng
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+)
1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.
2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=array-bounds=]
3695
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Bruce Richardson
---
drivers/net/intel/i40e/i40e_testpmd.c |
Add -Wvla project-wide so that VLAs are not allowed by default. This
is to avoid new VLAs from being introduced.
Meson files in directories which are not yet VLA-free have already
been updated with -Wno-vla to avoid build breaks.
Signed-off-by: Andre Muezerie
---
config/meson.build | 1 +
1 fil
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
drivers/common/cnxk/meson.build | 2 ++
drivers/common/mlx5/meson.build | 2 ++
drivers/common/qat/meson.build | 2 ++
drivers/crypto/ccp/meson.build
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Chengwen Feng
---
app/test-pmd/cmdline.c | 2 +-
app/test
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Chengwen Feng
---
app/test/test.c | 2 +-
We define no_wvla_cflag in a top directory so that it can be used by
meson.build files in lower directories that are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
config/meson.build | 8
1 file changed, 8 insertions(+)
diff --git a/config/meson.build b/config/meson.build
index 6a
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
The tuple can exceed sizeof(union rte_thash_tuple), for example if any
tunneling header is used in the RSS hash calculation.
The longest RSS hash key currently supported is
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array 'events'
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
From: Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/freebsd/include/rte_os.h | 1 +
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
3 files changed, 3 insertions(+)
d
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
Acked-by: Stephen Hemminger
---
lib/eal/common/eal_common
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
>
> Sorry, just fixing my comment here:
>
> So I think i spotted one issue, you might need override desc->len after
> the call to the reserve_and_fill function so that it's *not taken* from
> local_mbuf here.
>
On Sat 1 Feb 2025, 10:03 Ariel Otilibili, wrote:
> Both legs of the loop share the same logic: the common parts are about
> reserving and filling both address and length into the description.
>
> This is moved into reserve_and_fill().
>
> Bugzilla ID: 1440
> Suggested-by: Maryam Tahhan
> Signed-
On Thu, 6 Feb 2025 02:08:37 +0200
Shani Peretz wrote:
> +static struct rte_device *
> +create_pci_dev(const char *name)
> +{
> + int port_id;
> + struct rte_ether_addr mac_addr = {
> + .addr_bytes = {
> + 0x00, 0xFF, 0x00, 0xFF, 0x00, 0x00
> +
On Wed, 5 Feb 2025 20:16:48 +
Shani Peretz wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Wednesday, 5 February 2025 20:46
> > To: Shani Peretz
> > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > ; Tyler Retzlaff ; Parav
> > Pandit ; Xueming Li ; Ni
Change find_device and rte_cmp_dev_name to accept a struct
with pointer and size instead of a void* pointer.
Signed-off-by: Shani Peretz
---
app/test/test_devargs.c | 23 +++
app/test/test_vdev.c | 23 ++-
drivers/bus/a
DPDK supports multiple formats for specifying buses,
(such as ":08:00.0" and "08:00.0" for PCI).
This flexibility can lead to inconsistencies when using one
format while running testpmd, then attempts to use the other
format in a later command, resulting in a failure.
The issue arises from the
Added tests to PCI and vdev bus that compare and find devices
in various forms of names under test_devargs.
The tests check the functionality of the rte_cmp_dev_name function by
calling it with different variations of names, like short and full,
full and full, etc.
Signed-off-by: Shani Peretz
---
When registering a new PCI device, the device->name field stored
the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0").
This approach led to inconsistencies when registering new devices.
This patch fix this issue by saving the parsed PCI in device->name,
so when a new PCI devic
This series fixes two issues:
1. saving PCI name as the parsed one instead of user-provided string when
registering a new device
2. fixes rte_cmp_dev_name function that currently compares the names by
compering 2 strings
Also added test to check the functionality of rte_cmp_dev_name.
Shani Pe
Patrick Robb writes:
> On Tue, Feb 4, 2025 at 11:07 AM Aaron Conole wrote:
>
> This commit adds preliminary support for developer driven FreeBSD testing
> via the Cirrus-CI cloud continuous integration system.
>
> NOTE: Currently, this does not successfully execute. See the following
> buil
Hi Ariel,
On 1/31/25 6:34 PM, Ariel Otilibili-Anieli wrote:
Hello Maxime,
On Friday, January 31, 2025 14:09 CET, Maxime Coquelin
wrote:
This patch fixes a regression in vhost_driver_register()
causing VDUSE devices registration to fail systematically
because the return value was initialized
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, 5 February 2025 20:46
> To: Shani Peretz
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Tyler Retzlaff ; Parav
> Pandit ; Xueming Li ; Nipun Gupta
> ; Nikhil Agarwal ; Hemant
> Agrawal ; Sachin Saxena
> ;
On Wed, Feb 05, 2025 at 10:35:25AM -0800, Stephen Hemminger wrote:
> On Tue, 14 Jan 2025 13:05:02 -0800
> Andre Muezerie wrote:
>
> > This patch avoids warnings like the ones below emitted by MSVC:
> >
> > 1)
> > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> > result of 32
This patch avoids warnings like the ones below emitted by MSVC:
1)
../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)
2)
../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
signed
On Wed, Feb 05, 2025 at 10:33:57AM -0800, Stephen Hemminger wrote:
> On Tue, 14 Jan 2025 12:46:51 -0800
> Andre Muezerie wrote:
>
> > Added MSVC specific compiler flag to ignore warnings about unused
> > variables, like is being done for other compilers.
> >
> > Signed-off-by: Andre Muezerie
>
Removed unused variables and added MSVC specific compiler flag to
ignore warnings about unused variables, like is being done for
other compilers.
Signed-off-by: Andre Muezerie
---
drivers/common/idpf/base/meson.build | 13 ++---
drivers/common/idpf/idpf_common_rxtx.c | 2 --
d
v3:
* rebased.
Removed unused variables and added MSVC specific compiler flag to
ignore warnings about unused variables, like is being done for
other compilers.
Andre Muezerie (2):
drivers/common: remove unused variables and add MSVC compiler flag
drivers/net: add MSVC compiler flag for unus
Added MSVC specific compiler flag to ignore warnings about unused
variables, like is being done for other compilers.
Signed-off-by: Andre Muezerie
---
drivers/net/qede/base/meson.build | 57 +--
1 file changed, 32 insertions(+), 25 deletions(-)
diff --git a/drivers/n
On Wed, 5 Feb 2025 17:37:54 +
Shani Peretz wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Wednesday, 5 February 2025 18:42
> > To: Shani Peretz
> > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > ; Tyler Retzlaff ; Parav
> > Pandit ; Xueming Li ; Ni
On Tue, 14 Jan 2025 13:05:02 -0800
Andre Muezerie wrote:
> This patch avoids warnings like the ones below emitted by MSVC:
>
> 1)
> ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
>
>
On Tue, 14 Jan 2025 12:46:51 -0800
Andre Muezerie wrote:
> Added MSVC specific compiler flag to ignore warnings about unused
> variables, like is being done for other compilers.
>
> Signed-off-by: Andre Muezerie
This patch series needs rebase now that Intel drivers got reorganized.
The "Intel C++ Compiler" (icc) has been replaced by the newer clang-based
"Intel oneAPI DPC++/C++ Compiler" (icx) compiler. DPDK compilation has
also not been tested recently with the icc compiler, so let's remove doc
and code references to icc, and any special macros or build support that
was add
The Intel oneAPI DPC++/C++ Compiler (icx), issues warnings on build when
the "-march=native", or other configured global "-march" flag, is
overridden to "skylake-avx512", when compiling AVX-512 code.
Allow building with icx with warnings-as-errors flag (werror) enabled by
disabling the warning for
The "icc" compiler has been replaced by the newer icx one, so remove
references and workarounds for icc in our codebase. Building with
icx already works, all-be-it with warnings, so we can just fix the
few warnings and report it as supported in our docs in place of icc.
v2:
* include a patch to fi
On Wed, Feb 05, 2025 at 05:32:11PM +, Bruce Richardson wrote:
> On Wed, Feb 05, 2025 at 06:03:16PM +0100, David Marchand wrote:
> > On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson
> > wrote:
> > >
> > > The Intel-produced compiler "icc" has been replaced by the newer
> > > clang-based "icx" co
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, 5 February 2025 18:42
> To: Shani Peretz
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Tyler Retzlaff ; Parav
> Pandit ; Xueming Li ; Nipun Gupta
> ; Nikhil Agarwal ; Hemant
> Agrawal ; Sachin Saxena
> ;
On Wed, Feb 05, 2025 at 06:03:16PM +0100, David Marchand wrote:
> On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson
> wrote:
> >
> > The Intel-produced compiler "icc" has been replaced by the newer
> > clang-based "icx" compiler. DPDK compilation has also not been tested
> > recently with the icc co
My bad! I'll fix that real quick.
On Mon, Feb 3, 2025 at 11:51 AM Luca Vizzarro wrote:
>
> On 03/02/2025 16:38, Nicholas Pratte wrote:
> > --- a/dts/tests/TestSuite_mtu.py
> > +++ b/dts/tests/TestSuite_mtu.py
> > @@ -164,22 +164,33 @@ def test_runtime_mtu_updating_and_forwarding(self) ->
> > Non
From: Peter Spreadborough
This change addresses the CID 449072: Control flow issues (DEADCODE)
reported by coverity.
Coverity issue: 449072
Signed-off-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 2 +-
1 file changed, 1 insertion(+), 1 del
From: Peter Spreadborough
This change addresses the CID 449075: Control flow issues (DEADCODE)
reported by coverity associated with the ASSERT_RETURN macro. The
change renames the macro and replaces the log macro to use
PMD_DRV_LOG_LINE.
Coverity issue: 449075
Signed-off-by: Peter Spreadborough
From: Peter Spreadborough
This change addresses the CID 449065: Uninitialized variables (UNINIT)
issues reported by coverity.
Coverity issue: 449065
Signed-off-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 +
drivers/net/bnxt/tf_ulp/ulp_sc_mg
From: Peter Spreadborough
This change addresses the CID 449058: Integer handling issues
(OVERFLOW_BEFORE_WIDEN) reported by coverity.
Coverity issue: 449058
Signed-off-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 2 +-
1 file changed, 1
From: Peter Spreadborough
This change addresses the CID 449059: Integer handling issues
(INTEGER_OVERFLOW) reported by coverity.
Coverity issue: 449059
Signed-off-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c | 6 +-
1 file changed, 5 in
From: Peter Spreadborough
This change addresses the CID 449056: Error handling issues (CHECKED_RETURN)
reported by coverity. The changes add return code handling to
address the issue.
Coverity issue: 449056
Signed-off-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/tf
Fix the code accounting the status of compressed CQE handler.
The code was inside the block handling the normal CQE mode.
Moved the code out. Without this the Rx datapath was broken
for compressed CQEs in scalar mode.
Fixes: 5c980062d895 ("net/bnxt: support compressed Rx CQE")
Cc: sta...@dpdk.org
From: Sangtani Parag Satishbhai
When the PCI port is detached using the testpmd command,
as part of cleanup testpmd removes resources of parent
port and all the children's ports and calls the driver specific
pci_remove API with the parent rte ethdev to clean-up ethdevs.
For the bnxt driver, a con
Simplify the check for the CQE mode.
We don't have to check the Rx offload mode to determine
which CQE mode is supported.
CQE mode is configured at load time and once set will decide
if TCP LRO or buffer split can be supported or not.
Signed-off-by: Ajit Khaparde
Reviewed-by: Somnath Kotur
Revie
We are incorrectly setting the Rx and Tx burst handlers to static mode
by default. Fix that by using the bnxt_receive_function and
bnxt_transmit_function calls to determine if the vector mode is enabled
and identify the appropriate burst handler during the initialization.
Signed-off-by: Ajit Khapa
If a user selects compressed CQE mode using the cqe-mode devarg,
it is clear that the user does not intend to use TruFlow mode.
Since host backed TruFlow setting is enable by default now, disable
TruFlow during initialization to prevent unexpected behavior
when the two get enabled.
Signed-off-by:
Patchset with bug fixes for bnxt PMD.
Also addresses various Coverity issues reported in the recent
Coverity scan.
Please apply.
Ajit Khaparde (4):
net/bnxt: disable TruFlow if compressed CQE is set
net/bnxt: simplify check for CQE mode
net/bnxt: fix Rx handler
net/bnxt: fix burst handler
On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson
wrote:
>
> The Intel-produced compiler "icc" has been replaced by the newer
> clang-based "icx" compiler. DPDK compilation has also not been tested
> recently with the icc compiler, so let's remove doc and code references
> to icc, and any special ma
> -Original Message-
> From: Vamsi Krishna Attunuru
> Sent: Wednesday, February 5, 2025 10:20 AM
> To: Andre Muezerie
> Cc: bruce.richard...@intel.com; dev@dpdk.org;
> konstantin.v.anan...@yandex.ru
> Subject: RE: [EXTERNAL] [PATCH v2] drivers/net: use intrinsic to access
> content
>
06/01/2025 19:31, Wathsala Vithanage:
> +'mcpu_generic_aarch32': {
> +'march': 'armv8-a',
> +'march_extensions': ['simd'],
> +}
> +'mcpu_thunderx2t99': {
> +'march': 'armv8.1-a',
> +'march_extensions': ['crc', 'crypto']
> +},
A comma is missing.
I c
On Wed, Feb 5, 2025 at 5:44 PM Renyong Wan wrote:
> >> That's how we designed it.
> >> We designed a low-level device operations framework named xsc_dev_ops to
> >> support both VFIO drivers and kernel drivers. Each xsc_dev_ops is
> >> registered before the main function runs. During the PCI devic
Recheck-request: iol-compile-amd64-testing, iol-compile-arm64-testing,
iol-unit-amd64-testing
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 5e7455931442 ("net/dpaa: support Rx que
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: fe3688ba7950 ("crypto/dpaa_sec: support
On 2025/2/5 23:45, Thomas Monjalon wrote:
> 05/02/2025 16:37, Renyong Wan:
>> On 2025/2/5 22:43, Thomas Monjalon wrote:
>>> 05/02/2025 15:37, Renyong Wan:
On 2025/2/5 19:44, Thomas Monjalon wrote:
> 28/01/2025 15:46, Renyong Wan:
>> XSC PMD is designed to support both VFIO and private
On Tue, 4 Feb 2025 12:57:09 -0800
Andre Muezerie wrote:
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11)
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Warray-bounds"
> +#endif
>
> + /* gcc is giving false positives here when code is optimized */
>
On Wed, 5 Feb 2025 16:36:11 +
Shani Peretz wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Wednesday, 29 January 2025 18:25
> > To: Shani Peretz
> > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > ; Tyler Retzlaff ; Parav
> > Pandit ; Xueming Li ; Ni
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, 29 January 2025 18:25
> To: Shani Peretz
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Tyler Retzlaff ; Parav
> Pandit ; Xueming Li ; Nipun Gupta
> ; Nikhil Agarwal ; Hemant
> Agrawal ; Sachin Saxena
> ;
Hello André,
On Tue, Feb 4, 2025 at 9:57 PM Andre Muezerie
wrote:
> @@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun
> assign_fun, flip_fun flip_fun, size
> rand_bitset(bitset, size);
>
> for (i = 0; i < size; i++) {
> - RTE_BITSET_DECLARE(referenc
The code for parsing layers in devargs could reference past
the end of layers[] array on stack.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax")
Cc: xuemi...@nvidia.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hem
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: a77db24643b7 ("crypto/dpaa2_sec: suppor
The same condition is checked twice in an if statement.
Harmless, but redundant.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
Acked-by: Anoob Joseph
---
drivers/common/cnxk/cnxk_security.c | 16 ++--
1 file changed, 10 insertions(+), 6 delet
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 2d3788631862 ("net/dpaa2: support atomi
Using variable in outer loop, and inner loop is obvious bug.
This bug is in base code, so likely on other platforms as well.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 81dba2b2ff61 ("net/qede/base: add LLDP support")
Cc: rasesh.m...@cavium.com
Cc: sta...@dpdk.org
Signed-off-by: S
More bug fixes from PVS studio bug reports.
And one other fix to ptpclient.
Stephen Hemminger (19):
common/cnxk: remove duplicate condition
net/cpfl: avoid calling log (printf) with null
raw/cnxk_gpio: fix file descriptor leak
net/ntnic: remove dead code
net/i40e: remove duplicate code
The pointer mode is used then checked which is a bug reported
by PVS studio.
Fixes: bd2fd34ab86f ("common/cnxk: sync eth mode change command with firmware")
Cc: tduszyn...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/common/cnxk/roc_bphy_cgx.c | 12 ++--
The expression:
if ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&
gets evaluated as sockeid = (rte_lcore_to_socket_id(lcore) != 0)
which is not what was intended. This is goes all the way back
to first release.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: af75078fece3 ("fir
More bitmask truncation from mask computation.
Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue")
Cc: sunil.k...@nxp.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Acked-by: Hemant Agrawal
---
drivers/event/dpaa/dpaa_eventdev.c | 10 +-
1 file changed, 5 insertions(+), 5
Calling memcmp on same structure will always be true.
Replace with same conditional used elsewhere.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
Cc: danielx.t.mrzyg...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen
The type mask is 64 bit value, doing a shift of literal 1 (32 bit)
will result in int type (32 bit) and cause truncation.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: f4ca3fd54c4d ("net/hinic: create and destroy flow director filter")
Cc: cloud.wangxiao...@huawei.com
Cc: sta...@dpdk
Both sides of the if in uninit are using same code.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
---
drivers/net/octeon_ep/otx_ep_ethdev.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c
Don't use rte_memcpy() when not necessary. Structure assignment
is as fast and type safe.
Signed-off-by: Stephen Hemminger
---
examples/ptpclient/ptpclient.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.
The array of debug status strings did not match possible enum
values. Add the missing element and a static assert to make sure
the table has all possible values.
For more complete description see.
Link: https://pvs-studio.com/en/blog/posts/cpp/1176/
Fixes: ec55c118792b ("net/qede: add infrastruct
There are two branches in the cascading if/else that have same
condition and code; remove one. Update the code to follow DPDK
style where all statements in if should have brackets if any
leg requires them.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 2ab5c84605f0 ("net/i40e: fix ESP
1 - 100 of 165 matches
Mail list logo
