RE: [RFC PATCH] eventdev: adapter API to configure multiple Rx queues

> -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, January 29, 2025 10:35 AM > To: Shijith Thotton ; dev@dpdk.org > Cc: Pavan Nikhilesh Bhagavatula ; Pathak, Pravin > ; Hemant Agrawal ; > Sachin Saxena ; Mattias R_nnblom > ; Jerin Jacob ; Liang > Ma ; Mccarthy, Peter ; >

RE: [RFC PATCH] eventdev: adapter API to configure multiple Rx queues

> -Original Message- > From: Shijith Thotton > Sent: Friday, January 24, 2025 3:30 PM > To: Naga Harish K, S V ; dev@dpdk.org > Cc: Pavan Nikhilesh Bhagavatula ; Pathak, > Pravin ; Hemant Agrawal > ; Sachin Saxena ; > Mattias R_nnblom ; Jerin Jacob > ; Liang Ma ; Mccarthy, Peter > ; Van

RE: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 28, 2025 4:32 PM > To: Long Li > Cc: lon...@linuxonhyperv.com; Ferruh Yigit ; Andrew > Rybchenko ; Wei Hu ; > dev@dpdk.org > Subject: Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters > for hot plu

Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

On Wed, 29 Jan 2025 00:10:12 + Long Li wrote: > > Subject: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for > > hot plug events > > > > On Mon, 27 Jan 2025 17:35:06 -0800 > > lon...@linuxonhyperv.com wrote: > > > > > @@ -1409,9 +1424,6 @@ eth_hn_dev_uninit(struct rte_eth

RE: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

> Subject: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for > hot plug events > > On Mon, 27 Jan 2025 17:35:06 -0800 > lon...@linuxonhyperv.com wrote: > > > @@ -1409,9 +1424,6 @@ eth_hn_dev_uninit(struct rte_eth_dev *eth_dev) > > ret_stop = hn_dev_stop(eth_dev); > > hn_d

[PATCH v3 1/2] net/af_xdp: fix use after free in af_xdp_tx_zc()

tx_bytes is computed after both legs are tested. This might produce a use after memory free. The computation is now moved into each leg. Bugzilla ID: 1440 Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Signed-off-by: Ariel Otilibili --- drivers/net/af_xdp/rte_eth_af_xdp.c | 4

[PATCH v3 2/2] net/af_xdp: Refactor af_xdp_tx_zc()

Both legs of the loop share the same logic: either to go out of the function, or to fall through to the next instructions. For that, maybe_cpy_pkt() is introduced. Bugzilla ID: 1440 Signed-off-by: Ariel Otilibili --- drivers/net/af_xdp/rte_eth_af_xdp.c | 131 ++-- 1 file

[PATCH v3 0/2] Fix use after free, and refactor af_xdp_tx_zc()

Hello, The series addresses Bugzilla ID 1440 in two steps; 1. Fix use after free. 2. Refactor af_xdp_tx_zc(). Thank you, --- v3 * reworded commit message of patch-1 * addressed feedback of Maryam Tahhan v2 (https://inbox.dpdk.org/dev/20250116225151.188214-1-ariel.otilib...@6wind.com/) * reworde

[PATCH v7 2/2] dts: add flow create/delete to testpmd shell

Add flow create/delete methods to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 45 +++ 1 file changed, 45 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/rem

[PATCH v7 1/2] dts: add flow rule dataclass to testpmd shell

Add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 52 ++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH 1/3] lib/eal: add rte_atomic128_cmp_exchange compatible with MSVC

On Fri, Jan 24, 2025 at 03:27:06PM +0100, David Marchand wrote: > On Tue, Dec 10, 2024 at 5:33 PM Andre Muezerie > wrote: > > > > MSVC does not support inline assembly, which is used by the > > implementation of rte_atomic128_cmp_exchange and is needed > > by lib/stack. > > > > Error printed by MS

[PATCH v2 2/2] stack: enable build with MSVC

An implementation compatible with MSVC is provided for atomic128_cmp_exchange in rte_stack_lf_c11.h. Now that the issues preventing the code needed to build lib/stack have been addressed, it can be enabled so that it also gets built when using the MSVC compiler. Signed-off-by: Andre Muezerie ---

[PATCH v2 0/2] enable build of lib/stack when using MSVC

MSVC does not support inline assembly, which is used by the implementation of rte_atomic128_cmp_exchange and is needed by the C11 flavor of lib/stack. A special implementation of rte_atomic128_cmp_exchange compatible with MSVC is added to rte_stack_lf_c11.h. It uses an intrinsic function when usin

[PATCH v2 1/2] test: disable non-C11 atomic tests for MSVC

In general, non-C11 atomics are not to be used with MSVC. This patch skips the non-C11 atomic tests when using MSVC. Signed-off-by: Andre Muezerie --- app/test/test_atomic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index db07159e81..3f

Re: [PATCH v3 0/6] queue start/stop and deferred checks

On Mon, 16 Dec 2024 11:11:32 -0800 Stephen Hemminger wrote: > Recent zxdh driver review raised the question of why should > drivers have to check rx_conf for deferred start support. > This can be better handled across all drivers at ethdev level. > > Also found some drivers were incorrect in fea

Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

On Mon, 27 Jan 2025 17:35:06 -0800 lon...@linuxonhyperv.com wrote: > From: Long Li > > If a device is hot removed and hot plugged, it needs the same driver > parameters that are passed to EAL. However, during device removal, all > EAL driver parameters are freed as part of the cleanup. > > Cach

Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

On Mon, 27 Jan 2025 17:35:06 -0800 lon...@linuxonhyperv.com wrote: > @@ -1409,9 +1424,6 @@ eth_hn_dev_uninit(struct rte_eth_dev *eth_dev) > ret_stop = hn_dev_stop(eth_dev); > hn_dev_close(eth_dev); > > - free(hv->vf_devargs); > - hv->vf_devargs = NULL; > - > hn_detach(h

Re: [PATCH v9 00/15] net/zxdh: updated net zxdh driver

On Tue, 21 Jan 2025 11:44:18 +0800 Junlong Wang wrote: > V9: > - Remove unnecessary __rte_packed* in stats structure. > > V8: > - using __rte_packed_begin/__rte_packed_end replace __rte_packed. > > V7: > - resolved warning '-Waddress-of-packed-member' > in function 'zxdh_dev_rss_reta_

Re: [PATCH v6 2/2] dts: add flow create/delete to testpmd shell

Got it, thanks Luca!

[DPDK/ethdev Bug 1622] ntnic: using signals and threads

https://bugs.dpdk.org/show_bug.cgi?id=1622 Bug ID: 1622 Summary: ntnic: using signals and threads Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority:

Re: [PATCH v1 02/31] net/ntnic: add thread check return code

On Tue, 21 Jan 2025 18:07:40 +0100 Serhii Iliushyk wrote: > From: Danylo Vodopianov > > CI found couple coverity problems which were fixed in this commit. > > CID: 448965 Error handling issues (CHECKED_RETURN). > > Thread return code check was added. > > Coverity issue: 448965 > Fixes: a1ba8

Re: [PATCH v1 00/31] net/ntnic: bugfixes and refactoring

On Tue, 21 Jan 2025 18:07:38 +0100 Serhii Iliushyk wrote: > These patches include fixes for issues detected by the Coverity Scan tool and > internal tests. > > Danylo Vodopianov (26): > net/ntnic: fix index verification > net/ntnic: add thread check return code > net/ntnic: add return cod

Re: [PATCH] net/bnxt: remove unnecessary checks for null pointer

On Tue, Jan 28, 2025 at 9:42 AM Stephen Hemminger wrote: > > The function rte_free() handles a NULL pointer as no-op. > This patch was automatically generated from nullfree.cocci script. > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/tf_core/v3/tfc_tbl_sc

[PATCH] net/bnxt: remove unnecessary checks for null pointer

The function rte_free() handles a NULL pointer as no-op. This patch was automatically generated from nullfree.cocci script. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 6 ++ drivers/net/bnxt/tf_ulp/ulp_mapper.c| 3 +-- drivers/net/bnxt/tf_ulp/ul

[PATCH] ptr_compress: fix build for Arm SVE enabled SoC

Fix compilation issue with const conversion. Fixes: 077596a4b077 ("ptr_compress: add pointer compression library") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- lib/ptr_compress/rte_ptr_compress.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ptr_compres

[PATCH 1/4] drivers: merge common and net idpf drivers

Rather than having some of the idpf code split out into the "common" directory, used by both a net/idpf and a net/cpfl driver, we can merge all idpf code together under net/idpf and have the cpfl driver depend on "net/idpf" rather than "common/idpf". Signed-off-by: Bruce Richardson --- drivers/c

[PATCH 3/4] drivers: move iavf common folder to iavf net

The common/iavf driver folder contains the base code for the iavf driver, which is also linked against by the ice driver and others. However, there is no need for this to be in common, and we can move it to the net/intel/iavf as a base code driver. This involves updating dependencies that were on c

[PATCH 4/4] net/intel: allow building ice driver without iavf

The ice PMD relies on a number of functions from the iavf base code, which can be got by linking against that iavf driver. However, since only three C files are necessary here, we can allow ice to be built independently of iavf by including the base files directly in cases where iavf is not part of

[PATCH 0/4] remove common iavf and idpf drivers

The iavf and idpf common directories were used only to share code between multiple net drivers and did not need to be drivers in their own right, since it is just as easy to have a dependency from one net driver on another as a net driver on a common one. This patchset therefore aims to eliminate

[PATCH 2/4] net/idpf: re-enable unused variable warnings

The idpf driver was being built with warnings disabled for unused variables. However, while the warning was being disabled in the base code directory, all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruce Ri

Re: [PATCH] devtool: fix falsely reporting from checkpatch

On Tue, Jan 28, 2025 at 04:02:27PM +0100, David Marchand wrote: > Hi, > > On Mon, Jan 20, 2025 at 12:27 PM WanRenyong wrote: > > > > When executes the check_packed_attributes function in checkpatch, > > if __rte_packed_begin or __rte_packed_end appear in the context > > of a patch file, there may

Re: [PATCH] devtool: fix falsely reporting from checkpatch

Hi, On Mon, Jan 20, 2025 at 12:27 PM WanRenyong wrote: > > When executes the check_packed_attributes function in checkpatch, > if __rte_packed_begin or __rte_packed_end appear in the context > of a patch file, there may be a situation where the counts of > __rte_packed_begin and __rte_packed_end

DPDK Release Status Meeting 2025-01-28

Release status meeting minutes 2025-01-28 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Debian * Intel * Microsoft * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed wor

[PATCH v7 00/15] XSC PMD for Yunsilicon NICs

This xsc PMD (**librte_net_xsc**) provides poll mode driver for Yunsilicon metaScale serials NICs. Features: - - MTU update - TSO - RSS hash - RSS key update - RSS reta update - L3 checksum offload - L4 checksum offload - Inner L3 checksum - Inner L4 checksum - Basic stats - Stats per que

[PATCH v7 12/15] net/xsc: add ethdev Tx burst

Implement xsc ethdev Tx burst function. Signed-off-by: Dongwei Xu Signed-off-by: Renyong Wan --- doc/guides/nics/features/xsc.ini | 4 + drivers/net/xsc/xsc_ethdev.c | 1 + drivers/net/xsc/xsc_tx.c | 228 +++ drivers/net/xsc/xsc_tx.h | 1 +

[PATCH v7 15/15] net/xsc: add ethdev link and MTU ops

Implement xsc ethdev link and MTU ops. Signed-off-by: Renyong Wan --- doc/guides/nics/features/xsc.ini | 1 + drivers/net/xsc/xsc_dev.c| 33 ++ drivers/net/xsc/xsc_dev.h| 4 +++ drivers/net/xsc/xsc_ethdev.c | 60 4 files chan

[PATCH v7 14/15] net/xsc: add ethdev infos get

Implement xsc ethdev information get ops. Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 61 1 file changed, 61 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c index 63c64ce547..5d548adb2d 100644 --- a/dr

[PATCH v7 11/15] net/xsc: add ethdev Rx burst

Implement xsc ethdev Rx burst function. Signed-off-by: Xiaoxiong Zhang Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 3 + drivers/net/xsc/xsc_rx.c | 174 +++ drivers/net/xsc/xsc_rx.h | 1 + drivers/net/xsc/xsc_rxtx.h | 13 +++ 4 fil

[PATCH v7 13/15] net/xsc: add basic stats ops

Implement xsc ethdev basic statatics ops. Signed-off-by: Renyong Wan --- v6: * Remove unnecessary paren. * Add the feature of stats per queue in xsc.ini. --- doc/guides/nics/features/xsc.ini | 2 + drivers/net/xsc/xsc_ethdev.c | 75 2 files changed, 77 ins

[PATCH v7 10/15] net/xsc: add ethdev stop and close

Implement xsc ethdev close and stop functions. Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_dev.c| 12 drivers/net/xsc/xsc_dev.h| 2 + drivers/net/xsc/xsc_ethdev.c | 108 +++ drivers/net/xsc/xsc_rx.c | 47 +++ drivers/net/xsc

[PATCH v7 09/15] net/xsc: add ethdev start

Implement xsc ethdev start function. Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- v5: * Remove unnecessary call of rte_wmb. --- drivers/net/xsc/meson.build | 2 + drivers/net/xsc/xsc_dev.c| 33 drivers/net/xsc/xsc_dev.h| 8 + drivers/net/xsc/xsc_ethdev.c | 172 ++

[PATCH v7 08/15] net/xsc: add Rx and Tx queue setup

Implement xsc ethdev Rx and Tx queue setup functions. Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- v7: * Delete the packed attributes of sub structures and unions. v6: * Replace __rte_packed with __rte_packed_begin and __rte_packed_end. --- drivers/net/xsc/xsc_defs.h | 4 ++ dr

[PATCH v7 07/15] net/xsc: add ethdev configure and RSS ops

Implement xsc ethdev configure and RSS hash functions. Signed-off-by: Renyong Wan --- v6: * Use memcpy instead of rte_memcpy. v5: * Remove some unnecessary parameter checks. --- doc/guides/nics/features/xsc.ini | 3 ++ drivers/net/xsc/xsc_defs.h | 15 ++ drivers/net/xsc/xsc_dev.c

[PATCH v7 05/15] net/xsc: add PCT interfaces

PCT is the abbreviation of Packet classifier table, which is built in NP to define behavior of various packets. Signed-off-by: Renyong Wan --- v6: * Replace __rte_packed with __rte_packed_begin and __rte_packed_end. --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_defs.h | 29 +++

[PATCH v7 06/15] net/xsc: initialize xsc representors

For the design of the xsc PMD, each ethdev corresponds to a representor. Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_defs.h | 11 +++ drivers/net/xsc/xsc_dev.c| 95 drivers/net/xsc/xsc_dev.h| 3 + drivers/net/xsc/xsc_ethdev.c | 170 ++

[PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver

XSC PMD is designed to support both VFIO and private kernel drivers. This commit add xsc dev ops to support VFIO driver. Signed-off-by: Na Na Signed-off-by: Renyong Wan --- v7: * Delete the packed attributes of sub structures and unions. v6: * Replace __rte_packed with __rte_packed_begin and

[PATCH v7 03/15] net/xsc: add xsc mailbox

XSC mailbox is a mechanism used for interaction between PMD and firmware. Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- v7: * Remove the cast of xdev->dev_priv. * Remove the cast of malloc return value. --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_cmd.h | 3

[PATCH v7 01/15] net/xsc: add xsc PMD framework

Add xsc PMD framework, doc and build infrastructure, supporting PCI probe. Signed-off-by: Renyong Wan --- v7: * Change the name of Wanrenyong to Renyong Wan. v6: * Delete the included header file net/if.h. * Rebase the main branch to merge release notes. --- .mailmap

[PATCH v7 02/15] net/xsc: add xsc device initialization

XSC device is a hardware abstract level device serving as a handle to interact with hardware. Signed-off-by: Renyong Wan --- v7: * Define the size of xdev->name to PCI_PRI_STR_SIZE. v5: * Fix coding style issue with misspelling * Rearrange the elements in struct xsc_hwinfo to reduce holes ---

Re: [PATCH v6 00/25] Reduce code duplication across Intel NIC drivers

On Tue, Jan 28, 2025 at 07:20:43AM +, Shetty, Praveen wrote: > > This patchset attempts to reduce the amount of code duplication across a > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > As part of this process of deduplication, and in preparation for further > clea

[PATCH] doc: update ODM dmadev guide

Update ODM dmadev guide with details on ODM PF driver application. The kernel PF driver module is being removed and so the steps specific to that is also removed. Signed-off-by: Anoob Joseph --- doc/guides/dmadevs/odm.rst | 39 ++ 1 file changed, 14 insertions

[PATCH] net/mlx5: fix GRE open matcher does not match packet

The previous GRE fix was meant to handle HWS behavior and changed the behavior for SWS causing degradation. After the previous fix, in case of an empty GRE match, GRE mask was initialized with protocol full mask, Instead of the empty mask with protocol mask equals zero. The Current fix handles th