[PATCH 1/1] vhost: fix missing descriptor chains length checks

2024-12-22 Thread Yunjian Wang
The descriptor chains length must be greater than the Virtio-net header size. Otherwise, such descriptor chains sizes implies no packet data. Fixes: fe8477ebbd94 ("vhost: support async packed ring dequeue") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/vhost/virtio_net.c | 10

RE: 21.11.9 patches review and test

2024-12-22 Thread Xu, HailinX
> -Original Message- > From: Xu, HailinX > Sent: Tuesday, December 17, 2024 6:01 PM > To: Kevin Traynor ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Luca B

RE: [PATCH 1/1] vhost: fix a double fetch when dequeue offloading

2024-12-22 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, December 21, 2024 12:36 AM > To: Wangyunjian(wangyunjian,TongTu) > Cc: dev@dpdk.org; maxime.coque...@redhat.com; chen...@nvidia.com; > Lilijun (Jerry) ; xiawei (H) ; > wangzengyuan ; sta

Re: [RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID

2024-12-22 Thread Stephen Hemminger
On Sun, 22 Dec 2024 17:38:19 +0200 Shani Peretz wrote: > This change introduces a new API to dynamically enable or disable > xstat counters by their IDs. Some counters may require hardware > resources that are potentially limited, so providing the ability > to toggle them on or off makes sense. >

Re: [PATCH v3 01/10] devtools/cocci, lib/eal: remove unused rte_bitmap_free()

2024-12-22 Thread Stephen Hemminger
On Sun, 22 Dec 2024 02:19:53 +0100 Ariel Otilibili wrote: > Coverity reports return values of calls to rte_bitmap_free() are not used. Some existing user code may actually be using this so this would be an API change. Therefore this patch can not be accepted for current releases. It is worth a

RE: [RFC PATCH] eventdev: adapter API to configure multiple Rx queues

2024-12-22 Thread Naga Harish K, S V
> -Original Message- > From: Shijith Thotton > Sent: Thursday, December 19, 2024 1:04 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Pathak, Pravin ; > Hemant Agrawal ; Sachin Saxena > ; Mattias R_nnblom > ; Jerin Jacob ; Liang > Ma ; Mccarthy, Peter ; > Van Haaren, H

[RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID

2024-12-22 Thread Shani Peretz
This change introduces a new API to dynamically enable or disable xstat counters by their IDs. Some counters may require hardware resources that are potentially limited, so providing the ability to toggle them on or off makes sense. In addition, adding an API to query the current state (enabled, di

[PATCH v4 10/11] common/cnxk: remove unused plt_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). plt_bitmap_free() is an alias of rte_bitmap_free(). A subsequent commit removes all its occurrences: ``` $ git grep -Pn 'plt_bitmap_free\(' drivers/common/cnxk/roc_mcs.c:722: plt_bitmap_free(rsrc->tcam_bmap)

[PATCH v4 08/11] net/bonding: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 171875d067 ("net/bonding: release port upon close") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Chas Williams Cc: "Min Hu (Connor)" --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file

[PATCH v4 09/11] net/netvsc: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Long Li Cc: Wei Hu --- drivers/net/netvsc/hn_rxtx.c | 1 - 1 file changed, 1 de

[PATCH v4 11/11] {common,net}/cnxk: remove unused plt_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on commits: * 13844f8557 ("common/cnxk: remove unused plt_bitmap_free()") * d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: f752780f30 ("common/cnxk: add ROC MACsec initialization") Fixes: bea5d990a9 ("net/cnxk: support outbound soft expiry notification") Fix

[PATCH v4 07/11] common/mlx5: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Dariusz Sosnowski Cc: Viacheslav Ovsiienko Cc: Bing Zhao Cc: Ori Kam Cc: Suanming Mou Cc: Matan A

[PATCH v4 06/11] net/mlx4: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Matan Azrad Cc: Viacheslav Ovsiienko --- drivers/net/mlx4/mlx4_mr.c | 1 - 1 file changed, 1 deleti

[PATCH v4 05/11] net/cxgbe: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Potnuri Bharat Teja --- drivers/net/cxgbe/cxgbe_main.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH v4 03/11] net/sfc: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: e00c3a0c1b ("net/sfc: rename SW stats structures") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Andrew Rybchenko --- drivers/net/sfc/sfc_sw_stats.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v4 04/11] crypto/ionic: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 6bc7f2cf66 ("crypto/ionic: support sessions") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto_main.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v4 02/11] app/test: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Coverity issue: 357712, 357737 Fixes: 24d376bfee ("test/bitmap: fix memory leak") Signed-off-by: Ariel Otilibili -- Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Cc: Stephen Hemminger --- app/test/test_bitmap.c |

[PATCH v4 01/11] devtools/cocci, lib/eal: remove unused rte_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Coverity reports return values of calls to rte_bitmap_free() are not used. As of commit 07604f2644 ("maintainers: update for next-net tree"): ``` $ awk 'NR>281 && NR<300 {print NR ":" $0}' lib/eal/include/rte_bitmap.h 282:/** 283: * Bitmap free 284: * 285: * @param bmp 286: * Handle to bitmap

[PATCH v4 00/11] devtools, lib, test, net, common: remove unused rte_bitmap_free() and plt_bitmap_free()

2024-12-22 Thread Ariel Otilibili
Hello, The first version was about the clearing of Coverity IDs 357712 & 357737; now this series is about the removal of rte_bitmap_free() and its alias plt_bitmap_free(). As of commit 07604f2644 ("maintainers: update for next-net tree"): * rte_bitmap_free() returns an integer, and does nothi