RE: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2024-12-21 Thread Asaf Penso
Hello Igor and Slava, Can you please check out this issue? Regards, Asaf Penso From: Edwin Brossette Sent: Friday, 20 December 2024 19:06 To: dev@dpdk.org Cc: Laurent Hardy ; Olivier Matz ; Didier Pallard ; Jean-Mickael Guerin Subject: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

[PATCH v3 08/10] net/bonding: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 171875d067 ("net/bonding: release port upon close") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Chas Williams Cc: "Min Hu (Connor)" --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file

[PATCH v3 10/10] common/cnxk: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: fa8f86a14e ("common/cnxk: add build infrastructre and HW definition") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Nithin Dabilpuram Cc: Kiran Kumar K Cc: Sunil Kumar Kori Cc: Satha Rao Cc:

[PATCH v3 09/10] net/netvsc: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Long Li Cc: Wei Hu --- drivers/net/netvsc/hn_rxtx.c | 1 - 1 file changed, 1 de

[PATCH v3 04/10] crypto/ionic: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 6bc7f2cf66 ("crypto/ionic: support sessions") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto_main.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v3 06/10] net/mlx4: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Matan Azrad Cc: Viacheslav Ovsiienko --- drivers/net/mlx4/mlx4_mr.c | 1 - 1 file changed, 1 deleti

[PATCH v3 07/10] common/mlx5: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Dariusz Sosnowski Cc: Viacheslav Ovsiienko Cc: Bing Zhao Cc: Ori Kam Cc: Suanming Mou Cc: Matan A

[PATCH v3 05/10] net/cxgbe: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Potnuri Bharat Teja --- drivers/net/cxgbe/cxgbe_main.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH v3 03/10] net/sfc: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: e00c3a0c1b ("net/sfc: rename SW stats structures") Signed-off-by: Ariel Otilibili --- Cc: sta...@dpdk.org Cc: Andrew Rybchenko --- drivers/net/sfc/sfc_sw_stats.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v3 02/10] app/test: remove unsued rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Depends on 17dd8149d6 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Coverity issue: 357712, 357737 Fixes: 24d376bfee ("test/bitmap: fix memory leak") Signed-off-by: Ariel Otilibili -- Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Cc: Stephen Hemminger --- app/test/test_bitmap.c |

[PATCH v3 01/10] devtools/cocci, lib/eal: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Coverity reports return values of calls to rte_bitmap_free() are not used. As of commit 07604f2644 ("maintainers: update for next-net tree"): ``` $ awk 'NR>281 && NR<300 {print NR ":" $0}' lib/eal/include/rte_bitmap.h 282:/** 283: * Bitmap free 284: * 285: * @param bmp 286: * Handle to bitmap

[PATCH v3 00/10] devtools, lib, test, net, common: remove unused rte_bitmap_free()

2024-12-21 Thread Ariel Otilibili
Hello, The first version was about the clearing of Coverity IDs 357712 & 357737; now this series is about the removal of rte_bitmap_free(). As of commit 07604f2644 ("maintainers: update for next-net tree"): * rte_bitmap_free() returns an integer, and does nothing else * all functions that call

Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Ariel Otilibili-Anieli
On Saturday, December 21, 2024 18:42 CET, Andrew Rybchenko wrote: > NACK > > it is the base driver and corresponding code is unreachable with current > build options only. Hello Andrew, Thanks for having looked into this. It looks indeed like a false positive: ``` $ awk 'NR>67 && NR<88 {prin

Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Andrew Rybchenko
NACK it is the base driver and corresponding code is unreachable with current build options only. On 12/21/24 16:27, Ariel Otilibili wrote: The default switch case ends with a goto; meaning these instructions are never reached. Coverity issue: 121742 Fixes: 19b64c6ac3 ("net/sfc/base: import li

[PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Ariel Otilibili
The default switch case ends with a goto; meaning these instructions are never reached. Coverity issue: 121742 Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base") Signed-off-by: Ariel Otilibili -- Cc: sta...@dpdk.org Cc: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_mon.c | 3 --- 1 f

[PATCH 0/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Ariel Otilibili
Hello, This patch clears out Coverity ID 121742. Thank you, Ariel Otilibili (1): common/sfc_efx/base: remove unreachable code drivers/common/sfc_efx/base/efx_mon.c | 3 --- 1 file changed, 3 deletions(-) -- 2.47.1