Re: [PATCH v4] net/hns3: fix Rx packet without CRC data

2024-11-29 Thread huangdengdui
On 2024/11/30 1:12, Stephen Hemminger wrote: > On Fri, 29 Nov 2024 09:36:43 +0800 > Jie Hai wrote: > >>> + >>> +static inline void >>> +hns3_recalculate_crc(struct rte_mbuf *m) >>> +{ >>> + char *append_data; >>> + uint32_t crc; >>> + >>> + crc = rte_net_crc_calc(rte_pktmbuf_mtod(m, void

[PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping

2024-11-29 Thread Alexander Kozyrev
Take the RSS hash value from the title packet before it gets overwritten by the decompression routine. Set the RSS hash flag in the packet mbuf if RSS is enabled in case of non-RSS CQE zipping format. Fixes: 54c2d46 ("net/mlx5: support flow tag and packet header miniCQEs") Cc: sta...@dpdk.org Sig

[PATCH v3 2/2] config/arm: sort SOCs alphabetically

2024-11-29 Thread Wathsala Vithanage
Order SOC configurations and names alphabetically. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- config/arm/meson.build | 86 +- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson

[PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs

2024-11-29 Thread Wathsala Vithanage
Arm recommends using -mcpu over -march and march-extensions when the compiler supports the target CPU (neoverse-n1 etc.). Arm build so far has been an amalgam of -mcpu and -march. When march is in use, it has been the case so far to silently fall back to a downgraded march when the compiler does no

Re: [PATCH] doc: reword sample app guides

2024-11-29 Thread Thomas Monjalon
22/10/2024 01:42, Nandini Persad: > I revised these sections mostly for grammar and clarity. > > Signed-off-by: Nandini Persad Applied with few improvements in links and code formatting, thanks.

Re: When the trace buffers are saved to disk?

2024-11-29 Thread Adel Belkhiri
Thank you for your answer. On Fri, Nov 29, 2024 at 4:23 PM Thomas Monjalon wrote: > 29/11/2024 21:39, Adel Belkhiri: > > Thank you for the clarification, Thomas. Indeed, the documentation for > the > > trace library is kind of limited. If you don't mind, I have another > > question: Would it be

Re: When the trace buffers are saved to disk?

2024-11-29 Thread Thomas Monjalon
29/11/2024 21:39, Adel Belkhiri: > Thank you for the clarification, Thomas. Indeed, the documentation for the > trace library is kind of limited. If you don't mind, I have another > question: Would it be useful to have an API to register a callback (to save > trace data) when the buffer is full? I

[PATCH v2] net/mlx5: fix RSS hash for non-RSS CQE zipping

2024-11-29 Thread Alexander Kozyrev
Take the RSS hash and flow tag values from the title packet before they get overwritten by the decompressing routine. Set the RSS hash flag in the packet mbuf if RSS is enabled in case of non-RSS CQE zipping format. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h |

Re: When the trace buffers are saved to disk?

2024-11-29 Thread Adel Belkhiri
Thank you for the clarification, Thomas. Indeed, the documentation for the trace library is kind of limited. If you don't mind, I have another question: Would it be useful to have an API to register a callback (to save trace data) when the buffer is full? On Fri, Nov 29, 2024 at 6:44 AM Thomas Mon

[PATCH] crypto/openssl: fix CMAC auth context update

2024-11-29 Thread Wathsala Vithanage
This patch removes an unnecessary cleanup of the shared CMAC context at the end of the CMAC authentication function, which causes subsequent calls to it to fail. Fixes: 17d5bc6135af ("crypto/openssl: make per-QP auth context clones") Cc: sta...@dpdk.org Signed-off-by: Wathsala Vithanage Reviewed

Re: [PATCH v3] doc: reword sample app guides

2024-11-29 Thread Thomas Monjalon
14/10/2024 19:03, Nandini Persad: > I have reviewed these sections for grammar/clarity > and made small modifications to the formatting of sections > to adhere to a template which will create uniformality > in the sample application user guides overall. > > Signed-off-by: Nandini Persad > Acked-b

Re: [PATCH dpdk] log: fix double free on cleanup

2024-11-29 Thread Stephen Hemminger
On Fri, 29 Nov 2024 17:10:14 +0100 Robin Jarry wrote: > Fix the following crash when closing a log file after rte_eal_cleanup(): > > double free or corruption (!prev) > > Thread 1 "grout" received signal SIGABRT, Aborted. > __pthread_kill_implementation (threadid=, > signo=signo

Re: [PATCH dpdk] log: fix double free on cleanup

2024-11-29 Thread Stephen Hemminger
On Fri, 29 Nov 2024 17:10:14 +0100 Robin Jarry wrote: > @@ -550,11 +555,8 @@ eal_log_init(const char *id) > void > rte_eal_log_cleanup(void) > { > - FILE *log_stream = rte_logs.file; > - > - /* don't close stderr on the application */ > - if (log_stream != NULL) > - fcl

Re: [PATCH] power/amd_uncore: add e-smi installation instructions

2024-11-29 Thread Stephen Hemminger
On Fri, 29 Nov 2024 04:32:07 + Sivaprasad Tummala wrote: > Added section for installing and building the E-SMI library > for AMD EPYC Uncore support and version requirements. > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/prog_guide/power_man.rst | 32

[PATCH dpdk] log: fix double free on cleanup

2024-11-29 Thread Robin Jarry
Fix the following crash when closing a log file after rte_eal_cleanup(): double free or corruption (!prev) Thread 1 "grout" received signal SIGABRT, Aborted. __pthread_kill_implementation (threadid=, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 ... #10

Re: [PATCH v2] doc/multi-process: fix grammar and phrasing

2024-11-29 Thread Thomas Monjalon
05/10/2024 00:10, Stephen Hemminger: > Simplify awkward wording in description of the multi process > application. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/sample_app_ug/multi_process.rst | 168 - > 1 file changed, 61 insertions(+), 107 deletions(-) Applied wi

Re: [PATCH v3 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-29 Thread Thomas Monjalon
27/11/2024 10:13, Anatoly Burakov: > Currently, when binding a device to VFIO, the UID/GID for the device will > always stay as system default (`root`). Yet, when running DPDK as non-root > user, one has to change the UID/GID of the device to match the user's > UID/GID to use the device. > > This

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread David Marchand
On Fri, Nov 29, 2024 at 10:52 AM Anatoly Burakov wrote: > > On some systems (particularly ones with NUMA disabled in BIOS), even > though NUMA nodes may be present in sysfs, the lspci command will not > have NUMANode keys in them, which will cause an exception. Fix to check > if NUMANode keys are

Re: [PATCH v1 1/1] usertools/devbind: fix missing active marker

2024-11-29 Thread David Marchand
On Fri, Nov 29, 2024 at 9:05 AM Robin Jarry wrote: > Anatoly Burakov, Nov 27, 2024 at 16:42: > > When adding NUMA node printouts, the "*Active*" marker was accidentally > > omitted. Add it back in. > > > > Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node") > > > > Signed-off-by: Ana

Re: [PATCH v4] dts: remove nested html dir for API doc

2024-11-29 Thread Thomas Monjalon
29/11/2024 13:15, Paul Szczepanek: > > On 29/11/2024 11:54, Thomas Monjalon wrote: > > From: Paul Szczepanek > > > > To facilitate deploying docs to the website > > and make paths more consistent remove the html > > directory from docs nested in API html directory. > > > > Signed-off-by: Paul S

Re: [PATCH v4] dts: remove nested html dir for API doc

2024-11-29 Thread Paul Szczepanek
On 29/11/2024 11:54, Thomas Monjalon wrote: > From: Paul Szczepanek > > To facilitate deploying docs to the website > and make paths more consistent remove the html > directory from docs nested in API html directory. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Luca Vizzarro > Signed-o

[PATCH v4] dts: remove nested html dir for API doc

2024-11-29 Thread Thomas Monjalon
From: Paul Szczepanek To facilitate deploying docs to the website and make paths more consistent remove the html directory from docs nested in API html directory. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro Signed-off-by: Thomas Monjalon --- v4: fix custom.css path and reword a

Re: When the trace buffers are saved to disk?

2024-11-29 Thread Thomas Monjalon
28/11/2024 20:17, Adel Belkhiri: > Hi all, > > Recently, while tracing applications from the apps and examples > directories, I became confused about when the trace buffer is written to > disk. Is the trace data saved only when rte_save_trace() is called, or does It is rte_trace_save() > it also

Re: [PATCH v3] dts: remove html dir from nested docs

2024-11-29 Thread Thomas Monjalon
29/11/2024 00:05, Paul Szczepanek: > To facilitate deploying docs to the website > and make paths more consistent remove the html > directory from docs nested in html directories. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Luca Vizzarro > --- > buildtools/call-sphinx-build.py | 6 --

Re: [PATCH] power/amd_uncore: add e-smi installation instructions

2024-11-29 Thread Thomas Monjalon
29/11/2024 05:32, Sivaprasad Tummala: > Added section for installing and building the E-SMI library > for AMD EPYC Uncore support and version requirements. > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/prog_guide/power_man.rst | 32 + > 1 file changed, 32 i

[PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Anatoly Burakov
On some systems (particularly ones with NUMA disabled in BIOS), even though NUMA nodes may be present in sysfs, the lspci command will not have NUMANode keys in them, which will cause an exception. Fix to check if NUMANode keys are available in lspci output before enabling NUMA node output. Fixes:

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/29/2024 10:12 AM, Burakov, Anatoly wrote: On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +    # occasionally, system may report NUMA support but lspci will not, so we +    # want to go through all devices and see if any of them

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +# occasionally, system may report NUMA support but lspci will not, so we +# want to go through all devices and see if any of them do not have NUMANode +# property - this will

Re: [PATCH v3 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-29 Thread Robin Jarry
Anatoly Burakov, Nov 27, 2024 at 10:13: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device. This patch

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Robin Jarry
Anatoly Burakov, Nov 28, 2024 at 17:08: On some systems, even though NUMA nodes may be present in sysfs, the lspci command will not have NUMANode keys in them, which will cause an exception. Fix to check if NUMANode keys are available in lspci output before enabling NUMA node output. Fixes: a7d6

Re: [PATCH v1 1/1] usertools/devbind: fix missing active marker

2024-11-29 Thread Robin Jarry
Anatoly Burakov, Nov 27, 2024 at 16:42: When adding NUMA node printouts, the "*Active*" marker was accidentally omitted. Add it back in. Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node") Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry