[PATCH v6 08/20] gro: fix overwrite unprocessed packets

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v6 01/20] eal: include header required for alloca

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

[PATCH v6 02/20] eal/linux: remove use of VLAs

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v6 00/20] remove use of VLAs for Windows

2024-11-08 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v6 19/20] test: remove use of VLAs for Windows built code in bitset tests

2024-11-08 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v6 18/20] build: enable vla warnings on Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v6 20/20] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2024-11-08 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v6 15/20] net/i40e: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/i40e/i40e_testpmd.c | 5 ++-

[PATCH v6 10/20] net/ixgbe: remove use of VLAs

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v6 09/20] gro: remove use of VLAs

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v6 11/20] net/ice: remove use of VLAs

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v6 12/20] app/testpmd: remove use of VLAs for Windows built

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v6 13/20] test: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v6 16/20] common/mlx5: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v6 17/20] net/mlx5: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v6 14/20] common/idpf: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v6 06/20] hash/thash: remove use of VLAs for Windows built

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v6 07/20] rcu: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v6 05/20] hash: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v6 04/20] ethdev: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v6 03/20] eal/common: remove use of VLAs

2024-11-08 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

Re: [PATCH 0/2] gpudev: annotate memory allocation

2024-11-08 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:58:02 -0700 Stephen Hemminger wrote: > Use function attributes to catch misuse of GPU memory > at compile time. > > Stephen Hemminger (2): > test-gpudev: avoid use-after-free and free-non-heap warnings > gpudev: add malloc annotations to rte_gpu_mem_alloc > > app/tes

RE: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Friday, 8 November 2024 23.23 > > On 2024-11-08 20:53, Morten Brørup wrote: > >> From: Morten Brørup [mailto:m...@smartsharesystems.com] > >> Sent: Friday, 8 November 2024 19.35 > >> > >>> From: David Marchand [mailto:david.march...@r

Re: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Thomas Monjalon
08/11/2024 23:34, Mattias Rönnblom: > On 2024-11-08 23:13, Thomas Monjalon wrote: > > 08/11/2024 20:53, Morten Brørup: > >>> From: Morten Brørup [mailto:m...@smartsharesystems.com] > >>> Sent: Friday, 8 November 2024 19.35 > >>> > From: David Marchand [mailto:david.march...@redhat.com] >

RE: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, 8 November 2024 23.13 > Let's consider based on the need. > The lcore variables are new and we don't want it to degrade the DPDK > footprint, > at least not in this first version. > 4 KB is a memory page on common systems, > it l

Re: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 23:13, Thomas Monjalon wrote: 08/11/2024 20:53, Morten Brørup: From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Friday, 8 November 2024 19.35 From: David Marchand [mailto:david.march...@redhat.com] Sent: Friday, 8 November 2024 19.18 OVS locks all pages to avoid pag

Re: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 20:53, Morten Brørup wrote: From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Friday, 8 November 2024 19.35 From: David Marchand [mailto:david.march...@redhat.com] Sent: Friday, 8 November 2024 19.18 OVS locks all pages to avoid page faults while processing packets.

Re: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Thomas Monjalon
08/11/2024 20:53, Morten Brørup: > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Friday, 8 November 2024 19.35 > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Friday, 8 November 2024 19.18 > > > > > > OVS locks all pages to avoid page faults whil

Re: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 19:17, David Marchand wrote: OVS locks all pages to avoid page faults while processing packets. 1M for each lcore translates to allocating 128M with default build options on x86. This resulted in OOM while running unit tests in parallel. Could you give some more context. If you g

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Thomas Monjalon
08/11/2024 16:43, Mattias Rönnblom: > On 2024-11-08 14:08, Thomas Monjalon wrote: > > The memory allocated with _aligned_malloc() > > must be released with _aligned_free() on Windows. > > > > The POSIX free() was called in eal_lcore_var_cleanup(), > > Referring to free() as a part of POSIX is tru

Re: [PATCH v8 0/7] Stage-Ordered API and other extensions for ring library

2024-11-08 Thread Thomas Monjalon
> Konstantin Ananyev (6): > test/ring: fix failure with custom number of lcores > ring: common functions for 'move head' ops > ring: make copying functions generic > ring/soring: introduce Staged Ordered Ring > app/test: add unit tests for soring API > test: add stress test suite This

Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
On Fri, Nov 08, 2024 at 10:18:31AM +, Konstantin Ananyev wrote: > > > > > > Title for this patch is incorrect. Does it belong merged with the next > > patch in series? > > Yes, seems like oringianl title get lost, I think it needs to be: > gro: fix overwrite unprocessed packets > https://pa

Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code

2024-11-08 Thread Andre Muezerie
On Fri, Nov 08, 2024 at 08:51:00AM +, Bruce Richardson wrote: > Title for this patch is incorrect. Does it belong merged with the next > patch in series? Indeed, I used the wrong title for this patch. I'll fix it in v6. > > On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote: > > Fr

RE: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Friday, 8 November 2024 19.35 > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 8 November 2024 19.18 > > > > OVS locks all pages to avoid page faults while processing packets. It sounds smart, so I ju

RE: [PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, 8 November 2024 19.18 > > OVS locks all pages to avoid page faults while processing packets. > 1M for each lcore translates to allocating 128M with default build > options on x86. > This resulted in OOM while running unit te

[PATCH] config: limit lcore variable maximum size to 4k

2024-11-08 Thread David Marchand
OVS locks all pages to avoid page faults while processing packets. 1M for each lcore translates to allocating 128M with default build options on x86. This resulted in OOM while running unit tests in parallel. At the moment, the more demanding DPDK user of lcore variable is rte_service, with a 2112

RE: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 8 November 2024 17.01 > > On Fri, 8 Nov 2024 14:08:21 +0100 > Thomas Monjalon wrote: > > > The memory allocated with _aligned_malloc() > > must be released with _aligned_free() on Windows. > > > > The POSIX free() was

Re: [PATCH v32 00/12] Log library enhancements

2024-11-08 Thread David Marchand
On Fri, Nov 8, 2024 at 9:57 AM David Marchand wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > > * Putting a timestamp

[PATCH v3 3/3] dts: add l2fwd test suite

2024-11-08 Thread Luca Vizzarro
Add a basic L2 forwarding test suite which tests the correct functionality of the forwarding facility built-in in the DPDK. The tests are performed with different queues numbers per port. Signed-off-by: Luca Vizzarro Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek Reviewed-by: Dean Ma

[PATCH v3 2/3] dts: allow to get multiple expected packets

2024-11-08 Thread Luca Vizzarro
At the moment there is only one facility that allows to prepare a packet as it is expected to be received on the traffic generator end. Extend this to allow to prepare multiple packets at the same time. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/test_suite.py |

[PATCH v3 1/3] dts: fix adjust L2/L3 addresses behavior

2024-11-08 Thread Luca Vizzarro
The _adjust_addresses function has been updated to both modify the original packets and return new updated copies of them. Having a double behavior even if documented is not intuitive and can lead to bugs. This changes the behavior to solely act on copies, leaving the original packet untouched. F

[PATCH v3 0/3] dts: add l2fwd test suite

2024-11-08 Thread Luca Vizzarro
Hi there, sending in a v3 for l2fwd. v3: - addressed comments for docstrings - make use of @requires - add a get_expected_packet version for multiple packets - fix an inconsistency bug with _adjust_addresses - rebased v2: - added copyright - rebased Best, Luca Depends-on: series-33871 ("dts: Py

Re: [PATCH] dts: remove external dependency on python docs

2024-11-08 Thread Patrick Robb
Reviewed-by: Patrick Robb

[PATCH] dts: remove external dependency on python docs

2024-11-08 Thread Paul Szczepanek
Sphinx can link to online python docs but doing so creates a requirement for an internet connection. This commit removes this dependency. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- doc/guides/conf.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/

RE: [PATCH v2 07/10] net/mlx5: add legacy unicast flow rules management

2024-11-08 Thread Dariusz Sosnowski
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 8, 2024 15:48 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 07/10] net/mlx5: add legacy unicast flow rules > management >

Re: strange DPDK memory allocator behavior

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 17:08, Mattias Rönnblom wrote: On 2024-11-08 16:03, Thomas Monjalon wrote: Hello, After merging the lcore variables allocation from Mattias, we've seen an issue in unit tests running on 32-bit plaftorms: https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/ dpdk/

Re: strange DPDK memory allocator behavior

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 16:03, Thomas Monjalon wrote: Hello, After merging the lcore variables allocation from Mattias, we've seen an issue in unit tests running on 32-bit plaftorms: https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_Testing/i586 The initialization has

[PATCH] net/mlx5: fix MAC address initialization

2024-11-08 Thread Dariusz Sosnowski
Offending patch added code which broke compilation on GCC 15, where MAC address was initialized with a string, causing the following errors: ../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_flow_create’: ../drivers/net/mlx5/mlx5_flow.c:8568:44: error: initializer-string for array

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Stephen Hemminger
On Fri, 8 Nov 2024 14:08:21 +0100 Thomas Monjalon wrote: > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 32

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 14:08, Thomas Monjalon wrote: The memory allocated with _aligned_malloc() must be released with _aligned_free() on Windows. The POSIX free() was called in eal_lcore_var_cleanup(), Referring to free() as a part of POSIX is true, but a bit misleading, since it's also standard C.

strange DPDK memory allocator behavior

2024-11-08 Thread Thomas Monjalon
Hello, After merging the lcore variables allocation from Mattias, we've seen an issue in unit tests running on 32-bit plaftorms: https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_Testing/i586 The initialization has this error message "most of the time":

Re: [PATCH v2 07/10] net/mlx5: add legacy unicast flow rules management

2024-11-08 Thread Ferruh Yigit
On 10/22/2024 1:06 PM, Dariusz Sosnowski wrote: > This patch adds the following internal functions for creation of > unicast DMAC flow rules: > > - mlx5_legacy_dmac_flow_create() - simple wrapper over > mlx5_ctrl_flow(). > - mlx5_legacy_dmac_vlan_flow_create() - simple wrapper over > mlx5_ctrl

Re: [PATCH v5 00/25]

2024-11-08 Thread David Marchand
On Fri, Nov 8, 2024 at 12:15 PM Jie Hai wrote: > > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >

Re: [PATCH v2 2/2] dts: add blocklist test suite

2024-11-08 Thread Luca Vizzarro
On 07/11/2024 20:33, Nicholas Pratte wrote: Hi Luca, nice work! See my small comment below/ I ran some local tests and everything seems to be working fine, so other than that minor fix I pointed out, the rest should be all set! Good suggestion, I've changed it a little bit now. Thanks!

Re: [PATCH v2 0/2] gpudev: annotate memory allocation functions

2024-11-08 Thread David Marchand
On Mon, Oct 28, 2024 at 8:03 PM Stephen Hemminger wrote: > > Use function attributes to catch misuse of GPU memory > at compile time. > > v2 - remove test case where invalid pointer was being passed. > The test is now caught at compile time, making a runtime test > no longer necessary. >

Re: [PATCH v2 1/2] dts: add blocked ports to EalParams

2024-11-08 Thread Luca Vizzarro
On 07/11/2024 19:04, Nicholas Pratte wrote: Hi Luca, this looks good to me! The only thing that needs to be fixed is the attributes component of the docstring for EalParams in eal.py. Aside from that: Reviewed-by: Nicholas Pratte Great, catch! Thanks!

Re: [PATCH v2] test/fib: clarify FIB RCU negative tests

2024-11-08 Thread David Marchand
On Thu, Nov 7, 2024 at 6:04 PM Vladimir Medvedkin wrote: > > Add additional negative tests for rte_fib_rcu_qsbr_add(). > Also explicitly check returned codes. > Additionally add a check into the rte_fib_rcu_qsbr_add() > for passed fib argument. > > Signed-off-by: Vladimir Medvedkin I kept Stephe

[PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-08 Thread Luca Vizzarro
Allow test suites to be configured individually. Moreover enable them to implement their own custom configuration. This solution adds some new complexity to DTS, which is generated source code. In order to ensure strong typing, the test suites and their custom configurations need to be linked in t

[PATCH v3 1/4] dts: add tests package to API docs

2024-11-08 Thread Luca Vizzarro
The test suites are not documented in the API as their respective documentation files are missing. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/api/dts/index.rst | 1 + doc/api/dts/tests.TestSuite_hello_world.rst | 9 + doc/api/dts/tests.

[PATCH v3 0/4] dts: add per-test-suite configuration

2024-11-08 Thread Luca Vizzarro
Hi there, sending a v3 for the per-test-suite configuration additions. v3: - fixed bug in dts-check-format v2: - rebase - added test suites to doc pages - doc fixes - updated the custom config procedure to using tests.config - simplified the generated file - implemented the generator in dts-check

[PATCH v3 4/4] dts: update autodoc sorting order

2024-11-08 Thread Luca Vizzarro
The autodoc member sorting order default is set to alphabetical, which translates to autodoc sorting every member in modules, classes etc. This also brings some side effects, like sorting capabilities which can't be compared and result in errors. This change prevents autodoc from sorting, and keep

[PATCH v3 2/4] dts: fix smoke tests docstring

2024-11-08 Thread Luca Vizzarro
Sphinx autodoc complains of is_blocking being duplicated. This is the case as the parent already holds a docstring for this attribute. Remove the duplication. Fixes: 6ef07151aac4 ("dts: update docstrings") Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_smoke_

RE: [PATCH v4 02/19] eal/linux: remove use of VLAs

2024-11-08 Thread Konstantin Ananyev
> On Tue, Nov 05, 2024 at 09:19:25AM +0100, David Marchand wrote: > > Hello Andre, > > > > Thanks for taking over this series. > > > > On Tue, Nov 5, 2024 at 4:18 AM Andre Muezerie > > wrote: > > > > > > From: Konstantin Ananyev > > > > > > 1) ./lib/eal/linux/eal_interrupts.c:1073:16 > > >

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Dmitry Kozlyuk
2024-11-08 14:08 (UTC+0100), Thomas Monjalon: > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 3221226356 or si

[PATCH v2 4/4] dts: update autodoc sorting order

2024-11-08 Thread Luca Vizzarro
The autodoc member sorting order default is set to alphabetical, which translates to autodoc sorting every member in modules, classes etc. This also brings some side effects, like sorting capabilities which can't be compared and result in errors. This change prevents autodoc from sorting, and keep

[PATCH v2 3/4] dts: add per-test-suite configuration

2024-11-08 Thread Luca Vizzarro
Allow test suites to be configured individually. Moreover enable them to implement their own custom configuration. This solution adds some new complexity to DTS, which is generated source code. In order to ensure strong typing, the test suites and their custom configurations need to be linked in t

[PATCH v2 2/4] dts: fix smoke tests docstring

2024-11-08 Thread Luca Vizzarro
Sphinx autodoc complains of is_blocking being duplicated. This is the case as the parent already holds a docstring for this attribute. Remove the duplication. Fixes: 6ef07151aac4 ("dts: update docstrings") Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_smoke_

[PATCH v2 1/4] dts: add tests package to API docs

2024-11-08 Thread Luca Vizzarro
The test suites are not documented in the API as their respective documentation files are missing. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/api/dts/index.rst | 1 + doc/api/dts/tests.TestSuite_hello_world.rst | 9 + doc/api/dts/tests.

[PATCH v2 0/4] dts: add per-test-suite configuration

2024-11-08 Thread Luca Vizzarro
Hi there, sending a v2 for the per-test-suite configuration additions. v2: - rebase - added test suites to doc pages - doc fixes - updated the custom config procedure to using tests.config - simplified the generated file - implemented the generator in dts-check-format Best regards, Luca Vizzarro

Re: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

2024-11-08 Thread David Marchand
Hello Jerin, On Fri, Nov 8, 2024 at 1:22 PM Jerin Jacob wrote: > > > Is n't breaking the ABI? > > > > So can't we modify the ABI, or is there any special operation required to > > modify > > the ABI? > > Only LTS release (xx.11) can change the ABI after sending deprecation notice. > Looking at t

RE: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Morten Brørup
Reviewed-by: Morten Brørup

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread David Marchand
On Fri, Nov 8, 2024 at 2:08 PM Thomas Monjalon wrote: > > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 322122

[PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Thomas Monjalon
The memory allocated with _aligned_malloc() must be released with _aligned_free() on Windows. The POSIX free() was called in eal_lcore_var_cleanup(), called in rte_eal_cleanup(), and triggered a heap corruption: exit status 3221226356 or signal 3221226228 SIGinvalid with MALLOC_PERTURB_=86 Fixes:

[PATCH v6 02/17] net/r8169: add logging structure

2024-11-08 Thread Howard Wang
Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 9 +++ drivers/net/r8169/r8169_logs.h | 46 2 files changed, 55 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h diff --git a/dr

RE: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

2024-11-08 Thread Jerin Jacob
> -Original Message- > From: Huichao Cai > Sent: Friday, November 8, 2024 7:10 AM > To: Jerin Jacob > Cc: Kiran Kumar Kokkilagadda ; Nithin Kumar > Dabilpuram ; yanzhirun_...@163.com; > dev@dpdk.org > Subject: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when > scheduling nod

[PATCH v6 17/17] net/r8169: add driver_start and driver_stop

2024-11-08 Thread Howard Wang
rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_compat.h | 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v6 16/17] net/r8169: add support for getting fw version

2024-11-08 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini index 3bcba23ea5..8e4142f64e 100644 ---

[PATCH v6 15/17] net/r8169: implement MTU configuration

2024-11-08 Thread Howard Wang
Add support for updating MTU value. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini ind

[PATCH v6 13/17] net/r8169: implement device statistics

2024-11-08 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 3 ++ drivers/net/r8169/r8169_compat.h | 16 ++ drivers/net/r8169/r8169_ethdev.c | 48 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 ++

[PATCH v6 14/17] net/r8169: implement promisc and allmulti modes

2024-11-08 Thread Howard Wang
Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 4 ++ drivers/net/r8169/r8169_ethdev.c | 67 ++ 2 files changed, 71 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/d

[PATCH v6 12/17] net/r8169: implement Tx path

2024-11-08 Thread Howard Wang
Add implementation for TX datapath. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 6 +- doc/guides/nics/r8169.rst | 1 + drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 682 +++

[PATCH v6 11/17] net/r8169: implement Rx path

2024-11-08 Thread Howard Wang
Add implementation for RX datapath. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 12 + doc/guides/nics/r8169.rst | 8 + drivers/net/r8169/r8169_compat.h | 24 + drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers

[PATCH v6 10/17] net/r8169: add link status and interrupt management

2024-11-08 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 4 + drivers/net/r8169/r8169_compat.h | 1 + drivers/net/r8169/r8169_ethdev.c | 278 - drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169

[PATCH v6 09/17] net/r8169: add support for hw initialization

2024-11-08 Thread Howard Wang
This patch initializes software variables, resets the NIC, and performs other hw initialization tasks. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h | 39 +++ drivers/net/r8169/r8169_dash.c | 86 + drivers/net/r8169/r8169_dash.h

[PATCH v6 08/17] net/r8169: add support for phy configuration

2024-11-08 Thread Howard Wang
This patch contains phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 15 +- drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 449 +++ drivers/net/r8169/r8169_phy.h| 100 +++ 4 fil

[PATCH v6 06/17] net/r8169: add phy registers access routines

2024-11-08 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_hw.c | 2 +- drivers/net/r8169/r8169_phy.c| 219 +++ drivers/net/r8169/r8169_phy.h| 18 +++ 4 files changed, 239 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v6 05/17] net/r8169: add support for hw config

2024-11-08 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 4 + drivers/net/r8169/r8169_ethdev.h | 13 +- drivers/net/r8169/r8169_hw.

[PATCH v6 04/17] net/r8169: implement core logic for Tx/Rx

2024-11-08 Thread Howard Wang
Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 20 ++- drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_rxtx.c | 43 ++

[PATCH v6 01/17] net/r8169: add PMD driver skeleton

2024-11-08 Thread Howard Wang
Meson build infrastructure, r8169_ethdev minimal skeleton, header with Realtek NIC device and vendor IDs. Signed-off-by: Howard Wang --- MAINTAINERS| 8 ++ doc/guides/nics/features/r8169.ini | 9 ++ doc/guides/nics/index.rst | 1 + doc/guides/ni

[PATCH v6 03/17] net/r8169: add hardware registers access routines

2024-11-08 Thread Howard Wang
Add implementation for hardware registers access routines such as mmio read/write, mac ocp read/write, csi read/write and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h | 377 +++ drivers/net/r8169/r816

[PATCH v6 00/17] Modify code as suggested by the maintainer.

2024-11-08 Thread Howard Wang
Remove some headers and code that are not used. Improve r8169.ini and r8169.rst gradually. Howard Wang (17): net/r8169: add PMD driver skeleton net/r8169: add logging structure net/r8169: add hardware registers access routines net/r8169: implement core logic for Tx/Rx net/r8169: add supp

RE: [PATCH v15 4/4] eal: add PMU support to tracing library

2024-11-08 Thread Tomasz Duszynski
>> In order to profile app one needs to store significant amount of >> samples somewhere for an analysis later on. Since trace library >> supports storing data in a CTF format lets take advantage of that and >> add a dedicated PMU tracepoint. >> >> Signed-off-by: Tomasz Duszynski >> --- >> app/te

[PATCH v6 8/9] dts: fix custom enum behaviour with docs

2024-11-08 Thread Luca Vizzarro
When building docs without any dependencies, autodoc will mock all the packages missing from the system. Because DTS makes use of a special enum library called aenum, autodoc fails to recognise enum inheriting it as such and raises exceptions as a consequence. This change extends the already in-pl

[PATCH v6 9/9] dts: use TestSuiteSpec class imports

2024-11-08 Thread Luca Vizzarro
The introduction of TestSuiteSpec adds auto-discovery of test suites, which are also automatically imported. This causes double imports as the runner loads the test suites. This changes the behaviour of the runner to load the imported classes from TestSuiteSpec instead of importing them again. Sig

[PATCH v6 6/9] dts: add autodoc pydantic

2024-11-08 Thread Luca Vizzarro
Add and enable the autodoc-pydantic sphinx extension. Pydantic models are not correctly recognised by autodoc, causing the generated docs to lack all the actual model information. The autodoc-pydantic sphinx extension fixes the original behaviour by correctly formatting them. Signed-off-by: Luca V

[PATCH v6 7/9] dts: improve configuration API docs

2024-11-08 Thread Luca Vizzarro
Pydantic models are not treated the same way as dataclasses by autodoc. As a consequence the docstrings need to be applied directly to each field. Otherwise the generated API documentation page would present two entries per each field with each their own differences. Signed-off-by: Luca Vizzarro

[PATCH v6 4/9] dts: use pydantic in the configuration

2024-11-08 Thread Luca Vizzarro
This change brings in pydantic in place of warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further validation is added to verify: - cross referenci

[PATCH v6 5/9] dts: remove warlock dependency

2024-11-08 Thread Luca Vizzarro
Since pydantic has completely replaced warlock, there is no more need to keep it as a dependency. This removes it. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Nicholas Pratte Reviewed-by: Patrick Robb --- dts/poetry.lock| 227 +---

[PATCH v6 3/9] dts: refactor build and node info classes

2024-11-08 Thread Luca Vizzarro
The DPDKBuildInfo and NodeInfo classes, representing information gathered in runtime, were erroneously placed in the configuration package. This moves them in more appropriate modules. NodeInfo, specifically, is moved to os_session instead of node mostly as a consequence of circular dependencies.

[PATCH v6 2/9] dts: add TestSuiteSpec class and discovery

2024-11-08 Thread Luca Vizzarro
Currently there is a lack of a definition which identifies all the test suites available to test. This change intends to simplify the process to discover all the test suites and identify them. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Nicholas Pratte Reviewed-by: Pa

  1   2   >