RE: [EXTERNAL] Re: [PATCH v15 4/4] eal: add PMU support to tracing library

2024-11-04 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Monday, 28 October 2024 11.32 > > >On Fri, Oct 25, 2024 at 2:25 PM Tomasz Duszynski > wrote: > >> > >> In order to profile app one needs to store significant amount of > >> samples somewhere for an analysis later on. Since trace lib

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

2024-11-04 Thread Ankur Dwivedi
>-Original Message- >From: Ankur Dwivedi >Sent: Monday, October 21, 2024 7:37 PM >To: Stephen Hemminger >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob >Subject: RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in >checkpatch > >>On Wed, 9 Oct 2024 06:03:58 + >>A

RE: [PATCH v15 0/4] add support for self monitoring

2024-11-04 Thread Tomasz Duszynski
>-Original Message- >From: Tomasz Duszynski >Sent: Friday, October 25, 2024 10:54 AM >To: Tomasz Duszynski >Cc: ruifeng.w...@arm.com; bruce.richard...@intel.com; >david.march...@redhat.com; dev@dpdk.org; >Jerin Jacob ; konstantin.v.anan...@yandex.ru; >mattias.ronnb...@ericsson.com; >m..

RE: [PATCH] doc: update match with compare result item limitation

2024-11-04 Thread Bing Zhao
The ` repr_matching_en ` flag is enabled (by default) can be added. > -Original Message- > From: Suanming Mou > Sent: Tuesday, November 5, 2024 9:48 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH]

[PATCH v4 13/19] net/ice: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/ice_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v4 19/19] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2024-11-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v4 16/19] net/mlx5: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v4 14/19] net/ixgbe: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++-- drivers/net/ixgbe

[PATCH v4 17/19] build: enable vla warnings on Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests

2024-11-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test/test_bitset.c | 55 +++-- app/test/test_reassem

[PATCH v4 12/19] net/i40e: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_testpmd.c | 5 ++--- 1 file changed, 2 insertion

[PATCH v4 15/19] common/mlx5: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v4 09/19] app/testpmd: remove use of VLAs for Windows built

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v4 10/19] test: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v4 06/19] hash/thash: remove use of VLAs for Windows built

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v4 02/19] eal/linux: remove use of VLAs

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ eal_intr_handle_interrupts() is called by eal_intr_thread_main() so it seems ok to simply alloc space for events from heap and reuse the same buffer through the life

[PATCH v4 08/19] gro: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- lib/gro/rte_gro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v4 04/19] ethdev: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v4 11/19] common/idpf: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/idpf_common_rxtx.c| 2 +- drivers/common/i

[PATCH v4 07/19] rcu: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v4 05/19] hash: remove use of VLAs for Windows built code

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v4 01/19] eal: include header required for alloca

2024-11-04 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

[PATCH v4 03/19] eal/common: remove use of VLAs

2024-11-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

[PATCH v4 00/19] remove use of VLAs for Windows

2024-11-04 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

RE: [PATCH v2] net/ice: fix wrong DDP search path

2024-11-04 Thread Li, HongboX
> -Original Message- > From: Zhichao Zeng > Sent: Monday, November 4, 2024 6:10 PM > To: dev@dpdk.org > Cc: Zeng, ZhichaoX ; Richardson, Bruce > ; Burakov, Anatoly > > Subject: [PATCH v2] net/ice: fix wrong DDP search path > > In the previous implementation, when the user did not enter a

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Varghese, Vipin
Snipped > > > > > > I recall from the Cache Stashing community call... There is some > > > ACPI > > function to > > > get the (opaque) "location IDs" of various parts in the system, to > > > be > > used for setting > > > the Cache Stashing hints. > > > Is there only one "ACPI location ID" (I don't

[PATCH] doc: update match with compare result item limitation

2024-11-04 Thread Suanming Mou
In switch mode, when ``repr_matching_en`` flag is enabled in the devarg, the match with compare result item is not supported to the ``ingress`` rule as an implicit REPRESENTED_PORT need to be added to the matcher. That REPRESENTED_PORT item conflicts with the single item limitation for match with c

Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-11-04 Thread Thomas Monjalon
04/11/2024 12:46, Junlong Wang: > > >>> net/zxdh: add zxdh get device backend infos > > >>> net/zxdh: add configure zxdh intr implementation > > >>> net/zxdh: add zxdh dev infos get ops > > >>> net/zxdh: add zxdh dev configure ops > > >>> > > > > > >> Hi Junlong, > > > > > >> I can see not

Re: [PATCH v3 2/2] net/vmxnet3: support larger MTU with version 6

2024-11-04 Thread Jochen Behrens
Hi Morten, thanks for fixing the MTU setting! Acked-by: Jochen Behrens jochen.behr...@broadcom.com On 11/4/24 02:52, Morten Brørup wrote: Virtual hardware version 6 supports larger max MTU, but the device information (dev_info) did not reflect this, so it could not be used. Fixes: b1584dd0aff

Re: [PATCH] dts: improve statistics

2024-11-04 Thread Dean Marx
Adding Luca to this thread because it applies to him as well: Hi Tomáš, This all looks great, one thing I did notice when running locally is that the "test_suites" section of results.json contains null values instead of the names of the suites that were run. Could just be something strange happen

Re: [PATCH v5 00/52] replace strerror

2024-11-04 Thread Stephen Hemminger
On Mon, 4 Nov 2024 19:09:45 +0800 Dengdui Huang wrote: > The function strerror() is insecure in a multi-thread environment. > It is better to use strerror_r() instead of strerror(). > In addition, rte_errno should obtain the error description through > rte_strerror() instead of strerror(). > In

Re: [PATCH v4 00/42] replace strerror

2024-11-04 Thread Stephen Hemminger
On Wed, 23 Oct 2024 16:28:10 +0800 Dengdui Huang wrote: > The function strerror() is insecure in a multi-thread environment. > It is better to use rte_strerror() instead of strerror(). > In this patchset, only the libs and drivers are modified. > > chang log: > v3->v4 fix ci error > v2->v3 drop

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-11-04 Thread David Marchand
Hello Luca, On Sat, Nov 2, 2024 at 11:09 AM David Marchand wrote: > > On Thu, Oct 31, 2024 at 9:46 PM Stephen Hemminger > wrote: > > > > On Thu, 31 Oct 2024 14:05:16 + > > Luca Boccassi wrote: > > > > > On Thu, 31 Oct 2024 at 13:04, David Marchand > > > wrote: > > > > > > > > On Thu, Oct

Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-11-04 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Thu, Oct 10, 2024 at 2:42 PM Dean Marx wrote: > > Fix optional verify argument in set_forward_mode > method in testpmd shell class. > > Bugzilla ID: 1410 > Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") > > Signed-off-by: Dean Marx > --- > dts/framework/r

Re: [PATCH v4 8/8] dts: use TestSuiteSpec class imports

2024-11-04 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > The introduction of TestSuiteSpec adds auto-discovery of test suites, > which are also automatically imported. This causes double imports as the > runner loads the test suites. This changes the behaviour of the

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-11-04 Thread Nicholas Pratte
Noted, I appreciate the insight! On Tue, Oct 29, 2024 at 8:56 AM Luca Vizzarro wrote: > > On 01/10/2024 21:45, Nicholas Pratte wrote: > > The code you have here makes sense, and I like the implementation as > > it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an > > earlier patch

Re: Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Bruce Richardson
On Mon, Nov 04, 2024 at 08:15:00AM -0800, Stephen Hemminger wrote: > On Mon, 4 Nov 2024 13:11:02 +0100 > Morten Brørup wrote: > > > Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the > > destination as the second parameter. > > > > Not following well established conventio

Re: [PATCH v4 7/8] dts: improve configuration API docs

2024-11-04 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > Pydantic models are not treated the same way as dataclasses by autodoc. > As a consequence the docstrings need to be applied directly to each > field. Otherwise the generated API documentation page would presen

Re: [PATCH v4] eal/unix: optimize thread creation

2024-11-04 Thread David Marchand
On Mon, Nov 4, 2024 at 9:57 AM David Marchand wrote: > > Setting the cpu affinity of the child thread from the parent thread is > racy when using pthread_setaffinity_np, as the child thread may start > running and initialize before affinity is set. > > On the other hand, setting the cpu affinity f

[PATCH] net/mlx5: fix the Rx queue control management

2024-11-04 Thread Bing Zhao
With the shared Rx queue feature introduced, the control and private Rx queue structures are decoupled, each control structure can be shared for multiple queue for all representors inside a domain. So it should be only managed by the shared context instead of any private data of each device. The p

Re: Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Stephen Hemminger
On Mon, 4 Nov 2024 13:11:02 +0100 Morten Brørup wrote: > Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the > destination as the second parameter. > > Not following well established conventions adds a high risk of causing bugs > in the applications/libraries/drivers; it

Re: [PATCH v2] net/ice: fix wrong DDP search path

2024-11-04 Thread Bruce Richardson
On Mon, Nov 04, 2024 at 06:09:34PM +0800, Zhichao Zeng wrote: > In the previous implementation, when the user did not enter any value in > "/sys/module/firmware_class/parameters/path", it would incorrectly search > for DDP packages under "/". > > This commit fixes this issue. > > Fixes: 9207f9364

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Morten Brørup
> > > > > > Does the API need to be prepared for L4 cache? > > > > > > https://www.anandtech.com/show/16924/did-ibm-just-preview- > the- > > > future > > > > > > - > > > > > of-caches > > > > > Thank you for the pointer, yes initial patch was considering L4 > > > cache > > > > > too. But I was not

[PATCH 2/2] common/cnxk: add mailbox debug trace

2024-11-04 Thread Harman Kalra
Implementing mailbox debug trace points to trace function calls. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_dev.c | 89 -- drivers/common/cnxk/roc_mbox.c | 34 drivers/common/cnxk/roc_mbox.h | 2 + drivers/common/cnxk/roc_platfo

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Varghese, Vipin
Snipped > > > > > > > Does the API need to be prepared for L4 cache? > > > > > https://www.anandtech.com/show/16924/did-ibm-just-preview-the- > > future > > > > > - > > > > of-caches > > > > Thank you for the pointer, yes initial patch was considering L4 > > cache > > > > too. But I was not able

[PATCH 1/2] common/cnxk: fix mailbox timeout issues

2024-11-04 Thread Harman Kalra
Found couple of reasons causing mailbox timeout: * msgs_acked value by interrupt thread was not getting synced to thread polling it. * mbox_data value sent by AF was seen 0 causing neither down nor up msg processing. Fixes: 9bd368ca311a ("common/cnxk: enable PF VF mailbox") Fixes: 61deac72abbf ("c

[PATCH v10 01/10] net/zxdh: add zxdh ethdev pmd driver

2024-11-04 Thread Junlong Wang
Add basic zxdh ethdev init and register PCI probe functions Update doc files. Signed-off-by: Junlong Wang --- MAINTAINERS| 7 ++ doc/guides/nics/features/zxdh.ini | 9 +++ doc/guides/nics/index.rst | 1 + doc/guides/nics/zxdh.rst | 3

[PATCH v10 06/10] net/zxdh: add zxdh get device backend infos

2024-11-04 Thread Junlong Wang
Add zxdh get device backend infos, use msg chan to send msg get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_common.c | 256 + drivers/net/zxdh/zxdh_common.h | 30 drivers/net/zxdh/zxdh_ethdev.c | 37 +

RE: [PATCH 1/2] eal: add unreachable and precondition hints

2024-11-04 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 4 November 2024 13.19 > > On Mon, Nov 04, 2024 at 12:40:49PM +0100, Morten Brørup wrote: > > Ping for review. > > > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > Sent: Friday, 25 October 2024 13.52 > >

[PATCH v10 02/10] net/zxdh: add logging implementation

2024-11-04 Thread Junlong Wang
Add zxdh logging implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 14 -- drivers/net/zxdh/zxdh_logs.h | 34 ++ 2 files changed, 46 insertions(+), 2 deletions(-) create mode 100644 drivers/net/zxdh/zxdh_logs.h diff --

Re: [PATCH v3] net/ice: fix incorrect reading of PHY timestamp

2024-11-04 Thread Bruce Richardson
On Mon, Nov 04, 2024 at 10:31:12AM +, Soumyadeep Hore wrote: > In ICE PMD, previously the ready bitmap checking before reading > PHY timestamp was not present. This caused incorrect Tx > timestamping. > > The ready bitmap checking is enabled and PHY timestamp is read once > the ready bitmap gi

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Morten Brørup
> > > > Does the API need to be prepared for L4 cache? > > > > https://www.anandtech.com/show/16924/did-ibm-just-preview-the- > future > > > > - > > > of-caches > > > Thank you for the pointer, yes initial patch was considering L4 > cache > > > too. But I was not able to get hold of system or get s

Re: [PATCH 1/2] eal: add unreachable and precondition hints

2024-11-04 Thread Bruce Richardson
On Mon, Nov 04, 2024 at 12:40:49PM +0100, Morten Brørup wrote: > Ping for review. > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Friday, 25 October 2024 13.52 > > > > Added two new compiler/optimizer hints: > > * The __rte_unreachable hint for use in points in code known

[PATCH] event/cnxk: fix incorrect template macros

2024-11-04 Thread pbhagavatula
From: Pavan Nikhilesh Fix incorrect template macros used for dual workslot functions. Fixes: a83fc0f4e118 ("event/cnxk: remove single event enqueue and dequeue") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_worker.h | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v10 08/10] net/zxdh: add zxdh dev infos get ops

2024-11-04 Thread Junlong Wang
Add support for zxdh infos get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 45 +- drivers/net/zxdh/zxdh_ethdev.h | 2 ++ 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_et

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Varghese, Vipin
Snipped > > > > Does the API need to be prepared for L4 cache? > > > https://www.anandtech.com/show/16924/did-ibm-just-preview-the-future > > > - > > of-caches > > Thank you for the pointer, yes initial patch was considering L4 cache > > too. But I was not able to get hold of system or get someo

Risk of rte_ether_addr_copy() causing bugs

2024-11-04 Thread Morten Brørup
Unlike memcpy() and other copy functions, rte_ether_addr_copy() takes the destination as the second parameter. Not following well established conventions adds a high risk of causing bugs in the applications/libraries/drivers; it is likely that developers expect copy() functions to take paramete

[PATCH v10 05/10] net/zxdh: add msg chan enable implementation

2024-11-04 Thread Junlong Wang
Add msg chan enable implementation to support send msg to backend(device side) get infos. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 + drivers/net/zxdh/zxdh_ethdev.h | 12 + drivers/net/zxdh/zxdh_msg.c| 657 + drivers/net/zxdh/zxdh_

[PATCH v10 07/10] net/zxdh: add configure zxdh intr implementation

2024-11-04 Thread Junlong Wang
configure zxdh intr include risc,dtb. and release intr. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 315 + drivers/net/zxdh/zxdh_ethdev.h | 6 + drivers/net/zxdh/zxdh_msg.c| 210 ++ drivers/net/zxdh/zxdh_msg.h| 1

[PATCH v10 04/10] net/zxdh: add msg chan and msg hwlock init

2024-11-04 Thread Junlong Wang
Add msg channel and hwlock init implementation Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 15 +++ drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_msg.c| 170 + drivers/net/zxdh/zxdh_m

[PATCH v10 00/10] net/zxdh: introduce net zxdh driver

2024-11-04 Thread Junlong Wang
v10: - move zxdh under Wind River in MAINTAINERS and add myself as the maintainer and add experimental into MAINTAINERS/driver file,elease notes. - changed DPDK syntax is to have return value in a separate line. - Add a keyword in log types for distinguished. - using regular comments (n

[PATCH v10 10/10] net/zxdh: add zxdh dev close ops

2024-11-04 Thread Junlong Wang
provided zxdh dev close ops for resource released. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c index 54e51a31fa.

[PATCH v10 03/10] net/zxdh: add zxdh device pci init implementation

2024-11-04 Thread Junlong Wang
Add device pci init implementation, to obtain PCI capability and read configuration, etc. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 44 + drivers/net/zxdh/zxdh_ethdev.h | 18 ++- drivers/net/zxdh/zxdh_pci.c| 283 +++

[PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-11-04 Thread Junlong Wang
> >>> net/zxdh: add zxdh get device backend infos > >>> net/zxdh: add configure zxdh intr implementation > >>> net/zxdh: add zxdh dev infos get ops > >>> net/zxdh: add zxdh dev configure ops > >>> > > > >> Hi Junlong, > > > >> I can see not all of the eth_dev_ops implemented, and datapath n

RE: [PATCH 1/2] eal: add unreachable and precondition hints

2024-11-04 Thread Morten Brørup
Ping for review. > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Friday, 25 October 2024 13.52 > > Added two new compiler/optimizer hints: > * The __rte_unreachable hint for use in points in code known never to > be > reached. > * The __rte_assume hint for providing information

[PATCH v3] net/ice: fix incorrect reading of PHY timestamp

2024-11-04 Thread Soumyadeep Hore
In ICE PMD, previously the ready bitmap checking before reading PHY timestamp was not present. This caused incorrect Tx timestamping. The ready bitmap checking is enabled and PHY timestamp is read once the ready bitmap gives positive value. Fixes: 881169950d80 ("net/ice/base: implement initial PT

Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support rte flow on cn20k

2024-11-04 Thread Jerin Jacob
On Tue, Oct 29, 2024 at 1:01 PM wrote: > > From: Satheesh Paul > > Support for rte flow in cn20k. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K > index 00..af2eee7266 > --- /dev/null > +++ b/drivers/net/cnxk/cnxk_flow_wrapper.c > @@ -0,0 +1,303 @@ > +/* SPDX-License-Ide

Re: [PATCH v6 2/9] raw/cnxk_rvu_lf: support NPA/SSO pffunc get

2024-11-04 Thread Jerin Jacob
On Tue, Oct 29, 2024 at 9:40 PM Jerin Jacob wrote: > > On Mon, Oct 28, 2024 at 4:40 PM Akhil Goyal wrote: > > > > Added rte_pmd_rvu_lf_npa_pf_func_get and > > rte_pmd_rvu_lf_sso_pf_func_get APIs to get NPA and > > SSO pffunc for the application/external driver use. > > > > Signed-off-by: Akhil Go

RE: [RFC v3 1/3] eal/lcore: add topology based functions

2024-11-04 Thread Morten Brørup
> > Does the API need to be prepared for L4 cache? > > https://www.anandtech.com/show/16924/did-ibm-just-preview-the-future- > of-caches > Thank you for the pointer, yes initial patch was considering L4 cache > too. But I was not able to get hold of system or get someone to test > this with L4. > H

[PATCH v5 46/52] net/tap: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/tap/rte_eth_tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v5 39/52] net/mlx4: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/mlx4/mlx4.c | 27 +-- drivers/net/mlx4/m

[PATCH v5 47/52] net/vhost: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/vhost/rte_eth_vhost.c | 14 +++--- 1 file changed, 11 insert

[PATCH v5 18/52] common/cnxk: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/common/cnxk/roc_dev.c | 12 ++-- drivers/common/cnxk/roc_model

[PATCH v5 43/52] net/qede: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/qede/qede_regs.c | 9 +++-- 1 file changed, 7 insertions(+), 2 d

[PATCH v5 42/52] net/mlx5: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 ++

[PATCH v5 50/52] vdpa/ifc: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/vdpa/ifc/ifcvf_vdpa.c | 57 ++- 1 file c

[PATCH v5 52/52] vdpa/sfc: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 --- 1 file changed, 12 inserti

[PATCH v5 28/52] net/cnxk: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/cnxk/cnxk_rep_msg.c | 9 +++-- 1 file changed, 7 insertions(+),

[PATCH v5 49/52] raw/ifpga: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/raw/ifpga/afu_pmd_n3000.c | 10 -- drivers/raw/ifpga/base/i

[PATCH v5 51/52] vdpa/mlx5: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 5 - 1 file changed, 4 insertions(+),

[PATCH v5 44/52] net/sfc: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/sfc/sfc_flow.c| 5 +- drivers/net/sfc/sfc_flow_tunnel.c |

[PATCH v5 32/52] net/failsafe: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/failsafe/failsafe.c | 13 ++--- drivers/net/failsafe

[PATCH v5 48/52] net/virtio: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/virtio/virtio_user/vhost_kernel.c | 21 +-- .../net/virtio/virti

[PATCH v5 45/52] net/tap: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/tap/rte_eth_tap.c | 51 ++- drivers/

[PATCH v5 05/52] latency: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- lib/latencystats/rte_latencystats.c | 10 -- 1 file changed, 8 insertion

[PATCH v5 35/52] net/ice: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/ice/ice_testpmd.c | 10 -- 1 file changed, 8 insertions(+),

[PATCH v5 41/52] net/mlx5: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/mlx5/linux/mlx5_os.c | 5 ++- drivers/net/mlx5/linux/mlx5_socke

[PATCH v5 40/52] net/mlx4: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_ethdev.c | 18 +- driv

[PATCH v5 15/52] bus/pci: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/bus/pci/bsd/pci.c| 20 +--- drivers/bus/pci/linux/pci.c

[PATCH v5 36/52] net/ixgbe: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/ixgbe/ixgbe_testpmd.c | 30 -- 1 file ch

[PATCH v5 33/52] net/failsafe: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/failsafe/failsafe.c | 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- drivers/ne

[PATCH v5 03/52] eal: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- lib/eal/common/eal_common_fbarray.c | 6 +- lib/eal/common/eal_common_opti

[PATCH v5 24/52] net/af_xdp: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/af_xdp/rte_eth_af_xdp.c | 25 - 1 file chang

[PATCH v5 37/52] net/memif: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/memif/memif_socket.c | 10 +-- drivers/net/memif/rte_eth_memif.

[PATCH v5 34/52] net/i40e: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/i40e/i40e_testpmd.c | 109 +--- 1 file c

[PATCH v5 31/52] net/enetfec: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/enetfec/enet_uio.c | 5 - 1 file changed, 4 insertions(+), 1 del

[PATCH v5 38/52] net/memif: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 29/52] net/dpaa: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- drivers/net/dpaa/fmlib/fm_lib.c

[PATCH v5 20/52] common/mlx5: use rte strerror

2024-11-04 Thread Dengdui Huang
The rte_errno may be an RTE-specific error code, use rte_strerror() instead of strerror(). Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/common/mlx5/linux/mlx5_nl.c | 10 +- drivers/common/mlx5/mlx5_common.c | 6 +++---

[PATCH v5 14/52] bus/fslmc: replace strerror with reentrant version

2024-11-04 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/bus/fslmc/fslmc_vfio.c | 28 +--- 1 file changed

  1   2   >