[PATCH] eal/alarm_cancel: Fix thread starvation

2024-09-17 Thread Wojciech Panfil
Issue: Two threads: - A, executing rte_eal_alarm_cancel, - B, executing eal_alarm_callback. Such case can cause starvation of thread B. Please see that there is a small time window between lock and unlock in thread A, so thread B must be switched to within a very small time window, so that it can

Re: [PATCH] examples/eventdev: fix segment fault with generic pipeline

2024-09-17 Thread fengchengwen
Hi Jerin, Thanks for your review, v2 had fix it and sent, please review. On 2024/9/17 23:50, Jerin Jacob wrote: > On Thu, Aug 1, 2024 at 4:54 PM Chengwen Feng wrote: >> >> There was a segmentation fault when executing eventdev_pipeline with >> command [1] with ConnectX-5 NIC card: >> >> 0x0

[PATCH v2] examples/eventdev: fix segment fault with generic pipeline

2024-09-17 Thread Chengwen Feng
There was a segmentation fault when executing eventdev_pipeline with command [1] with ConnectX-5 NIC card: 0x0079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev.h:6636 txa_service_tx (txa

[PATCH v3 02/19] net/xsc: add log macro

2024-09-17 Thread WanRenyong
Add log macro to print runtime messages and trace functions. Signed-off-by: WanRenyong --- v3: * use RTE_LOG_LINE_PREFIX instead of rte_log --- drivers/net/xsc/xsc_ethdev.c | 11 + drivers/net/xsc/xsc_log.h| 46 2 files changed, 57 insertions(+)

[PATCH v3 10/19] net/xsc: add ethdev configure and rxtx queue setup ops

2024-09-17 Thread WanRenyong
Implement xsc ethdev configure, Rx and Tx queue setup functions. Signed-off-by: WanRenyong --- v3: * use variable length array (VLA) instead of zero length array (ZLA) v2: * fix compilation warning --- drivers/net/xsc/xsc_ethdev.c | 171 +++ drivers/net/xsc/xsc

[PATCH v3 18/19] net/xsc: add dev infos get

2024-09-17 Thread WanRenyong
Implement xsc ethdev information get function. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 60 1 file changed, 60 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c index 369eba3d63..4407c1295b 100644 ---

[PATCH v3 19/19] net/xsc: add dev basic stats ops

2024-09-17 Thread WanRenyong
Implement xsc ethdev basic stats get and reset functions. Signed-off-by: WanRenyong --- doc/guides/nics/features/xsc.ini | 1 + drivers/net/xsc/xsc_ethdev.c | 76 drivers/net/xsc/xsc_rxtx.c | 11 - drivers/net/xsc/xsc_rxtx.h | 15 +++ 4 f

[PATCH v3 17/19] net/xsc: add dev link and MTU ops

2024-09-17 Thread WanRenyong
XSC PMD does not support update link right now, in order to start device successfully link_update function always return 0. Signed-off-by: WanRenyong --- v3: * change the first letter of the log to uppercase --- doc/guides/nics/features/xsc.ini | 1 + drivers/net/xsc/xsc_ethdev.c | 50

[PATCH v3 14/19] net/xsc: add ethdev Rx burst

2024-09-17 Thread WanRenyong
Implement xsc PMD receive function. Signed-off-by: WanRenyong Signed-off-by: Xiaoxiong Zhang --- drivers/net/xsc/xsc_rxtx.c | 189 - drivers/net/xsc/xsc_rxtx.h | 9 ++ 2 files changed, 197 insertions(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_rxtx.

[PATCH v3 13/19] net/xsc: add ethdev start and stop ops

2024-09-17 Thread WanRenyong
Implement xsc ethdev start and stop function. Signed-off-by: WanRenyong Signed-off-by: Rong Qian --- v3: * remove the \n symbol in the log * change the first letter of the log to uppercase * use malloc instead of rte_zmalloc --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_ctrl.h

[PATCH v3 16/19] net/xsc: configure xsc device hardware table

2024-09-17 Thread WanRenyong
Configure hardware table to enable transmission and reception of the queues. Signed-off-by: WanRenyong Signed-off-by: Xiaoxiong Zhang --- v3: * remove the \n symbol in the log * change the first letter of the log to uppercase --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_ctrl.h

[PATCH v3 12/19] net/xsc: add ethdev RSS hash ops

2024-09-17 Thread WanRenyong
Implement xsc ethdev RSS hash config get and update functions. Signed-off-by: WanRenyong --- doc/guides/nics/features/xsc.ini | 3 +++ drivers/net/xsc/xsc_ctrl.h | 27 drivers/net/xsc/xsc_ethdev.c | 43 +++- drivers/net/xsc/xsc_ethdev.h

[PATCH v3 15/19] net/xsc: add ethdev Tx burst

2024-09-17 Thread WanRenyong
Implement xsc PMD transmit function. Signed-off-by: WanRenyong Signed-off-by: Rong Qian --- doc/guides/nics/features/xsc.ini | 4 + drivers/net/xsc/xsc_rxtx.c | 231 ++- drivers/net/xsc/xsc_rxtx.h | 9 ++ 3 files changed, 242 insertions(+), 2 deletion

[PATCH v3 08/19] net/xsc: create eth devices for representor ports

2024-09-17 Thread WanRenyong
Each representor port is a rte ethernet device. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 87 drivers/net/xsc/xsc_ethdev.h | 1 + 2 files changed, 88 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c i

[PATCH v3 11/19] net/xsc: add mailbox and structure

2024-09-17 Thread WanRenyong
Mailbox is a communication channel between driver and firmware. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ctrl.c | 8 drivers/net/xsc/xsc_ctrl.h | 31 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/xsc/xsc_ctrl.c b/drivers/net/xsc/xs

[PATCH v3 09/19] net/xsc: initial representor eth device

2024-09-17 Thread WanRenyong
Initialize xsc eth device private data. Signed-off-by: WanRenyong --- v3: * change the first letter of the log to uppercase --- drivers/net/xsc/xsc_defs.h | 2 +- drivers/net/xsc/xsc_dev.h| 3 + drivers/net/xsc/xsc_ethdev.c | 64 + drivers/net/xsc/xsc_ethdev.h |

[PATCH v3 07/19] net/xsc: add representor ports probe

2024-09-17 Thread WanRenyong
XSC representor port is designed to store representor resources. In addition to common representor ports, xsc device is a special representor port. Signed-off-by: WanRenyong Signed-off-by: Na Na --- drivers/net/xsc/xsc_defs.h | 24 +++ drivers/net/xsc/xsc_dev.c | 103 +++

[PATCH v3 05/19] net/xsc: add ioctl command interface

2024-09-17 Thread WanRenyong
IOCTL command interface is one of methods used to interact with firmware by PMD. By using ioctl interface, PMD sends command to the kernel module, then the kernel module translates the command and sends it to firmware, at last, the kernel module send back PDM the result from firmware. Signed-off-b

[PATCH v3 06/19] net/xsc: initialize hardware information

2024-09-17 Thread WanRenyong
Getting hardware information is done by ioctl command, which contains the information of xsc device, as well as the common information of the NIC board. Signed-off-by: WanRenyong --- v3: * change the xsc_hwinfo_init function name to newline --- drivers/net/xsc/xsc_dev.c | 64 ++

[PATCH v3 04/19] net/xsc: add xsc device init and uninit

2024-09-17 Thread WanRenyong
XSC device is a concept of low level device used to manage hardware resource and to interact with firmware. Signed-off-by: WanRenyong --- v3: * use snprintf instead of sprintf for safety * use getline instead of fgets to handle arbitrary length * change the xsc_dev_args_parse function name to n

[PATCH v3 03/19] net/xsc: add PCI device probe and remove

2024-09-17 Thread WanRenyong
Support the following Yunsilicon NICs to be probed: - metaScale-200 - metaScale-200S - metaScale-50 - metaScale-100Q Signed-off-by: WanRenyong Signed-off-by: Na Na --- drivers/net/xsc/xsc_defs.h | 12 ++ drivers/net/xsc/xsc_ethdev.c | 74 drivers/net/

[PATCH v3 00/19] XSC PMD for Yunsilicon NICs

2024-09-17 Thread WanRenyong
This xsc PMD (**librte_net_xsc**) provides poll mode driver for Yunsilicon metaScale serials NICs. Features: - - MTU update - TSO - RSS hash - RSS key update - RSS reta update - L3 checksum offload - L4 checksum offload - Inner L3 checksum - Inner L4 checksum - Basic stats Support NICs:

[PATCH v3 01/19] net/xsc: add doc and minimum build framework

2024-09-17 Thread WanRenyong
Add minimum PMD code, doc and build infrastructure for xsc. Signed-off-by: WanRenyong --- v2: * fix compilation error --- .mailmap | 4 MAINTAINERS | 9 + doc/guides/nics/features/xsc.ini | 9 + doc/guides/nics/index.rst

Re: [PATCH v5 3/7] eal: add lcore variable performance test

2024-09-17 Thread Mattias Rönnblom
On 2024-09-17 17:40, Morten Brørup wrote: + start = rte_rdtsc(); + + for (i = 0; i < ITERATIONS; i++) + update_fun(mods[i & num_mods_mask]); This indexing adds more instructions to be executed than just the update function. The added overhead is the same for all teste

Re: [PATCH v3 1/1] bbdev: removing unnecessary symbols from version map

2024-09-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

RE: [EXTERNAL] [PATCH 1/2] net: add thread-safe crc api

2024-09-17 Thread Akhil Goyal
> The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > These functions are not safe when using between different > processes, though. > > Signed-off-by: Arkadiusz Kusztal Added Jasvinder for review. This patch is mainly related to

RE: [EXTERNAL] [PATCH v1 3/3] crypto/ipsec_mb: add SM4 algorithm support

2024-09-17 Thread Akhil Goyal
> This patch introduces SM4 algorithm support to the AESNI_MB PMD. > > Signed-off-by: Brian Dooley > --- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++ > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 47 + > 2 files changed, 69 insertions(+) Update correspond

RE: [EXTERNAL] [PATCH] crypto/scheduler: fix crashes in scheduler_multicore due to incorrect variable usage

2024-09-17 Thread Akhil Goyal
Hi Yong Liang, You should mark the previous versions as superseded in patchwork. This create unnecessary confusion. The patch title is still too long. crypto/scheduler: fix incorrect variable usage > The variable `pending_deq_ops` was incorrectly used > instead of `pending_enq_ops`. > This cau

RE: [EXTERNAL] [PATCH] doc: fix crashes in scheduler_multicore due to incorrect variable usage

2024-09-17 Thread Akhil Goyal
Hi Kai, Please review. The patch title is not correct. Please fix. > The variable `pending_deq_ops` was incorrectly used > instead of `pending_enq_ops`. > This causes the program to crash > when the worker PMD accesses the session > > Bugzilla ID: 1537 > Fixes: 6812b9bf470e ("crypto/scheduler: u

RE: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev > > Setting dequeue packet count to max of MAX_PKT_BURST > size instead of MAX_PKTS. > > Dequeue from cryptodev is called with MAX_PKTS but > routing functions allocate hop/dst_ip arrays of > size MAX_PKT_BURST. This can

RE: [PATCH v1 3/3] test/crypto: add support for error recovery

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 3/3] test/crypto: add support for error recovery > > Add a callback for error recovery and register it with cryptodev. > Add a unit test to verify the error recovery of cryptodev. > The unit test generates an error by passing an mbuf to cryptodev > allocated from heap memory.

RE: [PATCH v1 2/3] crypto/cnxk: add queue pair reset support

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 2/3] crypto/cnxk: add queue pair reset support > > Add support for reset of a specific queue pair on cnxk platform. > > Signed-off-by: Vidya Sagar Velumuri Acked-by: Akhil Goyal

RE: [PATCH v1 1/3] cryptodev: add queue pair reset API

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 1/3] cryptodev: add queue pair reset API > > The API will reset the specific queue pair of a cryptodev. > The current API, cryptodev_queue_pair_setup(), requires the cryptodev > to be stopped before reconfiguring any queue pair. Stopping the > cryptodev in one thread can res

RE: [PATCH 00/11] fixes and improvements to cnxk crypto PMD

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH 00/11] fixes and improvements to cnxk crypto PMD > > Adding new PMD APIs and improvements to cnxk crypto PMD. > > Anoob Joseph (9): > common/cnxk: ensure CPTR is 128B aligned > common/cnxk: rearrange to remove hole > common/cnxk: remove abort from flush API > common/cnxk

RE: [PATCH 0/6] Fixes and improvements in crypto unit tests

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH 0/6] Fixes and improvements in crypto unit tests > > Enable larger packet sizes in TLS tests and add minor improvements in > crypto unit tests. > > Anoob Joseph (6): > test/crypto: add asserts to validate test lengths > test/crypto: enable larger packet sizes with TLS > te

RE: [EXTERNAL] [v2 0/7] DPAA2 crypto changes

2024-09-17 Thread Akhil Goyal
> v2 changes: > * fix patch sequence > * add missing code in > "crypto/dpaa2_sec: rework debug code" > > Changes related to crypto driver > > Gagandeep Singh (1): > crypto/dpaa2_sec: fix memory leak > > Jun Yang (5): > net/dpaa2: support FLC stashing API > crypto/dpaa2_se

[PATCH v23 15/15] doc: add release note about log library

2024-09-17 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- doc/guides/rel_notes/release_24_11.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst

[PATCH v23 14/15] log: colorize log output

2024-09-17 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c

[PATCH v23 13/15] log: add support for systemd journal

2024-09-17 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v23 12/15] log: add optional support of syslog

2024-09-17 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 5 +- doc/guides/linux

[PATCH v23 11/15] log: add timestamp option

2024-09-17 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v23 10/15] log: add hook for printing log messages

2024-09-17 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 files changed, 14 insertions(+), 1 deletion(-) create

[PATCH v23 09/15] log: drop syslog support, and make code common

2024-09-17 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_options.c | 3 - lib/log/log.c

[PATCH v23 08/15] eal: initialize log before everything else

2024-09-17 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v23 07/15] log: move handling of syslog facility out of eal

2024-09-17 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 51 ++--- lib/eal/freeb

[PATCH v23 06/15] eal: change rte_exit() output to match rte_log()

2024-09-17 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v23 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-17 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files

[PATCH v23 04/15] eal: make eal_log_level_parse common

2024-09-17 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 45 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/ea

[PATCH v23 03/15] windows: add os shim for localtime_r

2024-09-17 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/eal/wi

[PATCH v23 02/15] windows: make getopt functions have const properties

2024-09-17 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v23 01/15] maintainers: add for log library

2024-09-17 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c5a703b5c0..ecf6f955cc 100644 --- a/MAINTAIN

[PATCH v23 00/15] Logging improvements

2024-09-17 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

RE: [PATCH 1/2] test/crypto: allow retries with stats test

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH 1/2] test/crypto: allow retries with stats test > > Stats need not be reflected instantly after the operation. Relax the > test case to have retries to allow slower updates. > > Signed-off-by: Anoob Joseph Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v22 15/15] doc: add release note about log library

2024-09-17 Thread Morten Brørup
Acked-by: Morten Brørup

[PATCH v4 2/2] app/testpmd: add set dev led on/off command

2024-09-17 Thread Chaoyong He
From: James Hershaw Add command to change the state of a controllable LED on an ethdev port to on/off. This is for the purpose of identifying which physical port is associated with an ethdev. Usage: testpmd> set port led Signed-off-by: James Hershaw Reviewed-by: Chaoyong He --- app/test-

[PATCH v4 1/2] app/testpmd: add support for setting device EEPROM

2024-09-17 Thread Chaoyong He
From: James Hershaw There is currently no means to test the .set_eeprom function callback of a given PMD in drivers/net/. This patch adds functionality to allow a user to set device eeprom from the testpmd cmdline. Usage: testpmd> set port eeprom magic \ value offset - i

[PATCH v4 0/2] add two commands for testpmd application

2024-09-17 Thread Chaoyong He
This patch series aims to add two commands for the testpmd application: - testpmd> set port eeprom magic \ value offset - testpmd> set port led --- v4: * Make the log more readable by using 'rte_strerror()'. * Make the modification of document following the rules. v3: * Add acknow

[DPDK/core Bug 1547] Build fails on FreeBSD 14.0

2024-09-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1547 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[DPDK/core Bug 1547] Build fails on FreeBSD 14.0

2024-09-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1547 Bug ID: 1547 Summary: Build fails on FreeBSD 14.0 Product: DPDK Version: 24.11 Hardware: All OS: FreeBSD Status: UNCONFIRMED Severity: major Priority: N

[PATCH v22 15/15] doc: add release note about log library

2024-09-17 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/release_24_11.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst index 0ff70d9057..4ed483b

[PATCH v22 14/15] log: colorize log output

2024-09-17 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c

[PATCH v22 13/15] log: add support for systemd journal

2024-09-17 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v22 12/15] log: add optional support of syslog

2024-09-17 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 5 +- doc/guides/linux

[PATCH v22 11/15] log: add timestamp option

2024-09-17 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v22 09/15] log: drop syslog support, and make code common

2024-09-17 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_options.c | 3 - lib/log/log.c

[PATCH v22 10/15] log: add hook for printing log messages

2024-09-17 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 files changed, 14 insertions(+), 1 deletion(-) create

[PATCH v22 07/15] log: move handling of syslog facility out of eal

2024-09-17 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 51 ++--- lib/eal/freeb

[PATCH v22 08/15] eal: initialize log before everything else

2024-09-17 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v22 06/15] eal: change rte_exit() output to match rte_log()

2024-09-17 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v22 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-17 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files

[PATCH v22 04/15] eal: make eal_log_level_parse common

2024-09-17 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 45 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/ea

[PATCH v22 03/15] windows: add os shim for localtime_r

2024-09-17 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/eal/wi

[PATCH v22 02/15] windows: make getopt functions have const properties

2024-09-17 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v22 01/15] maintainers: add for log library

2024-09-17 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c5a703b5c0..ecf6f955cc 100644 --- a/MAINTAIN

[PATCH v22 00/15] Logging improvements

2024-09-17 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[DPDK/core Bug 1546] fib6 perf test failing

2024-09-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1546 Bug ID: 1546 Summary: fib6 perf test failing Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

RE: [EXTERNAL] Re: [PATCH] doc: update Arm IPsec-MB dependency version

2024-09-17 Thread Akhil Goyal
> On 31/07/2024 22:26, Wathsala Vithanage wrote: > > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.07.08 > > in snow3g and zuc documentation. > > > > Signed-off-by: Wathsala Vithanage > > Reviewed-by: Dhruv Tripathi > Acked-by: Jack Bond-Preston Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH v6 8/8] zsda: add zsda crypto-session and compile file

2024-09-17 Thread Akhil Goyal
> Add new file zsda_sym_session.c, zsda_symsession.h > and modify drivers/common/zsda/meson.build > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build| 16 +- > drivers/crypto/zsda/zsda_sym_session.c | 503 + > drivers/crypto/zsda/zsda_sym_sessio

RE: [EXTERNAL] [PATCH v6 6/8] zsda: add zsda crypto-pmd

2024-09-17 Thread Akhil Goyal
> Add new file zsda_sym_pmd.c, zsda_sym_pmd.h in drivers/crypto/zsda > > Signed-off-by: Hanxiao Li Please split the patches appropriately for better review. Please follow https://patches.dpdk.org/project/dpdk/patch/20240916162856.11566-1-step...@networkplumber.org/ > --- > drivers/crypto/zsda/

RE: [EXTERNAL] [PATCH v6 5/8] zsda: modify files for introducing zsda cryptodev

2024-09-17 Thread Akhil Goyal
> -Original Message- > From: Hanxiao Li > Sent: Wednesday, September 11, 2024 1:24 PM > To: dev@dpdk.org > Cc: wang.yon...@zte.com.cn; Hanxiao Li > Subject: [EXTERNAL] [PATCH v6 5/8] zsda: modify files for introducing zsda > cryptodev > > It is necessary to make necessary modification

RE: [EXTERNAL] [PATCH v6 1/8] zsda: Introduce zsda device drivers

2024-09-17 Thread Akhil Goyal
> Introduce driver support for ZSDA which can > help to accelerate storage data process. > > v6: modify code for ci compile > > Signed-off-by: Hanxiao Li > --- > MAINTAINERS | 4 + > config/rte_config.h | 4 + > drivers/common/zsda/meson.build | 25 +

RE: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-09-17 Thread Konstantin Ananyev
> From: Vignesh PS > > Add support to ip_frag library to perform IPv6 reassembly > when extension headers are present before the fragment > extension in the packet. > > Signed-off-by: Vignesh PS > --- > .mailmap | 1 + > lib/ip_frag/ip_frag_common.h | 2 + > l

RE: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-09-17 Thread Konstantin Ananyev
> > On Mon, 26 Aug 2024 13:23:28 +0200 > wrote: > > > diff --git a/lib/ip_frag/ip_reassembly.h b/lib/ip_frag/ip_reassembly.h > > index 54afed5417..429e74f1b3 100644 > > --- a/lib/ip_frag/ip_reassembly.h > > +++ b/lib/ip_frag/ip_reassembly.h > > @@ -54,6 +54,8 @@ struct __rte_cache_aligned ip_f

RE: [PATCH v2] ipsec: allow stateless IPsec processing

2024-09-17 Thread Konstantin Ananyev
> Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an IPsec > session. > > For outbound IPsec processing, the change enables user to > provide sequence number to be used for the IPsec

[PATCH v2] devtools: fix false positive from checkpatch

2024-09-17 Thread Stephen Hemminger
The codespell dictionary has "stdio" in its bad word list, but stdio.h is often used in DPDK code and creates bogus false positives from checkpatch. Also add a check to the parameters to build-dict.sh so it gives usage error if parameter is missing or does not point to the codespell git clone. Si

Re: 21.11.8 patches review and test

2024-09-17 Thread Kevin Traynor
On 17/09/2024 17:21, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Tuesday, September 17, 2024 7:14 PM >> To: Ali Alnubani ; sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McNamara >> ; Ju-Hyoung Le

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Konstantin Ananyev
> >> +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE) > >> + > >> +static void *lcore_buffer; > >> +static size_t offset = RTE_MAX_LCORE_VAR; > >> + > >> +static void * > >> +lcore_var_alloc(size_t size, size_t align) > >> +{ > >> + void *handle; > >> + void *value; > >> + > >> +

RE: 21.11.8 patches review and test

2024-09-17 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, September 17, 2024 7:14 PM > To: Ali Alnubani ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Luca > Boccassi ; Pei Zhang ; Raslan > Daraws

Re: 21.11.8 patches review and test

2024-09-17 Thread Kevin Traynor
On 11/09/2024 14:10, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, September 11, 2024 3:20 PM >> To: Ali Alnubani ; sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McNamara >> ; Ju-Hyoung

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Konstantin Ananyev
> >> + > >> +/** > >> + * Get pointer to lcore variable instance with the specified lcore id. > >> + * > >> + * @param lcore_id > >> + * The lcore id specifying which of the @c RTE_MAX_LCORE value > >> + * instances should be accessed. The lcore id need not be valid > >> + * (e.g., may be @re

Re: [PATCH] examples/eventdev: fix segment fault with generic pipeline

2024-09-17 Thread Jerin Jacob
On Thu, Aug 1, 2024 at 4:54 PM Chengwen Feng wrote: > > There was a segmentation fault when executing eventdev_pipeline with > command [1] with ConnectX-5 NIC card: > > 0x0079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, > queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev

Re: [PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Thomas Monjalon
17/09/2024 17:45, Bruce Richardson: > On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > > The codespell dictionary has "stdio" in its bad word list, > > but stdio.h is often used in DPDK code and creates bogus false > > postitives from checkpatch. > > > > Also add a check to the

Re: [PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Bruce Richardson
On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > The codespell dictionary has "stdio" in its bad word list, > but stdio.h is often used in DPDK code and creates bogus false > postitives from checkpatch. > > Also add a check to the parameters to build-dict.sh so it > gives usage

RE: [PATCH v5 3/7] eal: add lcore variable performance test

2024-09-17 Thread Morten Brørup
> + start = rte_rdtsc(); > + > + for (i = 0; i < ITERATIONS; i++) > + update_fun(mods[i & num_mods_mask]); This indexing adds more instructions to be executed than just the update function. The added overhead is the same for all tested access methods, so the absolute differen

[PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Stephen Hemminger
The codespell dictionary has "stdio" in its bad word list, but stdio.h is often used in DPDK code and creates bogus false postitives from checkpatch. Also add a check to the parameters to build-dict.sh so it gives usage error if parameter is missing or does not point to the codespell git clone. S

Re: [PATCH] eventdev: do not use zero length arrays

2024-09-17 Thread Jerin Jacob
On Thu, Jul 25, 2024 at 11:24 PM Stephen Hemminger wrote: > > Zero length array's are a GNU C extension and should be replaced > by use of flexible arrayrs. This has been fixed almost everywhere > in DPDK 24.07 but looks like some event code got missed. > > Generated by devtools/cocci/zero_length_

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-17 Thread Patrick Robb
Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his series. It's probably not worth blocking a "critic

Re: [PATCH] test/event: fix missing schedule type assignment

2024-09-17 Thread Jerin Jacob
On Wed, Jul 24, 2024 at 1:02 AM wrote: > > From: Pavan Nikhilesh > > Missing schedule type assignment might set it to > incorrect value, set it to SCHED_TYPE_PARALLEL. > > Fixes: d007a7f39de3 ("eventdev: introduce link profiles") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Applied

Re: [PATCH v19 5/5] dts: add API doc generation

2024-09-17 Thread Juraj Linkeš
On 16. 9. 2024 14:48, Thomas Monjalon wrote: 16/09/2024 10:51, Juraj Linkeš: On 12. 9. 2024 22:09, Thomas Monjalon wrote: 21/08/2024 17:02, Juraj Linkeš: +req_deps = _get_dependencies(_DTS_DEP_FILE_PATH) +req_deps.pop('python') + +for req_dep, dep_data in (req_deps | _EXTRA_DEPS

[PATCH v5 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

  1   2   >