Re: [PATCH v6 3/3] event/dsw: add capability for independent enqueue

2024-07-22 Thread Mattias Rönnblom
On 2024-07-11 21:54, Abdullah Sevincer wrote: To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to

Re: [PATCH v6 2/3] eventdev: add support for independent enqueue

2024-07-22 Thread Mattias Rönnblom
On 2024-07-11 21:54, Abdullah Sevincer wrote: This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to support independent enqueue to support PMD to enqueue in any order even the un

RE: [V1] app/testpmd: restore VXLAN-GPE support

2024-07-22 Thread Minggang(Gavin) Li
> -Original Message- > From: Ferruh Yigit > Sent: Monday, July 22, 2024 10:44 PM > To: Minggang(Gavin) Li ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; Aman Singh > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: Re: [V1] app/testpmd: restore V

[PATCH] net/hns3: fix uninitialized value

2024-07-22 Thread Jie Hai
This patch fixes uninitialized auto_state value when querying FEC mode of device. Bugzilla ID: 1498 Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Chengwen Feng --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed,

[PATCH] net/ice/base: add retries for reading NVM

2024-07-22 Thread Zhichao Zeng
Reading NVM fails in some scenarios, so synchronize with the share code in the kernel driver to add retries for reading NVM. Signed-off-by: Zhichao Zeng --- drivers/net/ice/base/ice_nvm.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/net/ic

[PATCH v2 3/3] test-pmd: add more packet verbose decode options

2024-07-22 Thread Stephen Hemminger
The existing verbose levels 1..3 provide a messy multi-line output per packet. I found this unhelpful when diagnosing many types of problems like packet flow. This patch keeps the previous levels and adds two new levels: 4: one line per packet is printed in a format resembling tshark output. Wi

[PATCH v2 2/3] test: add test for packet dissector

2024-07-22 Thread Stephen Hemminger
Some tests for new packet dissector. Signed-off-by: Stephen Hemminger --- app/test/meson.build| 1 + app/test/test_dissect.c | 289 2 files changed, 290 insertions(+) create mode 100644 app/test/test_dissect.c diff --git a/app/test/meson.build b/a

[PATCH v2 1/3] net: add new packet dissector

2024-07-22 Thread Stephen Hemminger
The function rte_dissect_mbuf is used to decode the contents of an mbuf and print them in human readable format similar to what tshark uses. For now, handles IP, IPv6, TCP, UDP, ICMP and ARP. The intention is to extend this to be able to handle more nested tunnel types as well as higher level prot

[PATCH v2 0/3] Add packet dissector

2024-07-22 Thread Stephen Hemminger
Take earlier patch which enhanced mbuf printout for test-pmd and generalize this to be a function in net library. v2 - splits the patch up and adds standalone functional tests Stephen Hemminger (3): net: add new packet dissector test: add test for packet dissector test-pmd: add more packet

RE: release candidate 24.07-rc2

2024-07-22 Thread Xu, HailinX
> -Original Message- > From: David Marchand > Sent: Saturday, July 13, 2024 2:25 AM > To: annou...@dpdk.org > Cc: Thomas Monjalon > Subject: release candidate 24.07-rc2 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v24.07-rc2 > > Ther

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-07-22 Thread Jun Wang
I used the e1000 NIC with OVS-DPDK and experienced a failure when using the /dpdk/app/dpdk-dumpcap command to capture packets. After making modifications, it worked fine. /dpdk/app/dpdk-dumpcap -i :00:04.0 File: /tmp/dpdk-dumpcap_0_:00:04.0_20240723020203.pcapng Segmentation fault (core

Re: [PATCH] app/testpmd: fix build on signed comparison

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 8:21 PM, Ali Alnubani wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, July 22, 2024 1:52 PM >> To: Aman Singh ; Sivaprasad Tummala >> >> Cc: dev@dpdk.org; sta...@dpdk.org; Raslan Darawsheh >> Subject: [PATCH] app/testpmd: fix build on signed comparison >>

Re: [v3 05/30] dma/dpaa2: add sanity check for SG entry

2024-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2024 22:09:05 +0530 Gagandeep Singh wrote: > From: Jun Yang > > Make sure the SG entry number doesn't overflow. > > Signed-off-by: Jun Yang > --- Please do not use the term 'sanity check'. It is on the Inclusive Naming word list as a Tier 2: strongly consider replacing. https

[PATCH v3] power: fix number of uncore freqs

2024-07-22 Thread Stephen Hemminger
The number of uncore frequencies was defined in three places, and two of them were too small leading to test failures. All places should be using RTE_MAX_UNCORE_FREQS. Bugzilla ID: 1499 Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") Signed-off-by: Stephen Hemminger --- v3 - re

RE: [PATCH] app/testpmd: fix build on signed comparison

2024-07-22 Thread Ali Alnubani
> -Original Message- > From: Ferruh Yigit > Sent: Monday, July 22, 2024 1:52 PM > To: Aman Singh ; Sivaprasad Tummala > > Cc: dev@dpdk.org; sta...@dpdk.org; Raslan Darawsheh > Subject: [PATCH] app/testpmd: fix build on signed comparison > > Build error: > .../app/test-pmd/config.c: In f

RE: [PATCH dpdk] rel_notes: announce 24.11 ipv6 api breakage

2024-07-22 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Monday, 22 July 2024 19.40 > > In 24.11, all IPv6 public APIs will be modified to use a structure > instead of fixed size arrays. [...] > + - lpm ( Remove "(" or add something here. With that fixed, Acked-by: Morten Brørup

[PATCH dpdk] rel_notes: announce 24.11 ipv6 api breakage

2024-07-22 Thread Robin Jarry
In 24.11, all IPv6 public APIs will be modified to use a structure instead of fixed size arrays. Cc: Bruce Richardson Cc: Morten Brørup Cc: Stephen Hemminger Cc: Vladimir Medvedkin Cc: Konstantin Ananyev Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation.rst | 16 ++

Re: [PATCH v1] common/cnxk: fix integer overflow

2024-07-22 Thread Jerin Jacob
On Thu, Jul 18, 2024 at 12:13 PM Ankur Dwivedi wrote: > > The expression flow_age->aging_poll_freq * NPC_AGE_WAIT_TIMEOUT_US is > evaluated using 32 bit arithmetic. An integer overflow may occur when > the value is too large to fit in 32 bits. This patch resolves this by > casting flow_age->aging_

Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

2024-07-22 Thread Dean Marx
> > > +recv = self.send_packet_and_capture(pakt) > +self.verify(len(recv) > 0, "Did not receive and packets when > testing VLAN priority.") > I'm assuming this should say "any" instead of "and." Other than that, everything looks good to me. Reviewed-by: Dean Marx

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-07-22 Thread Bruce Richardson
On Sun, Jul 14, 2024 at 04:26:26PM +0800, Jun Wang wrote: >>> The code to update link status is not safe in secondary process. >>> If called from secondary it will crash, example from dumpcap: >>> eth_em_link_update >>> >>> Signed-off-by: Jun Wang >> >> Wouldn't it

[v3 30/30] bus/dpaa: add port bmi stats

2024-07-22 Thread Gagandeep Singh
From: Hemant Agrawal Add BMI statistics and fixing the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++- drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/f

[v3 29/30] dma/dpaa: support max SG entry size

2024-07-22 Thread Gagandeep Singh
From: Jun Yang SG transaction is not helpful for performance of large transaction size. Start single transaction for size > max SG entry size in SG copy. Default MAX SG entry size is 2000 bytes which is experiment data of mem to mem, user can change it according to experiment: export DPAA_QDMA_S

[v3 28/30] dma/dpaa: support multiple SG copies

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Split burst copies to multiple SG copies if burst number exceeds max number of SG entries. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 180 +++ drivers/dma/dpaa/dpaa_qdma.h | 2 +- 2 files changed, 98 insertions(+), 84 deletions(-

[v3 27/30] dma/dpaa: improve silent mode support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Don't save eq context in silent mode, check HW status only to identify if queue is full. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/d

[v3 26/30] dma/dpaa: improve ERRATA workaround solution

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Fix issue of ERRATA 050757/050265 workaround which is not effective in burst mode. SDF/DDF is referred by first entry of compound frame table, move the DF to compound frame table description which is suitable to adapt single copy and SG/burst copy. Fix SG issue which was caused b

[v3 25/30] dma/dpaa: disable SG descriptor as default

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Burst operation used for SG copy as default until SG issue is fixed. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index eaa5f81f6d..8492d

[v3 24/30] dma/dpaa: improve congestion handling

2024-07-22 Thread Gagandeep Singh
From: Jun Yang The congestion issue occurs frequently on low speed device(PCIe). We should drain the command queue to make dma work when congestion occurs. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 157 +++ 1 file changed, 85 insertions(+), 72 d

[v3 23/30] dma/dpaa: block dequeue

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Perform block dequeue to identify which queue of this block is completed. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 252 --- 1 file changed, 116 insertions(+), 136 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/

[v3 22/30] dma/dpaa: add Scatter Gather support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Perform SG operation by copy_sg callback of DMA lib or burst request from application. Perform Simple operation if burst number is 1. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 856 ++- drivers/dma/dpaa/dpaa_qdma.h | 184 +---

[v3 21/30] dma/dpaa: dequeue status queue

2024-07-22 Thread Gagandeep Singh
From: Jun Yang To support multiple command queues of each block, status queue need support to notify which command queue of block is completed. The multiple command queues are balanced to blocks in setup. If multiple command queues are enabled in one block, de-queue status is performed instead o

[v3 20/30] dma/dpaa: refactor driver

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Return complete index instead of total complete counter in complete callback. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 534 ++- drivers/dma/dpaa/dpaa_qdma.h | 109 +++ 2 files changed, 330 insertions(+), 313 deletions(-) dif

[v3 19/30] dma/dpaa: data path optimization

2024-07-22 Thread Gagandeep Singh
Remove unnessary status read before every send. Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 186 ++- drivers/dma/dpaa/dpaa_qdma.h | 7 ++ 2 files changed, 101 insertions(+), 92 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drive

[v3 18/30] dma/dpaa: remove unwanted desc

2024-07-22 Thread Gagandeep Singh
remove unwanted descriptor list maintenance and channels overhead. Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 594 +-- drivers/dma/dpaa/dpaa_qdma.h | 43 +-- 2 files changed, 221 insertions(+), 416 deletions(-) diff --git a/drivers/dma/dpa

[v3 17/30] dma/dpaa: qdma stall workaround for ERR050265

2024-07-22 Thread Gagandeep Singh
Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA stall issue due to

[v3 16/30] dma/dpaa: add workaround for ERR050757

2024-07-22 Thread Gagandeep Singh
ERR050757 on LS104x indicates: For outbound PCIe read transactions, a completion buffer is used to store the PCIe completions till the data is passed back to the initiator. At most 16 outstanding transactions are allowed and maximum read request is 256 bytes. The completion buffer size inside the

[v3 15/30] dma/dpaa: add burst capacity API

2024-07-22 Thread Gagandeep Singh
From: Vanshika Shukla This patch improves the dpaa qdma driver and adds dpaa_qdma_burst_capacity API which returns the remaining space in the descriptor ring. Signed-off-by: Vanshika Shukla --- drivers/dma/dpaa/dpaa_qdma.c | 34 +- drivers/dma/dpaa/dpaa_qdma.h |

[v3 14/30] dma/dpaa: fix job enqueue

2024-07-22 Thread Gagandeep Singh
The check shall be end instead of equal. Fixes: 7da29a644c51 ("dma/dpaa: support DMA operations") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dp

[v3 13/30] dma/dpaa: support multi channels

2024-07-22 Thread Gagandeep Singh
This patch add support to use multiple dma channel in the driver. Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index 10e65ef1d7..24ad7ad019 1

[v3 12/30] dma/dpaa2: move the qdma header to common place

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Include rte_pmd_dpaax_qdma.h instead of rte_pmd_dpaa2_qdma.h and change code accordingly. Signed-off-by: Jun Yang --- doc/api/doxy-api-index.md | 2 +- doc/api/doxy-api.conf.in | 2 +- drivers/common/dpaax/meson.build | 3 +- drivers/

[v3 11/30] dma/dpaa2: change the DMA copy return value

2024-07-22 Thread Gagandeep Singh
From: Jun Yang The return value of DMA copy/sg copy should be index of descriptor copied in success. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2

[v3 10/30] dma/dpaa2: limit the max descriptor number

2024-07-22 Thread Gagandeep Singh
From: Jun Yang For non-SG format, the index is saved in FD with DPAA2_QDMA_FD_ATT_TYPE_OFFSET(13) bits width. The max descriptor number of ring is power of 2, so the eventual max number is: ((1 << DPAA2_QDMA_FD_ATT_TYPE_OFFSET) / 2) Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.h |

[v3 09/30] dma/dpaa2: add short FD support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Short FD can be used for single transfer scenario which shows higher performance than FLE. 1) Save index context in FD att field for short and FLE(NonSG). 2) Identify FD type by att of FD. 3) Force 48 bits address for source address and fle according to spec. Signed-off-by: Jun Ya

[v3 08/30] bus/fslmc: enhance the qbman dq storage logic

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Multiple DQ storages are used among multiple cores, the single dq storage of first union is leak if multiple storages are allocated. It does not make sense to keep the single dq storage of union, remove it and reuse the first dq storage of multiple storages for this case. Signed-o

[v3 07/30] dma/dpaa2: borrow flags of DMA operation to pass job context

2024-07-22 Thread Gagandeep Singh
From: Jun Yang For copy_sg: pass job index lists. For copy: pass job index. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 92 ++ drivers/dma/dpaa2/dpaa2_qdma.h | 7 ++ drivers/dma/dpaa2/rte_pmd_dpaa2_qdma.h | 15 - 3 files changed, 68

[v3 06/30] dma/dpaa2: include DPAA2 specific header files

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Include dpaa2_hw_pvt.h and dpaa2_hw_dpio.h files Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.h b/drivers/dma/dpaa2/dpaa2_qdma.h index 743a43fa14..eb02bff08f 100644 --- a/drivers/dm

[v3 05/30] dma/dpaa2: add sanity check for SG entry

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Make sure the SG entry number doesn't overflow. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c index 44b82c139e..7f6ebcb46b

[v3 04/30] dma/dpaa2: multiple process support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Support multiple processes for dpaa2 dma. 1) Move queue configuration procedure from init function to device configuration function which is called by user. 2) Instances of dpaa2_dpdmai_dev and qdma_device are allocated from primary process and shared between multiple processes.

[v3 03/30] dma/dpaa2: adapt DMA driver API

2024-07-22 Thread Gagandeep Singh
From: Jun Yang 1) Support DMA single copy and SG copy. 2) Silent mode support. Add index combined with length field. For Silent mode, this index is used to notify DMA driver which inner descriptor should be used. For none silent mode, this index is used to notify user which descriptor is complet

[v3 02/30] dma/dpaa2: support multiple HW queues

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Initialize and Configure queues of dma device according to hw queues supported from mc bus. Because multiple queues per device are supported, virt queues implementation are dropped. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 312 +++-

[v3 01/30] dma/dpaa2: configure route by port by PCIe port param

2024-07-22 Thread Gagandeep Singh
From: Jun Yang struct { uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/ uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/ uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/ uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/ . } pcie; Signed-off-by: Jun Ya

[v3 00/30] NXP DMA driver fixes and Enhancements

2024-07-22 Thread Gagandeep Singh
V3 changes: * fix 32 bit compilation issue V2 changes: * fix compilation issue on ubuntu 22.04 Gagandeep Singh (6): dma/dpaa: support multi channels dma/dpaa: fix job enqueue dma/dpaa: add workaround for ERR050757 dma/dpaa: qdma stall workaround for ERR050265 dma/dpaa: remove unwanted d

Re: [PATCH] app/testpmd: fix build on signed comparison

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 11:52 AM, Ferruh Yigit wrote: > Build error: > .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': > .../app/test-pmd/config.c:5159:30: >error: comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > if ((nb_txq * nb_fwd_ports)

[PATCH v2] power: fix number of uncore freqs

2024-07-22 Thread Stephen Hemminger
The number of uncore frequencies was defined in three places, and two of them were too small leading to test failures. All places should be using RTE_MAX_UNCORE_FREQS. Bugzilla ID: 1499 Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") Signed-off-by: Stephen Hemminger --- v2 - dro

Re: [PATCH v5 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Bruce Richardson
On Mon, Jul 22, 2024 at 04:09:15PM +0100, Bruce Richardson wrote: > On Mon, Jul 22, 2024 at 01:50:44PM +, Vladimir Medvedkin wrote: > > This patch fixes possible memory leak inside the > > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() > > for previously allocated pkt_buf

Re: [PATCH v5 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-22 Thread Bruce Richardson
On Mon, Jul 22, 2024 at 01:50:46PM +, Vladimir Medvedkin wrote: > If the parser was not initialized when calling ice_hash_parse_raw_pattern() > -rte_errno was returned. Replace returning rte_errno with ENOTSUP since > rte_errno is meaningless in the context of ice_hash_parse_raw_pattern(). > >

Re: [PATCH v5 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Bruce Richardson
On Mon, Jul 22, 2024 at 01:50:45PM +, Vladimir Medvedkin wrote: > Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. > > Signed-off-by: Vladimir Medvedkin > I believe there are quite a number of other small things in this function that could do with improvement e.g. the p

Re: [PATCH v5 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Bruce Richardson
On Mon, Jul 22, 2024 at 01:50:44PM +, Vladimir Medvedkin wrote: > This patch fixes possible memory leak inside the > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() > for previously allocated pkt_buf and msk_buf. > > Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic

Re: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs

2024-07-22 Thread Raslan Darawsheh
Hi, From: Alexander Kozyrev Sent: Wednesday, November 1, 2023 4:57 PM To: dev@dpdk.org Cc: Suanming Mou; Slava Ovsiienko; Raslan Darawsheh Subject: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs Keep unzipping if the next CQE is the miniCQE array in rxq_cq_decompress_v() routine only f

[PATCH] doc: announce vhost changes to support asymmetric operation

2024-07-22 Thread Gowrishankar Muthukrishnan
Announce vhost ABI changes to modify few functions to support asymmetric crypto operation. Signed-off-by: Gowrishankar Muthukrishnan -- RFC: https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukri...@marvell.com/ --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file

[PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-07-22 Thread Gowrishankar Muthukrishnan
Announce cryptodev changes to offload RSA asymmetric operation in VirtIO PMD. Signed-off-by: Gowrishankar Muthukrishnan -- RFC: https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-2-gmuthukri...@marvell.com/ https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-3-gmuth

Re: [PATCH] lib: add get/set link settings interface

2024-07-22 Thread Ferruh Yigit
On 4/4/2024 12:38 AM, Stephen Hemminger wrote: > On Thu, 4 Apr 2024 00:08:41 +0200 > Marek Pazdan wrote: > >> I can remove this part (rte_eth_config), but the new API provides other >> link information which is not available from the existing API, like >> supported/advertising/partner_advertising

[PATCH] doc: announce cryptodev change to support EDDSA

2024-07-22 Thread Gowrishankar Muthukrishnan
Announce the additions in cryptodev ABI to support EDDSA algorithm. Signed-off-by: Gowrishankar Muthukrishnan -- RFC: https://patches.dpdk.org/project/dpdk/patch/0ae6a1afadac64050d80b0fd7712c4a6a8599e2c.1701273963.git.gmuthukri...@marvell.com/ --- doc/guides/rel_notes/deprecation.rst | 4

Re: [V1] app/testpmd: restore VXLAN-GPE support

2024-07-22 Thread Ferruh Yigit
On 7/17/2024 8:11 AM, Gavin Li wrote: > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a76b44bf39..51a8d4993e 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -423,6 +423,12 @@ enum index { > ITEM_GENEVE_VNI, > ITEM_GENE

Re: [PATCH] net/gve: Update TX queue state

2024-07-22 Thread Tathagat Priyadarshi
Thanks Ferruh. On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit wrote: > On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote: > > Fixing Typo in updating the TX queue state > > > > Signed-off-by: Tathagat Priyadarshi > > > > Good catch, thanks Tathagat. > > I think impact is more than just typo, so l

Re: [PATCH] net/gve: Update TX queue state

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote: > Fixing Typo in updating the TX queue state > > Signed-off-by: Tathagat Priyadarshi > Good catch, thanks Tathagat. I think impact is more than just typo, so let me update the patch title as: net/gve: fix Tx queue state on queue start Also ne

RE: [PATCH v4 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Medvedkin, Vladimir
-Original Message- From: Richardson, Bruce Sent: Monday, July 22, 2024 12:25 PM To: Medvedkin, Vladimir Cc: dev@dpdk.org Subject: Re: [PATCH v4 2/3] net/ice: refactor raw pattern parsing function On Mon, Jul 22, 2024 at 10:59:49AM +, Vladimir Medvedkin wrote: > Replace strlen wit

[PATCH v5 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
If the parser was not initialized when calling ice_hash_parse_raw_pattern() -rte_errno was returned. Replace returning rte_errno with ENOTSUP since rte_errno is meaningless in the context of ice_hash_parse_raw_pattern(). Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RS

[PATCH v5 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin tmp --- drivers/net/ice/ice_hash.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 6b3095e2c5..a

[PATCH v5 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Vladimir Medvedkin
This patch fixes possible memory leak inside the ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() for previously allocated pkt_buf and msk_buf. Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS") Cc: sta...@dpdk.org Reported-by: Michael Theodore St

Re: [V1] app/testpmd: restore VXLAN-GPE support

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 2:04 PM, Thomas Monjalon wrote: > 22/07/2024 11:36, Ferruh Yigit: >> On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote: >>> From: Ferruh Yigit On 7/17/2024 8:11 AM, Gavin Li wrote: > VXLAN-GPE support was removed from testpmd recently. Drivers which are > not migrated are st

Re: [PATCH] app/testpmd: fix build on signed comparison

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 11:52 AM, Ferruh Yigit wrote: > Build error: > .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': > .../app/test-pmd/config.c:5159:30: >error: comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > if ((nb_txq * nb_fwd_ports)

Re: [PATCH v2] ethdev: fix device init without socket-local memory

2024-07-22 Thread Ferruh Yigit
On 7/22/2024 11:02 AM, Bruce Richardson wrote: > When allocating memory for an ethdev, the rte_malloc_socket call used > only allocates memory on the NUMA node/socket local to the device. This > means that even if the user wanted to, they could never use a remote NIC > without also having memory on

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-22 Thread Dean Marx
Reviewed-by: Dean Marx On Tue, Jul 2, 2024 at 3:25 PM Nicholas Pratte wrote: > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there is now an > adjust_addresse

Re: [PATCH v3 2/3] dts: add methods for setting mac and multicast addresses

2024-07-22 Thread Dean Marx
I think Jeremy already mentioned this but just make sure you update vlan_set_filter_on/off to the new version that has an on boolean arg. Reviewed-by: Dean Marx On Thu, Jul 18, 2024 at 3:12 PM Nicholas Pratte wrote: > Several new methods have been added to TestPMDShell in order to produce > th

Re: [PATCH v3 3/3] dts: mac filter test suite refactored for new dts

2024-07-22 Thread Dean Marx
> > +This test suite ensures proper and expected behavior of Allowlist filtering > via mac > +addresses on devices bound to the Poll Mode Driver. If a packet received > on a device > +contains a mac address not contained with its mac address pool, the > packet should > +be dropped. Alternatively

Re: [PATCH] dts: fix DPDK git tarball cast bug

2024-07-22 Thread Juraj Linkeš
Reviewed-by: Juraj Linkeš Thanks for catching this. On 19. 7. 2024 17:34, Alex Chapman wrote: When running DTS with a git revision specified the following error occurs: $ ./main.py --revision HEAD [...] FileNotFoundError: [Errno 2] No such file or directory: 'dts/' Fix by casting DPDKGi

Re: [V1] app/testpmd: restore VXLAN-GPE support

2024-07-22 Thread Thomas Monjalon
22/07/2024 11:36, Ferruh Yigit: > On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote: > > From: Ferruh Yigit > >> On 7/17/2024 8:11 AM, Gavin Li wrote: > >>> VXLAN-GPE support was removed from testpmd recently. Drivers which are > >>> not migrated are still using VXLAN-GPE in tests. > >>> > >>> This c

Re: [PATCH v2] net/vdev: fix insert vdev core dump

2024-07-22 Thread Burakov, Anatoly
On 7/16/2024 11:53 AM, Mingjin Ye wrote: In secondary processes, insert_vdev() may be called multiple times on the same device due to multi-process hot-plugging of the vdev bus and EAL parameters to add the same vdev. In this case, when rte_devargs_insert() is called, the devargs->name reference

RE: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs

2024-07-22 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, November 1, 2023 15:57 > To: dev@dpdk.org > Cc: Suanming Mou ; Slava Ovsiienko > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs > > Keep unzipping if the next CQE is the miniCQE

[v2 17/30] dma/dpaa: qdma stall workaround for ERR050265

2024-07-22 Thread Gagandeep Singh
Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA stall issue due to

[v2 20/30] dma/dpaa: refactor driver

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Return complete index instead of total complete counter in complete callback. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 534 ++- drivers/dma/dpaa/dpaa_qdma.h | 109 +++ 2 files changed, 330 insertions(+), 313 deletions(-) dif

[v2 01/30] dma/dpaa2: configure route by port by PCIe port param

2024-07-22 Thread Gagandeep Singh
From: Jun Yang struct { uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/ uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/ uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/ uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/ . } pcie; Signed-off-by: Jun Ya

[v2 19/30] dma/dpaa: data path optimization

2024-07-22 Thread Gagandeep Singh
Remove unnessary status read before every send. Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 186 ++- drivers/dma/dpaa/dpaa_qdma.h | 7 ++ 2 files changed, 101 insertions(+), 92 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drive

[v2 18/30] dma/dpaa: remove unwanted desc

2024-07-22 Thread Gagandeep Singh
remove unwanted descriptor list maintenance and channels overhead. Signed-off-by: Gagandeep Singh --- drivers/dma/dpaa/dpaa_qdma.c | 594 +-- drivers/dma/dpaa/dpaa_qdma.h | 43 +-- 2 files changed, 221 insertions(+), 416 deletions(-) diff --git a/drivers/dma/dpa

[v2 00/30] NXP DMA driver fixes and Enhancements

2024-07-22 Thread Gagandeep Singh
V2 changes: * fix compilation issue on ubuntu 22.04 Gagandeep Singh (6): dma/dpaa: support multi channels dma/dpaa: fix job enqueue dma/dpaa: add workaround for ERR050757 dma/dpaa: qdma stall workaround for ERR050265 dma/dpaa: remove unwanted desc dma/dpaa: data path optimization Hema

[v2 07/30] dma/dpaa2: borrow flags of DMA operation to pass job context

2024-07-22 Thread Gagandeep Singh
From: Jun Yang For copy_sg: pass job index lists. For copy: pass job index. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 92 ++ drivers/dma/dpaa2/dpaa2_qdma.h | 7 ++ drivers/dma/dpaa2/rte_pmd_dpaa2_qdma.h | 15 - 3 files changed, 68

[v2 06/30] dma/dpaa2: include DPAA2 specific header files

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Include dpaa2_hw_pvt.h and dpaa2_hw_dpio.h files Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.h b/drivers/dma/dpaa2/dpaa2_qdma.h index 743a43fa14..eb02bff08f 100644 --- a/drivers/dm

[v2 02/30] dma/dpaa2: support multiple HW queues

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Initialize and Configure queues of dma device according to hw queues supported from mc bus. Because multiple queues per device are supported, virt queues implementation are dropped. Signed-off-by: Jun Yang --- drivers/dma/dpaa2/dpaa2_qdma.c | 312 +++-

[v2 30/30] bus/dpaa: add port bmi stats

2024-07-22 Thread Gagandeep Singh
From: Hemant Agrawal Add BMI statistics and fixing the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++- drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/f

[v2 29/30] dma/dpaa: support max SG entry size

2024-07-22 Thread Gagandeep Singh
From: Jun Yang SG transaction is not helpful for performance of large transaction size. Start single transaction for size > max SG entry size in SG copy. Default MAX SG entry size is 2000 bytes which is experiment data of mem to mem, user can change it according to experiment: export DPAA_QDMA_S

[v2 28/30] dma/dpaa: support multiple SG copies

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Split burst copies to multiple SG copies if burst number exceeds max number of SG entries. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 180 +++ drivers/dma/dpaa/dpaa_qdma.h | 2 +- 2 files changed, 98 insertions(+), 84 deletions(-

[v2 27/30] dma/dpaa: improve silent mode support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Don't save eq context in silent mode, check HW status only to identify if queue is full. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/d

[v2 26/30] dma/dpaa: improve ERRATA workaround solution

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Fix issue of ERRATA 050757/050265 workaround which is not effective in burst mode. SDF/DDF is referred by first entry of compound frame table, move the DF to compound frame table description which is suitable to adapt single copy and SG/burst copy. Fix SG issue which was caused b

[v2 25/30] dma/dpaa: disable SG descriptor as default

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Burst operation used for SG copy as default until SG issue is fixed. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index eaa5f81f6d..8492d

[v2 23/30] dma/dpaa: block dequeue

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Perform block dequeue to identify which queue of this block is completed. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 252 --- 1 file changed, 116 insertions(+), 136 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/

[v2 24/30] dma/dpaa: improve congestion handling

2024-07-22 Thread Gagandeep Singh
From: Jun Yang The congestion issue occurs frequently on low speed device(PCIe). We should drain the command queue to make dma work when congestion occurs. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 157 +++ 1 file changed, 85 insertions(+), 72 d

[v2 22/30] dma/dpaa: add Scatter Gather support

2024-07-22 Thread Gagandeep Singh
From: Jun Yang Perform SG operation by copy_sg callback of DMA lib or burst request from application. Perform Simple operation if burst number is 1. Signed-off-by: Jun Yang --- drivers/dma/dpaa/dpaa_qdma.c | 856 ++- drivers/dma/dpaa/dpaa_qdma.h | 184 +---

[v2 21/30] dma/dpaa: dequeue status queue

2024-07-22 Thread Gagandeep Singh
From: Jun Yang To support multiple command queues of each block, status queue need support to notify which command queue of block is completed. The multiple command queues are balanced to blocks in setup. If multiple command queues are enabled in one block, de-queue status is performed instead o

[v2 16/30] dma/dpaa: add workaround for ERR050757

2024-07-22 Thread Gagandeep Singh
ERR050757 on LS104x indicates: For outbound PCIe read transactions, a completion buffer is used to store the PCIe completions till the data is passed back to the initiator. At most 16 outstanding transactions are allowed and maximum read request is 256 bytes. The completion buffer size inside the

[v2 15/30] dma/dpaa: add burst capacity API

2024-07-22 Thread Gagandeep Singh
From: Vanshika Shukla This patch improves the dpaa qdma driver and adds dpaa_qdma_burst_capacity API which returns the remaining space in the descriptor ring. Signed-off-by: Vanshika Shukla --- drivers/dma/dpaa/dpaa_qdma.c | 34 +- drivers/dma/dpaa/dpaa_qdma.h |

  1   2   >