[PATCH] vdpa: update used->flags in used ring relay

From: BillXiang The vDPA device will work incorrectly if flags such as VRING_USED_F_NO_NOTIFY are not updated correctly. Signed-off-by: BillXiang --- lib/vhost/vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c index a1dd5a753b..8abb073675 100644 ---

[PATCH 2/2] net/nfp: fix AVX2 vector Rx function memory overrun

From: Long Wu CI found that the 'rxb' in 'nfp_net_vec_avx2_recv_pkts()' may cause memory overrun. Coverity issue:439964 Fixes: b67555307628 ("net/nfp: add AVX2 Rx") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx_vec_avx2.c | 41 +

[PATCH 1/2] net/nfp: fix copy and paste error

CI found copy and paste error occurs. Coverity issue: 439967 Fixes: 830057d1dba9 ("net/nfp: refactor flow action compile function") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 0/2] fix coverity issues

This patch series fix two coverity issues: - 439964 - 439967 Chaoyong He (1): net/nfp: fix copy and paste error Long Wu (1): net/nfp: fix AVX2 vector Rx function memory overrun drivers/net/nfp/flower/nfp_flower_flow.c | 4 +-- drivers/net/nfp/nfp_rxtx_vec_avx2.c | 41 +++--

Re: [RFC v2] ethdev: an API for cache stashing hints

On Mon, 15 Jul 2024 22:11:41 + Wathsala Vithanage wrote: > An application provides cache stashing hints to the ethernet devices to > improve memory access latencies from the CPU and the NIC. This patch > introduces three distinct hints for this purpose. > > The RTE_ETH_DEV_STASH_HINT_HOST_WI

RE: [PATCH v2 2/2] net/ngbe: disable LLDP by default

On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote: > On 7/16/2024 9:16 AM, Jiawen Wu wrote: > > --- a/drivers/net/ngbe/base/ngbe_hw.h > > +++ b/drivers/net/ngbe/base/ngbe_hw.h > > @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval); > > void ngbe_map_device_id(struct ngbe_hw *h

[PATCH v2] net/ark: fix index arithmetic optimization bug

fix for compiler optimizer error using int32_t. (a - b) > 0 can behave differently under optimization at values near max and min bounds. This patch replaces int32_t with uint32_t except for necessary casts. Fixes: 9ee9e0d3b85e ("net/ark: update to reflect FPGA updates") Cc: sta...@dpdk.org Signed

[PATCH v2 2/2] dts: add dual_vlan test suite to the yaml schema

From: Jeremy Spewock Adds the test suite name to the yaml schema to allow for it to be run. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/frame

[PATCH v2 1/2] dts: add dual_vlan testing suite

From: Jeremy Spewock This patch ports over the functionality of the dual_vlan suite from old DTS to the new framework. This test suite exists to test the functionality of VLAN functions such as stripping, inserting, and filerting in the presence of two VLAN headers. There are some test cases whi

[PATCH v2 0/2] dts: add test suite for dual VLANs

From: Jeremy Spewock v2: * remove test cases that verify the ability to have 3 VLAN headers as this is a less practical case than only having 2. * add a test case that verifies a packet with only 1 VLAN header can have another inserted into it. * remove patch that fixes tx_vlan_reset met

[PATCH] net/ark: fix index arithmetic optimization bug

fix for compiler optimizer error using int32_t. (a - b) > 0 can behave differently under optimization at values near max and min bounds. This patch replaces int32_t with uint32_t except for necessary casts. Fixes: 9ee9e0d3b85e ("net/ark: update to reflect FPGA updates") Cc: sta...@dpdk.org Signed

Re: [PATCH v9 01/21] net/ntnic: add ethdev and makes PMD available

On 7/16/2024 1:01 PM, Serhii Iliushyk wrote: > Add initial ntnic ethdev skeleton and register PCI probe functions > Update documentation: Device description and feature list > > Signed-off-by: Serhii Iliushyk > --- > v6 > * Remove unused includes > * Remove EOF markers > * Remove unnecesarry comm

Re: [PATCH v9 14/21] net/ntnic: add clock profile for the NT200A0X smartNIC

On 7/16/2024 1:02 PM, Serhii Iliushyk wrote: > diff --git > a/drivers/net/ntnic/nthw/core/nt200a0x/clock_profiles/nthw_fpga_clk9563.c > b/drivers/net/ntnic/nthw/core/nt200a0x/clock_profiles/nthw_fpga_clk9563.c > new file mode 100644 > index 00..a957581bf3 > --- /dev/null > +++ b/drivers/n

Re: [PATCH v9 21/21] net/ntnic: add physical layer control module

On 7/16/2024 1:02 PM, Serhii Iliushyk wrote: > + /* GTY_RX_BUF_STAT */ > +#ifdef RXBUFSTAT > + p->mp_reg_gty_rx_buf_stat = > + nthw_module_get_register(p->mp_mod_mac_pcs, > MAC_PCS_GTY_RX_BUF_STAT); > + p->mp_field_gty_rx_buf_stat_rx_buf_stat

Re: [PATCH v9 09/21] net/ntnic: add registers and FPGA model for NapaTech NIC

On 7/16/2024 1:01 PM, Serhii Iliushyk wrote: > The NTNIC PMD does not rely on a kernel space Napatech driver, > thus all defines related to the register layout is part of the PMD > code, which will be added in later commits. > > Signed-off-by: Serhii Iliushyk > In the commit log title, "net/ntni

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

On Wed, Feb 14, 2024 at 3:17 PM Patrick Robb wrote: > > > > On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian > wrote: >> >> >> >> [Cristian] >> Yes, you are right, we do have a DTS test suite for the pipeline library. >> >> It would be great to run it automatically as part of the CI testing.

[PATCH] kni: fix build with Linux 6.10

6.10 removed the "support" (it was never supported [1]) of separate source and build dirs for out of tree modules. KNI uses "src=" hack for that purpose. Instead, copy sources to the build dir and don't rely upon the unsupported... Intended esp. for stable/22.11. It should go wherever kni is sti

Re: [PATCH v2 1/6] dts: Remove build target config and list of devices

On Fri, Jul 5, 2024 at 1:15 PM Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these are unuesed. > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to reflec

Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

I think it makes sense to allow users to not specify any test suites in the config file if they specify them through other means, so I like this change. On Fri, Jul 5, 2024 at 1:20 PM Nicholas Pratte wrote: > > There is some odd functionality/behavior in how the --test-suite > parameters interact

Re: [PATCH v2] dts: Testbed And Node Configuration Split

On Wed, Jul 3, 2024 at 10:58 AM Nicholas Pratte wrote: > > This implementation splits the execution and node configuration > components of the conf.yaml into two separate config files. A > new command line argument is added, allowing the user to specify > both a node configuration file and an exec

[PATCH v9 21/21] net/ntnic: add physical layer control module

Adds functionality to control the physical layer of the OSI model. This takes the form of the module MAC PCS (Media Access Control Physical Coding Sublayer). The functionality is used by the 100G link functionality to establish link. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/n

[PATCH v9 19/21] net/ntnic: add QSFP28 support

Includes support for QSFP28 Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h| 21 ++ drivers/net/ntnic/link_mgmt/nt4ga_link.c | 25 +++ drivers/net/ntnic/nim/i2c_nim.c | 267 ++- drivers/net/ntnic/nim/nim_defines.h | 1 + 4 files

[PATCH v9 20/21] net/ntnic: add GPIO communication for NIMs

For NIM reset sequence GPIO communication is used. After this commit the NIMs supported by ntnic is able to start up and be controlled fully by the adapter. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling --- drivers/net/ntnic/include/nt4ga_link.h| 1 + .../link_mgmt/link_100

[PATCH v9 17/21] net/ntnic: add generic NIM and I2C modules

As the ntnic can support different port speeds, it also needs to support different NIMs (Network Interface Module). This commit add the generic NIM support for ntnic, such that the specific modules, such as QSFP28 can be added later. The communication with NIMs is in the form of I2C, so support fo

[PATCH v9 13/21] net/ntnic: add startup and reset sequence for NT200A0X

Adds reset (RST) module for FW 9563. Also adds SDRAM Controller (SDC) module, as it is part of the startup and reset sequence. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling --- .../include/ntnic_nthw_fpga_rst_nt200a0x.h| 81 +++ drivers/net/ntnic/meson.build |

[PATCH v9 14/21] net/ntnic: add clock profile for the NT200A0X smartNIC

Because the ntnic hardware supports multiple different FPGAs with different pipelines and port speeds, the clock profile is not hardcoded into the product, and need to be initialized from software. The clock profile itself is an array of integers that was generated by Silicon Labs ClockBuilder. S

[PATCH v9 18/21] net/ntnic: add QSFP support

Includes support for QSFP and QSFP+. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h | 10 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 12 +- drivers/net/ntnic/nim/i2c_nim.c | 310 +- drivers/net/ntnic/nim/i2c_nim.h

[PATCH v9 10/21] net/ntnic: add FPGA modules for initialization

New ntnic FPGA modules: - Host Interface (HIF): Basic FPGA info such as prod ID and build time. - Inter-Integrated Circuit Controller (IIC): Use the FPGA to access the other integrated circuits on the ntnic. - PCI Express Gen3 (PCIE3): The FPGA part of PCIe3 initialization, speed te

[PATCH v9 15/21] net/ntnic: add link management skeleton

Add functionality to read and control the link-state of the ntnic. Note that must functions are not implemented yet. Adds the following eth_dev_ops: - dev_set_link_up - dev_set_link_down - link_update - mac_addr_add - mac_addr_set - set_mc_addr_list - promiscuous_enable Signed-off-by: Serhii Iliu

[PATCH v9 16/21] net/ntnic: add link 100G module ops

As the ntnic can support different speeds, an abstraction layer for 100G speed is needed. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 12 - .../link_mgmt/link_100g/nt4ga_link_100g.c | 49 +++ drivers/net/ntnic/meson.build

[PATCH v9 08/21] net/ntnic: add adapter initialization

Add interfaces for initialize the adapter Add proper PCI device deinitialization Signed-off-by: Serhii Iliushyk --- v6 * Function for global var clearing was removed v9 * Fix PCI devide deinitialization * Fix p_hw_info usage --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 145 +++

[PATCH v9 11/21] net/ntnic: add FPGA initialization functionality

Enable FPGA initialization and adds ethdev fw_version_get. Signed-off-by: Serhii Iliushyk --- v5 * Fix Typo/Spelling v7 * Add FW update feature to documentation - INI and RST files --- doc/guides/nics/features/ntnic.ini| 1 + doc/guides/nics/ntnic.rst | 5 + d

[PATCH v9 12/21] net/ntnic: add support of the NT200A0X smartNIC

Add ntnic support for NT200A0X NIC Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 +++ drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_fpga.h | 7 +++ .../nthw/core/nt200a0x/nthw_fpga_nt200a0x.c | 54 +

[PATCH v9 05/21] net/ntnic: add VFIO module

Adds VFIO functionality and the DMA it requires. The VFIO context is initialized during ntnic ethdev startup. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/ntnic_ethdev.c | 22 +++ drivers/net/ntnic/ntnic_vfio.c | 235

[PATCH v9 07/21] net/ntnic: add core platform structures

Adds many of the high level structures needed by the ntnic FPGA modules and adapter control. This is considered the first part of the skeleton of ntnic FPGA support Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntos_drv.h | 2 + drivers/net/ntnic/meson.build |

[PATCH v9 06/21] net/ntnic: add basic eth dev ops to ntnic

Adds support for eth_dev configure, start, stop, close, and infos_get. The internal structs of ntnic is also added and initialized. Signed-off-by: Serhii Iliushyk --- v6 * Replace if_index with n_intf_no * Unnecessry resources free was fixed * Fix typo * Useless vars were removed v9 * Remove if_i

[PATCH v9 02/21] net/ntnic: add logging implementation

Adds ntnic specific implementation for logging. NT NIC uses this logging abstraction layer to ensure that FPGA module implementations function both within and outside in DPDK environment Signed-off-by: Serhii Iliushyk --- v6 * Logging header file was moved * Default log type was set to NOTICE ---

[PATCH v9 01/21] net/ntnic: add ethdev and makes PMD available

Add initial ntnic ethdev skeleton and register PCI probe functions Update documentation: Device description and feature list Signed-off-by: Serhii Iliushyk --- v6 * Remove unused includes * Remove EOF markers * Remove unnecesarry commpiller flags * Update documentation INI and RST files *

[PATCH v9 03/21] net/ntnic: add minimal initialization for PCI device

add implementation for probe/init and remove/deinit of the PCI device. proper device deinitialization will be added letter. Signed-off-by: Serhii Iliushyk --- v6 * Add driver deinitialization * Add API rte_eth_dev_probing_finish * Add correct API for finishing probing the device *

[PATCH v9 04/21] net/ntnic: add NT utilities implementation

Add ntnic utilities. Signed-off-by: Serhii Iliushyk --- v6 * NT utils header file was moved --- drivers/net/ntnic/meson.build | 2 ++ drivers/net/ntnic/ntnic_ethdev.c | 2 ++ drivers/net/ntnic/ntutil/nt_util.c | 33 +++ drivers/net/ntnic/ntutil/nt_util.h | 43 +++

Re: [PATCH v2 2/2] net/ngbe: disable LLDP by default

On 7/16/2024 9:16 AM, Jiawen Wu wrote: > --- a/drivers/net/ngbe/base/ngbe_hw.h > +++ b/drivers/net/ngbe/base/ngbe_hw.h > @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval); > void ngbe_map_device_id(struct ngbe_hw *hw); > > void ngbe_read_efuse(struct ngbe_hw *hw); > -u32

[PATCH v2] net/vdev: fix insert vdev core dump

In secondary processes, insert_vdev() may be called multiple times on the same device due to multi-process hot-plugging of the vdev bus and EAL parameters to add the same vdev. In this case, when rte_devargs_insert() is called, the devargs->name reference will be invalidated because rte_devargs_in

[DPDK/ethdev Bug 1473] [dpdk-24.07] vxlan/vxlan_ipv6_checksum_offload: IPV6-Vxlan TX droped by outer sw csum

https://bugs.dpdk.org/show_bug.cgi?id=1473 Huang,zhimin (zhiminx.hu...@intel.com) changed: What|Removed |Added Resolution|--- |INVALID Stat

RE: [PATCH v1] crypto/qat: add fix for Gen4 WRITE

Acked-by: Arkadiusz Kusztal > -Original Message- > From: Dooley, Brian > Sent: Friday, July 12, 2024 4:49 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Kusztal, ArkadiuszX > ; Dooley, Brian > Subject: [PATCH v1] crypto/qat: add fix for Gen4 WRITE > > All ge

[PATCH v2 1/2] net/txgbe: disable LLDP by default

In the new firmware versions, LLDP is enabled by default to implement new features in other drivers. But it is useless in DPDK. So disable it in device initialization to prevent it from affecting hardware default behavior. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 3 +

[PATCH v2 2/2] net/ngbe: disable LLDP by default

In the new firmware versions, LLDP is enabled by default to implement new features in other drivers. But it is useless in DPDK. So disable it in device initialization to prevent it from affecting hardware default behavior. Build errors on some ARM platforms are introduced by this patch: ../driver