Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-20 Thread Mattias Rönnblom
It seems like patchwork didn't realize this v4 patch set supersedes v3. I'm trying to figure out what I did wrong. Must you use the cover letter's message id in order for patchwork to recognize the history?

[PATCH v2 4/4] test/crypto: add modex tests for zero padded operands

2024-06-20 Thread Gowrishankar Muthukrishnan
Add modex tests for zero padded operands, as in ASN encoding. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 16 + app/test/test_cryptodev_mod_test_vectors.h | 71 ++ 2 files changed, 87 insertions(+) diff --git a/app/test/test

[PATCH v2 3/4] test/crypto: use common test function for mod tests

2024-06-20 Thread Gowrishankar Muthukrishnan
Use common test function for modex and modinv tests. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - Old functions not removed. --- app/test/test_cryptodev_asym.c | 21 +++- app/test/test_cryptodev_mod_test_vectors.h | 124 + 2 files changed, 140 insertions(

[PATCH v2 2/4] test/crypto: remove unused variable in modex test data

2024-06-20 Thread Gowrishankar Muthukrishnan
Remove unused result_len from modex test data. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_mod_test_vectors.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/app/test/test_cryptodev_mod_test_vectors.h b/app/test/test_cryptodev_mod_test_vectors.h index c7

[PATCH v2 1/4] test/crypto: validate modex result from first nonzero value

2024-06-20 Thread Gowrishankar Muthukrishnan
At present, there is no specification of whether modex op output can carry leading zeroes without changing the value. OpenSSL strips leading zeroes, but other hardware need not be. Hence, when output is compared against expected result, validation could start from first non-zero. Fixes: 1ffefe00f1

[PATCH v2 0/4] test/crypto: enhance modex tests

2024-06-20 Thread Gowrishankar Muthukrishnan
This patch series enhances modex tests to: * use common test function in existing test vectors * add test for zero padded operands v2: - Retain old modex test functions to avoid doc updates. Gowrishankar Muthukrishnan (4): test/crypto: validate modex result from first nonzero value test/c

[PATCH v2 9/9] doc: reword rcu library section in prog guide

2024-06-20 Thread Nandini Persad
Simple syntax changes made to the rcu library section in programmer's guide. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/rcu_lib.rst | 77 --- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/doc/guides/prog_guide/rcu_lib.rst b/doc/guides/p

[PATCH v2 8/9] doc: reword stack library section in prog guide

2024-06-20 Thread Nandini Persad
Minor changes made to wording of the stack library section in prog guide. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/stack_lib.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/stack_lib.rst b/doc/guides/prog_guide/stack_lib.rst index

[PATCH v2 7/9] doc: reword cmdline section in prog guide

2024-06-20 Thread Nandini Persad
Minor syntax edits made to the cmdline section. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/cmdline.rst | 34 +++ 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/doc/guides/prog_guide/cmdline.rst b/doc/guides/prog_guide/cmdline.rst index 6

[PATCH v2 6/9] doc: reword log library section in prog guide

2024-06-20 Thread Nandini Persad
Minor changes made for syntax in the log library section and 7.1 section of the programmer's guide. A couple sentences at the end of the trace library section were also edited. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/cmdline.rst | 24 +++--- doc/guides/prog_guid

[PATCH v2 5/9] doc: reword trace library section in prog guide

2024-06-20 Thread Nandini Persad
Minor syntax edits were made to sect the trace library section of prog guide. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/trace_lib.rst | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/doc/guides/prog_guide/trace_lib.rst b/doc/guide

[PATCH v2 4/9] doc: reword service cores section in prog guide

2024-06-20 Thread Nandini Persad
I've made minor syntax changes to section 8 of programmer's guide, service cores. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/service_cores.rst | 32 - 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/doc/guides/prog_guide/service_cores.rst b/

[PATCH v2 3/9] doc: reword design section in contributors guidelines

2024-06-20 Thread Nandini Persad
Minor editing was made for grammar and syntax of design section. Signed-off-by: Nandini Persad --- .mailmap | 1 + doc/guides/contributing/design.rst | 86 +++--- doc/guides/linux_gsg/sys_reqs.rst | 2 +- 3 files changed, 45 insertions(+), 44

[PATCH v2 2/9] doc: reword argparse section in prog guide

2024-06-20 Thread Nandini Persad
I have made small edits for syntax in this section. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/argparse_lib.rst | 75 +- 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/doc/guides/prog_guide/argparse_lib.rst b/doc/guides/prog_guide/argparse_l

[PATCH v2 1/9] doc: reword pmd section in prog guide

2024-06-20 Thread Nandini Persad
I made edits for syntax/grammar the PMD section of the prog guide. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/poll_mode_drv.rst | 151 1 file changed, 73 insertions(+), 78 deletions(-) diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_

[PATCH] telemetry: fix potential connection issue

2024-06-20 Thread Zhichao Zeng
For calling memcpy when the source and destination addresses are the same, there is a small probability that there will be a copy error issue in some environments, resulting in a failure to connect. This patch uses memmove instead of memcpy to avoid this issue. Fixes: b80fe1805eee ("telemetry: in

[PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-20 Thread jspewock
From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicates the implementation of scapy methods. This patch remo

[PATCH v1 0/1] dts: replace XML-RPC server

2024-06-20 Thread jspewock
From: Jeremy Spewock v1: * Documentation fixes based on comments * Use multiple inheritance to merge the two commits together, allowing the scapy traffic generator to handle the implementation of all of the scapy related logic. Jeremy Spewock (1): dts: Remove XML-RPC server for Scapy T

[DPDK/core Bug 1468] rte_mbuf timesync field should be dynfield

2024-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1468 Bug ID: 1468 Summary: rte_mbuf timesync field should be dynfield Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancemen

Re: [PATCH v4 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-20 Thread Jeremy Spewock
On Wed, Jun 19, 2024 at 4:51 AM Juraj Linkeš wrote: > > > > -def scatter_pktgen_send_packet(self, pktsize: int) -> str: > > +def scatter_pktgen_send_packet(self, pktsize: int) -> list[Packet]: > > A note: We should make this method a part of TestSuite (so that we have > a common way to fil

Re: [PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-20 Thread Jeremy Spewock
On Wed, Jun 19, 2024 at 4:16 AM Juraj Linkeš wrote: > > > > +def stop_then_start_port_decorator( > > The name shouldn't contain "decorator". Just the docstring should > mention it's a decorator. Ack. > > > +func: Callable[["TestPmdShell", int, Any, bool], None] > > I'm thinking about this ty

RE: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-20 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > This patch set make DPDK library, driver, and application code use the > compiler/libc memcpy() by default when functions in are > invoked. > > The various custom DPDK rte_memcpy() implementations may be retained > by means of a

RE: [PATCH v1 7/9] test/bbdev: check assumptions on fft window

2024-06-20 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 12, 2024 4:11 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 7/9] test/bbdev: check assumptions on fft window >

[PATCH v4 12/13] fib: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The trie implementation of the fib library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson Acked-by: Stephen Hemminger --- lib/fib/trie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/fib/trie.c b/lib/fib/tri

[PATCH v4 11/13] distributor: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The distributor library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson --- lib/distributor/rte_distributor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_

[PATCH v4 13/13] eal: provide option to use compiler memcpy instead of RTE

2024-06-20 Thread Mattias Rönnblom
Provide build option to have functions in delegate to the standard compiler/libc memcpy(), instead of using the various custom DPDK, handcrafted, per-architecture rte_memcpy() implementations. A new meson build option 'use_cc_memcpy' is added. By default, the compiler/libc memcpy() is used. The

[PATCH v4 05/13] net/ngbe: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The ngbe driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/ngbe/ngbe_rxtx_vec_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_rxtx_vec_sse.c b/drivers/net/ngbe/ngbe_rxtx_vec_s

[PATCH v4 10/13] net/octeon_ep: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The octeon_ip driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Stephen Hemminger --- drivers/net/octeon_ep/otx_ep_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/

[PATCH v4 09/13] event/dlb2: include headers for vector and memory copy APIs

2024-06-20 Thread Mattias Rönnblom
The DLB2 PMD depended on being included as a side-effect of being included. In addition, DLB2 used rte_memcpy() but did not include , but rather depended on other include files to do so. This patch addresses both of those issues. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson ---

[PATCH v4 08/13] net/fm10k: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The fm10k PMD relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson --- drivers/net/fm10k/fm10k_rxtx_vec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/ne

[PATCH v4 07/13] net/virtio: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The virtio driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/virtio/virtio_rxtx_simple_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_simple_sse.c b/drivers/net/virt

[PATCH v4 06/13] net/txgbe: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The txgbe driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/txgbe/txgbe_rxtx_vec_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_rxtx_vec_sse.c b/drivers/net/txgbe/txgbe_rxt

[PATCH v4 03/13] net/ice: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The ice driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/ice/ice_rxtx_vec_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_rxtx_vec_sse.c b/drivers/net/ice/ice_rxtx_vec_sse.c inde

[PATCH v4 04/13] net/ixgbe: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The ixgbe driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxt

[PATCH v4 01/13] net/i40e: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The i40e driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/i40e/i40e_rxtx_vec_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_s

[PATCH v4 02/13] net/iavf: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The iavf driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_s

[PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-20 Thread Mattias Rönnblom
This patch set make DPDK library, driver, and application code use the compiler/libc memcpy() by default when functions in are invoked. The various custom DPDK rte_memcpy() implementations may be retained by means of a build-time option. This patch set only make a difference on x86, PPC and ARM.

[PATCH v4 3/3] dts: Improve logging for interactive shells

2024-06-20 Thread jspewock
From: Jeremy Spewock The messages being logged by interactive shells currently are using the same logger as the node they were created from. Because of this, when sending interactive commands, the logs make no distinction between when you are sending a command directly to the host and when you ar

[PATCH v4 2/3] dts: Add missing docstring from XML-RPC server

2024-06-20 Thread jspewock
From: Jeremy Spewock When this XML-RPC server implementation was added, the docstring had to be shortened in order to reduce the chances of this race condition being encountered. Now that this race condition issue is resolved, the full docstring can be restored. Signed-off-by: Jeremy Spewock --

[PATCH v4 1/3] dts: Improve output gathering in interactive shells

2024-06-20 Thread jspewock
From: Jeremy Spewock The current implementation of consuming output from interactive shells relies on being able to find an expected prompt somewhere within the output buffer after sending the command. This is useful in situations where the prompt does not appear in the output itself, but in some

[PATCH v4 0/3] Improve interactive shell output gathering and logging

2024-06-20 Thread jspewock
From: Jeremy Spewock v4: * rebase on top of rc1. * address comments and fix typos in the added docstring example. Jeremy Spewock (3): dts: Improve output gathering in interactive shells dts: Add missing docstring from XML-RPC server dts: Improve logging for interactive shells dts/fra

Community CI Meeting Minutes - June 13, 2024

2024-06-20 Thread Patrick Robb
# Attendees 1. Patrick Robb 2. Juraj Linkeš 3. Aaron Conole 4. Dean Marx 5. Jeremy Spewock 6. Manit Mahajan 7. Nicholas Pratte 8. Paul Szczepanek 9. Tomas Durovec ###

RE: [PATCH] examples/fips_validation: fix coverity issues

2024-06-20 Thread Dooley, Brian
Hey Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, June 15, 2024 12:31 PM > To: dev@dpdk.org; Dooley, Brian ; Gowrishankar > Muthukrishnan > Cc: Anoob Joseph ; sta...@dpdk.org > Subject: [PATCH] examples/fips_validation: fix coverity issues > > F

DTS WG Meeting Minutes - June 20, 2024

2024-06-20 Thread Patrick Robb
# Attendees * Patrick Robb * Juraj Linkeš * Paul Szczepanek * Jeremy Spewock * Nicholas Pratte * Dean Marx * Luca Vizzarro # Minutes

Re: [PATCH v2 095/148] net/ice/base: add E830 debug dump cluster ID values

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:29PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Add E830 debug dump cluster ID values, which are different than the > values for E810. Rename E810 cluster IDs to make it easier to > distinguish which values are which.Add E830 debug dump cluster ID > values,

Re: [PATCH v2 093/148] net/ice/base: allow different FW API versions based on MAC type

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:27PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Allow the driver to be compatible with different FW API versions based > on the device's MAC type. Currently, E810 is only compatible with one > FW API version. Now the driver can be compatible with different

RE: [PATCH] net/*: replace intrinsic header include with rte_vect

2024-06-20 Thread Konstantin Ananyev
> Rather than having the SSE code in each driver include tmmintrin.h, > which often does not contain all needed intrinsics, e.g. > _mm_cvtsi128_si64() for 32-bit x86 builds, we can just replace the > include of ?mmintrin.h with rte_vect.h for all network drivers. > > Signed-off-by: Bruce Richard

[PATCH 12/12] crypto/cnxk: enable dual submission to CPT

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Submit two instructions in one LMTLINE. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c | 17 +- drivers/common/cnxk/roc_cpt.h | 8 +- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 182 +- drivers/crypto/cnxk/cn10k_c

[PATCH 11/12] crypto/cnxk: make pack IV variable as const

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Make 'pack_iv' variable as const to avoid multiple checks. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk

[PATCH 10/12] crypto/cnxk: fix aes-gcm zero len input cases

2024-06-20 Thread Aakash Sasidharan
For aes-gcm (AEAD) zero length input, sg code path is taken unlike the digest only cases as AAD is treated as a separate input component. Fix the zero len case in SG path by avoiding the gather component only when it is a non AEAD algorithm. Also add sg version check as the fix only applies to spec

[PATCH 09/12] crypto/cnxk: update sess pointer for next iteration

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Update sess pointer while working on next set of packets. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/c

[PATCH 08/12] crypto/cnxk: add dual submission in Rx inject

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Add dual submission to CPT in Rx inject path. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_cpt.h | 43 +- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 70 +-- drivers/crypto/cnxk/cnxk_

[PATCH 07/12] crypto/cnxk: remove init of CPT result field in packet

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph The packet would be posted to CPT only when there is a valid result. Skip setting of the same. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/dri

[PATCH 06/12] crypto/cnxk: use NEON for Rx inject inst preparation

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Use NEON instructions for Rx inject instruction preparation. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 57 +-- 1 file changed, 42 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/d

[PATCH 05/12] crypto/cnxk: use SSO PF func of inline device in inst

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph RVU PF FUNC of the CPT LF need not be set as the hardware would determine that. Instead SSO PF FUNC need to be set as inline device so that critical errors would reach inline device. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 +- drivers/cr

[PATCH 04/12] crypto/cnxk: add flow control in Rx inject path

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Add flow control in Rx inject path to avoid over submission to CPT. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/dri

[PATCH 03/12] common/cnxk: make inline dev PF func get as idev API

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Inline PF FUNC would be required to set SSO_PF_FUNC in the instruction for cryptodev Rx inject. Move the API to idev to allow usage of the same. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_idev.c | 6 ++ drivers/common/cnxk/roc_idev.h | 2

[PATCH 01/12] common/cnxk: add comments to denote skipped entries

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Add comments to denote unused table entries. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ae.c| 6 +++--- drivers/common/cnxk/roc_ae_fpm_tables.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/common/cnxk/roc_ae.c b/

[PATCH 02/12] crypto/cnxk: update version map file with PMD APIs

2024-06-20 Thread Aakash Sasidharan
From: Anoob Joseph Update version map with details of PMD APIs added. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 2 ++ drivers/crypto/cnxk/version.map | 8 2 files changed, 10 insertions(+) diff --git a/drivers/crypto/cnxk/rte_pmd_cnxk_crypt

[PATCH 00/12] fixes and improvements to CNXK crypto PMD

2024-06-20 Thread Aakash Sasidharan
This series adds improvements to CNXK crypto PMD and fixes aes-gcm zero length input failure. Aakash Sasidharan (1): crypto/cnxk: fix aes-gcm zero len input cases Anoob Joseph (11): common/cnxk: add comments to denote skipped entries crypto/cnxk: update version map file with PMD APIs comm

Re: [PATCH v2 087/148] net/ice/base: allow skipping PF clear

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:21PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > As per updated data sheet, add 'skip_clear_pf' field to ice_hw structure, > which > can be used to skip call to ice_clear_pf_cfg() in ice_init_hw(). > > Also, make 'fw_vsi_num' field of ice_hw structure visi

[PATCH v2 7/7] test/security: use single session in data walkthrough test

2024-06-20 Thread Aakash Sasidharan
Existing data walkthrough test creates a new session per each test packet size. Enhance the test to use single session instead. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 49 +-- app/test/test_cryptodev_security_tls_record.h | 1 + 2 fil

[PATCH v2 6/7] test/security: add out of place sgl tests for TLS

2024-06-20 Thread Aakash Sasidharan
Add multi segmented test for TLS 1.3 and multi segmented out of place tests for DTLS 1.2 and TLS 1.3. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 69 ++- 1 file changed, 39 insertions(+), 30 deletions(-) diff --git a/app/test/test_cryptod

[PATCH v2 5/7] test/crypto: verify padding corruption in DTLS-1.2

2024-06-20 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit test to verify corrupted padding bytes in DTLS-1.2 record Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 17 + 1 file changed, 17 insertions(+) diff --git a/app/test/test_cryptodev.c b/a

[PATCH v2 4/7] test/crypto: verify padding corruption in TLS-1.2

2024-06-20 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit test to verify corrupted padding bytes in TLS-1.2 record Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 18 +- app/test/test_cryptodev_security_tls_record.c | 7 +

[PATCH v2 3/7] test/security: add TLS 1.3 data walkthrough tests

2024-06-20 Thread Aakash Sasidharan
Add combined mode data walkthrough test and multi-segmented packet data walkthrough test for TLS 1.3. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/t

[PATCH v2 2/7] test/crypto: add combined mode cases for TLS 1.3

2024-06-20 Thread Aakash Sasidharan
Add cases to try TLS 1.3 record write(encrypt) + read(decrypt) operations. This is used for testing TLS 1.3 record features with all algorithms supported by the security device. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 17 + 1 file changed, 17 insertions(+

[PATCH v2 0/7] Improvements and new test cases

2024-06-20 Thread Aakash Sasidharan
v2: * Remove unused variables from tests for padding corruption. Adding new test cases and improvements to test application. Aakash Sasidharan (4): test/crypto: add combined mode cases for TLS 1.3 test/security: add TLS 1.3 data walkthrough tests test/security: add out of place sgl tests fo

[PATCH v2 1/7] test/crypto: unit tests for padding for TLS-1.3

2024-06-20 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the padding for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 94438c

Re: [PATCH v2 3/6] net/octeon_ep: properly include vector API header file

2024-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2024 09:24:49 +0200 Mattias Rönnblom wrote: > The octeon_ip driver relied on , but failed to provide a > direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Stephen Hemminger

Re: Coding Style for local variables

2024-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2024 11:02:21 +0200 Morten Brørup wrote: > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > > > 10/06/2024 18:31, Konstantin Ananyev: > > > > > Morten said: > > > > > > The coding sty

Re: [PATCH v2 084/148] net/ice/base: add function to read SDP section from NVM

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:18PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Add API and definitions related to reading SDP section from NVM, related to > PTP > pins assignment. > Not familiar with the acronym here, so checked datasheet: SDP == Software Definable Pin??? /Bruce

Re: [PATCH v2 5/6] fib: properly include vector API header file

2024-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2024 10:14:18 +0100 Bruce Richardson wrote: > On Thu, Jun 20, 2024 at 09:24:51AM +0200, Mattias Rönnblom wrote: > > The trie implementation of the fib library relied on , but > > failed to provide a direct include of this file. > > > > Signed-off-by: Mattias Rönnblom > > --- >

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-06-20 Thread Kundapura, Ganapati
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, June 13, 2024 11:34 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; Mcnamara, John > ; Richardson, Bruce > > Cc: Morten Brørup ; ferruh.yi...@amd.com; > fanzhang@gmail.com; tho...@monjalon.net

rte_bitmap_free() Re: DPDK Coverity issue 426433

2024-06-20 Thread Boyer, Andrew
Hello John, While Coverity is correct that this is a useless call, that's an internal implementation detail of rte_bitmap_free() - not really something the caller should know about. Can we annotate rte_bitmap_free() in some way to eliminate these? This is not the first PMD that's had this issue

Re: [PATCH 2/4] dts: Use First Core Logic Change

2024-06-20 Thread Nicholas Pratte
On Fri, Jun 14, 2024 at 2:09 PM Jeremy Spewock wrote: > > On Thu, Jun 13, 2024 at 4:21 PM Nicholas Pratte wrote: > > > > Removed use_first_core from the conf.yaml in favor of determining this > > within the framework. use_first_core continue to serve a purpose in that > > it is only enabled when

Re: [PATCH v2 073/148] net/ice/base: remove unused define

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:07PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > In a previous patch a define was added that is not used. This is causing > issues > with CI builds. > > Signed-off-by: Dave Ertman > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_sched.c | 1

Re: [PATCH v2 072/148] net/ice/base: update strict status when assigning BW limits

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:06PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > In the BW configuration performed by DCF functions, the strict/WFQ and > priority > field (referred to as Generic in the EAS) is not updated in the FW. This > needs > to be updated so as to not incorrectly

Re: [PATCH v3 1/6] net/fm10k: add missing vector API header include

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 01:50:22PM +0200, Mattias Rönnblom wrote: > The fm10k PMD relied on , but failed to provide a direct > include of this file. > > Signed-off-by: Mattias Rönnblom > Acked-by: Bruce Richardson > --- > drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + > 1 file changed, 1 insertion(+

[PATCH] net/*: replace intrinsic header include with rte_vect

2024-06-20 Thread Bruce Richardson
Rather than having the SSE code in each driver include tmmintrin.h, which often does not contain all needed intrinsics, e.g. _mm_cvtsi128_si64() for 32-bit x86 builds, we can just replace the include of ?mmintrin.h with rte_vect.h for all network drivers. Signed-off-by: Bruce Richardson --- driv

Re: [PATCH v5 3/5] event/dlb2: enhance DLB credit handling

2024-06-20 Thread Jerin Jacob
On Thu, Jun 20, 2024 at 2:31 AM Abdullah Sevincer wrote: > > This commit improves DLB credit handling scenarios when > ports hold on to credits but can't release them due to insufficient > accumulation (less than 2 * credit quanta). > > Worker ports now release all accumulated credits when back-to

Re: [PATCH v2 047/148] net/ice/base: added informational message for NAC topology

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:41PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Use proper bitmask to verify primary/secondary mode instead of whole 'mode' > field, which also includes other information. In the result, for Mode 2a for > example, 'secondary' mode was always reported which

Re: [PATCH v5 1/5] event/dlb2: add support for HW delayed token

2024-06-20 Thread Jerin Jacob
On Thu, Jun 20, 2024 at 2:37 AM Abdullah Sevincer wrote: > > In DLB 2.5, hardware assist is available, complementing the Delayed > token POP software implementation. When it is enabled, the feature > works as follows: > > It stops CQ scheduling when the inflight limit associated with the CQ > is r

[PATCH v3 2/6] event/dlb2: include headers for vector and memory copy APIs

2024-06-20 Thread Mattias Rönnblom
The DLB2 PMD depended on being included as a side-effect of being included. In addition, DLB2 used rte_memcpy() but did not include , but rather depended on other include files to do so. This patch addresses both of those issues. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson ---

[PATCH v3 5/6] fib: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The trie implementation of the fib library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson --- lib/fib/trie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287..74db886

[PATCH v3 6/6] eal: provide option to use compiler memcpy instead of RTE

2024-06-20 Thread Mattias Rönnblom
Provide build option to have functions in delegate to the standard compiler/libc memcpy(), instead of using the various custom DPDK, handcrafted, per-architecture rte_memcpy() implementations. A new meson build option 'use_cc_memcpy' is added. By default, the compiler/libc memcpy() is used. The

[PATCH v3 4/6] distributor: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The distributor library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson --- lib/distributor/rte_distributor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_

[PATCH v3 3/6] net/octeon_ep: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The octeon_ip driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/octeon_ep/otx_ep_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c ind

[PATCH v3 1/6] net/fm10k: add missing vector API header include

2024-06-20 Thread Mattias Rönnblom
The fm10k PMD relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson --- drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx

[PATCH v3 0/6] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-20 Thread Mattias Rönnblom
This patch set make DPDK library, driver, and application code use the compiler/libc memcpy() by default when functions in are invoked. The various custom DPDK rte_memcpy() implementations may be retained by means of a build-time option. This patch set only make a difference on x86, PPC and ARM.

Re: [PATCH v2 1/6] net/fm10k: add missing intrinsic include

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 01:40:42PM +0200, Mattias Rönnblom wrote: > On 2024-06-20 11:28, Bruce Richardson wrote: > > On Thu, Jun 20, 2024 at 09:24:47AM +0200, Mattias Rönnblom wrote: > > > Add missing include, to get the _mm_cvtsi128_si64 > > > prototype. > > > > > > Signed-off-by: Mattias Rönnbl

Re: [PATCH v2 1/6] net/fm10k: add missing intrinsic include

2024-06-20 Thread Mattias Rönnblom
On 2024-06-20 11:28, Bruce Richardson wrote: On Thu, Jun 20, 2024 at 09:24:47AM +0200, Mattias Rönnblom wrote: Add missing include, to get the _mm_cvtsi128_si64 prototype. Signed-off-by: Mattias Rönnblom --- drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + 1 file changed, 1 insertion(+) diff --g

DPDK Release Status Meeting 2024-06-20

2024-06-20 Thread Mcnamara, John
Release status meeting minutes 2024-06-20 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/updated working dat

Re: [PATCH v2 040/148] net/ice/base: add FW load status mask

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:34PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Add a mask used to extract FW load status from GL_MNG_FWSM. > > Signed-off-by: Jan Sokolowski > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_hw_autogen.h | 1 + > 1 file changed, 1 insertion(

Re: [PATCH v2 037/148] net/ice/base: fix NVM feature check

2024-06-20 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:31PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Add defines required by NVM feature check. Although not directly used in this > patch this change is required in order to better match upstream. > > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ic

RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Thursday, June 20, 2024 5:07 PM > To: Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM > IPsec operation > > > > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: op

Re: [PATCH v2 1/6] net/fm10k: add missing intrinsic include

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 09:24:47AM +0200, Mattias Rönnblom wrote: > Add missing include, to get the _mm_cvtsi128_si64 > prototype. > > Signed-off-by: Mattias Rönnblom > --- > drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/fm10k/fm10k_rxt

Re: [PATCH v2 5/6] fib: properly include vector API header file

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 09:24:51AM +0200, Mattias Rönnblom wrote: > The trie implementation of the fib library relied on , but > failed to provide a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Bruce Richardson

Re: [PATCH v2 4/6] distributor: properly include vector API header file

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 09:24:50AM +0200, Mattias Rönnblom wrote: > The distributor library relied on , but failed to provide > a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Bruce Richardson

Re: FW: compilation|FAILURE| pw(141419) sid(32237) job(PER_PATCH_BUILD12332)[v2,6/6] eal: provide option to use compiler memcpy instead of RTE

2024-06-20 Thread Bruce Richardson
On Thu, Jun 20, 2024 at 10:20:42AM +0200, Mattias Rönnblom wrote: > On 2024-06-20 10:11, Mattias Rönnblom wrote: > > > > > > -Original Message- From: sys_...@intel.com > > Sent: Thursday, 20 June 2024 09:55 To: test-rep...@dpdk.org; Mattias > > Rönnblom Subject: compilation|FAILURE| > >

  1   2   >