[PATCH v1 4/4] test/crypto: add modex tests for zero padded operands

2024-06-15 Thread Gowrishankar Muthukrishnan
Add modex tests for zero padded operands, as in ASN encoding. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 16 + app/test/test_cryptodev_mod_test_vectors.h | 71 ++ 2 files changed, 87 insertions(+) diff --git a/app/test/test

[PATCH v1 3/4] test/crypto: use common test function for mod tests

2024-06-15 Thread Gowrishankar Muthukrishnan
Use common test function for modex and modinv tests. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 238 ++--- app/test/test_cryptodev_asym_util.h| 18 -- app/test/test_cryptodev_mod_test_vectors.h | 206 ++ 3 f

[PATCH v1 2/4] test/crypto: remove unused variable in modex test data

2024-06-15 Thread Gowrishankar Muthukrishnan
Remove unused result_len from modex test data. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_mod_test_vectors.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/app/test/test_cryptodev_mod_test_vectors.h b/app/test/test_cryptodev_mod_test_vectors.h index c7

[PATCH v1 1/4] test/crypto: validate modex result from first nonzero value

2024-06-15 Thread Gowrishankar Muthukrishnan
At present, there is no specification of whether modex op output can carry leading zeroes without changing the value. OpenSSL strips leading zeroes, but other hardware need not be. Hence, when output is compared against expected result, validation could start from first non-zero. Fixes: 1ffefe00f1

[PATCH v1 0/4] test/crypto: enhance modex tests

2024-06-15 Thread Gowrishankar Muthukrishnan
This patch series enhances modex tests to: * use common test function in existing test vectors * add test for zero padded operands Gowrishankar Muthukrishnan (4): test/crypto: validate modex result from first nonzero value test/crypto: remove unused variable in modex test data test/crypto:

RE: [PATCH v2 0/3] malloc related cleanups

2024-06-15 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 15 June 2024 18.00 > > The type parameter for malloc is only used for tracing. > Fix documentation and don't pass through heap routines. > > Stephen Hemminger (3): > rte_malloc: document that type is for tracing >

Re: [PATCH] event: fix warning from useless snprintf

2024-06-15 Thread Stephen Hemminger
On Sat, 15 Jun 2024 13:43:16 +0200 Thomas Monjalon wrote: > 24/04/2024 21:10, Stephen Hemminger: > > On Wed, 24 Apr 2024 17:12:39 + > > "Van Haaren, Harry" wrote: > > > From: Stephen Hemminger > > > > "Van Haaren, Harry" wrote: > > > > > > From: Stephen Hemminger > > > > > > > > > >

[PATCH v2 3/3] event/sw: avoid snprintf truncation

2024-06-15 Thread Stephen Hemminger
The string used for rte_malloc_socket gets truncated. With Gcc-14, this warning is generated: ../drivers/event/sw/sw_evdev.c:263:3: warning: 'snprintf' will always be truncated; specified size is 12, but format string expands to at least 13 [-Wformat-truncation] 263 | snprin

[PATCH v2 2/3] eal: remove type argument from internal routines

2024-06-15 Thread Stephen Hemminger
The type argument is carried through malloc heap routines but never used there. It is only used a rte_malloc for tracing. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memzone.c | 6 ++--- lib/eal/common/malloc_heap.c| 39 - lib/eal/common/ma

[PATCH v2 1/3] rte_malloc: document that type is for tracing

2024-06-15 Thread Stephen Hemminger
The string type is only used for tracing and not used as documented by dump_stats. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_malloc.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/eal/include/rte_malloc.h b/lib/eal/include/rte_m

[PATCH v2 0/3] malloc related cleanups

2024-06-15 Thread Stephen Hemminger
The type parameter for malloc is only used for tracing. Fix documentation and don't pass through heap routines. Stephen Hemminger (3): rte_malloc: document that type is for tracing eal: remove type argument from internal routines event/sw: avoid snprintf truncation v2 - keep usage for traci

[PATCH v1 6/6] app/crypto-perf: support ECDSA

2024-06-15 Thread Gowrishankar Muthukrishnan
Added support for ECDSA SECP256R1 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 57 ++ app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 10 ++- app/test

[PATCH v1 5/6] app/crypto-perf: support SM2

2024-06-15 Thread Gowrishankar Muthukrishnan
From: Akhil Goyal Added support for SM2 asymmetric crypto performance. A new command line option is added to specify asymmetric operation type `--asym-op Type`. Type can be sign/verify/encrypt/decrypt. Example command: ./dpdk-test-crypto-perf --vdev crypto_openssl -c 0x30 -- \ --devtype crypto_

[PATCH v1 4/6] app/crypto-perf: add function to check asymmetric operation

2024-06-15 Thread Gowrishankar Muthukrishnan
Replace checking input option for every asymmetric test case by a function. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_test_common.c | 12 +++- app/test-crypto-perf/cperf_test_common.h | 2 ++ app/test-crypto-perf/cperf_test_latency.c| 7 --

[PATCH v1 3/6] app/crypto-perf: fix result location for asymmetric test

2024-06-15 Thread Gowrishankar Muthukrishnan
For asymmetric op, private test data should be stored after rte_crypto_asym_op struct. Fixes: a538d1d2d01e ("test/crypto-perf: extend asymmetric crypto throughput test") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_test_common.c | 6 -- app

[PATCH v1 2/6] app/crypto-perf: remove redundant local varriable

2024-06-15 Thread Gowrishankar Muthukrishnan
Remove redundant local variable used for asym session. Fixes: a29bb248988 ("cryptodev: hide asymmetric session structure") Fixes: 2973dbf93b4 ("security: hide session structure") Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 9 +++-- 1 file changed, 3 inse

[PATCH v1 1/6] app/crypto-perf: add modex groups test

2024-06-15 Thread Gowrishankar Muthukrishnan
Add perf tests for modex groups 5, 14, 15, 16, 17 and 18 based on RFC 3526. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_test_vectors.c | 570 +- app/test-crypto-perf/cperf_test_vectors.h | 4 +- 2 files changed, 571 insertions(+), 3 deletions(-)

[PATCH v1 0/6] app/crypto-perf: add asymmetric crypto tests

2024-06-15 Thread Gowrishankar Muthukrishnan
This patch series adds below asymmetric tests in crypto-perf tool: * MODEX group tests (RFC 3526) * SM2 tests * ECDSA P256R1 tests Akhil Goyal (1): app/crypto-perf: support SM2 Gowrishankar Muthukrishnan (5): app/crypto-perf: add modex groups test app/crypto-perf: remove redundant loc

Re: [PATCH] event: fix warning from useless snprintf

2024-06-15 Thread Thomas Monjalon
24/04/2024 21:10, Stephen Hemminger: > On Wed, 24 Apr 2024 17:12:39 + > "Van Haaren, Harry" wrote: > > From: Stephen Hemminger > > > "Van Haaren, Harry" wrote: > > > > > From: Stephen Hemminger > > > > > > > > > > With Gcc-14, this warning is generated: > > > > > ../drivers/event/sw/sw_evde

[PATCH] crypto/cnxk: fix ECDH pubkey verify

2024-06-15 Thread Gowrishankar Muthukrishnan
Fix dequeue operation for ECDH pubkey verify. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Fixes: 5c9025583167 ("crypto/cnxk: fix CN9K ECDH public key verification") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 23 +++

[PATCH] crypto/cnxk: fix coverity issues

2024-06-15 Thread Gowrishankar Muthukrishnan
Fix out-of-bound issues reported by coverity scan. Coverity issue: 403164, 403165, 403166, 403167, 403169, 403170, 403171, 403172, 403173, 403174, 403176, 403178, 403179, 403180 Fixes: 5686b573e4b ("crypto/cnxk: support SM2") Fixes: badc0c6f6d6 ("cryptodev: set private and public k

[PATCH] examples/fips_validation: fix coverity issues

2024-06-15 Thread Gowrishankar Muthukrishnan
Fix NULL dereference, out-of-bound, bad bit shift issues reported by coverity scan. Coverity issue: 384440, 384435, 384433, 384429 Fixes: 36128a67c27 ("examples/fips_validation: add asymmetric validation") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validatio