RE: [PATCH v4] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Morten Brørup
> From: Du, Frank [mailto:frank...@intel.com] > Sent: Friday, 24 May 2024 03.05 > > > From: Ferruh Yigit > > Sent: Thursday, May 23, 2024 9:32 PM > > > > On 5/23/2024 10:22 AM, Morten Brørup wrote: > > >> From: Frank Du [mailto:frank...@intel.com] > > >> Sent: Thursday, 23 May 2024 10.08 > > >> >

[PATCH v3] net/cpfl: get running host ID for CPFL PMD

2024-05-23 Thread Shaiq Wani
Check whether CPFL PMD runs on Host or ACC Signed-off-by: Shaiq Wani --- drivers/net/cpfl/cpfl_ethdev.c | 17 + drivers/net/cpfl/cpfl_ethdev.h | 5 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.

RE: [PATCH v4] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Du, Frank
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, May 23, 2024 9:32 PM > To: Morten Brørup ; Du, Frank > ; dev@dpdk.org > Cc: Loftus, Ciara > Subject: Re: [PATCH v4] net/af_xdp: fix umem map size for zero copy > > On 5/23/2024 10:22 AM, Morten Brørup wrote: > >> From: Frank Du

RE: [PATCH v5 16/32] baseband: replace use of fixed size rte_memcpy

2024-05-23 Thread Chautru, Nicolas
Hi Stephen, Still issue with indentation inconsistencies below. Thanks Nic > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, May 21, 2024 8:28 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chautru, Nicolas > ; Gagandeep Singh ; > Hemant Agrawal > Subject: [PATCH v5 16

RE: [PATCH v2] test/crypto: fix enqueue dequeue callback case

2024-05-23 Thread Kundapura, Ganapati
Hi, > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 23, 2024 6:19 PM > To: dev@dpdk.org > Cc: Kundapura, Ganapati ; Gujjar, > Abhinandan S ; fanzhang@gmail.com; > ano...@marvell.com; Akhil Goyal ; sta...@dpdk.org > Subject: [PATCH v2] test/crypto: fix enqueue dequeue ca

Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver

2024-05-23 Thread Tyler Retzlaff
On Thu, May 23, 2024 at 04:30:30PM +, Konstantin Ananyev wrote: > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, May 23, 2024 5:21 PM > > To: Zhangfei Gao > > Cc: Akhil Goyal ; Fan Zhang ; > > Ashish Gupta ; > > dev@dpdk.org > > Subject: Re: [PATCH 1/3] co

RE: [PATCH 1/3] compress/uadk: Introduce UADK compression driver

2024-05-23 Thread Konstantin Ananyev
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 23, 2024 5:21 PM > To: Zhangfei Gao > Cc: Akhil Goyal ; Fan Zhang ; > Ashish Gupta ; > dev@dpdk.org > Subject: Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver > > On Mon, 22 Apr 2024 14:31:00 +

[RFC 4/4] net/ice: remove use of VLAs

2024-05-23 Thread Konstantin Ananyev
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we can a

[RFC 3/4] net/ixgbe: remove use of VLAs

2024-05-23 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable length array

[RFC 2/4] gro: remove use of VLAs

2024-05-23 Thread Konstantin Ananyev
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then copy them t

[RFC 1/4] gro: fix overwrite unprocessed packets

2024-05-23 Thread Konstantin Ananyev
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/gro/r

[RFC 0/4] remove use of VLA

2024-05-23 Thread Konstantin Ananyev
From: Konstantin Ananyev To continue further work on VLA replacement for these series: https://patches.dpdk.org/project/dpdk/list/?series=31887 extra few patches to remove VLA for gro lib and ixgbe and ice PMDs. DISCLAIMER: I don't have ice and ixgbe HW available on my box, so didn't make a prope

RE: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-23 Thread Akhil Goyal
Hi Zhangfei, Overall, a well written driver. Please see below comment. > +static int > +uadk_compress_pmd_config(struct rte_compressdev *dev, > + struct rte_compressdev_config *config) > +{ > + char mp_name[RTE_MEMPOOL_NAMESIZE]; > + struct uadk_compress_priv *priv; >

[PATCH v2 1/1] net/cnxk: fix RSS config via ethdev configure API

2024-05-23 Thread skori
From: Sunil Kumar Kori Currently user passed RSS configuration is ignored via rte_eth_dev_configure() API. Instead default RSS setup is done by driver. Adding handling for user passed RSS configuration too via rte_eth_dev_configure(). Fixes: b75e0aca84b0 ("net/cnxk: add device configuration ope

Re: [PATCH v2] net/cpfl: get running host ID for CPFL PMD

2024-05-23 Thread Stephen Hemminger
On Thu, 23 May 2024 06:10:45 + Shaiq Wani wrote: > +static uint8_t > +get_running_host_id(void) > +{ > + struct utsname unameData; > + uint8_t host_id = CPFL_INVALID_HOST_ID; > + uname(&unameData); > > + if (uname(&unameData) != 0) { Why do it twice? > + PMD_INI

Re: [PATCH] net/cnxk: add RSS config via ethdev configure API

2024-05-23 Thread Jerin Jacob
On Wed, Apr 10, 2024 at 6:41 PM wrote: > > From: Sunil Kumar Kori > > Currently user passed RSS configuration is ignored via > rte_eth_dev_configure() API. Instead default RSS setup is done by > driver. Rewrite the git commit as fix and add Fixes: tag > > Adding handling for user passed RSS co

Re: [PATCH v4] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Ferruh Yigit
On 5/23/2024 10:22 AM, Morten Brørup wrote: >> From: Frank Du [mailto:frank...@intel.com] >> Sent: Thursday, 23 May 2024 10.08 >> >> The current calculation assumes that the mbufs are contiguous. However, >> this assumption is incorrect when the mbuf memory spans across huge page. >> To ensure that

[PATCH v2] test/crypto: fix enqueue dequeue callback case

2024-05-23 Thread Akhil Goyal
The enqueue/dequeue callback test cases were using the test_null_burst_operation() for doing enqueue/dequeue. But this function is only designed to be run for NULL PMD. Hence for other PMDs, the callback was not getting called. Now, used a function test_AES_CBC_HMAC_SHA1_encrypt_digest() which is n

Re: [PATCH 2/2] ARM64: Cross-Compilation Support

2024-05-23 Thread Jerin Jacob
On Thu, May 23, 2024 at 5:56 PM Sebastian Brzezinka wrote: > > I re-uploaded this patch to get rid of the banner added by the mail service, > so there are no meaningful changes added to v2. > > > Is aarch64-none-linux* latest compiler? > > According to https://developer.arm.com/downloads/-/gnu-a,

Re: [PATCH 2/2] ARM64: Cross-Compilation Support

2024-05-23 Thread Sebastian Brzezinka
I re-uploaded this patch to get rid of the banner added by the mail service, so there are no meaningful changes added to v2.  > Is aarch64-none-linux* latest compiler? According to https://developer.arm.com/downloads/-/gnu-a, there is no toolchain named aarch64-linux-gnu*. 

[PATCH] doc: add firmware update links in mlx5 guide

2024-05-23 Thread Thomas Monjalon
If using upstream kernel and libraries, there was no direct link to download the firmware and update tool. Firmware update explanations are reorganized and include all links. Signed-off-by: Thomas Monjalon --- doc/guides/platform/mlx5.rst | 41 +--- 1 file changed

[DPDK/other Bug 1445] [dpdk-24.07] dpdk-test-dma-perf hang on Ubuntu24.04

2024-05-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1445 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Resolution|--- |INVALID Status|UNCON

RE: [PATCH v4] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Morten Brørup
> From: Frank Du [mailto:frank...@intel.com] > Sent: Thursday, 23 May 2024 10.08 > > The current calculation assumes that the mbufs are contiguous. However, > this assumption is incorrect when the mbuf memory spans across huge page. > To ensure that each mbuf resides exclusively within a single pa

Re: [PATCH v2] doc: update LTS maintenance to 3 years

2024-05-23 Thread Xueming Li
LGTM Acked-by: Xueming Li From: Kevin Traynor Sent: Thursday, May 23, 2024 5:12 PM To: Luca Boccassi ; Morten Brørup Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; dev@dpdk.org ; david.march...@redhat.com ; christian.ehrha...@canonical.com ; Xueming Li ; ferruh

Re: [PATCH v2] doc: update LTS maintenance to 3 years

2024-05-23 Thread Kevin Traynor
Ping Xueming/Christian, Any comment on this, can you ack if you think it's a good idea ? On 28/03/2024 10:25, Kevin Traynor wrote: > On 28/03/2024 10:01, Luca Boccassi wrote: >> On Mon, 25 Mar 2024 at 10:02, Morten Brørup >> wrote: >>> From: Thomas Monjalon [mailto:tho...@monjalon.net] >>>

RE: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined

2024-05-23 Thread Kundapura, Ganapati
Hi Akhil Agreed that callbacks are not getting called if not NULL PMD as it is designed to be run for NULL PMD. Tested your patch with qat pmd and callbacks are getting called. Both the patches can go in. + --- + + Test Suite : Crypto Gener

[PATCH v4] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Frank Du
The current calculation assumes that the mbufs are contiguous. However, this assumption is incorrect when the mbuf memory spans across huge page. To ensure that each mbuf resides exclusively within a single page, there are deliberate spacing gaps when allocating mbufs across the boundaries. Correc

RE: [v1 2/2] app/testpmd: introduce VXLAN-GBP and VXLAN-GPE fields

2024-05-23 Thread Ori Kam
> -Original Message- > From: Minggang(Gavin) Li > Sent: Friday, May 17, 2024 11:08 AM > Subject: [v1 2/2] app/testpmd: introduce VXLAN-GBP and VXLAN-GPE fields > > After unification of VXLAN and all its extension protocols(VXLAN-GPE and > VXLAN-GBP currently), all related RTE items shou

RE: [PATCH v2] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Du, Frank
> -Original Message- > From: Morten Brørup > Sent: Thursday, May 23, 2024 3:41 PM > To: Du, Frank ; Ferruh Yigit ; > dev@dpdk.org; Andrew Rybchenko ; Burakov, > Anatoly > Cc: Loftus, Ciara > Subject: RE: [PATCH v2] net/af_xdp: fix umem map size for zero copy > > > From: Du, Frank [mailt

RE: [PATCH v2] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Morten Brørup
> From: Du, Frank [mailto:frank...@intel.com] > Sent: Thursday, 23 May 2024 08.56 > > > From: Morten Brørup > > Sent: Wednesday, May 22, 2024 3:27 PM > > > > > From: Du, Frank [mailto:frank...@intel.com] > > > Sent: Wednesday, 22 May 2024 03.25 > > > > > > > From: Ferruh Yigit > > > > Sent: Wedn

[PATCH v1 3/3] net/mlx5: implement VXLAN last reserved modification

2024-05-23 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v1 1/3] ethdev: add VXLAN last reserved field

2024-05-23 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 6e8ab1d4c7..b807713cec 100644 --- a/lib/ethdev/rte_flow

[PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command

2024-05-23 Thread Rongwei Liu
Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 60ee9337cf..9e

[PATCH v1 0/3] support VXLAN rsvd1 modification

2024-05-23 Thread Rongwei Liu
Support to modify VXLAN the last byte reserved field. Rongwei Liu (3): ethdev: add VXLAN last reserved field app/testpmd: add VXLAN last reserved modification command net/mlx5: implement VXLAN last reserved modification app/test-pmd/cmdline_flow.c | 4 ++-- doc/guides/nics/mlx5.rst

[PATCH v3] net/af_xdp: fix umem map size for zero copy

2024-05-23 Thread Frank Du
The current calculation assumes that the mbufs are contiguous. However, this assumption is incorrect when the memory spans across a huge page. Correct to directly read the size from the mempool memory chunks. Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Cc: sta...@dpdk.org Si