[PATCH v2] net/af_xdp: fix umem map size for zero copy

2024-05-10 Thread Frank Du
The current calculation assumes that the mbufs are contiguous. However, this assumption is incorrect when the memory spans across a huge page. Correct to directly read the size from the mempool memory chunks. Signed-off-by: Frank Du --- v2: * Add virtual contiguous detect for for multiple memhdr

Re: [PATCH 0/3] Introduce UADK compression driver

2024-05-10 Thread Zhangfei Gao
On Mon, 22 Apr 2024 at 22:31, Zhangfei Gao wrote: > > Introduce a new compress PMD for hardware accelerators based on UADK [1]. > > UADK is a framework for user applications to access hardware accelerators. > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > the same page ta

Re: [RFC 0/3] generic sw counters

2024-05-10 Thread Stephen Hemminger
On Fri, 10 May 2024 19:29:48 +0200 Morten Brørup wrote: > ad, common functions are good. > > I'm somewhat skeptical about putting the stats structure first in the > rte_eth_dev_data's tx_queues and rx_queues. > These are void* because their types are private to the PMD. Putting the stats > str

RE: [RFC 0/3] generic sw counters

2024-05-10 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 10 May 2024 07.01 > > This is my attempt to demonstrate: > - generic counters for SW drivers, the example does af_packet and tap > but same should be applied to af_xdp, virtio, etc. > - counters are safe against

Re: [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf

2024-05-10 Thread Stephen Hemminger
On Fri, 10 May 2024 10:03:56 + Ciara Loftus wrote: > Record the port id in the af_xdp rx queue structure and use it > to set the port id of the mbuf of a received packed. > > Bugzilla ID: 1428 > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > cc: sta...@dpdk.og > > Reported-by: S

Re: [PATCH 3/3] net/af_xdp: Fix stats reset

2024-05-10 Thread Maryam Tahhan
On 10/05/2024 11:03, Ciara Loftus wrote: The imissed statistic was not properly reset because it was read directly from the kernel statistics. To fix this, take note of the kernel statistic when the stats are reset and deduct this value from the kernel statistic read during statistics get. Bugzi

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-10 Thread Maryam Tahhan
On 10/05/2024 11:03, Ciara Loftus wrote: Failures to allocate mbufs in the receive path were not being accounted for in the ethdev statistics. Fix this. Bugzilla ID: 1429 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-by: C

Re: [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf

2024-05-10 Thread Maryam Tahhan
On 10/05/2024 11:03, Ciara Loftus wrote: Record the port id in the af_xdp rx queue structure and use it to set the port id of the mbuf of a received packed. Bugzilla ID: 1428 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-b

[PATCH 3/3] net/af_xdp: Fix stats reset

2024-05-10 Thread Ciara Loftus
The imissed statistic was not properly reset because it was read directly from the kernel statistics. To fix this, take note of the kernel statistic when the stats are reset and deduct this value from the kernel statistic read during statistics get. Bugzilla ID: 1430 Fixes: f1debd77efaf ("net/af_x

[PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

2024-05-10 Thread Ciara Loftus
Failures to allocate mbufs in the receive path were not being accounted for in the ethdev statistics. Fix this. Bugzilla ID: 1429 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_et

[PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf

2024-05-10 Thread Ciara Loftus
Record the port id in the af_xdp rx queue structure and use it to set the port id of the mbuf of a received packed. Bugzilla ID: 1428 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rt

RE: [RFC v3] net/af_packet: make stats reset reliable

2024-05-10 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 10 May 2024 06.56 > > On Thu, 9 May 2024 16:19:08 +0200 > Morten Brørup wrote: > > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > Sent: Thursday, 9 May 2024 13.37 > > > > > > > From: Bruce Richardson

RE: [EXTERNAL] [PATCH v2] graph: fix does not return the unique id when create graph

2024-05-10 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Gongming Chen > Sent: Friday, May 10, 2024 12:26 PM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_...@163.com > Cc: dev@dpdk.org; Gongming Chen ; > sta...@dpdk.org; Fan Yin > Subject: [EXTERNAL] [PATCH v2] graph: fix

Re: [PATCH v1] vhost: fix crash caused by accessing a freed vsocket

2024-05-10 Thread Gongming Chen
Hi Maxime and Chenbo, Do you have any suggestions for how to address this? Looking forward to hearing from you! Thanks, Gongming > On Apr 3, 2024, at 11:52 PM, Gongming Chen > wrote: > > Hi Maxime, > Thanks for review. > >> On Apr 3, 2024, at 5:39 PM, Maxime Coquelin >> wrote: >> >> Hi G