The temporary array latencystats is not needed if the algorithm
is converted into one pass.
Signed-off-by: Stephen Hemminger
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/latencystats/rte_latencystats.c | 31 +++--
1 file changed, 16 insertions(+), 15 deletio
Do not need to recompute all the table indices.
Signed-off-by: Stephen Hemminger
---
lib/lpm/rte_lpm.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h
index 2888e5f4ca..9c6df311cb 100644
--- a/lib/lpm/rte_lpm.h
+++ b/lib/lpm/rte_lp
Recheck-request: iol-broadcom-Performance
On Mon, May 6, 2024 at 1:58 PM Tyler Retzlaff
wrote:
>
> This series converts all non-generic built atomics to use the rte_atomic
> macros that allow optional enablement of standard C11 atomics.
>
> Use of generic atomics for non-scalar types are not conv
On Mon, 6 May 2024 11:18:41 -0700
Tyler Retzlaff wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Tyler Retzlaff
See the alternate patch, the
On Mon, 6 May 2024 11:18:40 -0700
Tyler Retzlaff wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Tyler Retzlaff
> ---
> lib/gro/rte_gro.c |
On Mon, 6 May 2024 11:18:35 -0700
Tyler Retzlaff wrote:
> From: Konstantin Ananyev
>
> 1) ../lib/eal/common/eal_common_proc.c:695:15
> : warning: variable length array used
>
> As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
> it with fixed size array.
>
> Signed-off-by: Ko
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++--
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff
---
config/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/config/meson.build b/config/meson.build
index 8c8b019..
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c | 6 +++---
2 files chan
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/ice/ice_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++--
drivers/net/ixgbe/ixgbe_rxtx_vec_common.
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/idpf/idpf_common_rxtx.c| 2 +-
drivers/common/idpf/idpf_common_rxtx_av
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/i40e/i40e_testpmd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
d
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/cmdline.c| 2 +-
app/test-pmd/cmdline_flow.c | 9 -
app/test
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test/test.c | 2 +-
app/test/test_cmdline_string.c| 2 +-
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
lib/latencystats/rte_latencystats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
>From my understanding, tuple size here should never exceed
sizeof(union rte_thash_tuple), so it should be safe to replace VLA with
fixed size array.
Signed-off-by: Konstant
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
lib/lpm/rte_lpm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/lpm
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
lib/gro/rte_gro.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’
eal_intr_handle_interrupts() is called by eal_intr_thread_main()
so it seems ok to simply alloc space for events from heap and reuse the
same buffer through the life
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
---
lib/eal/common/eal_common_proc.c | 5 +++--
1 file cha
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/incl
On Mon, 6 May 2024 02:15:10 +0600
Fuji Nafiul wrote:
> I understand that I will need more cores and SSD, which I have. The thing
> is is there any current project available that exposes params to dump the
> highest possible rate with available resources? or I have to use the pdump
> framework and
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/test-bbdev/test_bbdev_perf.c | 183 +++
1 file changed, 110 insertions(+), 7
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/test-compress-perf/comp_perf_test_common.h | 2 +-
app/test-compress-perf/comp_perf_test_cyclecount.c | 4
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/test-crypto-perf/cperf_test_latency.c| 6 +++---
app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 10
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/test-eventdev/test_order_atq.c| 4 ++--
app/test-eventdev/test_order_common.c | 5 +++--
app/test-eventdev/t
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/test/test_bpf.c| 46 -
app/test/test_distributor.c| 114 +++
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
app/dumpcap/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/dumpcap/main
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
examples/bbdev_app/main.c | 13 +
examples/l2fwd-event/l2fwd_common.h
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/bus/vmbus/rte_vmbus_reg.h | 2 +-
drivers/bus/vmbus/vmbus_channel.c | 8
2 files changed, 5 inserti
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/common/cpt/cpt_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/c
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/dma/idxd/idxd_internal.h | 2 +-
drivers/dma/idxd/idxd_pci.c | 9 +
2 files changed, 6 insertio
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/crypto/ccp/ccp_dev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/cry
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/event/dlb2/dlb2.c| 34 +-
drivers/event/dlb2/dlb2_priv.h | 13
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/dri
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/txgbe/txgbe_ethdev.c| 12 +++-
drivers/net/txgbe/txgbe_ethdev.h| 2 +-
drivers/net/txgb
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/baseband/acc/rte_acc100_pmd.c | 36 +--
drivers/baseband/acc/rte_vrb_pmd.c| 46 +
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/common/iavf/iavf_impl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/comm
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/common/idpf/idpf_common_device.h | 6 +++---
drivers/common/idpf/idpf_common_rxtx.c| 14 ++
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/common/mlx5/linux/mlx5_nl.c | 5 +--
drivers/common/mlx5/mlx5_common.h | 2 +-
drivers/common/ml
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/dma/skeleton/skeleton_dmadev.c | 5 +++--
drivers/dma/skeleton/skeleton_dmadev.h | 2 +-
2 files changed, 4
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
Reviewed-by: Mattias Rönnblom
---
drivers/event/dsw/dsw_evdev.h | 6 +++---
drivers/event/dsw/dsw_event.c | 47 +
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/event/octeontx/timvf_evdev.h | 8
drivers/event/octeontx/timvf_worker.h | 36 +---
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/event/opdl/opdl_ring.c | 80 +-
1 file changed, 40 insertions(+), 40
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/raw/ifpga/ifpga_rawdev.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/driver
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/vdpa/mlx5/mlx5_vdpa.c | 24 +-
drivers/vdpa/mlx5/mlx5_vdpa.h | 14 +-
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/qede/base/bcm_osal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/n
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/idpf/idpf_ethdev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/ne
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/hinic/hinic_pmd_rx.c | 2 +-
drivers/net/hinic/hinic_pmd_rx.h | 2 +-
2 files changed, 2 insertions(+),
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/virtio/virtio_ring.h | 4 +--
drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 +++
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/thunderx/nicvf_rxtx.c | 9 +
drivers/net/thunderx/nicvf_struct.h | 4 ++--
2 files changed, 7
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/memif/memif.h | 4 ++--
drivers/net/memif/rte_eth_memif.c | 50 +++-
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/gve/base/gve_osdep.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/cxgbe/clip_tbl.c | 12 ++--
drivers/net/cxgbe/clip_tbl.h | 2 +-
drivers/net/cxgbe/cxgbe_ma
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/octeontx/octeontx_ethdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/d
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
dif
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/octeon_ep/cnxk_ep_rx.h| 5 +++--
drivers/net/octeon_ep/cnxk_ep_tx.c| 5 +++--
drivers/net/octeon
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_cpr.h | 4 ++--
drivers/net/bnxt/bnxt_rxq.h | 2 +-
drivers/net/bnxt/bnx
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/cpfl/cpfl_ethdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/n
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/i40e/i40e_ethdev.c| 4 ++--
drivers/net/i40e/i40e_rxtx.c | 6 +++---
drivers/net/i40e/i
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/ice/base/ice_osdep.h | 4 ++--
drivers/net/ice/ice_dcf.c| 6 +++---
drivers/net/ice/ice_dcf.h
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/hns3/hns3_cmd.c | 18 ++--
drivers/net/hns3/hns3_dcb.c | 2 +-
drivers/net/hns3/hns
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 +-
drivers/net/mlx5/linux/mlx5_verbs.c | 9 ++-
drivers/net/mlx
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/ixgbe/ixgbe_ethdev.c | 14 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ix
Replace the use of gcc builtin __atomic_xxx intrinsics with
corresponding rte_atomic_xxx optional rte stdatomic API.
Signed-off-by: Tyler Retzlaff
Acked-by: Stephen Hemminger
---
drivers/net/iavf/iavf.h | 16
drivers/net/iavf/iavf_rxtx.c | 4 ++--
driver
This series converts all non-generic built atomics to use the rte_atomic
macros that allow optional enablement of standard C11 atomics.
Use of generic atomics for non-scalar types are not converted in this
change and will be evaluated as a part of a separate series.
Specifically conversion of lib/
On Fri, May 03, 2024 at 07:35:48PM +0100, Daniel Gregory wrote:
> Missed during commit 1ec6a845b5cb
> ("eal: use stdatomic API in public headers")
>
> Signed-off-by: Daniel Gregory
> ---
Acked-by: Tyler Retzlaff
Hello,
On Tue, Mar 5, 2024 at 11:37 AM Mingjin Ye wrote:
> /**
> * Structure to store private data for each PF/VF instance.
> */
> @@ -599,6 +610,8 @@ struct ice_adapter {
> struct ice_devargs devargs;
> enum ice_pkg_type active_pkg_type; /* loaded ddp package type */
>
Allowing the replacement of a miss table without enforcing
a previous disconnecting. This feature extension allows the
user to change the destination miss table when the system
runs without losing traffic.
Fixes: b81f95ca770d ("net/mlx5/hws: support default miss table")
Cc: sta...@dpdk.org
Signed
From: Hamdan Igbaria
The debug print of only_term param in the action template
was printed incorrectly.
Fixes: 78580cf4e796 ("net/mlx5/hws: add debug layer")
Cc: sta...@dpdk.org
Signed-off-by: Hamdan Igbaria
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_debug.c | 2 +-
1 file changed
From: Hamdan Igbaria
Dump action ste arrays info for resizing matchers.
Signed-off-by: Hamdan Igbaria
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_debug.c | 23 +++
drivers/net/mlx5/hws/mlx5dr_debug.h | 1 +
drivers/net/mlx5/hws/mlx5dr_matcher.c | 1 +
drive
From: Alex Vesker
In case decapL3 action is created we would access header
data even in case the SHARED flag is not set, this would
lead to an invalid memory access.
Fixes: 3a6c50215c07 ("net/mlx5/hws: support multi-pattern")
Cc: sta...@dpdk.org
Signed-off-by: Alex Vesker
Acked-by: Matan Azrad
From: Erez Shitrit
Save the exact tag when matching over jumbo masking.
Fixes: 348cdeec6472 ("net/mlx5/hws: add FW WQE rule creation logic")
Cc: sta...@dpdk.org
Signed-off-by: Erez Shitrit
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_rule.c | 9 +++--
1 file changed, 7 insertion
From: Alex Vesker
Requesting the user for number of action resources is
not defined well enough, instead the user should provide
an initial action template which should contain the
future attached action templates.
Signed-off-by: Alex Vesker
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5
Improving code readability by following code styles such as mlx5dr prefix
and extracting a support check to an external function call.
Also, reducing unneeded static memory allocation using a bounded size
macro.
Fixes: 88ff41793e7a ("net/mlx5/hws: reorder STE fields to improve hash")
Cc: sta...@dp
From: Yevgeny Kliteynik
Simplify the code that does CQ poll - have DB record
update as part of CQ polling.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx
From: Yevgeny Kliteynik
Instead of passing 0 as an enum parameter, define flag NONE.
This resolves the following code analysis error: "enumerated
type mixed with another type".
This value is currently used in tests only, and will later
be used in backward-compatible steering API.
Fixes: 5cadd74f
From: Yevgeny Kliteynik
Add missing spinlock destruction in error flow.
Fixes: b0290e56dd08 ("net/mlx5/hws: add context object")
Cc: sta...@dpdk.org
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_context.c | 1 +
1 file changed, 1 insertion(+)
diff --
From: Yevgeny Kliteynik
Small simplification to the send_queues_close code
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c
b/drivers/n
From: Yevgeny Kliteynik
mlx5dr_rule_create returns -ret, so internal functions should return
rte_errno on failure. Fix return values of the function that creates
rule in root table.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +-
1 file ch
From: Yevgeny Kliteynik
The following caps were never in use:
- wire_regc
- metadata_c
- metadata_c_mask
Also send ring's reg_addr field wasn't in use.
Removing these caps and fields from structs and removing
the code that queried them.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
From: Yevgeny Kliteynik
Remove comment that documents parameter that doesn't exist.
Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")
Cc: sta...@dpdk.org
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.h | 2 --
1 file changed, 2 deletions(-)
d
From: Yevgeny Kliteynik
Fix wrong reserved size and add helpful comment
Fixes: 365cdf5f8ce7 ("net/mlx5/hws: add command layer")
Cc: sta...@dpdk.org
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/common/mlx5/mlx5_prm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletio
From: Erez Shitrit
When the user tries to create a matcher and if failed with specific
errno (E2BIG) the message will be in debug level and not in warning.
It is a part of a feature when the user re-try to insert a new matching
depends on that errno, no need the annoying message.
Fixes: c55c2bf
On Sun, May 5, 2024 at 11:38 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Sun, 5 May 2024 22:42:57 +0300
> Abdullah Ömer Yamaç wrote:
>
> > > Also, this looks wrong. The initialized arrays looked better before.
> > >
> > >
> > > -static const char *tuntap_types[ETH_TUNTAP_TYPE_
+ Arm team to the loop.
Removed invalid email address.
From: Daniel Gregory
Date: Saturday, May 4, 2024 at 2:27 AM
To: Ruifeng Wang
Cc: dev@dpdk.org , Punit Agrawal ,
Liang Ma , Daniel Gregory
, Feifei Wang
Subject: [PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant
The ARM implementat
https://bugs.dpdk.org/show_bug.cgi?id=1436
Luca Boccassi (luca.bocca...@gmail.com) changed:
What|Removed |Added
CC||luca.bocca...@gmail.com
Keep per-lcore power intrinsics state in a lcore variable to reduce
cache working set size and avoid any CPU next-line-prefetching causing
false sharing.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
---
lib/eal/x86/rte_power_intrinsics.c | 17 +++--
1 file changed, 11 ins
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
RFC v3:
* Replace for loop with FOREACH macro.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
---
lib/power/rte_power_pmd_mgmt.c | 34 ---
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a more cache-friendly lcore variable.
RFC v3:
* Remove cache alignment on unregistered threads' rte_rand_state.
(Morten Brørup)
Signed-off-by
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
RFC v6:
* Remove a now-redundant lcore variable value memset().
RFC v5:
* Fix lcore value pointer bug introduced by RFC v4.
RFC v4:
* Remove strange-looking lcore value l
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
small chunks of often-used data, which is related logically, but where
there are performan
Add test suite to exercise the API.
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check all lcore id's values for all variables in the many variables
test case.
* Introduce test case for max-sized lcore variables.
RFC v2:
* Improve alignment-relate
1 - 100 of 104 matches
Mail list logo
