RE: [PATCH] maintainers: update for eal

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 30 April 2024 22.52 > > Add myself as a maintainer for eal and tests. > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Morten Brørup

[PATCH] cmdline: configure input buffer size

DPDK defines cmdline input buffer size to 512 characters. That buffer size can be too small for long application input. For example, the following flow template API testpmd command is 444 bytes long: ``` flow queue 0 create 0 template_table 1000 \ pattern_template 0 actions_template 0 postpone no

[DPDK/ethdev Bug 1429] af_xdp driver does not count allocation failures

https://bugs.dpdk.org/show_bug.cgi?id=1429 Bug ID: 1429 Summary: af_xdp driver does not count allocation failures Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[DPDK/ethdev Bug 1428] af_xdp driver does not set rx port in mbuf

https://bugs.dpdk.org/show_bug.cgi?id=1428 Bug ID: 1428 Summary: af_xdp driver does not set rx port in mbuf Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [PATCH] devtools: add .clang-format file

> ... > > 1. Some options are failing for me [1], I don't know if it requires a > specific version of clang-format > I fixed these errors, and the clang-format version should be 17. I will send them after some discussions, as I've shared below. > > 2. Current options are not fully aligned with cod

Re: Run unit tests with C++ too

On Tue, Apr 30, 2024 at 4:13 PM Mattias Rönnblom wrote: > On 2024-04-30 15:52, Patrick Robb wrote: > > > > > > On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > > wrote: > > > > It would be great if the unit test suite (app/test/*) was compiled > (and > > r

[PATCH] maintainers: update for eal

Add myself as a maintainer for eal and tests. Signed-off-by: Tyler Retzlaff --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7abb3ae..c9adff9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -149,6 +149,7 @@ Environment Abstraction Layer T: git://

Re: [PATCH] maintainers: update maintainer for EAL API and Windows

adding dev@dpdk.org for review. On Fri, Feb 02, 2024 at 11:37:02AM +0100, Thomas Monjalon wrote: > 25/01/2024 18:57, Tyler Retzlaff: > > EAL API and common code > > +M: Tyler Retzlaff > > F: lib/eal/common/ > > F: lib/eal/unix/ > > F: lib/eal/include/ > > OK so this is just this simple line

Re: [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier

On Tue, Apr 30, 2024 at 10:06:08PM +0200, Mattias Rönnblom wrote: > On 2024-04-30 01:14, Tyler Retzlaff wrote: > >On Mon, Apr 29, 2024 at 06:21:13AM +, bugzi...@dpdk.org wrote: > >>https://bugs.dpdk.org/show_bug.cgi?id=1425 > >> > >> Bug ID: 1425 > >>Summary: enable_stda

[PATCH v2 8/9] crypto/ionic: add a watchdog operation

If no progress has been made within the timeout, post a dummy operation using session 0. This will restart the queue in the rare case that a doorbell is lost inside the device. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 16 drivers/crypto/ionic/ionic_crypto_m

[PATCH v2 6/9] crypto/ionic: add session support

This defines the session object and related commands. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 33 ++ drivers/crypto/ionic/ionic_crypto_main.c | 143 +++ drivers/crypto/ionic/ionic_crypto_ops.c | 123 +++ 3 files changed

[PATCH v2 9/9] crypto/ionic: add stats support

This defines the stats handlers and exposes them to the stack. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 8 drivers/crypto/ionic/ionic_crypto_main.c | 48 drivers/crypto/ionic/ionic_crypto_ops.c | 33 +++- 3 files chang

[PATCH v2 7/9] crypto/ionic: add datapath

This defines the main crypto operation enqueue and dequeue handlers. Signed-off-by: Andrew Boyer --- doc/guides/cryptodevs/features/ionic.ini | 8 + doc/guides/cryptodevs/ionic.rst | 11 + drivers/crypto/ionic/ionic_crypto.h | 17 ++ drivers/crypto/ionic/ionic_crypto_caps.c |

[PATCH v2 5/9] crypto/ionic: add capabilities and basic ops

This exposes the supported capabilities to the stack. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 3 ++ drivers/crypto/ionic/ionic_crypto_caps.c | 25 + drivers/crypto/ionic/ionic_crypto_main.c | 8 +++ drivers/crypto/ionic/ionic_crypto_ops.c | 66 ++

[PATCH v2 4/9] crypto/ionic: add adminq command support

This defines the adminq used for control path commands. The adminq is faster and more flexible than the device command interface. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 115 + drivers/crypto/ionic/ionic_crypto_cmds.c | 302 +++ driv

[PATCH v2 3/9] crypto/ionic: add device commands

This defines the device (register-based) commands. They are used for device identification, setup, and teardown. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 24 ++ drivers/crypto/ionic/ionic_crypto_cmds.c | 348 +++ drivers/crypto/ionic/ionic_c

[PATCH v2 2/9] crypto/ionic: add the firmware interface definition file

These definitions are shared between the PMD and firmware. Teach the device to read the FW version and check for liveness. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 53 ++ drivers/crypto/ionic/ionic_crypto_if.h | 1021 ++ drivers/crypto/io

[PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

Introduce a new crypto PMD for AMD Pensando hardware accelerators. It allows applications running directly on the AMD Pensando DSC to offload cryptographic operations to hardware cryptographic blocks. Add support for the cryptodevs to the common ionic library. Add the driver skeleton. Add a skelet

[PATCH v2 0/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

This patchset introduces a new crypto PMD for AMD Pensando hardware accelerators. It allows applications running directly on the AMD Pensando DSC to offload cryptographic operations to hardware cryptographic blocks. V2: - Remix patches as requested by review - Fix duplicated logtype global int - D

Re: Run unit tests with C++ too

On 2024-04-30 15:52, Patrick Robb wrote: On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > wrote: It would be great if the unit test suite (app/test/*) was compiled (and run) using a C++ (C++11) compiler as well. At least, if such is available. Sur

Re: [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier

On 2024-04-30 01:14, Tyler Retzlaff wrote: On Mon, Apr 29, 2024 at 06:21:13AM +, bugzi...@dpdk.org wrote: https://bugs.dpdk.org/show_bug.cgi?id=1425 Bug ID: 1425 Summary: enable_stdatomic=true breaks C++ on GCC 11 and earlier Produc

Re: [PATCH 3/5] dts: add parsing utility module

On Tue, Apr 30, 2024 at 6:49 AM Luca Vizzarro wrote: > > > > Is it simpler to default this to base 10? I assume that's what it'll > > be most of the time so we might as well allow users to skip this > > parameter. > > Base 0 just assumes the base of the number from the number prefix[1]. So > if i

[PATCH] doc: add power uncore API documentation

Add missing power uncore API documenttation. Fixes: ac1edcb6621a ("power: refactor uncore power management API") Cc: sta...@dpdk.org Reported-by: Vipin Varghese Signed-off-by: Ferruh Yigit --- Cc: Anatoly Burakov Cc: David Hunt Cc: Sivaprasad Tummala --- doc/api/doxy-api-index.md | 1 + 1 f

[PATCH v5 0/2] Methodology change for hugepage configuration

In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem

[PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Signed-off-by: Nicholas Pratte --- dts/conf.yaml

[PATCH v5 1/2] dts: Change hugepage runtime config to 2MB Exclusively

The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended during runtime. This new implementation allows on

[DPDK/core Bug 1427] BPF jit test errors on Arm

https://bugs.dpdk.org/show_bug.cgi?id=1427 Bug ID: 1427 Summary: BPF jit test errors on Arm Product: DPDK Version: 24.03 Hardware: ARM OS: All Status: UNCONFIRMED Severity: normal Priority: Norma

Re: Run unit tests with C++ too

On Tue, Apr 30, 2024 at 09:52:05AM -0400, Patrick Robb wrote: > On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > wrote: > > > It would be great if the unit test suite (app/test/*) was compiled (and > > run) using a C++ (C++11) compiler as well. At least, if such is available. > > > > Sure, the

Re: [PATCH v1] dts: clean up close in remote session

Makes perfect sense to me to just get rid of the unneeded method and argument, and the new order also makes things more clear. Reviewed-by: Jeremy Spewock

Re: [PATCH v1] dts: rename execution to test run

+1 for the new name, "execution" in the scope of the config file gets very confusing when people start talking about their individual runs or "executions" of the dts runner. I think test runs will serve as a much more specific name. Reviewed-by: Jeremy Spewock

Re: [RFC v2 5/6] eal: add atomic bit operations

On Fri, Apr 26, 2024 at 11:39:17AM +0200, Mattias Rönnblom wrote: [ ... ] > > > >> > >>The only reason for _Atomic being as it is, as far as I can see, is to > >>accommodate for ISAs which does not have the appropriate atomic machine > >>instructions, and thus require a lock or some other data as

[PATCH v9 4/4] hash: add SVE support for bulk key lookup

- Implemented SVE code for comparing signatures in bulk lookup. - New SVE code is ~5% slower than optimized NEON for N2 processor for 128b vectors. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Nathan Brown Reviewed-by: Ruifeng Wang --- lib/hash/arch/arm/compare_signatur

[PATCH v9 3/4] test/hash: check bulk lookup of keys after collision

This patch adds unit test for rte_hash_lookup_bulk(). It also update the test_full_bucket test to the current number of entries in a hash bucket. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- app/test/test_hash.c | 99 ++

[PATCH v9 2/4] hash: optimize compare signature for NEON

Upon a successful comparison, NEON sets all the bits in the lane to 1 We can skip shifting by simply masking with specific masks. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- lib/hash/arch/arm/compare_signatures.h | 24 +++- 1 file chan

[PATCH v9 1/4] hash: pack the hitmask for hash in bulk lookup

Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which allow a better cache usage and enable future improvemen

[PATCH v9 0/4] hash: add SVE support for bulk key lookup

This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having the primary and seco

Re: [PATCH v1 4/4] dts: refine pre-test setup and teardown steps

Reviewed-by: Jeremy Spewock

Re: [PATCH v1 3/4] dts: unify super calls

Reviewed-by: Jeremy Spewock

Re: [PATCH v1 2/4] dts: unify class inheritance from object

Reviewed-by: Jeremy Spewock

Re: [PATCH v1 1/4] dts: add tg node execution setup and teardown

Reviewed-by: Jeremy Spewock

Re: [bugfix] set same mac of bond slave

On Tue, 30 Apr 2024 09:17:30 +0800 Simon Jones wrote: > + for (i = 0; i < internals->slave_count; i++) { > + if (rte_eth_dev_default_mac_addr_set( > + internals->slaves[i].port_id, > +

[PATCH] net/af_packet: fix statistics

The statistics in af_packet driver do not follow the standard practice of other drivers: - Statistics should be maintained as 64 bit even on 32 bit. - Remove the tx_error counter since it was not correct. When transmit ring is full it is not an error and the driver correctly returns only

Queries on DPDK Trace Library usage

Hi Team / Jerin, I am trying to use DPDK Trace Library functionality in my DPDK application. I've successfully observed the trace files being generated by invoking rte_trace_save(), particularly when utilizing the EAL option '--trace=.*' I found following statement in the programmer guide, Th

DPDK 21.11.7 released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-21.11.7.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=21.11 This LTS release contains ~130 fixes from main branch up to DPDK 24.03. Thanks to the authors who helped with backports and to the

Re: Run unit tests with C++ too

On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom wrote: > It would be great if the unit test suite (app/test/*) was compiled (and > run) using a C++ (C++11) compiler as well. At least, if such is available. > Sure, the UNH Lab can try this. > > With the current state of affairs, header file ma

Re: [PATCH v7 00/14] fix lcore ID restriction

On 4/25/2024 1:31 PM, Ferruh Yigit wrote: > On 3/26/2024 12:55 PM, Sivaprasad Tummala wrote: >> With modern CPUs, it is possible to have higher >> CPU count thus we can have higher RTE_MAX_LCORES. >> In DPDK sample applications, the current config >> lcore options are hard limited to 255. >> >> The

[RFC v5 6/6] eal: add unit tests for atomic bit access functions

Extend bitops tests to cover the rte_bit_atomic_[set|clear|assign|test|test_and_[set|clear|assign]]() family of functions. RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: T

[RFC v5 1/6] eal: extend bit manipulation functionality

Add functionality to test, set, clear, and assign the value to individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. RFC v4: * Add rte_bit_flip() which, believe

[RFC v5 5/6] eal: add atomic bit operations

Add atomic bit test/set/clear/assign and test-and-set/clear functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. RFC v4: * Add atomic bit flip. * Mark macro-generated private functions experimental. RFC v3: * Work around lack of C++ support for

[RFC v5 4/6] eal: add unit tests for exactly-once bit access functions

Extend bitops tests to cover the rte_bit_once_[set|clear|assign|test]() family of functions. RFC v5: * Atomic bit op implementation moved from this patch to the proper patch in the series. (Morten Brørup) RFC v4: * Remove redundant continuations. Signed-off-by: Mattias Rönnblom Acked-by: M

[RFC v5 3/6] eal: add exactly-once bit access functions

Add bit test/set/clear/assign functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise

[RFC v5 2/6] eal: add unit tests for bit operations

Extend bitops tests to cover the rte_bit_[set|clear|assign|test]() family of functions. The tests are converted to use the test suite runner framework. RFC v4: * Remove redundant line continuations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/tes

[RFC v5 0/6] Improve EAL bit operations API

This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

Re: [RFC v4 4/6] eal: add unit tests for exactly-once bit access functions

On 2024-04-30 12:37, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Tuesday, 30 April 2024 11.55 Extend bitops tests to cover the rte_bit_once_[set|clear|assign|test]() family of functions. RFC v4: * Remove redundant continuations. Signed-off-by: Mat

Re: [PATCH 5/5] dts: add `show port stats` command to TestPmdShell

On 29/04/2024 16:54, Jeremy Spewock wrote: On Fri, Apr 12, 2024 at 7:11 AM Luca Vizzarro wrote: +output = self.send_command(f"show port stats {port_id}") Does this also need to skip the first line in the output? Yep, well spotted!

Re: [PATCH 3/5] dts: add parsing utility module

On 29/04/2024 17:15, Jeremy Spewock wrote: It would be helpful if this top level docstring explained more of how to use the text parser and some examples of using a small dataclass that chains some of these methods together. At first glance it wasn't clear to me why things were done the way they

RE: [RFC v4 4/6] eal: add unit tests for exactly-once bit access functions

> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Tuesday, 30 April 2024 11.55 > > Extend bitops tests to cover the > rte_bit_once_[set|clear|assign|test]() family of functions. > > RFC v4: > * Remove redundant continuations. > > Signed-off-by: Mattias Rönnblom > Acked-by

[RFC v4 4/6] eal: add unit tests for exactly-once bit access functions

Extend bitops tests to cover the rte_bit_once_[set|clear|assign|test]() family of functions. RFC v4: * Remove redundant continuations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/test/test_bitops.c | 10 + lib/eal/include/rte_bitops.h | 425

[RFC v4 6/6] eal: add unit tests for atomic bit access functions

Extend bitops tests to cover the rte_bit_atomic_[set|clear|assign|test|test_and_[set|clear|assign]]() family of functions. RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: T

[RFC v4 5/6] eal: add atomic bit operations

Add atomic bit test/set/clear/assign and test-and-set/clear functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. RFC v4: * Add atomic bit flip. * Mark macro-generated private functions experimental. RFC v3: * Work around lack of C++ support for

[RFC v4 3/6] eal: add exactly-once bit access functions

Add bit test/set/clear/assign functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise

[RFC v4 2/6] eal: add unit tests for bit operations

Extend bitops tests to cover the rte_bit_[set|clear|assign|test]() family of functions. The tests are converted to use the test suite runner framework. RFC v4: * Remove redundant line continuations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/tes

[RFC v4 1/6] eal: extend bit manipulation functionality

Add functionality to test, set, clear, and assign the value to individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. RFC v4: * Add rte_bit_flip() which, believe

[RFC v4 0/6] Improve EAL bit operations API

This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

RE: [PATCH] net/af_xdp: fix umem map size for zero copy

> > > > > Subject: [PATCH] net/af_xdp: fix umem map size for zero copy > > > > > > The current calculation assumes that the mbufs are contiguous. > > > However, this assumption is incorrect when the memory spans across a > huge > > page. > > > Correct to directly read the size from the mempool memo

Re: [PATCH v4] dts: Change hugepage runtime config to 2MB Exclusively

Please leave the context you're addressing. Reading this was a bit confusing and also hard to understand. On Mon, Apr 29, 2024 at 7:26 PM Nicholas Pratte wrote: > > I fixed the docstring under setup_hugepages in os_session, and I also > made a quick fix to the dts.rst documentation. For the dts.r