[DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier

2024-04-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1425 Bug ID: 1425 Summary: enable_stdatomic=true breaks C++ on GCC 11 and earlier Product: DPDK Version: 23.11 Hardware: All OS: Linux Status: UNCONFIRMED

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 28 April 2024 17.53 > > On 2024-04-26 17:17, Morten Brørup wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Friday, 26 April 2024 17.14 > >> > >> On Fri, 26 Apr 2024 14:20:01 +0200 > >> Morten

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 17:17, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Friday, 26 April 2024 17.14 On Fri, 26 Apr 2024 14:20:01 +0200 Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 14:20, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread safe has performance impact on datapath. Instead document APIs as not thread safe and add condit

Re: [RFC] net/af_packet: make stats reset reliable

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 13:33, Morten Brørup wrote: +static uint64_t +stats_get_diff(uint64_t stats, uint64_t offset) +{ + if (stats >= offset) + return stats - offset; + /* unlikely wraparound case */ + return UINT64_MAX + stats - offset; The numbers are unsigned, so wrap

Re: [RFC v2 5/6] eal: add atomic bit operations

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 14:00, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Friday, 26 April 2024 11.39 On 2024-04-25 18:18, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Thursday, 25 April 2024 16.36 On 2024-04-25 12:25, Morten Brør

Re: [RFC v2] net/af_packet: make stats reset reliable

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 16:38, Ferruh Yigit wrote: For stats reset, use an offset instead of zeroing out actual stats values, get_stats() displays diff between stats and offset. This way stats only updated in datapath and offset only updated in stats reset function. This makes stats reset function more rel

[DPDK/vhost/virtio Bug 1424] x710 ports Error attaching device to DPDK

2024-04-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1424 Bug ID: 1424 Summary: x710 ports Error attaching device to DPDK Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Run unit tests with C++ too

2024-04-28 Thread Mattias Rönnblom
It would be great if the unit test suite (app/test/*) was compiled (and run) using a C++ (C++11) compiler as well. At least, if such is available. With the current state of affairs, header file macros or functions are not verified to be functional (or even valid) C++. "C is a subset of C++",

[DPDK/eventdev Bug 1423] Using -fno-strict-aliasing when compiling DPDK unit tests reduces their effectiveness

2024-04-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1423 Bug ID: 1423 Summary: Using -fno-strict-aliasing when compiling DPDK unit tests reduces their effectiveness Product: DPDK Version: 23.11 Hardware: All OS: All