[PATCH] net/nfp: fix receive packets failed

From: Long Wu Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang ---

RE: [PATCH] graph: fix head move when graph walk in mcore dispatch

> -Original Message- > From: Wu, Jingjing > Sent: Thursday, March 21, 2024 11:39 AM > To: Yan, Zhirun ; dev@dpdk.org > Cc: jer...@marvell.com; pbhagavat...@marvell.com; sta...@dpdk.org > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch > > > > > -Origin

Re: [PATCH] net/ixgbe: do not update link status in secondary process

I tried this modification and it works as well. [root@compute3 /]# /dpdk/app/dpdk-dumpcap -i :18:00.0 File: /tmp/dpdk-dumpcap_0_:18:00.0_20240321043451.pcapng Capturing on ':18:00.0' Packets captured: 499 ^C Packets received/dropped on interface ':18:00.0': 499/0 (100.0) diff --gi

RE: [PATCH] graph: fix head move when graph walk in mcore dispatch

> -Original Message- > From: Yan, Zhirun > Sent: Wednesday, March 20, 2024 4:43 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: jer...@marvell.com; pbhagavat...@marvell.com; sta...@dpdk.org > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch > > > > > -Origin

Re: [PATCH 0/2] introduce PM QoS interface

Hi Moren, Thanks for your revew. 在 2024/3/20 22:05, Morten Brørup 写道: From: Huisong Li [mailto:lihuis...@huawei.com] Sent: Wednesday, 20 March 2024 11.55 The system-wide CPU latency QoS limit has a positive impact on the idle state selection in cpuidle governor. Linux creates a cpu_dma_latenc

RE: [PATCH 2/2] net/ice: Tx path check mbuf sub-segment

> -Original Message- > From: Mingjin Ye > Sent: Friday, March 15, 2024 6:24 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; sta...@dpdk.org > Subject: [PATCH 2/2] net/ice: Tx path check mbuf sub-segment > > Add check mbuf sub-segment to Tx diagnostic path. > > Fixes: 2a0244d611b4 ("net/ice: s

Re: [PATCH 0/3] support setting lanes

On 2024/3/20 20:31, Ferruh Yigit wrote: > On 3/18/2024 9:26 PM, Damodharam Ammepalli wrote: >> On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote: >>> >>> 12/03/2024 08:52, Dengdui Huang: Some speeds can be achieved with different number of lanes. For example, 100Gbps can be achiev

RE: [PATCH v3] dmadev: fix structure alignment

Hi, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 20, 2024 7:37 PM > To: fengcheng...@huawei.com; Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX ; sta...@dpdk.org > Subject: Re: [PATCH v3] dmadev: fix structure alignment > > 20/03/2024 08:23, Wenwu Ma: > > Th

Re: RFC acceptable handling of VLAs across toolchains

So just top posting to revive this discussion. i spent some time going through lib and drivers and the use of VLAs is very extensive. additionally, i have learned that there is some syntax improvement value in using them over alloca() in spite of neither being able to report allocation failure.

[PATCH v7 3/4] security: remove rte marker fields

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/release_24_03.rst | 3

[PATCH v7 4/4] cryptodev: remove rte marker fields

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/release_24_03.rst | 3

[PATCH v7 2/4] mbuf: remove rte marker fields

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Provide new rearm_data and rx_descriptor_fields1 fields in anonymous unions as

[PATCH v7 1/4] net/i40e: use inline prefetch function

Don't directly access the cacheline1 field in rte_mbuf struct for prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_r

[PATCH v7 0/4] remove use of RTE_MARKER fields in libraries

As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields. RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields. For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch. Prov

[PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

Use newly introduced __rte_constant(e) macro instead of directly using __builtin_constant_p() allowing mempool to be built by MSVC. Signed-off-by: Tyler Retzlaff --- lib/mempool/rte_mempool.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/l

[PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

MSVC does not have a __builtin_constant_p intrinsic so provide __rte_constant(e) that expands false for MSVC and to the intrinsic for GCC. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/e

[PATCH 0/2] provide toolchain abstracted __builtin_constant_p

Decouple direct dependency on GCC built-in __builtin_constant_p provide a new macro __rte_constant(e) that expands to the built-in for GCC and to false for MSVC. Tyler Retzlaff (2): eal: provide macro for GCC builtin constant intrinsic mempool: use rte constant macro instead of GCC builtin l

[PATCH] hash: provide crc32 functions based on intrinsics

Provide crc32 inline functions implemented using intrinsics for MSVC. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_crc_x86.h | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/lib/hash/rte_crc_x86.h b/lib/hash/rte_crc_x86.h inde

[PATCH] provide crc32 functions based on intrinsics for MSVC

MSVC does not support inline assembly so provide crc32 functions using intrinsics. Tyler Retzlaff (1): hash: provide crc32 functions based on intrinsics lib/hash/rte_crc_x86.h | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) -- 1.8.3.1

[PATCH 1/2] eal: provide movdiri for MSVC

MSVC does not support inline assembly instead it provides compiler intrinsics. Provide conditional compile for MSVC for movdiri using the _directstoreu_u32 intrinsic. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/include/rte_io.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/x8

[PATCH 2/2] eal: add rte ffs32 and rte ffs64 inline functions

provide toolchain abstraction for __builtin_ffs{,l,ll} gcc built-in intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_bitops.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index

[PATCH 0/2] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri for MSVC

MSVC does not support inline assembly so use movdiri intrinsic and provide abstracted rte_ffs{32,64} inline functions instead of directly using GCC built-ins. Tyler Retzlaff (2): eal: provide movdiri for MSVC eal: add rte ffs32 and rte ffs64 inline functions lib/eal/include/rte_bitops.h | 34

[PATCH 0/2] adapt prefetch functions for MSVC

MSVC does not have intrinsics that allow prefetch specifying read/write so adjust conditional compilation to allow MSVC to use the non access type inline functions from rte_prefetch.h While here fix issues with C++ build (which only appears on MSVC because it uses intrinsics and not inline assembl

[PATCH 1/2] eal: provide prefetch functions for MSVC

MSVC does not have an equivalent of __builtin_prefetch that allows read or read-write parameter. Introduce conditional compile expansion of rte_prefetch[0-2] inline functions when building with MSVC. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_prefetch.h | 12 1 fi

[PATCH 2/2] eal: adjust intrinsic type casts for CXX

_mm_prefetch does not take a volatile qualified pointer, cast it away. Additionally the pointer type should be char * not void * so adjust the cast to match. _mm_cldemote does not take a volatile qualified pointer, cast it away. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/include/rte_prefetch

[PATCH] net: stop using mmx intrinsics

Update code to use only avx/sse intrinsics as mmx is not supported on MSVC. Signed-off-by: Tyler Retzlaff --- lib/net/net_crc_avx512.c | 28 ++-- lib/net/net_crc_sse.c| 28 ++-- 2 files changed, 20 insertions(+), 36 deletions(-) diff --git a/l

[PATCH] stop using mmx intrinsics

MSVC does not support older MMX intrinsics use SSE/AVX instead. Tyler Retzlaff (1): net: stop using mmx intrinsics lib/net/net_crc_avx512.c | 28 ++-- lib/net/net_crc_sse.c| 28 ++-- 2 files changed, 20 insertions(+), 36 deletions(-) -- 1.8

[PATCH 09/15] net/iavf: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/net/iavf/iavf_ipsec_crypto.h | 3 +++ drivers/net/iavf/iavf_rxtx.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/iavf/iavf_ipsec_

[PATCH 11/15] net/mlx5: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/hws/mlx5dr.h | 1 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.h| 5 + drivers/net/mlx5/mlx5_hws_cnt.h | 1 + drive

[PATCH 15/15] examples: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- examples/common/neon/port_group.h | 1 + examples/ip_pipeline/cli.c| 5 + examples/ipsec-secgw/ipsec.h | 1 + examples/l3fwd-power/main.c | 2

[PATCH 12/15] net/octeon_ep: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/net/octeon_ep/otx_ep_mbox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/octeon_ep/otx_ep_mbox.h b/drivers/net/octeon_ep/otx_ep_mbox.h in

[PATCH 13/15] app/testpmd: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- app/test-pmd/csumonly.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 6711dda..638e607 100644 --- a/app

[PATCH 10/15] net/ice: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/base/ice_osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/ice_osdep.h index 0e14

[PATCH 06/15] common/mlx5: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common_mr.h| 4 drivers/common/mlx5/mlx5_common_utils.h | 1 + drivers/common/mlx5/mlx5_prm.h | 28 +

[PATCH 14/15] app/test: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- app/test/test_efd.c| 1 + app/test/test_hash.c | 1 + app/test/test_member.c | 1 + 3 files changed, 3 insertions(+) diff --git a/app/test/test_efd.c b/app/te

[PATCH 08/15] net/i40e: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/base/i40e_osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h ind

[PATCH 07/15] dma/ioat: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/dma/ioat/ioat_hw_defs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/ioat/ioat_hw_defs.h b/drivers/dma/ioat/ioat_hw_defs.h index dc3493a..

[PATCH 05/15] common/idpf: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/base/idpf_osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/idpf/base/idpf_osdep.h b/drivers/common/idpf/base/idpf_os

[PATCH 02/15] eal: pack structures when building with MSVC

Add __rte_msvc_pack to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_private.h | 1 + lib/eal/include/rte_memory.h | 1 + lib/eal/include/rte_memzone.h | 1 + lib/eal/include/rte_trace_point.h | 1 + lib/eal/

[PATCH 04/15] common/iavf: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- drivers/common/iavf/iavf_osdep.h| 2 ++ drivers/common/iavf/virtchnl_inline_ipsec.h | 11 +++ 2 files changed, 13 insertions(+) diff --git a/dr

[PATCH 03/15] net: pack structures when building with MSVC

Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing when building with MSVC. Signed-off-by: Tyler Retzlaff --- lib/net/rte_arp.h | 2 ++ lib/net/rte_dtls.h | 1 + lib/net/rte_esp.h | 2 ++ lib/net/rte_ether.h| 1 + lib/net/rte_geneve.h | 1 + lib/net/rte_g

[PATCH 00/15] fix packing of structs when building with MSVC

MSVC struct packing is not compatible with GCC provide a macro that can be used to push existing pack value and sets packing to 1-byte. The existing __rte_packed macro is then used to restore the pack value prior to the push. Instead of providing macros exclusively for MSVC and for GCC the existin

[PATCH 01/15] eal: provide pack start macro for MSVC

MSVC struct packing is not compatible with GCC provide a macro that can be used to push existing pack value and sets packing to 1-byte. The existing __rte_packed macro is then used to restore the pack value prior to the push. Instead of providing macros exclusively for MSVC and for GCC the existin

[PATCH 46/46] app/test-bbdev: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/test-bbdev/test_bbdev_perf.c | 183 +++ 1 file changed, 110 insertions(+), 73 deletions(-) diff --git a/

[PATCH 45/46] app/test-compress-perf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/test-compress-perf/comp_perf_test_common.h | 2 +- app/test-compress-perf/comp_perf_test_cyclecount.c | 4 ++-- app/test-compress-perf/

[PATCH 44/46] app/test-crypto-perf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/test-crypto-perf/cperf_test_latency.c| 6 +++--- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 10 +- app/test-crypto-p

[PATCH 43/46] app/test-eventdev: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 5 +++-- app/test-eventdev/test_order_common.h | 8 --

[PATCH 42/46] app/test: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/test/test_bpf.c| 46 - app/test/test_distributor.c| 114 - app/t

[PATCH 41/46] app/dumpcap: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- app/dumpcap/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index

[PATCH 40/46] examples: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- examples/bbdev_app/main.c | 13 + examples/l2fwd-event/l2fwd_common.h| 4 +-- examples/l2fwd-ev

[PATCH 39/46] bus/vmbus: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/bus/vmbus/vmbus_channel.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_channel.c

[PATCH 38/46] common/cpt: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/common/cpt/cpt_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_common.h b/drivers/com

[PATCH 37/46] crypto/ccp: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/crypto/ccp/ccp_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/c

[PATCH 36/46] dma/idxd: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/dma/idxd/idxd_internal.h | 2 +- drivers/dma/idxd/idxd_pci.c | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff -

[PATCH 35/46] event/dlb2: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/event/dlb2/dlb2.c| 34 +- drivers/event/dlb2/dlb2_priv.h | 10 +- drivers/event/dlb2/dl

[PATCH 34/46] net/null: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/null/rte_eth_null.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c

[PATCH 33/46] net/txgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/txgbe/txgbe_ethdev.c| 12 +++- drivers/net/txgbe/txgbe_ethdev.h| 2 +- drivers/net/txgbe/txgbe_ethdev_vf.c | 2 +-

[PATCH 32/46] baseband/acc: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- drivers/baseband/acc/rte_vrb_pmd.c| 46 +++---

[PATCH 31/46] common/iavf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/common/iavf/iavf_impl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/iavf/iavf_impl.c b/drivers

[PATCH 30/46] common/idpf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/idpf_common_device.h | 6 +++--- drivers/common/idpf/idpf_common_rxtx.c| 14 -- drivers/common/idpf

[PATCH 29/46] common/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/linux/mlx5_nl.c | 5 +-- drivers/common/mlx5/mlx5_common.h | 2 +- drivers/common/mlx5/mlx5_common_mr.c| 16 +

[PATCH 28/46] crypto/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/otx_c

[PATCH 27/46] dma/skeleton: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/dma/skeleton/skeleton_dmadev.c | 5 +++-- drivers/dma/skeleton/skeleton_dmadev.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)

[PATCH 26/46] event/dsw: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/event/dsw/dsw_evdev.h | 6 +++--- drivers/event/dsw/dsw_event.c | 34 +- drivers/event/dsw/dsw_xstats.

[PATCH 25/46] event/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/event/octeontx/timvf_evdev.h | 8 drivers/event/octeontx/timvf_worker.h | 36 +-- 2 files chan

[PATCH 24/46] event/opdl: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/event/opdl/opdl_ring.c | 80 +- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/d

[PATCH 23/46] raw/ifpga: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/raw/ifpga/ifpga_rawdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/

[PATCH 21/46] net/ring: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/ring/rte_eth_ring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/dri

[PATCH 22/46] vdpa/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/vdpa/mlx5/mlx5_vdpa.c | 24 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 14 +-- drivers/vdpa/mlx5/mlx5_vdp

[PATCH 20/46] net/qede: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/qede/base/bcm_osal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/bcm_osal.c b/dri

[PATCH 19/46] net/idpf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/idpf/idpf_ethdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/driver

[PATCH 18/46] net/hinic: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/hinic/hinic_pmd_rx.c | 2 +- drivers/net/hinic/hinic_pmd_rx.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH 17/46] net/virtio: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/virtio/virtio_ring.h | 4 +-- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 - drivers/net/virtio/vi

[PATCH 15/46] net/sfc: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/sfc/meson.build | 5 ++--- drivers/net/sfc/sfc_mae_counter.c | 30 +++--- drivers/net/sfc/sfc_repr_pro

[PATCH 16/46] net/thunderx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/thunderx/nicvf_rxtx.c | 9 + drivers/net/thunderx/nicvf_struct.h | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-)

[PATCH 14/46] net/memif: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/memif/memif.h | 4 ++-- drivers/net/memif/rte_eth_memif.c | 50 +++ 2 files changed, 27

[PATCH 13/46] net/gve: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/gve/base/gve_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/gve/base/gve_osdep.h b/drive

[PATCH 12/46] net/cxgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/cxgbe/clip_tbl.c | 12 ++-- drivers/net/cxgbe/clip_tbl.h | 2 +- drivers/net/cxgbe/cxgbe_main.c | 20 ++-

[PATCH 11/46] net/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/octeontx/octeontx_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/octeontx/octeontx_

[PATCH 10/46] net/octeon_ep: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/octeon_ep/cnxk_ep_rx.h| 5 +++-- drivers/net/octeon_ep/cnxk_ep_tx.c| 5 +++-- drivers/net/octeon_ep/cnxk_ep_vf.c| 8 -

[PATCH 09/46] net/af_xdp: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/af_xdp/rte_eth_af_xdp.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/af_xdp/

[PATCH 08/46] net/cpfl: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/cpfl/cpfl_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drive

[PATCH 06/46] net/hns3: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/hns3/hns3_cmd.c | 18 ++-- drivers/net/hns3/hns3_dcb.c | 2 +- drivers/net/hns3/hns3_ethdev.c| 36 ++

[PATCH 07/46] net/bnxt: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/bnxt/bnxt_cpr.h | 4 ++-- drivers/net/bnxt/bnxt_rxq.h | 2 +- drivers/net/bnxt/bnxt_rxr.c | 13 ++

[PATCH 05/46] net/i40e: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_ethdev.c| 4 ++-- drivers/net/i40e/i40e_rxtx.c | 6 +++--- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 +- 3

[PATCH 01/46] net/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 +- drivers/net/mlx5/linux/mlx5_verbs.c | 9 ++- drivers/net/mlx5/mlx5.c |

[PATCH 04/46] net/ice: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/base/ice_osdep.h | 4 ++-- drivers/net/ice/ice_dcf.c| 6 +++--- drivers/net/ice/ice_dcf.h| 2 +- drivers/net/i

[PATCH 03/46] net/iavf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_rxtx.c | 4 ++-- drivers/net/iavf/iavf_rxtx_vec_neon

[PATCH 02/46] net/ixgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_ethdev.c | 14 -- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- 3 fil

[PATCH 00/46] use stdatomic API

This series converts all non-generic built atomics to use the rte_atomic macros that allow optional enablement of standard C11 atomics. Use of generic atomics for non-scalar types are not converted in this change and will be evaluated as a part of a separate series. Note if this series ends up re

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

On Wed, Mar 20, 2024 at 6:08 AM Ferruh Yigit wrote: > > On 3/20/2024 6:06 AM, Gregory Etelson wrote: > > Hello Ferruh, > > > >>BUT overall how can we catch issues like this in the feature, we don't > >>have a good way to test testpmd flow commands. > >>@Ori, @Gregory, do you have any idea? > >>cc'

Re: [PATCH 00/83] move alignment attribute on types

On Wed, Mar 20, 2024 at 06:41:30PM +0100, David Marchand wrote: > Hello Tyler, > > On Wed, Mar 20, 2024 at 4:38 PM Tyler Retzlaff > wrote: > > > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > locati

[DPDK/other Bug 1405] Static Memory footprint large increase due to net/bnxt changes in 23.11

https://bugs.dpdk.org/show_bug.cgi?id=1405 Bug ID: 1405 Summary: Static Memory footprint large increase due to net/bnxt changes in 23.11 Product: DPDK Version: 23.11 Hardware: All OS: All Status:

pcapng_autotest unit test false positive

Hello Stephen, I noticed a (time based?) failure of the pcapng unit test in some UNH Debian 11 container. Please have a look. https://lab.dpdk.org/results/dashboard/patchsets/29604/ --- stdout --- RTE>>pcapng_autotest + ---

Re: [PATCH 00/83] move alignment attribute on types

Hello Tyler, On Wed, Mar 20, 2024 at 4:38 PM Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > and variables is not compatible with MSVC. There is only a single > location accepted by both toolchains. > > After having established this as the convent

RE: [PATCH 00/83] move alignment attribute on types

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 20 March 2024 16.51 > > On Wed, Mar 20, 2024 at 08:36:53AM -0700, Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is

RE: [PATCH v9 5/5] eal: add option to put timestamp on console output

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 20 March 2024 15.39 > > On Wed, 20 Mar 2024 09:34:21 +0100 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Wednesday, 20 March 2024 04.34 > > > > > > On Tue, 19

[PATCH] net/ixgbe: do not update link status in secondary process

The code to update link status is not safe in secondary process. If called from secondary it will crash, example from dumpcap: ixgbe_dev_link_update_share() ixgbe_dev_link_update() rte_eth_link_get() Signed-off-by: Stephen Hemminger Reported-by: Jun Wang --- Simpler versi

[PATCH] graph: expose node context as pointers

In some cases, the node context data is used to store two pointers because the data is larger than the reserved 16 bytes. Having to define intermediate structures just to be able to cast is tedious. Add two pointers that take the same space than ctx. Signed-off-by: Robin Jarry --- lib/graph/rte_

Re: [PATCH] net/ena: fix mbuf double free in fast free mode

On 3/20/2024 2:52 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Fixed an issue of double free of mbufs which is exposed > in mbuf fast free mode when handling multi-mbuf packets. > > The faulty patch mishandled free of non-head mbufs as it > iterated over linked mbufs and collected the

  1   2   3   >