[PATCH] compress/nitrox: fix dereference after null check

2024-03-12 Thread Nagadheeraj Rottela
In nitrox_check_comp_req() while updating the last byte during FINAL flush there is possibility of accessing null mbuf in two rare cases. First case is when the application changes the dst mbuf between enqueue and dequeue. Second case is when data length reported by hardware is greater than the mbu

[PATCH v4 21/21] test/security: add out of place sgl test case for TLS 1.2

2024-03-12 Thread Aakash Sasidharan
Add TLS 1.2 out-of-place multi-segmented packet test. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 52 ++- app/test/test_cryptodev_security_tls_record.h | 1 + 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/app/test/test_c

[PATCH v4 20/21] test/crypto: unit tests for padding in DTLS-1.2

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the padding for DTLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c ind

[PATCH v4 19/21] test/crypto: unit tests to verify padding in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the padding for TLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 85 ++- app/test/test_cryptodev_security_tls_record.c | 28 -- app/test/test_cryptodev_security_tls_record.h

[PATCH v4 18/21] test/crypto: test to verify zero len record in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with zero length. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptode

[PATCH v4 17/21] test/crypto: test to verify custom content type in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with content type as custom. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index

[PATCH v4 16/21] test/crypto: test to verify hdr corruption in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with header corruption. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

[PATCH v4 15/21] test/crypto: update framework to verify tls-1.3

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Update the fields in preparation of test descriptor. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 17 +--- app/test/test_cryptodev_security_tls_record.c | 43 --- app/test/test_cryptodev_security_tls_reco

[PATCH v4 14/21] test/crypto: add TLS 1.3 vectors

2024-03-12 Thread Aakash Sasidharan
From: Akhil Goyal Added vectors and test suite for TLS 1.3 AES-128-GCM, AES-256-GCM and CHACHA20-POLY1305 vectors. The vectors are generated using gnuTLS client server application. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 35 +++ app/test/test_cryptodev_s

[PATCH v4 13/21] test/crypto: update verification of header

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri In TLS 1.3, the version in the header would be TLS 1.2 and the content type would be APP irrespective of the type of the payload. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev_security_tls_record.c | 20 +-- 1 file changed, 14 insert

[PATCH v4 12/21] test/security: add more DTLS anti-replay window sz

2024-03-12 Thread Aakash Sasidharan
Add anti-replay tests for window sizes 128, 256, 512, 1024, 2048 and 4096 window sizes in DTLS 1.2 suite. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 72 +-- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/app/test/test_cryp

[PATCH v4 11/21] test/security: add DTLS 1.2 anti-replay tests

2024-03-12 Thread Aakash Sasidharan
Add anti-replay test for DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 115 ++- app/test/test_cryptodev_security_tls_record.c | 132 ++ app/test/test_cryptodev_security_tls_record.h | 11 +- 3 files changed, 188 insert

[PATCH v4 10/21] test/security: add TLS/DTLS 1.2 AES-256-SHA384 vectors

2024-03-12 Thread Aakash Sasidharan
From: Akhil Goyal Added vectors for TLS 1.2 and DTLS 1.2 using algos AES-256-CBC and HMAC-SHA384 Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 19 ++ app/test/test_cryptodev_security_tls_record.h | 2 + ...yptodev_security_tls_record_test_vectors.h | 200 +++

[PATCH v4 09/21] test/security: add unit tests for DTLS-1.2

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify 1. DTLS record with zero length 2. DTLS record with header corruption 3. DTLS record with content type as custom Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 77 +++ 1 file changed, 7

[PATCH v4 08/21] test/security: unit test to verify zero TLS records

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the zero len TLS records. Zero len packets are allowed when content type is app data while zero packet length with other content type (such as handshake) would result in an error. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptode

[PATCH v4 07/21] test/cryptodev: allow zero packet length buffers

2024-03-12 Thread Aakash Sasidharan
From: Anoob Joseph The function 'create_segmented_mbuf' is updated to support zero packet length mbufs. This allows testing of zero packet length payload with TLS record processing. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.h | 20 +++- 1 file changed, 7 insertion

[PATCH v4 06/21] test/security: unit test for custom content verification

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit test to verify the TLS header creation with custom content type Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ app/test/test_cryptodev_security_tls_record.c | 3 +++ app/test/test_cryptodev_se

[PATCH v4 05/21] test/security: unit test for TLS packet corruption

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add test to verify the corrupted TLS packet header Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 27 +-- app/test/test_cryptodev_security_tls_record.c | 4 +++ app/test/test_cryptodev_security_tls_record.h |

[PATCH v4 04/21] test/security: add TLS SG data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add multi segment packet data walkthrough test for TLS 1.2 and DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 42 +++ app/test/test_cryptodev_security_tls_record.h | 2 +- 2 files changed, 43 insertions(+), 1 deletion(-) diff --gi

[PATCH v4 03/21] test/security: add DTLS 1.2 data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add data walkthrough test for DTLS 1.2 Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 17 + app/test/test_cryptodev_security_tls_record.c | 5 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/a

[PATCH v4 02/21] test/security: add TLS 1.2 data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add data walkthrough test for TLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 90 +-- app/test/test_cryptodev.h | 12 ++- app/test/test_cryptodev_security_tls_record.c | 25 -- app/test/test_cryptodev_security_

[PATCH v4 01/21] test/security: enable AES-GCM in combined mode TLS

2024-03-12 Thread Aakash Sasidharan
Enable AES-GCM AEAD tests in combined mode TLS test suite. Coverity issue: 414888 Fixes: 9157ccb8f876 ("test/crypto: verify TLS headers") Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev_security_tls_record.c | 10 -- app/test/test_security_proto.h| 3 +++ 2

[PATCH v4 00/21] Improvements and new test cases

2024-03-12 Thread Aakash Sasidharan
v4: * Set max ciphertext length for data walkthrough tests to 4k. v3: * Set max packet length for data walkthrough tests to 8k. v2: * Rebased. Aakash Sasidharan (7): test/security: enable AES-GCM in combined mode TLS test/security: add TLS 1.2 data walkthrough test test/security: add DTLS

[PATCH] test-pmd: add more packet decode options (verbose)

2024-03-12 Thread Stephen Hemminger
The existing verbose levels 1..3 provide a messy multi-line output per packet. This is unhelpful when diagnosing many types of problems like packet flow. This patch adds two new levels: 4: one line per packet is printed in a format resembling tshark output. With addresses and protocol info. 5:

[RFC] eal: add rte_counted_by attribute

2024-03-12 Thread Stephen Hemminger
Both Gcc 14 and clang support this in latest versions. Add to EAL first, then instrument flexible arrays. [1] https://reviews.llvm.org/D148381 [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_compat.h | 10 ++ 1 file change

RE: [PATCH v2 1/1] net/mana: add vlan tagging support

2024-03-12 Thread Long Li
> --- a/drivers/net/mana/rx.c > +++ b/drivers/net/mana/rx.c > @@ -532,6 +532,21 @@ mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, > uint16_t pkts_n) > mbuf->hash.rss = oob- > >packet_info[pkt_idx].packet_hash; > } > > + if (oob->rx_vlan_tag_pr

RE: [PATCH v2] net/netvsc: fix number Tx queues > Rx queues

2024-03-12 Thread Long Li
> a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index > 9bf1ec5509..c0aaeaa972 100644 > --- a/drivers/net/netvsc/hn_rxtx.c > +++ b/drivers/net/netvsc/hn_rxtx.c > @@ -243,6 +243,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev, { > struct hn_data *hv = dev->data->dev_private

[PATCH v4 31/31] net/ena: upgrade driver version to 2.9.0

2024-03-12 Thread shaibran
From: Shai Brandes upgrade driver version to 2.9.0. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 1707d5f2c2..7b697c

[PATCH v4 30/31] net/ena: control path pure polling mode

2024-03-12 Thread shaibran
From: Shai Brandes This commit implements a new operation mode that enables purely polling-based functionality, eliminating the need for interrupts in the control path. This mode is not activated by default and can be toggled using the "control_poll_interval" devarg. When operating in this mode,

[PATCH v4 29/31] net/ena: support max large llq depth from the device

2024-03-12 Thread shaibran
From: Shai Brandes Selected AWS instances from later generations enable large LLQ by default, allowing the transmission of packets with headers exceeding 96 bytes. Due to the overall ENA memory BAR size limitation, large LLQ has the side effect of halving the maximum number of LLQ entries (from

[PATCH v4 28/31] net/ena: exhaust interrupt callbacks in device close

2024-03-12 Thread shaibran
From: Shai Brandes Change rte_intr_callback_unregister to its synchronous variant to ensure all active interrupt callbacks are completed before proceeding with the flow. Relocate the interrupt deregistration to precede the release of stats memory, thereby preventing the interrupt handler from acc

[PATCH v4 27/31] net/ena: update device-preferred size of rings

2024-03-12 Thread shaibran
From: Shai Brandes Update the device-preferred size of the Tx ring to fall within the valid range when a large LLQ is enabled. For consistency, align the device-preferred size of the Rx ring accordingly. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c

[PATCH v4 26/31] net/ena/base: modify logs to use unsigned format specifier

2024-03-12 Thread shaibran
From: Shai Brandes Modify log prints to use correct format specifier for unsigned variables and removed line breaks for lines that do not exceed maximal line length. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_eth_com.c | 22 +++--- d

[PATCH v4 25/31] net/ena/base: modify customer metrics memory management

2024-03-12 Thread shaibran
From: Shai Brandes 1. Set buffer length to zero in case memory allocation failed and after memory is released. 2. The driver checks buffer_virt_addr for customer allocation success. In case the allocation fails, buffer_virt_addr may not necessarily be NULL. Signed-off-by: Shai Brandes

[PATCH v4 24/31] net/ena: cosmetic changes

2024-03-12 Thread shaibran
From: Shai Brandes This patch makes several changes to improve the style and readability of the code. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_com.c | 13 + drivers/net/ena/base/ena_plat_dpdk.h | 2 +- 2 files changed, 6 insertion

[PATCH v4 23/31] net/ena/base: add support for device reset request

2024-03-12 Thread shaibran
From: Shai Brandes Adds support for reset request message from the device to the driver, over AENQ, which in turn should cause the driver to trigger reset. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_defs/ena_admin_defs.h | 3 ++- drivers/net/ena/base/

[PATCH v4 22/31] net/ena/base: handle command abort

2024-03-12 Thread shaibran
From: Shai Brandes Currently admin_queue->stats.aborted_cmd counter is incremented if an admin command status is ENA_CMD_ABORTED and only if the admin queue is in polling mode. This commit fixes handling the case of incrementing admin_queue->stats.aborted_cmd if the admin queue is in interrupt mo

[PATCH v4 21/31] net/ena/base: remove operating system type enum

2024-03-12 Thread shaibran
From: Shai Brandes remove all other operating system enumeration as they are unrelated to DPDK. Use a constant value instead. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_defs/ena_admin_defs.h | 13 + drivers/net/ena/base/ena_plat_dpdk.h

[PATCH v4 20/31] net/ena/base: rework Rx ring submission queue

2024-03-12 Thread shaibran
From: Shai Brandes RX ring submission queue descriptors are always located in host memory This optimization replaces the generic update tail method with a tailored method for host memory type descriptors to avoid unnecessary if statement. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH v4 14/31] net/ena/base: phc feature modifications

2024-03-12 Thread shaibran
From: Shai Brandes 1. PHC algorithm is updated to support reading new PHC values. 2. Update default PHC expiration timeout. 3. Fix a theoretical PHC destroy race. 4. Adjust PHC for multiple devices. 5. PHC activation version check point. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH v4 18/31] net/ena/base: check for existing keep alive notification

2024-03-12 Thread shaibran
From: Shai Brandes This commit adds an API to query the aenq on whether there is a pending keep alive notification. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_com.c | 39 ++ drivers/net/ena/base/ena_com.h | 10 +

[PATCH v4 16/31] net/ena/base: add unlikely to error checks

2024-03-12 Thread shaibran
From: Shai Brandes The unlikely mechanism is used to reduce pipe flush, caused by a wrong branch prediction. Moreover, it increases readability by wrapping unexpected errors. This commit adds unlikely to error checks that are unlikely to happen. Signed-off-by: Shai Brandes Reviewed-by: Amit Ber

[PATCH v4 19/31] net/ena/base: modify memory barrier comment

2024-03-12 Thread shaibran
From: Shai Brandes The dma_rmb() memory barrier guarantees that the device set the phase bit before continuing to read the rest of the descriptor. Because the phase bit and the rest of the descriptor are in the same cache line this ensures coherency of the data from the descriptor. Signed-off-by

[PATCH v4 17/31] net/ena/base: missing admin interrupt reset reason

2024-03-12 Thread shaibran
From: Shai Brandes There can be cases when we trigger reset if an admin interrupt is missing. In order to identify this use-case specifically, this commit adds a new reset reason. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_com.c| 2 ++

[PATCH v4 15/31] net/ena/base: restructure interrupt handling

2024-03-12 Thread shaibran
From: Shai Brandes When invoking an admin command, in interrupt mode, if the interrupt is received after timeout and also after the calling function finished running, the response will be written into a memory that is no longer valid. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein ---

[PATCH v4 07/31] net/ena/base: limit exponential backoff exp

2024-03-12 Thread shaibran
From: Shai Brandes Limit the value of the exponent used for this backoff at (1<<16) to prevent it from reaching to an excessive value (1<<32) or potentially even overflowing. In addition, for uniformity and readability purposes, the min/max parameter in the calls of ENA_MIN32 and ENA_MAX32 macros

[PATCH v4 12/31] net/ena/base: add completion descriptor corruption check

2024-03-12 Thread shaibran
From: Shai Brandes Adding a check of the MBZ (Must Be Zero) fields in the incoming tx and rx completion descriptors in order to identify corrupted descriptors. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_eth_com.c | 13 +++-- drivers/net/ena/ba

[PATCH v4 10/31] net/ena/base: rename fields in completion descriptors

2024-03-12 Thread shaibran
From: Shai Brandes Several reserved bits in ena_eth_io_tx_cdesc and ena_eth_io_rx_cdesc_base have been renamed explicitly to MBZ (Must Be Zero). These bits are set by the device to zero before being sent to the driver. The fields are used as an integrity check in order to ensure that the received

[PATCH v4 13/31] net/ena/base: malformed Tx descriptor error reason

2024-03-12 Thread shaibran
From: Shai Brandes Adding ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED to identify cases where the returned TX completion descriptors are corrupted. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_defs/ena_regs_defs.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v4 11/31] net/ena/base: use correct read once on u8 field

2024-03-12 Thread shaibran
From: Shai Brandes The flags field in ena_eth_io_tx_cdesc is 8-bits long. The current macro used is READ_ONCE16. Switching to READ_ONCE8 to avoid reading extra data. Given that there's an implicit cast to u8 in the assignment, the correct value is being read, but this change makes it even more ac

[PATCH v4 09/31] net/ena/base: optimize Rx ring submission queue

2024-03-12 Thread shaibran
From: Shai Brandes RX ring submission queue descriptors are always located in host memory This optimization replaces the generic descriptor retrieval method with a tailored method for host memory type descriptors to avoid unnecessary if statement. Signed-off-by: Shai Brandes Reviewed-by: Amit B

[PATCH v4 08/31] net/ena/base: add a new csum offload bit

2024-03-12 Thread shaibran
From: Shai Brandes Add a new driver supported feature bit for TX IPv6 checksum offload. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- .../net/ena/base/ena_defs/ena_admin_defs.h| 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v4 05/31] net/ena: fix fast mbuf free

2024-03-12 Thread shaibran
From: Shai Brandes In case the application enables fast mbuf release optimization, the driver releases 256 TX mbufs in bulk upon reaching the TX free threshold. The existing implementation utilizes rte_mempool_put_bulk for bulk freeing TXs, which exclusively supports direct mbufs. In case the app

[PATCH v4 06/31] net/ena: restructure the llq policy setting process

2024-03-12 Thread shaibran
From: Shai Brandes The driver will set the size of the LLQ header size according to the recommendation from the device. The user can bypass the recommendation via devargs: - The existing devarg 'large_llq_hdr' (default 0) allows user to enforce large llq header policy. - The existing devarg 'en

[PATCH v4 04/31] net/ena: sub-optimal configuration notifications support

2024-03-12 Thread shaibran
From: Shai Brandes ENA device will send asynchronous notifications to the driver in order to notify users about sub-optimal configurations and refer them to public AWS documentation for further action. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/rel_notes/release_24

[PATCH v4 03/31] net/ena: update imissed stat with Rx overruns

2024-03-12 Thread shaibran
From: Shai Brandes Depending on its acceleration support, the device updates a different statistic when an ingress packet is dropped because no buffers are available to hold it. - In AWS instance types from later generations 'rx_overruns' is updated. - Otherwise, in legacy instance types, 'rx_dro

[PATCH v4 02/31] net/ena: report new supported link speed capabilities

2024-03-12 Thread shaibran
From: Shai Brandes Updated the rte_eth_dev_info device supported speed bitmap to include 200Gbps and 400Gbps capabilities. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH v4 01/31] net/ena: rework the metrics multi-process functions

2024-03-12 Thread shaibran
From: Shai Brandes 1. Changed the rte_memcpy call to use the precomputed buf_size. 2. Removed redundant address operators (ampersand symbol) when providing memcpy source address parameter. 3. Code style related change. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net

[PATCH v4 00/31] net/ena: v2.9.0 driver release

2024-03-12 Thread shaibran
From: Shai Brandes Hi all, the ena v2.9.0 release introduces: 1. HAL upgrade: - renamed the 'base' folder to be 'hal' - separated the HAL patches instead of a bulk update. 2. Restructured ena stats and metrics. 3. Restructured the LLQ configuration: - configurable via devarg. - suppor

RE: [PATCH v6 1/5] ci: replace IPsec-mb package install

2024-03-12 Thread Power, Ciara
> -Original Message- > From: Dooley, Brian > Sent: Tuesday, March 12, 2024 1:50 PM > To: Aaron Conole ; Michael Santana > > Cc: dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo > ; pr...@iol.unh.edu; > wathsala.vithan...@arm.com; Power, Ciara > Subject: [PATCH v6 1/5] ci: repla

Re: [PATCH] windows: install sched.h header

2024-03-12 Thread Tyler Retzlaff
On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote: > 20/12/2023 10:11, Bruce Richardson: > > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote: > > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to > > > DESTDIR to be usable. > > Why other files d

[PATCH v2] windows: install sched.h header

2024-03-12 Thread Tyler Retzlaff
rte_os.h includes sched.h so install sched.h to allow DPDK installed to DESTDIR to be usable. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Cc: sta...@dpdk.org Cc: pallavi.ka...@intel.com Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- v2: * reviewed a

[PATCH v3 21/21] test/security: add out of place sgl test case for TLS 1.2

2024-03-12 Thread Aakash Sasidharan
Add TLS 1.2 out-of-place multi-segmented packet test. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 52 ++- app/test/test_cryptodev_security_tls_record.h | 1 + 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/app/test/test_c

[PATCH v3 20/21] test/crypto: unit tests for padding in DTLS-1.2

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the padding for DTLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c ind

[PATCH v3 19/21] test/crypto: unit tests to verify padding in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the padding for TLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 85 ++- app/test/test_cryptodev_security_tls_record.c | 28 -- app/test/test_cryptodev_security_tls_record.h

[PATCH v3 18/21] test/crypto: test to verify zero len record in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with zero length. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptode

[PATCH v3 17/21] test/crypto: test to verify custom content type in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with content type as custom. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index

[PATCH v3 16/21] test/crypto: test to verify hdr corruption in TLS

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with header corruption. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

[PATCH v3 15/21] test/crypto: update framework to verify tls-1.3

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Update the fields in preparation of test descriptor. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 17 +--- app/test/test_cryptodev_security_tls_record.c | 43 --- app/test/test_cryptodev_security_tls_reco

[PATCH v3 07/21] test/cryptodev: allow zero packet length buffers

2024-03-12 Thread Aakash Sasidharan
From: Anoob Joseph The function 'create_segmented_mbuf' is updated to support zero packet length mbufs. This allows testing of zero packet length payload with TLS record processing. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.h | 20 +++- 1 file changed, 7 insertion

[PATCH v3 14/21] test/crypto: add TLS 1.3 vectors

2024-03-12 Thread Aakash Sasidharan
From: Akhil Goyal Added vectors and test suite for TLS 1.3 AES-128-GCM, AES-256-GCM and CHACHA20-POLY1305 vectors. The vectors are generated using gnuTLS client server application. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 35 +++ app/test/test_cryptodev_s

[PATCH v3 13/21] test/crypto: update verification of header

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri In TLS 1.3, the version in the header would be TLS 1.2 and the content type would be APP irrespective of the type of the payload. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev_security_tls_record.c | 20 +-- 1 file changed, 14 insert

[PATCH v3 12/21] test/security: add more DTLS anti-replay window sz

2024-03-12 Thread Aakash Sasidharan
Add anti-replay tests for window sizes 128, 256, 512, 1024, 2048 and 4096 window sizes in DTLS 1.2 suite. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 72 +-- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/app/test/test_cryp

[PATCH v3 11/21] test/security: add DTLS 1.2 anti-replay tests

2024-03-12 Thread Aakash Sasidharan
Add anti-replay test for DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 115 ++- app/test/test_cryptodev_security_tls_record.c | 132 ++ app/test/test_cryptodev_security_tls_record.h | 11 +- 3 files changed, 188 insert

[PATCH v3 10/21] test/security: add TLS/DTLS 1.2 AES-256-SHA384 vectors

2024-03-12 Thread Aakash Sasidharan
From: Akhil Goyal Added vectors for TLS 1.2 and DTLS 1.2 using algos AES-256-CBC and HMAC-SHA384 Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 19 ++ app/test/test_cryptodev_security_tls_record.h | 2 + ...yptodev_security_tls_record_test_vectors.h | 200 +++

[PATCH v3 09/21] test/security: add unit tests for DTLS-1.2

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify 1. DTLS record with zero length 2. DTLS record with header corruption 3. DTLS record with content type as custom Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 77 +++ 1 file changed, 7

[PATCH v3 08/21] test/security: unit test to verify zero TLS records

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit tests to verify the zero len TLS records. Zero len packets are allowed when content type is app data while zero packet length with other content type (such as handshake) would result in an error. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptode

[PATCH v3 06/21] test/security: unit test for custom content verification

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add unit test to verify the TLS header creation with custom content type Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ app/test/test_cryptodev_security_tls_record.c | 3 +++ app/test/test_cryptodev_se

[PATCH v3 05/21] test/security: unit test for TLS packet corruption

2024-03-12 Thread Aakash Sasidharan
From: Vidya Sagar Velumuri Add test to verify the corrupted TLS packet header Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 27 +-- app/test/test_cryptodev_security_tls_record.c | 4 +++ app/test/test_cryptodev_security_tls_record.h |

[PATCH v3 04/21] test/security: add TLS SG data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add multi segment packet data walkthrough test for TLS 1.2 and DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 42 +++ app/test/test_cryptodev_security_tls_record.h | 2 +- 2 files changed, 43 insertions(+), 1 deletion(-) diff --gi

[PATCH v3 03/21] test/security: add DTLS 1.2 data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add data walkthrough test for DTLS 1.2 Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 17 + app/test/test_cryptodev_security_tls_record.c | 5 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/a

[PATCH v3 02/21] test/security: add TLS 1.2 data walkthrough test

2024-03-12 Thread Aakash Sasidharan
Add data walkthrough test for TLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 90 +-- app/test/test_cryptodev.h | 12 ++- app/test/test_cryptodev_security_tls_record.c | 25 -- app/test/test_cryptodev_security_

[PATCH v3 01/21] test/security: enable AES-GCM in combined mode TLS

2024-03-12 Thread Aakash Sasidharan
Enable AES-GCM AEAD tests in combined mode TLS test suite. Coverity issue: 414888 Fixes: 9157ccb8f876 ("test/crypto: verify TLS headers") Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev_security_tls_record.c | 10 -- app/test/test_security_proto.h| 3 +++ 2

[PATCH v3 00/21] Improvements and new test cases

2024-03-12 Thread Aakash Sasidharan
v3: * Set max packet length for data walkthrough tests to 8k. v2: * Rebased. Aakash Sasidharan (7): test/security: enable AES-GCM in combined mode TLS test/security: add TLS 1.2 data walkthrough test test/security: add DTLS 1.2 data walkthrough test test/security: add TLS SG data walkthro

[PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-12 Thread Jack Bond-Preston
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12 in snow3g and zuc documentation. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- .mailmap | 1 + doc/guides/cryptodevs/snow3g.rst | 2 +- doc/guides/cryptodevs/zuc.rst| 2 +- 3 fi

[PATCH v1 2/2] dts: Add missing docstring from XML-RPC server

2024-03-12 Thread jspewock
From: Jeremy Spewock When this XML-RPC server implementation was added, the docstring had to be shortened in order to reduce the chances of this race condition being encountered. Now that this race condition issue is resolved, the full docstring can be restored. Signed-off-by: Jeremy Spewock --

[PATCH v1 1/2] dts: Improve output gathering in interactive shells

2024-03-12 Thread jspewock
From: Jeremy Spewock The current implementation of consuming output from interactive shells relies on being able to find an expected prompt somewhere within the output buffer after sending the command. This is useful in situations where the prompt does not appear in the output itself, but in some

[PATCH v1 0/2] Improve interactive shell output gathering

2024-03-12 Thread jspewock
From: Jeremy Spewock When the interactive shell was originally added, the gathering of output was implented in a way that was trying to be flexible enough to gather output until a given string was found anywhere in the output. It has been found more recently that this greater flexibility provides

RE: [PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-12 Thread Brandes, Shai
> -Original Message- > From: Ferruh Yigit > Sent: Friday, March 8, 2024 7:45 PM > To: Brandes, Shai > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v3 28/33] net/ena/hal: cosmetic changes > > CAUTION: This email originated from outside of the organization. Do not click > links or o

RE: [PATCH v6 1/5] ci: replace IPsec-mb package install

2024-03-12 Thread Power, Ciara
> -Original Message- > From: David Marchand > Sent: Tuesday, March 12, 2024 4:05 PM > To: Dooley, Brian > Cc: Aaron Conole ; Michael Santana > ; dev@dpdk.org; gak...@marvell.com; De Lara > Guarch, Pablo ; pr...@iol.unh.edu; > wathsala.vithan...@arm.com; Power, Ciara > Subject: Re: [PAT

RE: [PATCH v6 1/5] ci: replace IPsec-mb package install

2024-03-12 Thread Power, Ciara
> -Original Message- > From: David Marchand > Sent: Tuesday, March 12, 2024 4:14 PM > To: Power, Ciara > Cc: Dooley, Brian ; Aaron Conole > ; Michael Santana ; > dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo > ; pr...@iol.unh.edu; > wathsala.vithan...@arm.com; Thomas Monjalon

Re: [PATCH 4/4] app/testpmd: enhance getopt_long usage

2024-03-12 Thread Ferruh Yigit
On 3/8/2024 2:48 PM, David Marchand wrote: > This is a cleanup similar to previous ones in EAL and examples. > Instead of using strcmp for every long options while getopt_long already > did such parsing, rely on getopt_long return value. > > Note for reviewers: this patch is best reviewed once app

Re: [PATCH 3/4] app/testpmd: check queue count for related options

2024-03-12 Thread Ferruh Yigit
On 3/8/2024 2:48 PM, David Marchand wrote: > Checking the number of rxq/txq in the middle of option parsing is > confusing. Move the check where nb_rxq / nb_txq are modified. > > Signed-off-by: David Marchand > --- > app/test-pmd/parameters.c | 8 > 1 file changed, 4 insertions(+), 4 de

RE: [PATCH v3 08/33] net/ena/hal: exponential backoff exp limit

2024-03-12 Thread Brandes, Shai
> -Original Message- > From: Brandes, Shai > Sent: Sunday, March 10, 2024 4:54 PM > To: 'Ferruh Yigit' > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v3 08/33] net/ena/hal: exponential backoff > exp limit > > > > > -Original Message- > > From: Ferruh Yigit > > Sent: Frid

[PATCH v5 2/2] eal: initialize shared plugins on Windows

2024-03-12 Thread Tyler Retzlaff
When EAL is built with MSVC it is possible to dynamically load plugins on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC and provide code to load plugins on Windows. Signed-off-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk --- lib/eal/common/eal_common_options.c | 90

[PATCH v5 0/2] eal: initialize shared plugins on Windows

2024-03-12 Thread Tyler Retzlaff
When EAL is built with MSVC it is possible to dynamically load plugins on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC and provide code to load plugins on Windows. Note: For patch 2/2 no verify permissions is provided as it would be redundant with the check performed b

[PATCH v5 1/2] eal/windows: make dirent.h shim compatible with MinGW

2024-03-12 Thread Tyler Retzlaff
Include winapifamily.h for WINAPI_FAMILY macro and provide a definition of WINAPI_FAMILY_PHONE_APP if not present (happens compiling under mingw) Signed-off-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk --- lib/eal/windows/include/dirent.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-12 Thread Ferruh Yigit
On 3/8/2024 2:48 PM, David Marchand wrote: > rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > for the theoretical case when it would fail, raise an error rather than > skip subsequent options. > > Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") > C

Re: [PATCH 1/4] app/testpmd: fix stats-period option check

2024-03-12 Thread Ferruh Yigit
On 3/8/2024 2:48 PM, David Marchand wrote: > Rather than silently ignore an invalid value, raise an error for > stats-period user input. > > Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > Acked-by: Ferruh Yigit

RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-12 Thread Wathsala Wathawana Vithanage
> > > > If the correct version is being installed and picked up, maybe there > > is something missing for that function definition in arm-ipsec-mb repo. > > Wathsala, can you check that please? > > We are working on reproducing this issue. Will update asap. A stub has been added in the Arm ipsec-

  1   2   >