Re: [PATCH 13/13] net/ionic: optimize device start operation

2024-02-02 Thread Stephen Hemminger
On Fri, 2 Feb 2024 11:32:38 -0800 Andrew Boyer wrote: > + memset(ctx, 0, sizeof(*ctx)); > + ctx->pending_work = true; > + ctx->cmd.q_init.opcode = IONIC_CMD_Q_INIT; > + ctx->cmd.q_init.type = q->type; > + ctx->cmd.q_init.ver = lif->qtype_info[q->type].version; > + ctx->cmd

Re: [PATCH 01/13] net/ionic: add stat for completion queue entries processed

2024-02-02 Thread Stephen Hemminger
On Fri, 2 Feb 2024 11:32:26 -0800 Andrew Boyer wrote: > When completion coalescing is turned on in the FW, there will be > fewer CQE than Tx packets. Expose the stat through debug logging. > > Signed-off-by: Andrew Boyer If you care about the stat it should be in xstats.

[PATCH v7 19/19] log: remove PMD log type

2024-02-02 Thread Stephen Hemminger
All uses of PMD logtype in core DPDK have been replaced by dynamic types. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 2 +- lib/log/rte_log.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 4cb07121b915..255f757d94cc 100644

[PATCH v7 18/19] examples/fips_validation: replace use of PMD logtype

2024-02-02 Thread Stephen Hemminger
Replace PMD with USER1 since that is already used in main Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[PATCH v7 17/19] event/skeleton: replace logtype PMD with dynamic type

2024-02-02 Thread Stephen Hemminger
The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 4 ++-- drivers/event/skeleton/skeleton_eventdev.h | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --

[PATCH v7 16/19] event/dlb2: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
Driver was using RTE_LOGTYPE_PMD when it had its own logtype. Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/d

[PATCH v7 14/19] crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
A couple of messages were using RTE_LOGTYPE_PMD when dedicated logtype was already available. Fixes: fe3688ba7950 ("crypto/dpaa_sec: support event crypto adapter") Fixes: bffc7d561c81 ("crypto/dpaa2_sec: support event crypto adapter") Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec

[PATCH v7 15/19] event/dpaa, event/dpaa2: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
Do not use RTE_LOGTYPE_PMD. Fixes: b0f66a68ca74 ("event/dpaa: support crypto adapter") Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c| 2 +- drivers/event/dpaa2/dpaa2_eventdev.c

[PATCH v7 13/19] crypto/ccp: do not use PMD logtype

2024-02-02 Thread Stephen Hemminger
This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c

[PATCH v7 12/19] crypto/caam_jr: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
The driver has macro and logtype but not used in a couple places. Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver") Signed-off-by: Stephen Hemminger --- drivers/crypto/caam_jr/caam_jr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/caam_jr/c

[PATCH v7 11/19] crypto/armv8: do not use PMD logtype

2024-02-02 Thread Stephen Hemminger
Driver already has logging macros, just not used in one place. Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors") Signed-off-by: Stephen Hemminger --- drivers/crypto/armv8/rte_armv8_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cr

[PATCH v7 10/19] crypto/scheduler: replace use of logtype PMD

2024-02-02 Thread Stephen Hemminger
Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s

[PATCH v7 08/19] net/vmxnet3: used dedicated logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver has log macros, just not used in one place. Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c

[PATCH v7 09/19] raw/cnxk: replace PMD logtype with dynamic type

2024-02-02 Thread Stephen Hemminger
Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 16 ++- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_

[PATCH v7 06/19] net/mvpp2: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
Always use the dedicated logtype, not PMD. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2

[PATCH v7 07/19] net/nfb: use dynamic logtype

2024-02-02 Thread Stephen Hemminger
All drivers should be using dynamic logtype. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: Stephen Hemminger --- drivers/net/nfb/nfb.h| 5 + drivers/net/nfb/nfb_ethdev.c | 20 +--- drivers/net/nfb/nfb_rx.c | 10 +- drivers/net/nfb

[PATCH v7 05/19] net/mrvl: do not use PMD logtype

2024-02-02 Thread Stephen Hemminger
Use the same logtype as other places in the driver. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/ne

[PATCH v7 04/19] net/dpaa2: used dedicated logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver has a logtype, but was not being used in one place. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_sparse

[PATCH v7 03/19] net/dpaa: use dedicated logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- 1 file changed,

[PATCH v7 01/19] common/sfc_efx: remove use of PMD logtype

2024-02-02 Thread Stephen Hemminger
This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v7 02/19] mempool/dpaa2: use driver logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw

[PATCH v7 00/19] Replace uses of RTE_LOGTYPE_PMD

2024-02-02 Thread Stephen Hemminger
Many of the uses of PMD logtype have already been fixed. But there are still some leftovers, mostly places where drivers had a logtype but did not use them. Note: this is not an ABI break, but could break out of tree drivers that never updated to use dynamic logtype. DPDK never guarant

[PATCH v7 03/19] net/dpaa: use dedicated logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- 1 file changed,

[PATCH v7 02/19] mempool/dpaa2: use driver logtype not PMD

2024-02-02 Thread Stephen Hemminger
The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw

[PATCH v7 01/19] common/sfc_efx: remove use of PMD logtype

2024-02-02 Thread Stephen Hemminger
This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v7 00/19] Replace use of PMD logtype

2024-02-02 Thread Stephen Hemminger
Many of the uses of PMD logtype have already been fixed. But there are still some leftovers, mostly places where drivers had a logtype but did not use them. Note: this is not an ABI break, but could break out of tree drivers that never updated to use dynamic logtype. DPDK never guarant

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Ashish Sadanandan
On Fri, Feb 2, 2024 at 2:41 AM Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > 02/02/2024 06:13, Ashish Sadanandan: > > > The header was missing the extern "C" directive which causes name > > > mangling of functions by C++ compilers, leading to linke

[PATCH 13/13] net/ionic: optimize device start operation

2024-02-02 Thread Andrew Boyer
Split the queue_start operation into first-half and second-half helpers. This allows us to batch up the queue commands during dev_start(), reducing the outage window when restarting the process by about 1ms per queue. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 178

[PATCH 12/13] net/ionic: optimize device stop operation

2024-02-02 Thread Andrew Boyer
Split the queue_stop operation into first-half and second-half helpers. Move the command context from the stack into each Rx/Tx queue struct. Expose some needed adminq interfaces. This allows us to batch up the queue commands during dev_stop(), reducing the outage window when restarting the proces

[PATCH 11/13] net/ionic: optimize device close operation

2024-02-02 Thread Andrew Boyer
Use a single device reset command to speed up dev_close(). The LIF stop and port reset commands are not needed. This reduces the outage window when restarting the process by about 2ms plus another 1ms per queue. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 --- drivers/ne

[PATCH 10/13] net/ionic: fix device close sequence to avoid crash

2024-02-02 Thread Andrew Boyer
The close routine should release all resources, but not call rte_eth_dev_destroy(). As written this code will call rte_eth_dev_release_port() twice and segfault. Instead, move rte_eth_dev_destroy() to the remove routine. eth_ionic_dev_uninit() will call close if necessary. Fixes: 175e4e7ed760 ("n

[PATCH 06/13] net/ionic: memcpy descriptors when using Q-in-CMB

2024-02-02 Thread Andrew Boyer
From: Neel Patel They can be batched together this way, reducing the number of PCIe transactions. This improves transmit PPS by up to 50% in some configurations. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_dev.c | 9 +++-- drivers/net/ionic/ionic

[PATCH 09/13] net/ionic: add flexible firmware xstat counters

2024-02-02 Thread Andrew Boyer
From: Brad Larson Assign 32 counters for flexible firmware events. These can be used as per-port or per-queue counters in certain firmware configurations. They are displayed as fw_flex_eventX in xstats. Signed-off-by: Andrew Boyer Signed-off-by: Brad Larson --- drivers/net/ionic/ionic_ethdev.

[PATCH 07/13] net/ionic: fix RSS query routine

2024-02-02 Thread Andrew Boyer
From: Akshay Dorwat The routine that copies out the RSS config can't use memcpy() because 'reta_conf->reta' is an array of uint16_t while 'lif->rss_ind_tbl' is an array of uint8_t. Instead, copy the values individually. Fixes: 22e7171bc63b ("net/ionic: support RSS") Cc: cardigli...@ntop.org Cc:

[PATCH 08/13] net/ionic: report 1G and 200G link speeds when applicable

2024-02-02 Thread Andrew Boyer
From: Vamsi Krishna Atluri The hardware supports these speeds, so we should report them correctly. Signed-off-by: Andrew Boyer Signed-off-by: Vamsi Krishna Atluri --- drivers/net/ionic/ionic_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ionic/ionic_ethdev.c b/

[PATCH 04/13] net/ionic: fix missing volatile type for cqe pointers

2024-02-02 Thread Andrew Boyer
From: Neel Patel This memory may be changed by the hardware, so the volatile keyword is required for correctness. Fixes: e86a6fcc7cf3 ("net/ionic: add optimized non-scattered Rx/Tx") cc: sta...@dpdk.org Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_rxtx.c

[PATCH 05/13] net/ionic: replace non-standard type in structure definition

2024-02-02 Thread Andrew Boyer
Use uint8_t instead of u_char. This simplifies the code. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_dev_pci.c b/drivers/net/ionic/ionic_dev_pci.c index 5e74a6da71..cbaac2c5bc 10064

[PATCH 03/13] net/ionic: don't auto-enable Rx scatter-gather a second time

2024-02-02 Thread Andrew Boyer
The receive side will enable scatter-gather if required based on the mbuf size. If the client already enabled it in the config, it does not need to be enabled again. This reduces log output. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 02/13] net/ionic: increase max supported MTU to 9750 bytes

2024-02-02 Thread Andrew Boyer
Some configurations want to use values this high internally. Allow them to do so without modifying the code. Signed-off-by: Andrew Boyer Signed-off-by: Bhuvan Mital --- drivers/net/ionic/ionic_dev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_dev.

[PATCH 01/13] net/ionic: add stat for completion queue entries processed

2024-02-02 Thread Andrew Boyer
When completion coalescing is turned on in the FW, there will be fewer CQE than Tx packets. Expose the stat through debug logging. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 1 + drivers/net/ionic/ionic_rxtx.c| 3 +++ drivers/net/ionic/ionic_rxtx_sg.c | 2

[PATCH 00/13] net/ionic: miscellaneous fixes and improvements

2024-02-02 Thread Andrew Boyer
This patchset provides miscellaneous fixes and improvements for the net/ionic driver used by AMD Pensando devices. Akshay Dorwat (1): net/ionic: fix RSS query routine Andrew Boyer (8): net/ionic: add stat for completion queue entries processed net/ionic: increase max supported MTU to 9750 b

[PATCH] drivers: Convert uses of RTE_LOG_DP to use RTE_LOG_DP_LINE

2024-02-02 Thread Stephen Hemminger
Make use of RTE_LOG_DP_LINE has newline just like uses of macro with rte_log() which is common in drivers. Signed-off-by: Stephen Hemminger --- .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- drivers/common/cpt/cpt_pmd_logs.h | 2 +- drivers/common/cpt/cpt_ucode.h

RE: [PATCH v3 2/2] doc: remove outdated version details

2024-02-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Sivaramakrishnan, VenkatX > Sent: Friday, February 2, 2024 3:04 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Richardson, Bruce ; Power, > Ciara ; Sivaramakrishnan, VenkatX > > Subject: [PATCH v3 2/2] doc: remove outdated version details >

RE: [PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-02-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Sivaramakrishnan, VenkatX > Sent: Friday, February 2, 2024 3:04 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Richardson, Bruce ; Power, > Ciara ; Sivaramakrishnan, VenkatX > > Subject: [PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec Mu

[PATCH v6 2/2] net/octeon_ep: add Rx NEON routine

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx ARM NEON SIMD routine. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_24_03.rst | 1 + drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 147 drivers/net/octeon_ep/meson.build | 6 +- drivers/net/octeon_ep/otx_ep_ethdev.

[PATCH v6 1/2] net/octeon_ep: improve Rx performance

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Use mempool API instead of pktmbuf alloc to avoid mbuf reset as it will be done by rearm on receive. Reorder refill to avoid unnecessary write commits on mbuf data. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation with distro gcc. v3 Changes: - Fix aarc

[PATCH 2/2] net/mlx5: improve pattern template validation

2024-02-02 Thread Gregory Etelson
Current PMD implementation validates pattern templates that will always be rejected during table template creation. The patch adds basic HWS verifications to pattern validation to ensure that the pattern can be used in table template. PMD updates `rte_errno` if pattern template validation failed:

[PATCH 0/2] net/mlx5: update pattern validations

2024-02-02 Thread Gregory Etelson
Gregory Etelson (2): net/mlx5/hws: definer, update pattern validations net/mlx5: improve pattern template validation drivers/net/mlx5/hws/mlx5dr_definer.c | 4 +- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 121 -- 3 files c

[PATCH 1/2] net/mlx5/hws: definer, update pattern validations

2024-02-02 Thread Gregory Etelson
The patch updates HWS code for upcoming extended PMD pattern template verification: Support VOID flow item type. Return E2BUG error code when pattern is too large for definer. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/hws/mlx5dr_definer.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

[PATCH v5 2/2] net/octeon_ep: add Rx NEON routine

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx ARM NEON SIMD routine. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_24_03.rst | 1 + drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 148 drivers/net/octeon_ep/meson.build | 6 +- drivers/net/octeon_ep/otx_ep_ethdev.

[PATCH v5 1/2] net/octeon_ep: improve Rx performance

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Use mempool API instead of pktmbuf alloc to avoid mbuf reset as it will be done by rearm on receive. Reorder refill to avoid unnecessary write commits on mbuf data. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation with distro gcc. v3 Changes: - Fix aarc

Re: [PATCH] bus/vdev: fix devargs memory leak

2024-02-02 Thread Burakov, Anatoly
On 9/1/2023 9:24 AM, Mingjin Ye wrote: When a device is created by a secondary process, an empty devargs is temporarily generated and bound to it. This causes the device to not be associated with the correct devargs, and the empty devargs are not released when the resource is freed. This patch f

Re: [PATCH] event/cnxk: remove unused files

2024-02-02 Thread Jerin Jacob
On Fri, Feb 2, 2024 at 4:09 PM wrote: > > From: Pavan Nikhilesh > > Remove unused template files. > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/for-main. Thanks

[PATCH v3 2/2] doc: remove outdated version details

2024-02-02 Thread Sivaramakrishnan Venkat
SW PMDs documentation is updated to remove details of unsupported IPsec Multi-buffer versions.DPDK older than 20.11 is end of life. So, older DPDK versions are removed from the Crypto library version table. Signed-off-by: Sivaramakrishnan Venkat --- v3: - added second patch for outdated docu

[PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-02-02 Thread Sivaramakrishnan Venkat
SW PMDs increment IPsec Multi-buffer version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required. Signed-off-by: Sivaramakrishnan Venkat Acked-by: Ciara Power --- v2: - Removed unused macro in ipsec_mb_ops.c - set_gcm_job() modified correctly to keep multi_

RE: [RFC v3] eal: add bitset type

2024-02-02 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Friday, 2 February 2024 11.19 > > On 2024-02-01 09:04, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Wednesday, 31 January 2024 19.46 > >> > >> On 2024-01-31 17:06, Stephen Hemminger wrote

[PATCH v3 11/11] eventdev: drop comment for anon union from doxygen

2024-02-02 Thread Bruce Richardson
Make the comments on the unnamed unions in the rte_event structure regular comments rather than doxygen ones. The comments do not add anything meaningful to the doxygen output. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-02 Thread Bruce Richardson
Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clarify the field's use, and whether it is preserved between enqueue and dequeue, and it's role, if any, in scheduling. Signed-off-by: Bruce Richardson --- V3: up

[PATCH v3 09/11] eventdev: improve comments on scheduling types

2024-02-02 Thread Bruce Richardson
The description of ordered and atomic scheduling given in the eventdev doxygen documentation was not always clear. Try and simplify this so that it is clearer for the end-user of the application Signed-off-by: Bruce Richardson --- V3: extensive rework following feedback. Please re-review! --- l

[PATCH v3 08/11] eventdev: improve doxygen comments for control APIs

2024-02-02 Thread Bruce Richardson
The doxygen comments for the port attributes, start and stop (and related functions) are improved. Signed-off-by: Bruce Richardson --- V3: add missing "." on end of sentences/lines. --- lib/eventdev/rte_eventdev.h | 47 +++-- 1 file changed, 29 insertions(+), 18

[PATCH v3 07/11] eventdev: improve doxygen comments on config fns

2024-02-02 Thread Bruce Richardson
Improve the documentation text for the configuration functions and structures for configuring an eventdev, as well as ports and queues. Clarify text where possible, and ensure references come through as links in the html output. Signed-off-by: Bruce Richardson --- V3: Update following review, ma

[PATCH v3 06/11] eventdev: improve doxygen comments on configure struct

2024-02-02 Thread Bruce Richardson
General rewording and cleanup on the rte_event_dev_config structure. Improved the wording of some sentences and created linked cross-references out of the existing references to the dev_info structure. As part of the rework, fix issue with how single-link port-queue pairs were counted in the rte_e

[PATCH v3 05/11] eventdev: improve function documentation for query fns

2024-02-02 Thread Bruce Richardson
General improvements to the doxygen docs for eventdev functions for querying basic information: * number of devices * id for a particular device * socket id of device * capability information for a device Signed-off-by: Bruce Richardson --- V3: minor changes following review --- lib/eventdev/rt

[PATCH v3 04/11] eventdev: cleanup doxygen comments on info structure

2024-02-02 Thread Bruce Richardson
Some small rewording changes to the doxygen comments on struct rte_event_dev_info. Signed-off-by: Bruce Richardson --- V3: reworked following feedback - added closing "." on comments - added more cross-reference links - reworded priority level comments --- lib/eventdev/rte_eventdev.h | 85 +

[PATCH v3 03/11] eventdev: update documentation on device capability flags

2024-02-02 Thread Bruce Richardson
Update the device capability docs, to: * include more cross-references * split longer text into paragraphs, in most cases with each flag having a single-line summary at the start of the doc block * general comment rewording and clarification as appropriate Signed-off-by: Bruce Richardson --- V

[PATCH v3 02/11] eventdev: move text on driver internals to proper section

2024-02-02 Thread Bruce Richardson
Inside the doxygen introduction text, some internal details of how eventdev works was mixed in with application-relevant details. Move these details on probing etc. to the driver-relevant section. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 32 --

[PATCH v3 01/11] eventdev: improve doxygen introduction text

2024-02-02 Thread Bruce Richardson
Make some textual improvements to the introduction to eventdev and event devices in the eventdev header file. This text appears in the doxygen output for the header file, and introduces the key concepts, for example: events, event devices, queues, ports and scheduling. This patch makes the followi

[PATCH v3 00/11] improve eventdev API specification/documentation

2024-02-02 Thread Bruce Richardson
This patchset makes rewording improvements to the eventdev doxygen documentation to try and ensure that it is as clear as possible, describes the implementation as accurately as possible, and is consistent within itself. Most changes are just minor rewordings, along with plenty of changes to chang

Re: [dpdk-dev] [PATCH] net/cnxk: fix aged flows query

2024-02-02 Thread Jerin Jacob
On Fri, Feb 2, 2024 at 10:51 AM wrote: > > From: Satheesh Paul > > After all aged flows are destroyed, the aged_flows bitmap > is free-ed. Querying aged flows tries to access this bitmap > resulting in a segmentation fault. Fixing this by not accessing > the bitmap if no aged flows are present. >

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 11:33:19AM +, Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:38:10AM +0100, Mattias Rönnblom wrote: > > On 2024-02-01 17:59, Bruce Richardson wrote: > > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > > On 2024-01-19 18:43, Bruce Richardso

[PATCH 5/5] net/mlx5: add support for flow table resizing

2024-02-02 Thread Gregory Etelson
Support template table API in PMD. The patch allows to increase existing table capacity. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.h | 5 + drivers/net/mlx5/mlx5_flow.c| 51 drivers/net/mlx5/mlx5_flow.h| 84 -- drivers/net/mlx5/mlx5_flow_hw.c | 512 +++

[PATCH 4/5] net/mlx5: move multi-pattern actions management to table level

2024-02-02 Thread Gregory Etelson
The multi-pattern actions related structures and management code have been moved to the table level. That code refactor is required for the upcoming table resize feature. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.h| 73 +- drivers/net/mlx5/mlx5_flow_hw.c | 229 ++

[PATCH 0/5] net/mlx5: add support for flow table resizing

2024-02-02 Thread Gregory Etelson
Gregory Etelson (3): net/mlx5: fix parameters verification in HWS table create net/mlx5: move multi-pattern actions management to table level net/mlx5: add support for flow table resizing Maayan Kashani (1): net/mlx5: add resize function to ipool Yevgeny Kliteynik (1): net/mlx5/hws: add

[PATCH 2/5] net/mlx5: add resize function to ipool

2024-02-02 Thread Gregory Etelson
From: Maayan Kashani Before this patch, ipool size could be fixed by setting max_idx in mlx5_indexed_pool_config upon ipool creation. Or it can be auto resized to the maximum limit by setting max_idx to zero upon ipool creation and the saved value is the maximum index possible. This patch adds ip

[PATCH 3/5] net/mlx5: fix parameters verification in HWS table create

2024-02-02 Thread Gregory Etelson
Modified the conditionals in `flow_hw_table_create()` to use bitwise AND instead of equality checks when assessing `table_cfg->attr->specialize` bitmask. This will allow for greater flexibility as the bitmask may encapsulate multiple flags. The patch maintains the previous behavior with single flag

[PATCH 1/5] net/mlx5/hws: add support for resizable matchers

2024-02-02 Thread Gregory Etelson
From: Yevgeny Kliteynik Add support for matcher resize with the following new API calls: - mlx5dr_matcher_resize_set_target - mlx5dr_matcher_resize_rule_move The first function links two matchers and allows moving rules from src matcher to dst matcher. Both matchers should have the same charac

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 10:38:10AM +0100, Mattias Rönnblom wrote: > On 2024-02-01 17:59, Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event

[PATCH v4 2/2] net/octeon_ep: add Rx NEON routine

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx ARM NEON SIMD routine. Signed-off-by: Pavan Nikhilesh --- drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 147 drivers/net/octeon_ep/meson.build | 6 +- drivers/net/octeon_ep/otx_ep_ethdev.c | 5 +- drivers/net/octeon_ep/otx_ep_rxtx.h

[PATCH v4 1/2] net/octeon_ep: improve Rx performance

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Use mempool API instead of pktmbuf alloc to avoid mbuf reset as it will be done by rearm on receive. Reorder refill to avoid unnecessary write commits on mbuf data. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation with distro gcc. v3 Changes: - Fix aarc

Re: [PATCH v2 03/11] eventdev: update documentation on device capability flags

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 09:58:25AM +0100, Mattias Rönnblom wrote: > On 2024-01-31 15:09, Bruce Richardson wrote: > > On Tue, Jan 23, 2024 at 10:18:53AM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Update the device capability docs, to: > > > > > > > > *

[PATCH] cnxk: fix representor stats

2024-02-02 Thread Amit Prakash Shukla
Representor stats were not matching the PF/VF stats as seen linux kernel. This patch fixes the same. Depends-on: series-30966 ("support for port representors") Signed-off-by: Amit Prakash Shukla --- drivers/common/cnxk/roc_mbox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/commo

Re: [PATCH v3 2/2] net/octeon_ep: add Rx NEON routine

2024-02-02 Thread Jerin Jacob
On Fri, Feb 2, 2024 at 2:54 PM wrote: > > From: Pavan Nikhilesh > > Add Rx ARM NEON SIMD routine. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 148 > drivers/net/octeon_ep/meson.build | 6 +- > drivers/net/octeon_ep/otx_ep

Re: [PATCH] net/iavf: fix access to null value

2024-02-02 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 02:05:55AM +, Mingjin Ye wrote: > The "vsi" may be null, so it needs to be used after checking. > > Fixes: ab28aad9c24f ("net/iavf: fix Rx Tx burst in multi-process") > Cc: sta...@dpdk.org > > Signed-off-by: Mingjin Ye > --- > drivers/net/iavf/iavf_rxtx.c | 10 ++

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 10:45:34AM +0100, Mattias Rönnblom wrote: > On 2024-02-01 18:02, Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 10:24:54AM +0100, Mattias Rönnblom wrote: > On 2024-01-31 15:37, Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:51:03PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-23 10:43, Bruce Richardson wrote: > > > > On Tue, Jan 23, 2024 at 10:35:02AM +0100, Mattias Rönnblo

Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-02-02 Thread Thomas Monjalon
29/01/2024 08:55, David Marchand: > On Mon, Jan 29, 2024 at 6:35 AM Rahul Gupta > wrote: > > > Looking at what this patch does.. I am under the impression all you > > > really need is rte_eal_init without initial probing. > > > Such behavior can probably be achieved with a allowlist set to a non >

Re: [RFC v3] eal: add bitset type

2024-02-02 Thread Mattias Rönnblom
On 2024-02-01 09:04, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 31 January 2024 19.46 On 2024-01-31 17:06, Stephen Hemminger wrote: On Wed, 31 Jan 2024 14:13:01 +0100 Mattias Rönnblom wrote: [...] FYI - the linux kernel has a similar but mor

Re: [PATCH v2] app/testpmd: support updating flow rule actions

2024-02-02 Thread Thomas Monjalon
01/02/2024 10:59, Oleksandr Kolomeiets: > "flow actions_update" updates a flow rule specified by a rule ID with a > new action list by making a call to "rte_flow_actions_update()": > > flow actions_update {port_id} {rule_id} > actions {action} [/ {action} [...]] / end [user_id] > > Cr

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Mattias Rönnblom
On 2024-02-01 18:02, Bruce Richardson wrote: On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: On 2024-01-19 18:43, Bruce Richardson wrote: Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clar

[PATCH] event/cnxk: remove unused files

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Remove unused template files. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/deq/cn10k/deq_0_15_dual.c| 16 drivers/event/cnxk/deq/cn10k/deq_112_127_dual.c | 16 drivers/event/cnxk/deq/cn10k/deq_16_31_dual.c | 16

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > 02/02/2024 06:13, Ashish Sadanandan: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined references to these functio

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Mattias Rönnblom
On 2024-02-01 17:59, Bruce Richardson wrote: On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: On 2024-01-19 18:43, Bruce Richardson wrote: Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clar

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 02:52:05PM +0530, Jerin Jacob wrote: > On Thu, Feb 1, 2024 at 10:33 PM Bruce Richardson > wrote: > > > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-02-02 Thread Mattias Rönnblom
On 2024-01-31 15:37, Bruce Richardson wrote: On Wed, Jan 24, 2024 at 12:51:03PM +0100, Mattias Rönnblom wrote: On 2024-01-23 10:43, Bruce Richardson wrote: On Tue, Jan 23, 2024 at 10:35:02AM +0100, Mattias Rönnblom wrote: On 2024-01-19 18:43, Bruce Richardson wrote: Some small rewording chang

[DPDK Bug 1377] per queue counters are not working on Intel XL710 based SRIOV VFs using iavf pmd

2024-02-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1377 Bug ID: 1377 Summary: per queue counters are not working on Intel XL710 based SRIOV VFs using iavf pmd Product: DPDK Version: 22.11 Hardware: x86 OS: Linux

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Jerin Jacob
On Thu, Feb 1, 2024 at 10:33 PM Bruce Richardson wrote: > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_event" struct, enhance

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Thomas Monjalon
02/02/2024 06:13, Ashish Sadanandan: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Fixes: 86c743cf9140 ("eal: define generic vector types") > Cc: n

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-02 Thread Bruce Richardson
On Thu, Feb 01, 2024 at 05:02:44PM +, Bruce Richardson wrote: > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_event" struct, e

[PATCH v3 2/3] config/arm: add support for fallback march

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v3 1/2] net/octeon_ep: improve Rx performance

2024-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Use mempool API instead of pktmbuf alloc to avoid mbuf reset as it will be done by rearm on receive. Reorder refill to avoid unnecessary write commits on mbuf data. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation with distro gcc. v3 Changes: - Fix aarc

  1   2   >