RE: [PATCH 0/9] use C11 alignof

2024-01-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 25 January 2024 00.18 > > Replace use of __alignof__(T) and __alignof__(e) with C11 alignof(T) > and alignof(typeof(e)) respectively to improve portability of the code > between toolchains. > > Tyler Retzlaff (9): >

RE: [PATCH 1/2] hash: replace zero length array with flex array

2024-01-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 24 January 2024 23.18 flex array > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

RE: [PATCH 2/2] rcu: replace zero length array with flex array

2024-01-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 24 January 2024 23.18 lex array > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

Re: [PATCH v2 8/8] net/sfc: fix calloc parameters

2024-01-24 Thread Andrew Rybchenko
On 1/24/24 22:02, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Wednesday, 24 January 2024 19.54 gcc [1] generates warning [2] about rte_calloc usage, because rte_calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124

Re: [24.03 RFC] argparse: add argparse library

2024-01-24 Thread fengchengwen
Hi Stephen, On 2024/1/24 23:54, Stephen Hemminger wrote: > On Tue, 21 Nov 2023 12:26:51 + > Chengwen Feng wrote: > >> Introduce argparse library (which was inspired by the thread [1]), >> compared with getopt, the argparse has following advantages: >> 1) Set the help information when definin

RE: [EXT] [PATCH 9/9] security: use C11 alignof

2024-01-24 Thread Akhil Goyal
> Replace use of __alignof__(T) with C11 alignof(T) to improve portability > between toolchains. > > Signed-off-by: Tyler Retzlaff Acked-by: Akhil Goyal

Re: [V1 2/5] app/testpmd: support VXLAN-GPE flags

2024-01-24 Thread Singh, Aman Deep
On 1/12/2024 1:32 PM, Gavin Li wrote: Add support for VXLAN-GPE flags field in flow rule pattern to testpmd. Signed-off-by: Gavin Li Acked-by: Dariusz Sosnowski Acked-by: Aman Singh

Re: [V1 4/5] app/testpmd: support VXLAN-GPE reserved fields

2024-01-24 Thread Singh, Aman Deep
On 1/12/2024 1:32 PM, Gavin Li wrote: Add support for VXLAN-GPE rsvd0 and rsvd1 fields in flow rule pattern to testpmd Signed-off-by: Gavin Li Acked-by: Dariusz Sosnowski Acked-by: Aman Singh (aman.deep.si...@intel.com> ---

RE: Regarding https://mails.dpdk.org/archives/dev/2023-June/270558.html dpdk patch

2024-01-24 Thread Deng, KaiwenX
Hi Amiya Can you provide me with the DPDK startup parameters? Thanks From: Amiya Ranjan Mohakud Sent: Tuesday, January 23, 2024 4:54 PM To: Deng, KaiwenX ; dev@dpdk.org Cc: Amiya Ranjan Mohakud ; Amiya Ranjan Mohakud Subject: Regarding https://mails.dpdk.org/archives/dev/2023-June/270558.html

RE: [PATCH v4 1/1] ethdev: parsing multiple representor devargs string

2024-01-24 Thread Harman Kalra
Ping... Request for review comments please. Thanks Harman > -Original Message- > From: Harman Kalra > Sent: Monday, January 22, 2024 12:49 AM > To: dev@dpdk.org; Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; > Hyong Youb Kim ; Yu

RE: [EXT] [PATCH 7/9] pdcp: use C11 alignof

2024-01-24 Thread Anoob Joseph
> > External Email > > -- > Replace use of __alignof__(T) with C11 alignof(T) to improve portability > between toolchains. > > Signed-off-by: Tyler Retzlaff Acked-by: Anoob Joseph

Re: [PATCH 02/12] argparse: add argparse library

2024-01-24 Thread fengchengwen
Hi Thomas, On 2024/1/24 21:24, Thomas Monjalon wrote: > 22/01/2024 04:57, Chengwen Feng: >> Introduce argparse library (which was inspired by the thread [1]). This >> commit provides public API and doc. >> >> [1] >> https://patchwork.dpdk.org/project/dpdk/patch/20231105054539.22303-2-fengcheng...

RE: [PATCH v2 3/8] rawdev: fix calloc parameters

2024-01-24 Thread Hemant Agrawal
> gcc [1] generates warning [2] about calloc usage, because calloc parameter > order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20240108 (experimental) > > [2] > Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o > ../lib/rawdev/rte_rawdev.c: In func

[PATCH v1] doc: update guideline for fix commit messages

2024-01-24 Thread Sivaramakrishnan Venkat
Maintainers remove the Cc author line when merging the patch. So, the guidelines is updated with a suggestion for the placement of Cc lines in a commit message for easy merging. Signed-off-by: Sivaramakrishnan Venkat --- doc/guides/contributing/patches.rst | 6 ++ 1 file changed, 6 insertion

[PATCH] vdpa/mlx5: fix queue enable drain CQ

2024-01-24 Thread Yajun Wu
For the case: `ethtool -L eth0 combined xxx` in VM, VQ will disable and enable without calling device close. In such case, need add drain CQ before reuse/reset event QP. Fixes: 24969c7b62 ("vdpa/mlx5: reuse event queues") Cc: sta...@dpdk.org Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- dr

Re: [PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread fengchengwen
For dmadev part Reviewed-by: Chengwen Feng Thanks On 2024/1/24 20:04, David Marchand wrote: > RTE_LOG() macros prefixe the log messages based on the logtype. > This results in logs like: > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' > TMTY: TELEMETRY: Socket creation and b

[PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-01-24 Thread longli
From: Long Li Instead of allocating mbufs one by one during RX, use rte_pktmbuf_alloc_bulk() to allocate them in a batch. Signed-off-by: Long Li --- drivers/net/mana/rx.c | 67 +++ 1 file changed, 43 insertions(+), 24 deletions(-) diff --git a/drivers/n

Re: [PATCH v2 5/8] dmadev: fix calloc parameters

2024-01-24 Thread fengchengwen
Reviewed-by: Chengwen Feng Thanks On 2024/1/25 2:54, Ferruh Yigit wrote: > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 20240124 (experimental) > > [2] >

Re: [PATCH v2 4/8] eventdev: fix calloc parameters

2024-01-24 Thread fengchengwen
Reviewed-by: Chengwen Feng Thanks On 2024/1/25 2:54, Ferruh Yigit wrote: > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 20240124 (experimental) > > [2] >

Re: [PATCH v2 3/8] rawdev: fix calloc parameters

2024-01-24 Thread fengchengwen
Reviewed-by: Chengwen Feng Thanks On 2024/1/25 2:54, Ferruh Yigit wrote: > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20240108 (experimental) > > [2] > Compiling C object .../lib/lib

RE: [EXT] [PATCH 8/9] reorder: use C11 alignof

2024-01-24 Thread Volodymyr Fialko
> -Original Message- > From: Tyler Retzlaff > Sent: Thursday, January 25, 2024 12:18 AM > To: dev@dpdk.org > Cc: Akhil Goyal ; Andrew Rybchenko > ; > Anoob Joseph ; Ferruh Yigit ; > Honnappa Nagarahalli > ; Jerin Jacob ; Konstantin > Ananyev > ; Nithin Kumar Dabilpuram > ; Ori Kam > ;

[PATCH 9/9] security: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/security/rte_security.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index b082

[PATCH 8/9] reorder: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/reorder/rte_reorder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index ff81544..c080

[PATCH 7/9] pdcp: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/pdcp/rte_pdcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c index 1c6d246..1c076fb 100644 --- a/

[PATCH 5/9] stack: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 1dab6d6..7261281

[PATCH 6/9] node: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/node/node_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/node/node_private.h b/lib/node/node_private.h index 845fdaa..92acb9b 1

[PATCH 3/9] ethdev: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.c | 3 ++- lib/ethdev/rte_flow.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/ethdev_driver.c b/lib/e

[PATCH 4/9] eventdev: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/eventdev/rte_eventdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 94628a6

[PATCH 2/9] mbuf: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf_dyn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/mbuf/rte_mbuf_dyn.c b/lib/mbuf/rte_mbuf_dyn.c index 446018f..1cfb329 10

[PATCH 1/9] ring: use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve portability between toolchains Signed-off-by: Tyler Retzlaff --- lib/ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index c59f626..a783299 100644

[PATCH 0/9] use C11 alignof

2024-01-24 Thread Tyler Retzlaff
Replace use of __alignof__(T) and __alignof__(e) with C11 alignof(T) and alignof(typeof(e)) respectively to improve portability of the code between toolchains. Tyler Retzlaff (9): ring: use C11 alignof mbuf: use C11 alignof ethdev: use C11 alignof eventdev: use C11 alignof stack: use C11

RE: [PATCH 1/2] hash: replace zero length array with flex array

2024-01-24 Thread Honnappa Nagarahalli
> -Original Message- > From: Tyler Retzlaff > Sent: Wednesday, January 24, 2024 4:18 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; Sameh Gobriel > ; Vladimir Medvedkin > ; Yipeng Wang ; > Stephen Hemminger ; Tyler Retzlaff > > Subject: [PATCH 1/2] hash: replac

RE: [PATCH 2/2] rcu: replace zero length array with flex array

2024-01-24 Thread Honnappa Nagarahalli
> -Original Message- > From: Tyler Retzlaff > Sent: Wednesday, January 24, 2024 4:18 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; Sameh Gobriel > ; Vladimir Medvedkin > ; Yipeng Wang ; > Stephen Hemminger ; Tyler Retzlaff > > Subject: [PATCH 2/2] rcu: replace

[PATCH 1/2] hash: replace zero length array with flex array

2024-01-24 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index e8de071..1982051 100644 --- a/lib/hash/rte_thas

[PATCH 2/2] rcu: replace zero length array with flex array

2024-01-24 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/rcu/rcu_qsbr_pvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rcu_qsbr_pvt.h b/lib/rcu/rcu_qsbr_pvt.h index 5fd7ca2..96d05e6 100644 --- a/lib/rcu/rcu_qsb

[PATCH 0/2] more replacement of zero length array

2024-01-24 Thread Tyler Retzlaff
Replace some missed zero length arrays not captured in the original series. https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=* Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html Tyler Retzlaff (2):

RE: [PATCH v2 8/8] net/sfc: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about rte_calloc usage, because > rte_calloc parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 2024012

RE: [PATCH v2 7/8] net/bnx2x: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about rte_calloc usage, because > rte_calloc parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 2024012

RE: [PATCH v2 6/8] common/mlx5: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 20240124 (experiment

RE: [PATCH v2 2/8] net/nfp: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20231102 (experimental) > > [2] > Compiling C

RE: [PATCH v2 1/8] pipeline: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20231102 (experimental) > > [2] > Compiling

RE: [PATCH v2 5/8] dmadev: fix calloc parameters

2024-01-24 Thread Morten Brørup
ning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 20240124 (experimental) > > [2] > Compiling C object lib/librte_dmadev.a.p/dmadev_rte_dmadev.c.o > ../lib/dmadev/rte_dmadev.c: In funct

RE: [PATCH v2 3/8] rawdev: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20240108 (experimental) > > [2] > Compiling C

RE: [PATCH v2 4/8] eventdev: fix calloc parameters

2024-01-24 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 24 January 2024 19.54 > > gcc [1] generates warning [2] about calloc usage, because calloc > parameter order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.1 20240124 (experiment

[PATCH v2 8/8] net/sfc: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about rte_calloc usage, because rte_calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae.c.o ../net/sfc/sfc_mae.c: In function

[PATCH v2 7/8] net/bnx2x: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about rte_calloc usage, because rte_calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_bnx2x.c.o ../drivers/net/bnx2x/bnx2x.c: In function

[PATCH v2 6/8] common/mlx5: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object .../common_mlx5_mlx5_common_mr.c.o .../mlx5/mlx5_common_mr.c: In function ‘mlx5_mempool_get_chunks

[PATCH v2 3/8] rawdev: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20240108 (experimental) [2] Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o ../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dum

[PATCH v2 5/8] dmadev: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_dmadev.a.p/dmadev_rte_dmadev.c.o ../lib/dmadev/rte_dmadev.c: In function

[PATCH v2 4/8] eventdev: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_eventdev.c.o ../lib/eventdev/rte_eventdev.c: In function

[PATCH v2 2/8] net/nfp: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o .../net/nfp/nfpcore/nfp_mutex.c: In function ‘nfp_cpp_mutex_alloc’: .

[PATCH v2 1/8] pipeline: fix calloc parameters

2024-01-24 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../pipeline_rte_swx_pipeline_spec.c.o .../rte_swx_pipeline_spec.c: In function ‘pipeline_spec_parse’:

Re: [PATCH 2/2] drivers: RTE_LOG_DP newline consistency

2024-01-24 Thread Tyler Retzlaff
On Wed, Jan 24, 2024 at 08:28:35AM -0800, Stephen Hemminger wrote: > Make sure use of RTE_LOG_DP has newline just like uses of RTE_LOG. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [RFC] doc/linux_gsg: add amd configuration section

2024-01-24 Thread Varghese, Vipin
On 1/16/2024 8:44 PM, Thomas Monjalon wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. There was no comment on this doc. It is RFC, is it ready to merge? new patch shared doc/linux_gsg: add amd confi

[PATCH] doc/linux_gsg: add amd configuration section

2024-01-24 Thread Vipin Varghese
Add AMD EPYC SoC tuning guide as new section of linux getting started guide. Signed-off-by: Vipin Varghese --- MAINTAINERS | 4 ++ doc/guides/linux_gsg/amd_platform.rst | 70 +++ doc/guides/linux_gsg/index.rst| 1 + 3 files changed, 75

Re: [PATCH 1/2] drivers: remove unnecessary RTE_LOG_DP macros

2024-01-24 Thread Tyler Retzlaff
On Wed, Jan 24, 2024 at 08:28:34AM -0800, Stephen Hemminger wrote: > Several drivers did copy/paste of log macros for datapath > but are not using them, so remove them. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

[PATCH] doc/linux_gsg: add amd configuration section

2024-01-24 Thread Vipin Varghese
Add AMD EPYC SoC tuning guide as new setcion of linux getting started guide. Signed-off-by: Vipin Varghese --- MAINTAINERS | 4 ++ doc/guides/linux_gsg/amd_platform.rst | 70 +++ doc/guides/linux_gsg/index.rst| 1 + 3 files changed, 75

Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-01-24 Thread Tyler Retzlaff
On Wed, Jan 24, 2024 at 05:45:11AM -0800, Rahul Gupta wrote: > From: Rahul Gupta > > In continuation to the following email, I am sending this patch. > (https://inbox.dpdk.org/dev/20231110172523.ga17...@microsoft.com/) > > Initialization requires rte_eal_init + rte_pktmbuf_pool_create which > ca

RE: [EXT] [RFC PATCH] cryptodev: add sm2 key exchange and encryption for HW

2024-01-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, January 4, 2024 2:38 PM > To: Kusztal, ArkadiuszX > Cc: Akhil Goyal ; Ji, Kai ; Power, Ciara > ; Anoob Joseph ; > dev@dpdk.org > Subject: RE: [EXT] [RFC PATCH] cryptodev: add sm2 key exchange and > encryption for

Testing scatter support for PMDs using testpmd

2024-01-24 Thread Jeremy Spewock
Hello maintainers, In porting over the first ethdev suite to the new DTS framework, there was an inconsistency that we found and we were wondering if anyone would be able to shed some light on this. In general the inconsistency pertains to Intel and Mellanox NICs, where one will throw an error and

[PATCH 2/2] drivers: RTE_LOG_DP newline consistency

2024-01-24 Thread Stephen Hemminger
Make sure use of RTE_LOG_DP has newline just like uses of RTE_LOG. Signed-off-by: Stephen Hemminger --- .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 2 +- drivers/crypto/dpaa_sec/dpaa_sec_log.h| 2 +- drivers/event/dlb2/dlb2_log

[PATCH 1/2] drivers: remove unnecessary RTE_LOG_DP macros

2024-01-24 Thread Stephen Hemminger
Several drivers did copy/paste of log macros for datapath but are not using them, so remove them. Signed-off-by: Stephen Hemminger --- drivers/bus/cdx/cdx_logs.h| 11 --- drivers/bus/fslmc/fslmc_logs.h| 11 --- drivers/common/dpaax/dpaax_logs.h

[PATCH 0/2] RTE_LOG_DP cleanups

2024-01-24 Thread Stephen Hemminger
This patch set was suggested by David while reviewing the RTE_LOGTYPE_PMD patches. Stephen Hemminger (2): drivers: remove unnecessary RTE_LOG_DP macros drivers: RTE_LOG_DP newline consistency .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- drivers/bus/cdx/cdx_logs.h

Re: [24.03 RFC] argparse: add argparse library

2024-01-24 Thread Stephen Hemminger
On Tue, 21 Nov 2023 12:26:51 + Chengwen Feng wrote: > Introduce argparse library (which was inspired by the thread [1]), > compared with getopt, the argparse has following advantages: > 1) Set the help information when defining parameters. > 2) Support positional parameters. > > The paramete

Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-01-24 Thread David Marchand
On Wed, Jan 24, 2024 at 2:45 PM Rahul Gupta wrote: > > From: Rahul Gupta > > In continuation to the following email, I am sending this patch. > (https://inbox.dpdk.org/dev/20231110172523.ga17...@microsoft.com/) > > Initialization requires rte_eal_init + rte_pktmbuf_pool_create which > can consume

Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2024 05:45:11 -0800 Rahul Gupta wrote: > + * returns current status of execution on a given lcore > + */ > +__rte_experimental int > +rte_eal_init_async_setup_done(int lcore_id) > +{ > + int ret = (lcore_config[lcore_id].state) parenthesis not needed here

Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2024 05:45:11 -0800 Rahul Gupta wrote: > + > +/* > + * waits until function executing on given lcore finishes. > + * returns value returned by the function executing on that lcore. > + */ > +__rte_experimental int > +rte_eal_init_wait_async_setup_complete(void) > +{ > + int lco

RE: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback march

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:59 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback marc

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:57 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march > confli

Re: [PATCH v5 00/11] use rte_pktmbuf_mto_offset

2024-01-24 Thread Thomas Monjalon
> > Stephen Hemminger (11): > > gro: use rte_pktmbuf_mtod_offset > > gso: use rte_pktmbuf_mtod_offset > > test/crypto_dev: use rte_pktmbuf_mtod_offset > > drivers/crypto: use rte_pktmbuf_mtod_offset > > net/nfp: use rte_pktmbuf_mtod_offset > > net/tap: use rte_pktmbuf_motd_offset > >

RE: [PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread Power, Ciara
> -Original Message- > From: David Marchand > Sent: Wednesday, January 24, 2024 12:05 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Chengwen Feng > ; Laatz, Kevin ; > Richardson, Bruce ; Elena Agostini > ; Jerin Jacob ; Kiran Kumar K > ; Nithin Dabilpuram > ; Yan, Zhirun ; Pavan > Nikhi

Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD

2024-01-24 Thread Lewis Donzis
- On Jan 24, 2024, at 7:58 AM, Ferruh Yigit ferruh.yi...@amd.com wrote: > On 1/24/2024 12:34 PM, Lewis Donzis wrote: > >> - On Jan 11, 2024, at 6:03 AM, Ferruh Yigit ferruh.yi...@amd.com wrote: >> >>> On 1/9/2024 4:00 PM, Lewis Donzis wrote: - On Jan 9, 2024, at 8:2

Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD

2024-01-24 Thread Ferruh Yigit
On 1/24/2024 12:34 PM, Lewis Donzis wrote: > - On Jan 11, 2024, at 6:03 AM, Ferruh Yigit ferruh.yi...@amd.com wrote: > >> On 1/9/2024 4:00 PM, Lewis Donzis wrote: >>> >>> >>> - On Jan 9, 2024, at 8:23 AM, Bruce Richardson >>> bruce.richard...@intel.com >>> wrote: >>> DPDK does not s

RE: [24.03 RFC 1/3] args: new library to allow easier manipulation of cmdline args

2024-01-24 Thread Honnappa Nagarahalli
> > 02/11/2023 18:28, Bruce Richardson: > > Add a new small library to make it easier for apps to work with > > cmdline arguments and build up args to use when initializing EAL. > > > > This library is optional, and can be disabled at build time using the > > disable libraries meson option. > >

Re: [PATCH v5 06/11] net/tap: use rte_pktmbuf_motd_offset

2024-01-24 Thread Thomas Monjalon
08/07/2023 03:57, Stephen Hemminger: > Replace explicit packet offset computations with rte_pktmbuf_mtod_offset(). > > Signed-off-by: Stephen Hemminger It has been reworked by David Marchand in 23.11.

[dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions

2024-01-24 Thread Rahul Gupta
From: Rahul Gupta In continuation to the following email, I am sending this patch. (https://inbox.dpdk.org/dev/20231110172523.ga17...@microsoft.com/) Initialization requires rte_eal_init + rte_pktmbuf_pool_create which can consume a total time of 500-600 ms: a) For many devices FLR may take a si

Re: [PATCH v5 05/11] net/nfp: use rte_pktmbuf_mtod_offset

2024-01-24 Thread Thomas Monjalon
10/07/2023 14:19, Niklas Söderlund: > On 2023-07-07 18:57:12 -0700, Stephen Hemminger wrote: > > Replace explicit packet offset computations with rte_pktmbuf_mtod_offset(). > > > > Signed-off-by: Stephen Hemminger > > Reviewed-by: Niklas Söderlund A similar change by Chaoyong He has been merge

Re: [PATCH v4 0/8] add new command line argument parsing library

2024-01-24 Thread Thomas Monjalon
18/12/2023 10:18, Bruce Richardson: > On Fri, Dec 15, 2023 at 01:53:21PM -0800, Stephen Hemminger wrote: > > On Fri, 15 Dec 2023 17:26:24 + > > Euan Bourke wrote: > > > > > A recent thread on the mailing list[1] discussed corelist and coremask > > > parsing and the idea of a new library dedic

Re: [PATCH v4 1/8] arg_parser: new library for command line parsing

2024-01-24 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 02:16:13PM +0100, Morten Brørup wrote: > > From: Euan Bourke [mailto:euan.bou...@intel.com] > > Sent: Friday, 15 December 2023 18.26 > > > > Add a new library to make it easier for eal and other libraries to > > parse > > command line arguments. > > > > The first function

Re: [PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 01:26:58PM +, Bruce Richardson wrote: > On Wed, Jan 24, 2024 at 01:04:49PM +0100, David Marchand wrote: > > RTE_LOG() macros prefixe the log messages based on the logtype. > > This results in logs like: > > > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/

Re: [PATCH 12/12] examples/dma: replace getopt with argparse

2024-01-24 Thread Thomas Monjalon
22/01/2024 04:58, Chengwen Feng: > -#define CMD_LINE_OPT_MAC_UPDATING "mac-updating" > -#define CMD_LINE_OPT_NO_MAC_UPDATING "no-mac-updating" > -#define CMD_LINE_OPT_PORTMASK "portmask" > -#define CMD_LINE_OPT_NB_QUEUE "nb-queue" > -#define CMD_LINE_OPT_COPY_TYPE "copy-type" > -#define CMD_LINE_OP

Re: [PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 01:04:49PM +0100, David Marchand wrote: > RTE_LOG() macros prefixe the log messages based on the logtype. > This results in logs like: > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' > TMTY: TELEMETRY: Socket creation and binding ok > TMTY: TELEMETRY: Te

Re: [PATCH 02/12] argparse: add argparse library

2024-01-24 Thread Thomas Monjalon
22/01/2024 04:57, Chengwen Feng: > Introduce argparse library (which was inspired by the thread [1]). This > commit provides public API and doc. > > [1] > https://patchwork.dpdk.org/project/dpdk/patch/20231105054539.22303-2-fengcheng...@huawei.com/ I'm not sure how this helps with the initial pr

RE: [PATCH v4 1/8] arg_parser: new library for command line parsing

2024-01-24 Thread Morten Brørup
> From: Euan Bourke [mailto:euan.bou...@intel.com] > Sent: Friday, 15 December 2023 18.26 > > Add a new library to make it easier for eal and other libraries to > parse > command line arguments. > > The first function in this library is one to parse a corelist string > into an array of individual

Re: [PATCH 04/12] test/argparse: add verify argument config test

2024-01-24 Thread Thomas Monjalon
22/01/2024 04:57, Chengwen Feng: > This commit adds verify argument config test. > > Signed-off-by: Chengwen Feng Test can be squashed in the commit adding the feature.

Re: [PATCH 01/12] eal: introduce more macro for bit definition

2024-01-24 Thread Thomas Monjalon
22/01/2024 04:57, Chengwen Feng: > Introduce macros: RTE_MBIT64/RTE_MBIT32, RTE_GENMASK64/RTE_GENMASK32, > and RTE_FIELD_GET64/RTE_FIELD_GET32. A bit of context and description would help. > +/** > + * Get the uint64_t value for a multiple bits set. > + * > + * @param val > + * The value may no

[PATCH] net/cnxk: support Tx queue descriptor count

2024-01-24 Thread skoteshwar
From: Satha Rao Added cnxk APIs to get used txq descriptor count. Signed-off-by: Satha Rao --- doc/guides/nics/features/cnxk.ini | 1 + drivers/net/cnxk/cn10k_ethdev.c | 10 ++ drivers/net/cnxk/cn9k_ethdev.c| 10 ++ drivers/net/cnxk/cnxk_ethdev.h| 11 +++ 4 f

Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD

2024-01-24 Thread Lewis Donzis
Did this get checked in? Just curious because I don't see it in 22.11.4 that was released yesterday, so wasn't sure when it would show up. Thanks, lew - On Jan 11, 2024, at 6:03 AM, Ferruh Yigit ferruh.yi...@amd.com wrote: > On 1/9/2024 4:00 PM, Lewis Donzis wrote: >> >> >> - On Jan

[PATCH] test/event: skip test if no driver is present

2024-01-24 Thread David Marchand
Align eventdev with what other device abstraction libraries do: if no driver is present, skip the tests. Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_eventdev.c | 10 -- 1 file changed, 8 insertions(+), 2 delet

[PATCH] app/testpmd: add command to get Tx queue used count

2024-01-24 Thread skoteshwar
From: Satha Rao Fastpath API to get txq used count. testpmd> show port 0 txq 0 desc count Signed-off-by: Satha Rao --- app/test-pmd/cmdline.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdlin

RE: [PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 24 January 2024 13.05 > > RTE_LOG() macros prefixe the log messages based on the logtype. > This results in logs like: > > TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' > TMTY: TELEMETRY: Socket creatio

[PATCH] lib: remove duplicate prefix in logs

2024-01-24 Thread David Marchand
RTE_LOG() macros prefixe the log messages based on the logtype. This results in logs like: TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...' TMTY: TELEMETRY: Socket creation and binding ok TMTY: TELEMETRY: Telemetry initialized ok Remove redundancy in some libraries following their

Re: [24.03 RFC 1/3] args: new library to allow easier manipulation of cmdline args

2024-01-24 Thread Thomas Monjalon
02/11/2023 18:28, Bruce Richardson: > Add a new small library to make it easier for apps to work with cmdline > arguments and build up args to use when initializing EAL. > > This library is optional, and can be disabled at build time using > the disable libraries meson option. This is an optional

Re: [24.03 RFC 3/3] args: add functions to check parameter validity

2024-01-24 Thread Thomas Monjalon
02/11/2023 18:28, Bruce Richardson: > Add in functions which can be used to check for valid arguments for EAL > or for the application. This can be used to separate out mixed arguments. > > Signed-off-by: Bruce Richardson > --- > lib/args/args.c | 122 +++

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-01-24 Thread Mattias Rönnblom
On 2024-01-23 10:43, Bruce Richardson wrote: On Tue, Jan 23, 2024 at 10:35:02AM +0100, Mattias Rönnblom wrote: On 2024-01-19 18:43, Bruce Richardson wrote: Some small rewording changes to the doxygen comments on struct rte_event_dev_info. Signed-off-by: Bruce Richardson --- lib/eventdev/rt

Re: [PATCH v2 01/11] eventdev: improve doxygen introduction text

2024-01-24 Thread Mattias Rönnblom
On 2024-01-23 10:06, Bruce Richardson wrote: On Tue, Jan 23, 2024 at 09:57:58AM +0100, Mattias Rönnblom wrote: On 2024-01-19 18:43, Bruce Richardson wrote: Make some textual improvements to the introduction to eventdev and event devices in the eventdev header file. This text appears in the doxy

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-01-24 Thread Mattias Rönnblom
On 2024-01-19 18:43, Bruce Richardson wrote: Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clarify the field's use, and whether it is preserved between enqueue and dequeue, and it's role, if any, in schedulin

[PATCH v5] mempool: test performance with larger bursts

2024-01-24 Thread Morten Brørup
Bursts of up to 64 or 128 packets are not uncommon, so increase the maximum tested get and put burst sizes from 32 to 128. For convenience, also test get and put burst sizes of RTE_MEMPOOL_CACHE_MAX_SIZE. Some applications keep more than 512 objects, so increase the maximum number of kept objects

Re: [PATCH v2 10/11] eventdev: RFC clarify comments on scheduling types

2024-01-24 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 05:19:18PM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > The description of ordered and atomic scheduling given in the eventdev > > doxygen documentation was not always clear. Try and simplify this so > > that it is clearer for the end-use

[PATCH] bus/pci: fix secondary process PCI uio resource map problem

2024-01-24 Thread Chaoyong He
From: Zerun Fu For the primary process, the logic loops all BARs and will skip the map of BAR with an invalid physical address (0), also will assign 'uio_res->nb_maps' with the real mapped BARs number. But for the secondary process, instead of loops all BARs, the logic using the 'uio_res->nb_map'

  1   2   >