RE: [PATCH] net/e1000: support launchtime feature

2023-12-21 Thread Chuanyu Xue
Hi Simei, Thank you so much for your review. >> >> /* QAV Tx mode control register */ >> #define E1000_I210_TQAVCTRL 0x3570 >> +#define E1000_I210_LAUNCH_OS0 0x3578 > >What does this register mean? > "LAUNCH_OS0" is defined as LaunchOffset register, which sets the base time for launchtime. Bas

Re: [PATCH v4 7/7] dts: add scatter test suite

2023-12-21 Thread Jeremy Spewock
On Tue, Dec 19, 2023 at 12:29 PM Juraj Linkeš wrote: > Should we use the full name (pmd_buffer_scatter) in the subject? I > lean towards the full name. > > On Mon, Dec 18, 2023 at 7:13 PM wrote: > > > > From: Jeremy Spewock > > > > This test suite provides testing the support of scattered packe

Re: [PATCH v3] ethdev: fix getting supported ptypes list

2023-12-21 Thread Tyler Retzlaff
On Thu, Dec 21, 2023 at 06:40:01PM +, Sivaramakrishnan Venkat wrote: > Incorrect ptypes list causes buffer overflow for Address Sanitizer > run.Previously, the last element in the ptypes lists to be > "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was > not clearly documen

Re: [PATCH v4 1/7] dts: add required methods to testpmd_shell

2023-12-21 Thread Jeremy Spewock
On Tue, Dec 19, 2023 at 11:45 AM Juraj Linkeš wrote: > The subject could be improved. That these methods are required is > kinda obvious. We should try to actually include some useful > information in the subject, such as "add basic methods to testpmd > shell", but even that is not saying much. M

[PATCH v3] ethdev: fix getting supported ptypes list

2023-12-21 Thread Sivaramakrishnan Venkat
Incorrect ptypes list causes buffer overflow for Address Sanitizer run.Previously, the last element in the ptypes lists to be "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was not clearly documented and many PMDs did not follow this implementation. Instead, the dev_supported_

Re: [EXT] Re: [PATCH v2 24/24] doc: port representors in cnxk

2023-12-21 Thread Thomas Monjalon
21/12/2023 14:28, Harman Kalra: > From: Thomas Monjalon > > 19/12/2023 18:40, Harman Kalra: > > > + Representor ports to be created for respective representees should be > > > + defined via these representor devargs. > > > + Eg. To create a representor for representee PF1VF0, devargs to be >

[PATCH 18/18] net/bnxt: enable SSE mode for compressed CQE

2023-12-21 Thread Ajit Khaparde
P7 device family supports 16 byte Rx completions. Enable SSE vector mode for compressed Rx CQE processing. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++- drivers/net/bnxt/bnxt_rxr.h | 2 + drivers/net/bnxt/bnxt_rxtx_

[PATCH 17/18] net/bnxt: add AVX2 support for compressed CQE

2023-12-21 Thread Ajit Khaparde
P7 device family supports 16 byte Rx completions. Add AVX2 vector mode for compressed Rx CQE. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_ethdev.c| 5 + drivers/net/bnxt/bnxt_rxr.h | 2 + drivers/net/bnxt/bnxt_rxtx_vec_avx2.c |

[PATCH 16/18] net/bnxt: query extended stats from firmware

2023-12-21 Thread Ajit Khaparde
From: Damodharam Ammepalli Add the driver support for HWRM_STAT_EXT_CTX_QUERY HWRM msg. In this patch only P7 chipset is enabled for this HWRM while P5 and previous generation remain with HWRM_STAT_CTX_QUERY. Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[PATCH 15/18] net/bnxt: add 400G get support for P7 devices

2023-12-21 Thread Ajit Khaparde
From: Damodharam Ammepalli P7 devices report speeds over speeds2 hsi fields. Adding required support to capture the capability from phy_qcap and save the speeds2 fields into driver priv structure. In fixed mode update the link_speed from force_link_speeds2 field. Updates to logging to provide mor

[PATCH 14/18] net/bnxt: add tunnel TPA support

2023-12-21 Thread Ajit Khaparde
From: Damodharam Ammepalli This patch adds support for tunnel TPA type. The tunnel TPA support is brought in by the updated bit_field tnl_tpa_en(4) in hwrm_vnic_tpa_cfg_input->enables, which is used by the firmware to indicate the capability of the underlying hardware. This patch updates hwrm HW

[PATCH 13/18] net/bnxt: add VF FLR async event handler

2023-12-21 Thread Ajit Khaparde
From: Jay Ding When a VF undergoes an FLR, the firmware indicates this via an async notification to the PF. Note that the PF driver needs to register for the notification with the firmware. Add support for VF_FLR async event handling when the driver is running on a PF. Signed-off-by: Jay Ding S

[PATCH 12/18] net/bnxt: set allmulti mode if multicast filter fails

2023-12-21 Thread Ajit Khaparde
Fallback to all multicast mode if FW rejects multicast filter programming. The firmware can reject the MC filter programming request if it is running low in resources when there is a large number of functions. The driver must be prepared to fallback to the all-multicast mode if the original MC fil

[PATCH 11/18] net/bnxt: add ESP and AH header based RSS support

2023-12-21 Thread Ajit Khaparde
Check if the firmware can support RSS based on these types and program the hardware accodringly when requested when the firmware indicates that the underlying hardware supports the functionality. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h|

[PATCH 10/18] net/bnxt: add flow query callback

2023-12-21 Thread Ajit Khaparde
From: Damodharam Ammepalli This patch addsbnxt query callback to rte_flow_ops in non TruFlow mode. At this point only the RSS hash function type is displayed. Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 61 +

[PATCH 09/18] net/bnxt: extend RSS hash support for P7 devices

2023-12-21 Thread Ajit Khaparde
P7 adapters support XOR based and checksum based RSS hashing. Add support for checksum and XOR based RSS hash for these adapters. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h| 15 +-- drivers/net/bnxt/bnxt_ethdev.c | 72 ++- dr

[PATCH 08/18] net/bnxt: refactor Rx doorbell during Rx flush

2023-12-21 Thread Ajit Khaparde
Ring the Rx doorbell during the Rx ring flush processing only if there is a valid completion. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_rxr.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b

[PATCH 07/18] net/bnxt: reattempt mbuf allocation for Rx and AGG rings

2023-12-21 Thread Ajit Khaparde
Normally the PMD allocates a new mbuf for every mbuf consumed. In case of mbuf alloc failure, that slot in the Rx or AGG ring remains empty till a new mbuf is not allocated for that slot. If this happens too frequently the Rx ring or the aggregation ring could be completely drained of mbufs and can

[PATCH 06/18] net/bnxt: support backward compatibility

2023-12-21 Thread Ajit Khaparde
From: Kalesh AP On older firmware versions, HWRM_FUNC_QCAPS response is not returning the maximum number of multicast filters that can be supported by the function. As a result, memory allocation with size 0 fails. Bugzilla ID: 1309 Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Aji

[PATCH 05/18] net/bnxt: fix speed change from 200G to 25G on Thor

2023-12-21 Thread Ajit Khaparde
From: Kalesh AP While forcing speed to 200G, driver sets the structure variable "bp->link_info->link_signal_mode" value to BNXT_SIG_MODE_PAM4. After that when the user forces the speed back to 25G, this cached value is not set back to BNXT_SIG_MODE_NRZ which results in issuing the HWRM_PORT_PHY_C

[PATCH 04/18] net/bnxt: fix setting 50G and 100G forced speed

2023-12-21 Thread Ajit Khaparde
From: Kalesh AP Thor based NICs can support PAM4 as well as NRZ link negotiation. While PAM4 can negotiate speeds at 50G, 100G and 200G, the PMD will use NRZ signaling for 50G and 100G speeds. PAM4 signaling will be used only for 200G speed negotiations. Driver has to check for NRZ speed support

[PATCH 03/18] net/bnxt: fix a typo while parsing link speed

2023-12-21 Thread Ajit Khaparde
From: Kalesh AP While setting forced speed, the speed should have mapped to macro "HWRM_PORT_PHY_CFG_INPUT_FORCE_xxx" instead of "HWRM_PORT_PHY_CFG_INPUT_AUTO_xxx". We do not see any issue as both these macros are defined to the same value. Fixing it for better convey the intent. Signed-off-by:

[PATCH 02/18] net/bnxt: add support for compressed Rx CQE

2023-12-21 Thread Ajit Khaparde
Thor2 supports compressed Rx completions instead of the full featured 32-byte Rx completions. Add support for these compressed CQEs in scalar mode. Unlike in the typical Rx completions, the hardware does not provide the opaque field to index into the aggregator descriptor ring. So maintain the cons

[PATCH 01/18] net/bnxt: add support for UDP GSO

2023-12-21 Thread Ajit Khaparde
UDP GSO aka UDP Fragmentation Offload allows an application or stack to provide a data payload larger than the MTU. The application then updates the mbuf ol_flags and sets the PKT_TX_UDP_SEG flag. Then based on the tso_segs and tso_mss fields in the mbuf the PMD can indicate the UDP GSO transmit re

[PATCH 00/18] bnxt patchset

2023-12-21 Thread Ajit Khaparde
This patchset contains more code fixes and reafctoring, apart from extending more support for the newer P7 device family. The patchset adds vector mode support for compressed Rx CQE. This patchset includes support for checksum and XOR RSS hash mode. It also adds support for forced speeds and autone

[PATCH v3 2/2] ip_frag: updated name for IP frag max frag define

2023-12-21 Thread Euan Bourke
Removed LIBRTE from name as its an old prefix. Signed-off-by: Euan Bourke --- app/test/test_reassembly_perf.c | 2 +- config/rte_config.h | 2 +- doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 8 doc/guides/sample_app_ug/ip_r

[PATCH v3 1/2] doc: updated incorrect value for IP frag max fragments

2023-12-21 Thread Euan Bourke
Docs for IP Fragment said RTE_LIBRTE_IP_FRAG_MAX_FRAG was 4 by default, however this was changed to 8. Documentation has been updated to account for this, including a snippet of code where RTE_LIBRTE_IP_FRAG_MAX_FRAG is defined to ensure documentation stays up to date. Fixes: f8e0f8ce9030 ("ip_fr

Re: [PATCH] devtools: forbid writing to standard output streams

2023-12-21 Thread Tyler Retzlaff
On Thu, Dec 21, 2023 at 02:31:20PM +0100, David Marchand wrote: > No output on stdout or stderr! > Drivers and libraries must use the logging framework. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff

[PATCH v5 18/18] log: mark PMD logtype as deprecated

2023-12-21 Thread Stephen Hemminger
This is temporary patch to help find all misuse use of PMD logtype --- lib/log/log.c | 3 +++ lib/log/rte_log.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/log/log.c b/lib/log/log.c index ab06132a98a1..09a31a62c0fd 100644 --- a/lib/log/log.c +++ b/lib/log/log.c @@

[PATCH v5 17/18] examples/fips_validation: replace use of PMD logtype

2023-12-21 Thread Stephen Hemminger
Replace PMD with USER1 since that is already used in main Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[PATCH v5 16/18] net/nfb: use dynamic logtype

2023-12-21 Thread Stephen Hemminger
All drivers should be using dynamic logtype. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: Stephen Hemminger --- drivers/net/nfb/nfb.h| 5 + drivers/net/nfb/nfb_ethdev.c | 24 ++-- drivers/net/nfb/nfb_rx.c | 9 - drivers/net/

[PATCH v5 15/18] event/skeleton: replace logtype PMD with dynamic type

2023-12-21 Thread Stephen Hemminger
The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 4 ++-- drivers/event/skeleton/skeleton_eventdev.h | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --

[PATCH v5 14/18] event/dpaa, event/dpaa2: use dedicated logtype

2023-12-21 Thread Stephen Hemminger
Do not use RTE_LOGTYPE_PMD. Fixes: b0f66a68ca74 ("event/dpaa: support crypto adapter") Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c| 2 +- drivers/event/dpaa2/dpaa2_eventdev.c

[PATCH v5 13/18] event/dlb2: use dedicated logtype

2023-12-21 Thread Stephen Hemminger
Driver was using RTE_LOGTYPE_PMD when it had its own logtype. Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 275 +++--- 1 file changed, 137 insertions(+), 138 deletions(-) diff --git a/driv

[PATCH v5 12/18] crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype

2023-12-21 Thread Stephen Hemminger
A couple of messages were using RTE_LOGTYPE_PMD when dedicated logtype was already available. Fixes: fe3688ba7950 ("crypto/dpaa_sec: support event crypto adapter") Fixes: bffc7d561c81 ("crypto/dpaa2_sec: support event crypto adapter") Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec

[PATCH v5 11/18] crypto/caam_jr: use dedicated logtype

2023-12-21 Thread Stephen Hemminger
The driver has macro and logtype but not used in a couple places. Also, remove extraneous newlines. Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver") Signed-off-by: Stephen Hemminger --- drivers/crypto/caam_jr/caam_jr.c | 46 +--- drivers/crypto/caam_jr/c

[PATCH v5 10/18] crypto/ccp: do not use PMD logtype

2023-12-21 Thread Stephen Hemminger
This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd

[PATCH v5 09/18] crypto/scheduler: replace use of logtype PMD

2023-12-21 Thread Stephen Hemminger
Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s

[PATCH v5 08/18] raw/cnxk: replace PMD logtype with dynamic type

2023-12-21 Thread Stephen Hemminger
Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 16 ++- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_

[PATCH v5 07/18] net/vmxnet3: used dedicated logtype not PMD

2023-12-21 Thread Stephen Hemminger
The driver has log macros, just not used in one place. Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c

[PATCH v5 06/18] net/mvpp2: use dedicated logtype

2023-12-21 Thread Stephen Hemminger
Always use the dedicated logtype, not PMD. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2

[PATCH v5 05/18] net/dpaa2: used dedicated logtype not PMD

2023-12-21 Thread Stephen Hemminger
The driver has a logtype, but was not being used in one place. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_sparse

[PATCH v5 04/18] net/dpaa: use dedicated logtype not PMD

2023-12-21 Thread Stephen Hemminger
The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 8 1 file change

[PATCH v5 03/18] mempool/dpaa2: use driver logtype not PMD

2023-12-21 Thread Stephen Hemminger
The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw

[PATCH v5 02/18] common/sfc_efx: remove use of PMD logtype

2023-12-21 Thread Stephen Hemminger
This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v5 01/18] drivers: use dedicated logtypes

2023-12-21 Thread Stephen Hemminger
From: David Marchand When a driver dedicated logtype exists, use it instead of the generic PMD logtype. This has been done partially automatically with: $ for file in $(git grep -l RTE_LOG.*PMD.*fmt drivers/'**.h' \ :^drivers/common/cnxk/roc_platform.h) do tail=${file#drivers/*/*/} dir=${

[PATCH v5 00/18] Replace uses of PMD logtype

2023-12-21 Thread Stephen Hemminger
The generic RTE_LOGTYPE_PMD is a leftover and should be removed. This replaces all uses in current tree. It leaves PMD logtype as deprecated because there maybe other uses in external projects leftover. This version does not use Depends-on: because CI system can't handle that and want to make sure

Re: [PATCH v5 00/13] Detect superfluous newline in logs

2023-12-21 Thread Stephen Hemminger
On Wed, 20 Dec 2023 16:35:53 +0100 David Marchand wrote: > Getting readable and consistent logs is important when running a DPDK > application, especially when troubleshooting. > A common issue with logs is when a DPDK change do not add (or on the > contrary add too many \n) in the format string.

Re: [PATCH] devtools: forbid writing to standard output streams

2023-12-21 Thread Stephen Hemminger
On Thu, 21 Dec 2023 14:31:20 +0100 David Marchand wrote: > No output on stdout or stderr! > Drivers and libraries must use the logging framework. > > Signed-off-by: David Marchand > --- > devtools/checkpatches.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/devtools/checkp

DTS roadmap for 24.03

2023-12-21 Thread Juraj Linkeš
Here are the DTS items the community plans on adding to 24.03: Existing patches: * Dockerfile as a convenient way for developers to use DTS: https://patches.dpdk.org/project/dpdk/list/?series=25550 * DTS HTML API generation from DTS docstrings: https://patches.dpdk.org/project/dpdk/list/?series=30

Re: [PATCH] devtools: forbid writing to standard output streams

2023-12-21 Thread Bruce Richardson
On Thu, Dec 21, 2023 at 02:31:20PM +0100, David Marchand wrote: > No output on stdout or stderr! > Drivers and libraries must use the logging framework. > > Signed-off-by: David Marchand > --- > devtools/checkpatches.sh | 8 > 1 file changed, 8 insertions(+) Acked-by: Bruce Richardson

Re: [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments

2023-12-21 Thread Bourke, Euan
On 21/12/2023 11:41, Thomas Monjalon wrote: 21/12/2023 12:32, Euan Bourke: -/* ip_fragmentation defines */ +/* ip_fragmentation defines 8< */ #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 +/* >8 End of ip_fragmentation defines */ [...] +.. literalinclude:: ../../../config/rte_config.h +:start-af

[PATCH] devtools: forbid writing to standard output streams

2023-12-21 Thread David Marchand
No output on stdout or stderr! Drivers and libraries must use the logging framework. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 10d1bf490b..c9e466f736 100755 ---

RE: [EXT] Re: [PATCH v2 24/24] doc: port representors in cnxk

2023-12-21 Thread Harman Kalra
Hi Thomas, Thanks for reviewing. Please find responses inline. Thanks Harman > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, December 20, 2023 3:08 PM > To: Harman Kalra > Cc: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Ra

Re: [PATCH v1] common/qat: option to disable asym driver

2023-12-21 Thread Bruce Richardson
On Thu, Dec 21, 2023 at 12:23:02PM +, Brian Dooley wrote: > Currently the QAT sym and asym drivers can only be disabled together > when building. Add an option to disable the QAT asym driver. > > Signed-off-by: Brian Dooley Hi Brian, Couple of questions that aren't clear to me from this pat

[PATCH 24/24] crypto/cnxk: add CPT SG mode debug

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Adding CPT SG mode debug dump. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 135 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 7 ++ 2 files changed, 141 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnx

[PATCH 21/24] crypto/cnxk: use a single function for opad ipad

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Use a single function for opad and ipad generation for IPsec, TLS and flexi crypto. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 65 ++--- drivers/common/cnxk/cnxk_security.h | 5 --- drivers/common/cnxk/roc_s

[PATCH 23/24] crypto/cnxk: add TLS 1.3 capability

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.3 record read and write capability Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 4 +- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 92 +++ 2 files changed, 94 insertions(+), 2 deletions(-) diff

[PATCH 20/24] crypto/cnxk: validate the combinations supported in TLS

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Validate the cipher and auth combination to allow only the ones supported by hardware. Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_tls.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 22/24] crypto/cnxk: add support for TLS 1.3

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 50 +-- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 159 +- 3 files changed, 136

[PATCH 17/24] crypto/cnxk: add TLS capability

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS 1.2 record read and write capability. Add DTLS 1.2 record read and write capability. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- doc/guides/rel_notes/release_24_03.rst| 2 + drivers/common/cnxk/hw/cpt.h |

[PATCH 19/24] crypto/cnxk: replace PDCP with PDCP chain opcode

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Replacing PDCP opcode with PDCP chain opcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 331 +- drivers/common/cnxk/roc_se.h | 18 +- drivers/crypto/cnxk/cnxk_se.h | 96 +- 3 files changed, 135 insertions

[PATCH 18/24] crypto/cnxk: add PMD APIs for raw submission to CPT

2023-12-21 Thread Anoob Joseph
Add PMD APIs to allow applications to directly submit CPT instructions to hardware. Signed-off-by: Anoob Joseph --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/rel_notes/release_24_03.rst| 1 + drivers/crypto/cnxk/cn10k_cryp

[PATCH 16/24] crypto/cnxk: add TLS record datapath handling

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for TLS record handling in datapath. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 57 +++- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 7 + drivers/crypto/cnxk/cn10k_tls_ops.h |

[PATCH 15/24] crypto/cnxk: add TLS record session ops

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add TLS record session ops for creating and destroying security sessions. Add support for both read and write sessions. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 8 + drivers/crypto/cnxk/cn10k_t

[PATCH 14/24] crypto/cnxk: separate IPsec from security common code

2023-12-21 Thread Anoob Joseph
The current structs and functions assume only IPsec offload. Separate it out to allow for addition of TLS. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev.c | 2 +- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 127

[PATCH 13/24] common/cnxk: add TLS record contexts

2023-12-21 Thread Anoob Joseph
Add TLS record read and write contexts. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_cpt.h | 4 +- drivers/common/cnxk/roc_ie_ot_tls.h | 199 drivers/common/cnxk/roc_se.h| 11 ++ 3 files changed, 211 in

[PATCH 12/24] common/cnxk: update opad-ipad gen to handle TLS

2023-12-21 Thread Anoob Joseph
For TLS opcodes, ipad is at the offset 64 as compared to the packed implementation for IPsec. Extend the function to handle TLS contexts as well. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 15 --- drivers/common/cnxk/cnx

[PATCH 11/24] crypto/cnxk: rename security caps as IPsec security caps

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Security capabilities would vary between IPsec and other new offloads. Rename existing security caps to indicate that they are IPsec specific ones. Rename and change the scope of common functions, inorder to avoid code duplication. These functions can be used by both I

[PATCH 10/24] crypto/cnxk: enable Rx inject for 103

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Enable Rx inject feature for 103XX Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.c b/drivers/crypto/cnxk/cnxk_cryptodev.c index b168

[PATCH 09/24] crypto/cnxk: Rx inject config update

2023-12-21 Thread Anoob Joseph
From: Rahul Bhansali - Update chan in CPT inst from port's Rx chan - Set Rx inject config in Idev struct Signed-off-by: Rahul Bhansali --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 +++- drivers/crypto/cnxk/cn10k_ipsec.c | 3 +++ drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + dri

[PATCH 08/24] common/cnxk: add Rx inject configs

2023-12-21 Thread Anoob Joseph
From: Rahul Bhansali Add Rx inject config for feature enable/disable, and store Rx chan value per port. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_idev.c | 44 + drivers/common/cnxk/roc_idev.h | 5 drivers/common/cnxk/roc_idev_priv.h |

[PATCH 07/24] crypto/cnxk: enable Rx inject in security lookaside

2023-12-21 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add Rx inject fastpath API. Add devargs to specify an LF to be used for Rx inject. When the RX inject feature flag is enabled: 1. Reserve a CPT LF to use for RX Inject mode. 2. Enable RXC and disable full packet mode for that LF. Signed-off-by: Anoob Joseph Signed-off

[PATCH 06/24] crypto/cnxk: enable digest gen for zero len input

2023-12-21 Thread Anoob Joseph
From: Aakash Sasidharan With zero length input, digest generation fails with incorrect value. Fix this by completely avoiding the gather component when the input packet has zero data length. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(

[PATCH 05/24] crypto/cnxk: fix ECDH pubkey verify in cn9k

2023-12-21 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Fix ECDH pubkey verify in cn9k. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/cr

[PATCH 04/24] crypto/cnxk: return microcode completion code

2023-12-21 Thread Anoob Joseph
Return microcode completion code in case of errors. This allows applications to check the failure reasons in more granularity. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c

[PATCH 03/24] crypto/cnxk: fallback to SG if headroom is not available

2023-12-21 Thread Anoob Joseph
From: Tejasree Kondoj Falling back to SG mode for cn9k lookaside IPsec if headroom is not available. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/

[PATCH 01/24] common/cnxk: fix memory leak

2023-12-21 Thread Anoob Joseph
From: Akhil Goyal dev_init() acquires some resources which need to be cleaned in case a failure is observed afterwards. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_cpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[PATCH 02/24] crypto/cnxk: use common macro

2023-12-21 Thread Anoob Joseph
Having different macros for same purpose may cause issues if one is updated without updating the other. Use same macro by including the header. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/c

[PATCH 00/24] Fixes and improvements in crypto cnxk

2023-12-21 Thread Anoob Joseph
Add following features - TLS record processing offload (TLS 1.2-1.3, DTLS 1.2) - Rx inject to allow lookaside packets to be injected to ethdev Rx - Use PDCP_CHAIN opcode instead of PDCP opcode for cipher-only and auth only cases Aakash Sasidharan (1): crypto/cnxk: enable digest gen for zero le

[PATCH v1] common/qat: option to disable asym driver

2023-12-21 Thread Brian Dooley
Currently the QAT sym and asym drivers can only be disabled together when building. Add an option to disable the QAT asym driver. Signed-off-by: Brian Dooley --- drivers/common/qat/meson.build | 22 +--- drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 2 ++ drivers/

RE: [PATCH] net/iavf: add diagnostic support in TX path

2023-12-21 Thread Zhang, Qi Z
> -Original Message- > From: Mingjin Ye > Sent: Thursday, December 21, 2023 6:12 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH] net/iavf: add diagnostic support in TX path > > The only way to enable diagnostics for TX paths

Re: [v6] net/af_xdp: enable uds_path instead of use_cni

2023-12-21 Thread David Marchand
On Thu, Dec 21, 2023 at 12:46 PM Maryam Tahhan wrote: > > If there are fixes mixed in, please separate them in dedicated patches > > so we can backport them to LTS releases. > > Thanks for the Feedback David, I don't quite understand the ask here, is to > to have a separate patch for documentatio

Re: [PATCH v9 00/21] dts: docstrings update

2023-12-21 Thread Thomas Monjalon
04/12/2023 11:24, Juraj Linkeš: > The first commit makes changes to the code. These code changes mainly > change the structure of the code so that the actual API docs generation > works. There are also some code changes which get reflected in the > documentation, such as making functions/methods/at

Re: [v6] net/af_xdp: enable uds_path instead of use_cni

2023-12-21 Thread Maryam Tahhan
On 21/12/2023 11:36, David Marchand wrote: Hello, On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan wrote: With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a DPDK pod is requesting multiple net devices and these devices are from different po

Re: [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments

2023-12-21 Thread Thomas Monjalon
21/12/2023 12:32, Euan Bourke: > -/* ip_fragmentation defines */ > +/* ip_fragmentation defines 8< */ > #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 > +/* >8 End of ip_fragmentation defines */ [...] > +.. literalinclude:: ../../../config/rte_config.h > +:start-after: ip_fragmentation defines 8< > +

Re: [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments

2023-12-21 Thread David Marchand
Hello, On Thu, Dec 21, 2023 at 12:33 PM Euan Bourke wrote: > > Docs for IP Fragment said RTE_LIBRTE_IP_FRAG_MAX_FRAGS was 4 by default, > however this was changed to 8. > > Documentation has been updated to account for this, including a > snippet of the code where RTE_LIBRTE_IP_FRAG_MAX_FRAGS is

Re: [v6] net/af_xdp: enable uds_path instead of use_cni

2023-12-21 Thread David Marchand
Hello, On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan wrote: > > With the original 'use_cni' implementation, (using a > hardcoded socket rather than a configurable one), > if a DPDK pod is requesting multiple net devices > and these devices are from different pools, then > the container attempts t

[PATCH v2 2/2] ip_frag: updated name for IP frag define

2023-12-21 Thread Euan Bourke
Removed LIBRTE from name as its an old prefix. Signed-off-by: Euan Bourke --- app/test/test_reassembly_perf.c | 2 +- config/rte_config.h | 2 +- doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 4 ++-- doc/guides/sample_app_ug/ip_reass

[PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments

2023-12-21 Thread Euan Bourke
Docs for IP Fragment said RTE_LIBRTE_IP_FRAG_MAX_FRAGS was 4 by default, however this was changed to 8. Documentation has been updated to account for this, including a snippet of the code where RTE_LIBRTE_IP_FRAG_MAX_FRAGS is defined to ensure the documentation stays up to date. Signed-off-by: Eu

[PATCH v1 1/1] net/thunderx: update dmac control register to appropriately

2023-12-21 Thread Hanumanth Pothula
By default dmac control register is set to reject packets on mac address match, leading all unicast packets to drop. Update DMAC control register to allow packets on MAC address match rather than dropping. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/base/nicvf_mbox.c | 12

RE: [v6] net/af_xdp: enable uds_path instead of use_cni

2023-12-21 Thread Koikkara Reeny, Shibin
Thank you Maryam for the changes. We can merge the patch. Regards, Shibin > -Original Message- > From: Maryam Tahhan > Sent: Friday, December 15, 2023 3:40 PM > To: ferruh.yi...@amd.com; step...@networkplumber.org; > lihuis...@huawei.com; fengcheng...@huawei.com; > liuyongl...@huawei.co

[PATCH] net/ice: add diagnostic support in TX path

2023-12-21 Thread Mingjin Ye
The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

[PATCH] net/i40e: add diagnostic support in TX path

2023-12-21 Thread Mingjin Ye
The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

[PATCH] net/iavf: add diagnostic support in TX path

2023-12-21 Thread Mingjin Ye
The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

Re: [PATCH v4 07/17] raw/cnxk: replace PMD logtype with dynamic type

2023-12-21 Thread David Marchand
On Mon, Dec 18, 2023 at 8:27 PM Stephen Hemminger wrote: > > Driver should not be using PMD logtype, they should have their > own logtype. > > Signed-off-by: Stephen Hemminger [snip] \ > diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c > b/drivers/raw/cnxk_bphy/c

Re: [PATCH v4 14/17] event/skeleton: replace logtype PMD with dynamic type

2023-12-21 Thread David Marchand
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger wrote: > > The skeleton is supposed to match current best practices. > Change it to use dynamic logtype. > > Signed-off-by: Stephen Hemminger > --- > drivers/event/skeleton/skeleton_eventdev.c | 3 ++- > drivers/event/skeleton/skeleton_eventdev.h

Re: [PATCH v4 12/17] event/dlb2: use dedicated logtype

2023-12-21 Thread David Marchand
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger wrote: > > Driver was using RTE_LOGTYPE_PMD when it had its own logtype. > Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") > > Signed-off-by: Stephen Hemminger > --- > drivers/event/dlb2/dlb2.c | 5 ++--- > 1 file changed, 2 insertions(+),

Re: [PATCH v4 08/17] crypto/scheduler: replace use of logtype PMD

2023-12-21 Thread David Marchand
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger wrote: > > Driver has logging macro but not used everywhere. > > Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold > parameter") > Signed-off-by: Stephen Hemminger > --- > drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- > 1

Re: [PATCH v4 11/17] crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype

2023-12-21 Thread David Marchand
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger wrote: > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c > b/drivers/crypto/dpaa_sec/dpaa_sec.c > index a301e8edb2a4..3008ca4dc2f7 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -3518,7 +3518,7 @@

  1   2   >