[Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

https://bugs.dpdk.org/show_bug.cgi?id=1335 Bug ID: 1335 Summary: [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14 Product: DPDK Version: 23.11 Hardware: All OS:

[PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets

Instead of freeing directly, use commonly used function which also updates stats. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c

[PATCH 1/2] examples/ipsec-secgw: fix width of variables

'rte_eth_rx_burst' returns uint16_t. The same value need to be passed to 'process_packets' functions which performs further processing. Having this function use 'uint8_t' can result in issues when MAX_PKT_BURST is larger. The route functions (route4_pkts & route6_pkts) take uint8_t as the argument

RE: [PATCH] ixgbe: fix interrupt clear mask for eimc register

> -Original Message- > From: Simon Ellmann > Sent: Thursday, December 14, 2023 7:03 PM > To: Zhang, Qi Z > Cc: Yang, Qiming ; Wu, Wenjun1 > ; dev@dpdk.org > Subject: Re: [PATCH] ixgbe: fix interrupt clear mask for eimc register > > > On 14. Dec 2023, at 03:24, Zhang, Qi Z wrote: > >>

[PATCH v2 0/6] fix lcore ID restriction

With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Sivaprasad Tummala (6): e

[PATCH v2 6/6] examples/vm_power_manager: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 0e8f47491f09 ("examples/vm_power: add command to query CPU frequency") Cc: marcinx.hajkow...@intel.com Cc: sta...@dpdk.org Si

[PATCH v2 4/6] examples/ipsec-secgw: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sergio.gonzalez.mon...@intel.com Cc: sta...@dpdk.org

[PATCH v2 5/6] examples/qos_sched: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: de3cfa2c9823 ("sched: initial import") Cc: sta...@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/qos_sched/args.c

[PATCH v2 3/6] examples/l3fwd-graph: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Cc: ndabilpu...@marvell.com Cc: sta...@dpdk.org Signed-

[PATCH v2 2/6] examples/l3fwd-power: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Cc: radu.nico...@intel.com Cc: sta...@dpdk.org Si

[PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction

Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd/main.c | 19

[PATCH v2 0/6] fix lcore ID restriction

With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Sivaprasad Tummala (6): e

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/

[PATCH] dpdk: Enable GQ stats reporting

Read from shared region to retrieve imissed statistics for GQ. Change-Id: I8123d70ec5019b12f368e67b858c382bb7812e5c --- dpdk/base/gve_adminq.h | 11 ++ dpdk/gve_ethdev.c | 84 ++ dpdk/gve_ethdev.h | 6 +++ 3 files changed, 101 insertions(+)

[PATCH v2 2/3] ethdev: add compare item

The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH v2 3/3] net/mlx5: add compare item support

The compare item allows adding flow match with comparison result. This commit adds compare item support to the PMD code. Due to HW limitation: - Only HWS supported. - Only 32-bit comparison is supported. - Only single compare flow is supported in the flow table. - Only match with compare resul

[PATCH v2 1/3] ethdev: rename action modify field data structure

Current rte_flow_action_modify_data struct describes the pkt field perfectly and is used only in action. It is planned to be used for item as well. This commit renames it to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou --- app/test-pmd/cmdline_flow.

[PATCH v2 0/3] [PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

RE: [PATCH] bus/ifpga: remove dead code

Hi > -Original Message- > From: David Marchand > Sent: Monday, December 18, 2023 11:45 PM > To: dev@dpdk.org > Cc: Xu, Rosen ; Tianfei Zhang > ; Zhang, Qi Z > Subject: [PATCH] bus/ifpga: remove dead code > > This macro was never used. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA

Re: [RFC v2 09/14] rcu: introduce a logging helper

On Mon, Dec 18, 2023 at 10:37:12AM +0100, David Marchand wrote: > On Tue, Dec 12, 2023 at 8:11 PM Tyler Retzlaff > wrote: > > On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > > > On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff > > > wrote: > > > > > > > > On Fri, Dec 08, 2023 at 0

[PATCH v4 17/17] log: mark PMD logtype as deprecated

This is temporary patch to help find all misue use of PMD logtype --- lib/log/log.c | 3 +++ lib/log/rte_log.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/log/log.c b/lib/log/log.c index ab06132a98a1..09a31a62c0fd 100644 --- a/lib/log/log.c +++ b/lib/log/log.c @@

[PATCH v4 16/17] examples/fips_validation: replace use of PMD logtype

Replace PMD with USER1 since that is already used in main Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[PATCH v4 15/17] net/nfb: use dynamic logtype

All drivers should be using dynamic logtype. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: Stephen Hemminger --- drivers/net/nfb/nfb.h| 5 + drivers/net/nfb/nfb_ethdev.c | 24 ++-- drivers/net/nfb/nfb_rx.c | 9 - drivers/net/

[PATCH v4 14/17] event/skeleton: replace logtype PMD with dynamic type

The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 3 ++- drivers/event/skeleton/skeleton_eventdev.h | 8 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --g

[PATCH v4 13/17] event/dpaa, event/dpaa2: use dedicated logtype

Do not use RTE_LOGTYPE_PMD. Fixes: b0f66a68ca74 ("event/dpaa: support crypto adapter") Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Stephen Hemminger Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c| 2 +- drivers/ev

[PATCH v4 12/17] event/dlb2: use dedicated logtype

Driver was using RTE_LOGTYPE_PMD when it had its own logtype. Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/d

[PATCH v4 11/17] crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype

A couple of messages were using RTE_LOGTYPE_PMD when dedicated logtype was already available. Fixes: fe3688ba7950 ("crypto/dpaa_sec: support event crypto adapter") Fixes: bffc7d561c81 ("crypto/dpaa2_sec: support event crypto adapter") Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec

[PATCH v4 10/17] crypto/caam_jr: use dedicated logtype

The driver has macro and logtype but not used in a couple places. Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver") Signed-off-by: Stephen Hemminger --- drivers/crypto/caam_jr/caam_jr.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/caa

[PATCH v4 09/17] crypto/ccp: do not use PMD logtype

This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd

[PATCH v4 08/17] crypto/scheduler: replace use of logtype PMD

Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s

[PATCH v4 07/17] raw/cnxk: replace PMD logtype with dynamic type

Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 16 ++- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_

[PATCH v4 06/17] net/vmxnet3: used dedicated logtype not PMD

The driver has log macros, just not used in one place. Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c

[PATCH v4 05/17] net/mvpp2: use dedicated logtype

Always use the dedicated logtype, not PMD. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2

[PATCH v4 04/17] net/dpaa2: used dedicated logtype not PMD

The driver has a logtype, but was not being used in one place. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_sparse

[PATCH v4 03/17] net/dpaa: use dedicated logtype not PMD

The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 8 1 file change

[PATCH v4 02/17] mempool/dpaa2: use driver logtype not PMD

The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw

[PATCH v4 01/17] common/sfc_efx: remove use of PMD logtype

This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v4 00/17] Replace uses of RTE_LOGTYPE_PMD

The generic RTE_LOGTYPE_PMD is a leftover and should be removed. This replaces all uses in current tree. It leaves PMD logtype as deprecated because there maybe other uses in external projects leftover. Depends-on: patch-135264 ("drivers: use dedicated logtypes") Stephen Hemminger (17): common/

[PATCH v4 7/7] dts: add scatter test suite

From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v4 6/7] dts: add scatter to the yaml schema

From: Jeremy Spewock Allow for scatter to be specified in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/confi

[PATCH v4 5/7] dts: allow configuring MTU of ports

From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 8 dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v4 4/7] dts: add pci addresses to EAL parameters

From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevant PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 11 +++ 1 file changed, 11 insertions(+)

[PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer

From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v4 2/7] dts: allow passing parameters into interactive apps

From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- .../

[PATCH v4 1/7] dts: add required methods to testpmd_shell

From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Also added methods for starting and stopping packet f

[PATCH v4 0/7] dts: Port scatter suite over

From: Jeremy Spewock v4: Addresses comments on the previous version. Main things which were added include specific methods within the testpmd shell to avoid the need of calling send_command directly, as well as docstring comment updates. This series had to get resubmitted so that it would show

[PATCH] net/dpaa2: used dedicated logtype not PMD

The driver has a logtype, but was not being used in one place. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev

[PATCH v4 7/7] dts: add scatter test suite

From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v4 5/7] dts: allow configuring MTU of ports

From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 8 dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v4 6/7] dts: add scatter to the yaml schema

From: Jeremy Spewock Allow for scatter to be specified in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/confi

[PATCH v4 4/7] dts: add pci addresses to EAL parameters

From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevant PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 11 +++ 1 file changed, 11 insertions(+)

[PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer

From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v4 1/7] dts: add required methods to testpmd_shell

From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Also added methods for starting and stopping packet f

[PATCH v4 2/7] dts: allow passing parameters into interactive apps

From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- .../

[PATCH v4 0/7] dts: Port scatter suite over

From: Jeremy Spewock v4: Addresses comments on the previous version. Main things which were added include specific methods within the testpmd shell to avoid the need of calling send_command directly, as well as docstring comment updates. This series had to get resubmitted so that it would show

[PATCH] mempool/dpaa2: use driver logtype not PMD

The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw

Re: [PATCH v4 02/14] regexdev: fix logtype register

On Mon, 18 Dec 2023 15:37:51 +0100 David Marchand wrote: > This library logtype was not initialized so its logs would end up under > the 0 logtype, iow, RTE_LOGTYPE_EAL. > > Fixes: b25246beaefc ("regexdev: add core functions") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > Reviewed-

RE: [PATCH] dma/dpaa2: fix logtype register

> -Original Message- > From: David Marchand > Sent: Monday, December 18, 2023 9:17 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Gagandeep Singh ; Hemant Agrawal > ; Nipun Gupta > Subject: [PATCH] dma/dpaa2: fix logtype register > Importance: High > > This driver logtype was not initial

Re: [PATCH 1/2] baseband/acc: fix logtypes register

On Mon, 18 Dec 2023 16:43:06 +0100 David Marchand wrote: > This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that > all logs for both acc100 and vrb drivers would be emitted for > pmd.baseband.acc logtype. > > It seems the intent was to have dedicated logtypes per driver, so >

Re: [PATCH] dma/dpaa2: fix logtype register

On Mon, 18 Dec 2023 16:46:39 +0100 David Marchand wrote: > This driver logtype was not initialized so its logs would end up under > the 0 logtype, iow, RTE_LOGTYPE_EAL. > This issue comes from a typo on the logtype variable name. > > Fixes: 8caf8427f85a ("dma/dpaa2: introduce driver skeleton") >

Re: [PATCH] bus/ifpga: remove dead code

On Mon, Dec 18, 2023 at 04:45:26PM +0100, David Marchand wrote: > This macro was never used. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > > Signed-off-by: David Marchand > --- > drivers/bus/ifpga/ifpga_logs.h | 4 > 1 file changed, 4 deletions(-) > Acked-by: Bruce R

[PATCH] dma/dpaa2: fix logtype register

This driver logtype was not initialized so its logs would end up under the 0 logtype, iow, RTE_LOGTYPE_EAL. This issue comes from a typo on the logtype variable name. Fixes: 8caf8427f85a ("dma/dpaa2: introduce driver skeleton") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/dma/d

[PATCH] bus/ifpga: remove dead code

This macro was never used. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Signed-off-by: David Marchand --- drivers/bus/ifpga/ifpga_logs.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h index 873e0a4f2f..248b

[PATCH 2/2] baseband/acc: fix common logs

Logs generated by helpers common to acc100 and vrb drivers were emitted with a RTE_LOG_NOTICE == 6 == RTE_LOGTYPE_HASH. Register a dedicated logtype for this. Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") Signed-off-by: David Marchand --- drivers/baseband/acc/acc_co

[PATCH 1/2] baseband/acc: fix logtypes register

This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that all logs for both acc100 and vrb drivers would be emitted for pmd.baseband.acc logtype. It seems the intent was to have dedicated logtypes per driver, so register one for each with a suffix. Fixes: c2d93488c7c3 ("baseband/a

[PATCH] common/qat: make qat common code independent from services

QAT common code should not depend on specific services, to the contrary, it should be used by the specific services. This commit decuples services (sym, asym, comp) from the common code. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_device.c | 183 +++---

[PATCH 2/2] common/qat: add vqat confiuration macros

This commit adds vqat (virtual QAT device) configuration macros to the Intel QuickAssist Technology PMD. Signed-off-by: Arkadiusz Kusztal --- .../qat/qat_adf/adf_transport_access_macros_vqat.h | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 drivers/common/qat/q

[PATCH 1/2] common/qat: add vqat definition to pmd map

This commit adds vqat (virtual QAT device) to PMD PCI ID map. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_common.h | 1 + drivers/common/qat/qat_device.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/common/qat/qat_common.h b/drivers/common/qat/qat_common.h index

[PATCH v4 00/14] Detect superfluous newline in logs

Getting readable and consistent logs is important when running a DPDK application, especially when troubleshooting. A common issue with logs is when a DPDK change do not add (or on the contrary add too many \n) in the format string. This issue would only get noticed when actually hitting this log

[PATCH v4 14/14] lib: use per line logging in helpers

Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand Reviewed-by: Chengwen Feng Reviewed-by: Andrew Rybchenko --- Changes since v3: - fixed some checkpatch complaints, Changes since RFC v1: - converted all logging helpers in lib/, --- lib/bbdev/rte_bbdev.c

[PATCH v4 11/14] log: add a per line log helper

gcc builtin __builtin_strchr can be used as a static assertion to check whether passed format strings contain a \n. This can be useful to detect double \n in log messages. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- Changes since v3: - fixed some checkp

[PATCH v4 10/14] vhost: improve log for memory dumping configuration

Add the device name as a prefix of logs associated to madvise() calls. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- lib/vhost/iotlb.c | 18 +- lib/vhost/vhost.h | 2 +- lib/vhost/vhost_user.c | 26 +- 3 files changed, 23 insert

[PATCH v4 08/14] lib: simplify multilines log messages

Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff Reviewed-by: Andrew Rybchenko --- Changes since RFC v2: - fixed format string crossing line boundaries, --- lib/acl/tb_mem.c| 4 ++-- lib/bpf/bpf_stub.c

[PATCH v4 09/14] rcu: introduce a logging helper

Add a simple helper for logging messages in this library. Signed-off-by: David Marchand Reviewed-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli Reviewed-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 62 -- lib/rcu/rte_rcu_qsbr.h | 1 + 2 fil

[PATCH v4 02/14] regexdev: fix logtype register

This library logtype was not initialized so its logs would end up under the 0 logtype, iow, RTE_LOGTYPE_EAL. Fixes: b25246beaefc ("regexdev: add core functions") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff Acked-by: Ori Kam ---

[PATCH v4 05/14] lib: remove redundant newline from logs

Fix places where two newline characters may be logged. Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Stephen Hemminger Reviewed-by: Chengwen Feng Acked-by: Mattias Rönnblom --- Changes since RFC v1: - split fixes on direct calls to printf or RTE_LOG in a previous patch, --- dr

[PATCH v4 07/14] bpf: remove log level in internal helper

There is no other log level than debug, simplify this helper. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/bpf/bpf_validate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_valida

[PATCH v4 03/14] lib: use dedicated logtypes and macros

No printf! When a dedicated log helper exists, use it. And no usurpation please: a library should log under its logtype (see the eventdev rx adapter update for example). Note: the RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET macro is renamed for consistency with the rest of eventdev (private) macros. Cc:

[PATCH v4 04/14] lib: add newline in logs

Fix places leading to a log message not terminated with a newline. Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff Reviewed-by: Andrew Rybchenko --- lib/eal/common/eal_common_options.c | 2 +- lib/eal/linux/eal_hugepage_info.c | 2

[PATCH v4 06/14] eal/linux: remove log paraphrasing the doc

An error log message does not need to paraphrase the DPDK documentation. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/linux/eal_timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/eal/linux/eal_timer.c b/lib/eal

[PATCH v4 01/14] hash: remove some dead code

This macro is not used. Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.h | 11 --- 1 file changed, 11 deletions(-) diff --git a

Re: [PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD

On Wed, Dec 13, 2023 at 4:09 PM Stephen Hemminger wrote: > > On Wed, 13 Dec 2023 09:00:48 +0100 > David Marchand wrote: > > > On Wed, Dec 13, 2023 at 5:19 AM Stephen Hemminger > > wrote: > > > > > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > > > As a first step, fix many

[PATCH] drivers: use dedicated logtypes

When a driver dedicated logtype exists, use it instead of the generic PMD logtype. This has been done partially automatically with: $ for file in $(git grep -l RTE_LOG.*PMD.*fmt drivers/'**.h' \ :^drivers/common/cnxk/roc_platform.h) do tail=${file#drivers/*/*/} dir=${file%%$tail} ! git gr

RE: [EXT] Re: [PATCH] lib/dmadev: get DMA device using device ID

Hi Bruce, Thanks for the review and feedback. Please find my reply in-line. Thanks, Amit Shukla > -Original Message- > From: Bruce Richardson > Sent: Monday, December 11, 2023 3:54 PM > To: Amit Prakash Shukla > Cc: Chengwen Feng ; Kevin Laatz > ; dev@dpdk.org; Jerin Jacob Kollanukkara

RE: [EXT] [PATCH v3] examples/packet_ordering: fix segfault in disable_reorder mode

> -Original Message- > From: Qian Hao > Sent: Wednesday, December 13, 2023 12:07 PM > To: dev@dpdk.org > Cc: Volodymyr Fialko > Subject: [EXT] [PATCH v3] examples/packet_ordering: fix segfault in > disable_reorder mode > > External Email > >

RE: [PATCH v5 3/3] app/graph: implement port forward usecase

> -Original Message- > From: Rakesh Kudurumalla > Sent: Friday, December 15, 2023 2:46 PM > To: Sunil Kumar Kori ; Rakesh Kudurumalla > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram > Subject: [PATCH v5 3/3] app/graph: implement port forward usecase > > Added

RE: [PATCH v5 2/3] app/graph: add ethdev forward command

> -Original Message- > From: Rakesh Kudurumalla > Sent: Friday, December 15, 2023 2:46 PM > To: Sunil Kumar Kori ; Rakesh Kudurumalla > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram > Subject: [PATCH v5 2/3] app/graph: add ethdev forward command > > Adds a tx

RE: [EXT] Re: [PATCH] lib/dmadev: get DMA device using device ID

Hi Chengwen, Thanks for the review and feedback. I will send the next version with suggested changes. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Saturday, December 9, 2023 12:42 PM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richardson > Cc: dev@dpdk.o

RE: [EXT] [PATCH v5 1/3] node: support to add next node to ethdev Rx node

Overall patch looks okay. Just a minor comments. Regards Sunil Kumar Kori > -Original Message- > From: Rakesh Kudurumalla > Sent: Friday, December 15, 2023 2:46 PM > To: Nithin Kumar Dabilpuram ; Pavan > Nikhilesh Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > Rakesh Ku

Re: [PATCH v3 08/14] lib: simplify multilines log messages

On 12/18/23 12:27, David Marchand wrote: Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff Reviewed-by: Andrew Rybchenko

Re: [RFC v2 09/14] rcu: introduce a logging helper

On Tue, Dec 12, 2023 at 8:11 PM Tyler Retzlaff wrote: > On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > > On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff > > wrote: > > > > > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > > > Signed-off-by: David Marchand

[PATCH v3 11/14] log: add a per line log helper

gcc builtin __builtin_strchr can be used as a static assertion to check whether passed format strings contain a \n. This can be useful to detect double \n in log messages. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- Changes since RFC v1: - added a check

[PATCH v3 14/14] lib: use per line logging in helpers

Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand Reviewed-by: Chengwen Feng Reviewed-by: Andrew Rybchenko --- Changes since RFC v1: - converted all logging helpers in lib/, --- lib/bbdev/rte_bbdev.c | 5 +++-- lib/bpf/bpf_impl.h

[PATCH v3 10/14] vhost: improve log for memory dumping configuration

Add the device name as a prefix of logs associated to madvise() calls. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- lib/vhost/iotlb.c | 18 +- lib/vhost/vhost.h | 2 +- lib/vhost/vhost_user.c | 26 +- 3 files changed, 23 insert

[PATCH v3 09/14] rcu: introduce a logging helper

Add a simple helper for logging messages in this library. Signed-off-by: David Marchand Reviewed-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli Reviewed-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 62 -- lib/rcu/rte_rcu_qsbr.h | 1 + 2 fil

[PATCH v3 08/14] lib: simplify multilines log messages

Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff --- Changes since RFC v2: - fixed format string crossing line boundaries, --- lib/acl/tb_mem.c| 4 ++-- lib/bpf/bpf_stub.c | 6 ++ lib/eal/wi

[PATCH v3 07/14] bpf: remove log level in internal helper

There is no other log level than debug, simplify this helper. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/bpf/bpf_validate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_valida

[PATCH v3 06/14] eal/linux: remove log paraphrasing the doc

An error log message does not need to paraphrase the DPDK documentation. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/linux/eal_timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/eal/linux/eal_timer.c b/lib/eal

[PATCH v3 05/14] lib: remove redundant newline from logs

Fix places where two newline characters may be logged. Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Stephen Hemminger Reviewed-by: Chengwen Feng Acked-by: Mattias Rönnblom --- Changes since RFC v1: - split fixes on direct calls to printf or RTE_LOG in a previous patch, --- dr

  1   2   >