Re: [PATCH v2 00/14] support new 5760X P7 devices

On Wed, Dec 13, 2023 at 6:34 AM Ajit Khaparde wrote: > > On Sat, Dec 9, 2023 at 5:31 PM Ajit Khaparde > wrote: > > > > While some of the patches refactor and improve existing code, > > this series adds support for the new 5760X P7 device family. > > Follow-on patches will incrementally add more

RE: [PATCH v4] lib/net: fix tcp/udp cksum with padding data

> From: Kaiwen Deng [mailto:kaiwenx.d...@intel.com] > Sent: Wednesday, 13 December 2023 05.38 > > IEEE 802 packets may have a minimum size limit. The data fields > should be padded when necessary. In some cases, the padding data > is not zero. > > In 'rte_ipv4_udptcp_cksum_mbuf()', as payload len

Re: [PATCH v2 00/14] support new 5760X P7 devices

On Sat, Dec 9, 2023 at 5:31 PM Ajit Khaparde wrote: > > While some of the patches refactor and improve existing code, > this series adds support for the new 5760X P7 device family. > Follow-on patches will incrementally add more functionality. > > v1->v2: > - Fixed unused variable error > - Fixed

[PATCH v4] lib/net: fix tcp/udp cksum with padding data

IEEE 802 packets may have a minimum size limit. The data fields should be padded when necessary. In some cases, the padding data is not zero. In 'rte_ipv4_udptcp_cksum_mbuf()', as payload length "mbuf->pkt_len - l4_off" is used, which includes padding and if padding is not zero it will end up prod

DPDK Tech Board Meeting Reminder - Tomorrow, Wed. Dec. 13th, 2023 - 7am Pacific/10am Eastern/1500h UTC

Good evening DPDK Community, This is a reminder that tomorrow, 13 December 2023, the DPDK Tech Board meets at 7am Pacific/10am Eastern/1500h UTC. A read-only agenda can be found here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db

[PATCH v2 25/25] mempool/dpaa, mempool/dpaa2: do not use logtype PMD

The driver already has a logtype, just not consistently used. Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa/dpaa_mempool.h | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 2 +- 3 files changed, 4 insertions(+),

[PATCH v2 24/25] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/dma/dpaa/dpaa_qdma_logs.h | 5 +++-- drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma_logs.h b/drivers/dma/dpaa/dpaa_qdma_l

[PATCH v2 23/25] bus/fslmc: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index a1e14dd84e9a..edd74af04d7c 100644 --- a/drivers/bus

[PATCH v2 22/25] bus/cdx: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/cdx/cdx_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h index a1046ce544a6..e432fae00e4d 100644 --- a/drivers/bus/cdx/cdx_log

[PATCH v2 21/25] basband/la12xx: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h index

[PATCH v2 20/25] common/dpaax: do not use PMD logtype

Use existing dpaax_logger log type instead of PMD. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/compat.h | 5 - drivers/common/dpaax/dpaax_logs.h | 2 +- drivers/common/dpaax/version.map | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v2 19/25] common/sfc_efx: remove use of PMD logtype

This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v2 18/25] common/cpt: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_pmd_logs.h b/drivers/common/cpt/cpt_pmd_logs.h index 174326c6ce38..6b78fcb6b6fc 100644 --- a/d

[PATCH v2 17/25] common/cnxk: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index ba23b2e

[PATCH v2 16/25] net/vmxnet3: do not use PMD logtype

The driver used a slightly different (and older) format for datapath logs. Remove PMD logtype here. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- drivers/net/vmxnet3/vmxnet3_logs.h | 12 2 files changed, 9 insertions(+), 5 deletions(-) diff --

[PATCH v2 15/25] net/virtio: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_logs.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h index 9b1b1defc5a6..0447ee961fb6 1

[PATCH v2 14/25] net/qede: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 3187d97bb7b0..f7aa14df7e3b 100644 --- a/driver

[PATCH v2 13/25] net/pfe: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_logs.h | 3 +-- drivers/net/pfe/pfe_logs.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_logs.h b/drivers/net/octeontx/octeo

[PATCH v2 12/25] net/octeon_ep: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeon_ep/otx_ep_common.h | 7 +++ drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octe

[PATCH v2 11/25] net/mvpp2: do not use PMD logtype

The driver already has a logtype but it was not being used in one place. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrv

[PATCH v2 10/25] net/mana: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/mana/mana.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 6836872dc257..8d60f9172d44 100644 --- a/drivers/net/mana/mana.h +++ b/dr

[PATCH v2 09/25] net/igc: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Junfeng Guo --- drivers/net/igc/igc_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h index 11071a32b542..ffa1981bae32 10

[PATCH v2 08/25] net/enetc, net/enetfec: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/enetc/enetc_logs.h | 2 +- drivers/net/enetfec/enet_pmd_logs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h index

[PATCH v2 07/25] net/dpaa2: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_et

[PATCH v2 06/25] net/dpaa: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06d

[PATCH v2 05/25] net/bnxt: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h | 5 + drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- drivers/net/bnxt/bnxt_txr.c | 4 +--- 4 fi

[PATCH v2 04/25] net/avp: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_logs.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h index 6e297c7a4a81..0ae95a7685c5 100644 --- a/d

[PATCH v2 03/25] net/atlantic: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_logs.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h index e3dba334fe92..c2a3a6320c58 10064

[PATCH v2 02/25] log: add rte_log_dp()

Add a new macro for logging in datapath using a logtype. The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD) like RTE_LOG(). This macro allows using a dynamic type. Ideally, rte_log_dp() could be an always_inline function but GCC and Clang will not inline a function with variable numb

[PATCH v2 01/25] log: fix doc comment for RTE_LOG_DP()

The macro does not return a numeric status, only void. Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time") Signed-off-by: Stephen Hemminger --- lib/log/rte_log.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index 4d207b8da2cd..05

[PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD

The generic RTE_LOGTYPE_PMD is a leftover and should be removed. As a first step, fix many drivers to not use it, and add a helper for the RTE_LOG_DP(). Most of this patchset is boiler plate but there were some places where use of PMD type snuck in with changes to original driver and get fixed he

[PATCH 5/5] net/nfp: use ctrl extend to check the mode of features

Use the 'ctrl_extend' rather than 'cap_extend' to check the switch mode of features. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 4 +--- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 4 +--- drivers/net/nfp/nfp_ethdev.c | 5 +++-

[PATCH 4/5] net/nfp: use ctrl to check the mode of features

Use the 'ctrl' rather than 'cap' to check the switch mode of features. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 10 +- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 12 ++-- drivers/net/nfp/nfp_net_common.c | 2 +

[PATCH 3/5] net/nfp: modify the logic of set MAC address

Modify the logic of set MAC address, add the check logic of MAC address. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfp_net_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_

[PATCH 2/5] net/nfp: modify the logic of set promisc mode

Modify the logic of set promisc mode, add the check logic of capacity. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfp_net_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_ne

[PATCH 1/5] net/nfp: complete the logic of print capacity

Complete the logic of print capacity, print all the capacity and extend capacity. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfp_net_common.c | 59 ++-- 1 file changed, 41 insertions(+), 18 deletions(-) diff --git a/

[PATCH 0/5] unify the usage of capacity and control

This patch series aims to unify the usage of capacity and control, and revise the related logics. Chaoyong He (5): net/nfp: complete the logic of print capacity net/nfp: modify the logic of set promisc mode net/nfp: modify the logic of set MAC address net/nfp: use ctrl to check the mode of

Re: [PATCH 05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp

On Wed, Dec 13, 2023 at 7:14 AM Stephen Hemminger wrote: > > Want datapath logs to use own logtype. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnxt/bnxt.h | 5 + > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- > dr

RE: [PATCH 10/26] net/igc: replace RTE_LOG_DP with rte_log_dp

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, December 13, 2023 09:42 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Guo, Junfeng > ; Su, Simei > Subject: [PATCH 10/26] net/igc: replace RTE_LOG_DP with rte_log_dp > > Want datapath logs to use own logtype. > > Signed

[PATCH 26/26] mempool/dpaa, mempool/dpaa2: do not use logtype PMD

The driver already has a logtype, just not consistently used. Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa/dpaa_mempool.h | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 2 +- 3 files changed, 4 insertions(+),

[PATCH 25/26] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/dma/dpaa/dpaa_qdma_logs.h | 5 +++-- drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma_logs.h b/drivers/dma/dpaa/dpaa_qdma_l

[PATCH 24/26] bus/fslmc: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index a1e14dd84e9a..edd74af04d7c 100644 --- a/drivers/bus

[PATCH 23/26] bus/cdx: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/cdx/cdx_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h index a1046ce544a6..e432fae00e4d 100644 --- a/drivers/bus/cdx/cdx_log

[PATCH 22/26] basband/la12xx: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h index

[PATCH 21/26] common/dpaax: do not use PMD logtype

Use existing dpaax_logger log type instead of PMD. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/compat.h | 5 - drivers/common/dpaax/version.map | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/dpaax/caamflib/compat.h b/drivers/

[PATCH 20/26] common/sfc_efx: remove use of PMD logtype

This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH 19/26] common/cpt: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_pmd_logs.h b/drivers/common/cpt/cpt_pmd_logs.h index 174326c6ce38..6b78fcb6b6fc 100644 --- a/d

[PATCH 18/26] common/cnxk: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index ba23b2e

[PATCH 17/26] net/vmxnet3: do not use PMD logtype

The driver used a slightly different (and older) format for datapath logs. Remove PMD logtype here. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- drivers/net/vmxnet3/vmxnet3_logs.h | 12 2 files changed, 9 insertions(+), 5 deletions(-) diff --

[PATCH 16/26] net/virtio: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_logs.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h index 9b1b1defc5a6..0447ee961fb6 1

[PATCH 15/26] net/qede: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 3187d97bb7b0..097294be9c71 100644 --- a/driver

[PATCH 14/26] net/pfe: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_logs.h | 3 +-- drivers/net/pfe/pfe_logs.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_logs.h b/drivers/net/octeontx/octeo

[PATCH 13/26] net/octeon_ep: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeon_ep/otx_ep_common.h | 7 +++ drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octe

[PATCH 12/26] net/mvpp2: do not use PMD logtype

The driver already has a logtype but it was not being used in one place. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrv

[PATCH 11/26] net/mana: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/mana/mana.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 6836872dc257..8d60f9172d44 100644 --- a/drivers/net/mana/mana.h +++ b/dr

[PATCH 10/26] net/igc: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/igc/igc_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h index 11071a32b542..ffa1981bae32 100644 --- a/drivers/net/

[PATCH 09/26] net/enetfec: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/enetfec/enet_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enetfec/enet_pmd_logs.h b/drivers/net/enetfec/enet_pmd_logs.h index 72d1cb61c598..c0a226284c53 100644 -

[PATCH 08/26] net/enetc: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/enetc/enetc_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h index 0976d42debd7..05a540f16490 100644 --- a/drivers/net

[PATCH 07/26] net/dpaa2: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_et

[PATCH 05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt.h | 5 + drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- drivers/net/bnxt/bnxt_txr.c | 4 +--- 4 files changed, 8 insertions

[PATCH 06/26] net/dpaa: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06d

[PATCH 04/26] net/avp: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_logs.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h index 6e297c7a4a81..0ae95a7685c5 100644 --- a/d

[PATCH 03/26] net/atlantic: replace RTE_LOG_DP with rte_log_dp

Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_logs.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h index e3dba334fe92..c2a3a6320c58 10064

[PATCH 02/26] log: add rte_log_dp()

Add a new macro for logging in datapath using a logtype. The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD) like RTE_LOG(). This macro allows using a dynamic type. Ideally, rte_log_dp() could be an always_inline function but GCC and Clang will not inline a function with variable numb

[PATCH 01/26] log: fix doc comment for RTE_LOG_DP()

The macro does not return a numeric status, only void. Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time") Signed-off-by: Stephen Hemminger --- lib/log/rte_log.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index 4d207b8da2cd..05

[PATCH 00/26] Replace uses of RTE_LOGTYPE_PMD

The generic RTE_LOGTYPE_PMD is a leftover and should be removed. As a first step, fix many drivers to not use it, and add a helper for the RTE_LOG_DP(). Most of this patchset is boiler plate but there were some places where use of PMD type snuck in with changes to original driver and get fixed he

Re: [RFC v2 09/14] rcu: introduce a logging helper

On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff > wrote: > > > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > > Signed-off-by: David Marchand > > > --- > > > > Reviewed-by: Tyler Retzlaff > > > > > lib/rcu/r

Re: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

[AMD Official Use Only - General] Thank you Morten for the understanding From: Morten Brørup Sent: 12 December 2023 23:39 To: Varghese, Vipin ; Bruce Richardson Cc: Yigit, Ferruh ; dev@dpdk.org ; sta...@dpdk.org ; honest.ji...@foxmail.com ; P, Thiyagarajan Su

RE: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

From: Varghese, Vipin [mailto:vipin.vargh...@amd.com] Sent: Tuesday, 12 December 2023 18.14 Sharing a few critical points based on my exposure to the dma-perf application below On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote: > +TO: Bruce, please stop me if I'm completel

Re: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

[Public] Sharing a few critical points based on my exposure to the dma-perf application below On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote: > +TO: Bruce, please stop me if I'm completely off track here. > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Tuesday, 12 >

Re: [PATCH 1/5] app/test-pm: add multiprocess test

On Tue, 12 Dec 2023 06:25:12 +0200 Artemy Kovalyov wrote: > +rte_atomic32_t g_count; > + > +static int > +done(const struct rte_mp_msg *msg __rte_unused, const void *arg __rte_unused) > +{ > + rte_atomic32_dec(&g_count); > + return 0; > +} Local variable, should be static. Also, assert

[PATCH v2 1/1] app/graph: generate cmdline boilerplate

From: Sunil Kumar Kori Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the application. Signed-off-by: Sunil Kumar Kori Acked-by: Bruce Richardson --- v1..v2: - Rebase and remove Depends-On: tag as dependent series is applied

[PATCH v2] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type

With a little setup in eventdev_pmd.h the eventdev drivers and API can be converted to dynamic log type. Signed-off-by: Stephen Hemminger --- v2 - logtpe can be internal lib/eventdev/eventdev_pmd.h | 3 +++ lib/eventdev/rte_eventdev.c | 2 ++ lib/eventdev/version.map| 1 + lib/log/log.c

[PATCH] crytodev: make logtype internal

The logtype does not need to be exported as API. Fixes: be618b81545e ("cryptodev: convert to dynamic logtype") Signed-off-by: Stephen Hemminger --- lib/cryptodev/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map

[PATCH] cryptodev: remove unused extern

The variable rte_cyptodev_names is unused and misspelled. Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/crypt

Re: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote: > +TO: Bruce, please stop me if I'm completely off track here. > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Tuesday, 12 > > December 2023 15.38 > > > > On 12/12/2023 11:40 AM, Morten Brørup wrote: > > >> From: Vipin Va

[PATCH v1] crypto/ipsec_mb: unified IPsec MB interface

Currently IPsec MB provides both the JOB API and direct API. AESNI_MB PMD is using the JOB API codepath while ZUC, KASUMI, SNOW3G, CHACHA20_POLY1305 and AESNI_GCM are using the direct API. Instead of using the direct API for these PMDs, they should now make use of the JOB API codepath. This would r

Re: [PATCH 0/7] support link auto negotiation

On 12/11/2023 3:08 AM, Chaoyong He wrote: > This patch series add the support of link auto negotiation feature, > including speed and FEC mode. > > Zerun Fu (7): > net/nfp: set a new parameter to hwinfo > net/nfp: support getting speed capability > net/nfp: support setting port speed > net

Re: [PATCH v1] net/tap: fix buffer overflow for ptypes list

On 12/12/2023 2:37 PM, Sivaramakrishnan Venkat wrote: > Incorrect ptypes list causes buffer overflow for Address Sanitizer > run and a tap device. The last element in the ptypes lists to be > to "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(). > In rte_eth_dev_get_supported_ptypes(), the

RE: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

+TO: Bruce, please stop me if I'm completely off track here. > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Tuesday, 12 December 2023 15.38 > > On 12/12/2023 11:40 AM, Morten Brørup wrote: > >> From: Vipin Varghese [mailto:vipin.vargh...@amd.com] > >> Sent: Tuesday, 12 December 2023 1

Re: [RFC v2 09/14] rcu: introduce a logging helper

On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff wrote: > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > Signed-off-by: David Marchand > > --- > > Reviewed-by: Tyler Retzlaff > > > lib/rcu/rte_rcu_qsbr.c | 62 -- > > lib/rcu/rte_rcu_q

Re: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

On 12/12/2023 11:40 AM, Morten Brørup wrote: >> From: Vipin Varghese [mailto:vipin.vargh...@amd.com] >> Sent: Tuesday, 12 December 2023 11.38 >> >> Replace pktmbuf pool with mempool, this allows increase in MOPS >> especially in lower buffer size. Using Mempool, allows to reduce >> the extra CPU cy

[PATCH v1] net/tap: fix buffer overflow for ptypes list

Incorrect ptypes list causes buffer overflow for Address Sanitizer run and a tap device. The last element in the ptypes lists to be to "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(). In rte_eth_dev_get_supported_ptypes(), the loop iterates until it finds "RTE_PTYPE_UNKNOWN" to detect la

RE: [v3] net/af_xdp: enable uds-path instead of use_cni

Thank you Maryam updating the document. I have added some comment below. Also what do you think about changing the name of the document file "af_xdp_cni.rst" to "af_xdp_dp.rst" ? Regards, Shibin > -Original Message- > From: Maryam Tahhan > Sent: Monday, December 11, 2023 2:39 PM > To:

DPDK Release Status Meeting 2023-12-07

Release status meeting minutes 2023-12-07 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current working

Re: [PATCH] cryptodev: convert to dynamic logtype

On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger wrote: > > The cryptodev logs are all referenced via rte_crytpodev.h > so make it dynamic there. > > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH 24.03 v2 2/9] eventdev: increase flexibility of all-types flag

On Tue, Dec 12, 2023 at 4:58 PM Bruce Richardson wrote: > > On Thu, Nov 23, 2023 at 09:37:58AM +0530, Jerin Jacob wrote: > > On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson > > wrote: > > > > > > Rather than requiring that any device advertising the > > > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag s

DPDK 20.11.10 released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.11.10.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=20.11 This is the final release of the 20.11 LTS branch, and it is now EOL. So long, and thanks for all the packets. Luca Boccassi ---

RE: [RFC] ethdev: introduce entropy calculation

> Subject: [RFC] ethdev: introduce entropy calculation > > When offloading rules with the encap action, the HW may calculate entropy > based on the encap protocol. > Each HW can implement a different algorithm. > > When the application receives packets that should have been encaped by the > HW, b

Re: [PATCH 3/3] examples/vm_power_manager: do not use EAL logtype

Acked-by: Huisong Li 在 2023/12/12 1:23, Stephen Hemminger 写道: Be consistent for all the error printouts and use fprintf(). The EAL logtype is reserved for internal use by EAL. Signed-off-by: Stephen Hemminger --- examples/vm_power_manager/main.c | 11 --- 1 file changed, 4 insertio

Re: [PATCH 2/3] examples/l2fwd-keepalive: don't use EAL logtype

Acked-by: Huisong Li 在 2023/12/12 1:23, Stephen Hemminger 写道: EAL logtype should be reserved for EAL library. This example is already using printf() so just print errors to stderr. Signed-off-by: Stephen Hemminger --- examples/l2fwd-keepalive/shm.c | 21 +++-- 1 file change

Re: [PATCH 1/3] testpmd: replace EAL logtype with fprintf

With belows to changes, Acked-by: Huisong Li 在 2023/12/12 1:23, Stephen Hemminger 写道: Testpmd is misusing EAL logtype for its own errors. Since the code directly calls fprintf in other places, change to use that everywhere. This has the added benefit of not having testpmd output clutter up sysl

RE: [PATCH] app/dma-perf: replace pktmbuf with mempool objects

> From: Vipin Varghese [mailto:vipin.vargh...@amd.com] > Sent: Tuesday, 12 December 2023 11.38 > > Replace pktmbuf pool with mempool, this allows increase in MOPS > especially in lower buffer size. Using Mempool, allows to reduce > the extra CPU cycles. I get the point of this change: It tests th

Re: [PATCH v2 1/5] vhost: fix virtqueue access check in datapath

On 12/5/23 10:45, David Marchand wrote: Now that a r/w lock is used, the access_ok field should only be updated under a write lock. Since the datapath code only takes a read lock on the virtqueue to check access_ok, this lock must be released and a write lock taken before calling vring_transl

[PATCH v3 9/9] event/sw: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/sw.ini | 3 +++ drivers/event/sw/sw_evdev.c | 3 +++ 2 files changed, 6 insertions(+) d

[PATCH v3 8/9] event/opdl: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/opdl.ini | 3 +++ drivers/event/opdl/opdl_evdev.c| 3 +++ 2 files changed, 6 insertions(+

[PATCH v3 7/9] event/octeontx: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/octeontx.ini | 3 +++ drivers/event/octeontx/ssovf_evdev.c | 3 +++ 2 files changed, 6 inse

[PATCH v3 6/9] event/dsw: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/dsw.ini | 2 ++ drivers/event/dsw/dsw_evdev.c | 2 ++ 2 files changed, 4 insertions(+) d

[PATCH v3 5/9] event/dpaa*: add schedule-type capability flags

Document explicitly the scheduling types supported by these drivers, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson Acked-by: Hemant Agrawal --- doc/guides/eventdevs/features/dpaa.ini | 2 ++ doc/guides/eventdevs/features/dpaa2.ini | 2 ++ dri

[PATCH v3 4/9] event/dlb2: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson Acked-by: Abdullah Sevincer --- doc/guides/eventdevs/features/dlb2.ini | 3 +++ drivers/event/dlb2/dlb2.c | 5 -

  1   2   >