[PATCH v5 5/5] net/mvneta: fix possible out-of-bounds write

2023-11-05 Thread Chengwen Feng
The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit --- driver

[PATCH v5 1/5] kvargs: add one new process API

2023-11-05 Thread Chengwen Feng
The rte_kvargs_process() was used to handle key=value (e.g. socket_id=0), it also supports to handle only-key (e.g. socket_id). But many drivers's callback can only handle key=value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified to

[PATCH v5 0/5] fix segment fault when parse args

2023-11-05 Thread Chengwen Feng
The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), it also supports to parse only-key (e.g. socket_id). But many drivers's callback can only handle key-value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified too

[PATCH v5 3/5] net/tap: use new API to parse kvargs

2023-11-05 Thread Chengwen Feng
Some kvargs could be key=value or only-key, it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to handle these kvargs. Signed-off-by: Chengwen Feng --- drivers/net/tap/rte_eth_tap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/tap

[PATCH v5 4/5] common/nfp: use new API to parse kvargs

2023-11-05 Thread Chengwen Feng
The nfp_parse_class_options() function could handle both key=value and only-key, so it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/nfp/nfp_common_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

[PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-05 Thread Chengwen Feng
The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.c | 4 ++-- drivers/net/sfc/sfc_kvargs.c

Re: [PATCH 01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data

2023-11-05 Thread Etelson, Gregory
On Sun, 5 Nov 2023, Thomas Monjalon wrote: External email: Use caution opening links or attachments The description of this patch does not match the change. Also the change is going backward, using deprecated fields. It does not make sense, I'll skip it. Hello Thomas, Patches in that s

Re: [PATCH v4 4/5] common/nfp: use new API to parse kvargs

2023-11-05 Thread fengchengwen
Hi Stephen, On 2023/11/6 11:19, Stephen Hemminger wrote: > On Sun, 5 Nov 2023 05:45:38 + > Chengwen Feng wrote: > >> if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) { >> -rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS, >> -nfp_kvarg_de

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-05 Thread fengchengwen
Hi Stephen, On 2023/11/6 11:18, Stephen Hemminger wrote: > On Sun, 5 Nov 2023 05:45:35 + > Chengwen Feng wrote: > >> +* **Updated kvargs process API.** >> + >> + * Introduced rte_kvargs_process_opt() API, which inherits the function >> +of rte_kvargs_process() and could handle both key=

Re: [PATCH v3 3/3] test/dma: add SG copy tests

2023-11-05 Thread fengchengwen
Hi Gowrishankar, On 2023/11/3 23:38, Gowrishankar Muthukrishnan wrote: > Add scatter-gather copy tests. > > Signed-off-by: Vidya Sagar Velumuri > Signed-off-by: Gowrishankar Muthukrishnan > --- > app/test/test_dmadev.c | 132 +- > app/test/test_dmadev_api.c | 16

Re: configuration of memseg lists number

2023-11-05 Thread kefu chai
On Sun, Nov 5, 2023 at 5:56 PM Avi Kivity wrote: > Thanks, it makes sense. I'll get around to it "eventually". > > On Thu, 2023-11-02 at 11:04 +0100, Thomas Monjalon wrote: > > Hello, > > While looking at Seastar, I see it uses this patch on top of DPDK: > > build: add meson options of ma

RE: [EXT] Re: [PATCH v4 1/1] build: add libarchive to external deps

2023-11-05 Thread Srikanth Yalavarthi
> -Original Message- > From: Bruce Richardson > Sent: 03 November 2023 22:21 > To: Srikanth Yalavarthi > Cc: David Marchand ; Aaron Conole > ; Igor Russkikh ; > dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; sta...@dpdk.org > Subject: [EXT] Re: [PATCH

Re: [PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

2023-11-05 Thread lihuisong (C)
在 2023/11/3 18:42, Ferruh Yigit 写道: On 11/3/2023 9:09 AM, lihuisong (C) wrote: Hi Ferruh, Thanks for you review. 在 2023/11/3 9:31, Ferruh Yigit 写道: On 8/2/2023 3:55 AM, Huisong Li wrote: The command "tso set " is used to enable UFO, please see commit ce8e6e742807 ("app/testpmd: support U

[PATCH v5 1/1] build: add libarchive to external deps

2023-11-05 Thread Srikanth Yalavarthi
In order to avoid linking with Libs.private, libarchive is not added to ext_deps during the meson setup stage. Since libarchive is not added to ext_deps, cross-compilation or native compilation with libarchive installed in non-standard location fails with errors related to "cannot find -larchive"

Re: [PATCH v3 2/3] test/dma: test vchan reconfiguration

2023-11-05 Thread fengchengwen
Hi Gowrishankar, On 2023/11/3 23:38, Gowrishankar Muthukrishnan wrote: > Reconfigure vchan count and validate if new count is effective. I think it mainly due to multi-vchan, should point it out, suggest be: support API with multiple vchan test Thanks Chengwen > > Signed-off-by: Gowrishankar

Re: [PATCH v3 1/3] test/dma: use unit test framework

2023-11-05 Thread fengchengwen
Hi Gowrishankar, Thanks for your works. On 2023/11/3 23:38, Gowrishankar Muthukrishnan wrote: > Use unit test framework to execute DMA tests. > > Signed-off-by: Gowrishankar Muthukrishnan > Suggested-by: Chengwen Feng > --- > app/test/test_dmadev.c | 240

[Bug 1236] [dpdk-23.07]VM crash when start dpdk-l3fwd-power in VM with QEMU-8.0.0

2023-11-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1236 linglix.c...@intel.com changed: What|Removed |Added Resolution|--- |FIXED CC|

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-05 Thread Stephen Hemminger
On Sun, 5 Nov 2023 05:45:35 + Chengwen Feng wrote: > +* **Updated kvargs process API.** > + > + * Introduced rte_kvargs_process_opt() API, which inherits the function > +of rte_kvargs_process() and could handle both key=value and only-key > +cases. > + > + * Constraint rte_kvargs_pr

RE: [PATCH v4] net/cpfl: support action prog

2023-11-05 Thread Zhang, Qi Z
> -Original Message- > From: Qiao, Wenjing > Sent: Thursday, November 2, 2023 4:51 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Qiao, Wenjing > Subject: [PATCH v4] net/cpfl: support action prog > > From: Wenjing Qiao > > Parse JSON file and generate r

RE: [PATCH v2] net/ice: fix Tx preparation

2023-11-05 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Thursday, November 2, 2023 2:41 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix Tx preparation > > Hi, > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursday, Novembe

RE: [PATCH] net/iavf: fix Tx preparation

2023-11-05 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Thursday, November 2, 2023 2:45 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: RE: [PATCH] net/iavf: fix Tx preparation > > Hi, > > > -Original Message- > > From: Qi Zhang > >

Re: [PATCH v2 0/7] fix race-condition of proactive error handling mode

2023-11-05 Thread fengchengwen
Friendly ping. On 2023/10/20 18:07, Chengwen Feng wrote: > This patch fixes race-condition of proactive error handling mode, the > discussion thread [1]. > > [1] > http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ > > Chengwen Feng (7): > ethdev:

RE: [PATCH v4] net/ice: fix crash on closing representor ports

2023-11-05 Thread Zhang, Qi Z
> -Original Message- > From: Ye, MingjinX > Sent: Thursday, November 2, 2023 6:11 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Zhang, Qi Z > Subject: [PATCH v4] net/ice: fix crash on closing representor ports > > Since the representor

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

2023-11-05 Thread Chenbo Xia
Sorry I missed all previous versions… +ARM guy > On Nov 4, 2023, at 02:29, Abdullah Sevincer > wrote: > > External email: Use caution opening links or attachments > > > This commit implements an internal api to enable and disable PASID for > a device e.g. device driver event/dlb2. > > For k

Re: [PATCH v2] test/dma: fix for buffer auto free

2023-11-05 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/11/4 2:30, Amit Prakash Shukla wrote: > Buffer auto free test failed for more than 1 dma device as the device > initialization for the test was been done only for the first dma > device. This changeset fixes the same and also fixes the freeing of > the uninitialise

[PATCH] doc: add prog action into default ini

2023-11-05 Thread Qi Zhang
Added prog action into nic feature default.ini. Fixes: 8f1953f1914d ("ethdev: add flow API for P4-programmable devices") Signed-off-by: Qi Zhang --- doc/guides/nics/features/default.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/f

[PATCH] doc: add prog action into default ini

2023-11-05 Thread Qi Zhang
Added prog action into nic feature default.ini. Fixes: 8f1953f1914d ("ethdev: add flow API for P4-programmable devices") Signed-off-by: Qi Zhang --- doc/guides/nics/features/default.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/f

[PATCH] doc: add prog action into default ini

2023-11-05 Thread Qi Zhang
Added prog action into nic feature default.ini. Fixes: 8f1953f1914d ("ethdev: add flow API for P4-programmable devices") Signed-off-by: Qi Zhang --- doc/guides/nics/features/default.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/f

Re: [PATCH 04/30] net/mlx5: add rte_device parameter to locate HWS registers

2023-11-05 Thread Thomas Monjalon
29/10/2023 17:31, Gregory Etelson: > 1. Add rte_eth_dev parameter to the `flow_hw_get_reg_id()` > > 2. Add mlx5_flow_hw_get_reg_id() > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > --- This, > -static void > +void > flow_rxq_mark_flag_set(struct rte_eth_dev *dev) > { and this, >

Re: [PATCH 01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data

2023-11-05 Thread Thomas Monjalon
The description of this patch does not match the change. Also the change is going backward, using deprecated fields. It does not make sense, I'll skip it. 29/10/2023 17:31, Gregory Etelson: > New mlx5dr_context member replaces mlx5dr_cmd_query_caps. > Capabilities structure is a member of mlx5dr_