Re: [PATCH v4 2/3] app/testpmd: add maximum Rx buffer size display

2023-11-02 Thread lihuisong (C)
在 2023/11/3 11:53, Ferruh Yigit 写道: On 11/3/2023 2:39 AM, lihuisong (C) wrote: 在 2023/11/3 0:42, Ferruh Yigit 写道: On 11/2/2023 12:16 PM, Huisong Li wrote: Add maximum Rx buffer size display. I think there is a value to show what is the intended usage of this new field in application level,

Re: [PATCH v4 1/3] ethdev: introduce maximum Rx buffer size

2023-11-02 Thread lihuisong (C)
在 2023/11/3 11:30, Ferruh Yigit 写道: On 11/3/2023 2:21 AM, lihuisong (C) wrote: 在 2023/11/3 0:35, Ferruh Yigit 写道: On 11/2/2023 12:16 PM, Huisong Li wrote: The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also

[PATCH 11/11] net/nfp: support QUEUE flow action

2023-11-02 Thread Chaoyong He
Add the corresponding logics to support the offload of QUEUE action. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/n

[PATCH 10/11] drivers: support MARK flow action

2023-11-02 Thread Chaoyong He
Add the corresponding logics to support the offload of MARK action. Also add the related logics to parse the mark id and put into the mbuf structure, and assigned the offload flags. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h

[PATCH 09/11] net/nfp: support TCP/UDP/SCTP flow items

2023-11-02 Thread Chaoyong He
Add the corresponding logics to support the offload of TCP/UDP/SCTP items. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/drivers/net/nfp/nfp_net_

[PATCH 08/11] net/nfp: support IPv6 flow item

2023-11-02 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv6 item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 61 +++ drivers/net/nfp/nfp_net_flow.c | 66 +++

[PATCH 07/11] net/nfp: support IPv4 flow item

2023-11-02 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv4 item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 37 ++ drivers/net/nfp/nfp_net_flow.c | 58 --

[PATCH 06/11] net/nfp: support drop flow action

2023-11-02 Thread Chaoyong He
Add the corresponding logics to support the offload of drop action. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 39 +- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/

[PATCH 05/11] net/nfp: support Ethernet flow item

2023-11-02 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of ethernet item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 13 +++ drivers/net/nfp/nfp_net_flow.c | 169 + 2 files change

[PATCH 04/11] net/nfp: support flow API for CoreNIC firmware

2023-11-02 Thread Chaoyong He
Add the flow validate/create/destroy/flush API of nfp PMD with CoreNIC firmware. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow destroy API construct a control cmsg and send it to firmware, then delete this flow from the hash t

[PATCH 02/11] drivers: add the structures and functions for flow offload

2023-11-02 Thread Chaoyong He
Add the structures and functions to process flow table, which is used in the rte_flow offload logics. This module is used for the CoreNIC firmware. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/net/nfp/meson.bu

[PATCH 03/11] net/nfp: add the control message channel

2023-11-02 Thread Chaoyong He
Using the mailbox, which serves as the control message channel between driver and CoreNIC firmware. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build| 1 + drivers/net/nfp/nfp_net_cmsg.c | 66 ++ drivers

[PATCH 01/11] net/nfp: move some source files

2023-11-02 Thread Chaoyong He
Rename module 'nfp_flow' into 'nfp_flower_flow' and move the source files into the 'flower' sub-directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_conntrack.h | 2 +- drivers/net/nfp/flower/nfp_flower_cmsg.h

[PATCH 00/11] Add basic flow support for corenic firmware

2023-11-02 Thread Chaoyong He
Add the very basic rte_flow support for corenic firmware. Chaoyong He (11): net/nfp: move some source files drivers: add the structures and functions for flow offload net/nfp: add the control message channel net/nfp: support flow API for CoreNIC firmware net/nfp: support Ethernet flow it

[PATCH] net/nfp: add quick exit logic for parse packet type

2023-11-02 Thread Chaoyong He
Add quick exit logic for parse packet type function, when the control switch for this feature is off, the function can return quickly. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 11 +-- 1 file changed, 9 insertions(+), 2 del

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-02 Thread Ferruh Yigit
On 11/3/2023 2:49 AM, Deng, KaiwenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, November 3, 2023 3:20 AM >> To: Deng, KaiwenX ; dev@dpdk.org >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Singh, Aman Deep ; >> Zhang, Yuying ; Matz, Olivier >> ; De L

[PATCH v3 7/7] Section 6: Glossary

2023-11-02 Thread David Young
--- doc/guides/getting_started_guide/glossary.rst | 75 +++ 1 file changed, 75 insertions(+) create mode 100644 doc/guides/getting_started_guide/glossary.rst diff --git a/doc/guides/getting_started_guide/glossary.rst b/doc/guides/getting_started_guide/glossary.rst new file mode

[PATCH v3 6/7] Added link to Getting Started Guide in index.rst

2023-11-02 Thread David Young
--- doc/guides/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/index.rst b/doc/guides/index.rst index 244b99624c..51a47d3a51 100644 --- a/doc/guides/index.rst +++ b/doc/guides/index.rst @@ -7,6 +7,7 @@ DPDK documentation .. toctree:: :maxdepth: 1 + getting_started

[PATCH v3 5/7] Section 5: Appendix

2023-11-02 Thread David Young
--- .../appendix/cross_compile_dpdk.rst | 37 +++ .../appendix/dpdk_meson_build_options.rst | 57 .../getting_started_guide/appendix/index.rst | 17 + .../running_dpdk_apps_without_root.rst| 36 +++ .../appendix/vfio_advanced.rst| 295 +++

[PATCH v3 3/7] Section 3: Setting up a System to Run DPDK Applications

2023-11-02 Thread David Young
--- .../getting_started_guide/system_setup.rst| 195 ++ 1 file changed, 195 insertions(+) create mode 100644 doc/guides/getting_started_guide/system_setup.rst diff --git a/doc/guides/getting_started_guide/system_setup.rst b/doc/guides/getting_started_guide/system_setup.rst n

[PATCH v3 4/7] Section 4: Running Applications

2023-11-02 Thread David Young
--- .../getting_started_guide/run_apps/index.rst | 10 ++ .../run_apps/run_apps.rst | 118 ++ 2 files changed, 128 insertions(+) create mode 100644 doc/guides/getting_started_guide/run_apps/index.rst create mode 100644 doc/guides/getting_started_guide/run_ap

[PATCH v3 2/7] Section 2: Install and Build DPDK

2023-11-02 Thread David Young
Section 2: Install and Build DPDK - Updated based on feedback; Merged windows_install_build.rst into building_from_sources.rst; Updated Meson 0.57.x to be required for Windows. --- .../building_from_sources.rst | 174 ++ .../install_and_build/index.rst

[PATCH v3 1/7] Section 1: Introduction

2023-11-02 Thread David Young
Edited copy to be simpler based on feedback. --- doc/guides/getting_started_guide/intro.rst | 13 + 1 file changed, 13 insertions(+) create mode 100644 doc/guides/getting_started_guide/intro.rst diff --git a/doc/guides/getting_started_guide/intro.rst b/doc/guides/getting_started_gui

[PATCH v3 0/7] docs: getting started guide consolidation

2023-11-02 Thread David Young
Updated based on latest v1 and v2 feedback. David Young (7): Section 1: Introduction Section 2: Install and Build DPDK Section 3: Setting up a System to Run DPDK Applications Section 4: Running Applications Section 5: Appendix Added link to Getting Started Guide in index.rst Section

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Ferruh Yigit
On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > Update the documentation and tools to build the BPF program used by > tap device. And apply fix to the RSS algorithm to correctly > handle non-IP protocols. > > v6 - cosmetic improvements to extract process > add better boilerplate and fix pyth

Re: [PATCH v4 2/3] app/testpmd: add maximum Rx buffer size display

2023-11-02 Thread Ferruh Yigit
On 11/3/2023 2:39 AM, lihuisong (C) wrote: > > 在 2023/11/3 0:42, Ferruh Yigit 写道: >> On 11/2/2023 12:16 PM, Huisong Li wrote: >>> Add maximum Rx buffer size display. >>> >> I think there is a value to show what is the intended usage of this new >> field in application level, >> that is why what do

Re: [PATCH v4 1/3] ethdev: introduce maximum Rx buffer size

2023-11-02 Thread Ferruh Yigit
On 11/3/2023 2:21 AM, lihuisong (C) wrote: > > 在 2023/11/3 0:35, Ferruh Yigit 写道: >> On 11/2/2023 12:16 PM, Huisong Li wrote: >>> The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum >>> Rx buffer size supported by hardware. Actually, some engines also have >>> the maximum Rx buf

[21.11 PATCH v1] net/mlx5: fix matcher layout size calculation

2023-11-02 Thread Rongwei Liu
Initially, the rdma-core library only supported misc0 to misc3 fields in matching resources, misc4 and misc5 fields were added to handle new features. The matcher layout, passing from DPDK to rdma-core, shouldn't exceed the size of the engaged library version capabilities. For now, there is no way

RE: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-02 Thread Deng, KaiwenX
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 3, 2023 3:20 AM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Singh, Aman Deep ; > Zhang, Yuying ; Matz, Olivier > ; De Lara Guarch, Pablo > > Subject: Re: [PATCH] app/test-pm

Re: [PATCH v4 2/3] app/testpmd: add maximum Rx buffer size display

2023-11-02 Thread lihuisong (C)
在 2023/11/3 0:42, Ferruh Yigit 写道: On 11/2/2023 12:16 PM, Huisong Li wrote: Add maximum Rx buffer size display. I think there is a value to show what is the intended usage of this new field in application level, that is why what do you think to use testpmd? Testpmd can be updated to check i

Re: [PATCH v4 1/3] ethdev: introduce maximum Rx buffer size

2023-11-02 Thread lihuisong (C)
在 2023/11/3 0:35, Ferruh Yigit 写道: On 11/2/2023 12:16 PM, Huisong Li wrote: The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf dat

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread lihuisong (C)
在 2023/11/3 0:51, Morten Brørup 写道: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 2 November 2023 17.24 On 11/2/2023 1:59 AM, lihuisong (C) wrote: 在 2023/11/2 0:08, Stephen Hemminger 写道: On Wed, 1 Nov 2023 10:36:07 +0800 "lihuisong (C)" wrote: Do we need to report this

Re: [PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

2023-11-02 Thread Ferruh Yigit
On 8/2/2023 3:55 AM, Huisong Li wrote: > The command "tso set " is used to enable UFO, please > see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine") > > The above patch configures the RTE_MBUF_F_TX_UDP_SEG to enable UFO only if > tso_segsz is set. > "The above patch sets the

RE: [PATCH 2/2] net/nfp: fix calloc parameters

2023-11-02 Thread Chaoyong He
> gcc [1] generates warning [2] about calloc usage, because calloc parameter > order is wrong, fixing it by replacing parameters. > > [1] > gcc (GCC) 14.0.0 20231102 (experimental) > > [2] > Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o > .../net/nfp/nfpco

Re: [PATCH] eal: add const to init function parameter

2023-11-02 Thread Konstantin Ananyev
02.11.2023 18:11, Bruce Richardson пишет: Change the parameter type of argv parameter to rte_eal_init from "char **" to "char * const *", since we don't modify the argv pointers passed in. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 2 +- lib/eal/common/eal_opti

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 10:17 PM, Thomas Monjalon wrote: > 02/11/2023 22:21, Ajit Khaparde: >> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: >>> On 6/25/2023 4:45 PM, Thomas Monjalon wrote: 23/06/2023 16:00, Ferruh Yigit: > On 2/3/2023 1:28 PM, Thomas Monjalon wrote: >> The option RTE_LIBRT

[PATCH v1] common/cnxk: fix aged flows bitmap alloc

2023-11-02 Thread Ankur Dwivedi
The allocation of bitmap for aged flows should be done in npc_aging_ctrl_thread_create() instead of roc_npc_init(), as the bitmap free is being done in npc_aging_ctrl_thread_destroy(). Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi --- d

[PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before free

2023-11-02 Thread Stephen Hemminger
Found with nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/openssl/rte_openssl_pmd.c | 36 +++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +- 2 files changed, 13 insertions(+), 26 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c

[PATCH 1/2] nullfree: add matches for null free cases from OpenSSL

2023-11-02 Thread Stephen Hemminger
OpenSSL functions follow the design parameter that free of NULL is ok. Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 9 + 1 file changed, 9 insertions(+) diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci index 9ca3fc2864..c58aad4fb7 100644

[PATCH 0/2] remove unnecessary null checks in OpenSSL usage

2023-11-02 Thread Stephen Hemminger
OpenSSL follows null free conventions Stephen Hemminger (2): nullfree: add matches for null free cases from OpenSSL crypto/openssl: remove unnecessary NULL checks before free devtools/cocci/nullfree.cocci| 9 + drivers/crypto/openssl/rte_openssl_pmd.c | 36 +++---

Re: [PATCH v2] crypto/openssl: fix memory leaks in asym ops

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 14:08:31 +0530 Gowrishankar Muthukrishnan wrote: > + if (pub_key) > + BN_free(pub_key); > + if (pkey) > + EVP_PKEY_free(pkey); > All these checks for null are unnecessary: EVP_PKEY_free() decrements the reference count of key and, if t

[PATCH v2] crypto/openssl: fix memory leaks in asym ops

2023-11-02 Thread Gowrishankar Muthukrishnan
Fix memory leaks in Asymmetric ops, as reported by valgrind. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - added more fixes. --- drivers/crypto/openssl/rte_openssl_pmd.c | 38 ++-- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 15 ++-- 2 files changed, 39 insertio

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Thomas Monjalon
02/11/2023 22:21, Ajit Khaparde: > On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: > > On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > > > 23/06/2023 16:00, Ferruh Yigit: > > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library > > >>

Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 21:00:31 + Ferruh Yigit wrote: > On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > > Rebuild with commit > > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/tap/tap_bpf_insns.h | 2959 +

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ajit Khaparde
On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: > > On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > > 23/06/2023 16:00, Ferruh Yigit: > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library > >>> unlike its name. > >>> > >>> Also we are

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ferruh Yigit
On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > 23/06/2023 16:00, Ferruh Yigit: >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library >>> unlike its name. >>> >>> Also we are suppose to enable/disable features dynamically, >>> not at compilati

Re: [PATCH] net/dpaa2: change threshold value

2023-11-02 Thread Ferruh Yigit
On 9/29/2023 2:50 PM, Ferruh Yigit wrote: > On 6/9/2023 3:20 PM, Ferruh Yigit wrote: >> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: >>> On 5/8/2023 4:11 PM, Tianli Lai wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doub

Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program

2023-11-02 Thread Ferruh Yigit
On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > Rebuild with commit > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/tap_bpf_insns.h | 2959 --- > 1 file changed, 1503 insertions(+),

[PATCH v8] devtools: add script to check for non inclusive naming

2023-11-02 Thread Stephen Hemminger
New script to find words that should not be used. Really just a wrapper around git grep command. By default it prints matches but can also display counts. Uses the word lists from Inclusive Naming Initiative see https://inclusivenaming.org/word-lists/ Note: the list has extra comma at end of lis

Re: [PATCH 0/2] add support of RX/TX pause frame switch

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 6:16 AM, Chaoyong He wrote: > This patch series add the support of RX and TX pause frame switch mode. > > Zerun Fu (2): > net/nfp: support getting pause frame switch mode > net/nfp: support setting pause frame switch mode > Series applied to dpdk-next-net/main, thanks.

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-02 Thread Ferruh Yigit
On 8/4/2023 9:28 AM, Kaiwen Deng wrote: > IEEE 802 packets may have a minimum size limit. The data fields > should be padded when necessary. In some cases, the padding data > is not zero. Testpmd does not trim these IP packets to the true > length of the frame, so errors will occur when calculating

Re: [PATCH] eal: add const to init function parameter

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 18:11:48 + Bruce Richardson wrote: > From: Bruce Richardson > To: dev@dpdk.org > Cc: step...@networkplumber.org, Bruce Richardson > Subject: [PATCH] eal: add const to init function parameter > Date: Thu, 2 Nov 2023 18:11:48 + > X-Mailer: git-send-email 2.39.2 > >

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 18:35:08 + Ferruh Yigit wrote: > > The motivation was to allow use of rte_flow in the failsafe/tap/mlx model. > > This is the legacy model for use in Hyper-V/Azure. Not aware of any > > application using this. > > The bug fix came from Oracle, perhaps they have more context

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 11:19:24 -0700 Rahul Gupta wrote: > From: Rahul Gupta > To: dev@dpdk.org, tho...@monjalon.net > Cc: sovar...@linux.microsoft.com, ok...@kernel.org, > sujithsan...@microsoft.com, sowmini.varad...@microsoft.com, > rahulrgupt...@gmail.com, Rahul Gupta , Rahul Gupta > > S

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 4:52 PM, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 15:11:10 + > Ferruh Yigit wrote: > >>> Stephen Hemminger (2): >>> net/tap: support infrastructure to build the BPF filter >>> net/tap; rebuild and update the BPF flow program >>> >> >> Thanks Stephen for fixing this. >

Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 4:53 PM, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 15:13:57 + > Ferruh Yigit wrote: > >> On 11/1/2023 6:02 PM, Stephen Hemminger wrote: >>> Rebuild with commit >>> c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) >>> >>> Signed-off-by: Stephen Hemminger

[RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-02 Thread Rahul Gupta
From: Rahul Gupta Initialization often requires rte_eal_init + rte_pktmbuf_pool_create which can consume a total time of 500-600 ms: a) For many devices FLR may take a significant chunk of time (200-250 ms in our use-case), this FLR is triggered during device probe in rte_eal_init(). b) rte

RE: [PATCH v1 02/11] test/bbdev: update python script parameters

2023-11-02 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, November 2, 2023 10:00 AM > To: Chautru, Nicolas ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; Rix, Tom > ; Hemant Agrawal > Cc: Zhang, Qi Z > Subject: Re: [PATCH v1 02/11] test/bbdev: update python scri

RE: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-11-02 Thread Sevincer, Abdullah
>+> WDYT, Jerin, Abdullah. It is a good idea to make it internal, I will work on that and upstream a new one.

Re: [24.03 RFC 0/3] Add argument manipulation library

2023-11-02 Thread Bruce Richardson
On Thu, Nov 02, 2023 at 10:50:29AM -0700, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 17:28:46 + > Bruce Richardson wrote: > > > DPDK has traditionally assumed that apps are written where argc/argv > > parameters are passed directly to rte_eal_init() and then app arguments > > are handled

[PATCH] eal: add const to init function parameter

2023-11-02 Thread Bruce Richardson
Change the parameter type of argv parameter to rte_eal_init from "char **" to "char * const *", since we don't modify the argv pointers passed in. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 2 +- lib/eal/common/eal_options.h| 2 +- lib/eal/freebsd/eal.c

Re: Updating examples which use coremask parameters

2023-11-02 Thread Bruce Richardson
On Thu, Nov 02, 2023 at 05:28:42PM +0100, Thomas Monjalon wrote: > 02/11/2023 15:56, Bruce Richardson: > > Hi all, > > > > looking to start a discussion and get some input here. > > > > There are a number of our examples in DPDK which still track core usage via > > a 64-bit bitmask, and, as such,

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 1:59 AM, lihuisong (C) wrote: > > 在 2023/11/2 0:08, Stephen Hemminger 写道: >> On Wed, 1 Nov 2023 10:36:07 +0800 >> "lihuisong (C)" wrote: >> Do we need to report this size? It's a common feature for all PMDs. It would make sense then to have max_rx_bufsize set to 16K by defa

[24.03 RFC 3/3] args: add functions to check parameter validity

2023-11-02 Thread Bruce Richardson
Add in functions which can be used to check for valid arguments for EAL or for the application. This can be used to separate out mixed arguments. Signed-off-by: Bruce Richardson --- lib/args/args.c | 122 +++ lib/args/rte_args.h | 56 +++

Re: [24.03 RFC 0/3] Add argument manipulation library

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 17:28:46 + Bruce Richardson wrote: > DPDK has traditionally assumed that apps are written where argc/argv > parameters are passed directly to rte_eal_init() and then app arguments > are handled afterwards, as is done in the DPDK apps and examples. > > However, based on ot

RE: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Thursday, 2 November 2023 18.06 > > On 11/2/2023 4:51 PM, Morten Brørup wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > >> Sent: Thursday, 2 November 2023 17.24 > >> > >> On 11/2/2023 1:59 AM, lihuisong (C) wrote: > >>> > >>

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 5:12 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Thursday, 2 November 2023 18.06 >> >> On 11/2/2023 4:51 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 2 November 2023 17.24 On 11/2

[24.03 RFC 2/3] eal: allow export of the cmdline argument parsing options

2023-11-02 Thread Bruce Richardson
Allow other libraries in DPDK to know about the options EAL takes, by exporting the long and short getopt options via an internal-only function. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 9 + lib/eal/include/rte_eal.h | 14 ++ lib/ea

[24.03 RFC 0/3] Add argument manipulation library

2023-11-02 Thread Bruce Richardson
DPDK has traditionally assumed that apps are written where argc/argv parameters are passed directly to rte_eal_init() and then app arguments are handled afterwards, as is done in the DPDK apps and examples. However, based on other projects, like VPP and OVS, we know that this is often not the case

Updating examples which use coremask parameters

2023-11-02 Thread Bruce Richardson
Hi all, looking to start a discussion and get some input here. There are a number of our examples in DPDK which still track core usage via a 64-bit bitmask, and, as such, cannot run on cores between 64 and RTE_MAX_LCORE. Two examples I have recently come across with this issue are "eventdev_pipel

[24.03 RFC 1/3] args: new library to allow easier manipulation of cmdline args

2023-11-02 Thread Bruce Richardson
Add a new small library to make it easier for apps to work with cmdline arguments and build up args to use when initializing EAL. This library is optional, and can be disabled at build time using the disable libraries meson option. Signed-off-by: Bruce Richardson --- doc/api/doxy-api-index.md |

RE: [PATCH] crypto/ipsec_mb: Do not dequeue ops from ring after job flush.

2023-11-02 Thread Cornu, Marcel D
> -Original Message- > From: Karas, Krzysztof > Sent: Wednesday, September 27, 2023 1:41 PM > To: Ji, Kai ; De Lara Guarch, Pablo > ; Cornu, Marcel D > ; Power, Ciara > Cc: dev@dpdk.org; Karas, Krzysztof ; > sta...@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: Do not dequeue ops from ring

Re: [PATCH v1 02/11] test/bbdev: update python script parameters

2023-11-02 Thread Maxime Coquelin
Hi Nicolas, On 10/27/23 22:02, Chautru, Nicolas wrote: Hi Maxime, Back on this discussion and there was some misunderstanding. This is really a bug for the python script helper only. The -t option is already reserved for bbdev-test application (and in doc) for setting the iter_max (see main.c

Re: Updating examples which use coremask parameters

2023-11-02 Thread Thomas Monjalon
02/11/2023 15:56, Bruce Richardson: > Hi all, > > looking to start a discussion and get some input here. > > There are a number of our examples in DPDK which still track core usage via > a 64-bit bitmask, and, as such, cannot run on cores between 64 and > RTE_MAX_LCORE. Two examples I have recent

Re: Updating examples which use coremask parameters

2023-11-02 Thread Bruce Richardson
On Thu, Nov 02, 2023 at 06:05:59PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 2 November 2023 15.57 > > > > Hi all, > > > > looking to start a discussion and get some input here. > > > > There are a number of our examples in DPD

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 15:11:10 + Ferruh Yigit wrote: > > Stephen Hemminger (2): > > net/tap: support infrastructure to build the BPF filter > > net/tap; rebuild and update the BPF flow program > > > > Thanks Stephen for fixing this. > > > But considering it was broken for a while and n

RE: Updating examples which use coremask parameters

2023-11-02 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 2 November 2023 15.57 > > Hi all, > > looking to start a discussion and get some input here. > > There are a number of our examples in DPDK which still track core usage > via > a 64-bit bitmask, and, as such, cannot r

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 4:51 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Thursday, 2 November 2023 17.24 >> >> On 11/2/2023 1:59 AM, lihuisong (C) wrote: >>> >>> 在 2023/11/2 0:08, Stephen Hemminger 写道: On Wed, 1 Nov 2023 10:36:07 +0800 "lihuisong (C)" wrote

Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program

2023-11-02 Thread Stephen Hemminger
On Thu, 2 Nov 2023 15:13:57 + Ferruh Yigit wrote: > On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > > Rebuild with commit > > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/tap/tap_bpf_insns.h | 2959 +

Re: [PATCH v4 1/3] ethdev: introduce maximum Rx buffer size

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 12:16 PM, Huisong Li wrote: > The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum > Rx buffer size supported by hardware. Actually, some engines also have > the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf > data room size in mempool is greate

RE: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-11-02 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Thursday, 2 November 2023 17.24 > > On 11/2/2023 1:59 AM, lihuisong (C) wrote: > > > > 在 2023/11/2 0:08, Stephen Hemminger 写道: > >> On Wed, 1 Nov 2023 10:36:07 +0800 > >> "lihuisong (C)" wrote: > >> > Do we need to report this size?

Re: [PATCH v2 4/7] net/bnxt: use fp ops setup function

2023-11-02 Thread Ajit Khaparde
On Thu, Nov 2, 2023 at 3:35 AM Konstantin Ananyev wrote: > > > > > Use rte_eth_fp_ops_setup() instead of directly manipulating > > rte_eth_fp_ops variable. > > > > Cc: sta...@dpdk.org > > > > Signed-off-by: Chengwen Feng > > --- > > drivers/net/bnxt/bnxt_cpr.c| 5 + > > drivers/net/bnxt/

Re: [PATCH v2 3/7] net/bnxt: fix race-condition when report error recovery

2023-11-02 Thread Ajit Khaparde
On Fri, Oct 20, 2023 at 3:11 AM Chengwen Feng wrote: > > If set data path functions to dummy functions before reports error > recovering event, there maybe a race-condition with data path threads, > this patch fixes it by setting data path functions to dummy functions > only after reports such eve

Re: [PATCH v4 2/3] app/testpmd: add maximum Rx buffer size display

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 12:16 PM, Huisong Li wrote: > Add maximum Rx buffer size display. > I think there is a value to show what is the intended usage of this new field in application level, that is why what do you think to use testpmd? Testpmd can be updated to check if mbuf data size is bigger than devi

Re: [PATCH 0/5] use abstracted bit count functions

2023-11-02 Thread Tyler Retzlaff
On Thu, Nov 02, 2023 at 04:33:57PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 2 November 2023 16.28 > > > > On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microso

RE: [PATCH 0/5] use abstracted bit count functions

2023-11-02 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 2 November 2023 16.28 > > On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Thursday, 2 November 2023 02.05 > > > > > > The first

Re: [PATCH 0/5] use abstracted bit count functions

2023-11-02 Thread Tyler Retzlaff
On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 2 November 2023 02.05 > > > > The first set of conversions missed the long 'l' versions of the > > builtins that were being used. This series completes

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Ferruh Yigit
On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > Update the documentation and tools to build the BPF program used by > tap device. And apply fix to the RSS algorithm to correctly > handle non-IP protocols. > > v6 - cosmetic improvements to extract process > add better boilerplate and fix pyth

Re: [PATCH v6 0/3] net/tap: build and fix for BPF program

2023-11-02 Thread Ferruh Yigit
On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > Update the documentation and tools to build the BPF program used by > tap device. And apply fix to the RSS algorithm to correctly > handle non-IP protocols. > > v6 - cosmetic improvements to extract process > add better boilerplate and fix pyth

Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program

2023-11-02 Thread Ferruh Yigit
On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > Rebuild with commit > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/tap_bpf_insns.h | 2959 --- > 1 file changed, 1503 insertions(+),

Re: [PATCH 00/11] Add the support of multiple PF

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 2:23 AM, Chaoyong He wrote: > Up to now, the NFP card using only one PF (or BDF) for multiple physical > ports, this force the PMD import the difference logic for 'PF' and > 'physical port'. Which is not easy to understand and also not compatible > with some DPDK applications. > This p

RE: [PATCH v4 00/13] support IPv6 push remove action

2023-11-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, November 1, 2023 6:44 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: [PATCH v4 00/13] support IPv6 push remove action > > Support IPv6

Re: [PATCH] net/nfp: add support of dynamic config of allmulticast mode

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 5:37 AM, Chaoyong He wrote: > From: Qin Ke > > Add support of dynamic config of allmulticast mode for NFP > by adding enable and disable callback function. > > Signed-off-by: Qin Ke > Reviewed-by: Chaoyong He > Applied to dpdk-next-net/main, thanks.

Re: [PATCH v9 0/9] support setting and querying RSS algorithms

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 8:20 AM, Jie Hai wrote: > This patchset is to support setting and querying RSS algorithms. > For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` > and field "algorithm" is added to ``rte_eth_rss_conf``. > The drivers should reports their "rss_algo_capa" if they sup

[PATCH 2/2] net/nfp: fix calloc parameters

2023-11-02 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o .../net/nfp/nfpcore/nfp_mutex.c: In function ‘nfp_cpp_mutex_alloc

[PATCH 1/2] pipeline: fix calloc parameters

2023-11-02 Thread Ferruh Yigit
gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../pipeline_rte_swx_pipeline_spec.c.o .../rte_swx_pipeline_spec.c: In function ‘pipeline_spec_parse

[Bug 1307] mlx5_net: probe of PCI device 4790:00:02.0 aborted after encountering an error: Operation not permitted

2023-11-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1307 Bug ID: 1307 Summary: mlx5_net: probe of PCI device 4790:00:02.0 aborted after encountering an error: Operation not permitted Product: DPDK Version: 23.11 Hardware: x86

Re: [EXT] [PATCH 27/36] net/octeontx: fix Rx and Tx queue state

2023-11-02 Thread Jie Hai
On 2023/11/2 17:59, Harman Kalra wrote: Hi Jie, What issue did you observe which the following patch resolves? Can you please provide steps. Because we are setting the respective queue state in octeontx_dev_tx_queue_start/stop() ethdev_ops Thanks Harman Hi, Harman, If dev_start are called,

[PATCH v4 2/3] app/testpmd: add maximum Rx buffer size display

2023-11-02 Thread Huisong Li
Add maximum Rx buffer size display. Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- app/test-pmd/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b9fdb7e8f1..2ac6f15773 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/

[PATCH v4 1/3] ethdev: introduce maximum Rx buffer size

2023-11-02 Thread Huisong Li
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf data room size in mempool is greater then the maximum Rx buffer size per descriptor

  1   2   >