[PATCH v2 11/11] net/nfp: remove the redundancy logic of representor port

2023-10-27 Thread Chaoyong He
Using the helper function, we can remove some redundancy logic of representor port by reusing the functions in common module. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 47 +--- drivers/net/nfp/flower/nfp_flower.h | 1 - .

[PATCH v2 09/11] net/nfp: unify the PMD name with macro

2023-10-27 Thread Chaoyong He
Unify the PMD name with a string macro, make it more extendable. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c| 8 +--- drivers/net/nfp/nfp_ethdev_vf.c | 6 -- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/nfp_et

[PATCH v2 10/11] net/nfp: extract a helper function

2023-10-27 Thread Chaoyong He
Extract a helper function to get the pointer of 'struct nfp_net_hw' for both normal port and representor pot, this will make the operation function can be used for both type port. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 64 ++-

[PATCH v2 08/11] net/nfp: replace hard coded value

2023-10-27 Thread Chaoyong He
Replace the hard coded value with meaningful macro to make it more readable. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_cmsg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c b/drivers/

[PATCH v2 07/11] net/nfp: use the DPDK defined function

2023-10-27 Thread Chaoyong He
Use the DPDK defined function to replace the user defined macro, to make the logic more standard. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 2 +- drivers/net/nfp/nfp_rxtx.c | 4 ++-- drivers/net/nfp/nfp_rxtx.h |

[PATCH v2 06/11] net/nfp: remove redundancy logic of init control BAR

2023-10-27 Thread Chaoyong He
There are two initialize statements of control BAR in 'nfp_net_init()' and the first one is unneeded, and what it really use is the check of NULL value of the 'mem_resource'. So we move the check of 'mem_resource' to the start of probe logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --

[PATCH v2 05/11] net/nfp: remove the redundancy macro

2023-10-27 Thread Chaoyong He
Macro 'NFP_HASH_OFFSET' and 'NFP_HASH_TYPE_OFFSET' are unused, so remove them. Macro 'NFP_MAX_PHYPORTS' and 'MAX_FLOWER_PHYPORTS' are redundancy, so just keep the first one. Macro 'NFP_NET_CFG_SPARE_ADDR', 'NFP_NET_CFG_RX_OFFSET_ADDR' and 'NFP_NET_CFG_RX_OFFSET' are redundancy, we just keep the fin

[PATCH v2 04/11] net/nfp: remove the unneeded data abstraction

2023-10-27 Thread Chaoyong He
The data structure 'struct nfp_net_adapter' has only one data field and we won't extend it in the future, which makes this abstraction unneeded, so remove this data structure and the related macro 'NFP_NET_DEV_PRIVATE_TO_HW'. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nf

[PATCH v2 03/11] net/nfp: remove the unneeded check of process type

2023-10-27 Thread Chaoyong He
Remove the unneeded secondary call of 'rte_eal_process_type()' in 'nfp_netvf_init()', because the first call of it already make sure only the primary process can continue run the rest logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev_vf.c | 16 +++-

[PATCH v2 02/11] net/nfp: remove the unneeded call of underlying API

2023-10-27 Thread Chaoyong He
Remove the unneeded call of underlying API in function 'nfp_net_pf_read_mac()`, because we already store the result of it in data structure. Also change the return type of this function to 'void' as there is no abnormal exit logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers

[PATCH v2 01/11] net/nfp: use the suitable helper macro

2023-10-27 Thread Chaoyong He
Replace the `rte_pktmbuf_mtod()` macro to with the more suitable `rte_pktmbuf_mtod_offset()`. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_cmsg.c | 2 +- drivers/net/nfp/flower/nfp_flower_ctrl.c | 4 ++-- drivers/net/nfp/nfp_rxtx.c | 3 +

[PATCH v2 00/11] Clean up NFP PMD

2023-10-27 Thread Chaoyong He
This patch series clean up the NFP PMD, by: - Using the DPDK macro and API to replace the user defined ones. - Remove the unneeded macro and logic. - Remove the duplicated logic. --- v2: * Fix the compile error. * Fix one check script warning. --- Chaoyong He (11): net/nfp: use the suitable hel

[PATCH] net/nfp: fix offload flags of the security capabilities

2023-10-27 Thread Chaoyong He
From: Shihong Wang This patch resolves configuration error of ol_flags in the rte_security_capability. Currently ol_flags in the ingress direction of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact, ol_flags only in the egress direction of the SA needs to be configured. Fixes:

[PATCH] net/nfp: reduce space reserved for layer 2 overhead

2023-10-27 Thread Chaoyong He
From: James Hershaw Reduce the space reserved for layer 2 overhead by defining NFP_ETH_OVERHEAD. Previously, the overhead was not explicitly defined, only the NFP_FRAME_SIZE_MAX value and the maximum layer 3 MTU was read from hardware, which is set by firmware. This resulted in a massive overhe

[PATCH 3/3] net/nfp: fix the reconfigure logic of set mac address

2023-10-27 Thread Chaoyong He
If the reconfigure API exit abnormally, the value in the config bar will not same with the value stored in the data structure. Fix this by add a local variable to hold the temporary value and the logic of store it when no error happen. Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change") C

[PATCH 2/3] net/nfp: fix the reconfigure logic in VF initialization

2023-10-27 Thread Chaoyong He
There exists exit point between the reconfigure logic and the stroe logic of the VF initialization, this may lead one situation that value in the config bar is not same with the value stored in the data structure. Fix this by move up the store statement. Fixes: 7f8e73201dae ("net/nfp: move VF fun

[PATCH 1/3] net/nfp: fix the reconfigure logic in PF initialization

2023-10-27 Thread Chaoyong He
There exists exit point between the reconfigure logic and the stroe logic of the PF initialization, this may lead one situation that value in the config bar is not same with the value stored in the data structure. Fix this by move up the store statement. Fixes: b812daadad0d ("nfp: add Rx and Tx")

[PATCH 0/3] Fix some reconfigure problem

2023-10-27 Thread Chaoyong He
This patch series fix some problems about reconfiguration logic. Chaoyong He (3): net/nfp: fix the reconfigure logic in PF initialization net/nfp: fix the reconfigure logic in VF initialization net/nfp: fix the reconfigure logic of set mac address drivers/net/nfp/nfp_ethdev.c | 4 ++--

[PATCH 11/11] net/nfp: remove the redundancy logic of representor port

2023-10-27 Thread Chaoyong He
Using the helper function, we can remove some redundancy logic of representor port by reusing the functions in common module. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 47 +--- drivers/net/nfp/flower/nfp_flower.h | 1 - .

[PATCH 10/11] net/nfp: extract a helper function

2023-10-27 Thread Chaoyong He
Extract a helper function to get the pointer of 'struct nfp_net_hw' for both normal port and representor pot, this will make the operation function can be used for both type port. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 64 ++-

[PATCH 09/11] net/nfp: unify the PMD name with macro

2023-10-27 Thread Chaoyong He
Unify the PMD name with a string macro, make it more extendable. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c| 8 +--- drivers/net/nfp/nfp_ethdev_vf.c | 6 -- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/nfp_et

[PATCH 08/11] net/nfp: replace hard coded value

2023-10-27 Thread Chaoyong He
Replace the hard coded value with meaningful macro to make it more readable. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_cmsg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c b/drivers/

[PATCH 07/11] net/nfp: use the DPDK defined function

2023-10-27 Thread Chaoyong He
Use the DPDK defined function to replace the user defined macro, to make the logic more standard. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 2 +- drivers/net/nfp/nfp_rxtx.c | 4 ++-- drivers/net/nfp/nfp_rxtx.h |

[PATCH 05/11] net/nfp: remove the redundancy macro

2023-10-27 Thread Chaoyong He
Macro 'NFP_HASH_OFFSET' and 'NFP_HASH_TYPE_OFFSET' are unused, so remove them. Macro 'NFP_MAX_PHYPORTS' and 'MAX_FLOWER_PHYPORTS' are redundancy, so just keep the first one. Macro 'NFP_NET_CFG_SPARE_ADDR', 'NFP_NET_CFG_RX_OFFSET_ADDR' and 'NFP_NET_CFG_RX_OFFSET' are redundancy, we just keep the fin

[PATCH 06/11] net/nfp: remove redundancy logic of init control BAR

2023-10-27 Thread Chaoyong He
There are two initialize statements of control BAR in 'nfp_net_init()' and the first one is unneeded, and what it really use is the check of NULL value of the 'mem_resource'. So we move the check of 'mem_resource' to the start of probe logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --

[PATCH 04/11] net/nfp: remove the unneeded data abstraction

2023-10-27 Thread Chaoyong He
The data structure 'struct nfp_net_adapter' has only one data field and we won't extend it in the future, which makes this abstraction unneeded, so remove this data structure and the related macro 'NFP_NET_DEV_PRIVATE_TO_HW'. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nf

[PATCH 03/11] net/nfp: remove the unneeded check of process type

2023-10-27 Thread Chaoyong He
Remove the unneeded secondary call of 'rte_eal_process_type()' in 'nfp_netvf_init()', because the first call of it already make sure only the primary process can continue run the rest logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev_vf.c | 16 +++-

[PATCH 02/11] net/nfp: remove the unneeded call of underlying API

2023-10-27 Thread Chaoyong He
Remove the unneeded call of underlying API in function 'nfp_net_pf_read_mac()`, because we already store the result of it in data structure. Also change the return type of this function to 'void' as there is no abnormal exit logic. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers

[PATCH 01/11] net/nfp: use the suitable helper macro

2023-10-27 Thread Chaoyong He
Replace the `rte_pktmbuf_mtod()` macro to with the more suitable `rte_pktmbuf_mtod_offset()`. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_cmsg.c | 2 +- drivers/net/nfp/flower/nfp_flower_ctrl.c | 4 ++-- drivers/net/nfp/nfp_rxtx.c | 3 +

[PATCH 00/11] Clean up NFP PMD

2023-10-27 Thread Chaoyong He
This patch series clean up the NFP PMD, by: - Using the DPDK macro and API to replace the user defined ones. - Remove the unneeded macro and logic. - Remove the duplicated logic. Chaoyong He (11): net/nfp: use the suitable helper macro net/nfp: remove the unneeded call of underlying API net/

Re: [PATCH v7 9/9] app/testpmd: add RSS hash algorithms display

2023-10-27 Thread lihuisong (C)
在 2023/10/28 9:46, Jie Hai 写道: Add the command "show port X rss-hash algorithm" to display the RSS hash algorithms of port X. An example is shown: testpmd> show port 0 rss-hash algorithm RSS algorithms: toeplitz Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 29

Re: [PATCH v7 7/9] lib/ethdev: add API to get RSS algorithm names

2023-10-27 Thread lihuisong (C)
在 2023/10/28 9:46, Jie Hai 写道: This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai --- doc/guides/rel_notes/release_23_11.rst | 3 +++ lib/ethdev/rte_ethdev.c| 25 + lib/ethdev/

Re: [PATCH v7 5/9] app/proc-info: fix never show RSS info

2023-10-27 Thread lihuisong (C)
在 2023/10/28 9:46, Jie Hai 写道: Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan Acked-by: Chengwen Feng --- lgtm, Acked-by: Huisong Li

Re: [PATCH v7 3/9] net/hns3: report RSS hash algorithms capability

2023-10-27 Thread lihuisong (C)
lgtm, Acked-by: Huisong Li 在 2023/10/28 9:46, Jie Hai 写道: The hns3 driver should reports RSS hash algorithm capability to support updating RSS hash algorithm by rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(). Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 4 1 f

Re: [PATCH v7 2/9] ethdev: support setting and querying RSS algorithm

2023-10-27 Thread lihuisong (C)
With belows to changes, Acked-by: Huisong Li 在 2023/10/28 9:46, Jie Hai 写道: Currently, rte_eth_rss_conf supports configuring and querying RSS hash functions, rss key and it's length, but not RSS hash algorithm. The structure ``rte_eth_dev_info`` is extended by adding a new field "rss_algo_cap

Re: [PATCH v7 1/9] ethdev: overwrite some comment related to RSS

2023-10-27 Thread lihuisong (C)
在 2023/10/28 9:46, Jie Hai 写道: 1. overwrite the comments of fields of 'rte_eth_rss_conf'. 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.h | 33 ++--- lib/ethdev/rte_flow.h | 1 + 2 files changed, 19 inser

Re: [PATCH 0/8] net/hns3: add some bugfix for hns3

2023-10-27 Thread Jie Hai
On 2023/10/28 3:29, Ferruh Yigit wrote: On 10/27/2023 7:09 AM, Jie Hai wrote: This patchset contains some bugfix for hns3 pmd. Dengdui Huang (6): net/hns3: fix unchecked Rx free threshold net/hns3: fix double stats for IMP and global reset net/hns3: remove reset log in secondary net

[PATCH v7 9/9] app/testpmd: add RSS hash algorithms display

2023-10-27 Thread Jie Hai
Add the command "show port X rss-hash algorithm" to display the RSS hash algorithms of port X. An example is shown: testpmd> show port 0 rss-hash algorithm RSS algorithms: toeplitz Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 29 - app/test-pmd/config.c | 2

[PATCH v7 8/9] app/proc-info: support querying RSS hash algorithm

2023-10-27 Thread Jie Hai
Display RSS hash algorithm with command show-port as below. - RSS info -- hash algorithm : toeplitz Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan --- app/proc-info/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/proc-info/main.c b/app/p

[PATCH v7 7/9] lib/ethdev: add API to get RSS algorithm names

2023-10-27 Thread Jie Hai
This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai --- doc/guides/rel_notes/release_23_11.rst | 3 +++ lib/ethdev/rte_ethdev.c| 25 + lib/ethdev/rte_ethdev.h| 4

[PATCH v7 6/9] app/proc-info: adjust the display format of RSS info

2023-10-27 Thread Jie Hai
This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ 25 3d 43 a3 8f b0

[PATCH v7 5/9] app/proc-info: fix never show RSS info

2023-10-27 Thread Jie Hai
Command show-port should show RSS info (rss_key, len and rss_hf), However, the information is shown only when rss_conf.rss_key is not NULL. Since no memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the rss_info will never show. This patch fixes it. Fixes: 8a37f37fc243 ("ap

[PATCH v7 4/9] net/hns3: support setting and querying RSS hash function

2023-10-27 Thread Jie Hai
From: Huisong Li Support setting and querying RSS hash function by ethdev ops. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu Signed-off-by: Jie Hai Acked-by: Chengwen Feng --- drivers/net/hns3/hns3_rss.c | 47 + 1 file changed, 27 insertions(+), 2

[PATCH v7 3/9] net/hns3: report RSS hash algorithms capability

2023-10-27 Thread Jie Hai
The hns3 driver should reports RSS hash algorithm capability to support updating RSS hash algorithm by rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(). Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/hns3/hns3

[PATCH v7 2/9] ethdev: support setting and querying RSS algorithm

2023-10-27 Thread Jie Hai
Currently, rte_eth_rss_conf supports configuring and querying RSS hash functions, rss key and it's length, but not RSS hash algorithm. The structure ``rte_eth_dev_info`` is extended by adding a new field "rss_algo_capa". Drivers are responsible for reporting this capa and configurations of RSS has

[PATCH v7 1/9] ethdev: overwrite some comment related to RSS

2023-10-27 Thread Jie Hai
1. overwrite the comments of fields of 'rte_eth_rss_conf'. 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.h | 33 ++--- lib/ethdev/rte_flow.h | 1 + 2 files changed, 19 insertions(+), 15 deletions(-) diff --git

[PATCH v7 0/9] support setting and querying RSS algorithms

2023-10-27 Thread Jie Hai
This patchset is to support setting and querying RSS algorithms. For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` and field "algorithm" is added to ``rte_eth_rss_conf``. The drivers should reports their "rss_algo_capa" if they support updating RSS algorithms. Otherwise, the

[PATCH v3 0/3] introduce maximum Rx buffer size

2023-10-27 Thread Huisong Li
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specification, like, hns3. If mbuf data room size in mempool is greater then the maximum Rx buffer size supported by HW, the data size

[PATCH v3 2/3] app/testpmd: add maximum Rx buffer size display

2023-10-27 Thread Huisong Li
Add maximum Rx buffer size display. Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- app/test-pmd/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b9fdb7e8f1..2ac6f15773 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/

[PATCH v3 3/3] net/hns3: report maximum buffer size

2023-10-27 Thread Huisong Li
This patch reports the maximum buffer size hardware supported. Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- drivers/net/hns3/hns3_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index c4d47f43fe..cfce9ddd0f 10

[PATCH v3 1/3] ethdev: introduce maximum Rx buffer size

2023-10-27 Thread Huisong Li
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specification, like, hns3. If mbuf data room size in mempool is greater then the maximum Rx buffer size supported by HW, the data size

Re: [PATCH v2 1/3] ethdev: introduce maximum Rx buffer size

2023-10-27 Thread lihuisong (C)
在 2023/10/27 15:40, Morten Brørup 写道: From: Huisong Li [mailto:lihuis...@huawei.com] Sent: Friday, 27 October 2023 06.15 The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specifica

[PATCH v2 09/10] test/bbdev: support new FFT capabilities

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Adding support to test new FFT capabilities. Optional frequency domain dewindowing, frequency resampling, timing error correction and time offset per CS. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 26 ++--- ap

[PATCH v2 10/10] test/bbdev: support 4 bit LLR compression

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add support to test LDPC UL operation for new capability. Option to compress HARQ memory to 4 bits per LLR. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 3 ++- app/test-bbdev/test_bbdev_vector.c | 2 ++ 2 files changed,

[PATCH v2 08/10] test/bbdev: add MLD support

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Adding test-bbdev support for the MLD-TS processing specific to the VRB2 variant. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 519 + app/test-bbdev/test_bbdev_vector.c | 132 app/te

[PATCH v2 07/10] test/bbdev: ldpc encoder concatenation vector

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add support for LDPC encoder concatenation configuration from the test vector. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_vector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_

[PATCH v2 05/10] test/bbdev: improve test log messages

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add a print message for failure to retrieve stats on bbdev. Add vector name in logs. Remove unnecessary prints. Update code comments and cosmetic changes. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/main.c|

[PATCH v2 06/10] test/bbdev: assert failed test for queue configure

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Stop test if rte_bbdev_queue_configure fails to configure queue. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev.c | 3 ++- 1 file changed, 2

[PATCH v2 04/10] test/bbdev: handle exception for LLR generation

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add range limit to prevent LLR generation greater than the data buffer size. Fixes: 7831a9684356 ("test/bbdev: support BLER for 4G") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[PATCH v2 03/10] test/bbdev: rename macros from acc200 to vrb

2023-10-27 Thread Nicolas Chautru
Renaming ACC200 macros to use generic intel vRAN Boost (VRB). No functional impact. Fixes: 69a9d9e139d2 ("baseband/acc: rename files from acc200 to vrb") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 91 --

[PATCH v2 02/10] test/bbdev: update python script parameters

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update the timeout argument and default values. Update EAL help message and default value. Add iter_max and snr arguments. Signed-off-by: Hernan Vargas --- app/test-bbdev/test-bbdev.py | 22 ++ app/test-bbdev/test_bbdev_perf.c | 2 +- 2 files change

[PATCH v2 01/10] test/bbdev: fix python script subprocess

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas test-bbdev.py relying on non-recommended subprocess Popen. This can lead to instabilities where the process cannot be stopped with a sig TERM. Use subprocess run with proper timeout argument. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpd

[PATCH v2 00/10] test-bbdev changes for 23.11

2023-10-27 Thread Nicolas Chautru
v2: adding fixes for some of the commits requested by Maxime. Update test-bbdev for 23.11. Hernan Vargas (9): test/bbdev: fix python script subprocess test/bbdev: update python script parameters test/bbdev: handle exception for LLR generation test/bbdev: improve test log messages test/b

[PATCH v3 1/2] baseband/acc: support ACC100 deRM corner case SDK

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Implement de-ratematch pre-processing for ACC100 SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to t

[PATCH v3 2/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update FlexRAN SDK module link to use FEC_SDK_23.07. Update compiler links to use ICX. Update build SDK build instructions. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/turbo_sw.rst | 53 +++--- 1 file changed, 30 insertions(+), 23 deletion

[PATCH v3 0/2] FlexRAN SDK update for 23.11

2023-10-27 Thread Nicolas Chautru
v3: rebase typo fixed. v2: rebase typo fixed. Upstreaming SDK workaround for ACC100 and updating documentation for new SDK release. Hernan Vargas (2): baseband/acc: support ACC100 deRM corner case SDK doc: update FlexRAN SDK links doc/guides/bbdevs/turbo_sw.rst| 53 +-

[PATCH v2 1/2] baseband/acc: support ACC100 deRM corner case SDK

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Implement de-ratematch pre-processing for ACC100 SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to t

[PATCH v2 2/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update FlexRAN SDK module link to use FEC_SDK_23.07. Update compiler links to use ICX. Update build SDK build instructions. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/turbo_sw.rst | 53 +++--- 1 file changed, 30 insertions(+), 23 deletion

[PATCH v2 0/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
v2: rebase typo fixed. Upstreaming SDK workaround for ACC100 and updating documentation for new SDK release. Hernan Vargas (2): baseband/acc: support ACC100 deRM corner case SDK doc: update FlexRAN SDK links doc/guides/bbdevs/turbo_sw.rst| 53 +--- drivers/baseba

Re: [PATCH] net/af_xdp: avoid error log for virtual interfaces

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 3:32 PM, David Marchand wrote: > For virtual interfaces, like a veth or a tap used in OVS unit tests, > plugging a af_xdp port on them results in an error level message: > > dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value > /sys/class/net/ovs-tap1/device/numa_nod

RE: [PATCH v1 02/11] test/bbdev: update python script parameters

2023-10-27 Thread Chautru, Nicolas
Hi Maxime, Back on this discussion and there was some misunderstanding. This is really a bug for the python script helper only. The -t option is already reserved for bbdev-test application (and in doc) for setting the iter_max (see main.c). The problem is that the python script introduced -t by

Re: [PATCH 0/8] net/hns3: add some bugfix for hns3

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 7:09 AM, Jie Hai wrote: > This patchset contains some bugfix for hns3 pmd. > > Dengdui Huang (6): > net/hns3: fix unchecked Rx free threshold > net/hns3: fix double stats for IMP and global reset > net/hns3: remove reset log in secondary > net/hns3: fix multiple reset detecte

RE: [EXT] [PATCH] crypto/qat: add sm2 ecdsa

2023-10-27 Thread Akhil Goyal
> Added SM2 ECDSA feature to the Intel QuickAssist Technology > symmetric crypto PMD. > > Signed-off-by: Arkadiusz Kusztal > --- The patch is not getting compiled on latest TOT. Please fix. ../drivers/crypto/qat/qat_asym.c: In function 'sm2_ecdsa_sign_set_input': ../drivers/crypto/qat/qat_asym.c:

RE: [EXT] [PATCH v3] doc: update QAT cryptodev guide to run on aarch64

2023-10-27 Thread Akhil Goyal
> Update guide with instructions to run on Aarch64 based Ampere Altra > platform > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > v3: > - Fix duplicate target warning by using anonymous reference > v2: > - Update driver guide with instructions to run on aarch64 instead >

RE: [PATCH] app/test: validate shorter private key in ECDSA P521 test

2023-10-27 Thread Akhil Goyal
> Subject: [PATCH] app/test: validate shorter private key in ECDSA P521 test > > Update test vector of ECDSA P521 curve for validating private key > of length shorter than prime length. As prime length of this test > is not aligned by 8 bytes, this new test vector could test any > alignment issue

RE: [PATCH 0/2] Add AES-CCM support and fix application panic

2023-10-27 Thread Akhil Goyal
> Subject: [PATCH 0/2] Add AES-CCM support and fix application panic > > This patch set adds support for AES-CCM algorithm and fixes application > panic when source or destination mbuf segments are higher than max > supported by the driver. > > Nagadheeraj Rottela (2): > crypto/nitrox: fix pani

Re: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2023-10-27 Thread Stephen Hemminger
On Fri, 27 Oct 2023 10:45:03 +0200 Morten Brørup wrote: > Is it 100 % certain that the system becomes unstable if not sleeping or using > blocking system calls from a real-time thread? > And technically, it's not the thread itself that becomes unstable. My experience is that the goal of real ti

Re: [PATCH v3 0/5] net/ena: v2.8.0 driver release

2023-10-27 Thread Ferruh Yigit
On 10/26/2023 3:21 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Hi, > > This patchset contains alignment of the driver to the latest HAL version > which adds support for retrieving new metrics from the device and opens > a path to use additional device features that are not yet suppor

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 5:22 PM, Ferruh Yigit wrote: > From: Shubham Rohila > > Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to > enable or disable bus master functionality for cdx devices. > > Signed-off-by: Shubham Rohila > Note: this is re-sent on behalf of Shubham to record the patch,

[PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Ferruh Yigit
From: Shubham Rohila Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx_vfio.c | 97

Re: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 27 October 2023 15:23 To: dev@dpdk.org Cc: Power, Ciara ; Dooley, Brian ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH] crypto/qat: fix build when no openssl exists Previously some compilation er

Re: [RFC PATCH v4 2/4] dts: add doc generation dependencies

2023-10-27 Thread Yoan Picchi
On 8/31/23 11:04, Juraj Linkeš wrote: Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are

[PATCH 7/7] compress/nitrox: add stateful request support

2023-10-27 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateful request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c| 187 +-- drivers/compress/nitrox/nitrox_comp_reqmgr.c | 555 --- drivers/compress/nitrox/nitrox_comp_reqmgr.h |

[PATCH 6/7] compress/nitrox: add stateless request support

2023-10-27 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateless request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c| 139 ++-- drivers/compress/nitrox/nitrox_comp_reqmgr.c | 789 +++ drivers/compress/nitrox/nitrox_comp_reqmgr.h | 61

[PATCH 5/7] compress/nitrox: add software queue management

2023-10-27 Thread Nagadheeraj Rottela
Add software queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c | 116 +++--- 1 file changed, 105 insertions(+), 11 deletions(-) diff --git a/drivers/compress/nitrox/nitr

[PATCH 4/7] crypto/nitrox: set queue type during queue pair setup

2023-10-27 Thread Nagadheeraj Rottela
Set queue type as SE to initialize symmetric hardware queue. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_sym.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nitrox/nitrox_sym.c b/drivers/crypto/nitrox/nitrox_sym.c index 1244317438..03652d3ade 100644

[PATCH 3/7] common/nitrox: add compress hardware queue management

2023-10-27 Thread Nagadheeraj Rottela
Add compress device ring initialization and cleanup code. Signed-off-by: Nagadheeraj Rottela --- drivers/common/nitrox/nitrox_csr.h | 12 +++ drivers/common/nitrox/nitrox_hal.c | 116 + drivers/common/nitrox/nitrox_hal.h | 115 drivers/co

[PATCH 2/7] compress/nitrox: add nitrox compressdev driver

2023-10-27 Thread Nagadheeraj Rottela
Introduce nitrox compressdev driver which implements below operations - dev_configure - dev_close - dev_infos_get - private_xform_create - private_xform_free Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 7 + doc/guides/compressdevs/features/nitrox.ini

[PATCH 1/7] crypto/nitrox: move nitrox common code to common folder

2023-10-27 Thread Nagadheeraj Rottela
- The common code will be shared by both crypto and compress Nitrox PMD's. Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 1 + drivers/common/nitrox/meson.build | 35 +++ .../{crypto => common}/nitrox/nitrox_csr.h| 0 ..

[PATCH 0/7] add Nitrox compress device support

2023-10-27 Thread Nagadheeraj Rottela
Add the Nitrox PMD to support Nitrox compress device. Nagadheeraj Rottela (7): crypto/nitrox: move nitrox common code to common folder compress/nitrox: add nitrox compressdev driver common/nitrox: add compress hardware queue management crypto/nitrox: set queue type during queue pair setup

[PATCH] net/af_xdp: avoid error log for virtual interfaces

2023-10-27 Thread David Marchand
For virtual interfaces, like a veth or a tap used in OVS unit tests, plugging a af_xdp port on them results in an error level message: dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value /sys/class/net/ovs-tap1/device/numa_node netdev_dpdk|INFO|Device 'net_af_xdptap1,iface=ovs-t

RE: [EXT] [PATCH v2] app/dma-perf: fix lcores array out of bounds access

2023-10-27 Thread Gowrishankar Muthukrishnan
Looks good to me. Acked-by: Gowrishankar Muthukrishnan

[PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ciara Power
Previously some compilation errors existed when no openssl was installed on the system, and intel-ipsec-mb was installed, due to missing headers and macros. This patch fixes the issue by adding in extra ifdefs around openssl specific code paths, and by adding the relevant macros explicitly in QAT

RE: [PATCH v2] common/qat: limit configuration to the primary process

2023-10-27 Thread Power, Ciara
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, October 23, 2023 4:53 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > > Subject: [PATCH v2] common/qat: limit configuration to the primary process > > This change p

Re: [PATCH v1 1/3] dmadev: add inter-domain operations

2023-10-27 Thread Medvedkin, Vladimir
Hi Satananda, Anoob, Chengwen, Jerin, all, After a number of internal discussions we have decided that we're going to postpone this feature/patchset till next release. >[Satananda] Have you considered extending  rte_dma_port_param and rte_dma_vchan_conf to represent interdomain memory transfe

Re: [PATCH v4 00/24] add the NFP vDPA PMD

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 3:59 AM, Chaoyong He wrote: > This patch series aims to add the NFP vDPA PMD, we also grab the common > logic into the `drivers/common/nfp` directory. > > --- > v4: > * Try to fix compile error in clang environment. > * Merge the modify of release notes into suitable commit. > * Rewr

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Gupta, Nipun
On 10/26/2023 8:50 AM, Shubham Rohila wrote: Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx_vfio.c | 97 +++

Re: [PATCH v3 14/19] cryptodev: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/cryptodev/rte_cryptodev.c | 22 -- lib/cryptodev/rte_cryptodev.h | 16

Re: [PATCH v3 16/19] ethdev: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.h | 16 lib/ethdev/ethdev_private.c | 6 +++--- lib/ethdev/

Re: [PATCH v3 07/19] mbuf: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 ++-- lib/mbuf/rte_mbuf_core.h | 5 +++-- 2 files changed,

  1   2   >