Re: [PATCH 0/2] fix enable_stdatomic=true build with clang

2023-10-16 Thread David Marchand
On Mon, Oct 16, 2023 at 9:07 PM David Marchand wrote: > > On Mon, Oct 16, 2023 at 8:53 PM Tyler Retzlaff > wrote: > > > > We are temporarily exposed while the CI is enabled that tests > > CC=clang && -Denable_stdatomic. > > > > In the meantime two mistakes have been found so fix them to allow > >

RE: [EXT] Re: [PATCH v8 06/12] app/graph: add ipv4_lookup command line interfaces

2023-10-16 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Monday, October 16, 2023 9:18 PM > To: Sunil Kumar Kori > Cc: Rakesh Kudurumalla ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 06/12] app/graph: add ipv4_lookup command > line interfaces > > External Email > >

RE: [EXT] Re: [PATCH v8 05/12] app/graph: add ethdev command line interfaces

2023-10-16 Thread Sunil Kumar Kori
> -Original Message- > From: Bruce Richardson > Sent: Monday, October 16, 2023 7:41 PM > To: Jerin Jacob > Cc: Sunil Kumar Kori ; Rakesh Kudurumalla > ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 05/12] app/graph: add ethdev command line > interfaces > > External Email > >

RE: [EXT] Re: [PATCH v8 04/12] app/graph: add mempool command line interfaces

2023-10-16 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Monday, October 16, 2023 2:39 PM > To: Sunil Kumar Kori > Cc: Rakesh Kudurumalla ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 04/12] app/graph: add mempool command line > interfaces > > External Email > >

RE: [EXT] Re: [PATCH v8 02/12] app/graph: add telnet connectivity framework

2023-10-16 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Monday, October 16, 2023 2:34 PM > To: Sunil Kumar Kori > Cc: Rakesh Kudurumalla ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 02/12] app/graph: add telnet connectivity > framework > > External Email > > --

RE: [EXT] Re: [PATCH v8 01/12] app/graph: add application framework to read CLI

2023-10-16 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Monday, October 16, 2023 2:31 PM > To: Sunil Kumar Kori > Cc: Thomas Monjalon ; Rakesh Kudurumalla > ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 01/12] app/graph: add application framework > to read CLI > > External Email > > --

[PATCH] net/virtio: fixed missing next flag when sending packets in packed mode

2023-10-16 Thread liufengjiang.0426
When the packets is sent in packed mode, and the packets data and virtio-header are divided into two desc, set the next flag of virtio-header desc Bugzilla ID: 1295 Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") Signed-off-by: Fengjiang Liu --- drivers/net/virtio/virtqu

[PATCH 25/25] doc: add the common and vDPA document

2023-10-16 Thread Chaoyong He
Add the document for nfp common library and vDPA PMD. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- MAINTAINERS| 8 doc/guides/platform/index.rst | 1 + doc/guides/platform/nfp.rst| 30 ++ doc/gui

[PATCH 24/25] vdpa/nfp: add nfp vDPA device operations

2023-10-16 Thread Chaoyong He
Implement the corresponding nfp vDPA opetation functions. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 213 1 file changed, 213 insertions(+) diff --git a/drivers/vdp

[PATCH 23/25] vdpa/nfp: add the notify related logic

2023-10-16 Thread Chaoyong He
Add the logic to process vDPA notify relay. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 155 +++ drivers/vdpa/nfp/nfp_vdpa_core.c | 61 drivers/vdpa/nfp/nfp

[PATCH 22/25] drivers: add the datapath update logic

2023-10-16 Thread Chaoyong He
Add the vDPA datapath update logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 315 +++ drivers/vdpa/nfp/nfp_vdpa_core.c

[PATCH 21/25] vdpa/nfp: add the hardware init logic

2023-10-16 Thread Chaoyong He
Add the hardware initialize logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/meson.build | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 10 ++ drivers/vdpa/nfp/nfp_vdpa_core.c | 54 +

[PATCH 20/25] vdpa/nfp: add the logic of remap PCI memory

2023-10-16 Thread Chaoyong He
Add the logic of remap PCI memory. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 65 - 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp

[PATCH 19/25] drivers: add the basic framework of vDPA PMD

2023-10-16 Thread Chaoyong He
Add the basic framework of vDPA PMD. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_pci.c | 1 + drivers/common/nfp/nfp_common_pci.h | 1 + drivers/vdpa/nfp/meson.build| 7 ++ drivers/vdpa/nfp

[PATCH 18/25] drivers/vdpa: introduce the NFP vDPA library

2023-10-16 Thread Chaoyong He
Introduce the very basic NFP vDPA library. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/meson.build| 1 + drivers/vdpa/nfp/meson.build| 16 drivers/vdpa/nfp/nfp_vdpa_log.c | 9 + dri

[PATCH 17/25] drivers: move device module to common library

2023-10-16 Thread Chaoyong He
Move the device module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build| 1 + drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.c | 0 drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.h | 3 +++ d

[PATCH 16/25] drivers: move platform module to common library

2023-10-16 Thread Chaoyong He
Move the platform module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/{net/nfp/nfpcore => common/nfp}/nfp_platform.h | 0 drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 2 +- drivers/net/nfp/nfp_net_ctrl.c

[PATCH 15/25] drivers: move queue logic to common module

2023-10-16 Thread Chaoyong He
Move the queue enable/disable logic to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 49 drivers/common/nfp/nfp_common.h | 7 + drivers/common/nfp/version.map | 2 ++

[PATCH 14/25] drivers: add the nfp common module

2023-10-16 Thread Chaoyong He
Add the nfp common module in the nfp common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build | 3 +- drivers/common/nfp/nfp_common.c | 133 ++ drivers/common/nfp/nfp_common.h | 227

[PATCH 13/25] drivers: add the common ctrl module

2023-10-16 Thread Chaoyong He
Add the common ctrl module. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 374 +++ drivers/net/nfp/nfp_net_ctrl.h | 365 +- 2 files changed, 375 insertions(+), 364 deletio

[PATCH 11/25] net/nfp: extract the MAC address data field

2023-10-16 Thread Chaoyong He
Extract the 'mac_addr' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 14 +++--- drivers/net/nfp/nfp_ethdev_vf.c | 18 +- drivers/n

[PATCH 12/25] net/nfp: rename parameter in related logic

2023-10-16 Thread Chaoyong He
Rename parameter 'hw' into 'net_hw' in the related logic, to make the name more accurate. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 +- drivers/net/nfp/nfp_ethdev.c| 86 ++--- drivers/net/nfp/n

[PATCH 10/25] net/nfp: change the parameter of reconfig

2023-10-16 Thread Chaoyong He
Extract the 'reconfig_lock' data field into the super class, also change the parameter of the related APIs, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 50 + drivers/net/nfp/

[PATCH 09/25] net/nfp: change the parameter of APIs

2023-10-16 Thread Chaoyong He
Change the parameter of some APIs from 'struct nfp_net_hw' into the super class 'struct nfp_hw', prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 24 ++-- .../net/nfp/flower/nfp

[PATCH 08/25] net/nfp: extract the ctrl data field

2023-10-16 Thread Chaoyong He
Extract the 'ctrl' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 ++--- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 2 +- drivers/net/nfp/nfdk/nfp_nfdk_dp

[PATCH 07/25] net/nfp: extract the ctrl BAR data field

2023-10-16 Thread Chaoyong He
Extract the 'ctrl_bar' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 drivers/net/nfp/nfp_ethdev.c| 14 +++--- drivers/net/n

[PATCH 06/25] net/nfp: extract the qcp data field

2023-10-16 Thread Chaoyong He
Extract the 'qcp_cfg' data field into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 8 drivers/net/nfp/nfp_net_common.h | 2 +- 2 files changed, 5 insertions(+),

[PATCH 05/25] net/nfp: extract the cap data field

2023-10-16 Thread Chaoyong He
Extract the 'cap' data field into the super class, ready for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 6 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 10 +-- drivers/net/nfp/nfdk/nfp_nfdk_dp.c |

[PATCH 04/25] net/nfp: rename ctrl module name

2023-10-16 Thread Chaoyong He
Rename the 'nfp_ctrl' module into 'nfp_net_ctrl' module, because which is more suitable and we will add 'nfp_common_ctrl' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build| 2

[PATCH 03/25] net/nfp: rename common module name

2023-10-16 Thread Chaoyong He
Rename the 'nfp_common' module into 'nfp_net_common' module, because which is more suitable and we will add 'nfp_common' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.h

[PATCH 02/25] net/nfp: make VF PMD using of NFP common module

2023-10-16 Thread Chaoyong He
Modify the logic of NFP VF PMD, make it using of the NFP common module and link into the 'nfp_drivers_list'. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build | 6 +- drivers/net/nfp/nfp_ethdev_vf.c | 1

[PATCH 01/25] drivers: introduce the NFP common library

2023-10-16 Thread Chaoyong He
A new NFP vdpa PMD will be added to support vdpa operations by NFP adapters. This vdpa PMD share some logic with the net/nfp PMD. So create a new common library in drivers/common for NFP PMDs. We import a 'nfp_class_driver' layer and which can support various device type in addition to the ethern

[PATCH 00/25] add the NFP vDPA PMD

2023-10-16 Thread Chaoyong He
This patch series aims to add the NFP vDPA PMD, we also grab the common logic into the `drivers/common/nfp` directory. Chaoyong He (25): drivers: introduce the NFP common library net/nfp: make VF PMD using of NFP common module net/nfp: rename common module name net/nfp: rename ctrl module

[PATCH v2] doc: update feature list for idpf and cpfl

2023-10-16 Thread beilei . xing
From: Beilei Xing Add all supported features in idpf.ini and cpfl.ini. Signed-off-by: Beilei Xing --- V2 changes: - Add all supported features, not just RSS. doc/guides/nics/features/cpfl.ini | 10 ++ doc/guides/nics/features/idpf.ini | 9 + 2 files changed, 19 insertions(+)

Re: [PATCH v1 5/6] power: add eventdev support for power management

2023-10-16 Thread Jerin Jacob
On Tue, Oct 17, 2023 at 2:27 AM Sivaprasad Tummala wrote: > > Add eventdev support to enable power saving when no events > are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering > an architecture-defined optimized power state th

RE: [PATCH v1 5/6] power: add eventdev support for power management

2023-10-16 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] > -Original Message- > From: Tyler Retzlaff > Sent: Tuesday, October 17, 2023 5:21 AM > To: Tummala, Sivaprasad > Cc: jerinjac...@gmail.com; harry.van.haa...@intel.com; > anatoly.bura...@intel.com; dev@dpdk.org; Yigit, Ferruh ; > david.h...@intel.com > S

[PATCH] net/cpfl: fix memory leak

2023-10-16 Thread beilei . xing
From: Beilei Xing Fix resource leak reported in coverity scan. Coverity issue: 403265 Fixes: 2d823ecd671c ("net/cpfl: support device initialization") Fixes: 989465ac51ea ("net/cpfl: support probe again") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 5 +++

[PATCH] net/nfp: fix coredump problem when testpmd exit

2023-10-16 Thread Chaoyong He
The ".dev_close" should not call rte_eth_dev_release_port() API directly, the rte_eth_dev_close() API will do it. Fixes: 831c44ab7869 ("net/nfp: add flower PF related routines") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zh

[PATCH v4] net/iavf: support no data path polling mode

2023-10-16 Thread Mingjin Ye
Currently, during a PF to VF reset due to an action such as changing trust settings on a VF, the DPDK application running with iavf PMD loses connectivity, and the only solution is to reset the DPDK application. Instead of forcing a reset of the DPDK application to restore connectivity, the iavf P

[PATCH v4] net/iavf: support no data path polling mode

2023-10-16 Thread Mingjin Ye
Currently, during a PF to VF reset due to an action such as changing trust settings on a VF, the DPDK application running with iavf PMD loses connectivity, and the only solution is to reset the DPDK application. Instead of forcing a reset of the DPDK application to restore connectivity, the iavf P

[PATCH 3/3] app/testpmd: add port representor as sample destination

2023-10-16 Thread Suanming Mou
This commit adds the missing port representor support as sample destination. Signed-off-by: Suanming Mou --- app/test-pmd/cmdline_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 6c8571154e..0d521159e9 100644 --- a/app/tes

[PATCH 2/3] net/mlx5: add port representor destination to mirror

2023-10-16 Thread Suanming Mou
In order to clone the traffic from FDB to NIC TIR, user can set port representor action as mirror clone destination. In that case cloned traffic will be moved to E-Switch manager root table, and goes to software TIR. This commit adds the port representor support to mirror action. Signed-off-by: S

[PATCH 1/3] net/mlx5: add port representor action

2023-10-16 Thread Suanming Mou
The packets handled by port representor action will be steered to E-Switch manager and received by software. This commit adds port representor action. Signed-off-by: Suanming Mou --- doc/guides/nics/mlx5.rst| 6 drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow.h

[PATCH 0/3] net/mlx5: add port representor destination to mirror

2023-10-16 Thread Suanming Mou
In order to clone the traffic from FDB to NIC TIR, user can set port representor action as mirror clone destination. In that case cloned traffic will be moved to E-Switch manager root table, and goes to software TIR. This series adds the port representor support to mirror action. This series depen

Re: [PATCH v1 5/6] power: add eventdev support for power management

2023-10-16 Thread Tyler Retzlaff
On Mon, Oct 16, 2023 at 01:57:14PM -0700, Sivaprasad Tummala wrote: > Add eventdev support to enable power saving when no events > are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering > an architecture-defined optimized power s

Re: [PATCH v1 3/6] eventdev: support optional dequeue callbacks

2023-10-16 Thread Tyler Retzlaff
On Mon, Oct 16, 2023 at 01:57:12PM -0700, Sivaprasad Tummala wrote: > Add optional support for inline event processing within pmd dequeue > call. For a dequeue callback, events dequeued from the event port > were passed them to a callback function if configured, to allow > additional processing. e.

Re: [PATCH v1 2/6] event/sw: support power monitor

2023-10-16 Thread Tyler Retzlaff
On Mon, Oct 16, 2023 at 01:57:11PM -0700, Sivaprasad Tummala wrote: > Currently sw eventdev pmd does not support ``rte_power_monitor`` api. > This patch adds support by adding monitor callback that is called > whenever we enter sleep state and need to check if it is time to > wake up. > > Signed-o

[PATCH 21/21] ring: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.h | 2 +- lib/ring/rte_ring_c11_pvt.h | 33 + lib/ring/rte_ring_core.h

[PATCH 20/21] timer: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/timer/rte_timer.c | 50 +- lib/timer/rte_timer.h | 6 +++--- 2 files changed, 28 insertions(+), 2

[PATCH 14/21] telemetry: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/telemetry/telemetry.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telem

[PATCH 19/21] hash: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 116 ++--- lib/hash/rte_cuckoo_hash.h | 6 +-- 2 files changed, 61 insertions(+

[PATCH 13/21] stack: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack.h| 2 +- lib/stack/rte_stack_lf_c11.h | 24 lib/stack/rte_stack_lf_generic.h | 18 ++

[PATCH 17/21] distributor: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/distributor/distributor_private.h | 4 +-- lib/distributor/rte_distributor.c | 54 +-- 2 files changed, 29 in

[PATCH 12/21] pdump: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/pdump/rte_pdump.c | 14 +++--- lib/pdump/rte_pdump.h | 8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/p

[PATCH 11/21] rcu: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 48 +-- lib/rcu/rte_rcu_qsbr.h | 68 +- 2 fil

[PATCH 18/21] ethdev: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.h | 16 lib/ethdev/ethdev_private.c | 6 +++--- lib/ethdev/rte_ethdev.c | 24 --

[PATCH 15/21] vhost: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/vhost/vdpa.c| 3 ++- lib/vhost/vhost.c | 42 lib/vhost/vhost.h | 39

[PATCH 07/21] gpudev: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/gpudev/gpudev.c| 6 +++--- lib/gpudev/gpudev_driver.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/gpudev/gp

[PATCH 16/21] cryptodev: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/cryptodev/rte_cryptodev.c | 22 -- lib/cryptodev/rte_cryptodev.h | 16 2 files changed, 20 insertions(+), 18

[PATCH 09/21] mbuf: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 ++-- lib/mbuf/rte_mbuf_core.h | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 05/21] eal: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_launch.c| 10 +-- lib/eal/common/eal_common_mcfg.c | 2 +- lib/eal/common/eal_common_proc.c | 14 ++-- lib

[PATCH 10/21] mempool: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mempool/rte_mempool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.

[PATCH 08/21] ipsec: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ipsec/ipsec_sqn.h | 2 +- lib/ipsec/sa.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sqn.h b/lib

[PATCH 06/21] eventdev: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/event/cnxk/cnxk_tim_worker.h | 4 +-- lib/eventdev/rte_event_timer_adapter.c | 66 +- lib/eventdev/rte_even

[PATCH 04/21] bbdev: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/bbdev/rte_bbdev.c | 6 +++--- lib/bbdev/rte_bbdev.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b

[PATCH 03/21] power: use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/power/power_acpi_cpufreq.c | 33 + lib/power/power_cppc_cpufreq.c | 25 + lib/power/po

[PATCH 01/21] power: fix use of rte stdatomic

2023-10-16 Thread Tyler Retzlaff
* rte stdatomic functions operate on RTE_ATOMIC(T) specified types not regular T add missing specifier for amd_pstate_power_info state field * use rte_memory_order_xxx instead of __ATOMIC_XXX Fixes: 1ed04d33cf19 ("power: support amd-pstate cpufreq driver") Cc: sivaprasad.tumm...@amd.com Signed-

[PATCH 02/21] event/cnxk: remove single use of rte stdatomic

2023-10-16 Thread Tyler Retzlaff
The variable operated on by the single use of rte stdatomic was not RTE_ATOMIC(T) specified. Remove the use of stdatomic for now to fix LLVM build with enable_stdatomic=true. event/cnxk will be converted to rte stdatomic in a later series. Fixes: 14a4aa9eae71 ("event/cnxk: support get remaining ti

[PATCH 00/21] use rte optional stdatomic API

2023-10-16 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. Note the first 2 patches are redundant and will be removed before merge. The series is a work in progress and is being submitted to get initial CI results. Tyler Retzlaff (21): power

Re: [PATCH] net/gve: Update max_rx_pktlen to be based on MTU

2023-10-16 Thread Stephen Hemminger
On Mon, 16 Oct 2023 13:59:48 -0700 Joshua Washington wrote: > conjunction with the MTU fix, causes problems with testpmd, as setting the > packet length with the --max-pkt-len flag causes the MTU to be set > higher than possible due to underflow. > > As an example, setting --max-pkt-len=1460 (th

Re: [PATCH] net/gve: Update max_rx_pktlen to be based on MTU

2023-10-16 Thread Stephen Hemminger
On Mon, 16 Oct 2023 13:59:48 -0700 Joshua Washington wrote: > Before this patch, max_rx_pktlen was always set to UINT16_MAX. This, in > conjunction with the MTU fix, causes problems with testpmd, as setting the > packet length with the --max-pkt-len flag causes the MTU to be set > higher than pos

[PATCH] net/gve: Update max_rx_pktlen to be based on MTU

2023-10-16 Thread Joshua Washington
Before this patch, max_rx_pktlen was always set to UINT16_MAX. This, in conjunction with the MTU fix, causes problems with testpmd, as setting the packet length with the --max-pkt-len flag causes the MTU to be set higher than possible due to underflow. As an example, setting --max-pkt-len=1460 (th

[PATCH v1 5/6] power: add eventdev support for power management

2023-10-16 Thread Sivaprasad Tummala
Add eventdev support to enable power saving when no events are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or when events arr

[PATCH v1 6/6] examples/eventdev_p: add eventdev power management

2023-10-16 Thread Sivaprasad Tummala
Add power management feature support to eventdev_pipeline sample app. A new command option "--pmd-mgmt" was added to select power management mode on worker cores. Options currently supported are "pause/monitor". Default, no power management features are enabled on the worker ports. Signed-off-by:

[PATCH v1 3/6] eventdev: support optional dequeue callbacks

2023-10-16 Thread Sivaprasad Tummala
Add optional support for inline event processing within pmd dequeue call. For a dequeue callback, events dequeued from the event port were passed them to a callback function if configured, to allow additional processing. e.g. unpack batch of packets from each event on dequeue, before passing back t

[PATCH v1 4/6] event/sw: support optional dequeue callbacks

2023-10-16 Thread Sivaprasad Tummala
This patch adds support for an event dequeue callbacks when configured to allow additional processing, power management (frequency scaling, monitor/sleep etc.,) and soon. Signed-off-by: Sivaprasad Tummala --- config/rte_config.h| 3 +++ drivers/event/sw/sw_evdev_worker.c | 5

[PATCH v1 2/6] event/sw: support power monitor

2023-10-16 Thread Sivaprasad Tummala
Currently sw eventdev pmd does not support ``rte_power_monitor`` api. This patch adds support by adding monitor callback that is called whenever we enter sleep state and need to check if it is time to wake up. Signed-off-by: Sivaprasad Tummala --- drivers/event/sw/sw_evdev.c| 1 + drive

[PATCH v1 1/6] eventdev: add power monitoring API on event port

2023-10-16 Thread Sivaprasad Tummala
A new API to allow power monitoring condition on event port to optimize power when no events are arriving on an event port for the worker core to process in an eventdev based pipelined application. Signed-off-by: Sivaprasad Tummala --- lib/eventdev/eventdev_pmd.h | 22 ++ lib

Re: [PATCH 0/2] fix enable_stdatomic=true build with clang

2023-10-16 Thread David Marchand
On Mon, Oct 16, 2023 at 8:53 PM Tyler Retzlaff wrote: > > We are temporarily exposed while the CI is enabled that tests > CC=clang && -Denable_stdatomic. > > In the meantime two mistakes have been found so fix them to allow > the CI to be enabled. > > Tyler Retzlaff (2): > power: fix use of rte

[PATCH 2/2] event/cnxk: remove single use of rte stdatomic

2023-10-16 Thread Tyler Retzlaff
The variable operated on by the single use of rte stdatomic was not RTE_ATOMIC(T) specified. Remove the use of stdatomic for now to fix LLVM build with enable_stdatomic=true. event/cnxk will be converted to rte stdatomic in a later series. Fixes: 14a4aa9eae71 ("event/cnxk: support get remaining ti

[PATCH 1/2] power: fix use of rte stdatomic

2023-10-16 Thread Tyler Retzlaff
* rte stdatomic functions operate on RTE_ATOMIC(T) specified types not regular T add missing specifier for amd_pstate_power_info state field * use rte_memory_order_xxx instead of __ATOMIC_XXX Fixes: 1ed04d33cf19 ("power: support amd-pstate cpufreq driver") Cc: sivaprasad.tumm...@amd.com Signed-

[PATCH 0/2] fix enable_stdatomic=true build with clang

2023-10-16 Thread Tyler Retzlaff
We are temporarily exposed while the CI is enabled that tests CC=clang && -Denable_stdatomic. In the meantime two mistakes have been found so fix them to allow the CI to be enabled. Tyler Retzlaff (2): power: fix use of rte stdatomic event/cnxk: remove single use of rte stdatomic drivers/ev

[PATCH v2 16/16] net/mlx5: fix METER_MARK indirection list callback

2023-10-16 Thread Gregory Etelson
Indirect action list METER_MARK handle and configuration parameters can be independently masked or non-masked in actions template. Non-masked configuration state is saved in the `mlx5_action_construct_data::shared_meter` object. The patch moves indirect action list callback from `mlx5_action_const

[PATCH v2 15/16] net/mlx5: support indirect list METER_MARK action

2023-10-16 Thread Gregory Etelson
Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.c| 69 +- drivers/net/mlx5/mlx5_flow.h| 67 - drivers/net/mlx5/mlx5_flow_hw.c | 427 +++- 3 files changed, 482 insertions(+), 81 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/dr

[PATCH v2 14/16] net/mlx5: fix mirror redirect action

2023-10-16 Thread Gregory Etelson
PMD used a buffer located on expired stack to store mirror reformat data. The patch moves reformat buffer to the same context as the mirror action creation. Fixes: 0284c9b82ee8 ("net/mlx5: support HWS mirror action") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c | 17 ++

[PATCH v2 13/16] net/mlx5: fix RTE action location tracking in a template

2023-10-16 Thread Gregory Etelson
PMD can implicitly add flow actions to application actions template. If PMD added actions to a template is must track location of the original application actions in modified template. The patch adds tracking ability for the orignal acton in a template. Fixes: ddb68e4 ("net/mlx5: add extended met

[PATCH v2 12/16] net/mlx5: refactor HWS code

2023-10-16 Thread Gregory Etelson
1. In `rte_flow_actions_template`, rename `actions_off` into `dr_off`. 2. Remove duplicated code in template table creation. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.h| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 117 ++-- 2 files changed, 52 in

[PATCH v2 11/16] net/mlx5: fix modify field expansion for raw DECAP / ENCAP

2023-10-16 Thread Gregory Etelson
Flow actions in HWS actions template must be arranged according to pre-defined order. MLX5 PMD handles RAW_DECAP / RAW_ENCAP actions sequence as a single RAW ENCAP or DECAP flow action. When the PMD scanned flow actions to locate position where MODIFY_FIELD action could be inserted it processed t

[PATCH v2 10/16] net/mlx5: fix in shared counter and age template action create

2023-10-16 Thread Gregory Etelson
Count and age actions in HWS template are translated into the same DR5 action. PMD maintains dedicated variable - `cnt_off`, that points action location in DR5 array. Currnet PMD did not initialize the `cnt_off` variable during shared counter / age actions initialization. Fixes: feb1f2fe2b76 ("ne

[PATCH v2 09/16] net/mlx5: fix mirror action validation

2023-10-16 Thread Gregory Etelson
HWS mirror flow action validation rejected flows in NIC domain, if PMD FDB mode was active. The patch allows NIC mirror action in FDB mode. Fixes: 0284c9b82ee8 ("net/mlx5: support HWS mirror action") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c | 20 +--- 1

[PATCH v2 08/16] net/mlx5: support HWS mirror action

2023-10-16 Thread Gregory Etelson
HWS mirror clones original packet to one or two destinations and proceeds with the original packet path. The mirror has no dedicated RTE flow action type. Mirror object is referenced by INDIRECT_LIST action. INDIRECT_LIST for a mirror built from actions list: SAMPLE [/ SAMPLE] / / END Mirro

[PATCH v2 07/16] net/mlx5: reformat HWS code

2023-10-16 Thread Gregory Etelson
Replace if() with switch(). Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c | 70 ++--- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6fcf654e4a..b2215fb5cf 10

[PATCH v2 06/16] net/mlx5/hws: support reformat for hws mirror

2023-10-16 Thread Gregory Etelson
From: Haifei Luo In dest_array action, an optional reformat action can be applied to each destination. This patch supports this by using the extended destination entry. Signed-off-by: Haifei Luo Signed-off-by: Shun Hao --- drivers/common/mlx5/mlx5_prm.h | 15 +++ drivers/net/mlx5/hw

[PATCH v2 04/16] net/mlx5/hws: add support for mirroring

2023-10-16 Thread Gregory Etelson
From: Shun Hao This patch supports mirroring by adding an dest_array action. The action accecpts a list containing multiple destination actions, and can duplicate packet and forward to each destination in the list. Signed-off-by: Shun Hao Acked-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm

[PATCH v2 05/16] net/mlx5/hws: allow destination into default miss FT

2023-10-16 Thread Gregory Etelson
From: Erez Shitrit In FDB it will direct the packet into the hypervisor vport. That allows the user to mirror packets into the default-miss vport. Signed-off-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_action.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/m

[PATCH v2 03/16] net/mlx5/hws: add mlx5dr DevX object struct to mlx5dr action

2023-10-16 Thread Gregory Etelson
From: Hamdan Igbaria Add mlx5dr_devx_obj struct to mlx5dr_action, so we could hold the FT obj in dest table action. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 drivers/net/mlx5/hws/mlx5dr_action.h | 3 +++ drivers/net/mlx5/hws/mlx5dr_table.c | 1 - 3 files

[PATCH v2 02/16] net/mlx5/hws: support creating of dynamic forward table and FTE

2023-10-16 Thread Gregory Etelson
From: Hamdan Igbaria Add the ability to create forward table and FTE. Signed-off-by: Hamdan Igbaria --- drivers/common/mlx5/mlx5_prm.h| 4 drivers/net/mlx5/hws/mlx5dr_cmd.c | 13 + drivers/net/mlx5/hws/mlx5dr_cmd.h | 19 +++ 3 files changed, 36 insertions(

[PATCH v2 01/16] net/mlx5/hws: add support for reformat DevX object

2023-10-16 Thread Gregory Etelson
From: Hamdan Igbaria Add support for creation of packet reformat object, via the ALLOC_PACKET_REFORMAT_CONTEXT command. Signed-off-by: Hamdan Igbaria --- drivers/common/mlx5/mlx5_prm.h | 39 + drivers/net/mlx5/hws/mlx5dr_cmd.c | 60 ++ drive

Re: [PATCH v3 00/11] Unify the PMD coding style

2023-10-16 Thread Ferruh Yigit
On 10/13/2023 7:06 AM, Chaoyong He wrote: > This patch series aims to unify the coding style of NFP PMD, make the > logics following the same rules, to make it easier to understand and > extend. > Also prepare for the upcoming vDPA PMD patch series. > > --- > v2: > * Add some missing modification.

Re: [PATCH v3 11/11] net/nfp: refact the meson build file

2023-10-16 Thread Ferruh Yigit
On 10/13/2023 7:06 AM, Chaoyong He wrote: > Make the source files follow the alphabeta sequence. > Also update the copyright header line. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > drivers/net/nfp/meson.build | 23 --- > 1 file c

  1   2   >